[libvirt] [PATCH v6 1/3] qmp: rename query_option_descs() to get_param_info()

Signed-off-by: Amos Kong Reviewed-by: Eric Blake --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index f610101..508adbc 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsLi

[libvirt] [PATCH v6 0/3] fix query-command-line-options

This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 https

Re: [libvirt] [PATCH] Fix Memory Leak in testGetCaps()

On 03/26/2014 11:37 PM, Nehal J Wani wrote: > While running qemucaps2xmltest, it was found that valgrind pointed out > the following memory leaks: > > ==27045== 160 (112 direct, 48 indirect) bytes in 1 blocks are definitely lost > in loss record 51 of 65 > ==27045==at 0x4A0577B: calloc (vg_re

[libvirt] [PATCH] Modify help information of virsh list command

Use 'virsh list domain --title' option can get domain's title, not description, the original help information 'show short domain description' will confuse users, so modify it to 'show domain title' Signed-off-by: Li Yang --- tools/virsh-domain-monitor.c |2 +- 1 files changed, 1 insertions(+

[libvirt] [PATCH] util: fix a typo in virprocess.c

s/forcably/forcibly Signed-off-by: Hongwei Bi --- src/util/virprocess.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 405ad06..9179d73 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -283,7 +283,7 @@ i

Re: [libvirt] [PATCH v3 1/2] Move virBhyveTapGetRealDeviceName to virnetdevtap

Ján Tomko wrote: > ACK Fixed headers grouping and spurious blank line and pushed, thanks! Roman Bogorodskiy -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 2/2] bhyve: add xml2args unittest

Ján Tomko wrote: > > +static virCapsPtr > > +testBhyveBuildCapabilities(void) > > +{ > > +virCapsPtr caps; > > +virCapsGuestPtr guest; > > + > > +if ((caps = virCapabilitiesNew(virArchFromHost(), > > Getting the arch from the host seems wrong in a test, but it seems the bhyve > driv

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

On Thu, Mar 20, 2014 at 10:12:43PM +0800, Amos Kong wrote: > On Tue, Mar 11, 2014 at 10:04:56AM +0100, Markus Armbruster wrote: > > Eric Blake writes: > > > > > On 03/07/2014 02:54 AM, Markus Armbruster wrote: > > >> Eric Blake writes: > > >> > > >>> On 03/05/2014 07:36 PM, Amos Kong wrote: > >

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

On Wed, Mar 26, 2014 at 02:15:18PM +0100, Markus Armbruster wrote: > Amos Kong writes: > > > On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > On 03/05/2014 07:36 PM, Amos Kong wrote: > >> >> vm_config_groups[] only contains part of the optio

Re: [libvirt] [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

On Thu, Mar 27, 2014 at 10:16:44AM +0800, Amos Kong wrote: > On Wed, Mar 26, 2014 at 05:12:08PM +0100, Markus Armbruster wrote: > > Eric Blake writes: ... > > > Reviewed-by: Eric Blake > > > > I'm not thrilled about the ABI break, but avoiding it would probably > > take too much code for too li

Re: [libvirt] is there a way to convert vm's filter into comandline

On 03/26/2014 08:43 PM, Eric Blake wrote: > On 03/26/2014 07:20 PM, bigclouds wrote: >> hi,all >> >> is there a way to convert vm's filter into comandline, i think it is useful. > > You mean, as in > virsh domxml-to-native qemu-argv $(virsh dumpxml $dom) Correction: virsh dumpxml $dom > file

Re: [libvirt] is there a way to convert vm's filter into comandline

On 03/26/2014 07:20 PM, bigclouds wrote: > hi,all > > is there a way to convert vm's filter into comandline, i think it is useful. You mean, as in virsh domxml-to-native qemu-argv $(virsh dumpxml $dom) or are you asking about the nwfilter settings applied on behalf of a guest? -- Eric Blake

[libvirt] [PATCH 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

Signed-off-by: Amos Kong --- vl.c | 4 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index 2355227..596ecfa 100644 --- a/vl.c +++ b/vl.c @@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = { }, }; +#ifdef CONFIG_TPM static QemuOptsList qemu_tpmdev_opts = { .n

[libvirt] [PATCH 2/3] abort QEMU if group name in option table doesn't match with defined option name

All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from 2.0 Signed-off-by: Amos Kong --- qemu-options.h | 12 util/qemu-config.c

[libvirt] [PATCH 3/3] update names in option tables to match with actual command-line spelling

We want to establish a mapping between option name and option table, then we can search related option table by option name. This patch makes all the member name of QemuOptsList to match with actual command-line spelling(option name). [ Important Note ] The QemuOptsList member name values are AB

[libvirt] [PATCH 0/3] ABI change: change group name of option table to match with option name

This patchset changes group names of option tables to match with option name, this breakes ABI, release note was updated. Amos Kong (3): only add qemu_tpmdev_opts when CONFIG_TPM is defined abort QEMU if group name in option table doesn't match with defined option name update names in op

Re: [libvirt] how libvirt know the hostname of vm

On 03/26/2014 07:16 PM, bigclouds wrote: > hi,all > i recently notice that virt-manager show the hostname of vm, i am curious > about that, that is the implementation? That's a question better asked on the virt-manager list (http://www.redhat.com/mailman/listinfo/virt-tools-list), as libvirt is n

Re: [libvirt] [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

On Wed, Mar 26, 2014 at 05:12:08PM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 03/20/2014 07:07 AM, Amos Kong wrote: > >> We want to establish a mapping between option name and option table, > >> then we can search related option table by option name. > >> > >> This patch makes

[libvirt] is there a way to convert vm's filter into comandline

hi,all is there a way to convert vm's filter into comandline, i think it is useful. if there is the functionality, so you think it is worthy to be done. thanks-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] how libvirt know the hostname of vm

hi,all i recently notice that virt-manager show the hostname of vm, i am curious about that, that is the implementation? thanks-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/n] conf: split network host structs to util/

Continuing the refactoring of host-side storage descriptions out of conf/domain_conf and into util/virstoragefile, this patch focuses on details about a host name/port/transport as used by a network storage volume. * src/conf/domain_conf.h (virDomainDiskProtocolTransport) (virDomainDiskHostDef, vi

[libvirt] [PATCH 1/n] conf: split security label structs to util/

In order to reuse the newly-created host-side disk struct in the virstoragefile backing chain code, I first have to move it to util/. This starts the process, by first moving the security label structures. * src/conf/domain_conf.h (virDomainDefGenSecurityLabelDef) (virDomainDiskDefGenSecurityLabe

[libvirt] [PATCH 0/n] round 2 of storage chain refactoring

In round 1, I split out a new struct in domain_conf.h. This starts round 2: moving the struct into util/virstoragefile.h, so it can be shared by domain, snapshot, and existing virstoragefile backing chain operations. It's turned out to be a bigger process than I first thought, so I've tried split

[libvirt] [PATCH] Fix Memory Leak in testGetCaps()

While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==27045== 160 (112 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 51 of 65 ==27045==at 0x4A0577B: calloc (vg_replace_malloc.c:593) ==27045==by 0x4C6BACD: virAllocV

[libvirt] [PATCH v4 5/5] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

These are exposed under domfsfreeze command and domfsthaw command. Signed-off-by: Tomoki Sekiyama --- tools/virsh-domain.c | 92 ++ tools/virsh.pod | 15 2 files changed, 107 insertions(+) diff --git a/tools/virsh-domain.c b/tool

[libvirt] [PATCH v4 1/5] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

These will freeze and thaw filesystems within guest. The APIs take @flags arguments which are currently not used, for future extensions. Signed-off-by: Tomoki Sekiyama --- include/libvirt/libvirt.h.in |6 src/driver.h | 10 ++ src/libvirt.c| 70 ++

[libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

Hello, This is patchset v4 to add FSFreeze/FSThaw API for custom disk snapshotting. Changes to v3: * fix typp and label spacing * rebased to recent tree (v3: http://www.redhat.com/archives/libvir-list/2014-March/msg01358.html ) === Description === Currently FSFreeze and FSThaw are supported

[libvirt] [PATCH v4 4/5] qemu: Implement virDomainFSFreeze and virDomainFSThaw

Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFreeze() which are already implemented for snapshot quiescing. Signed-off-by: Tomoki Sekiyama --- src/qemu/qemu_driver.c | 78 1 file changed, 78 insertions(+) diff --git a/src/qemu/qemu_

[libvirt] [PATCH v4 3/5] qemu: Track domain quiesced status

Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest filesystems of the domain is quiesced or not. It also modify error code from qemuDomainSnapshotFSFreeze and qemuDomainSnapshotFSThaw, so that a caller can know whether the command is actually sent to the guest agent. If the

[libvirt] [PATCH v4 2/5] remote: Implement virDomainFSFreeze and virDomainFSThaw

New rules are added in fixup_name in gendispatch.pl to keep the name FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze', which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag. Signed-off-by: Tomoki Sekiyama --- src/access/viraccessperm.c |2 +- src/access/viraccessp

[libvirt] [TCK] nwfilter tests and libvirt commit 4f209434

Hi, As I've been looking through libvirt-tck tests, I found that commit 4f209434 (in libvirt) changes a condition that the nwfilter/050-apply-verify-host.t relies on. Specifically, the 050-apply-verify-host.t test creates a number of filters with invalid values (such as dscp='64', and protocol

[libvirt] [PATCH v2] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 ==29896==at 0x4A0577B: calloc (vg_replace_malloc.c:593) ==29896==by 0x4C6B45E: virAllocN (viralloc.c:191) ==29896==

Re: [libvirt] Crash when using python-libvirt setSchedulerParameters

On 3/25/2014 6:50 AM, Michal Privoznik wrote: On 24.03.2014 21:45, Brian Rak wrote: I'm seeing a very weird (and somewhat reproducable) crash in setSchedulerParameters. The backtrace looks like this: *** glibc detected *** python2.7: free(): invalid pointer: 0x0152bc48 *** === Back

Re: [libvirt] [PATCH v3 2/2] bhyve: add xml2args unittest

On 03/26/2014 05:53 PM, Roman Bogorodskiy wrote: > At this point unittest covers 4 basic cases: > > - minimal working XML for bhyve > - same as above, but with virtio disk > - ACPI and APIC args test > - MAC address test > --- > tests/Makefile.am | 26 >

Re: [libvirt] [PATCH v3 1/2] Move virBhyveTapGetRealDeviceName to virnetdevtap

On 03/26/2014 05:53 PM, Roman Bogorodskiy wrote: > To ease mocking for bhyve unit tests move virBhyveTapGetRealDeviceName() > out of bhyve_command.c to virnetdevtap and rename it to > virNetDevTapGetRealDeviceName(). > --- > src/bhyve/bhyve_command.c | 74 +--- >

Re: [libvirt] [PATCH] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

On Thu, Mar 27, 2014 at 12:00:49AM +0530, Nehal J Wani wrote: > While running qemucaps2xmltest, it was found that valgrind pointed out > the following memory leaks: > > ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 > ==29896==at 0x4A0577B: calloc (vg_replace_malloc.c

[libvirt] [PATCH] Fix Memory Leak in virQEMUCapsInitGuestFromBinary()

While running qemucaps2xmltest, it was found that valgrind pointed out the following memory leaks: ==29896== 0 bytes in 1 blocks are definitely lost in loss record 1 of 65 ==29896==at 0x4A0577B: calloc (vg_replace_malloc.c:593) ==29896==by 0x4C6B45E: virAllocN (viralloc.c:191) ==29896==

[libvirt] [PATCH v3 2/2] bhyve: add xml2args unittest

At this point unittest covers 4 basic cases: - minimal working XML for bhyve - same as above, but with virtio disk - ACPI and APIC args test - MAC address test --- tests/Makefile.am | 26 .../bhyvexml2argvdata/bhyvexml2argv-acpiapic.args | 3 + tests/

[libvirt] [PATCH v3 1/2] Move virBhyveTapGetRealDeviceName to virnetdevtap

To ease mocking for bhyve unit tests move virBhyveTapGetRealDeviceName() out of bhyve_command.c to virnetdevtap and rename it to virNetDevTapGetRealDeviceName(). --- src/bhyve/bhyve_command.c | 74 +--- src/libvirt_private.syms | 1 + src/util/virnetdevtap.c

[libvirt] [PATCH v3 0/2] bhyve: add xml2args unittest

Changes from v2: - Make virBhyveTapGetRealDeviceName a stub on non-FreeBSD - Add bhyvexml2argvdata and bhyvexml2argvmock.c to EXTRA_DIST - Include bhyve headers in tests only if WITH_BHYVE is defined - Don't use 'util/' for #include when not needed Changes from v1: - Chase MAC address support

Re: [libvirt] [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

Eric Blake writes: > On 03/20/2014 07:07 AM, Amos Kong wrote: >> We want to establish a mapping between option name and option table, >> then we can search related option table by option name. >> >> This patch makes all the member name of QemuOptsList to match with >> actual command-line spellin

Re: [libvirt] [PATCH] security_dac: Honor norelabel attribute

On Mon, Mar 24, 2014 at 17:37:07 +0100, Michal Privoznik wrote: > The inspiration for this patch comes from a question on the list > asking if there's a way to not label some disks. Well, in DAC driver > there's not. Even if user have requested norelabel: > > > > > >

[libvirt] [PATCH] cpu: Properly check input parameters

Most of the APIs in CPU driver do not expect to get NULL for input parameters. Let's mark them with ATTRIBUTE_NONNULL and also check for some members of virCPUDef when the APIs expect them have some specific values. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 48

Re: [libvirt] [PATCH v2] dnsmasq: allowing RFC 2782 compliant SRV records

On 03/08/2014 01:13 AM, Steven Malin wrote: > This patch allows RFC 2782 compliant SRV records in the network > config and corrects the documentation. Thanks for bringing this bug to light in such a proactive way (with a patch rather than just a complaint :-)). Your patch pointed out that the SRV

[libvirt] [PATCH] cpu: Add documentation for CPU driver APIs

Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 202 ++ 1 file changed, 202 insertions(+) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index e91f5bb..9cd2300 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -77,6 +77,19 @@ cpuGetSubDriver(v

Re: [libvirt] [libvirt-java] [PATCH 35/65] Fix memleak in StorageVol.getXMLDesc

At Fri, 21 Feb 2014 10:59:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:43PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StorageVol.java |8 +++- > > src/main/java/org/libvirt/jna/Libvirt.java |2 +- >

Re: [libvirt] [PATCH 0/5] virCommandRunRegex cleanups

On 03/26/2014 02:20 PM, Michal Privoznik wrote: > On 25.03.2014 08:17, Ján Tomko wrote: >> Simplify the code. This should have no functional change >> (except for the impossible leak fix in 3/5). Most of this >> functionality is tested in viriscsitest. >> >> Ján Tomko (5): >>Remove useless 'max

Re: [libvirt] [PATCH 0/5] virCommandRunRegex cleanups

On 25.03.2014 08:17, Ján Tomko wrote: Simplify the code. This should have no functional change (except for the impossible leak fix in 3/5). Most of this functionality is tested in viriscsitest. Ján Tomko (5): Remove useless 'maxReg' variable Simplify the loop in virCommandRunRegex Free

Re: [libvirt] [libvirt-java] [PATCH 33/65] Fix memleak in DomainSnapshot.getXMLDesc

At Fri, 21 Feb 2014 10:59:02 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:41PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/DomainSnapshot.java | 10 +- > > src/main/java/org/libvirt/jna/Libvirt.java|

Re: [libvirt] [libvirt-java] [PATCH 00/65]

At Fri, 21 Feb 2014 11:21:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > > Hi. > > > > Here are a few patches that piled up in my local branch. Some of them > > I already submitted to this list, but there has been no reponse to > > them. >

Re: [libvirt] [libvirt-java] [PATCH 34/65] Fix memleak in StorageVol.getPath

At Fri, 21 Feb 2014 10:59:25 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:42PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StorageVol.java | 10 +- > > src/main/java/org/libvirt/jna/Libvirt.java |2 +-

Re: [libvirt] [libvirt-java] [PATCH 08/65] Depend on JNA versions 3.4.1 to 4.0.0

At Fri, 21 Feb 2014 10:36:10 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:16PM +0100, Claudio Bley wrote: > > Specify a version range for the net.java.dev.jna / jna artifact > > in order to accept any version we tested the libvirt Java bindings > > against. > > > > Signed-of

Re: [libvirt] [libvirt-java] [PATCH 32/65] Fix memleak in StoragePool.listVolumes

At Fri, 21 Feb 2014 10:58:35 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:40PM +0100, Claudio Bley wrote: > > We need to free the char* entries of the result array returned > > ourselves. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StoragePool

Re: [libvirt] [RFC] VM which uses macvtap will not respond ping request when being migrated

On 03/25/2014 07:15 AM, Wangrui (K) wrote: > macvtap0 is belong to vm at the dest side. When migrate begins macvtap0 will > send the packet like this: > > 07:57:59.233270 IP6 :: > ff02::16: HBH ICMP6, multicast listener report v2, 1 > group record(s), lengt 28 > 07:58:00.096088 I

Re: [libvirt] [libvirt-java] [PATCH 31/65] Fix memleak in Domain.snapshotListNames

eAt Fri, 21 Feb 2014 10:57:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:39PM +0100, Claudio Bley wrote: > > We need to free the char* entries of the result array returned ourselves. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Domain.java

Re: [libvirt] [libvirt-java] [PATCH 30/65] Fix Domain.getSchedulerParameters / getSchedulerType

At Fri, 21 Feb 2014 10:57:10 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:38PM +0100, Claudio Bley wrote: > > The getSchedulerType method returns a String (the name of the > > scheduler), not a String array containing a single element. > > > > It's OK to just pass null for t

Re: [libvirt] [libvirt-java] [PATCH 23/65] Remove processError method from StoragePool class

At Fri, 21 Feb 2014 10:49:15 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:31PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Adjust the doc comment for storageVolLookupByName to indicate that > > it

Re: [libvirt] [libvirt-java] [PATCH 28/65] Remove ErrorHandler.processError(Libvirt) method

At Fri, 21 Feb 2014 10:51:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:36PM +0100, Claudio Bley wrote: > > It was deprecated and is no longer used. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/ErrorHandler.java | 12 > > 1 fil

Re: [libvirt] [libvirt-java] [PATCH 26/65] Remove processError method from Connect class

At Fri, 21 Feb 2014 10:50:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:34PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..) and remove calls to the deprecated > > ErrorHandler.processError(Libvirt) method. >

Re: [libvirt] [libvirt-java] [PATCH 20/65] Remove processError method from Network class

At Fri, 21 Feb 2014 10:45:55 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:28PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 27/65] Call processError only when virInitialize signalled an error

At Fri, 21 Feb 2014 10:50:57 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:35PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Library.java |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ACK Thank

Re: [libvirt] [libvirt-java] [PATCH 25/65] Remove processError method from Stream class

At Fri, 21 Feb 2014 10:49:52 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:33PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 24/65] Remove processError method from StorageVol class

At Fri, 21 Feb 2014 10:49:33 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:32PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 22/65] Remove processError method from Secret class

At Fri, 21 Feb 2014 10:48:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:30PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 19/65] Remove processError from Interface class

At Fri, 21 Feb 2014 10:45:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:27PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 21/65] Remove processError method from NetworkFilter class

At Fri, 21 Feb 2014 10:46:19 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:29PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 16/65] Remove processError from Device class

At Fri, 21 Feb 2014 10:43:43 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:24PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Devic

Re: [libvirt] [libvirt-java] [PATCH 15/65] Start refactoring of error handling

At Fri, 21 Feb 2014 10:43:15 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:23PM +0100, Claudio Bley wrote: > > Almost every class contains a processError() method with an identical > > definition, just forwarding the call to ErrorHandler.processError(Libvirt). > > > > This fu

Re: [libvirt] [libvirt-java] [PATCH 18/65] Remove processError from DomainSnapshot class

At Fri, 21 Feb 2014 10:45:01 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:26PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 17/65] Remove processError from Domain class

At Fri, 21 Feb 2014 10:44:42 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:25PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also update erroneous javadoc comments stating that methods would return

Re: [libvirt] [libvirt-java] [PATCH 14/65] test: ensure the Device.listCapabilities method works

At Fri, 21 Feb 2014 10:42:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:22PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java | 14 ++ > > 1 file changed, 14 insertions(+) > > ACK T

Re: [libvirt] [libvirt-java] [PATCH 13/65] Make Device.listCapabilities return only valid array elements

At Fri, 21 Feb 2014 10:41:35 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:21PM +0100, Claudio Bley wrote: > > The libvirt function virNodeDeviceListCaps might return fewer elements > > than requested. Take this into account and properly decode the UTF-8 > > strings returned.

Re: [libvirt] [libvirt-java] [PATCH 10/65] Fix wrapping of native size_t data type

At Fri, 21 Feb 2014 14:42:26 +0100, Claudio Bley wrote: > > At Fri, 21 Feb 2014 10:37:36 +, > Daniel P. Berrange wrote: > > > > On Thu, Feb 13, 2014 at 04:22:18PM +0100, Claudio Bley wrote: > > > Libvirt function parameters having type (pointer to) size_t were > > > wrapped via JNA using int,

Re: [libvirt] [libvirt-java] [PATCH 12/65] tests: remove obsolete test driver

At Fri, 21 Feb 2014 10:40:46 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:20PM +0100, Claudio Bley wrote: > > JUnit is used for quite some time now, which supercedes the tests > > defined in the old "test" class. > > > > Signed-off-by: Claudio Bley > > --- > > src/test/jav

Re: [libvirt] [libvirt-java] [PATCH 09/65] jna: load virt-0 or virt library depending on the platform

At Fri, 21 Feb 2014 10:36:33 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:17PM +0100, Claudio Bley wrote: > > On Windows, the libvirt DLL is called libvirt-0.dll. Trying to load > > the "virt" library hence fails to find the file. Branch on the platform > > and load "virt-0"

Re: [libvirt] [libvirt-java] [PATCH 07/65] Ignore editor backup files

At Fri, 21 Feb 2014 10:35:42 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > .gitignore |2 ++ > > 1 file changed, 2 insertions(+) > > ACK. Counts as a trivial patch that can be pushed withou

Re: [libvirt] [libvirt-java] [PATCH 06/65] Make comments proper javadoc comments for enum constants

At Fri, 21 Feb 2014 10:35:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Error.java | 397 > > ++ > > 1 file changed, 262 insertions

Re: [libvirt] [libvirt-java] [PATCH 05/65] test: ensure that exceptions are thrown when expected

At Fri, 21 Feb 2014 10:34:52 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java |2 ++ > > 1 file changed, 2 insertions(+) > > ACK Thanks, pushed

Re: [libvirt] [libvirt-java] [PATCH 04/65] test: fix typo in testConnection()

At Fri, 21 Feb 2014 10:34:24 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:12PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > ACK

Re: [libvirt] [libvirt-java] [PATCH 03/65] Fix typos in Error.java

At Fri, 21 Feb 2014 10:34:05 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:11PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Error.java |6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > ACK Thank

Re: [libvirt] [libvirt-java] [PATCH 01/65] Fix warnings about using raw types

At Fri, 21 Feb 2014 10:32:08 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote: > > Eclipse generates this kind of warning: > > > > org/libvirt/jna/virConnectCredential.java:20: > > List is a raw type. References to generic type List should be > >

Re: [libvirt] [libvirt-java] [PATCH 02/65] Fix warnings about accessing static methods

At Fri, 21 Feb 2014 10:33:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote: > > java/org/libvirt/Error.java:217: > > The static method wrap(int) from the type Error.ErrorDomain should be > > accessed in a static way > > > > Signed-off-by: Claudi

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

Amos Kong writes: > On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 03/05/2014 07:36 PM, Amos Kong wrote: >> >> vm_config_groups[] only contains part of the options which have >> >> argument, and all options which have no argument aren't added

Re: [libvirt] [PATCH 2/3] qemu: extract guest capabilities initialization

On 17.03.2014 16:19, Francesco Romani wrote: this patch decouples the binary and the capabilities detection from the guest initialization. The purpose is to make testing easier. --- src/qemu/qemu_capabilities.c | 45 +--- src/qemu/qemu_capabilities.h |

Re: [libvirt] [PATCH 0/3] v2: qemu: export disk snapshot capability

On 17.03.2014 16:19, Francesco Romani wrote: This patch series extend the QEMU capabilities XML to report if the underlying QEMU binary supports, or not, the live disk snapshotting. Without this patch series, the only way to know if QEMU has this support is to actually request a disk snapshot a

Re: [libvirt] [PATCH 3/3] qemu: add unit tests for the capabilities xml

On 17.03.2014 16:19, Francesco Romani wrote: the test is loosely inspired from qemucapabilitiestest and qemuxml2xmltest. Added a new test instead of extending an existing one because the feature being tested don't really fits nicely in any existing place. --- tests/Makefile.am

Re: [libvirt] [PATCH 0/3] v2: qemu: export disk snapshot capability

On 17.03.2014 16:19, Francesco Romani wrote: This patch series extend the QEMU capabilities XML to report if the underlying QEMU binary supports, or not, the live disk snapshotting. Without this patch series, the only way to know if QEMU has this support is to actually request a disk snapshot a

Re: [libvirt] [PATCH v2 2/2] bhyve: add xml2args unittest

On 03/23/2014 07:17 AM, Roman Bogorodskiy wrote: > At this point unittest covers 4 basic cases: > > - minimal working XML for bhyve > - same as above, but with virtio disk > - ACPI and APIC args test > - MAC address test > --- > src/util/virnetdevtap.c| 1 - > te

Re: [libvirt] [PATCH v2 1/2] Move virBhyveTapGetRealDeviceName to virnetdevtap

On 03/23/2014 07:17 AM, Roman Bogorodskiy wrote: > To ease mocking for bhyve unit tests move virBhyveTapGetRealDeviceName() > out of bhyve_command.c to virnetdevtap and rename it to > virNetDevTapGetRealDeviceName(). > --- > src/bhyve/bhyve_command.c | 70 +

Re: [libvirt] [PATCH] qemuDomainAttachDeviceFlags: Parse device xml as inactive

On 03/19/2014 04:19 PM, Michal Privoznik wrote: > In all other drivers we are doing so. Moreover, we don't want to parse > runtime information in attach (even if the attach is meant as live) > because we are generating the runtime info ourselves. We can't trust > users they supply sane values anywa

Re: [libvirt] [Qemu-devel] [PATCH v5 2/2] query-command-line-options: query all the options in qemu-options.hx

On Tue, Mar 11, 2014 at 06:46:10PM -0600, Eric Blake wrote: > On 03/06/2014 11:09 PM, Amos Kong wrote: > > vm_config_groups[] only contains part of the options which have > > parameters, and all options which have no parameter aren't added > > to vm_config_groups[]. Current query-command-line-optio

Re: [libvirt] [PATCH 2/2] Ensure JNA callbacks cannot get GCed

On Wed, Mar 26, 2014 at 7:24 AM, Claudio Bley wrote: > At Wed, 26 Mar 2014 02:43:49 +, > Chris Ellis wrote: > > > > Currently nothing prevents the JNA callback objects used when registering > > for domain events from being garbage collected. JNA requires that > callback > > objects are not G

[libvirt] question for in ethernet type and multiple queues in KVM (start VM failed)

Hi, I use ethernet vif for VM (libvirt 1.1.0 qemu 1.5.1). xml as such tap_mq is a tap device with multi_queue property which was created on host by ip command, such as follows #ip tuntap add ta

Re: [libvirt] question for in ethernet type and multiple queues in KVM (start VM failed)

On Wed, Mar 26, 2014 at 09:31:17AM +, Gonglei (Arei) wrote: > > > > > > I use ethernet vif for VM (libvirt 1.1.0 qemu 1.5.1). xml as such > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >

Re: [libvirt] [PATCH] maint: use $(SED) instead of sed for syntax-check

Roman Bogorodskiy wrote: > Some syntax-check rules use GNU sed specific regexps, so allow > to override which sed would be used to fix 'syntax-check' for > non GNU-userland systems. > --- > cfg.mk | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Any updates on that? Roma

Re: [libvirt] question for in ethernet type and multiple queues in KVM (start VM failed)

On Wed, Mar 26, 2014 at 08:59:04AM +, Wangrui (K) wrote: > Hi, > > I use ethernet vif for VM (libvirt 1.1.0 qemu 1.5.1). xml as such > > > > > > > > > > tap_mq is a tap device with multi_queue p

Re: [libvirt] [PATCH] qemu: remove redundant virQEMUDriverGetConfig

On Tue, Mar 25, 2014 at 04:37:33PM -0400, Tomoki Sekiyama wrote: > qemuDomainSetSchedulerParametersFlags() calls virQEMUDriverGetConfig() twice > and makes the reference counter leak. This removes redundant call. > --- > src/qemu/qemu_driver.c |1 - > 1 file changed, 1 deletion(-) > > diff --

Re: [libvirt] [libvirt-java] [PATCH] Set Java source level in pom

On Wed, Mar 26, 2014 at 4:32 AM, Eric Blake wrote: > On 03/25/2014 10:19 PM, Eric Blake wrote: > > On 03/25/2014 09:29 PM, Chris Ellis wrote: > >> Hi > >> > >> Simple patch to set the Java source level within the pom, this makes it > >> easier to import the project into Eclipse. I've also added

Re: [libvirt] [PATCH 3/3] Coverity: Resolve a RESOURCE_LEAK

On Tue, Mar 25, 2014 at 03:00:02PM -0600, Eric Blake wrote: > On 03/25/2014 12:00 PM, John Ferlan wrote: > > On error the lofd would have been leaked. > > > > Signed-off-by: John Ferlan > > --- > > src/lxc/lxc_controller.c | 14 ++ > > 1 file changed, 10 insertions(+), 4 deletions(-)

Re: [libvirt] [libvirt-java] [PATCH] Update pom to include Java source level

On Wed, Mar 26, 2014 at 7:52 AM, Claudio Bley wrote: > At Wed, 26 Mar 2014 03:29:34 +, > Chris Ellis wrote: > > > > Update the pom to set the Java source level. This enables Eclipse > > to correctly configure itself. > > So, you let ant generate the pom.xml and use that with Eclipse, right?

  1   2   >