Re: [libvirt] [PATCH] Restore skipping of setting capacity

2014-05-01 Thread Eric Blake
On 04/23/2014 11:58 AM, Eric Blake wrote: > On 04/23/2014 07:28 AM, John Ferlan wrote: >> Commit id 'ac9a0963' refactored out the 'withCapacity' for the >> virStorageBackendUpdateVolInfo() API. See: > > Fortunately, we haven't released this regression of mine :) > >> >> http://www.redhat.com/arc

Re: [libvirt] Libvirt API

2014-05-01 Thread Eric Blake
On 04/29/2014 01:59 AM, Vikas Kokare wrote: > The environment details are > > kernel version : 2.6.18-371.8.1.el5 > RHEL release : Red Hat Enterprise Linux Server release 5.10 (Tikanga) You are probably better off raising a support ticket with Red Hat, as this list tends to focus on upstream dev

[libvirt] [PATCH v7 6/6] qemu: Support mountpoints option of guest-fsfreeze-freeze

2014-05-01 Thread Tomoki Sekiyama
With this patch, virDomainFSFreeze will pass the mountpoints argument to qemu guest agent. For example, virDomainFSFreeze(dom, {"/mnt/vol1", "/mnt/vol2"}, 2, 0) will issue qemu guest agent command: {"execute":"guest-fsfreeze-freeze", "arguments":{"mountpoints":["/mnt/vol1","/mnt/vol2"]}}

[libvirt] [PATCH v7 4/6] qemu: Implement virDomainFSFreeze and virDomainFSThaw

2014-05-01 Thread Tomoki Sekiyama
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are already implemented for snapshot quiescing. Signed-off-by: Tomoki Sekiyama --- src/qemu/qemu_driver.c | 98 1 file changed, 98 insertions(+) diff --git a/src/qemu/qemu_d

[libvirt] [PATCH v7 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-01 Thread Tomoki Sekiyama
These are exposed under domfsfreeze command and domfsthaw command. Signed-off-by: Tomoki Sekiyama --- tools/virsh-domain.c | 126 ++ tools/virsh.pod | 23 + 2 files changed, 149 insertions(+) diff --git a/tools/virsh-domain.c b/too

[libvirt] [PATCH v7 2/6] remote: Implement virDomainFSFreeze and virDomainFSThaw

2014-05-01 Thread Tomoki Sekiyama
New rules are added in fixup_name in gendispatch.pl to keep the name FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze', which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag. Signed-off-by: Tomoki Sekiyama Acked-by: Daniel P. Berrange --- src/access/viraccessperm.c |

[libvirt] [PATCH v7 3/6] qemu: track quiesced status in qemuDomainSnapshotFSFreeze

2014-05-01 Thread Tomoki Sekiyama
Adds 'quiesced' status into qemuDomainObjPrivate that tracks whether FSFreeze is requested in the domain. It modifies error code from qemuDomainSnapshotFSFreeze and qemuDomainSnapshotFSThaw, so that a caller can know whether the command is actually sent to the guest agent. If the error is caused b

[libvirt] [PATCH v7 1/6] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-05-01 Thread Tomoki Sekiyama
These will freeze and thaw filesystems within guest specified by @mountpoints parameters. The parameters can be NULL and 0, then the all mounted filesystems are frozen or thawed. @flags parameter, which are currently not used, is for future extensions. Signed-off-by: Tomoki Sekiyama --- include/

[libvirt] [PATCH v7 0/6] Expose FSFreeze/FSThaw within the guest as API

2014-05-01 Thread Tomoki Sekiyama
Hello, This is patchset v7 to add FSFreeze/FSThaw API for custom disk snapshotting. Changes since v6: * return VIR_ERR_ARGUMENT_UNSUPPORTED when 'mountpoints' parameter is given even though the driver doesn't support it, rather than ignore it. * include some missing argument in debug line i

[libvirt] [PATCH V2 0/3] support flags in libxlDomain{Shutdown, Reboot}

2014-05-01 Thread Jim Fehlig
This small series is a V2 of https://www.redhat.com/archives/libvir-list/2014-April/msg00837.html Patch 1 adds VIR_DOMAIN_SHUTDOWN_PARAVIRT and VIR_REBOOT_SHUTDOWN_PARAVIRT flags to the API as requested by danpb. Patch 2 makes use of the shutdown flags in libxlDomainShutdownFlags. Patch 3 does

[libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

2014-05-01 Thread Jim Fehlig
Add support for VIR_DOMAIN_REBOOT_PARAVIRT and VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flags in libxlDomainReboot(). Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/

[libvirt] [PATCH V2 1/3] Introduce a new flag for controlling shutdown/reboot

2014-05-01 Thread Jim Fehlig
Add a new flag to virDomain{Reboot,Shutdown}FlagValues to allow shutting down and rebooting a domain via the Xen paravirt control interface. Signed-off-by: Jim Fehlig --- include/libvirt/libvirt.h.in | 2 ++ tools/virsh-domain.c | 14 ++ tools/virsh.pod | 8 +++

[libvirt] [PATCH V2 2/3] libxl: support PARAVIRT and ACPI shutdown flags

2014-05-01 Thread Jim Fehlig
Add support for VIR_DOMAIN_SHUTDOWN_PARAVIRT and VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN flags in libxlDomainShutdownFlags(). Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/src/libxl/libxl_

Re: [libvirt] [PATCHv2 0/3] fix virstoragetest failure on 32-bit

2014-05-01 Thread Eric Blake
On 05/01/2014 02:41 PM, John Ferlan wrote: > > > On 04/30/2014 10:27 PM, Eric Blake wrote: >> v1 was here, but it got nacked for being ugly: >> https://www.redhat.com/archives/libvir-list/2014-April/msg01132.html >> >> so in this version, I improved virstring first, then used the >> new clean fun

Re: [libvirt] Test failures with newest gnutls

2014-05-01 Thread Martin Kletzander
On Tue, Apr 29, 2014 at 05:32:45PM +0100, Daniel P. Berrange wrote: On Tue, Apr 29, 2014 at 05:25:12PM +0100, Daniel P. Berrange wrote: On Tue, Apr 29, 2014 at 06:19:56PM +0200, Martin Kletzander wrote: > Hi everyone, > > after upgrade to gnutls-3.3.0, I discovered (commandtest fails) that > any

Re: [libvirt] [PATCHv2 0/3] fix virstoragetest failure on 32-bit

2014-05-01 Thread John Ferlan
On 04/30/2014 10:27 PM, Eric Blake wrote: > v1 was here, but it got nacked for being ugly: > https://www.redhat.com/archives/libvir-list/2014-April/msg01132.html > > so in this version, I improved virstring first, then used the > new clean function. > > This is a build-breaker fix, so it deserv

Re: [libvirt] [PATCH] php: implement libvirt_node_get_free_memory.

2014-05-01 Thread Eric Blake
On 05/01/2014 01:05 PM, Dawid Zamirski wrote: > On Thu, 2014-05-01 at 12:55 -0600, Eric Blake wrote: >> [meta-comment] >> >> I'm not a PHP expert, so I'll let others review the patch itself. But >> when contributing patches to libvirt-php.git, it helps if you do: >> git config format.subjectprefi

Re: [libvirt] [PATCH] php: implement libvirt_node_get_free_memory.

2014-05-01 Thread Dawid Zamirski
On Thu, 2014-05-01 at 12:55 -0600, Eric Blake wrote: > [meta-comment] > > I'm not a PHP expert, so I'll let others review the patch itself. But > when contributing patches to libvirt-php.git, it helps if you do: > git config format.subjectprefix "php PATCH" > to make it obvious which repo you ar

Re: [libvirt] [PATCH] php: implement libvirt_node_get_free_memory.

2014-05-01 Thread Eric Blake
[meta-comment] On 05/01/2014 12:33 PM, Dawid Zamirski wrote: > This patch adds support for virNodeGetFreeMemory which is available in > libvirt since v0.3.3. While the php bindings alredy provide > libvirt_node_get_mem_stats from which such info could be obtained, not > all hypervisors support it,

[libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

2014-05-01 Thread Roman Bogorodskiy
Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 + 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c in

[libvirt] [PATCH] php: implement libvirt_node_get_free_memory.

2014-05-01 Thread Dawid Zamirski
This patch adds support for virNodeGetFreeMemory which is available in libvirt since v0.3.3. While the php bindings alredy provide libvirt_node_get_mem_stats from which such info could be obtained, not all hypervisors support it, e.g. vbox and esx driver don't have it but they do implement virNodeG

Re: [libvirt] [PATCH] Misc error reporting bugs in QEMU cli builder

2014-05-01 Thread Eric Blake
On 05/01/2014 10:25 AM, Daniel P. Berrange wrote: > A couple of places in the QEMU XML -> ARGV conversion code > raised an error but then forgot to return an error status > due to missing gotos. While fixing this also tweak style > of a couple of other error reports > > Signed-off-by: Daniel P. Be

[libvirt] [PATCH] Misc error reporting bugs in QEMU cli builder

2014-05-01 Thread Daniel P. Berrange
A couple of places in the QEMU XML -> ARGV conversion code raised an error but then forgot to return an error status due to missing gotos. While fixing this also tweak style of a couple of other error reports Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_command.c | 8 +--- 1 file chan

Re: [libvirt] Reg : failing to attach iscsi disk from virsh to running VM on xen

2014-05-01 Thread Jim Fehlig
Prapulla Kumar wrote: > Hi, > I'm using libvirt 1.2.3 and xen 4.3.1 > I'm trying to attach a volume to VM which is running on xen. > While attaching it is giving error at libvirtd log is > > * error : libxlDomainAttachDeviceDiskLive:2567 : unsupported > configuration: disk bus 'scsi' cannot be hot

[libvirt] [PATCH V6] libxl: add migration support

2014-05-01 Thread Jim Fehlig
This patch adds initial migration support to the libxl driver, using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration functions. Signed-off-by: Jim Fehlig --- V5 here https://www.redhat.com/archives/libvir-list/2014-April/msg01123.html In V6: Change receive migration args to a virObje

[libvirt] Reg : failing to attach iscsi disk from virsh to running VM on xen

2014-05-01 Thread Prapulla Kumar
Hi, I'm using libvirt 1.2.3 and xen 4.3.1 I'm trying to attach a volume to VM which is running on xen. While attaching it is giving error at libvirtd log is * error : libxlDomainAttachDeviceDiskLive:2567 : unsupported configuration: disk bus 'scsi' cannot be hotplugged.* can you suggest any con

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-01 Thread Eric Blake
On 05/01/2014 03:38 AM, Daniel P. Berrange wrote: >> >> The parser already accepts repeated options (well, precisely ONE >> repeated option), by making that option be last in the command >> description and giving it .type = VSH_OT_ARGV. For comparison, see the >> echo command in virsh.c or the se

Re: [libvirt] [PATCH 1/2] qemu: add host-pci-multidomain capability

2014-05-01 Thread Laine Stump
On 04/30/2014 05:17 PM, Daniel P. Berrange wrote: > On Wed, Apr 30, 2014 at 04:04:00PM +0300, Laine Stump wrote: >> @@ -1043,6 +1044,8 @@ virQEMUCapsComputeCmdFlags(const char *help, >> virQEMUCapsSet(qemuCaps, QEMU_CAPS_DRIVE_SERIAL); >> if (strstr(help, "-pcidevice")) >> vi

Re: [libvirt] [PATCH] qemu: fix crash when removing from interface with update-device

2014-05-01 Thread Eric Blake
On 05/01/2014 02:57 AM, Laine Stump wrote: > If a domain network interface that contains a is modified > "live" using "virsh update-device --live", libvirtd would crash. This > was because the code supporting live update of an interface's > filterref was assuming that a filterref might be added or

[libvirt] [PATCH] bhyve: report cpuTime in bhyveDomainGetInfo

2014-05-01 Thread Roman Bogorodskiy
Add a helper function virBhyveGetDomainTotalCpuStats() to obtain process CPU time using kvm (kernel memory interface) and use it to set cpuTime field of the virDomainInfo struct in bhyveDomainGetInfo(). --- configure.ac | 7 +++ src/bhyve/bhyve_driver.c | 9 + src/bhyve

Re: [libvirt] [PATCH v7 0/4] Handling of undefine and re define snapshots with VirtualBox 4.2 or higher

2014-05-01 Thread Daniel P. Berrange
On Fri, Apr 18, 2014 at 11:51:30AM +0200, Yohan BELLEGUIC wrote: > Hello, > > This is a new series of patches in order to support undefining and redefining > snapshots with VirtualBox 4.2 or higher. > These patches are based on Manuel Vives' patches, taking into account Daniel > P. Berrange's re

Re: [libvirt] [PATCH v7 4/4] vbox_tmpl.c: Add function for undefining snapshot

2014-05-01 Thread Daniel P. Berrange
On Fri, Apr 18, 2014 at 11:51:34AM +0200, Yohan BELLEGUIC wrote: > All snapshots information will be deleted from the vbox XML, but > differencing disks will be kept so the user will be able to redefine the > snapshot. > --- > src/vbox/vbox_tmpl.c | 453 >

Re: [libvirt] [PATCH v7 3/4] vbox_tmpl.c: Patch for redefining snapshots

2014-05-01 Thread Daniel P. Berrange
On Fri, Apr 18, 2014 at 11:51:33AM +0200, Yohan BELLEGUIC wrote: > The machine is unregistered and its vbox XML file is changed in order to > add snapshot information. The machine is then registered with the > snapshot to redefine. > --- > src/vbox/vbox_tmpl.c | 949 > +++

Re: [libvirt] [PATCH v7 2/4] Add vbox_snapshot_conf struct

2014-05-01 Thread Daniel P. Berrange
On Fri, Apr 18, 2014 at 11:51:32AM +0200, Yohan BELLEGUIC wrote: > This structure contains the data to be saved in the VirtualBox XML file > and can be manipulated with severals exposed functions. > The structure is created by vboxSnapshotLoadVboxFile taking the > machine XML file. > It also can re

Re: [libvirt] [PATCH v7 1/4] vbox_tmpl.c: Better XML description for snapshots

2014-05-01 Thread Daniel P. Berrange
On Fri, Apr 18, 2014 at 11:51:31AM +0200, Yohan BELLEGUIC wrote: > From: Manuel VIVES > > It will be needed for the future patches because we will > redefine snapshots > --- > src/vbox/vbox_tmpl.c | 513 > +- > 1 file changed, 504 insertions(+),

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-01 Thread Daniel P. Berrange
On Wed, Apr 30, 2014 at 01:44:07PM -0600, Eric Blake wrote: > On 04/30/2014 10:52 AM, Tomoki Sekiyama wrote: > > > > >> I'd think it'd be better to just allow multiple instances of > >> the arg eg > >> > >> virsh fsfreeze --mount --mount > > > > the virsh option parser rejects repeated op

[libvirt] [PATCH] qemu: fix crash when removing from interface with update-device

2014-05-01 Thread Laine Stump
If a domain network interface that contains a is modified "live" using "virsh update-device --live", libvirtd would crash. This was because the code supporting live update of an interface's filterref was assuming that a filterref might be added or modified, but didn't account for removing the filt