Re: [libvirt] [PATCH RFC 05/22] storage: Add NONE protocol type for network disks

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Peter Krempa wrote: > Currently the protocol type with index 0 was NBD which made it hard to > distinguish wether the protocol type was actually assigned. Add a new s/wether/whether/ > protocol type with index 0 to distinguish it explicitly. > --- > src/qemu/qemu_command.

Re: [libvirt] [PATCH RFC 04/22] conf: Fix domain disk path iterator to work with networked storage

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Peter Krempa wrote: > Skip networked storage but continue iteration through backing chain to > iterate through all the local paths in the backing chain. > --- > src/conf/domain_conf.c | 37 - > 1 file changed, 20 insertions(+), 17 deletio

Re: [libvirt] [PATCH RFC 03/22] storage: Rework debugging of storage file access through storage driver

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Peter Krempa wrote: > Print the debug statements of individual file access functions from the > main API functions instead of the individual backend functions. > > Also enhance initialization debug messages on a per-backend basis. > --- > src/storage/storage_backend_fs.c

Re: [libvirt] [PATCH v7 3/6] qemu: track quiesced status in qemuDomainSnapshotFSFreeze

2014-05-06 Thread Eric Blake
On 05/01/2014 06:06 PM, Tomoki Sekiyama wrote: > Adds 'quiesced' status into qemuDomainObjPrivate that tracks whether > FSFreeze is requested in the domain. > > It modifies error code from qemuDomainSnapshotFSFreeze and > qemuDomainSnapshotFSThaw, so that a caller can know whether the command is >

Re: [libvirt] [PATCH RFC 02/22] storage: Store gluster volume name separately

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Peter Krempa wrote: > The gluster volume name was previously stored as part of the source path > string. This isn't a good idea when we want to start to deal with > resolving of relative paths on gluster as a storage volume can't > actually be changed by ../-ing it. > > Par

Re: [libvirt] [libvirt-users] Virsh Attach Volume Fails

2014-05-06 Thread Vilobh Meshram
The contents of disk.xml Trying to attach a volume created on CEPH RBD backend to an VM created. Can¹t see meaningful information in QEMU log nor in libvirt logs. I have the needed CEPH libs installed like librbd, librados. On 5/6/14, 4:35 PM,

[libvirt] Configure virtio-scsi options via libvirt

2014-05-06 Thread Mike Perez
Hi everyone, I would like be able to configure virtio-scsi options num_queues, max_sectors, and cmd_per_lun via libvirt. Are there any plans to have this support? -- Mike Perez -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [question]qemu: migrate and destory vm immediately on destination causes libvirt deadlock or segment fault

2014-05-06 Thread Wangrui (K)
Hi everyone, I do ram migration operation in KVM environment(libvirt1.2.4 qemu1.5.1). I encountered libvirtd deadlock or segmentfault when I destroy the migration VM on destination. I got the problem by flowing steps: step 1: migrate VM. step 2: execute "virsh destroy [VMName]" to destroy the migr

Re: [libvirt] [PATCH v7 2/6] remote: Implement virDomainFSFreeze and virDomainFSThaw

2014-05-06 Thread Eric Blake
On 05/01/2014 06:05 PM, Tomoki Sekiyama wrote: > New rules are added in fixup_name in gendispatch.pl to keep the name > FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze', > which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag. > > Signed-off-by: Tomoki Sekiyama > Acked-b

[libvirt] [PATCH 1/2] storage: Need to ensure removal of voldef from driver list

2014-05-06 Thread John Ferlan
If for some reason a volume cannot be built in the pool (eg, the buildVol call fails), then the error code may or may not properly remove the volume from the pool->volumes.objs[] list. Removal from the list is dependent on the 'deleteVol()' being present in the backend *and* calling it returning s

[libvirt] [PATCH 2/2] storage: Resolve issues in failure path

2014-05-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1092882 Refactoring in commit id '0c2305b3' resulted in the wrong storage volume object being passed to the new storageVolDeleteInternal(). It should have passed 'voldef' which is the address found in the pool->volumes.objs[i] array. By passing 'voldef'

[libvirt] [PATCH 0/2] Fix bug on buildVol error path

2014-05-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1092882 Changes as a result of commit id '0c2305b3', see: http://www.redhat.com/archives/libvir-list/2014-April/msg00375.html Resulted in a regression when there was a failure to buildVol the volume wasn't removed from the storage driver list because

Re: [libvirt] [PATCH RFC 01/22] qemu: Make qemuDomainPrepareDiskChainElement aware of remote storage

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Peter Krempa wrote: > Refactor the function to accept a virStorageSourcePtr instead of just > the path, add a check to run it only on local storage and fix callers > (possibly by using a newly introduced wrapper that wraps a path in the > virStorageSource struct for legacy

Re: [libvirt] [PATCH v7 1/6] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-05-06 Thread Eric Blake
On 05/02/2014 03:48 AM, Daniel P. Berrange wrote: > On Thu, May 01, 2014 at 08:05:48PM -0400, Tomoki Sekiyama wrote: >> These will freeze and thaw filesystems within guest specified by >> @mountpoints parameters. The parameters can be NULL and 0, then the all s/the all/all/ >> mounted filesystems

Re: [libvirt] [libvirt-users] Virsh Attach Volume Fails

2014-05-06 Thread Eric Blake
On 05/06/2014 02:51 AM, Vilobh Meshram wrote: > Hi, > > When trying to attach a created volume to an instance using the virsh utility > I am running into this error :- > > > [] $ sudo virsh attach-device instance-0015 disk.xml > > error: Failed to attach device from disk.xml > > error: in

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Eric Blake
On 04/23/2014 04:42 AM, Giuseppe Scrivano wrote: > Some CDROM devices are reported by udev to have an ID_TYPE="generic" > thus it is necessary to check if ID_CDROM is present. > > As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will > enable checks for ID_DRIVE_FLASH_SD and ID_DR

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Eric Blake
On 05/06/2014 05:11 AM, Giuseppe Scrivano wrote: > "Daniel P. Berrange" writes: > >> On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: >>> Some CDROM devices are reported by udev to have an ID_TYPE="generic" >>> thus it is necessary to check if ID_CDROM is present. >>> >>> As a s

Re: [libvirt] [RESEND PATCH] Add support for timestamping QEMU logs

2014-05-06 Thread Eric Blake
On 05/06/2014 07:36 AM, Ján Tomko wrote: > QEMU commit 5e2ac51 added a boolean '-msg timestamp=[on|off]' > option, which can enable timestamps on errors: > $ qemu-system-x86_64 -msg timestamp=on zghhdorf > 2014-04-09T13:25:46.779484Z qemu-system-x86_64: -msg timestamp=on: could > not open disk imag

Re: [libvirt] [PATCH] docs: update README-hacking

2014-05-06 Thread Eric Blake
On 05/06/2014 09:33 AM, Nehal J Wani wrote: > On Tue, May 6, 2014 at 12:32 PM, Chen Hanxiao > wrote: >> We didn't have "README-valgrind" file now. >> So remove related description. > > s/didn't/don't > or maybe this is better: > Remove reference of non-existing file 'README-valgrind' I went with

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Eric Blake
On 05/06/2014 02:19 PM, Eduardo Habkost wrote: >> IMHO, libvirt side should take advantage of information QEMU already >> provides. >> > > Current API requires re-running QEMU to query the information. This > series allows it to be run with the "-machine none" QEMU instance that > is already run

Re: [libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-06 Thread Eduardo Habkost
On Tue, May 06, 2014 at 03:50:48PM +0100, Daniel P. Berrange wrote: > On Tue, May 06, 2014 at 03:27:20PM +0200, Ján Tomko wrote: > > Not yet merged in upstream QEMU: > > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05024.html > > > > Add support for invariant TSC timer running at const

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Andreas Färber
Am 06.05.2014 22:19, schrieb Eduardo Habkost: > On Tue, May 06, 2014 at 10:01:11PM +0200, Igor Mammedov wrote: >> On Tue, 6 May 2014 11:42:56 -0300 >> Eduardo Habkost wrote: >>> On Tue, May 06, 2014 at 09:22:38AM +0200, Igor Mammedov wrote: On Fri, 2 May 2014 11:43:05 -0300 Eduardo Habko

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Eduardo Habkost
On Tue, May 06, 2014 at 10:01:11PM +0200, Igor Mammedov wrote: > On Tue, 6 May 2014 11:42:56 -0300 > Eduardo Habkost wrote: > > > On Tue, May 06, 2014 at 09:22:38AM +0200, Igor Mammedov wrote: > > > On Fri, 2 May 2014 11:43:05 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Fri, May 02, 201

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Igor Mammedov
On Tue, 6 May 2014 11:42:56 -0300 Eduardo Habkost wrote: > On Tue, May 06, 2014 at 09:22:38AM +0200, Igor Mammedov wrote: > > On Fri, 2 May 2014 11:43:05 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: > > > > On Wed, 30 Apr 2014 17:29:2

Re: [libvirt] [PATCH v5] Add helper program to create custom leases

2014-05-06 Thread Nehal J Wani
Ping! On Sat, Apr 26, 2014 at 5:29 AM, Nehal J Wani wrote: > Introduce helper program to catch events from dnsmasq and maintain a custom > lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as > ".status". > > Each lease contains the following info: > > > Example of cu

Re: [libvirt] [Qemu-devel] qemu leaving unix sockets behind after VM is shut down

2014-05-06 Thread Eric Blake
On 05/06/2014 08:52 AM, Chris Friesen wrote: > Yes, I am in fact using OpenStack/libvirt, and did eventually track down > libvirt as the code that was cleaning up the monitor socket. > > Even so, I think this sort of change would be valid in qemu itself. qemu > created the files, so really it shou

Re: [libvirt] [PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-06 Thread Alex Williamson
Hi Greg, I think Bjorn is waiting for an ack from you on this. Do you approve of this approach from a driver-core perspective? Thanks, Alex On Fri, 2014-04-04 at 14:19 -0600, Alex Williamson wrote: > The driver_override field allows us to specify the driver for a device > rather than relying o

Re: [libvirt] [PATCH] docs: update README-hacking

2014-05-06 Thread Nehal J Wani
On Tue, May 6, 2014 at 12:32 PM, Chen Hanxiao wrote: > We didn't have "README-valgrind" file now. > So remove related description. s/didn't/don't or maybe this is better: Remove reference of non-existing file 'README-valgrind' > > Signed-off-by: Chen Hanxiao > --- > README-hacking | 2 +- > 1

Re: [libvirt] [Qemu-devel] qemu leaving unix sockets behind after VM is shut down

2014-05-06 Thread Chris Friesen
On 05/06/2014 07:39 AM, Stefan Hajnoczi wrote: On Tue, Apr 01, 2014 at 02:34:58PM -0600, Chris Friesen wrote: When running qemu with something like this -device virtio-serial \ -chardev socket,path=/tmp/foo,server,nowait,id=foo \ -device virtserialport,chardev=foo,name=host.port.0 the VM start

Re: [libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2014 at 03:27:20PM +0200, Ján Tomko wrote: > Not yet merged in upstream QEMU: > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05024.html > > Add support for invariant TSC timer running at constant rate in > all ACPI P-, C- and T-states. What does this do at the hardware

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Eduardo Habkost
On Tue, May 06, 2014 at 09:22:38AM +0200, Igor Mammedov wrote: > On Fri, 2 May 2014 11:43:05 -0300 > Eduardo Habkost wrote: > > > On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: > > > On Wed, 30 Apr 2014 17:29:28 -0300 > > > Eduardo Habkost wrote: > > > > > > > This series allows

Re: [libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-06 Thread Peter Krempa
On 05/06/14 15:27, Ján Tomko wrote: > Not yet merged in upstream QEMU: > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05024.html > > Add support for invariant TSC timer running at constant rate in > all ACPI P-, C- and T-states. > > It can be enabled by specifying: > > > > in the

Re: [libvirt] [Qemu-devel] qemu leaving unix sockets behind after VM is shut down

2014-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2014 at 03:39:57PM +0200, Stefan Hajnoczi wrote: > On Tue, Apr 01, 2014 at 02:34:58PM -0600, Chris Friesen wrote: > > When running qemu with something like this > > > > -device virtio-serial \ > > -chardev socket,path=/tmp/foo,server,nowait,id=foo \ > > -device virtserialport,chard

Re: [libvirt] [Qemu-devel] qemu leaving unix sockets behind after VM is shut down

2014-05-06 Thread Stefan Hajnoczi
On Tue, Apr 01, 2014 at 02:34:58PM -0600, Chris Friesen wrote: > When running qemu with something like this > > -device virtio-serial \ > -chardev socket,path=/tmp/foo,server,nowait,id=foo \ > -device virtserialport,chardev=foo,name=host.port.0 > > the VM starts up as expected and creates a socke

[libvirt] [PATCH RFC 18/22] storage: Change to new backing store parser

2014-05-06 Thread Peter Krempa
Use the new backing store parser in the backing chain crawler. This change needs one test change where information about the NBD image are now parsed differently. --- src/storage/storage_driver.c | 90 +--- tests/virstoragetest.c | 14 --- 2 files

[libvirt] [PATCH RFC 03/22] storage: Rework debugging of storage file access through storage driver

2014-05-06 Thread Peter Krempa
Print the debug statements of individual file access functions from the main API functions instead of the individual backend functions. Also enhance initialization debug messages on a per-backend basis. --- src/storage/storage_backend_fs.c | 43 ++- src/storag

[libvirt] [PATCH RFC 21/22] qemu: Add support for networked disks for block commit

2014-05-06 Thread Peter Krempa
Now that we are able to select images from the backing chain via indexed access we should also convert possible network sources to qemu-compatible strings before passing them to qemu. --- src/qemu/qemu_driver.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --

[libvirt] [PATCH RFC 07/22] storage: Add storage file API to read file headers

2014-05-06 Thread Peter Krempa
Add storage driver based functions to access headers of storage files for metadata extraction. Along with this patch a local filesystem and gluster via libgfapi implementation is provided. The gluster implementation is based on code of the saferead_lim function. --- src/storage/storage_backend.h

[libvirt] [PATCH RFC 02/22] storage: Store gluster volume name separately

2014-05-06 Thread Peter Krempa
The gluster volume name was previously stored as part of the source path string. This isn't a good idea when we want to start to deal with resolving of relative paths on gluster as a storage volume can't actually be changed by ../-ing it. Parse and store the volume name separately for gluster stor

[libvirt] [PATCH RFC 15/22] storage: Switch metadata crawler to use storage driver to read headers

2014-05-06 Thread Peter Krempa
Use virStorageFileReadHeader() to read headers of storage files possibly on remote storate to retrieve the image metadata. The backend information is now parsed by virStorageFileGetMetadataInternal which is now exported from the util source and virStorageFileGetMetadataFromFDInternal now doesn't n

[libvirt] [PATCH RFC 20/22] qemu: Add support for networked disks for block pull/block rebase

2014-05-06 Thread Peter Krempa
Now that we are able to select images from the backing chain via indexed access we should also convert possible network sources to qemu-compatible strings before passing them to qemu. --- src/qemu/qemu_driver.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/

[libvirt] [PATCH RFC 05/22] storage: Add NONE protocol type for network disks

2014-05-06 Thread Peter Krempa
Currently the protocol type with index 0 was NBD which made it hard to distinguish wether the protocol type was actually assigned. Add a new protocol type with index 0 to distinguish it explicitly. --- src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_driver.c| 3 +++ src/util/virstoragefile.c |

[libvirt] LSN-2014-0003: Unsafe parsing of XML documents allows arbitrary file read

2014-05-06 Thread Daniel P. Berrange
Libvirt Security Notice: LSN-2014-0003 == Summary: Unsafe parsing of XML documents allows arbitrary file read Reported on: 20140411 Published on: 20140506 Fixed on: 20140506 Reported by: Daniel P. Berrange

[libvirt] [PATCH RFC 10/22] storage: Move virStorageFileGetMetadata to the storage driver

2014-05-06 Thread Peter Krempa
My future work will modify the metadata crawler function to use the storage driver file APIs to access the files instead of accessing them directly so that we will be able to request the metadata for remote files too. To avoid linking the storage driver to every helper file using the utils code, th

[libvirt] [PATCH RFC 19/22] storage: Traverse backing chains of network disks

2014-05-06 Thread Peter Krempa
Now we don't need to skip backing chain detection for remote disks. --- src/qemu/qemu_domain.c | 8 +++- src/storage/storage_driver.c | 18 ++ 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7ea9032..c

[libvirt] [PATCH RFC 17/22] storage: Add infrastructure to parse remote network backing names

2014-05-06 Thread Peter Krempa
Add parsers for relative and absolute backing names for local and remote storage files. This parser parses relative paths as relative to their parents and absolute paths according to the protocol or local access. For remote storage volumes, all URI based backing file names are supported and for t

[libvirt] [PATCH RFC 09/22] storage: Add API to check accessibility of storage volumes

2014-05-06 Thread Peter Krempa
Add a storage driver API equivalent ot the access() function. Implementations for the filesystem and gluster backends are provided. --- src/storage/storage_backend.h | 5 + src/storage/storage_backend_fs.c | 13 + src/storage/storage_backend_gluster.c | 11 +++

[libvirt] [PATCH RFC 06/22] storage: Add support for access to files using provided uid/gid

2014-05-06 Thread Peter Krempa
To allow using the storage driver APIs to access files on various storage sources in an universal fashion possibly on storage such as nfs with root squash we'll need to store the desired uid/gid in the metadata. Add new initialisation API that will store the desired uid/gid and a wrapper for the c

[libvirt] [PATCH RFC 13/22] storage: backend: Add possibility to suppress errors from backend lookup

2014-05-06 Thread Peter Krempa
Add a new function wrapper and tweak the storage file backend lookup function so that it can be used without reporting error. This will be useful in the metadata crawler code where we need silently break if metadata retrieval is not supported for the current storage type. --- src/storage/storage_b

[libvirt] [PATCH RFC 16/22] storage: Switch metadata crawler to use storage driver file access check

2014-05-06 Thread Peter Krempa
Use virStorageFileAccess() to to check wether the file is accessible in the main part of the metadata crawler. --- src/storage/storage_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index f2c54

[libvirt] [PATCH RFC 04/22] conf: Fix domain disk path iterator to work with networked storage

2014-05-06 Thread Peter Krempa
Skip networked storage but continue iteration through backing chain to iterate through all the local paths in the backing chain. --- src/conf/domain_conf.c | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/

[libvirt] [PATCH RFC 08/22] storage: backend: Add unique id retrieval API

2014-05-06 Thread Peter Krempa
Different protocols have different means to uniquely identify a storage file. This patch implements a storage driver API to retrieve a unique string describing a volume. The current implementation works for local storage only and returns the canonical path of the volume. To add caching support the

Re: [libvirt] [PATCH] util: changing all the "enum" structures into typedef's in "src/util/" directory.

2014-05-06 Thread Julio Faracco
Yes, I choose to do all this mechanical changes first and after I would change some particular modifications according the previous those mechanical changes. First, I would like to change enum's to typedef's. Thanks for your suggestions, Eric. It was so helpful. Specially for the short commit mes

[libvirt] [PATCH RFC 00/22] Support for walking backing chains on remote volumes (especially gluster)

2014-05-06 Thread Peter Krempa
This series adds support for waliking (detecting) of backing chain on remote storage and implements the needed callbacks for the gluster storage system via native library. The last patch in the series mocks up path canonicalization on gluster as I'm working on that but this series is getting tedio

[libvirt] [PATCH RFC 14/22] storage: Switch metadata crawler to use storage driver to get unique path

2014-05-06 Thread Peter Krempa
Use the virStorageFileGetUniqueIdentifier() function to get a unique identifier regardless of the target storage type instead of relying on canonicalize_path(). A new function that checks wether we support a given image is introduced to avoid errors for unimplemented backends. --- src/storage/sto

[libvirt] [PATCH RFC 22/22] [DO NOT APPLY UPSTREAM] storage: gluster: mock up path canonicalization

2014-05-06 Thread Peter Krempa
Add code to fake gluster storage path canonicalization while I'm working on the code. --- src/storage/storage_backend_gluster.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index 1a844c9..411

[libvirt] [PATCH RFC 01/22] qemu: Make qemuDomainPrepareDiskChainElement aware of remote storage

2014-05-06 Thread Peter Krempa
Refactor the function to accept a virStorageSourcePtr instead of just the path, add a check to run it only on local storage and fix callers (possibly by using a newly introduced wrapper that wraps a path in the virStorageSource struct for legacy code) --- src/qemu/qemu_driver.c | 77 +

[libvirt] [RESEND PATCH] Add support for timestamping QEMU logs

2014-05-06 Thread Ján Tomko
QEMU commit 5e2ac51 added a boolean '-msg timestamp=[on|off]' option, which can enable timestamps on errors: $ qemu-system-x86_64 -msg timestamp=on zghhdorf 2014-04-09T13:25:46.779484Z qemu-system-x86_64: -msg timestamp=on: could not open disk image zghhdorf: Could not open 'zghhdorf': No such file

[libvirt] [PATCH RFC 12/22] test: storage: Initialize storage source to correct type

2014-05-06 Thread Peter Krempa
Stat the path of the storage file being tested to set the correct type into the virStorageSource. This will avoid breaking the test suite when inquiring metadata of directory paths in the next patches. --- tests/virstoragetest.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests

[libvirt] [PATCH RFC 11/22] storage: Determine the local storage type right away

2014-05-06 Thread Peter Krempa
When walking the backing chain we previously set the storage type to _FILE and let the virStorageFileGetMetadataFromFDInternal update it to the correct type later on. This patch moves the actual storage type determination to the place where we parse the backing store name so that the code can late

[libvirt] [RFC PATCH] Add support for invtsc timer

2014-05-06 Thread Ján Tomko
Not yet merged in upstream QEMU: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05024.html Add support for invariant TSC timer running at constant rate in all ACPI P-, C- and T-states. It can be enabled by specifying: in the domain XML. Migration and saving the domain does not wor

[libvirt] Virsh Attach Volume Fails

2014-05-06 Thread Vilobh Meshram
Hi, When trying to attach a created volume to an instance using the virsh utility I am running into this error :- [] $ sudo virsh attach-device instance-0015 disk.xml error: Failed to attach device from disk.xml error: internal error unable to execute QEMU command '__com.redhat_drive_add'

Re: [libvirt] [PATCH 3/5] conf: changing all the "enum" network filter structures into typedef's in "src/conf/" directory.

2014-05-06 Thread Julio Faracco
It's strange. Sure, Eric. I will check why it failed to compile. No threre is no problem with "git rebase -i". But If I need some help I will ask you in IRC. Thanks! -- Julio Cesar Faracco -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: sanlock is x86_64 only on RHEL

2014-05-06 Thread Jiri Denemark
On Tue, May 06, 2014 at 05:58:32 -0600, Eric Blake wrote: > On 05/06/2014 01:40 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > libvirt.spec.in | 9 ++--- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/libvirt.spec.in b/libvirt.spec.in > > inde

Re: [libvirt] [PATCH] spec: Don't install nonexistent test_libvirt_lockd.aug

2014-05-06 Thread Jiri Denemark
On Tue, May 06, 2014 at 05:59:00 -0600, Eric Blake wrote: > On 05/06/2014 01:41 AM, Jiri Denemark wrote: > > test_libvirt_lockd.aug is only generated when qemu driver is enabled. > > > > Signed-off-by: Jiri Denemark > > --- > > libvirt.spec.in | 2 ++ > > 1 file changed, 2 insertions(+) > > ACK

Re: [libvirt] [PATCH] spec: Don't install nonexistent test_libvirt_lockd.aug

2014-05-06 Thread Eric Blake
On 05/06/2014 01:41 AM, Jiri Denemark wrote: > test_libvirt_lockd.aug is only generated when qemu driver is enabled. > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 2 ++ > 1 file changed, 2 insertions(+) ACK > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 84d5bf3..ae40e

Re: [libvirt] [PATCH] spec: sanlock is x86_64 only on RHEL

2014-05-06 Thread Eric Blake
On 05/06/2014 01:40 AM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index aeccf4f..84d5bf3 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in

Re: [libvirt] [PATCHv2] qemu: specify domain in host-side PCI addresses when needed/supported

2014-05-06 Thread Laine Stump
On 05/06/2014 10:01 AM, Ján Tomko wrote: > On 05/05/2014 04:37 PM, Laine Stump wrote: >> This uses the new QEMU_CAPS_HOST_PCI_MULTIDOMAIN capability when >> present, for -devivce pci-assign, -device vfio-pci, and -pcidevice. >> >> While creating tests for this new functionality, I noticed that the

Re: [libvirt] lxc: shutdown $domain broken in 1.2.2

2014-05-06 Thread Wangrui (K)
Does this problem has any progress now? I have the same problem. # virsh shutdown vm1 error: Failed to shutdown domain vm1 error: Mount namespaces are not available on this platform: Function not implemented from the logfile: [2014-05-06 15:26:57 CST]: libvirtd : 5194: error : virProcessRunInM

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Giuseppe Scrivano
"Daniel P. Berrange" writes: > On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: >> Some CDROM devices are reported by udev to have an ID_TYPE="generic" >> thus it is necessary to check if ID_CDROM is present. >> >> As a side effect, treating ID_TYPE="generic" as a missing ID_TY

Re: [libvirt] Request for Wiki editing access

2014-05-06 Thread Daniel P. Berrange
On Mon, May 05, 2014 at 06:01:41PM -0500, James Thornsberry wrote: > To whom it may concern, > > I’m just beginning to use the libvirt suite of tools and, in going through > your wiki, I’ve found a couple of minor things (mostly typos) that I would > immediately correct. > > Also, if I get my

Re: [libvirt] [PATCH] LXC: don't doubly link /dev/console

2014-05-06 Thread Daniel P. Berrange
On Mon, May 05, 2014 at 11:14:18AM -0400, Dwight Engen wrote: > When a console is configured, /dev/console and /dev/tty1 are created as > symlinks to the same underlying pts. This causes problems since a > separate getty will be spawned for /dev/console and /dev/tty1, but they > are each controllin

Re: [libvirt] [libvirt-python PATCH] Bump version to 1.2.5 for new dev cycle

2014-05-06 Thread Daniel P. Berrange
On Mon, May 05, 2014 at 03:57:24PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > > Notes: > I'm not sure whether this can be pushed automatically as there is no > "release", just a tag in the repo. However, libvirt-python fails to > install without this c

Re: [libvirt] [PATCH v3 1/3] qemu: extract PCI handling structs

2014-05-06 Thread Daniel P. Berrange
On Mon, May 05, 2014 at 05:00:34PM +0300, Laine Stump wrote: > On 05/05/2014 03:07 PM, Ján Tomko wrote: > > On 05/03/2014 06:31 PM, Roman Bogorodskiy wrote: > >> Extract PCI handling related structs that could be shared > >> with other drivers. > >> > >> List of structs moved to virpci.h and new na

Re: [libvirt] [PATCH 1/4] esx: parse new URI param 'allow_unsafe'

2014-05-06 Thread Martin Kletzander
On Mon, May 05, 2014 at 01:48:03PM -0600, Eric Blake wrote: On 05/05/2014 03:47 AM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- docs/drvesx.html.in | 14 ++ src/esx/esx_util.c | 13 - src/esx/esx_util.h | 2 ++ 3 files changed, 28 insertions(+), 1 d

[libvirt] [PATCH] spec: Don't install nonexistent test_libvirt_lockd.aug

2014-05-06 Thread Jiri Denemark
test_libvirt_lockd.aug is only generated when qemu driver is enabled. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 84d5bf3..ae40e0e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1878,7 +187

[libvirt] [PATCH] spec: sanlock is x86_64 only on RHEL

2014-05-06 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- libvirt.spec.in | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index aeccf4f..84d5bf3 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -262,16 +262,11 @@ %endif # Enable sanlock library for l

Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Igor Mammedov
On Fri, 2 May 2014 11:43:05 -0300 Eduardo Habkost wrote: > On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: > > On Wed, 30 Apr 2014 17:29:28 -0300 > > Eduardo Habkost wrote: > > > > > This series allows management code to use object-add on X86CPU > > > subclasses, so it > > Is th

[libvirt] [PATCH] Fix build wihout macvtap or virtualport

2014-05-06 Thread Ján Tomko
Commit 1b14c44 broke the build on FreeBSD by changing the signature of a few functions without updating the corresponding stubs that are used when WITH_MACVTAP or WITH_VIRTUALPORT is not defined. --- Pushed under the build-breaker rule. src/util/virnetdevmacvlan.c | 8 src/util/virn

[libvirt] [PATCH] docs: update README-hacking

2014-05-06 Thread Chen Hanxiao
We didn't have "README-valgrind" file now. So remove related description. Signed-off-by: Chen Hanxiao --- README-hacking | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README-hacking b/README-hacking index 80b022c..4e02fd8 100644 --- a/README-hacking +++ b/README-hacking @@

Re: [libvirt] [PATCHv2] qemu: specify domain in host-side PCI addresses when needed/supported

2014-05-06 Thread Ján Tomko
On 05/05/2014 04:37 PM, Laine Stump wrote: > This uses the new QEMU_CAPS_HOST_PCI_MULTIDOMAIN capability when > present, for -devivce pci-assign, -device vfio-pci, and -pcidevice. > > While creating tests for this new functionality, I noticed that the > xmls for two existing tests had erroneously