On 05/02/2014 03:56 AM, Daniel P. Berrange wrote:
> On Thu, May 01, 2014 at 08:06:19PM -0400, Tomoki Sekiyama wrote:
>> With this patch, virDomainFSFreeze will pass the mountpoints argument
>> to qemu guest agent. For example,
>>
>> virDomainFSFreeze(dom, {"/mnt/vol1", "/mnt/vol2"}, 2, 0)
>>
>> w
On 05/02/2014 03:54 AM, Daniel P. Berrange wrote:
> On Thu, May 01, 2014 at 08:06:13PM -0400, Tomoki Sekiyama wrote:
>> These are exposed under domfsfreeze command and domfsthaw command.
>>
>> Signed-off-by: Tomoki Sekiyama
>> ---
>> tools/virsh-domain.c | 126
>> +++
On 05/02/2014 03:54 AM, Daniel P. Berrange wrote:
> On Thu, May 01, 2014 at 08:06:07PM -0400, Tomoki Sekiyama wrote:
>> Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are
>> already implemented for snapshot quiescing.
>>
>> Signed-off-by: Tomoki Sekiyama
>> ---
>> src/qemu
"Freezed" is not an English word.
* src/lxc/lxc_driver.c (lxcFreezeContainer): Fix typo.
* src/qemu/qemu_driver.c (qemuDomainSnapshotFSFreeze): Likewise.
Signed-off-by: Eric Blake
---
Pushing under the trivial rule.
src/lxc/lxc_driver.c | 2 +-
src/qemu/qemu_driver.c | 6 +++---
2 files cha
On 05/12/2014 07:22 AM, Michal Privoznik wrote:
> On 10.05.2014 01:21, Tomoki Sekiyama wrote:
>> Add binding for the new virDomainFSFreeze and virDomainFSThaw functions
>> added in libvirt 1.2.5. These require override since these take a list
>> of mountpoints path string. The methods are named 'fS
On 05/12/2014 03:32 PM, Eric Blake wrote:
> On 05/11/2014 09:08 AM, Julio Faracco wrote:
>
Another helpful action: when resending an updated patch, use 'git
send-email --subject-prefix=PATCHv2' to make it obvious in the subject
line that it is a resend, then after the '---' separator, add comment
Chun Yan Liu wrote:
>
On 5/10/2014 at 06:18 AM, in message <536d541d.5040...@suse.com>, Jim
Fehlig
> wrote:
>
>> Chunyan Liu wrote:
>>
>>> Signed-off-by: Chunyan Liu
>>>
>>>
>>
>> A while back when testing Chunyan's "common hostdev library" seri
On 05/11/2014 09:08 AM, Julio Faracco wrote:
When sending a series, it helps to use 'git send-email --cover-letter'
(or 'git format-patch --cover-letter' before regular 'git send-email')
to generate the 0/N lead-in letter. Mail client threading is easier
when all patches are in-reply to the 0/N c
On Sun, May 11, 2014 at 8:38 PM, Julio Faracco wrote:
> In "src/conf/" there are many enumeration (enum) declarations. Similar to the
> recent cleanup to "src/util" directory, it's better to use a typedef for
> variable types, function types and other usages. Other enumeration and
> folders wil
Laine Stump wrote:
> On 05/09/2014 05:09 PM, Jim Fehlig wrote:
>
>> Chunyan Liu wrote:
>>
>>> is supported, but
>>> nowhere mentions 'managed' in syntax.
>>> Update documentation to cover it.
>>>
>>>
>> Yep, I see the managed attribute is in the schema.
>>
>>
>>> Signed-off
On 05/12/2014 12:21 PM, Daniel P. Berrange wrote:
> On Sun, May 11, 2014 at 12:24:10AM -0400, James wrote:
>> Doc patch for apps.html as per: http://libvirt.org/apps.html#add
>>
>> Cheers,
>> James
>>
>
> ACK
I had a hard time using 'git am' to apply this patch, but it was small
enough that I ca
On 05/12/2014 07:37 AM, Martin Kletzander wrote:
> When a domain was started without registration in sanlock, but libvirt
> was restarted after that, most of the operations failed due to
> contacting sanlock about that process. E.g. migration could not be
> performed because the locks couldn't be
On 05/12/2014 07:37 AM, Martin Kletzander wrote:
> Just move some code around for future patches to ease the review.
> With this patch there is no need for drastic cleanup path later.
>
> Signed-off-by: Martin Kletzander
> ---
> src/locking/lock_driver_sanlock.c | 50
> +++--
On Sun, May 11, 2014 at 12:25:44PM +0400, Roman Bogorodskiy wrote:
> Some syntax-check rules use GNU sed specific regexps, so make
> sure we're using $(SED) instead of sed, which might not be a
> GNU sed.
Simple and obvious fix, ACK.
I will push this shortly, thanks.
Rich.
--
Richard Jones, Vi
> Quoting from http://libvirt.org/hacking.html: "One should avoid
> sending patches as attachments, but rather send them in email body
> along with commit message." We prefer git send-email.
>
>
From 1fe98454aa52d9ef45b048212ae7406cc1ee08f9 Mon Sep 17 00:00:00 2001
From: James Shubin
Date: Sun
On Sun, May 11, 2014 at 12:24:10AM -0400, James wrote:
> Doc patch for apps.html as per: http://libvirt.org/apps.html#add
>
> Cheers,
> James
>
> Disclaimer: I've contributed patches to the project that this commit
> adds.
>
> From 1fe98454aa52d9ef45b048212ae7406cc1ee08f9 Mon Sep 17 00:00:00 20
On Sun, May 11, 2014 at 9:54 AM, James wrote:
> Doc patch for apps.html as per: http://libvirt.org/apps.html#add
>
> Cheers,
> James
>
> Disclaimer: I've contributed patches to the project that this commit
> adds.
>
Quoting from http://libvirt.org/hacking.html: "One should avoid
sending patches a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 12.05.2014 19:05, schrieb Eric Blake:
> [adding libvirt]
>
> On 05/09/2014 05:54 AM, Gerd Hoffmann wrote:
>> Hi,
>>
>>> virt-manager/libvirt seems to default to 9 MByte of Vram for
>>> cirrus, so this would break a lot of setups.
>>
>> It wouldn'
[adding libvirt]
On 05/09/2014 05:54 AM, Gerd Hoffmann wrote:
> Hi,
>
>> virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus,
>> so this would break a lot of setups.
>
> It wouldn't. libvirt sticks that into the xml, but it doesn't set any
> qemu parameters. The libvirt param
Alvin Starr wrote:
> I have updated the libvirt and xen from the f20 latest updates and
> forced all the scripts back to their unadulterated state.
> I believe that I am now seeing libvirt passing a -1 devid to libxl
> expecting libxl to chose the right one.
>
> There was an email thread about this
Ján Tomko wrote:
> On 04/23/2014 11:35 AM, Roman Bogorodskiy wrote:
> > ---
> > src/bhyve/bhyve_driver.c | 31 +++
> > src/bhyve/bhyve_utils.h | 1 +
> > 2 files changed, 32 insertions(+)
> >
>
> ACK
>
> > @@ -1173,6 +1203,7 @@ static virDriver bhyveDriver = {
>
Thanks for your review, and a lot of fixes :) .
Just a comment...
>On 10.05.2014 01:21, Tomoki Sekiyama wrote:
>diff --git a/libvirt-override.c b/libvirt-override.c
>index d0557c2..d08b271 100644
>--- a/libvirt-override.c
>+++ b/libvirt-override.c
>@@ -7564,7 +7564,7 @@ libvirt_virDomainFSFreeze(
On 12.05.2014 17:13, Tomoki Sekiyama wrote:
Thanks for your review, and a lot of fixes :) .
Just a comment...
On 10.05.2014 01:21, Tomoki Sekiyama wrote:
diff --git a/libvirt-override.c b/libvirt-override.c
index d0557c2..d08b271 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -756
I have updated the libvirt and xen from the f20 latest updates and
forced all the scripts back to their unadulterated state.
I believe that I am now seeing libvirt passing a -1 devid to libxl
expecting libxl to chose the right one.
There was an email thread about this problem. "[libvirt] Settin
From: Timm Bäder
---
I've reviewed and pushed this patch directly as it's trivial
Christophe
libvirt-gobject/libvirt-gobject-domain-device-private.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain-device-private.h
b/libvirt-gobje
On 05/12/2014 07:11 AM, Ján Tomko wrote:
> On 05/08/2014 06:02 PM, John Ferlan wrote:
>> A post commit id 'e3d66229' review (and followup):
>>
>> http://www.redhat.com/archives/libvir-list/2014-May/msg00268.html
>>
>> noted some issues with the code, so I have adjusted the code
>> accordingly. Th
ACK
On Fri, May 09, 2014 at 10:28:28PM +0200, Marc-André Lureau wrote:
> From: Marc-André Lureau
>
> ---
> tests/test-gconfig.c| 14 ++
> tests/xml/gconfig-domain-device-channel.xml | 4
> 2 files changed, 18 insertions(+)
>
> diff --git a/tests/test-g
Hey,
On Fri, May 09, 2014 at 10:28:27PM +0200, Marc-André Lureau wrote:
>
> ---
> libvirt-gconfig/Makefile.am| 2 +
> libvirt-gconfig/libvirt-gconfig-domain-channel.h | 1 +
> ...bvirt-gconfig-domain-chardev-source-spiceport.c | 101
> +
> ...b
On 05/12/2014 01:57 PM, Wangrui (K) wrote:
>
> 1.
>
> As shown in the definition of nl_recv, its return value is of INT type.
>
>
>
> int nl_recv(struct nl_handle *handle, struct sockaddr_nl *nla,
>
> unsigned char **buf, struct ucred **creds)
>
>
>
> However, in function virNetlin
When a domain was started without registration in sanlock, but libvirt
was restarted after that, most of the operations failed due to
contacting sanlock about that process. E.g. migration could not be
performed because the locks couldn't be released (or inquired before a
release).
Resolves: https
Just move some code around for future patches to ease the review.
With this patch there is no need for drastic cleanup path later.
Signed-off-by: Martin Kletzander
---
src/locking/lock_driver_sanlock.c | 50 +++
1 file changed, 25 insertions(+), 25 deletions(-
On 10.05.2014 01:21, Tomoki Sekiyama wrote:
> Add binding for the new virDomainFSFreeze and virDomainFSThaw functions
> added in libvirt 1.2.5. These require override since these take a list
> of mountpoints path string. The methods are named 'fSFreeze' and 'fSThaw',
> like a existing 'fSTrim' meth
Doc patch for apps.html as per: http://libvirt.org/apps.html#add
Cheers,
James
Disclaimer: I've contributed patches to the project that this commit
adds.
From 1fe98454aa52d9ef45b048212ae7406cc1ee08f9 Mon Sep 17 00:00:00 2001
From: James Shubin
Date: Sun, 11 May 2014 00:17:23 -0400
Subject: [PAT
s/decription/description/ in the commit message
On 05/12/2014 02:29 PM, Michal Privoznik wrote:
> Our documentation generator is a bit messy, to say the least. For
> instance, the description to return values of a function is searched
> within C comment. Currently, all lines that start with 'retur
Our documentation generator is a bit messy, to say the least. For
instance, the description to return values of a function is searched
within C comment. Currently, all lines that start with 'returns' or
'Returns' are viewed as return value description. However, there are
some valid uses where the '
On 04/23/2014 11:35 AM, Roman Bogorodskiy wrote:
> ---
> src/bhyve/bhyve_driver.c | 31 +++
> src/bhyve/bhyve_utils.h | 1 +
> 2 files changed, 32 insertions(+)
>
ACK
> @@ -1173,6 +1203,7 @@ static virDriver bhyveDriver = {
> .connectClose = bhyveConnectClose,
On 05/08/2014 06:02 PM, John Ferlan wrote:
> A post commit id 'e3d66229' review (and followup):
>
> http://www.redhat.com/archives/libvir-list/2014-May/msg00268.html
>
> noted some issues with the code, so I have adjusted the code
> accordingly. The difference between this and the commit prior
>
Signed-off-by: Zhang Bo
---
src/util/virnetlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
index 4f4dedc..40912f5 100644
--- a/src/util/virnetlink.c
+++ b/src/util/virnetlink.c
@@ -271,7 +271,6 @@ int virNetlinkCommand(struct nl_msg *nl_msg,
In funtcion virNetlinkCommand, it uses the word "error" as the goto out
keyword, but it's not an error-handling branch, so, use "cleanup" instead.
Signed-off-by: Zhang Bo
---
src/util/virnetlink.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/util/virnetlink.
Zhang Bo (2):
util: replace error with cleanup in virNetlinkCommand
util: do not set resp to NULL after VIR_FREE
src/util/virnetlink.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
--
1.7.12.4
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailm
1.
As shown in the definition of nl_recv, its return value is of INT type.
int nl_recv(struct nl_handle *handle, struct sockaddr_nl *nla,
unsigned char **buf, struct ucred **creds)
However, in function virNetlinkCommand, it uses an unsigned int param,
respbuflen, to receive its retur
On 05/09/2014 05:09 PM, Jim Fehlig wrote:
> Chunyan Liu wrote:
>> is supported, but
>> nowhere mentions 'managed' in syntax.
>> Update documentation to cover it.
>>
> Yep, I see the managed attribute is in the schema.
>
>> Signed-off-by: Chunyan Liu
>> ---
>> docs/formatdomain.html.in | 14 +
On 05/09/2014 08:58 AM, Marcelo Tosatti wrote:
> On Wed, May 07, 2014 at 07:35:13PM -0300, Marcelo Tosatti wrote:
>
> Simply adding
>
>
>
>
>
> To cpu_map.xml is sufficient to allow users to enable
> this feature on demand ?
Yes, this is what I posted in v2 of the patch:
http
43 matches
Mail list logo
