On Tue, 2014-05-27 at 11:17 +0200, Jiri Denemark wrote:
> On Mon, May 26, 2014 at 10:21:09 +, chen.fan.f...@cn.fujitsu.com wrote:
> > On Thu, 2014-05-22 at 13:12 +0200, Jiri Denemark wrote:
> > > On Thu, May 22, 2014 at 02:07:32 +, chen.fan.f...@cn.fujitsu.com
> > > wrote:
> > > > On Thu
vcpupin will allow argument --vcpu as a signed number,
and pass it to virDomainPinVcpu directlly without
checking if this value is positive(valid).
> virsh vcpupin r7 -1 0
error: numerical overflow: input too large: 4294967295
This message is inaccurate, and the negative vcpu is
non-valuable. So
* tools/virsh.pod (attach-disk): Drop duplicate --config, fix typo
in --sourcetype.
Signed-off-by: Eric Blake
---
Puhsing under the trivial rule.
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index de9a4f7..02671b4 100644
Eric Blake wrote:
> On 05/28/2014 01:54 PM, Jim Fehlig wrote:
>
>> Commit 292d3f2d fixed the build with libselinux 2.3, but missed
>> some suggestions by eblake
>>
>> https://www.redhat.com/archives/libvir-list/2014-May/msg00977.html
>>
>> This patch changes the macro introduced in 292d3f2d to e
I encountered an AppArmor denial in Ubuntu 14.04. I had filed a bug here
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1324251
I just wanted to see this applied upstream from Ubuntu. This update to the
profile is necessary to write to 9pfs mounts. Let me know what you think about
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote:
> The driver_override field allows us to specify the driver for a device
> rather than relying on the driver to provide a positive match of the
> device. This shortcuts the existing process of looking up the vendor
> and device ID, a
On 05/28/2014 01:54 PM, Jim Fehlig wrote:
> Commit 292d3f2d fixed the build with libselinux 2.3, but missed
> some suggestions by eblake
>
> https://www.redhat.com/archives/libvir-list/2014-May/msg00977.html
>
> This patch changes the macro introduced in 292d3f2d to either be
> empty in the case
On Tue, May 27, 2014 at 09:07:42PM -0600, Bjorn Helgaas wrote:
> On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote:
> > The driver_override field allows us to specify the driver for a device
> > rather than relying on the driver to provide a positive match of the
> > device. This sho
Eric Blake wrote:
> My attempts to tweak this weren't panning out quickly enough, and yours
> definitely fixes a build-breaker, while still working for me with
> libselinux 2.2. Thanks for stepping in and helping :)
>
I managed to get your idea working and sent a cleanup patch.
Regards,
Jim
Commit 292d3f2d fixed the build with libselinux 2.3, but missed
some suggestions by eblake
https://www.redhat.com/archives/libvir-list/2014-May/msg00977.html
This patch changes the macro introduced in 292d3f2d to either be
empty in the case of newer libselinux, or contain 'const' in the
case of o
On 05/28/2014 11:38 AM, Eric Blake wrote:
> On 05/28/2014 06:44 AM, Cédric Bosdonnat wrote:
>> Several function signatures changed in libselinux 2.3, now taking
>> a 'const char *' instead of 'security_context_t'. The latter is
>> defined in selinux/selinux.h as
>>
>> typedef char *security_cont
On 05/28/2014 06:44 AM, Cédric Bosdonnat wrote:
> Several function signatures changed in libselinux 2.3, now taking
> a 'const char *' instead of 'security_context_t'. The latter is
> defined in selinux/selinux.h as
>
> typedef char *security_context_t;
> ---
> m4/virt-selinux.m4|
On 05/28/14 16:43, Eric Blake wrote:
> On 05/28/2014 02:45 AM, Peter Krempa wrote:
>
>>> }
>>
>> But this patch isn't ideal and makes the logic in the code even more
>> entangled.
>> qemuDomainObjRestore returns 1 on corrupted image that was removed, 0 on
>> sucess
>> and -1 on other
On 05/28/14 17:36, Eric Blake wrote:
> On 05/28/2014 09:18 AM, Peter Krempa wrote:
>> Even successful start of a VM from a managed save image would spam the
>> logs with the following message:
>>
>> Unable to restore from managed state [path]. Maybe the file is
>> corrupted?
>>
>> Re-arrange the lo
Cédric Bosdonnat wrote:
> Several function signatures changed in libselinux 2.3, now taking
> a 'const char *' instead of 'security_context_t'. The latter is
> defined in selinux/selinux.h as
>
> typedef char *security_context_t;
> ---
> m4/virt-selinux.m4| 18 ++
>
On 05/28/14 18:48, Eric Blake wrote:
> On 05/28/2014 08:16 AM, Peter Krempa wrote:
>> Now that virStorageFileGetMetadataFromBuf is used only for remote
>> filesystems, don't canonicalize the path in it.
>> ---
>> src/util/virstoragefile.c | 21 +++--
>> 1 file changed, 11 insertion
On 05/28/2014 08:16 AM, Peter Krempa wrote:
> Now that virStorageFileGetMetadataFromBuf is used only for remote
> filesystems, don't canonicalize the path in it.
> ---
> src/util/virstoragefile.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
ACK; counts as a bug
On 05/28/2014 08:16 AM, Peter Krempa wrote:
> Use virStorageFileGetMetadataFromFD instead in
> virStorageBackendProbeTarget as it now returns all required data and the
> storage file is already open in a filedescriptor.
>
> Also fix improper error code being returned when virFileReadHeaderFD
> wou
On 05/28/2014 08:15 AM, Peter Krempa wrote:
> Add argument to return backing file format of a file probed by
> virStorageFileGetMetadataFromFD so that it can be used in place of
> virStorageFileGetMetadataFromBuf.
> ---
> src/qemu/qemu_driver.c| 2 +-
> src/util/virstoragefile.c | 6 --
>
On 05/28/2014 12:58 AM, Peter Krempa wrote:
> On 05/28/14 01:14, Eric Blake wrote:
>> qemu 2.0 added the ability to commit the active layer, but slightly
>> differently than what libvirt had been anticipating in its
>> implementation of the virDomainBlockCommit call. As a result, if
>> you attempt
Alvin Starr wrote:
> On 05/28/2014 02:04 AM, Jim Fehlig wrote:
>> Alvin Starr wrote:
>>
>> Adding to Eric's comments...
>>
>>> I have been trying do some simulations of an openstack environment on
>>> my workstation that is running xen and libvirt.
>>> I managed to create nested HVM environments un
On 05/28/2014 09:18 AM, Peter Krempa wrote:
> Even successful start of a VM from a managed save image would spam the
> logs with the following message:
>
> Unable to restore from managed state [path]. Maybe the file is
> corrupted?
>
> Re-arrange the logic to output the warning only when the imag
Even successful start of a VM from a managed save image would spam the
logs with the following message:
Unable to restore from managed state [path]. Maybe the file is
corrupted?
Re-arrange the logic to output the warning only when the image is
corrupted.
The flaw was introduced in commit cfc28c6
On 05/28/2014 04:46 AM, Laine Stump wrote:
> The original version of virTimeLocalOffsetFromUTC() would fail for
> certain times of the day if daylight savings time was active. This
> could most easily be seen by uncommenting the TEST_LOCALOFFSET() cases
> that include a DST setting.
>
> src/uti
Hi Folks,
Tomorrow (thursday) at 1400 UTC is set for our next weekly meeting
on #virt-meeting of irc.oftc.net
If you have any agenda items to raise please add them to:
https://public.pad.fsfe.org/p/libvirt-community-meeting
NB, I will likely be offline tomorrow at the Xen Community Hackathon,
On 05/28/2014 02:45 AM, Peter Krempa wrote:
>> }
>
> But this patch isn't ideal and makes the logic in the code even more
> entangled.
> qemuDomainObjRestore returns 1 on corrupted image that was removed, 0 on
> sucess
> and -1 on other errors. The condition right above that hunk tes
Now that virStorageFileGetMetadataFromBuf is used only for remote
filesystems, don't canonicalize the path in it.
---
src/util/virstoragefile.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 43
Add argument to return backing file format of a file probed by
virStorageFileGetMetadataFromFD so that it can be used in place of
virStorageFileGetMetadataFromBuf.
---
src/qemu/qemu_driver.c| 2 +-
src/util/virstoragefile.c | 6 --
src/util/virstoragefile.h | 3 ++-
3 files changed, 7 inse
Currently a gluster pool fails to start due to an attempt to canonicalize a
path residing on gluster storage. This series rearranges things to avoid that.
Peter Krempa (3):
storage: Return backing format from virStorageFileGetMetadataFromFD
storage: fs: Drop-in replace use of virStorageFileGe
Use virStorageFileGetMetadataFromFD instead in
virStorageBackendProbeTarget as it now returns all required data and the
storage file is already open in a filedescriptor.
Also fix improper error code being returned when virFileReadHeaderFD
would fail as virStorageBackendUpdateVolTargetInfoFD would
On 05/28/2014 02:04 AM, Jim Fehlig wrote:
Alvin Starr wrote:
Adding to Eric's comments...
I have been trying do some simulations of an openstack environment on
my workstation that is running xen and libvirt.
I managed to create nested HVM environments under lx but found a
number of shortfalls
Several function signatures changed in libselinux 2.3, now taking
a 'const char *' instead of 'security_context_t'. The latter is
defined in selinux/selinux.h as
typedef char *security_context_t;
---
m4/virt-selinux.m4| 18 ++
tests/securityselinuxhelper.c | 16
During guest migration, if the domain xml is bigger than 16384 which is
easily possible for a guest with good number of disks, message encode fails
for xdr_remote_domain_migrate_perform3_ret().
So, Increase the COOKIE_MAX to STRING_MAX value.
Signed-off-by: Shivaprasad G Bhat
---
src/remote/remo
On Wed, May 28, 2014 at 11:18:30AM +0100, Daniel P. Berrange wrote:
On Wed, May 28, 2014 at 11:48:31AM +0200, Martin Kletzander wrote:
Caveats:
- I'm not sure how cpu hotplug is done with guest numa nodes, but if
there is a possibility to increase the number of numa nodes (which
does not
On Wed, May 28, 2014 at 01:44:49PM +0200, Martin Kletzander wrote:
> On Wed, May 28, 2014 at 11:29:40AM +0100, Daniel P. Berrange wrote:
> >On Wed, May 28, 2014 at 11:48:36AM +0200, Martin Kletzander wrote:
> >>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> >>index 4818cfb..b77914e
On Wed, May 28, 2014 at 11:29:40AM +0100, Daniel P. Berrange wrote:
On Wed, May 28, 2014 at 11:48:36AM +0200, Martin Kletzander wrote:
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4818cfb..b77914e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -17524,7
On 05/28/14 12:15, Dan Kenigsberg wrote:
> The documentation of the functions should match the argument name in the
> actual
> function signature.
>
> Signed-off-by: Dan Kenigsberg
> ---
> src/libvirt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
ACK and safe for release.
The original version of virTimeLocalOffsetFromUTC() would fail for
certain times of the day if daylight savings time was active. This
could most easily be seen by uncommenting the TEST_LOCALOFFSET() cases
that include a DST setting.
After a lot of experimenting, I found that the way to solve it in
On Wed, May 28, 2014 at 11:48:36AM +0200, Martin Kletzander wrote:
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 4818cfb..b77914e 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -17524,7 +17524,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
>
On Wed, May 28, 2014 at 11:48:31AM +0200, Martin Kletzander wrote:
> Caveats:
>
> - I'm not sure how cpu hotplug is done with guest numa nodes, but if
>there is a possibility to increase the number of numa nodes (which
>does not make sense to me from (a) user point of view and (b) our
>
The documentation of the functions should match the argument name in the actual
function signature.
Signed-off-by: Dan Kenigsberg
---
src/libvirt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 72a9f6d..f01b6dd 100644
--- a/src/libv
Currently, we only bind the whole QEMU domain to memory nodes
specified in nodemask altogether. That, however, doesn't make much
sense when one wants to control from where the memory for particular
guest nodes should be allocated. QEMU allows us to do that by
specifying 'host-nodes' parameter for
The numa patch series in qemu adds "query-memdev" command by which we
can tell whether we can use memory objects.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/qemu/qemu_capabilitie
This element specifies similar settings as the memory element,
although memnode can be used per guest NUMA node.
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 18 +
docs/schemas/domaincommon.rng | 17
src/conf/domain_conf.c| 181 +
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1d5bce6..9e674a2 100644
--- a/src/qemu/qem
Currently we are only able to bind the whole domain to some host nodes
using the /domain/numatune/memory element. Numerous requests were
made to support host<->guest numa node bindings, so this series tries
to pinch an idea on how to do that using /domain/numatune/memnode
elements.
So here are fe
In XML format, by definition, order of fields should not matter, so
oder of parsing the elements doesn't affect the end result. When
specifying guest NUMA cells, we depend only on the order of the 'cell'
elements. With this patch all older domain XMLs are parsed as before,
but with the 'id' attri
On 05/28/14 11:33, Jincheng Miao wrote:
> vcpupin will allow argument --vcpu as a signed number,
> and pass it to virDomainPinVcpu directlly without
> checking if this value is positive(valid).
>
>> virsh vcpupin r7 -1 0
> error: numerical overflow: input too large: 4294967295
>
> This message is
From: Wido den Hollander
This way users can manually set options in librados which might suite
their needs better.
---
docs/schemas/storagepool.rng |1 +
src/storage/storage_backend_rbd.c| 16
tests/storagepoolxml2xmlin/pool-rbd.xml |3 +++
tests/s
This series of patches adds the ability to pass down options to the
storage pool drivers.
In the case of NFS users can specify mount options and in the case of
RBD users can specify options for librados to influence some behavior.
All options and values are checked on input validity to prevent in
This way users can provide mount options for for example NFS
storage pools.
---
src/storage/storage_backend_fs.c | 44 ++
1 file changed, 44 insertions(+)
diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 33551e7..66d7bec
From: Wido den Hollander
This allows the end-user to pass down options to the storage pool
backend.
For example NFS could get mount options or Ceph librados options
passed down.
---
docs/schemas/storagepool.rng | 16 +
docs/storage.html.in | 48 +
src
vcpupin will allow argument --vcpu as a signed number,
and pass it to virDomainPinVcpu directlly without
checking if this value is positive(valid).
> virsh vcpupin r7 -1 0
error: numerical overflow: input too large: 4294967295
This message is inaccurate, and the negative vcpu is
non-valuable. So
vhost-user is a networking backend based on unix domain sockets
instead of tap devices and ioctl(). This makes it possible for
userspace networking stacks (vswitches) to provide vhost-networking to
guests.
Signed-off-by: Luke Gorrie
---
docs/schemas/domaincommon.rng | 23 +++
Howdy!
This patch adds support for the QEMU vhost-user feature to Libvirt.
vhost-user is an efficient interface between guests and userspace
network stacks (vswitches).
Our goal is to have vhost-user supported in the OpenStack Juno
release. We hope it is okay to start code review on qemu, Libvirt
On 05/28/14 01:28, Eric Blake wrote:
> On 05/27/2014 05:24 PM, Eric Blake wrote:
>> On 05/27/2014 08:06 AM, Jason J. Herne wrote:
>>> From: "Jason J. Herne"
>>>
>>> qemuDomainObjStart is checking the return code from qemuDomainObjRestore for
>>> errors even after determining that the return code i
On 05/28/14 03:53, Eric Blake wrote:
> On 05/26/2014 03:27 AM, Peter Krempa wrote:
>> On 05/23/14 18:38, Eric Blake wrote:
>>> On 05/22/2014 07:47 AM, Peter Krempa wrote:
My future work will modify the metadata crawler function to use the
storage driver file APIs to access the files inste
And don't forget to update comments if localtime_r is removed :)
> > + * This function is threadsafe, but is *not* async signal safe (due to
> > + * localtime_r()).
> -Original Message-
> From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
> On Behalf Of Laine Stu
On 05/28/14 01:14, Eric Blake wrote:
> qemu 2.0 added the ability to commit the active layer, but slightly
> differently than what libvirt had been anticipating in its
> implementation of the virDomainBlockCommit call. As a result, if
> you attempt to do a 'virsh blockcommit $dom vda', qemu gets i
59 matches
Mail list logo
