Eric Blake wrote:
> On 06/13/2014 01:00 PM, Roman Bogorodskiy wrote:
> > When virBhyveProcessStart() fails, it tries to unload
> > a guest that could have been already loaded using
> > bhyveload(8) to make sure not to leave it hanging in memory.
> >
> > However, we could fail before loading a V
On 06/13/2014 01:00 PM, Roman Bogorodskiy wrote:
> When virBhyveProcessStart() fails, it tries to unload
> a guest that could have been already loaded using
> bhyveload(8) to make sure not to leave it hanging in memory.
>
> However, we could fail before loading a VM into memory,
> so 'bhyvectl --d
When virBhyveProcessStart() fails, it tries to unload
a guest that could have been already loaded using
bhyveload(8) to make sure not to leave it hanging in memory.
However, we could fail before loading a VM into memory,
so 'bhyvectl --destroy' command will fail and print
an error message that loo
Eric Blake wrote:
> On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> > virBhyveProcessStart() calls bhyveNetCleanup() if it fails. However,
> > it might fail earlier than networks are allocated, so modify
> > bhyveNetCleanup() to check if net->ifname is not NULL before
> > going further with t
Eric Blake wrote:
> On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> > bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
> > passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
> > if virNetDevTapCreateInBridgePort() crashes after successfully
> > creating a TAP devic
On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> virBhyveProcessStart() calls bhyveNetCleanup() if it fails. However,
> it might fail earlier than networks are allocated, so modify
> bhyveNetCleanup() to check if net->ifname is not NULL before
> going further with the cleanup.
> ---
> src/bhyve/
On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
> passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
> if virNetDevTapCreateInBridgePort() crashes after successfully
> creating a TAP device, it'll jump to 'error' label,
Craig Rodrigues reported a problem on freebsd-virtualization list when
libvirtd with bhyve driver crashes when the bridge does not exist [1].
1:
http://docs.freebsd.org/cgi/getmsg.cgi?fetch=1431191+0+current/freebsd-virtualization
These two patches addresses the problem.
Roman Bogorodskiy (2):
virBhyveProcessStart() calls bhyveNetCleanup() if it fails. However,
it might fail earlier than networks are allocated, so modify
bhyveNetCleanup() to check if net->ifname is not NULL before
going further with the cleanup.
---
src/bhyve/bhyve_process.c | 10 ++
1 file changed, 6 insertions
bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
if virNetDevTapCreateInBridgePort() crashes after successfully
creating a TAP device, it'll jump to 'error' label, that
loops over tapfd and calls VIR_FORCE_CLOSE:
for
This patch series was first hinted at here:
https://www.redhat.com/archives/libvir-list/2014-June/msg00589.html
It fixes a minor bug that has existed since blockcommit was first
added, where we had an off-by-one that caused us to generate
different error messages in some cases where a user was pas
The next patch will be adding tests; for ease of review of that
patch, I want to create common context lines that don't change
when the new tests are added (it's easier to visually review
additions than it is to review an entire chunk of tests rewritten
into another larger chunk of tests).
* tests
The block commit code looks for an explicit base file relative
to the discovered top file; so for a chain of:
base <- snap1 <- snap2 <- snap3
and a command of:
virsh blockcommit $dom vda --base snap2 --top snap1
we got a sane message (here from libvirt 1.0.5):
error: invalid argument: could not
Typing chain->backingStore->backingStore gets old after a while;
introduce some alias variables to make the test more compact.
* tests/virstoragetest.c (mymain): Introduce some shorthand.
Signed-off-by: Eric Blake
---
tests/virstoragetest.c | 63 +
Add some more tests of what happens when we restrict a lookup
to begin at a point in the middle of a chain. In particular,
we want to ensure that a parent is not found when starting at
the child. This commit also demonstrates that we have a slight
difference in behavior on what parent we report w
On 06/13/2014 08:52 AM, Eric Blake wrote:
> On 06/13/2014 08:48 AM, Giuseppe Scrivano wrote:
>> Report VIR_ERR_NO_STORAGE_VOL instead of a system error when lstat
>> fails because the file doesn't exist.
>>
>> Fixes this problem in virt-install:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1
Ján Tomko wrote:
> On 06/01/2014 07:53 PM, Roman Bogorodskiy wrote:
> > Automatically allocate PCI addresses for devices instead
> > of hardcoding them in the driver code. The current
> > allocation schema is to dedicate an entire slot for each devices.
> >
> > Also, allow having arbitrary numb
On 06/13/2014 08:48 AM, Giuseppe Scrivano wrote:
> Report VIR_ERR_NO_STORAGE_VOL instead of a system error when lstat
> fails because the file doesn't exist.
>
> Fixes this problem in virt-install:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1108922
>
> Signed-off-by: Giuseppe Scrivano
>
Report VIR_ERR_NO_STORAGE_VOL instead of a system error when lstat
fails because the file doesn't exist.
Fixes this problem in virt-install:
https://bugzilla.redhat.com/show_bug.cgi?id=1108922
Signed-off-by: Giuseppe Scrivano
---
src/storage/storage_backend.c | 12 +---
1 file change
On 13.06.2014 10:28, Daniel P. Berrange wrote:
On Thu, Jun 12, 2014 at 07:21:47PM +0200, Martin Kletzander wrote:
On Thu, Jun 12, 2014 at 02:30:50PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 10, 2014 at 07:21:12PM +0200, Michal Privoznik wrote:
There are two places where you'll find info on
On 06/13/14 00:38, Eric Blake wrote:
> On 06/12/2014 09:02 AM, Peter Krempa wrote:
>> Now that we have pointers to store disk source information and thus can
>> easily exchange the structs behind we need a function to copy all the
>> data.
>> ---
>> src/libvirt_private.syms | 1 +
>> src/util/v
On 13.06.2014 12:25, Laine Stump wrote:
On 06/13/2014 12:34 PM, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is in other state
than 'up' . While on some we experience -EINVAL when read()-ing the
s
On 06/12/14 23:19, Eric Blake wrote:
> On 06/12/2014 09:02 AM, Peter Krempa wrote:
>> ---
>> src/util/virstorageencryption.c | 39 +++
>> src/util/virstorageencryption.h | 2 ++
>> 2 files changed, 41 insertions(+)
>
> I've definitely been wishing for this; as
On 06/04/2014 12:14 PM, Daniel P. Berrange wrote:
On Tue, Jun 03, 2014 at 05:33:13PM +0200, Ján Tomko wrote:
On 05/28/2014 11:38 AM, Wido den Hollander wrote:
This series of patches adds the ability to pass down options to the
storage pool drivers.
In the case of NFS users can specify mount
On 06/13/2014 12:34 PM, Michal Privoznik wrote:
> The kernel's more broken than one would think. Various drivers report
> various (usually spurious) values if the interface is in other state
> than 'up' . While on some we experience -EINVAL when read()-ing the
> speed sysfs file, with other drivers
On 13.06.2014 11:23, Laine Stump wrote:
On 06/13/2014 10:50 AM, Martin Kletzander wrote:
On Fri, Jun 13, 2014 at 10:31:53AM +0300, Laine Stump wrote:
On 06/13/2014 10:10 AM, Martin Kletzander wrote:
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken tha
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is in other state
than 'up' . While on some we experience -EINVAL when read()-ing the
speed sysfs file, with other drivers we might get anything from 0 to
UINT_MAX. If that's the
On 06/13/2014 10:50 AM, Martin Kletzander wrote:
> On Fri, Jun 13, 2014 at 10:31:53AM +0300, Laine Stump wrote:
>> On 06/13/2014 10:10 AM, Martin Kletzander wrote:
>>> On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drive
On 06/13/2014 11:30 AM, Daniel P. Berrange wrote:
> On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
>> The kernel's more broken than one would think. Various drivers report
>> various (usually spurious) values if the interface is down. While on
>> some we experience -EINVAL when r
On 06/13/14 05:51, Eric Blake wrote:
> On 06/11/2014 05:45 AM, Peter Krempa wrote:
>> When the test is failing but the debug output isn't enabled the
>> resulting line would look ugly like and would not contain the actual
>> difference.
>>
>> TEST: virstoragetest
>> .chain mem
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
> The kernel's more broken than one would think. Various drivers report
> various (usually spurious) values if the interface is down. While on
> some we experience -EINVAL when read()-ing the speed sysfs file, with
> other drivers we
On Thu, Jun 12, 2014 at 07:21:47PM +0200, Martin Kletzander wrote:
> On Thu, Jun 12, 2014 at 02:30:50PM +0100, Daniel P. Berrange wrote:
> >On Tue, Jun 10, 2014 at 07:21:12PM +0200, Michal Privoznik wrote:
> >>There are two places where you'll find info on huge pages. The first
> >>one is under el
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, June 12, 2014 4:16 PM
> To: Wangrui (K)
> Cc: libvir-list@redhat.com; Zengjunliang; ebl...@redhat.com
> Subject: Re: [PATCH RFC 0/3] allow setting video ram size for graphics
>
> On Do, 2014-06-12 at 0
On 13.06.2014 09:31, Laine Stump wrote:
On 06/13/2014 10:10 AM, Martin Kletzander wrote:
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is down. While on
s
On 12.06.2014 15:13, Laine Stump wrote:
On 06/05/2014 06:39 PM, Michal Privoznik wrote:
+
+/* Workaround broken kernel API. If the link is unplugged then
+ * depending on the NIC driver, link speed can be reported as -1.
+ * However, the value is printed out as unsigned i
On Fri, Jun 13, 2014 at 10:31:53AM +0300, Laine Stump wrote:
On 06/13/2014 10:10 AM, Martin Kletzander wrote:
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interfac
On 06/13/2014 10:10 AM, Martin Kletzander wrote:
> On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
>> The kernel's more broken than one would think. Various drivers report
>> various (usually spurious) values if the interface is down. While on
>> some we experience -EINVAL when re
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is down. While on
some we experience -EINVAL when read()-ing the speed sysfs file, with
other drivers we might
38 matches
Mail list logo
