Add 'nocow' to storage volume xml so that user can have an option
to set NOCOW flag to the newly created volume. It's useful on btrfs
file system to enhance performance.
Btrfs has low performance when hosting VM images, even more when the guest
in those VM are also using btrfs as file system. One
> -Original Message-
> From: Ján Tomko [mailto:jto...@redhat.com]
> Sent: Monday, July 07, 2014 6:54 PM
> To: Chen, Hanxiao/陈 晗霄; libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH] LXC: introduce lxcDomainSetMemoryFlags
>
> On 07/04/2014 10:21 AM, Chen Hanxiao wrote:
> > In lxc, we
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Cgroups code uses VIR_CGROUP_DEVICE_* flags to specify the mode but in
> the end it needs to be converted to a string. Add a helper to do it and
> use it in the cgroup code before introducing it into the rest of the
> code.
> ---
> src/libvirt_private.
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> When discovering a disk backing chain the parent disk's metadata need to
> be populated into the guest images so that each piece of the backing
> chain contains a copy of those. This will allow us to refactor the
> security driver so that it will not ne
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> We are going to modify storage source chains in place. Add a helper that
> will copy relevant information such as security labels to the new
> element if that doesn't contain it.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstoragefile.c | 4
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Now that we have pointers to store disk source information and thus can
> easily exchange the structs behind we need a function to copy all the
> data.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstoragefile.c | 194
>
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> In the future we might need to track state of individual images. Move
> the readonly and shared flags to the virStorageSource struct so that we
> can keep them in a per-image basis.
> ---
Mostly mechanical. ACK
--
Eric Blake eblake redhat com+1
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Some of the further changes will propagate seclabels from a disk source
> element into the backing store elements. This would change the XML
> output of the backing store as the seclabels would be formatted for each
> backing store element. Skip the sec
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Allow de-init of null storage sources.
> ---
> src/storage/storage_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
ACK
> diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
> index 8c0c5d6..ae86c69 100644
> --
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Add a wrapper that determines the correct uid and gid for a certain
> storage file and domain.
> ---
> src/qemu/qemu_domain.c | 23 +++
> src/qemu/qemu_domain.h | 4
> 2 files changed, 27 insertions(+)
>
ACK
--
Eric Blake
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> It will help re-using the function.
> ---
> src/qemu/qemu_domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
ACK
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signatu
On 07/04/2014 05:29 AM, Peter Krempa wrote:
> Add backends for this frontend function so that we can use it in the
> snapshot creation code.
> ---
> src/storage/storage_backend_fs.c | 17 +
> src/storage/storage_backend_gluster.c | 28
> 2 files ch
On 07/04/2014 05:22 AM, Peter Krempa wrote:
> Now that we are able to select images from the backing chain via indexed
> access we should also convert possible network sources to
> qemu-compatible strings before passing them to qemu.
> ---
> src/qemu/qemu_driver.c | 45
On 07/04/2014 05:22 AM, Peter Krempa wrote:
> Now that we are able to select images from the backing chain via indexed
> access we should also convert possible network sources to
> qemu-compatible strings before passing them to qemu.
> ---
> src/qemu/qemu_driver.c | 38
On 07/04/2014 05:22 AM, Peter Krempa wrote:
> Introduce flag for the block rebase API to allow the rebase operation to
> leave the chain relatively addressed. Also adds a virsh switch to enable
> this behavior.
> ---
> include/libvirt/libvirt.h.in | 3 +++
> src/libvirt.c| 3 +++
On 07/04/2014 05:22 AM, Peter Krempa wrote:
> Introduce flag for the block commit API to allow the commit operation to
> leave the chain relatively addressed. Also adds a virsh switch to enable
> this behavior.
> ---
> include/libvirt/libvirt.h.in | 3 +++
> src/libvirt.c| 5 +
On 07/07/2014 07:57 AM, Ján Tomko wrote:
> From: Hu Jianwei
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1077009
> ---
> src/conf/nwfilter_conf.c | 11 +++
> 1 file changed, 11 insertions(+)
ACK.
>
> diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
> index 0f633da..
FWIW this is still an issue with current libvirt git, but I haven't dug into
it any further.
- Cole
On 05/03/2014 04:54 PM, Cole Robinson wrote:
> I'm seeing a regression with:
>
> commit 79f11b35c77b3c286c84312dc9737c2ccbf67ed5
> Author: Eric Blake
> Date: Tue Apr 8 14:26:02 2014 -0600
>
>
On 07/04/2014 10:52 AM, Arunas Ruksnaitis wrote:
> Now I am starting to move forward, and have discovered that snapshot is
> only supported as QEMU native "savevm" command, which only works on QCOW2
> backing image.
That's not the only supported snapshot; we also support creating
external snapsho
On 07/07/2014 12:33 AM, Ján Tomko wrote:
> Commits e18a80a and 57e5c3c switched from a getenv wrapper which
> does not allocate a string to virFileFindResource which does not,
> without freeing it.
I think you meant s/which does not/which does/ in the second use of the
phrase.
>
> https://bugzil
On 07/07/2014 02:32 AM, Puneet Bakshi wrote:
> Hi,
>
> I want to work with "guest-fsfreeze-*" commands in Windows 2008 guest VM.
> Host is CentOS 6.4.
>
> Windows 2008 is running QEMU VSS provider. When "guest-fsfreeze-*" commands
> are invoked from host, response received is "This is not support
On 07/04/2014 06:25 AM, Peter Krempa wrote:
> ---
> docs/auditlog.html.in | 20
> src/conf/domain_audit.c | 48
> 2 files changed, 68 insertions(+)
>
> diff --git a/docs/auditlog.html.in b/docs/auditlog.html.in
> index 8528b5
On 07/04/2014 06:25 AM, Peter Krempa wrote:
> Add startup auditing and also hotplug auditing for said devices.
> ---
> docs/auditlog.html.in| 15 +++
> src/conf/domain_audit.c | 42 ++
> src/conf/domain_audit.h | 7 +++
> src/libvirt_p
On 07/07/2014 06:16 AM, Peter Krempa wrote:
> The qemu block info function relied on working with local storage. Break
> this assumption by adding support for remote volumes. Unfortunately we
> still need to take a hybrid approach as some of the operations require a
> filedescriptor.
>
> Previousl
On 07/07/2014 06:16 AM, Peter Krempa wrote:
> The gluster code had two functions for reading volume headers, remove
> one and reuse the second one.
> ---
> src/storage/storage_backend_gluster.c | 43
> ++-
> 1 file changed, 2 insertions(+), 41 deletions(-)
>
ACK.
On 07/07/2014 06:16 AM, Peter Krempa wrote:
> To allow reusing this function in the qemu driver we need to allow to
> specify the storage format. Also separate return of the backing store
s/to specify/specifying/
> path now isn't necessary.
> ---
> src/storage/storage_backend_gluster.c | 5
On 07/07/2014 06:16 AM, Peter Krempa wrote:
> There was just one callsite left. Integrate the body to the only calling
> function.
> ---
> src/util/virstoragefile.c | 91
> ---
> 1 file changed, 39 insertions(+), 52 deletions(-)
ACK.
--
Eric Blake
On 07/07/2014 06:40 AM, Peter Krempa wrote:
> Snapshots and block-copy have a flag that forces qemu to re-use existing
> file. Our docs weren't exactly clear on what the existing file should
> contain for this to actually work.
>
> Re-word the docs a bit to state that the file needs to be pre-crea
On 07/07/2014 12:35 PM, Tony Asleson wrote:
> Eric posted this a while back (ref:
> http://www.redhat.com/archives/libvir-list/2010-April/msg00226.html)
> without any apparent response/discussion.
>
> Can someone please elaborate on this?
At this point, we really aren't too worried about libtool
Eric posted this a while back (ref:
http://www.redhat.com/archives/libvir-list/2010-April/msg00226.html)
without any apparent response/discussion.
Can someone please elaborate on this?
Thanks,
Tony
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-
Translate libvirt discard settings into libxl-4.5 discard settings.
Signed-off-by: Olaf Hering
---
v3:
passing discard= with old libxl is now a fatal error
v2:
add cast to switch variable to let compiler check if the code handles
all enum values
src/libxl/libxl_conf.c | 31 ++
Thanks for the links. I'll definitely check them out.
The source code can be found at bossonvz.bosson.eu. But have in mind that the
bossonvz driver uses only a subset of the vzkernel API. Some vzctl
functionality is not implemented as it was not needed. Backwards compatibility
with older vz ker
--
David Fabian
Cluster Design, s.r.o.
Dne Čt 3. července 2014 23:17:12, Pavel Emelyanov napsal(a):
> On 07/03/2014 03:49 PM, Bosson VZ wrote:
> > Fair enough. We have no problem to adapt to the new process. I don't know
> > how libcontainer is designed
> > internally and how low-level it is but
On Mon, Jul 07, 2014 at 04:05:34PM +0200, Olaf Hering wrote:
> Translate libvirt discard settings into libxl-4.5 discard settings.
>
> Signed-off-by: Olaf Hering
> ---
> v2:
> add cast to switch variable to let compiler check if the code handles
> all enum values
>
> src/libxl/libxl_conf.c |
On Mon, Jul 07, 2014 at 04:00:44PM +0200, Olaf Hering wrote:
> On Fri, May 30, Jim Fehlig wrote:
>
> > Olaf Hering wrote:
> > > +if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
> > > +return;
> > > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> > > + _("This versio
Here are a 2 fixes that make virt-sandbox-service work for me.
One allows it to work if selinux isn't handled by libvirtd, the other
safely handles some file copying that can be different across distros.
Cédric Bosdonnat (2):
virt-sandbox-service: check for security label only if they can be
virt-sandbox-service assumes libvirt has selinux security model...
which is not necessarily the case. If no security model is defined,
then don't check for dynamic labels.
---
bin/virt-sandbox-service | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/bin/
Don't fail is /etc/rc.d/init.d/functions doesn't exist: this is
deprecated in LSB and /lib/lsb/init-functions should be used instead.
Similarily, SUSE distros have /etc/skel/.profile instead of
/etc/skel/.bash_profile. Added one more file to check and be more
lennient with missing ones
---
bin/vi
On Mon, Jul 07, Daniel P. Berrange wrote:
> IIUC, this is not about the underlying storage, but about whether the
> hypervisor API supports the discard setting. The libvirt policy is to
> always raise VIR_ERR_CONFIG_UNSUPPORTED and return failure to the app
> if they request a setting that the hyp
Translate libvirt discard settings into libxl-4.5 discard settings.
Signed-off-by: Olaf Hering
---
v2:
add cast to switch variable to let compiler check if the code handles
all enum values
src/libxl/libxl_conf.c | 28
1 file changed, 28 insertions(+)
diff --git a
On Fri, May 30, Jim Fehlig wrote:
> Olaf Hering wrote:
> > +if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
> > +return;
> > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> > + _("This version of libxenlight does not support "
> > + "discard= opt
From: Hu Jianwei
https://bugzilla.redhat.com/show_bug.cgi?id=1077009
---
src/conf/nwfilter_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
index 0f633da..52f24e4 100644
--- a/src/conf/nwfilter_conf.c
+++ b/src/conf/nwfil
On Mon, Jul 07, 2014 at 01:44:06PM +0200, Pavel Hrdina wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1076098
We support vram option for video devices in domain xml, but so far
only for QXL it had some effect. VGA video device in QEMU can also
accept the size of video ram and we should pass
Snapshots and block-copy have a flag that forces qemu to re-use existing
file. Our docs weren't exactly clear on what the existing file should
contain for this to actually work.
Re-word the docs a bit to state that the file needs to be pre-created in
the desired format and the backing chain metada
On 07/07/2014 01:44 PM, Pavel Hrdina wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1076098
>
> We support vram option for video devices in domain xml, but so far
> only for QXL it had some effect. VGA video device in QEMU can also
> accept the size of video ram and we should pass it.
>
Ev
On Mon, Jul 07, 2014 at 02:19:39PM +0200, Christophe Fergeau wrote:
> Ideally, this should be changed to be automatically substituted from
> whatever is listed in configure.ac.
https://www.redhat.com/archives/libvir-list/2014-July/msg00315.html
does that.
Christophe
pgpK7UvPqA4XH.pgp
Descripti
This way we don't have to keep track of the minimum glib2 version we
need in 2 separate places.
Signed-off-by: Christophe Fergeau
---
configure.ac | 1 +
libvirt-glib.spec.in | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 097f7f4..
On 07/07/14 13:20, Ján Tomko wrote:
> For inactive domains, set both current and maximum memory
> to the specified 'maximum memory' value.
>
> This matches the behavior of QEMU driver's SetMaxMemory.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1091132
> ---
> src/lxc/lxc_driver.c | 11 ++
On Mon, Jul 07, 2014 at 12:55:33PM +0200, Christophe Fergeau wrote:
> GTask was introduced in glib 2.36, so configure.ac needs to be updated
> to reflect that.
Forgot to add here that the minimum glib requirement is also listed in
libvirt-glib.spec.in. Ideally, this should be changed to be automat
The qemu block info function relied on working with local storage. Break
this assumption by adding support for remote volumes. Unfortunately we
still need to take a hybrid approach as some of the operations require a
filedescriptor.
Previously you'd get:
$ virsh domblkinfo gl vda
error: cannot s
There was just one callsite left. Integrate the body to the only calling
function.
---
src/util/virstoragefile.c | 91 ---
1 file changed, 39 insertions(+), 52 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 9208b77
To allow reusing this function in the qemu driver we need to allow to
specify the storage format. Also separate return of the backing store
path now isn't necessary.
---
src/storage/storage_backend_gluster.c | 5 -
src/util/virstoragefile.c | 31 ++-
sr
And a few refactors.
Peter Krempa (4):
util: storage: Inline use of virStorageFileGetMetadataFromFDInternal
util: storage: Allow specifying format for
virStorageFileGetMetadataFromBuf
storage: gluster: Optimize header reader functions
qemu: refactor qemuDomainGetBlockInfo to work with
The gluster code had two functions for reading volume headers, remove
one and reuse the second one.
---
src/storage/storage_backend_gluster.c | 43 ++-
1 file changed, 2 insertions(+), 41 deletions(-)
diff --git a/src/storage/storage_backend_gluster.c
b/src/storag
https://bugzilla.redhat.com/show_bug.cgi?id=1076098
We support vram option for video devices in domain xml, but so far
only for QXL it had some effect. VGA video device in QEMU can also
accept the size of video ram and we should pass it.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_command.c |
For inactive domains, set both current and maximum memory
to the specified 'maximum memory' value.
This matches the behavior of QEMU driver's SetMaxMemory.
https://bugzilla.redhat.com/show_bug.cgi?id=1091132
---
src/lxc/lxc_driver.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(
On 07/07/14 12:24, Ján Tomko wrote:
> On 07/04/2014 03:08 PM, Peter Krempa wrote:
>> Similary to cmdDetachDisk fetch the inactive definition when --config
>
> *Similarly
>
>> is specified as the active may not contain the network interface
>> if it was plugged with --config.
>>
>> Resolves: https
This is returning a char *
xxx
while the next patch exposes the model from the /domain/cpu/model node
as an actual object, why the difference?
Christophe
On Fri, Jul 04, 2014 at 02:51:26PM +0100, Zeeshan Ali (Khattak) wrote:
> Add a method to get the model of the CPU from
On Fri, Jul 04, 2014 at 02:51:28PM +0100, Zeeshan Ali (Khattak) wrote:
> Add a method to set model of domain CPU.
> ---
> libvirt-gconfig/libvirt-gconfig-domain-cpu.c | 11 +++
> libvirt-gconfig/libvirt-gconfig-domain-cpu.h | 4
> libvirt-gconfig/libvirt-gconfig.sym | 2 ++
On 07/07/14 12:36, Ján Tomko wrote:
> On 07/04/2014 02:25 PM, Peter Krempa wrote:
>> V2 adds docs to docs/auditlog.html.in and doesn't log the shared
>> serial/console
>> def twice. Sending for sanity review of language :)
>>
>> Peter Krempa (2):
>> audit: Add auditing for serial/parallel/channe
On Fri, Jul 04, 2014 at 02:51:27PM +0100, Zeeshan Ali (Khattak) wrote:
> diff --git a/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c
> b/libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c
> new file mode 100644
> index 000..514a2e3
> --- /dev/null
> +++ b/libvirt-gconfig/libvirt-gconfig-do
Hey,
On Mon, Jun 30, 2014 at 07:50:16PM +0200, Timm Bäder wrote:
> ---
> libvirt-gobject/libvirt-gobject-domain.c | 60
>
> libvirt-gobject/libvirt-gobject-domain.h | 10 ++
> libvirt-gobject/libvirt-gobject.sym | 2 ++
> 3 files changed, 72 insertions(
On 07/04/2014 03:58 PM, Cédric Bosdonnat wrote:
> Tiny fix for virt-lxc-convert: we are setting memory values in bytes, while
> free may give us values in a different unit by default: force free to output
> bytes with -b flag.
>
> ---
> examples/lxcconvert/virt-lxc-convert | 2 +-
> 1 file change
On 07/04/2014 10:21 AM, Chen Hanxiao wrote:
> In lxc, we could not use setmem command
> with --config options.
> This patch will add support for this.
>
> Signed-off-by: Chen Hanxiao
> ---
> src/lxc/lxc_driver.c | 52
> ++--
> 1 file changed, 42 i
On 07/04/2014 02:25 PM, Peter Krempa wrote:
> V2 adds docs to docs/auditlog.html.in and doesn't log the shared
> serial/console
> def twice. Sending for sanity review of language :)
>
> Peter Krempa (2):
> audit: Add auditing for serial/parallel/channel/console character devs
> audit: Audit s
Hey,
On Mon, Jun 30, 2014 at 07:50:15PM +0200, Timm Bäder wrote:
> ... which returns a GList of GVirDomainSnapshots, i.e. without any tree
> structure or other relationship between the snapshots.
Looks good, ACK. Any plans to return the snapshots as a tree at some
point? Or can the library user r
On Mon, Jun 30, 2014 at 07:50:14PM +0200, Timm Bäder wrote:
> This function can be used to fetch the snapshots of a domain (according
> to the given GVirDomainSnapshotListFlags) and save them in a
> domain-internal GHashTable. A function to access them from outside will
> be added in a later patch.
On 07/04/2014 03:08 PM, Peter Krempa wrote:
> Similary to cmdDetachDisk fetch the inactive definition when --config
*Similarly
> is specified as the active may not contain the network interface
> if it was plugged with --config.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1056902
>
On 07/07/14 10:41, Martin Kletzander wrote:
> On Mon, Jul 07, 2014 at 10:05:22AM +0200, Peter Krempa wrote:
>> For the regular dump operation we migrate the VM to a file. This won't
>> work when the VM has passthrough devices assigned. Rather than reporting
>> a cryptic error from qemu run our chec
On Mon, Jul 07, 2014 at 10:05:22AM +0200, Peter Krempa wrote:
For the regular dump operation we migrate the VM to a file. This won't
work when the VM has passthrough devices assigned. Rather than reporting
a cryptic error from qemu run our check whether it can be migrated.
This does not influenc
Hi,
I want to work with "guest-fsfreeze-*" commands in Windows 2008 guest VM.
Host is CentOS 6.4.
Windows 2008 is running QEMU VSS provider. When "guest-fsfreeze-*" commands
are invoked from host, response received is "This is not supported".
I am following
http://lists.gnu.org/archive/html/qemu
For the regular dump operation we migrate the VM to a file. This won't
work when the VM has passthrough devices assigned. Rather than reporting
a cryptic error from qemu run our check whether it can be migrated.
This does not influence the memory-only dump that is allowed with
passthrough devices.
On Mon, Jul 07, 2014 at 02:26:57PM +0800, Chen Hanxiao wrote:
We invoked virCgroupHasController twice for checking
VIR_CGROUP_CONTROLLER_DEVICES
in lxcDomainAttachDeviceDiskLive.
Signed-off-by: Chen Hanxiao
---
src/lxc/lxc_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/lxc
73 matches
Mail list logo
