Re: [libvirt] [v5][Patch 0/4] Libvirt CPU enhancements for Power KVM

2014-11-04 Thread Prerna Saxena
On Monday 03 November 2014 02:57 PM, Michal Privoznik wrote: > On 31.10.2014 10:15, Prerna Saxena wrote: >> This patch series is a collection of enhancements for PowerPC CPUs on >> PowerKVM. >> In this iteration, I have followed Dan's suggestion on using existing cpu >> mode >> format to describ

Re: [libvirt] [PATCH] qemu: don't setup cpuset.mems if memory mode in numatune is 'preferred'

2014-11-04 Thread Wang Rui
On 2014/11/4 22:04, Martin Kletzander wrote: > On Tue, Nov 04, 2014 at 09:22:22PM +0800, Wang Rui wrote: >> If the memory mode is specified as preferred, we get the following error when >> starting domain. >> >> error: Unable to write to '$my_cgroup_path/cpuset.mems': Device or resource >> busy >>

Re: [libvirt] Release of libvirt-python-1.2.10

2014-11-04 Thread Daniel Veillard
On Tue, Nov 04, 2014 at 10:49:46AM -0800, Jason Helfman wrote: > On Mon, Nov 3, 2014 at 1:21 AM, Daniel Veillard wrote: > > > I also tagged and pushed a new version of libvirt-python, > > it is available at: > > > > ftp://libvirt.org/libvirt/python > > > > it handle the new header split in lib

Re: [libvirt] Release of libvirt-python-1.2.10

2014-11-04 Thread Jason Helfman
On Tue, Nov 4, 2014 at 10:49 AM, Jason Helfman wrote: > > On Mon, Nov 3, 2014 at 1:21 AM, Daniel Veillard > wrote: > >> I also tagged and pushed a new version of libvirt-python, >> it is available at: >> >> ftp://libvirt.org/libvirt/python >> >> it handle the new header split in libvirt-1.2.1

Re: [libvirt] Release of libvirt-python-1.2.10

2014-11-04 Thread Jason Helfman
On Mon, Nov 3, 2014 at 1:21 AM, Daniel Veillard wrote: > I also tagged and pushed a new version of libvirt-python, > it is available at: > > ftp://libvirt.org/libvirt/python > > it handle the new header split in libvirt-1.2.10 and fixes a > number of issues: > > Documentation: > d Change the c

[libvirt] [PATCH v6 5/5]Test: Add a testcase for PowerPC compat mode cpu specification.

2014-11-04 Thread Prerna Saxena
>From 88879d7eac1237b2f6ef67cb5890cb46055d56dc Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Mon, 3 Nov 2014 15:53:08 +0530 This introduces a testcase for PowerPC compat mode cpu specification. Signed-off-by: Prerna Saxena --- .../qemuxml2argv-pseries-cpu-compat.args | 8 +++

[libvirt] [PATCH v6 4/5] docs: Add documentation for compat mode.

2014-11-04 Thread Prerna Saxena
>From 23f49711d74fae7905defa1524d7e4ab838c7838 Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Fri, 31 Oct 2014 15:13:16 +0530 Add documentation to explain how compat-mode can be invoked with libvirt running on PowerPC architecture. It also mentions that this change is available libvirt 1.2.

[libvirt] [PATCH v6 3/5]PowerPC:Improve PVR handling to fall back to cpu generation.

2014-11-04 Thread Prerna Saxena
>From eebc1544e28a134ce99d39b663f09ffa89b8064a Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Tue, 28 Oct 2014 15:30:05 +0530 IBM Power processors differ uniquely across generations (such as power6, power7, power8). Each generation signifies a new PowerISA version that exhibits features uniq

[libvirt] [PATCH v6 2/5] PowerPC : Add support for launching VM in 'compat' mode.

2014-11-04 Thread Prerna Saxena
>From 3ad5caf37bfa48e43c88660255e6a3bbb8afddeb Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Tue, 28 Oct 2014 15:05:59 +0530 PowerISA allows processors to run VMs in binary compatibility ("compat") mode supporting an older version of ISA. QEMU has recently added support to explicitly denot

[libvirt] [PATCH v6 1/5] Cpu: Add support for Power LE Architecture.

2014-11-04 Thread Prerna Saxena
>From 0c8b80da2f3ea85f65d5b6a7b841433d5162a3bd Mon Sep 17 00:00:00 2001 From: "Pradipta Kr. Banerjee" Date: Tue, 28 Oct 2014 14:41:59 +0530 Subject: [PATCH 1/5] Cpu: Add support for Power LE Architecture. This adds support for PowerPC Little Endian architecture., and allows libvirt to spawn VMs

[libvirt] [Patch v6 0/5] Libvirt CPU enhancements for Power KVM

2014-11-04 Thread Prerna Saxena
This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM. The v5 of this series has been acked. I have just rebased the patches on top of latest master and added a testcase. Series Summary: == Patch 1/5 : Introduce a new architecture 'ppc64le' for libvirt. Patch 2/5

Re: [libvirt] Local qemu migration

2014-11-04 Thread Cole Robinson
On 11/04/2014 10:43 AM, Marc-André Lureau wrote: Hi, Attempting to migration from session to system qemu fails because of the following checks in qemuMigrationCookieXMLParse(): if (STREQ(mig->remoteHostname, mig->localHostname)) { virReportError(VIR_ERR_INTERNAL_ERROR,

[libvirt] Local qemu migration

2014-11-04 Thread Marc-André Lureau
Hi, Attempting to migration from session to system qemu fails because of the following checks in qemuMigrationCookieXMLParse(): if (STREQ(mig->remoteHostname, mig->localHostname)) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Attempt to migrate guest to the same h

Re: [libvirt] [PATCH] domain: Improve error output for virDomainListGetStats

2014-11-04 Thread Luyao Huang
Thanks your advise :) and I have moved the check in qemuConnectGetAllDomainStats. And the v2: https://www.redhat.com/archives/libvir-list/2014-November/msg00069.html Thanks, Luyao Huang - Original Message - From: "Peter Krempa" To: "Luyao Huang" , libvir-list@redhat.com Sent: Tuesday,

Re: [libvirt] [PATCHv3 02/16] Domain conf: allow more than one IP address for net devices

2014-11-04 Thread Daniel P. Berrange
On Tue, Nov 04, 2014 at 01:43:58PM +0100, Cedric Bosdonnat wrote: > Hi Daniel, > > On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote: > > I think it is probably worth a followup patch to make drivers > > report VIR_ERR_CONFIG_UNSUPPORTED in the case where nips > 1 > > and the driver onl

[libvirt] [v2 PATCH] qemu: Improve error output for virDomainListGetStats

2014-11-04 Thread Luyao Huang
A unsupport error will output from qemuConnectGetAllDomainStats. Add a check for the flags in qemuConnectGetAllDomainStats and improve the error in the current implementation.From manual of virsh: The approaches can't be combined. Improve error to: error: --domain and --list-* flags are mutually

[libvirt] [libvirt-sandbox][PATCH 0/4] Couple of fixes to compile again

2014-11-04 Thread Michal Privoznik
It's been a while that I tried to build libvirt-sandbox. And guess what, it doesn't compile cleanly so here are some patches to fix the issues I met. Michal Privoznik (4): virt-selinux.m4: Define SELINUX variables Makefile: link SELINUX into libvirt-sandbox-1.0.so m4: sync macros with libvir

[libvirt] [libvirt-sandbox][PATCH 1/4] virt-selinux.m4: Define SELINUX variables

2014-11-04 Thread Michal Privoznik
Later in Makefile we are using SELINUX_{CFLAGS,LIBS} variables. But we don't define them anywhere. As the result, if you don't have selinux linked by default, you'll get linkage error. Signed-off-by: Michal Privoznik --- m4/virt-selinux.m4 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[libvirt] [libvirt-sandbox][PATCH 4/4] libvirt-sandbox-config.c: Fix comment

2014-11-04 Thread Michal Privoznik
Inline comments in the code should have only one star, two stars are reserved for function documentation from which gtk doc is generated. This commit resolves this warning: GISCAN LibvirtSandbox-1.0.gir libvirt-sandbox-config.c:2142: Error: LibvirtSandbox: Skipping invalid GTK-Doc comment blo

[libvirt] [libvirt-sandbox][PATCH 2/4] Makefile: link SELINUX into libvirt-sandbox-1.0.so

2014-11-04 Thread Michal Privoznik
The code that uses SELinux is compiled into libvirt-sandbox-1.0.so so it must be linked against -lselinux. Otherwise an error occurs: make[4]: Entering directory '/home/zippy/work/libvirt/libvirt-sanbox.git/libvirt-sandbox' CCLD libvirt-sandbox-init-lxc ./.libs/libvirt-sandbox-1.0.so: undef

[libvirt] [libvirt-glib][PATCH] m4: sync macros with libvirt

2014-11-04 Thread Michal Privoznik
The macros under the m4 directory are outdated a bit. When trying to compile with newer gcc I see some errors: make[2]: Entering directory '/home/zippy/work/libvirt/libvirt-glib.git/libvirt-glib' CC libvirt_glib_1_0_la-libvirt-glib-error.lo gcc: warning: switch '-Wmudflap' is no longer su

[libvirt] [libvirt-sandbox][PATCH 3/4] m4: sync macros with libvirt

2014-11-04 Thread Michal Privoznik
The macros under the m4 directory are outdated a bit. When trying to compile with newer gcc I see some errors: make[4]: Entering directory '/home/zippy/work/libvirt/libvirt-sanbox.git/libvirt-sandbox' CC libvirt_sandbox_1_0_la-libvirt-sandbox-main.lo gcc: warning: switch '-Wmudflap' is no

[libvirt] [PATCH] Transform VIR_ERROR into VIR_WARN in detect_scsi_host_caps

2014-11-04 Thread Cédric Bosdonnat
If detect_scsi_host_caps reports errors but keeps libvirtd going on startup, the user is mislead by the error messages. Transforming them into warning still shows the problems, but indicates this is not fatal. --- po/POTFILES.in| 1 - src/node_device/node_device_linux_

Re: [libvirt] [PATCH] Require at least one console for LXC domain

2014-11-04 Thread Ján Tomko
On 10/31/2014 11:53 AM, Martin Kletzander wrote: > On Fri, Oct 31, 2014 at 10:22:25AM +0100, Ján Tomko wrote: >> A domain without a console quietly dies soon after start, >> because we try to set /dev/null as a controlling TTY >> 2014-10-30 15:10:59.705+: 1: error : lxcContainerSetupFDs:283 : >

Re: [libvirt] [PATCH] qemu: don't setup cpuset.mems if memory mode in numatune is 'preferred'

2014-11-04 Thread Martin Kletzander
On Tue, Nov 04, 2014 at 09:22:22PM +0800, Wang Rui wrote: If the memory mode is specified as preferred, we get the following error when starting domain. error: Unable to write to '$my_cgroup_path/cpuset.mems': Device or resource busy XML is configured with numatune as follows: If memor

Re: [libvirt] [PATCH] domain: Improve error output for virDomainListGetStats

2014-11-04 Thread Luyao Huang
Thanks for pointing out the mistake.I will move the check in qemuConnectGetAllDomainStats, this won't make a old client cannot use the future server and will give a good error when use future client to connect to old server. Thanks, Luyao Huang - Original Message - From: "Eric Blake" To:

[libvirt] internal error: Cannot find suitable CPU model for given data

2014-11-04 Thread Matias Kreder
Hello, I am having troubles with libvirt on Fedora 21 alpha. On virt-manager: Unable to complete install: 'internal error: Cannot find suitable CPU model for given data' Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/asyncjob.py", line 89, in cb_wrapper callb

[libvirt] [PATCH] qemu: don't setup cpuset.mems if memory mode in numatune is 'preferred'

2014-11-04 Thread Wang Rui
If the memory mode is specified as preferred, we get the following error when starting domain. error: Unable to write to '$my_cgroup_path/cpuset.mems': Device or resource busy XML is configured with numatune as follows: If memory mode is 'preferred', cpuset.mems in cgroup shouldn't be

Re: [libvirt] [PATCHv3 02/16] Domain conf: allow more than one IP address for net devices

2014-11-04 Thread Cedric Bosdonnat
Hi Daniel, On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote: > I think it is probably worth a followup patch to make drivers > report VIR_ERR_CONFIG_UNSUPPORTED in the case where nips > 1 > and the driver only supports nips==1. Shouldn't we just VIR_WARN this? That would avoid breakin

Re: [libvirt] [PATCH] qemu: fix up NBD Server can not be stopped properly

2014-11-04 Thread Ján Tomko
On 11/04/2014 06:03 AM, weiwei li wrote: > In qemuMigrationFinish mig->nbd can not be initialized by > qemuMigrationEatCookie without a flag QEMU_MIGRATION_COOKIE_NBD. > That cause qemuMigrationStopNBDServer return and the NBD server > can not be stopped properly. > > Signed-off-by: Weiwei Li mail

Re: [libvirt] [PATCH] domain: Improve error output for virDomainListGetStats

2014-11-04 Thread Eric Blake
On 11/04/2014 07:51 AM, Luyao Huang wrote: > When pass flags --domain and --list-* to cmdDomstats, > a unsupport error will output from qemuConnectGetAllDomainStats. > > error: unsupported flags (0x1) in function qemuConnectGetAllDomainStats > >>From manual of virsh: The approaches can't be combi

Re: [libvirt] [PATCH] domain: Improve error output for virDomainListGetStats

2014-11-04 Thread Peter Krempa
On 11/04/14 07:51, Luyao Huang wrote: > When pass flags --domain and --list-* to cmdDomstats, > a unsupport error will output from qemuConnectGetAllDomainStats. > > error: unsupported flags (0x1) in function qemuConnectGetAllDomainStats > >>From manual of virsh: The approaches can't be combined.

Re: [libvirt] [PATCH] util: fix releasing pidfile in cleanup

2014-11-04 Thread Pavel Hrdina
On 11/04/2014 10:51 AM, Martin Kletzander wrote: Coverity found out the very obvious problem in the code. That is that virPidFileReleasePath() was called only if virPidFileAcquirePath() returned 0. But virPidFileAcquirePath() doesn't return only 0 on success, but the FD that needs to be closed.

[libvirt] [PATCH] util: fix releasing pidfile in cleanup

2014-11-04 Thread Martin Kletzander
Coverity found out the very obvious problem in the code. That is that virPidFileReleasePath() was called only if virPidFileAcquirePath() returned 0. But virPidFileAcquirePath() doesn't return only 0 on success, but the FD that needs to be closed. Signed-off-by: Martin Kletzander --- src/util/v