Re: [libvirt] [PATCH] security:selinux: Fix crash when tcon is NULL

2014-11-09 Thread Martin Kletzander
On Sat, Nov 08, 2014 at 06:17:26PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1161831 Libvirtd will crash when parameter tcon = NULL in virSecuritySELinuxSetFileconHelper function, because libvirt do not check the first parameter when use strcmp(). Add a check for tco

Re: [libvirt] [PATCH 0/4] [RFE] introduce new vgamem attribute for video devices

2014-11-09 Thread Martin Kletzander
On Mon, Nov 03, 2014 at 02:01:46PM +0100, Pavel Hrdina wrote: This patch series fixes few issues with vram and ram attributes for video devices and introduces new vgamem attribute to allow setting up video memory size for QEMU video devices. Well, we have 'vram' (old, always meant the size of

Re: [libvirt] [PATCH] phyp: Fix NULL dereference in phypConnectOpen

2014-11-09 Thread Martin Kletzander
On Sun, Nov 09, 2014 at 10:10:47AM -0500, John Ferlan wrote: On 11/07/2014 01:56 PM, Martin Kletzander wrote: Coverity found out that commit cd490086 caused a possible NULL pointer dereference. This is due to the fact, that phyp_driver might be NULL (if VIR_ALLOC() fails), but connection_data

[libvirt] [PATCH v2] phyp: Fix NULL dereference in phypConnectOpen

2014-11-09 Thread Martin Kletzander
Coverity found out that commit cd490086 caused a possible NULL pointer dereference. This is due to the fact, that phyp_driver is NULL at the time of closing the socket, instead of connection_data, which kept the socket before the mentioned commit, could not be NULL. However, internal_socket is st

[libvirt] [PATCH] qemu: update disk chain in vm->newDef when block job compeleted

2014-11-09 Thread weiwei li
A bug will be hitted with libvirt+qemu+kvm when doing follow steps: 1.initial status :vm = base+z(z is a snapshot) 2. call snapshotCreateXML( ): vm = base+z +z' 3. call blockRebase( ): vm = base+z''(z rebase to z') 4.(after rebasing work done) vm shutdown and then start an error occured like this

[libvirt] [Bug report] - vm start failed after image snapshot rebase

2014-11-09 Thread weiwei li
Hi , I hit a bug with libvirt+ qemu+kvm when doing follow steps: 1.initial status :vm = base+z(z is a snapshot) 2. call snapshotCreateXML( ): vm = base+z +z' 3. call blockRebase( ): vm = base+z''(z rebase to z') 4 .(after rebasing work done) vm shutdown and then start an error accord like this:

Re: [libvirt] [PATCH] phyp: Fix NULL dereference in phypConnectOpen

2014-11-09 Thread John Ferlan
On 11/07/2014 01:56 PM, Martin Kletzander wrote: > Coverity found out that commit cd490086 caused a possible NULL pointer > dereference. This is due to the fact, that phyp_driver might be > NULL (if VIR_ALLOC() fails), but connection_data, which kept the socket > before the mentioned commit, cou