Re: [libvirt] [PATCH] drvbhyve: Use boot-order for grub-bhyve boot device

On 13.11.2014 15:02, Conrad Meyer wrote: On Thu, Nov 13, 2014 at 8:30 AM, Michal Privoznik wrote: I think we need to honor boot order for CD-ROMs too. I mean, if you have two CD-ROMS like this: I agree.

[libvirt] [PATCH V2 2/4] libxl: acquire job in migration finish phase

Moving data reception of the perform phase of migration to a thread introduces a race with the finish phase, where checking if the domain is active races with the thread finishing the perform phase. The race is easily solved by acquiring a job in the finish phase, which must wait for the perform p

[libvirt] [PATCH V2 3/4] libxl: start domain paused on migration dst

During the perform phase of migration, the domain is started on the dst host in a running state if VIR_MIGRATE_PAUSED flag is not specified. In the finish phase, the domain is also unpaused if VIR_MIGRATE_PAUSED flag is unset. I've noticed this second unpause fails if the domain was already unpau

[libvirt] [PATCH V2 4/4] libxl: destroy domain in migration finish phase on failure

This patch contains three domain cleanup improvements in the migration finish phase, ensuring a domain is properly disposed when a failure is detected or the migration is cancelled. The check for virDomainObjIsActive is moved to libxlDomainMigrationFinish, where cleanup can occur if migration fail

[libvirt] [PATCH V2 1/4] libxl: Receive migration data in a thread

The libxl driver receives migration data within an IO callback invoked by the event loop, effectively disabling the event loop while migration occurs. This patch moves receving of the migration data to a thread. The incoming connection is still accepted in the IO callback, but control is immediat

[libvirt] [PATCH V2 0/4] libxl migration improvements

V2 of https://www.redhat.com/archives/libvir-list/2014-November/msg00423.html Patch 1 has been fixed based on Michal's feedback. Patch 2 is new in V2. I mistakenly dropped it when reordering the patches for the V1 submission. Patches 3 and 4 also have some minor adjustments from V1. See indiv

Re: [libvirt] [PATCH 1/3] libxl: Receive migration data in a thread

Michal Privoznik wrote: > On 13.11.2014 03:36, Jim Fehlig wrote: >> The libxl driver receives migration data within an IO callback invoked >> by the event loop, effectively disabling the event loop while migration >> occurs. >> >> This patch moves receving of the migration data to a thread. The >>

[libvirt] [PATCH] qemu: fix cannot get a hot-unplug disk blockdevio settings

When we try to get a hot-unplug disk blkdevio settings via qemuDomainGetBlockIoTune, libvirt will output a cannot find device error.Move the check after confirm vm is running. Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) di

Re: [libvirt] [PATCH v2 00/22] Remove unnecessary curly brackets around one-line bodies

On 11/13/2014 04:52 PM, John Ferlan wrote: > > > On 11/13/2014 09:37 AM, Martin Kletzander wrote: >> Brackets were removed by the following script in the root directory of >> libvirt's repository: >> >> for i in $(git ls-files | grep '\.[ch]$'); do >> echo -n "$i ... "; >> emacs $i --ba

Re: [libvirt] [PATCH v2 22/22] bracket-spacing: Add syntax-check for unnecessary curly brackets

On 11/13/2014 07:37 AM, Martin Kletzander wrote: > We're looking for three consecutive lines, first one is a if/for/while > with a condition and start of body, second one is a body with one and > only semicolon and third is end of the body by itself. > > Signed-off-by: Martin Kletzander > --- >

Re: [libvirt] [PATCH v2 21/22] bracket-spacing: Remove pointless cycles

On 11/13/2014 07:37 AM, Martin Kletzander wrote: > Change while () { smth; last; } to if () { smth; } as 'last' in perl is > analogous to 'break' in C. These are probably copy-paste leftovers from > creating new syntax-check rules. > > Signed-off-by: Martin Kletzander > --- > build-aux/bracket-

Re: [libvirt] [PATCH v2 20/22] bracket-spacing: Don't modify current line

On 11/13/2014 07:37 AM, Martin Kletzander wrote: > In bracket-spacing.pl, the current $line is being modified in $data. > That, however, spoils that $data for another check. Introduce new > $tmpdata variable that can be used for temporary modifications. The > difference between $data and $line is

Re: [libvirt] [PATCH v2 19/22] docs: Adjust contributor guidelines about curly brackets

On 11/13/2014 07:37 AM, Martin Kletzander wrote: > After recent discussion it looks like curly brackets around one-line > bodies are preferred if the preceding condition is, itself, multiline. > > Signed-off-by: Martin Kletzander > --- > HACKING | 8 > docs/hacking.html.in

Re: [libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

On 11/13/2014 09:37 AM, Martin Kletzander wrote: > Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does > check for passing strings ending with '\n' to known functions. But when > setting IFS, '\n' needs to be part of that (and is by default). The > order of individual characters

Re: [libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

On 11/13/2014 07:37 AM, Martin Kletzander wrote: > Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does > check for passing strings ending with '\n' to known functions. But when > setting IFS, '\n' needs to be part of that (and is by default). The > order of individual characters i

Re: [libvirt] [PATCH v2 00/22] Remove unnecessary curly brackets around one-line bodies

On 11/13/2014 09:37 AM, Martin Kletzander wrote: > Brackets were removed by the following script in the root directory of > libvirt's repository: > > for i in $(git ls-files | grep '\.[ch]$'); do > echo -n "$i ... "; > emacs $i --batch --eval \ > '(replace-regexp > "^\\([[:space

Re: [libvirt] [PATCH v2 22/22] bracket-spacing: Add syntax-check for unnecessary curly brackets

On 11/13/2014 04:18 PM, John Ferlan wrote: > > [1]I have to say the error one gets if they violate this rule: > > maint.mk: incorrect whitespace, see HACKING for rules > make: *** [bracket-spacing-check] Error 1 > Maybe we should change the message in cfg.mk to state 'incorrect formatting' inst

Re: [libvirt] [PATCH v2] qemu: Don't try to parse -help for new QEMU

On Thu, Nov 13, 2014 at 14:57:57 -0700, Eric Blake wrote: > On 11/13/2014 01:39 PM, Jiri Denemark wrote: > > Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help > > (and other commands, such as -cpu ?) output. However, if QMP probing > > failed, we still tried starting QEMU with v

Re: [libvirt] [PATCH v2 22/22] bracket-spacing: Add syntax-check for unnecessary curly brackets

On 11/13/2014 09:37 AM, Martin Kletzander wrote: > We're looking for three consecutive lines, first one is a if/for/while > with a condition and start of body, second one is a body with one and > only semicolon and third is end of the body by itself. > And because of a later ";;" check - one ca

Re: [libvirt] [PATCH v2 17/22] Remove unnecessary curly brackets in tools/

On 11/13/2014 09:37 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > tools/virsh-console.c| 6 ++ > tools/virsh-domain.c | 27 +-- > tools/virsh-edit.c | 6 ++ > tools/virsh-host.c

Re: [libvirt] [PATCH v2] qemu: Don't try to parse -help for new QEMU

On 11/13/2014 01:39 PM, Jiri Denemark wrote: > Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help > (and other commands, such as -cpu ?) output. However, if QMP probing > failed, we still tried starting QEMU with various options and parsing > the output, which was guaranteed to f

Re: [libvirt] [PATCH v2] qemu: add port check for host when disk type is network

On Fri, Nov 14, 2014 at 01:24:18 +0800, Shanzhi Yu wrote: > For network type disk, host port is not checked when start a guest, > so the error may be unclear when with invalid port. If pass -1 to port > the error will be > error: Failed to start domain rh6-i > error: An error occurred, but the caus

[libvirt] [nova] - 'nova reboot' causes console-log truncated

Hi all, [Issue observed] If we issue 'nova reboot ', we get to have the console output of the latest bootup of the server only. The console output of the previous boot for the same server vanishes due to truncation[1]. If we do reboot from within the VM instance [ #sudo reboot ], or reboot the

[libvirt] [PATCH v2] qemu: Don't try to parse -help for new QEMU

Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help (and other commands, such as -cpu ?) output. However, if QMP probing failed, we still tried starting QEMU with various options and parsing the output, which was guaranteed to fail because the output changed. Let's just refuse par

Re: [libvirt] [PATCH] qemu: Don't try to parse -help for new QEMU

On Wed, Nov 12, 2014 at 18:37:15 +0100, Peter Krempa wrote: > On 11/12/14 17:09, Jiri Denemark wrote: > > Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help > > (and other commands, such as -cpu ?) output. However, if QMP probing > > failed, we still tried starting QEMU with vari

Re: [libvirt] [PATCH] qemu: Always set migration capabilities

On Tue, Nov 11, 2014 at 16:16:22 +0100, Jano Tomko wrote: > On 11/10/2014 04:41 PM, Jiri Denemark wrote: > > We used to set migration capabilities only when a user asked for them in > > flags. This is fine when migration succeeds since the QEMU process is > > killed in the end but in case migration

[libvirt] [PATCH v2] qemu: add port check for host when disk type is network

For network type disk, host port is not checked when start a guest, so the error may be unclear when with invalid port. If pass -1 to port the error will be error: Failed to start domain rh6-i error: An error occurred, but the cause is unknown So make a check to make sure the port range from 0 to 6

Re: [libvirt] [libvirt-glib PATCH 0/2] Fix build failures caused byt macro sync

On Thu, Nov 13, 2014 at 04:47:23PM +0100, Peter Krempa wrote: On 11/13/14 16:45, Martin Kletzander wrote: *BLURB* Martin Kletzander (2): Properly mark unused parameters Revert back deleted glib-specific warning options libvirt-gobject/libvirt-gobject-connection.c | 2 +- libvirt-gob

Re: [libvirt] [libvirt-glib PATCH 0/2] Fix build failures caused byt macro sync

On 11/13/14 16:45, Martin Kletzander wrote: > *BLURB* > > Martin Kletzander (2): > Properly mark unused parameters > Revert back deleted glib-specific warning options > > libvirt-gobject/libvirt-gobject-connection.c | 2 +- > libvirt-gobject/libvirt-gobject-domain-snapshot.c | 4 ++--

[libvirt] [libvirt-glib PATCH 0/2] Fix build failures caused byt macro sync

*BLURB* Martin Kletzander (2): Properly mark unused parameters Revert back deleted glib-specific warning options libvirt-gobject/libvirt-gobject-connection.c | 2 +- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 4 ++-- libvirt-gobject/libvirt-gobject-domain.c | 2 +-

[libvirt] [libvirt-glib PATCH 2/2] Revert back deleted glib-specific warning options

Commit f525ba7796a2fd35bf55e88fb94459b2277fcd67 copied warning macros from gnulib without keeping glib-specific settings. This build-breaker brings back those needed ones except unused-parameter, which is no longer needed. Signed-off-by: Martin Kletzander --- m4/virt-compile-warnings.m4 | 11 ++

[libvirt] [libvirt-glib PATCH 1/2] Properly mark unused parameters

Signed-off-by: Martin Kletzander --- libvirt-gobject/libvirt-gobject-connection.c | 2 +- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 4 ++-- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-storage-vol.c | 4 ++-- tests/test-events.c

Re: [libvirt] [PATCH] drvbhyve: Use boot-order for grub-bhyve boot device

On 13.11.2014 15:02, Conrad Meyer wrote: On Thu, Nov 13, 2014 at 8:30 AM, Michal Privoznik wrote: I think we need to honor boot order for CD-ROMs too. I mean, if you have two CD-ROMS like this: I agree.

[libvirt] [PATCH v2 14/22] Remove unnecessary curly brackets in rest of src/[a-n]*/

Signed-off-by: Martin Kletzander --- src/access/viraccessdriverstack.c | 3 +-- src/bhyve/bhyve_driver.c | 3 +-- src/datatypes.c | 6 ++ src/driver.c | 3 +-- src/interface/interface_backend_udev.c| 12 ++

[libvirt] [PATCH v2 04/22] Remove unnecessary curly brackets in rest of src/esx/

Signed-off-by: Martin Kletzander --- src/esx/esx_device_monitor.c| 3 +- src/esx/esx_interface_driver.c | 12 +- src/esx/esx_network_driver.c| 57 +++-- src/esx/esx_nwfilter_driver.c | 3 +- src/esx/esx_secret_driver.c | 3 +- src/esx/esx_storage_bac

[libvirt] [PATCH v2 08/22] Remove unnecessary curly brackets in src/node_device/

Signed-off-by: Martin Kletzander --- src/node_device/node_device_driver.c | 21 +++-- src/node_device/node_device_hal.c| 6 +-- src/node_device/node_device_udev.c | 87 3 files changed, 38 insertions(+), 76 deletions(-) diff --git a/src/node_device

Re: [libvirt] [PATCH 0/2] Simplify MAC address generation on update

On 11.11.2014 10:42, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1156367 Ján Tomko (2): Silently ignore MAC in NetworkLoadConfig Generate a MAC when loading a config instead of package update libvirt.spec.in | 42 -- src/

[libvirt] [PATCH v2 11/22] Remove unnecessary curly brackets in src/test/test_driver.c

Signed-off-by: Martin Kletzander --- src/test/test_driver.c | 57 +- 1 file changed, 19 insertions(+), 38 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6421f99..d7844bd 100644 --- a/src/test/test_driver.c +++ b/src

[libvirt] [PATCH v2 15/22] Remove unnecessary curly brackets in rest of src/[o-u]*/

Signed-off-by: Martin Kletzander --- src/openvz/openvz_conf.c| 3 +-- src/openvz/openvz_driver.c | 27 +-- src/phyp/phyp_driver.c | 21 +++-- src/remote/remote_driver.c | 3 +-- src/rpc/virnetclient.c | 9 +++-- sr

[libvirt] [PATCH v2 00/22] Remove unnecessary curly brackets around one-line bodies

Brackets were removed by the following script in the root directory of libvirt's repository: for i in $(git ls-files | grep '\.[ch]$'); do echo -n "$i ... "; emacs $i --batch --eval \ '(replace-regexp "^\\([[:space:]]*\\(if\\|for\\|while\\).*)\\)[[:space:]]*{\\(\n[^\n;]*;[^\n;]*\\

[libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does check for passing strings ending with '\n' to known functions. But when setting IFS, '\n' needs to be part of that (and is by default). The order of individual characters in IFS doesn't matter, so transposing last two of them fix

[libvirt] [PATCH v2 05/22] Remove unnecessary curly brackets in src/vmx/vmx.c

Signed-off-by: Martin Kletzander --- src/vmx/vmx.c | 243 -- 1 file changed, 81 insertions(+), 162 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 389a012..e6bf5c3 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -565,9 +565,

[libvirt] [PATCH v2 07/22] Remove unnecessary curly brackets in src/hyperv/

Signed-off-by: Martin Kletzander --- src/hyperv/hyperv_device_monitor.c | 3 +- src/hyperv/hyperv_driver.c | 87 src/hyperv/hyperv_interface_driver.c | 3 +- src/hyperv/hyperv_network_driver.c | 3 +- src/hyperv/hyperv_nwfilter_driver.c | 3

[libvirt] [PATCH v2 22/22] bracket-spacing: Add syntax-check for unnecessary curly brackets

We're looking for three consecutive lines, first one is a if/for/while with a condition and start of body, second one is a body with one and only semicolon and third is end of the body by itself. Signed-off-by: Martin Kletzander --- build-aux/bracket-spacing.pl | 35 +

[libvirt] [PATCH v2 03/22] Remove unnecessary curly brackets in src/esx/esx_driver.c

Signed-off-by: Martin Kletzander --- src/esx/esx_driver.c | 390 +-- 1 file changed, 130 insertions(+), 260 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index af567d2..1cbebb9 100644 --- a/src/esx/esx_driver.c +++ b/src/esx

[libvirt] [PATCH v2 18/22] Remove unnecessary curly brackets in tests/

Signed-off-by: Martin Kletzander --- tests/commandhelper.c| 3 +-- tests/esxutilstest.c | 12 tests/eventtest.c| 3 +-- tests/openvzutilstest.c | 6 ++ tests/securityselinuxlabeltest.c | 6 ++ tests/shunloadtest.c

[libvirt] [PATCH v2 17/22] Remove unnecessary curly brackets in tools/

Signed-off-by: Martin Kletzander --- tools/virsh-console.c| 6 ++ tools/virsh-domain.c | 27 +-- tools/virsh-edit.c | 6 ++ tools/virsh-host.c | 3 +-- tools/virsh-pool.c | 6

[libvirt] [PATCH v2 21/22] bracket-spacing: Remove pointless cycles

Change while () { smth; last; } to if () { smth; } as 'last' in perl is analogous to 'break' in C. These are probably copy-paste leftovers from creating new syntax-check rules. Signed-off-by: Martin Kletzander --- build-aux/bracket-spacing.pl | 27 ++- 1 file changed, 10

[libvirt] [PATCH v2 12/22] Remove unnecessary curly brackets in src/util/

Signed-off-by: Martin Kletzander --- src/util/virauth.c | 12 src/util/virbitmap.c| 6 ++ src/util/virbuffer.c| 3 +-- src/util/vircommand.c | 9 +++-- src/util/virconf.c | 15 +-- src/util/virdbus.c

[libvirt] [PATCH v2 16/22] Remove unnecessary curly brackets in rest of src/

Signed-off-by: Martin Kletzander --- src/vmware/vmware_conf.c | 3 +-- src/vmware/vmware_driver.c | 6 ++ src/xen/block_stats.c | 3 +-- src/xen/xen_driver.c | 6 ++ src/xen/xen_hypervisor.c | 6 ++ src/xen/xend_internal.c| 18 ++ src/xen/xm_int

[libvirt] [PATCH v2 13/22] Remove unnecessary curly brackets in src/vbox/

Signed-off-by: Martin Kletzander --- src/vbox/vbox_MSCOMGlue.c | 30 + src/vbox/vbox_XPCOMCGlue.c| 33 ++-- src/vbox/vbox_common.c| 51 +++ src/vbox/vbox_network.c | 15 + src

[libvirt] [PATCH v2 19/22] docs: Adjust contributor guidelines about curly brackets

After recent discussion it looks like curly brackets around one-line bodies are preferred if the preceding condition is, itself, multiline. Signed-off-by: Martin Kletzander --- HACKING | 8 docs/hacking.html.in | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) dif

[libvirt] [PATCH v2 06/22] Remove unnecessary curly brackets in src/conf/

Signed-off-by: Martin Kletzander --- src/conf/capabilities.c | 3 +- src/conf/domain_conf.c | 135 +++- src/conf/interface_conf.c | 9 +-- src/conf/network_conf.c | 51 ++--- src/conf/node_device_conf.c | 15 ++--- src/conf/

[libvirt] [PATCH v2 09/22] Remove unnecessary curly brackets in src/qemu/

Signed-off-by: Martin Kletzander --- src/qemu/qemu_agent.c| 3 +-- src/qemu/qemu_capabilities.c | 9 +++-- src/qemu/qemu_cgroup.c | 6 ++ src/qemu/qemu_command.c | 6 ++ src/qemu/qemu_conf.c | 3 +-- src/qemu/qemu_domain.c | 3 +-- src/qemu/qemu_

[libvirt] [PATCH v2 10/22] Remove unnecessary curly brackets in src/storage/

Signed-off-by: Martin Kletzander --- src/storage/parthelper.c| 3 +-- src/storage/storage_backend.c | 9 +++-- src/storage/storage_backend_disk.c | 15 +-- src/storage/storage_backend_fs.c| 6 ++ src/storage/storage_backend_mpath.c | 27 +-

[libvirt] [PATCH v2 02/22] Remove unnecessary curly brackets in daemon/ and examples/

Signed-off-by: Martin Kletzander --- daemon/libvirtd.c | 15 +-- daemon/remote.c | 12 examples/object-events/event-test.c | 3 +-- examples/openauth/openauth.c| 9 +++-- 4 files changed, 13 insertions(+), 26 deletions(-

[libvirt] [PATCH v2 20/22] bracket-spacing: Don't modify current line

In bracket-spacing.pl, the current $line is being modified in $data. That, however, spoils that $data for another check. Introduce new $tmpdata variable that can be used for temporary modifications. The difference between $data and $line is that $data are as much cleaned as possible from non-code

Re: [libvirt] [PATCH] lxc: fix setmem effect on a running LXC machine

On 10/24/2014 11:17 AM, Erik Skultety wrote: > When user calls setmem on a running LXC machine, we do update its cgroup > entry (which is in odds with the original bug report, possibly resolved > by later versions), I removed this note as the reporter missed the different units. > however we ne

Re: [libvirt] [PATCH] drvbhyve: Use boot-order for grub-bhyve boot device

On Thu, Nov 13, 2014 at 8:30 AM, Michal Privoznik wrote: > I think we need to honor boot order for CD-ROMs too. I mean, if you have two > CD-ROMS like this: > > > > > > > > > > > > > I agree. I think the patch should do

Re: [libvirt] [PATCH 0/3] virsh: Cleanups and checks for options

On 11.11.2014 12:10, Martin Kletzander wrote: Option-ordering and typing checks and a reorder so tests pass. Martin Kletzander (3): virsh: Reorder some options virsh: Enforce proper ordering of options virsh: Error out if VSH_OT_STRING option has VSH_OFLAG_REQ flag tools/virsh-domain

Re: [libvirt] [PATCH 0/4] [RFE] introduce new vgamem attribute for video devices

On 11/10/2014 08:44 AM, Martin Kletzander wrote: On Mon, Nov 03, 2014 at 02:01:46PM +0100, Pavel Hrdina wrote: This patch series fixes few issues with vram and ram attributes for video devices and introduces new vgamem attribute to allow setting up video memory size for QEMU video devices. We

Re: [libvirt] [PATCH] virsh: Fix msg: blockjob is aborted from another client

On 11/13/2014 02:32 PM, Erik Skultety wrote: > When a block{pull, copy, commit} is aborted via keyboard interrupt, > the job is properly canceled followed by proper error message. > However, when the job receives an abort from another client connected > to the same domain, the error message incorre

[libvirt] [PATCH] virsh: Fix msg: blockjob is aborted from another client

When a block{pull, copy, commit} is aborted via keyboard interrupt, the job is properly canceled followed by proper error message. However, when the job receives an abort from another client connected to the same domain, the error message incorrectly indicates that a blockjob has been finished succ

Re: [libvirt] [PATCH] drvbhyve: Use boot-order for grub-bhyve boot device

On 12.11.2014 23:31, Conrad Meyer wrote: > Rather than just picking the first CD (or failing that, HDD) we come > across, if the user has picked a boot device ordering with order=''>, respect that (and just try to boot the lowest-index device). > > Adds two sets of tests to bhyve2xmlargv; 'grub-b

Re: [libvirt] [PATCH] drvbhyve: Clean-up some used ATTRIBUTE_UNUSEDs.

On 12.11.2014 22:11, Conrad Meyer wrote: --- src/bhyve/bhyve_device.c | 2 +- src/bhyve/bhyve_driver.c | 10 +- src/bhyve/bhyve_process.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) ACKed and pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH 1/3] libxl: Receive migration data in a thread

On 13.11.2014 03:36, Jim Fehlig wrote: The libxl driver receives migration data within an IO callback invoked by the event loop, effectively disabling the event loop while migration occurs. This patch moves receving of the migration data to a thread. The incoming connection is still accepted in

Re: [libvirt] [PATCH 0/3] libxl migration improvements

On 13.11.2014 03:36, Jim Fehlig wrote: This series of patches fixes problems discovered in libxl migration. The first patch fixes an issue that went undetected while testing the initial implementation of migration. Receiving migration data occurs in the context of an event loop callback, effect

Re: [libvirt] [libvirt-glib][PATCH] m4: sync macros with libvirt

On 13.11.2014 11:25, Christophe Fergeau wrote: On Tue, Nov 04, 2014 at 03:40:37PM +0100, Michal Privoznik wrote: The macros under the m4 directory are outdated a bit. When trying to compile with newer gcc I see some errors: ACK. The update to m4/warnings.m4 is not really needed, but it does no

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

On 11/13/2014 06:21 PM, Peter Krempa wrote: On 11/13/14 11:17, Shanzhi Yu wrote: On 11/13/2014 05:42 PM, Peter Krempa wrote: On 11/13/14 10:28, Shanzhi Yu wrote: For network type disk, host port is not checked when source protocol is iscsi, so the error is not sure when with invalid port. If

Re: [libvirt] [libvirt-glib][PATCH] m4: sync macros with libvirt

On Tue, Nov 04, 2014 at 03:40:37PM +0100, Michal Privoznik wrote: > The macros under the m4 directory are outdated a bit. When trying > to compile with newer gcc I see some errors: ACK. The update to m4/warnings.m4 is not really needed, but it does not hurt :) > > make[2]: Entering directory >

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

On 11/13/14 11:17, Shanzhi Yu wrote: > > On 11/13/2014 05:42 PM, Peter Krempa wrote: >> On 11/13/14 10:28, Shanzhi Yu wrote: >>> For network type disk, host port is not checked when source protocol is >>> iscsi, so the error is not sure when with invalid port. If pass -1 to >>> port >>> the error

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

On 11/13/2014 05:42 PM, Peter Krempa wrote: On 11/13/14 10:28, Shanzhi Yu wrote: For network type disk, host port is not checked when source protocol is iscsi, so the error is not sure when with invalid port. If pass -1 to port the error will be error: Failed to start domain rh6-i error: An er

[libvirt] [PATCH v4 12/17] Renamed virNetDevSetIPv4Address to virNetDevSetIPAddress

Renamed virNetDevSetIPv4Address as it also handles IPv6 addresses. --- src/libvirt_private.syms| 2 +- src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 4 ++-- src/util/virnetdev.c| 14 +++--- src/util/virnetdev.h| 6 +++--- 5 files changed, 14 inse

[libvirt] [PATCH v4 02/17] Domain conf: allow more than one IP address for net devices

Add the possibility to have more than one IP address configured for a domain network interface. IP addresses can also have a prefix to define the corresponding netmask. --- docs/formatdomain.html.in | 22 docs/schemas/domaincommon.rng | 16 ++- src/co

[libvirt] [PATCH v4 13/17] virNetDevAddRoute: implementation using netlink

--- src/util/virnetdev.c | 105 +++ 1 file changed, 90 insertions(+), 15 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 3eaf0e4..a4b4ab3 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -963,6 +963,95 @@ i

[libvirt] [PATCH v4 04/17] lxc conf2xml: convert IP addresses

--- src/lxc/lxc_native.c| 145 +++- tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 + 3 files changed, 98 insertions(+), 51 deletions(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_

[libvirt] [PATCH v4 06/17] lxc conf2xml: convert ip addresses for hostdev NICs

--- src/lxc/lxc_native.c | 3 +++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 2 ++ 3 files changed, 7 insertions(+) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 6ab093d..f0bc

[libvirt] [PATCH v4 16/17] Openvz --ipadd can be provided multiple times

Vzctl man page says that --ipadd can be provided multiple times to add several IP addresses. Looping over the configured ip addresses to add one --ipadd for each. This would even handle the multiple IPs handled by openvz_conf.c --- src/openvz/openvz_driver.c | 8 ++-- 1 file changed, 6 inserti

[libvirt] [PATCH v4 07/17] Domain network devices can now have a element

Network interfaces devices and host devices with net capabilities can now have an IPv4 and/or an IPv6 address configured. --- docs/formatdomain.html.in| 9 + docs/schemas/domaincommon.rng| 21 src/conf/domain_conf.c | 66 +

[libvirt] [PATCH v4 05/17] Allow network capabilities hostdev to configure IP addresses

--- docs/formatdomain.html.in| 12 ++-- docs/schemas/domaincommon.rng| 28 src/conf/domain_conf.c | 34 ++ src/conf/domain_conf.h | 2 ++ tests/lxcxml2xmldata/lxc-hostdev.xml | 2

[libvirt] [PATCH v4 08/17] lxc conf2xml: convert lxc.network.ipv[46].gateway

--- src/lxc/lxc_native.c | 19 ++- tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config | 2 ++ tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml| 2 ++ tests/lxcconf2xmldata/lxcconf2xml-simple.config | 2 ++ tests/lxcconf2xmldata/lxcconf

[libvirt] [PATCH v4 09/17] LXC: use the new net devices gateway definition

When a gateway is set on a network device, a new default route via this gateway through the devoce will be added in the container. --- src/lxc/lxc_container.c | 40 src/util/virsocketaddr.h | 3 +++ 2 files changed, 43 insertions(+) diff --git a/src/lxc/

[libvirt] [PATCH v4 03/17] LXC: set IP addresses to veth devices in the container

Uses the new virDomainNetDef ips to set the IP addresses on the network interfaces in the container. --- src/lxc/lxc_container.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 8aba3ba..4aeb19c 100644 -

[libvirt] [PATCH v4 17/17] Report error if a driver can't handle multiple IP addresses

Drivers supporting one and only one IP address raise an error if more IP addresses are configured. --- src/vbox/vbox_common.c | 12 +--- src/xenconfig/xen_common.c | 12 ++-- src/xenconfig/xen_sxpr.c | 12 ++-- 3 files changed, 29 insertions(+), 7 deletions(-) diff -

[libvirt] [PATCH v4 11/17] virNetDevSetIPv4Address: libnl implementation

Add a default implementation of virNetDevSetIPv4Address using netlink and libnl. This avoids requiring /usr/sbin/ip or /usr/sbin/ifconfig external binaries. --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 136 +-- src/util/virnetlink.c

[libvirt] [PATCH v4 14/17] virNetDevClearIPv4Address: netlink implementation

--- src/util/virnetdev.c | 60 +++- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index a4b4ab3..c61431b 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1052,6 +1052,47 @@

[libvirt] [PATCH v4 01/17] Forgot to cleanup ifname_guest* in domain network def parsing

--- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c65276..8c00dd1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7772,6 +7772,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt,

[libvirt] [PATCH v4 10/17] LXC: honour network devices link state

Don't activate LXC network device if has been set in its configuration. --- src/lxc/lxc_container.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 727565d..3befd1c 100644 --- a/src/lxc/lxc_

[libvirt] [PATCH v4 15/17] Renamed virNetDevClearIPv4Address to virNetDevClearIPAddress

Make clear that virNetDevClearIPv4Address can also handle IPv6 addresses by changing the name --- src/libvirt_private.syms | 2 +- src/util/virnetdev.c | 14 +++--- src/util/virnetdev.h | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libvirt_priva

[libvirt] [PATCH v4 00/17] LXC IP configuration feature

Hi all, Here is an updated version of the lxc IP configuration patch series. Diffs to v3: * Took care of Daniel's feedback * Fixed openvz driver to add support for multiple --ipadd * Report an error for drivers using IP addresses, but only the first one in case there are more provided.

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

On 11/13/2014 10:28 AM, Shanzhi Yu wrote: > For network type disk, host port is not checked when source protocol is > iscsi, so the error is not sure when with invalid port. If pass -1 to port > the error will be > error: Failed to start domain rh6-i > error: An error occurred, but the cause is un

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

On 11/13/14 10:28, Shanzhi Yu wrote: > For network type disk, host port is not checked when source protocol is > iscsi, so the error is not sure when with invalid port. If pass -1 to port > the error will be > error: Failed to start domain rh6-i > error: An error occurred, but the cause is unknown

Re: [libvirt] [PATCH v2] nwfilter: fix deadlock caused updating network device and nwfilter

On 11/12/2014 05:17 PM, John Ferlan wrote: On 11/12/2014 04:51 AM, Pavel Hrdina wrote: Commit 6e5c79a1 tried to fix deadlock between nwfilter{Define,Undefine} and starting of guest, but this same deadlock is also for s/is also/exists/ updating/attaching network device to domain. The deadl

[libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

For network type disk, host port is not checked when source protocol is iscsi, so the error is not sure when with invalid port. If pass -1 to port the error will be error: Failed to start domain rh6-i error: An error occurred, but the cause is unknown Resolves: https://bugzilla.redhat.com/show_bu

Re: [libvirt] [PATCH 1/2] qemu: Delete nvram store for transient domains too

On 12.11.2014 19:10, Peter Krempa wrote: On 11/12/14 18:26, Michal Privoznik wrote: There are two ways how to use nvram variable store file in libvirt: 1) create it by hand and pass the path in domain XML 2) let libvirt generate path and create the file Now, we allow users to remove the