Re: [libvirt] [PATCH] lxc: fix show the wrong xml when guest start failed

2015-01-06 Thread lhuang
On 01/06/2015 11:14 PM, Laine Stump wrote: On 01/06/2015 09:31 AM, Luyao Huang wrote: On 01/06/2015 10:11 PM, Michal Privoznik wrote: On 22.12.2014 08:21, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1176503 When guest start failed, libvirt will keep the current vm->def, th

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

2015-01-06 Thread Chun Yan Liu
>>> On 12/23/2014 at 03:32 PM, in message <54991AA7.243 : 102 : 21807>, Chun Yan Liu wrote: > On 12/23/2014 at 11:42 AM, in message <5498e4ba.1000...@redhat.com>, John > Ferlan wrote: > > > >> On 12/22/2014 09:55 PM, Chun Yan Liu wrote: >> > >> > >> On 12/22/2014 at

Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-06 Thread lhuang
On 01/07/2015 01:16 AM, Eric Blake wrote: On 01/05/2015 11:56 PM, lhuang wrote: On 01/05/2015 11:18 PM, Peter Krempa wrote: Subject: "change something"? That's a really vague statement. How about: qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug Good subject :) Thanks On

Re: [libvirt] [PATCH v2] Makefile: Fix parallel build after Xen-xl parser introduction

2015-01-06 Thread Eric Blake
On 01/06/2015 06:47 AM, Michal Privoznik wrote: > Well, the parallel build doesn't work as there are not dependencies > set correctly. When running 'make -j' I see this error: > > make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src' > GEN util/virkeymaps.h > GEN loc

Re: [libvirt] [PATCHv5 13/18] Domain network devices can now have a element

2015-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2015 at 01:41:34PM -0500, Laine Stump wrote: > On 12/30/2014 05:27 AM, Cédric Bosdonnat wrote: > > Network interfaces devices and host devices with net capabilities can > > now have IPv4 and/or an IPv6 routes configured. > > --- > > docs/formatdomain.html.in| 19 -

Re: [libvirt] [PATCHv5 13/18] Domain network devices can now have a element

2015-01-06 Thread Laine Stump
On 12/30/2014 05:27 AM, Cédric Bosdonnat wrote: > Network interfaces devices and host devices with net capabilities can > now have IPv4 and/or an IPv6 routes configured. > --- > docs/formatdomain.html.in| 19 - > docs/schemas/domaincommon.rng| 31 > src/conf/doma

Re: [libvirt] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2015 at 10:28:13AM -0700, Eric Blake wrote: > On 01/06/2015 09:12 AM, Wei Liu wrote: > > Currently libxl driver hardcodes some paths in its capability string, > > which might not be the correct paths. > > > > This patch introduces --with-libxl-prefix, so that user can specify the >

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
On Tue, Jan 06, 2015 at 05:03:59PM +, Ian Campbell wrote: > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > > No need to check hostarch to determine whether to use lib or lib64 > > anymore because we now always use lib. > > What about people who use --libdir=/path/to/lib64, as I believe Re

Re: [libvirt] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Eric Blake
On 01/06/2015 09:12 AM, Wei Liu wrote: > Currently libxl driver hardcodes some paths in its capability string, > which might not be the correct paths. > > This patch introduces --with-libxl-prefix, so that user can specify the > prefix used to build Xen tools. The default value is /usr/local which

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Ian Campbell
On Tue, 2015-01-06 at 17:20 +, Wei Liu wrote: > On Tue, Jan 06, 2015 at 05:03:59PM +, Ian Campbell wrote: > > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > > > No need to check hostarch to determine whether to use lib or lib64 > > > anymore because we now always use lib. > > > > What

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Andrew Cooper
On 06/01/15 17:03, Ian Campbell wrote: > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: >> No need to check hostarch to determine whether to use lib or lib64 >> anymore because we now always use lib. > What about people who use --libdir=/path/to/lib64, as I believe Red Hat > derived distros stil

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
On Tue, Jan 06, 2015 at 04:50:53PM +, Frediano Ziglio wrote: > 2015-01-06 16:12 GMT+00:00 Wei Liu : > > Currently libxl driver hardcodes some paths in its capability string, > > which might not be the correct paths. > > > > This patch introduces --with-libxl-prefix, so that user can specify the

Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-06 Thread Eric Blake
On 01/05/2015 11:56 PM, lhuang wrote: > > On 01/05/2015 11:18 PM, Peter Krempa wrote: >> Subject: "change something"? That's a really vague statement. >> >> How about: >> >> qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug > Good subject :) > Thanks >> On 01/03/15 06:06, Luyao H

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Frediano Ziglio
2015-01-06 16:12 GMT+00:00 Wei Liu : > Currently libxl driver hardcodes some paths in its capability string, > which might not be the correct paths. > > This patch introduces --with-libxl-prefix, so that user can specify the > prefix used to build Xen tools. The default value is /usr/local which is

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Ian Campbell
On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > No need to check hostarch to determine whether to use lib or lib64 > anymore because we now always use lib. What about people who use --libdir=/path/to/lib64, as I believe Red Hat derived distros still do, don't they? Ian. -- libvir-list mailin

[libvirt] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
Currently libxl driver hardcodes some paths in its capability string, which might not be the correct paths. This patch introduces --with-libxl-prefix, so that user can specify the prefix used to build Xen tools. The default value is /usr/local which is the default --prefix for Xen tools. Change e

Re: [libvirt] [PATCH] lxc: fix show the wrong xml when guest start failed

2015-01-06 Thread Laine Stump
On 01/06/2015 09:31 AM, Luyao Huang wrote: > > On 01/06/2015 10:11 PM, Michal Privoznik wrote: >> On 22.12.2014 08:21, Luyao Huang wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1176503 >>> >>> When guest start failed, libvirt will keep the current vm->def, >>> this will make a issue that w

Re: [libvirt] [PATCH V3 2/4] src/xenconfig: Xen-xl parser

2015-01-06 Thread David kiarie
On Sun, Jan 4, 2015 at 9:00 PM, Jim Fehlig wrote: > Michal Privoznik wrote: > > On 16.12.2014 05:30, Jim Fehlig wrote: > >> diff --git a/src/xenconfig/xen_xl_disk.l b/src/xenconfig/xen_xl_disk.l > >> new file mode 100644 > >> index 000..164aa32 > >> --- /dev/null > >> +++ b/src/xenconfig/xen_

Re: [libvirt] [PATCH v2] Makefile: Fix parallel build after Xen-xl parser introduction

2015-01-06 Thread Pavel Hrdina
On 01/06/2015 02:47 PM, Michal Privoznik wrote: Well, the parallel build doesn't work as there are not dependencies set correctly. When running 'make -j' I see this error: make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src' GEN util/virkeymaps.h GEN locking/loc

Re: [libvirt] [PATCH v2] Makefile: Fix parallel build after Xen-xl parser introduction

2015-01-06 Thread Martin Kletzander
On Tue, Jan 06, 2015 at 02:47:17PM +0100, Michal Privoznik wrote: Well, the parallel build doesn't work as there are not dependencies set correctly. When running 'make -j' I see this error: make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src' GEN util/virkeymaps.h GEN

Re: [libvirt] [PATCH] lxc: fix show the wrong xml when guest start failed

2015-01-06 Thread Luyao Huang
On 01/06/2015 10:11 PM, Michal Privoznik wrote: On 22.12.2014 08:21, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1176503 When guest start failed, libvirt will keep the current vm->def, this will make a issue that we cannot get a right xml after guest start failed. Pass the n

Re: [libvirt] [PATCH] lxc: fix show the wrong xml when guest start failed

2015-01-06 Thread Michal Privoznik
On 22.12.2014 08:21, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1176503 When guest start failed, libvirt will keep the current vm->def, this will make a issue that we cannot get a right xml after guest start failed. Pass the newDef to def will make it work well. Signed-off-b

[libvirt] [PATCH v2] Makefile: Fix parallel build after Xen-xl parser introduction

2015-01-06 Thread Michal Privoznik
Well, the parallel build doesn't work as there are not dependencies set correctly. When running 'make -j' I see this error: make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src' GEN util/virkeymaps.h GEN locking/lock_protocol.h make[2]: *** No rule to make target 'xe

Re: [libvirt] [PATCH] docs: Document some -boot option limitations on UEFI

2015-01-06 Thread Laszlo Ersek
On 01/06/15 13:08, Michal Privoznik wrote: > It was brought to my attention that some -boot options may not > work with UEFI. For instance, rebootTimeout is very SeaBIOS > specific,splash logo is not implemented yet on OVMF, and so on. > We should document this limitation at least. > > Signed-off-

Re: [libvirt] [PATCHv2] qemu: fix tc old rules will be cleaned if set tc new rules fail

2015-01-06 Thread Michal Privoznik
On 31.12.2014 02:34, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1177723 If tc cmd failed (maybe value too large) when we use virDomainSetInterfaceParameters , the old rules will be clean. Restore the old rules if tc failed. Signed-off-by: Luyao Huang --- v1 make a big mist

[libvirt] [PATCH] docs: Document some -boot option limitations on UEFI

2015-01-06 Thread Michal Privoznik
It was brought to my attention that some -boot options may not work with UEFI. For instance, rebootTimeout is very SeaBIOS specific,splash logo is not implemented yet on OVMF, and so on. We should document this limitation at least. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in |

Re: [libvirt] [PATCH] qemu: fix miss goto cleanup in qemuDomainAttachNetDevice

2015-01-06 Thread Michal Privoznik
On 06.01.2015 10:20, Luyao Huang wrote: This place have a wrong logic, maybe forget goto cleanup. Also fix some small things. Signed-off-by: Luyao Huang --- I am not sure i am right, but hotplug a net do not a address may cause a issue. src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 i

[libvirt] [PATCH] qemu: fix miss goto cleanup in qemuDomainAttachNetDevice

2015-01-06 Thread Luyao Huang
This place have a wrong logic, maybe forget goto cleanup. Also fix some small things. Signed-off-by: Luyao Huang --- I am not sure i am right, but hotplug a net do not a address may cause a issue. src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/s

Re: [libvirt] [PATCH 05/12] libvirt_private: add 4 new func in libvirt_private.syms

2015-01-06 Thread lhuang
On 01/06/2015 04:11 PM, Peter Krempa wrote: On 01/06/15 09:10, lhuang wrote: On 01/05/2015 10:48 PM, Peter Krempa wrote: On 01/03/15 06:06, Luyao Huang wrote: Signed-off-by: Luyao Huang --- src/libvirt_private.syms | 5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt_pri

Re: [libvirt] [PATCH] virnetlink: fix build on non-Linux

2015-01-06 Thread Cedric Bosdonnat
Hi Eric, On Mon, 2015-01-05 at 15:13 -0700, Eric Blake wrote: > Commit 4dc04d3a added virNetlinkGetErrorCode, but forgot to provide > a fallback, which kills the build on mingw (among others): > > CCLD libvirt.la > Cannot export virNetlinkGetErrorCode: symbol not defined > collect2: err

Re: [libvirt] [PATCH 05/12] libvirt_private: add 4 new func in libvirt_private.syms

2015-01-06 Thread Peter Krempa
On 01/06/15 09:10, lhuang wrote: > > On 01/05/2015 10:48 PM, Peter Krempa wrote: >> On 01/03/15 06:06, Luyao Huang wrote: >>> Signed-off-by: Luyao Huang >>> --- >>> src/libvirt_private.syms | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/src/libvirt_private.syms b/src/libvi

Re: [libvirt] [PATCH 05/12] libvirt_private: add 4 new func in libvirt_private.syms

2015-01-06 Thread lhuang
On 01/05/2015 10:48 PM, Peter Krempa wrote: On 01/03/15 06:06, Luyao Huang wrote: Signed-off-by: Luyao Huang --- src/libvirt_private.syms | 5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index aa776b4..deab4cf 100644 --- a/src/libv

Re: [libvirt] [PATCH 04/12] conf: introduce 3 functions for RNG device

2015-01-06 Thread lhuang
On 01/05/2015 10:56 PM, Peter Krempa wrote: The subject is vague. Please try to condense what the patch is adding in a way that describes the functions instead of an opaque "add 3 functions" On 01/03/15 06:06, Luyao Huang wrote: the 3 functions are: virDomainRNGInsert: Insert a RNG device to