Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1178986
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 7 -
src/qemu/qemu_process.c | 76 -
src/qemu/qemu_process.h | 5 +++-
3 files changed, 85 insertions(+), 3 deletions
On Tue, 2015-01-13 at 12:05 +0800, lhuang wrote:
> On 01/13/2015 10:35 AM, Zhu Guihua wrote:
> > Hi Luyao,
>
> Hi Guihua,
> > On Mon, 2015-01-12 at 09:38 +0800, lhuang wrote:
> >> On 01/10/2015 11:29 AM, Luyao Huang wrote:
> >>> We need a new function to build a RNG device object.
> >>>
> >>> Sign
It works well if we use qmp command to directly interact with qemu 2.1 to
hot-add vhost-user network card. However, libvirt seems not support hotplugging
well.
Steps to use qmp commands to directly(without libvirtd) interact with qemu 2.1 :
1 (qemu) chardev-add backend=socket,id=charnet1,path=/v
On 01/13/2015 10:35 AM, Zhu Guihua wrote:
Hi Luyao,
Hi Guihua,
On Mon, 2015-01-12 at 09:38 +0800, lhuang wrote:
On 01/10/2015 11:29 AM, Luyao Huang wrote:
We need a new function to build a RNG device object.
Signed-off-by: Luyao Huang
---
src/qemu/qemu_monitor_json.c | 46
Hi Luyao,
On Mon, 2015-01-12 at 09:38 +0800, lhuang wrote:
> On 01/10/2015 11:29 AM, Luyao Huang wrote:
> > We need a new function to build a RNG device object.
> >
> > Signed-off-by: Luyao Huang
> > ---
> > src/qemu/qemu_monitor_json.c | 46
> >
>
https://bugzilla.redhat.com/show_bug.cgi?id=1181182
When we meet error in qemuMigrationPrepareAny and goto
cleanup with rc < 0, we forget clear the priv->origname and this
will make this vm migrate fail next time because leave a wrong
origname in priv, and will Generate a wrong cookie when do
mig
Eric Blake wrote:
> On 01/09/2015 10:03 PM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for parsing
>> and formating the
John Ferlan wrote:
> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for parsing
>> and formating the
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> Patches 3-8 fix possible crash/invalid memory access if QEMU crashes
> while we're in the monitor.
> Patches 9-13 change all other callers of qemuDomainObjExitMonitor
> to exit early in that case, but should not fix any real issues.
> They are necessary
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> ---
> src/qemu/qemu_process.c | 102
> +---
> 1 file changed, 53 insertions(+), 49 deletions(-)
>
Hmm.. miscounted in a couple of comments in previous changes where I
reference 11/14 - guess that's 12/14 i
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> ---
> src/qemu/qemu_migration.c | 41 ++---
> 1 file changed, 26 insertions(+), 15 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 77e0b35..31494c8 100644
> --- a/src/qemu
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> Error out if the domain has disappeared in the meantime.
>
> This prevents writing the persistent definition as the domain
> status and calling qemuDomainRemoveDevice on devices
> that already have been dealt with in qemuProcessStop.
> ---
> src/qemu/q
https://bugzilla.redhat.com/show_bug.cgi?id=1135339 documents some
confusing behavior when a user tries to start an inactive block
commit in a second connection while there is already an on-going
active commit from a first connection. Eventually, qemu will
support multiple simultaneous block jobs,
At least with live block commit, it is possible to have a block
job that reports 0 status: namely, when the active image contains
no sectors that differ from the backing image it is being committed
into [1]. I'm not sure if that represents a qemu bug, but it leads
to weird virsh output where 'virs
?
Since it seems there's a second bugfix here (eg, the alias setting),
perhaps one should be added.
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> ---
> src/qemu/qemu_process.c | 22 --
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/src/qemu/qemu_process.c
I was trying to work on a libvirt bug, when I discovered the following:
$ qemu-img create -f qcow2 a.qcow2 10M
Formatting 'a.qcow2', fmt=qcow2 size=10485760 encryption=off
cluster_size=65536 lazy_refcounts=off
$ qemu-img create -f qcow2 \
-obacking_file=a.qcow2,backing_fmt=qcow2 b.qcow2
Formatti
?
Seems we're fixing two issues here
#1. The ExitMonitor issue
#2. Somehow the disk->info.alias becomes NULL and thus we're making a
local copy to avoid that.
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> ---
> src/qemu/qemu_driver.c | 26 +++---
> 1 file changed, 19 insertion
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> Exit the monitor right after we've done with it to get
> the virDomainObjPtr lock back, otherwise we might be accessing
> vm->def while it's being cleaned up by qemuProcessStop.
>
> If the domain crashed while we were in the monitor, exit
> early instea
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1161024
>
> If the domain crashed while we were in monitor,
> we cannot rely on the REALLOC done on live definition,
> since vm->def now points to the persistent definition.
> Skip adding the attached devices
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1161024
>
> Skip audit and removing the device from live def because
> it has already been cleaned up.
> ---
> src/qemu/qemu_hotplug.c | 59
> ++---
> 1 file chang
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1161024
>
> In the device type-specific functions, exit early
> if the domain has disappeared, because the cleanup
> should have been done by qemuProcessStop.
>
> Check the return value in processDeviceDelete
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> The domain might disappear during the time in monitor when
> the virDomainObjPtr is unlocked, so the caller needs to check
> if it's still alive.
>
> Since most of the callers are going to need it, put the
> check inside qemuDomainObjExitMonitor and ret
On 01/07/2015 10:42 AM, Ján Tomko wrote:
> This will allow us to call qemuDomainObjIsActive() in
> the tested functions to check if the domain has crashed.
> ---
> tests/qemuhotplugtest.c | 6 ++
> 1 file changed, 6 insertions(+)
>
ACK
John
--
libvir-list mailing list
libvir-list@redhat
On 01/09/2015 10:03 PM, Jim Fehlig wrote:
> Introduce a parser/formatter for the xl config format. Since the
> deprecation of xm/xend, the VM config file format has diverged as
> new features are added to libxl. This patch adds support for parsing
> and formating the xl config format. It support
Eric Blake wrote:
> On 01/12/2015 07:51 AM, John Ferlan wrote:
>
>> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>>
>>> This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853.
>>>
>>> Conflicts:
>>> src/Makefile.am
>>>
>>> Signed-off-by: Jim Fehlig
>>> ---
>>> .gitignore
On Mon, Jan 12, 2015 at 10:42:11AM +0100, Michal Privoznik wrote:
> On 19.12.2014 10:45, Guido Günther wrote:
> >so it applies to interfaces of type 'direct' too.
> >
> >Reported and patch provided by Bastian Blank at
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600
> >---
> >
John Ferlan wrote:
> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for parsing
>> and formating the
On Mon, 2015-01-12 at 09:23 -0700, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
> >
> >> The first attempt to implement support for parsing/formatting Xen's
> >> xl disk config format copied Xen's flex-based parser into libvirt, which
> >> has
Ian Campbell wrote:
> On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
>
>> The first attempt to implement support for parsing/formatting Xen's
>> xl disk config format copied Xen's flex-based parser into libvirt, which
>> has proved to be challenging in the context of autotools. But as it
On Mon, Jan 12, 2015 at 04:55:59PM +0100, Jiri Denemark wrote:
> On Thu, Jan 08, 2015 at 15:48:14 +, Daniel Berrange wrote:
> > Add a helper method that can validate an XML document against
> > an RNG schema
> > ---
> > include/libvirt/virterror.h | 1 +
> > src/internal.h | 4 +
On 01/12/2015 07:51 AM, John Ferlan wrote:
>
>
> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>> This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853.
>>
>> Conflicts:
>> src/Makefile.am
>>
>> Signed-off-by: Jim Fehlig
>> ---
>> .gitignore| 1 -
>> cfg.mk
On 01/12/2015 08:06 AM, Ian Campbell wrote:
> On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
>> The first attempt to implement support for parsing/formatting Xen's
>> xl disk config format copied Xen's flex-based parser into libvirt, which
>> has proved to be challenging in the context of aut
On Thu, Jan 08, 2015 at 15:48:14 +, Daniel Berrange wrote:
> Add a helper method that can validate an XML document against
> an RNG schema
> ---
> include/libvirt/virterror.h | 1 +
> src/internal.h | 4 +++
> src/libvirt_private.syms| 1 +
> src/util/virerror.c |
On Thu, Jan 08, 2015 at 15:48:12 +, Daniel Berrange wrote:
> The virDomainDefineXML method is one of the few that still lacks
> an 'unsigned int flags' parameter. This will be needed for adding
> XML validation to this API. virDomainCreateXML fortunately already
> has flags.
> ---
> include/li
On Thu, Jan 08, 2015 at 15:48:13 +, Daniel Berrange wrote:
> Make sure every virt driver implements virDomainDefineXMLFlags
> by adding a trivial passthrough from the existing impl with
> no flags set.
> ---
> src/bhyve/bhyve_driver.c | 12 ++--
> src/esx/esx_driver.c
On 26.12.2014 15:43, Dmitry Guryanov wrote:
Ploop is a pseudo device which makes possible to access
to an image in a file via block device, like loop devices,
but with additional features: snapshots, write tracker
and without double-caching.
It used in PCS for containers and in OpenVZ. You can m
On 26.12.2014 15:43, Dmitry Guryanov wrote:
Handle information about filesystems in domain config
and add corresponding devices to container via
parallels sdk.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_sdk.c | 109 +-
1 file changed, 1
On 26.12.2014 15:43, Dmitry Guryanov wrote:
It's possible to create a container with existing
disk image as root filesystem. You need to remove
existing disks from PCS VM config and then add a new
one, pointing to your image. And then call PrlVm_RegEx
with PRNVM_PRESERVE_DISK flag.
With this pat
On 26.12.2014 15:43, Dmitry Guryanov wrote:
Obtain information about container's filesystems and
store it in virDomainDef structure.
Signed-off-by: Dmitry Guryanov
---
src/parallels/parallels_sdk.c | 63 ---
1 file changed, 60 insertions(+), 3 deletion
On 01/10/2015 12:03 AM, Jim Fehlig wrote:
> Introduce a parser/formatter for the xl config format. Since the
> deprecation of xm/xend, the VM config file format has diverged as
> new features are added to libxl. This patch adds support for parsing
> and formating the xl config format. It suppo
On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
> The first attempt to implement support for parsing/formatting Xen's
> xl disk config format copied Xen's flex-based parser into libvirt, which
> has proved to be challenging in the context of autotools. But as it turns
> out, Xen provides an i
On 01/10/2015 12:03 AM, Jim Fehlig wrote:
> This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853.
>
> Conflicts:
> src/Makefile.am
>
> Signed-off-by: Jim Fehlig
> ---
> .gitignore| 1 -
> cfg.mk| 3 +-
> configure.ac
Well, apparently it's possible for a patch to sneak in through
review process and break 'make check'. It happened just lately
with 0e502466acb84a which changed the default of vgamem_mb for
qxl device. However, there were left some domain XMLs within our
test suite relying on the old default. These
On Mon, 2015-01-12 at 08:58 -0500, John Ferlan wrote:
>
> On 01/12/2015 02:36 AM, Pavel Hrdina wrote:
> > On 01/09/2015 05:02 PM, John Ferlan wrote:
> >> With the build fix, my coverity build worked again (good), but found
> >> more issues (boo).
> >>
> >> Consider these changes partially as a rep
https://bugzilla.redhat.com/show_bug.cgi?id=1176503
When guest start failed, libvirt will keep the current vm->def,
this will make a issue that we cannot get a right xml after guest
start failed. And don't call the stop/release hook to do some
other clean work.
Call virLXCProcessCleanup to help u
On 01/12/2015 05:09 AM, hong-hua@freescale.com wrote:
> Hi Laine,
>
> I'm not sure if /usr/include/linux/rtnetlink.h is necessary in the filesystem
> on host machine.
>
> In our scenario, both host machine and iNIC card are both PowerPC boards.
> I just checked the linux source code we used
>
On 12/19/2014 03:49 PM, Daniel Hansel wrote:
> The curent libvirt CPU driver for s390 does not return a host CPU model.
> This patch returns 'host' according to the other platforms that would
> not decode any CPU model.
> This is an intermediate bugfix due to a discussion on OpenStack mailing
> lis
On 01/12/2015 02:36 AM, Pavel Hrdina wrote:
> On 01/09/2015 05:02 PM, John Ferlan wrote:
>> With the build fix, my coverity build worked again (good), but found
>> more issues (boo).
>>
>> Consider these changes partially as a replacement for Pavel's patch:
>>
>> http://www.redhat.com/archives/li
On 01/12/2015 02:49 PM, Jiri Denemark wrote:
On Mon, Jan 12, 2015 at 13:56:12 +0100, Pavel Hrdina wrote:
The default value should be 16 MiB instead of 8 MiB. Only really old
version of upstream QEMU used the 8 MiB as default for vga framebuffer.
Without this change if you update your libvirt wh
On Mon, Jan 12, 2015 at 13:56:12 +0100, Pavel Hrdina wrote:
> The default value should be 16 MiB instead of 8 MiB. Only really old
> version of upstream QEMU used the 8 MiB as default for vga framebuffer.
>
> Without this change if you update your libvirt where we introduced the
> "vgamem" attribu
QEMU supports feature specification with -cpu host and we just skip
using that. Since QEMU developers themselves would like to use this
feature, this patch modifies the code to work.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1178850
Signed-off-by: Martin Kletzander
---
docs/formatd
On 12/11/2014 03:46 AM, Hao Liu wrote:
> Commit 6b9964 enforces checking invalid use of VSH_OT_STRING with
> VSH_OFLAG_REQ. This commit tries to do the same thing to stop using
> VSH_OT_DATA without VSH_OFLAG_REQ and also fix existing misuse.
>
> Signed-off-by: Hao Liu
> ---
> V2:
> Add missi
On 12.01.2015 14:20, Laszlo Ersek wrote:
> On 01/12/15 13:54, Michal Privoznik wrote:
>> It was brought to my attention that some -boot options may not
>> work with UEFI. For instance, rebootTimeout is very SeaBIOS
>> specific,splash logo is not implemented yet on OVMF, and so on.
>> We should docu
On Mon, Jan 12, 2015 at 02:21:35PM +0100, Martin Kletzander wrote:
> QEMU supports feature specification with -cpu host and we just skip
> using that. Since QEMU developers themselves would like to use this
> feature, this patch modifies the code to work.
This is actually useful in other ways too
This is based on top of:
https://www.redhat.com/archives/libvir-list/2015-January/msg00307.html
Martin Kletzander (2):
docs, schema, conf: Add support for PMU feature
qemu: Add support for enabling/disabling PMU
docs/formatdomain.html.in | 6 ++
docs/schemas/dom
This is used as a boolean parameter for the '-cpu' option.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1178853
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c | 12 +++-
tests/qemuxml2argvdata/qemuxml2argv-pmu-feature-off.args | 5
Just a new feature that can be turned on/off.
https://bugzilla.redhat.com/show_bug.cgi?id=1178853
Signed-off-by: Martin Kletzander
---
docs/formatdomain.html.in | 6 ++
docs/schemas/domaincommon.rng | 11 ++
src/conf/domain_conf.c
On 01/12/15 13:54, Michal Privoznik wrote:
> It was brought to my attention that some -boot options may not
> work with UEFI. For instance, rebootTimeout is very SeaBIOS
> specific,splash logo is not implemented yet on OVMF, and so on.
> We should document this limitation at least.
>
> Signed-off-
The default value should be 16 MiB instead of 8 MiB. Only really old
version of upstream QEMU used the 8 MiB as default for vga framebuffer.
Without this change if you update your libvirt where we introduced the
"vgamem" attribute for QXL video device the value will be set to 8 MiB,
but previously
It was brought to my attention that some -boot options may not
work with UEFI. For instance, rebootTimeout is very SeaBIOS
specific,splash logo is not implemented yet on OVMF, and so on.
We should document this limitation at least.
Signed-off-by: Michal Privoznik
---
diff to v1:
- Laszlo's sugge
Hi Michal,
On Mon, 2015-01-12 at 11:47 +0100, Michal Privoznik wrote:
> On 09.01.2015 17:47, Cédric Bosdonnat wrote:
> > Made the network configuration schemas and codes for the route element
> > reusable.
> > Created networkcommon_conf.[ch] files containing pieces to be used in both
> > domain
On 09.01.2015 17:47, Cédric Bosdonnat wrote:
Made the network configuration schemas and codes for the route element reusable.
Created networkcommon_conf.[ch] files containing pieces to be used in both
domain
and network configurations.
Replaced the brand new domain route configuration by the ne
Hi Laine,
I'm not sure if /usr/include/linux/rtnetlink.h is necessary in the filesystem
on host machine.
In our scenario, both host machine and iNIC card are both PowerPC boards.
I just checked the linux source code we used
$ grep -r RTEXT_FILTER_VF ./
./include/uapi/linux/rtnetlink.h:#define RT
Thanks for pointing out. I will move them to patch
qemu: add id when build RNG device and rename object id
in next version.
Luyao
- Original Message -
From: "Peter Krempa"
To: "Luyao Huang" , libvir-list@redhat.com
Sent: Monday, January 12, 2015 5:35:54 PM
Subject: Re: [libvirt] [PATCH v
Hi Laine,
Thank you for the reply. I tried to dump the information.
> -Original Message-
> From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of Laine
> Stump
> Sent: Thursday, January 08, 2015 11:13 PM
> To: Yin Olivia-R63875
> Cc: libvir-list@redhat.com
> Subject: Re: E
On Sun, 2015-01-11 at 13:51 +0100, Guido Günther wrote:
> Reported and patch provided by Bastian Blank at
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600
> ---
> src/lxc/lxc_container.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lxc/lxc_containe
On 19.12.2014 10:45, Guido Günther wrote:
so it applies to interfaces of type 'direct' too.
Reported and patch provided by Bastian Blank at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600
---
src/lxc/lxc_process.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
On 01/10/15 04:29, Luyao Huang wrote:
> Signed-off-by: Luyao Huang
> ---
> tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args | 4 ++--
> tests/qemuxml2argvdata/qemuxml2argv-arm-vexpressa9-virtio.args | 4 ++--
> tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args | 4 ++--
On 04.12.2014 08:27, Shivaprasad G Bhat wrote:
The struct members can't be referenced from files including the .h.
Moving the definition to .h from .c helps referencing the members. The patch
is just the struct definition code movement.
Signed-off-by: Shivaprasad G Bhat
---
src/util/virpci.c
On 04.12.2014 08:28, Shivaprasad G Bhat wrote:
The virsh start fails with qemu error when the hostdevices of the
same iommu group are used actively by other vms. It is not clear which
hostdev from the same iommu group is used by any of the running guests.
User has to go through every guest xml t
70 matches
Mail list logo
