Re: [libvirt] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-26 Thread Fam Zheng
On Fri, 01/23 17:21, Stefan Hajnoczi wrote: > Dear libvirt, KVM, and QEMU contributors, > The Google Summer of Code season begins soon and it's time to collect > our thoughts for mentoring students this summer working full-time on > libvirt, KVM, and QEMU. > > What is GSoC? > Google Summer of Code

Re: [libvirt] [PATCH] cpu: add Freescale ppc64 CPU models

2015-01-26 Thread hong-hua....@freescale.com
Hi Prerna, Currently, cpu_powerpc.c only support IBM ppc64 CPU models. Could your please help review the previous patch? With this patch, Freescale ppc64 CPU modesl could also be recognized. # virsh cpu-models ppc64 POWER7 POWER7_v2.1 POWER7_v2.3 POWER7+_v2.1 POWER8_v1.0 POWERPC_e5500_v10 POWERP

[libvirt] [PATCH tck 4/5] Ensure uri_transport is defined before using it

2015-01-26 Thread Mike Latimer
Under some environments (such as Xen), there may not be a uri_transport defined. As this is not required, ensure the value is defined before attempting to use it --- lib/Sys/Virt/TCK/Capabilities.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Sys/Virt/TCK/Capabi

[libvirt] [PATCH tck 3/5] hooks/05[12]: Fix typo in skip

2015-01-26 Thread Mike Latimer
Correct the order of parameters passed to skip to ensure the following tests are only executed under qemu and lxc environments: hooks/051-daemon-hook.t hooks/052-domain-hook.t --- scripts/hooks/051-daemon-hook.t | 2 +- scripts/hooks/052-domain-hook.t | 2 +- 2 files changed, 2 insertions

[libvirt] [PATCH tck 5/5] Prevent list_snapshots from causing test cleanup failure

2015-01-26 Thread Mike Latimer
When TCK cleans up a test domain, existing snapshots are deleted. However, not all drivers (e.g. libxl) support snapshots. When such a driver is involved, the following error is reported and the testkit fails to cleanup the domain: libvirt error code: 3, message: this function is not supported b

[libvirt] [PATCH tck 2/5] nwfilter/050-apply-verify-host.t: Fix typo, cleanup filter

2015-01-26 Thread Mike Latimer
If nwfilter/050-apply-verify-host.t fails to start a test VM, a typo causes the word 'Domain' to be executed as a command after undefining the VM: ./nwfilter2vmtest.sh: line 425: Domain: command not found Also, if either one of the test VM fails to be created, the test filter should be deleted

[libvirt] [PATCH tck 0/5] Misc. TCK cleanups

2015-01-26 Thread Mike Latimer
While running TCK on qemu, lxc and xen, I've ran into a few issues worth fixing upstream. The patches in this series are mainly focused on fixing minor typos, or safeguarding against failures in non-qemu environments. Depending on how interested people are in running TCK with xen, I can provide a

[libvirt] [PATCH tck 1/5] hooks/051-daemon-hook: Return 0 after connection reset

2015-01-26 Thread Mike Latimer
Despite running all subtests successfully, hooks/051-daemon-hook.t ends with a return code of 141. This is due to the connection to tck not being cleaned up properly after libvirtd is restarted in the middle of the test. Ignoring the SIGPIPE and specifically undefining $tck allows the test to comp

Re: [libvirt] [PATCH] tests: Check for virQEMUDriverConfigNew return value

2015-01-26 Thread Michal Privoznik
On 26.01.2015 17:24, Martin Kletzander wrote: > On Mon, Jan 26, 2015 at 05:12:25PM +0100, Michal Privoznik wrote: >> The function may return NULL if something went wrong. In some places >> in the tests we are not checking the return value rather than >> accessing the pointer directly resulting in S

Re: [libvirt] [vbox-dev] Assert with libvirt + xen hvm

2015-01-26 Thread Klaus Espenlaub
Hi all, On 26.01.2015 10:52, Michal Privoznik wrote: [CC'ing vbox-dev list] On 23.01.2015 21:42, CloudPatch Staff wrote: After some debugging we found what was causing of the assert. In our configuration we have two kernels to boot, one is a pv-linux for Xen dom0 and another just a normal linu

[libvirt] Missing libxl_device_nic settings

2015-01-26 Thread Kim Larry
Hi, I was trying to pass ip address to scripts/vif-bridge by putting in guest config xml file, however, I found that libxlMakeNic(which located in libxl/libxl_conf.c:956) doesn't set x_nic->ip. So I patched myself but I'm not so sure about  VIR_DOMAIN_NET_TYPE_ETHERNET. It seems like vif-route

[libvirt] Missing libxl_device_nic settings

2015-01-26 Thread Kim Larry
Hi, I was trying to pass ip address to scripts/vif-bridge by putting in guest config xml file, however, I found that libxlMakeNic(which located in libxl/libxl_conf.c:956) doesn't set x_nic->ip. So I patched myself but I'm not so sure about  VIR_DOMAIN_NET_TYPE_ETHERNET. It seems like vif-route

Re: [libvirt] [PATCH] tests: Check for virQEMUDriverConfigNew return value

2015-01-26 Thread Martin Kletzander
On Mon, Jan 26, 2015 at 05:12:25PM +0100, Michal Privoznik wrote: The function may return NULL if something went wrong. In some places in the tests we are not checking the return value rather than accessing the pointer directly resulting in SIGSEGV. Signed-off-by: Michal Privoznik --- tests/dom

[libvirt] [PATCH] tests: Check for virQEMUDriverConfigNew return value

2015-01-26 Thread Michal Privoznik
The function may return NULL if something went wrong. In some places in the tests we are not checking the return value rather than accessing the pointer directly resulting in SIGSEGV. Signed-off-by: Michal Privoznik --- tests/domaincapstest.c | 3 +++ tests/qemuhotplugtest.c | 3 ++- tests/qemu

[libvirt] [PATCH v5 1/2] qemu: Allow UEFI paths to be specified at compile time

2015-01-26 Thread Michal Privoznik
Up until now there are just two ways how to specify UEFI paths to libvirt. The first one is editing qemu.conf, the other is editing qemu_conf.c and recompile which is not that fancy. So, new configure option is introduced: --with-loader-nvram which takes a list of pairs of UEFI firmware and NVRAM s

[libvirt] [PATCH v5 0/2] Allow UEFI paths to be specified at compile time

2015-01-26 Thread Michal Privoznik
diff to v4: - added check for list consistence to configure too - slightly reformatted C parsing code 2/2 has been ACKed meanwhile, so sending it just for completeness. Michal Privoznik (2): qemu: Allow UEFI paths to be specified at compile time qemu: Add AAVMF to the list of known UEFIs co

[libvirt] [PATCH v5 2/2] qemu: Add AAVMF to the list of known UEFIs

2015-01-26 Thread Michal Privoznik
Well, even though users can pass the list of UEFI:NVRAM pairs at the configure time, we may maintain the list of widely available UEFI ourselves too. And as arm64 begin to rises, OVMF was ported there too. With a slight name change - it's called AAVMF, with AAVMF_CODE.fd being the UEFI firmware and

Re: [libvirt] [PATCH v4 2/2] qemu: Add AAVMF to the list of known UEFIs

2015-01-26 Thread Martin Kletzander
On Wed, Jan 21, 2015 at 08:21:29PM +0100, Michal Privoznik wrote: Well, even though users can pass the list of UEFI:NVRAM pairs at the configure time, we may maintain the list of widely available UEFI ourselves too. And as arm64 begin to rises, OVMF was ported there too. With a slight name change

Re: [libvirt] [PATCH] Fix a memory leak in virCgroupGetPercpuStats

2015-01-26 Thread Erik Skultety
On 01/26/2015 10:22 AM, Ján Tomko wrote: > --- > src/util/vircgroup.c | 6 -- > tests/vircgrouptest.c | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c > index e65617a..6957e81 100644 > --- a/src/util/vircgroup.c > +++ b/sr

Re: [libvirt] [PATCH v4 1/2] qemu: Allow UEFI paths to be specified at compile time

2015-01-26 Thread Michal Privoznik
On 26.01.2015 10:34, Martin Kletzander wrote: > On Wed, Jan 21, 2015 at 08:21:28PM +0100, Michal Privoznik wrote: >> Up until now there are just two ways how to specify UEFI paths to >> libvirt. The first one is editing qemu.conf, the other is editing >> qemu_conf.c and recompile which is not that

Re: [libvirt] [PATCH] [Build-breaker : 1.2.12] Suppress compilation without dbus headers

2015-01-26 Thread Prerna Saxena
On Monday 26 January 2015 02:47 PM, Daniel P. Berrange wrote: > On Sun, Jan 25, 2015 at 05:56:25PM +0530, Prerna Saxena wrote: >> Hi, >> While testing 1.2.12 rc2 on Powerpc, Fedora 21, I hit a bunch of build >> failures in absence of dbus-devel : >> >> src/util/virsystemd.c:284:17: note: in expan

Re: [libvirt] Assert with libvirt + xen hvm

2015-01-26 Thread Michal Privoznik
[CC'ing vbox-dev list] On 23.01.2015 21:42, CloudPatch Staff wrote: > After some debugging we found what was causing of the assert. In our > configuration we have > two kernels to boot, one is a pv-linux for Xen dom0 and another just a > normal linux kernel. > We have libvirt built with both Xen

[libvirt] [PATCHv2] util: bitmap: Tolerate NULL bitmaps in virBitmapEqual

2015-01-26 Thread Peter Krempa
After virBitmapEqual is able to compare NULL bitmaps few bits of code can be cleaned up. --- Version 2 cleans up code paths that would do a duplicate check now. src/conf/domain_conf.c | 40 ++-- src/conf/numatune_conf.c | 3 --- src/util/virbitmap.c | 6

Re: [libvirt] [libvirt-test-API][PATCH] Add IPv6 section into network case

2015-01-26 Thread hongming
Please sent patch V2 rather than generate the patch from your local repo. Also add the v2->v1 changes to the description of patch. Summary likes following [libvirt] [libvirt-test-API][PATCH v2] Add network_dhcp_leases test case On 01/26/2015 11:50 AM, jiahu wrote: Add IPv6 family related scenar

Re: [libvirt] [PATCH v4 1/2] qemu: Allow UEFI paths to be specified at compile time

2015-01-26 Thread Martin Kletzander
On Wed, Jan 21, 2015 at 08:21:28PM +0100, Michal Privoznik wrote: Up until now there are just two ways how to specify UEFI paths to libvirt. The first one is editing qemu.conf, the other is editing qemu_conf.c and recompile which is not that fancy. So, new configure option is introduced: --with-l

[libvirt] [PATCH] Fix a memory leak in virCgroupGetPercpuStats

2015-01-26 Thread Ján Tomko
Coverity reports that my commit af1c98e introduced two memory leaks: the cpumap if ncpus == 0 in virCgroupGetPercpuStats and the params array in the test of the function. --- src/util/vircgroup.c | 6 -- tests/vircgrouptest.c | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] [Build-breaker : 1.2.12] Suppress compilation without dbus headers

2015-01-26 Thread Daniel P. Berrange
On Sun, Jan 25, 2015 at 05:56:25PM +0530, Prerna Saxena wrote: > Hi, > While testing 1.2.12 rc2 on Powerpc, Fedora 21, I hit a bunch of build > failures in absence of dbus-devel : > > src/util/virsystemd.c:284:17: note: in expansion of macro 'STREQ_NULLABLE' > if (STREQ_NULLABLE("org

Re: [libvirt] [PATCH] conf: Disallow emulatorpin when numatune's in effect

2015-01-26 Thread Martin Kletzander
On Thu, Jan 22, 2015 at 02:08:46PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1170492 In one of our previous commits (dc8b7ce7) we've obsoleted in favor of and others. If old element was passed it was That commit was not trying to obsolete , it was just a re-f