Re: [libvirt] [PATCH] conf: fix forget goto error when report a unsupport error

2015-02-03 Thread Peter Krempa
On Wed, Feb 04, 2015 at 10:33:29 +0800, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1188914 > > This will cause a issue that add a unsupport input device > to a hypervisor which unsupport it, also will cause a wrong > error message when the input device is not a mouse or keybo

Re: [libvirt] [PATCH] conf: forget goto error when the node->name is not valid

2015-02-03 Thread Peter Krempa
On Wed, Feb 04, 2015 at 09:53:24 +0800, Luyao Huang wrote: > Although it won't cause a issue now, the code won't > touch this place. > > Signed-off-by: Luyao Huang > --- > src/conf/domain_conf.c | 1 + > 1 file changed, 1 insertion(+) ACK. Pushed with tweaked commit message. Peter signature.

Re: [libvirt] [libvirt-test-API][PATCH V2 04/11] Add IPv6 section into related network case

2015-02-03 Thread Jianwei Hu
Thanks for your correction. - Original Message - From: "hongming" To: "jiahu" , libvir-list@redhat.com Sent: Friday, January 30, 2015 1:17:12 PM Subject: Re: [libvirt] [libvirt-test-API][PATCH V2 04/11] Add IPv6 section into related network case On 01/28/2015 03:14 PM, jiahu wrote:

[libvirt] [PATCH] conf: fix forget goto error when report a unsupport error

2015-02-03 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1188914 This will cause a issue that add a unsupport input device to a hypervisor which unsupport it, also will cause a wrong error message when the input device is not a mouse or keyboard. Signed-off-by: Luyao Huang --- src/conf/domain_conf.c | 1 +

Re: [libvirt] [PATCHv2] lxc: fix show the wrong xml when guest start failed

2015-02-03 Thread lhuang
On 02/03/2015 11:01 PM, John Ferlan wrote: On 01/12/2015 09:33 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1176503 When guest start failed, libvirt will keep the current vm->def, this will make a issue that we cannot get a right xml after guest start failed. And don't c

Re: [libvirt] [PATCH v2 0/2] add support for --reflink to virsh

2015-02-03 Thread Chen, Hanxiao
> -Original Message- > From: John Ferlan [mailto:jfer...@redhat.com] > Sent: Wednesday, February 04, 2015 12:39 AM > To: Chen, Hanxiao/陈 晗霄; libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH v2 0/2] add support for --reflink to virsh > > > > On 02/02/2015 10:05 PM, Chen Hanxiao wr

[libvirt] [PATCH] conf: forget goto error when the node->name is not valid

2015-02-03 Thread Luyao Huang
Although it won't cause a issue now, the code won't touch this place. Signed-off-by: Luyao Huang --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 706e5d2..3a0b13e 100644 --- a/src/conf/domain_conf.c +++ b/src/con

Re: [libvirt] [PATCH 2/3] virsh: prevent destroying a in-used network for net-destroy

2015-02-03 Thread Laine Stump
On 02/02/2015 09:08 AM, Lin Ma wrote: > * add --system flag for net-dumpxml to show information about the > attached interfaces of the virtual network. I don't like this extra flag - I think it is unnecessary. If we're going to more info to the status, then we can just always add it to the statu

Re: [libvirt] [PATCH 1/3] bridge_driver: Return the live state info of a given virtual network

2015-02-03 Thread Laine Stump
On 02/02/2015 09:08 AM, Lin Ma wrote: > It constructs a temporary static config of the network, Obtains all of > attached interfaces information through netcf, Then removes the config. > > Signed-off-by: Lin Ma > --- > include/libvirt/libvirt-network.h| 1 + > src/Makefile.am

Re: [libvirt] [PATCH] check "fc_host" and "vport_ops" capabilities in SCSI host nodedevs

2015-02-03 Thread John Ferlan
On 02/03/2015 06:55 AM, Shivaprasad G Bhat wrote: > fc_host & vport_ops devices are SCSI devices with additional capabilities. > Mere string comparison of basic types is not sufficient in this case. This > patch introduces additional capability checks for SCSI devices if the user > is looking to

Re: [libvirt] [PATCH] qemu: include libvirt & QEMU versions in QEMU log files

2015-02-03 Thread Eric Blake
On 02/03/2015 08:54 AM, Daniel P. Berrange wrote: > It is often helpful to know which version of libvirt and QEMU > was present when a guest was first launched. Ensure this info > is written into the QEMU log file for each guest. > --- > src/qemu/qemu_capabilities.c | 22 +- > src/

Re: [libvirt] [PATCH 1/3] bridge_driver: Return the live state info of a given virtual network

2015-02-03 Thread Michal Privoznik
On 02.02.2015 15:08, Lin Ma wrote: > It constructs a temporary static config of the network, Obtains all of > attached interfaces information through netcf, Then removes the config. > > Signed-off-by: Lin Ma > --- > include/libvirt/libvirt-network.h| 1 + > src/Makefile.am

[libvirt] [PATCH] qemu: include libvirt & QEMU versions in QEMU log files

2015-02-03 Thread Daniel P. Berrange
It is often helpful to know which version of libvirt and QEMU was present when a guest was first launched. Ensure this info is written into the QEMU log file for each guest. --- src/qemu/qemu_capabilities.c | 22 +- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c

Re: [libvirt] [PATCH 2/3] virsh: prevent destroying a in-used network for net-destroy

2015-02-03 Thread Michal Privoznik
On 02.02.2015 15:08, Lin Ma wrote: > * add --system flag for net-dumpxml to show information about the > attached interfaces of the virtual network. > > * call virNetworkGetXMLDesc in cmdNetworkDestroy to get the live state > info to check whether the virtual network is in use. > > * add --fo

Re: [libvirt] [RFC PATCH 06/12] qemu: memdev: Add infrastructure to load memory device information

2015-02-03 Thread Ján Tomko
On Fri, Jan 30, 2015 at 02:21:03PM +0100, Peter Krempa wrote: > When using 'acpi-dimm' memory devices with qemu, some of the information > like the slot number and base address need to be reloaded from qemu > after process start so that it reflects the actual state. The state then > allows to use m

Re: [libvirt] [PATCH 0/2] storage: Fix crash with NBD backing store without path

2015-02-03 Thread Eric Blake
On 02/03/2015 10:09 AM, Peter Krempa wrote: > Storage volume with "nbd://localhost" would crash libvirt if being parsed. > > Peter Krempa (2): > tests: virstoragetest: Switch backing chain test to use automatic > numbering > util: storage: Fix parsing of nbd: string without path > > src/

[libvirt] [PATCH 1/2] tests: virstoragetest: Switch backing chain test to use automatic numbering

2015-02-03 Thread Peter Krempa
I'm going to add a few test cases so it's the best time to convert the test to automatic numbering. --- tests/virstoragetest.c | 55 +- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c in

[libvirt] [PATCH 0/2] storage: Fix crash with NBD backing store without path

2015-02-03 Thread Peter Krempa
Storage volume with "nbd://localhost" would crash libvirt if being parsed. Peter Krempa (2): tests: virstoragetest: Switch backing chain test to use automatic numbering util: storage: Fix parsing of nbd: string without path src/util/virstoragefile.c | 3 ++- tests/virstoragetest.c|

Re: [libvirt] [PATCH 3/3] virsh: prevent removing a in-used bridge for iface-unbridge

2015-02-03 Thread Michal Privoznik
On 02.02.2015 15:08, Lin Ma wrote: > By checking transient interfaces, It obtains the live information of > attached interfaces to see if the bridge is in use. > > Signed-off-by: Lin Ma > --- > tools/virsh-interface.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletion

[libvirt] [PATCH 2/2] util: storage: Fix parsing of nbd: string without path

2015-02-03 Thread Peter Krempa
If a storage file would be backed with a NBD device without path (nbd://localhost) libvirt would crash when parsing the backing path for the disk as the URI structure's path element is NULL in such case but the NBD parser would access it shamelessly. --- src/util/virstoragefile.c | 3 ++- tests/v

Re: [libvirt] [PATCH 2/2] virutil: fix MinGW build

2015-02-03 Thread Eric Blake
On 02/03/2015 06:27 AM, Pavel Hrdina wrote: > Commit b38da584 introduced two new functions to get a page size but it > won't work on Windows. We should take care of this. > > Signed-off-by: Pavel Hrdina > --- > src/util/virutil.c | 8 > 1 file changed, 8 insertions(+) > > +#else /* WI

Re: [libvirt] [PATCH v2 1/2] virnetdev: fix some issues found by coverity and mingw builds

2015-02-03 Thread Laine Stump
On 02/03/2015 08:27 AM, Pavel Hrdina wrote: > Commit e562a61a introduced new function to get/set interface state but > there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also > we need to wrap that functions by #ifdef to not break mingw build. > > Signed-off-by: Pavel Hrdina > ---

Re: [libvirt] [PATCH v2 1/2] virnetdev: fix some issues found by coverity and mingw builds

2015-02-03 Thread Pavel Hrdina
On 02/03/2015 03:48 PM, Laine Stump wrote: On 02/03/2015 08:27 AM, Pavel Hrdina wrote: Commit e562a61a introduced new function to get/set interface state but there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also we need to wrap that functions by #ifdef to not break mingw build

Re: [libvirt] [PATCH 2/2] virutil: fix MinGW build

2015-02-03 Thread Pavel Hrdina
On 02/03/2015 03:54 PM, Ján Tomko wrote: On Tue, Feb 03, 2015 at 02:27:35PM +0100, Pavel Hrdina wrote: Commit b38da584 introduced two new functions to get a page size but it won't work on Windows. We should take care of this. Signed-off-by: Pavel Hrdina --- src/util/virutil.c | 8

Re: [libvirt] [PATCH 2/2] virutil: fix MinGW build

2015-02-03 Thread Ján Tomko
On Tue, Feb 03, 2015 at 02:27:35PM +0100, Pavel Hrdina wrote: > Commit b38da584 introduced two new functions to get a page size but it > won't work on Windows. We should take care of this. > > Signed-off-by: Pavel Hrdina > --- > src/util/virutil.c | 8 > 1 file changed, 8 insertions(+)

Re: [libvirt] [RFC PATCH 00/12] Add support for memory hotplug

2015-02-03 Thread Ján Tomko
On Fri, Jan 30, 2015 at 02:20:57PM +0100, Peter Krempa wrote: > !! this series applies on top of the cleanup series posted earlier !! > > Hi, > this is my try to implement memory hotplug in libvirt (for the qemu) driver. > This series is almost code-complete but is lacking tests and docs as I want

Re: [libvirt] [PATCH 0/3] Prevent removing a in-used static bridge and destroying a in-used virtual network

2015-02-03 Thread Michal Privoznik
On 02.02.2015 15:08, Lin Ma wrote: > * Get the live state info of a virtual network through netcf in > networkGetXMLDesc. > * Add --system flag for net-dumpxml to show the live state info. > * Check the live state info in net-destroy. > * Add --force flag for net-destroy to forcibly destroy the vi

Re: [libvirt] [PATCH v2 0/2] add support for --reflink to virsh

2015-02-03 Thread John Ferlan
On 02/02/2015 10:05 PM, Chen Hanxiao wrote: > v2: add man page patch > > Chen Hanxiao (2): > virsh-volume: add support for --reflink > man: add --reflink man page of virsh > > tools/virsh-volume.c | 16 > tools/virsh.pod | 9 - > 2 files changed, 24 insertion

Re: [libvirt] [PATCH] virsh: report 0-length active block-commit job status

2015-02-03 Thread John Ferlan
On 01/27/2015 12:48 PM, Eric Blake wrote: > On 01/19/2015 03:01 PM, John Ferlan wrote: >> > > Revisiting, now that the release is done. > >> >> On 01/12/2015 05:54 PM, Eric Blake wrote: >>> At least with live block commit, it is possible to have a block >>> job that reports 0 status: namely, wh

[libvirt] [PATCH 0/2] fix build issues found by MinGW and Coverity

2015-02-03 Thread Pavel Hrdina
Pavel Hrdina (2): virnetdev: fix some issues found by coverity and mingw builds virutil: fix MinGW build src/util/virnetdev.c | 36 src/util/virnetdev.h | 6 +++--- src/util/virutil.c | 8 3 files changed, 35 insertions(+), 15 deletions(-) --

[libvirt] Looking for Outreachy sponsors for QEMU, libvirt, and KVM internships (was Outreach Program for Women)

2015-02-03 Thread Stefan Hajnoczi
Outreach Program for Women is renaming to Outreachy. The new website is: http://outreachy.org/ What is Outreachy? Outreachy helps people from underrepresented groups join the open source community through a 12-week full-time paid internship. The format is similar to Google Summer of Code. Inste

Re: [libvirt] [PATCHv2] lxc: fix show the wrong xml when guest start failed

2015-02-03 Thread John Ferlan
On 01/12/2015 09:33 AM, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1176503 > > When guest start failed, libvirt will keep the current vm->def, > this will make a issue that we cannot get a right xml after guest > start failed. And don't call the stop/release hook to do some

Re: [libvirt] [PATCH v2 1/2] virnetdev: fix some issues found by coverity and mingw builds

2015-02-03 Thread Ján Tomko
On Tue, Feb 03, 2015 at 02:27:34PM +0100, Pavel Hrdina wrote: > Commit e562a61a introduced new function to get/set interface state but > there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also > we need to wrap that functions by #ifdef to not break mingw build. > > Signed-off-by:

[libvirt] [PATCH v2 1/2] virnetdev: fix some issues found by coverity and mingw builds

2015-02-03 Thread Pavel Hrdina
Commit e562a61a introduced new function to get/set interface state but there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also we need to wrap that functions by #ifdef to not break mingw build. Signed-off-by: Pavel Hrdina --- src/util/virnetdev.c | 36 ---

[libvirt] [PATCH 2/2] virutil: fix MinGW build

2015-02-03 Thread Pavel Hrdina
Commit b38da584 introduced two new functions to get a page size but it won't work on Windows. We should take care of this. Signed-off-by: Pavel Hrdina --- src/util/virutil.c | 8 1 file changed, 8 insertions(+) diff --git a/src/util/virutil.c b/src/util/virutil.c index c905209..06e608d

[libvirt] [PATCH] check "fc_host" and "vport_ops" capabilities in SCSI host nodedevs

2015-02-03 Thread Shivaprasad G Bhat
fc_host & vport_ops devices are SCSI devices with additional capabilities. Mere string comparison of basic types is not sufficient in this case. This patch introduces additional capability checks for SCSI devices if the user is looking to list 'fc_host' or 'vport_ops' devices. Signed-off-by: Shiva

[libvirt] [PATCH] check "fc_host" and "vport_ops" capabilitis in SCSI host nodedevs

2015-02-03 Thread Shivaprasad G Bhat
virNodeListDevices called by listDevices indirectly uses the virNodeDeviceHasCap() which is buggy. Earlier, virNodeListDevices was used in "virsh nodedev-list" as well. Though, the code was rewritten to use vshNodeDeviceListCollect instead. The patch fixes listDevices output for the below python

Re: [libvirt] [PATCH 5/8] qemu: support attachment of disk device with boot index

2015-02-03 Thread Ján Tomko
On Mon, Jan 05, 2015 at 03:29:44PM +0800, Wang Rui wrote: > When we attach a disk to a running VM with boot index, we can get a > successful result. But in fact the boot index won't take effect. QEMU > supported to set device's boot index online recently(since QEMU 2.2.0). > It seems older QEMU s