Re: [libvirt] [PATCHv3 06/10] libxl: add tablet/mouse input device support

2015-02-20 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > From: Marek Marczykowski > > Signed-off-by: Marek Marczykowski-Górecki > --- > Changes in v2: > - rebase on 1.2.12+ > - multiple devices support > Changes in v3: > - reduce code duplication > > src/libxl/libxl_conf.c | 44 +++

Re: [libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

2015-02-20 Thread Marek Marczykowski-Górecki
On Fri, Feb 20, 2015 at 04:10:47PM -0700, Jim Fehlig wrote: > Marek Marczykowski-Górecki wrote: > > In Xen>=4.3, libxl supports new syntax for USB devices: > > usbdevice=[ "DEVICE", "DEVICE", ... ] > > Add support for that in xenconfig driver. When only one device is > > defined, keep using old syn

Re: [libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

2015-02-20 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > In Xen>=4.3, libxl supports new syntax for USB devices: > usbdevice=[ "DEVICE", "DEVICE", ... ] > Add support for that in xenconfig driver. When only one device is > defined, keep using old syntax for backward compatibility. > Cool, thanks for doing this! Bu

Re: [libvirt] [PATCHv3 06/10] libxl: add tablet/mouse input device support

2015-02-20 Thread Marek Marczykowski-Górecki
On Fri, Feb 20, 2015 at 03:45:02PM -0700, Jim Fehlig wrote: > Marek Marczykowski-Górecki wrote: > > From: Marek Marczykowski > > > > Signed-off-by: Marek Marczykowski-Górecki > > --- > > Changes in v2: > > - rebase on 1.2.12+ > > - multiple devices support > > Changes in v3: > > - reduce code

Re: [libvirt] [PATCHv4 03/10] libxl: support backend domain setting for disk and net devices

2015-02-20 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > From: Marek Marczykowski > > This implement handling of parameter introduced in > previous patch. > > Works on Xen >= 4.3, because only there libxl supports setting backend domain > by name, not XID. > > Signed-off-by: Marek Marczykowski-Górecki > --- > Chang

[libvirt] SR-IOV with libvirt

2015-02-20 Thread Florin Stingaciu
Hello, For the last little while I've been trying to configure a VM with a passthrough interface using SR-IOV. I've managed to configure SR-IOV on the hypervisor correctly. I'm working with a Mellanox ConnectX3 card with two infiniband ports and hypervisors running Centos 7. I can see the PCI devi

Re: [libvirt] [PATCHv4 02/10] conf: support backend domain name in disk and network devices

2015-02-20 Thread Jim Fehlig
Jim Fehlig wrote: > Marek Marczykowski-Górecki wrote: > >> From: Marek Marczykowski >> >> At least Xen supports backend drivers in another domain (aka "driver >> domain"). This patch introduces XML config option for such setting as >> 'domain' attribute of 'source' element. Verification its con

Re: [libvirt] [PATCHv4 02/10] conf: support backend domain name in disk and network devices

2015-02-20 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: > From: Marek Marczykowski > > At least Xen supports backend drivers in another domain (aka "driver > domain"). This patch introduces XML config option for such setting as > 'domain' attribute of 'source' element. Verification its content is left > for the driver.

[libvirt] [PATCH] qemu: fix ifindex array reported to systemd

2015-02-20 Thread Laine Stump
Commit f7afeddc added code to report to systemd an array of interface indexes for all tap devices used by a guest. Unfortunately it not only didn't add code to report the ifindexes for macvtap interfaces (interface type='direct') or the tap devices used by type='ethernet', it ended up sending "-1"

Re: [libvirt] [libvirt-python PATCH 1/2] Support virDomainGetIOThreadsInfo and virDomainIOThreadsInfoFree

2015-02-20 Thread John Ferlan
On 02/20/2015 12:42 PM, Pavel Hrdina wrote: > On Thu, Feb 19, 2015 at 07:59:38AM -0500, John Ferlan wrote: >> Add support for the libvirt_virDomainGetIOThreadsInfo method. This >> code mostly follows the libvirt_virDomainGetVcpuPinInfo method, but >> also takes some from the libvirt_virNodeGetCPU

Re: [libvirt] [PATCH 3/3] conf: numa: Check ABI stability of NUMA configuration

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 19:37:33 -0500, John Ferlan wrote: > > OK - I peeked after looking at 24/24 to see how difficult this series > would be (and before soaking my brain cells in liquid refreshment)... > > The first two seemed OK and it doesn't appear there's anyone else > disagreeing... > >

Re: [libvirt] [PATCH 04/11] conf: Add device address type for dimm devices

2015-02-20 Thread Martin Kletzander
On Fri, Feb 20, 2015 at 06:25:40PM +0100, Peter Krempa wrote: On Fri, Feb 20, 2015 at 10:19:53 +0100, Martin Kletzander wrote: On Thu, Feb 19, 2015 at 04:38:29PM +0100, Peter Krempa wrote: >ACPI Dimm devices are described by the slot and base address. Add a new >address type to be able to descri

Re: [libvirt] [PATCH 1/3] conf: ABI: Hugepage backing definition is not guest ABI

2015-02-20 Thread John Ferlan
On 02/16/2015 02:50 PM, Peter Krempa wrote: > The backing of the vm's memory isn't influencing the guest ABI thus > shouldn't be checked. > --- > src/conf/domain_conf.c | 24 > 1 file changed, 24 deletions(-) > Just to put it "officially there" - ACK... some thoughts

Re: [libvirt] [PATCH 01/11] qemu: caps: Add capability bit for the "pc-dimm" device

2015-02-20 Thread Peter Krempa
On Fri, Feb 20, 2015 at 08:40:52 +0100, Martin Kletzander wrote: > On Thu, Feb 19, 2015 at 04:38:26PM +0100, Peter Krempa wrote: > >The pc-dimm device represents a RAM memory module. > >--- > > src/qemu/qemu_capabilities.c | 2 ++ > > src/qemu/qemu_capabilities.h | 1

Re: [libvirt] [PATCH 3/7] conf: Hoist validation of memory size into the post parse callback

2015-02-20 Thread Peter Krempa
On Fri, Feb 20, 2015 at 08:19:26 -0500, John Ferlan wrote: > > > On 02/18/2015 09:16 AM, Peter Krempa wrote: > > Later patches will need to access the full definition to do check the > > memory size and thus the checking needs to be done after the whole > > definition including devices is known.

Re: [libvirt] [PATCH] Fix typos in messages

2015-02-20 Thread Pavel Hrdina
On Fri, Feb 20, 2015 at 06:50:40PM +0200, Yuri Chornoivan wrote: > --- > src/parallels/parallels_sdk.c | 2 +- > src/qemu/qemu_monitor_json.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c > i

Re: [libvirt] [PATCH 1/7] qemu: Forbid seting maximum memory size with the API with NUMA enabled

2015-02-20 Thread Peter Krempa
On Fri, Feb 20, 2015 at 07:37:03 -0500, John Ferlan wrote: > > $sub > > s/seting/setting > > On 02/18/2015 09:16 AM, Peter Krempa wrote: > > NUMA enabled guest configuration explicitly specifies memory sizes for > > individual nodes. Allowing the virDomainSetMemoryFlags API (and friends) > > to

[libvirt] Unattended guest installation fails

2015-02-20 Thread ChandraShekar Shastri
Hi, I am following the below link to install a Fedora19 guest on Fedora19 Host. http://kashyapc.com/2011/08/18/unattended-guest-install-with-a-local-kickstart/ Version : libvirtd (libvirt) 1.0.5.1, QEMU emulator version 1.4.2, Copyright (c) 2003-2008 Fabrice Bellard I have the iso which I lo

Re: [libvirt] [libvirt-python PATCH 1/2] Support virDomainGetIOThreadsInfo and virDomainIOThreadsInfoFree

2015-02-20 Thread Pavel Hrdina
On Thu, Feb 19, 2015 at 07:59:38AM -0500, John Ferlan wrote: > Add support for the libvirt_virDomainGetIOThreadsInfo method. This > code mostly follows the libvirt_virDomainGetVcpuPinInfo method, but > also takes some from the libvirt_virNodeGetCPUMap method with respect > to building the cpumap in

Re: [libvirt] [libvirt-python PATCH 2/2] Support virDomainSetIOThreads

2015-02-20 Thread Pavel Hrdina
On Thu, Feb 19, 2015 at 07:59:39AM -0500, John Ferlan wrote: > Support the libvirt_virDomainSetIOThreads method using code that mimics > the existing libvirt_virDomainPinVcpuFlags method > > The following is a sample session assuming guest 'iothr-gst' has IOThreads > configured (it's currently run

Re: [libvirt] [PATCH 04/11] conf: Add device address type for dimm devices

2015-02-20 Thread Peter Krempa
On Fri, Feb 20, 2015 at 10:19:53 +0100, Martin Kletzander wrote: > On Thu, Feb 19, 2015 at 04:38:29PM +0100, Peter Krempa wrote: > >ACPI Dimm devices are described by the slot and base address. Add a new > >address type to be able to describe such address. > >--- > > docs/schemas/domaincommon.rng |

Re: [libvirt] [PATCH RFC 2/3] conf: ABI: Memballoon setting is not guest ABI

2015-02-20 Thread Peter Krempa
On Mon, Feb 16, 2015 at 19:54:23 +, Daniel Berrange wrote: > On Mon, Feb 16, 2015 at 08:50:43PM +0100, Peter Krempa wrote: > > The current balloon setting does not influence the ABI of the guest and > > the driver should take the change just fine. > > --- > > I personally don't think that this

Re: [libvirt] [PATCH v2] qemu: Check for negative port values in network drive configuration

2015-02-20 Thread Martin Kletzander
On Fri, Feb 20, 2015 at 12:18:04PM +0100, Erik Skultety wrote: We interpret port values as signed int (convert them from char *), so if anegative value is provided in network disk's configuration, we accept it as valid, however there's an 'unknown cause' error raised later. This error is only acc

Re: [libvirt] [PATCH] qemu: Check for negative port values in network drive configuration

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 16:28:44 -0700, Eric Blake wrote: > On 02/19/2015 08:53 AM, Erik Skultety wrote: > > We interpret port values as signed int (convert them from char *), > > so if a negative value is provided in network disk's configuration, > > we accept it as valid, however there's an 'unkn

Re: [libvirt] [PATCH] qemu: Check for negative port values in network drive configuration

2015-02-20 Thread Martin Kletzander
On Thu, Feb 19, 2015 at 04:28:44PM -0700, Eric Blake wrote: On 02/19/2015 08:53 AM, Erik Skultety wrote: We interpret port values as signed int (convert them from char *), so if a negative value is provided in network disk's configuration, we accept it as valid, however there's an 'unknown cause

Re: [libvirt] [PATCH 24/24] conf: Move all NUMA configuration to virDomainNuma

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 19:28:56 -0500, John Ferlan wrote: > > > On 02/16/2015 01:52 PM, Peter Krempa wrote: > > For historical reasons data regarding NUMA configuration were split > > between the CPU definition and numatune. We cannot do anything about the > > XML still being split, but we certa

[libvirt] [PATCH] Fix typos in messages

2015-02-20 Thread Yuri Chornoivan
--- src/parallels/parallels_sdk.c | 2 +- src/qemu/qemu_monitor_json.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index bbc26ef..36c6c5f 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parall

Re: [libvirt] [PATCH v2] libvirt-guests: Allow time sync on guests resume

2015-02-20 Thread Ján Tomko
On Wed, Feb 18, 2015 at 05:09:41PM +0100, Michal Privoznik wrote: > diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf > index d1f2051..03e732f 100644 > --- a/tools/libvirt-guests.sysconf > +++ b/tools/libvirt-guests.sysconf > @@ -39,3 +39,10 @@ > # restoring guests, even tho

Re: [libvirt] [PATCH 7/7] conf: Automatically use NUMA memory size in case NUMA is enabled

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > Use the NUMA total instead of the configured size both in XML and for > uses in the code once NUMA is enabled for a domain. > > One test case change is necessary as the rounding of the individual cell > sizes was not matching the rounding of the tota

Re: [libvirt] [PATCH 4/7] conf: Replace access to def-mem.max_balloon with accessor functions

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > As there are two possible approaches to define a domain's memory size - > one used with legacy, non-NUMA VMs configured in the element > and per-node based approach on NUMA machines - the user needs to make > sure that both are specified correctly in

Re: [libvirt] [PATCH 5/7] qemu: command: Add helper to align memory sizes

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > The memory sizes in qemu are aligned up to 1 MiB boundaries. There are > two places where this was done once for the total size and then for > individual NUMA cell sizes. > > Add a function that will align the sizes in one place so that it's clear >

Re: [libvirt] [PATCH 6/7] conf: numa: Add helper to count total memory size configured in NUMA

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > The total NUMA memory consists of the sum of individual NUMA node memory > amounts. > --- > src/conf/numa_conf.c | 13 + > src/conf/numa_conf.h | 1 + > src/libvirt_private.syms | 1 + > 3 files changed, 15 insertions(+) > ACK

[libvirt] [PATCHv2] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Ján Tomko
Document that a complete device definition should be used and a partial match can lead to the device being detached. https://bugzilla.redhat.com/show_bug.cgi?id=872028 --- src/libvirt-domain.c | 14 ++ tools/virsh.pod | 9 ++--- 2 files changed, 20 insertions(+), 3 deletions

Re: [libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Michal Privoznik
On 20.02.2015 14:23, Ján Tomko wrote: > > > Would you object to a more general wording, or should we just not > advertise this at all? > For example: > > The supplied XML description of the device should be as specific > as its definition in the domain XML. The set of attributes used > to match t

Re: [libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Ján Tomko
On Fri, Feb 20, 2015 at 12:43:50PM +, Daniel P. Berrange wrote: > On Fri, Feb 20, 2015 at 01:16:24PM +0100, Michal Privoznik wrote: > > On 20.02.2015 12:39, Ján Tomko wrote: > > > Doucment that not all attributes are used for matching. s/Doucment/Document/ > > > > > > https://bugzilla.redhat

Re: [libvirt] [PATCH 3/7] conf: Hoist validation of memory size into the post parse callback

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > Later patches will need to access the full definition to do check the > memory size and thus the checking needs to be done after the whole > definition including devices is known. > --- > src/conf/domain_conf.c | 41 --

Re: [libvirt] [PATCH 2/7] qemu: lxc: Clarify error message when setting current memory

2015-02-20 Thread John Ferlan
On 02/18/2015 09:16 AM, Peter Krempa wrote: > Commit 60f7303c151cccdbe214b9f9ac59ecaf95cbf24b introduced the error > message but it's unclear whether the persistent config or the live > config tripped the message. Later the LXC driver copied the same code. > > Separate the message which will als

Re: [libvirt] [PATCH 3/3] qemuCaps: Disable memdev for rhel6.5.0 machine type

2015-02-20 Thread Daniel P. Berrange
On Fri, Feb 20, 2015 at 01:35:17PM +0100, Michal Privoznik wrote: > On 20.02.2015 12:11, Daniel P. Berrange wrote: > > On Fri, Feb 20, 2015 at 12:01:58PM +0100, Martin Kletzander wrote: > >> On Fri, Feb 13, 2015 at 02:29:49PM +, Daniel P. Berrange wrote: > >>> On Thu, Feb 12, 2015 at 04:09:40PM

Re: [libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Daniel P. Berrange
On Fri, Feb 20, 2015 at 01:16:24PM +0100, Michal Privoznik wrote: > On 20.02.2015 12:39, Ján Tomko wrote: > > Doucment that not all attributes are used for matching. > > > > https://bugzilla.redhat.com/show_bug.cgi?id=872028 > > --- > > src/libvirt-domain.c | 5 + > > tools/virsh.pod | 4

Re: [libvirt] [PATCH 1/7] qemu: Forbid seting maximum memory size with the API with NUMA enabled

2015-02-20 Thread John Ferlan
$sub s/seting/setting On 02/18/2015 09:16 AM, Peter Krempa wrote: > NUMA enabled guest configuration explicitly specifies memory sizes for > individual nodes. Allowing the virDomainSetMemoryFlags API (and friends) > to change the total doesn't make sense as the individual node configs > are not

Re: [libvirt] [PATCH 3/3] qemuCaps: Disable memdev for rhel6.5.0 machine type

2015-02-20 Thread Michal Privoznik
On 20.02.2015 12:11, Daniel P. Berrange wrote: > On Fri, Feb 20, 2015 at 12:01:58PM +0100, Martin Kletzander wrote: >> On Fri, Feb 13, 2015 at 02:29:49PM +, Daniel P. Berrange wrote: >>> On Thu, Feb 12, 2015 at 04:09:40PM +0100, Michal Privoznik wrote: Well, after [1] qemu doesn't understa

Re: [libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Michal Privoznik
On 20.02.2015 12:39, Ján Tomko wrote: > Doucment that not all attributes are used for matching. > > https://bugzilla.redhat.com/show_bug.cgi?id=872028 > --- > src/libvirt-domain.c | 5 + > tools/virsh.pod | 4 +++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/l

Re: [libvirt] [libvirt-python PATCH 1/2] Support virDomainGetIOThreadsInfo and virDomainIOThreadsInfoFree

2015-02-20 Thread Pavel Hrdina
On Thu, Feb 19, 2015 at 07:59:38AM -0500, John Ferlan wrote: > Add support for the libvirt_virDomainGetIOThreadsInfo method. This > code mostly follows the libvirt_virDomainGetVcpuPinInfo method, but > also takes some from the libvirt_virNodeGetCPUMap method with respect > to building the cpumap in

[libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

2015-02-20 Thread Ján Tomko
Doucment that not all attributes are used for matching. https://bugzilla.redhat.com/show_bug.cgi?id=872028 --- src/libvirt-domain.c | 5 + tools/virsh.pod | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 492e90a..a9

[libvirt] [PATCH v2] qemu: Check for negative port values in network drive configuration

2015-02-20 Thread Erik Skultety
We interpret port values as signed int (convert them from char *), so if anegative value is provided in network disk's configuration, we accept it as valid, however there's an 'unknown cause' error raised later. This error is only accidental because we return the port value in the return code. Thi

Re: [libvirt] [PATCH 3/3] qemuCaps: Disable memdev for rhel6.5.0 machine type

2015-02-20 Thread Daniel P. Berrange
On Fri, Feb 20, 2015 at 12:01:58PM +0100, Martin Kletzander wrote: > On Fri, Feb 13, 2015 at 02:29:49PM +, Daniel P. Berrange wrote: > >On Thu, Feb 12, 2015 at 04:09:40PM +0100, Michal Privoznik wrote: > >>Well, after [1] qemu doesn't understand '-object memory-backend-ram' > >>nor '-object mem

Re: [libvirt] [PATCH 3/3] qemuCaps: Disable memdev for rhel6.5.0 machine type

2015-02-20 Thread Martin Kletzander
On Fri, Feb 13, 2015 at 02:29:49PM +, Daniel P. Berrange wrote: On Thu, Feb 12, 2015 at 04:09:40PM +0100, Michal Privoznik wrote: Well, after [1] qemu doesn't understand '-object memory-backend-ram' nor '-object memory-backend-file'. Make sure we remove that capabilities from our internal li

Re: [libvirt] [PATCH 2/3] virQEMUCapsCacheLookupCopy: Filter qemuCaps based on machineType

2015-02-20 Thread Martin Kletzander
On Thu, Feb 12, 2015 at 04:09:39PM +0100, Michal Privoznik wrote: Not all machine types support all devices, device properties, backends, etc. So until we create a matrix of [machineType, qemuCaps], lets just filter out some capabilities before we return them to the consumer (which is going to ma

Re: [libvirt] [PATCH 1/3] virQEMUCapsCacheLookupCopy: Pass machine type

2015-02-20 Thread Martin Kletzander
On Thu, Feb 12, 2015 at 04:09:38PM +0100, Michal Privoznik wrote: It will come handy in the near future when we will filter some capabilities based on it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 4 +++- src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_migration.c

Re: [libvirt] [PATCH 19/24] qemu: command: Unify retrieval of NUMA cell count in qemuBuildNumaArgStr

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 18:38:38 -0500, John Ferlan wrote: > > > On 02/16/2015 01:52 PM, Peter Krempa wrote: > > The function uses the cell count in 6 places. Add a temp variable to > > hold the count as it will greatly simplify the refactor. > > --- > > src/qemu/qemu_command.c | 13 +++-

Re: [libvirt] [PATCH 16/24] conf: numa: Avoid re-allocation of the NUMA conf

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 18:17:08 -0500, John Ferlan wrote: > > > On 02/16/2015 01:52 PM, Peter Krempa wrote: > > As the numa object is now always present we can avoid the ad-hoc > > allocation code. > > --- > > src/conf/numa_conf.c | 26 ++ > > 1 file changed, 2 insertion

Re: [libvirt] [PATCH 11/24] conf: numa: Refactor logic in virDomainNumatuneParseXML

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 17:25:13 -0500, John Ferlan wrote: > > > On 02/16/2015 01:51 PM, Peter Krempa wrote: > > Shuffling around the logic will allow to simplify the code quite a bit. > > As an additional bonus the change in the logic now reports an error if > > automatic placement is selected a

Re: [libvirt] [PATCH 10/24] conf: numa: Reformat virDomainNumatuneParseXML

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 17:07:51 -0500, John Ferlan wrote: > > > On 02/16/2015 01:51 PM, Peter Krempa wrote: > > Make collapse few of the conditions so that the program flow is more > > clear. > > Reads awkwardly - I think remove the Make and you'll be OK Huh, yeah. I probably got sidetracked w

Re: [libvirt] [PATCH 06/24] conf: numa: Rename virDomainNumatune to virDomainNuma

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 16:52:59 -0500, John Ferlan wrote: > > > On 02/16/2015 01:51 PM, Peter Krempa wrote: > > The structure will gradually become the only place for NUMA related > > config, thus rename it appropriately. > > --- > > src/conf/domain_conf.c| 10 +++--- > > src/conf/domai

Re: [libvirt] [PATCH] virsh: fix vcpupin info

2015-02-20 Thread Michal Privoznik
On 20.02.2015 08:37, Pavel Hrdina wrote: > The "virDomainGetInfo" will get for running domain only live info and for > offline domain only config info. There was no way how to get config info > for running domain. We will use "vshCPUCountCollect" instead to get the > correct cpu count that we need

Re: [libvirt] [PATCH] util: do not take it as wrong if no PortData is found while getting migrateData

2015-02-20 Thread Martin Kletzander
On Thu, Feb 12, 2015 at 12:08:54PM +0800, Zhang Bo wrote: The function virNetDevOpenvswitchGetMigrateData() uses the cmd ovs-vsctl to get portdata. If no portdata is available, rather than failure in running the cmd, we think we should just print a warning message here, rather than taking it as w

Re: [libvirt] [PATCH 02/24] conf: Move NUMA cell parsing code from cpu conf to numa conf

2015-02-20 Thread Peter Krempa
On Thu, Feb 19, 2015 at 16:12:28 -0500, John Ferlan wrote: > > > On 02/16/2015 01:51 PM, Peter Krempa wrote: > > For weird historical reasons NUMA cells are added as a subelement of > > while the actual configuration is done in . > > > > This patch splits out the cell parser code from cpu confi

Re: [libvirt] [PATCH v3] virsh-edit: Make force editing usable

2015-02-20 Thread Michal Privoznik
On 20.02.2015 08:10, Martin Kletzander wrote: > When editing a domain with 'virsh edit' and failing validation, the > usual message pops up: > > Failed. Try again? [y,n,f,?]: > > Turning off validation can be useful, mainly for testing (but other > purposes too), so this patch adds support for

Re: [libvirt] [PATCH 04/11] conf: Add device address type for dimm devices

2015-02-20 Thread Martin Kletzander
On Thu, Feb 19, 2015 at 04:38:29PM +0100, Peter Krempa wrote: ACPI Dimm devices are described by the slot and base address. Add a new address type to be able to describe such address. --- docs/schemas/domaincommon.rng | 18 +++ src/conf/domain_conf.c| 74 +++

Re: [libvirt] [PATCH 03/11] qemu: Implement setup of memory hotplug parameters

2015-02-20 Thread Martin Kletzander
On Thu, Feb 19, 2015 at 04:38:28PM +0100, Peter Krempa wrote: To enable memory hotplug the maximum memory size and slot count need to be specified. As qemu supports now other units than mebibytes when specifying memory, use the new interface in this case. --- docs/formatdomain.html.in