Re: [libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number

2015-07-02 Thread lhuang
On 07/02/2015 06:28 PM, John Ferlan wrote: On 07/02/2015 05:46 AM, Pavel Hrdina wrote: ... diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 27d62e9..334fd3a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6497,6 +6497,19 @@ cmdVcpuPin(vshControl *ctl, const vsh

[libvirt] [PATCH] qemu: remove deadcode in qemuDomain{HelperGetVcpus|GetIOThreadsLive}

2015-07-02 Thread Luyao Huang
We set hostcpus but not use them. Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 8 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7a04e67..3f002b3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1418,13 +

Re: [libvirt] Request for libvirt wiki account creation

2015-07-02 Thread Prerna
Thanks a lot :) On Thu, Jul 2, 2015 at 9:40 PM, Daniel P. Berrange wrote: > On Thu, Jul 02, 2015 at 05:16:47PM +0530, Prerna wrote: > > Hi, > > I am interested in contributing some content to the libvirt wiki; and so > I > > need a libvirt wiki account. Could you pls create an account with > fol

Re: [libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Daniel P. Berrange
On Thu, Jul 02, 2015 at 04:42:47PM +0200, Henning Schild wrote: > On Thu, 2 Jul 2015 15:18:46 +0100 > "Daniel P. Berrange" wrote: > > > On Thu, Jul 02, 2015 at 04:02:58PM +0200, Henning Schild wrote: > > > Hi, > > > > > > i am currently looking into realtime VMs using libvirt. My first > > > sta

Re: [libvirt] Request for libvirt wiki account creation

2015-07-02 Thread Daniel P. Berrange
On Thu, Jul 02, 2015 at 05:16:47PM +0530, Prerna wrote: > Hi, > I am interested in contributing some content to the libvirt wiki; and so I > need a libvirt wiki account. Could you pls create an account with following > credentials: > username : prerna Created and replied offlist with password. Re

Re: [libvirt] Which symbols can be used in file paths in libvirt's XMLs?

2015-07-02 Thread Dmitry Guryanov
On 07/01/2015 07:36 PM, Daniel P. Berrange wrote: On Wed, Jul 01, 2015 at 07:22:33PM +0300, Dmitry Guryanov wrote: Hello, There is an absFilePatch type in docs/schemas/basictypes.rng rng schema: /[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+ There are quite few symbols in this set

[libvirt] [PATCH] docs: set more permissive patterns for paths in rng schemas

2015-07-02 Thread Dmitry Guryanov
There is no obvious reason to limit paths, used in libvirt to a subset of what is allowed in linux. So let's allow any symbols in paths. --- docs/schemas/basictypes.rng | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes

[libvirt] [PATCH 3/3] util: bitmap: Don't alloc overly large binary bitmaps

2015-07-02 Thread Peter Krempa
Optimize the virBitmap to array-of-char bitmap conversion by skipping trailing zero bytes. This also fixes a regression when requesting iothread information from a live VM since after commit 825df8c3158cfaf5f398418471f10f4ff3c3515a the bitmap returned from virProcessGetAffinity is too big to be fo

[libvirt] [PATCH 0/3] bitmap: Fix regression when getting iothread info

2015-07-02 Thread Peter Krempa
Peter Krempa (3): vz: Remove dead code from vzDomainGetVcpus vz: Use virBitmapToDataBuf instead of virBitmapToData in vzDomainGetVcpus util: bitmap: Don't alloc overly large binary bitmaps src/util/virbitmap.c | 7 +-- src/vz/vz_driver.c | 24 2 files cha

[libvirt] [PATCH 1/3] vz: Remove dead code from vzDomainGetVcpus

2015-07-02 Thread Peter Krempa
'maxcpu' and 'vcpus' are set but not used after that --- src/vz/vz_driver.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 47c5023..a489767 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -823,7 +823,7 @@ vzDoma

[libvirt] [PATCH 2/3] vz: Use virBitmapToDataBuf instead of virBitmapToData in vzDomainGetVcpus

2015-07-02 Thread Peter Krempa
--- src/vz/vz_driver.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index a489767..8d90191 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -823,7 +823,6 @@ vzDomainGetVcpus(virDomainPtr domain, { vi

Re: [libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Henning Schild
On Thu, 2 Jul 2015 15:18:46 +0100 "Daniel P. Berrange" wrote: > On Thu, Jul 02, 2015 at 04:02:58PM +0200, Henning Schild wrote: > > Hi, > > > > i am currently looking into realtime VMs using libvirt. My first > > starting point was reserving a couple of cores using isolcpus and > > later tuning

Re: [libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Daniel P. Berrange
On Thu, Jul 02, 2015 at 04:02:58PM +0200, Henning Schild wrote: > Hi, > > i am currently looking into realtime VMs using libvirt. My first > starting point was reserving a couple of cores using isolcpus and later > tuning the affinity to place my vcpus on the reserved pcpus. > > My first observat

[libvirt] cpu affinity, isolcpus and cgroups

2015-07-02 Thread Henning Schild
Hi, i am currently looking into realtime VMs using libvirt. My first starting point was reserving a couple of cores using isolcpus and later tuning the affinity to place my vcpus on the reserved pcpus. My first observation was that libvirt ignores isolcpus. Affinity masks of new qemus will defaul

[libvirt] [PATCH] storage: Fix regression in storagePoolUpdateAllState

2015-07-02 Thread Erik Skultety
Commit 2a31c5f0 introduced support for storage pool state XMLs, however it also introduced a regression: if (!virstoragePoolObjIsActive(pool)) { virStoragePoolObjUnlock(pool); continue; } The idea behind this was that since we've got state XMLs and the pool wasn't marked as active by auto

[libvirt] Request for libvirt wiki account creation

2015-07-02 Thread Prerna
Hi, I am interested in contributing some content to the libvirt wiki; and so I need a libvirt wiki account. Could you pls create an account with following credentials: username : prerna Thanks, Prerna Saxena -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [PATCH v2 2/4] virDomainObjSignal: drop this function

2015-07-02 Thread Peter Krempa
On Wed, Jul 01, 2015 at 17:29:09 -0400, John Ferlan wrote: > > > On 06/29/2015 11:17 AM, Pavel Hrdina wrote: > > There are multiple consumers for the domain condition and we should > > always wake them all. > > > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/domain_conf.c | 7 --- >

Re: [libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number

2015-07-02 Thread John Ferlan
On 07/02/2015 05:46 AM, Pavel Hrdina wrote: ... >> >> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >> index 27d62e9..334fd3a 100644 >> --- a/tools/virsh-domain.c >> +++ b/tools/virsh-domain.c >> @@ -6497,6 +6497,19 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) >> g

Re: [libvirt] [PATCHv3] virt-aa-helper: Fix permissions for vhost-user socket files

2015-07-02 Thread Michał Dubiel
Thanks Michal. Regards. On 2 July 2015 at 11:22, Michal Privoznik wrote: > On 01.07.2015 10:15, Michal Dubiel wrote: > > QEMU working in vhost-user mode communicates with the other end (i.e. > > some virtual router application) via unix domain sockets. This requires > > that permissions for the

Re: [libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number

2015-07-02 Thread Pavel Hrdina
On Thu, Jul 02, 2015 at 10:44:36AM +0800, lhuang wrote: > > On 07/02/2015 04:29 AM, John Ferlan wrote: > > > > On 06/28/2015 10:10 PM, Luyao Huang wrote: > >> If usr pass a vcpu which exceed guest maxvcpu number, virsh client > >> will only output an header like this: > >> > >> # virsh vcpupin t

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-02 Thread Michal Privoznik
On 01.07.2015 16:03, John Ferlan wrote: > I'm picking a random Coverity thread to express my latest thoughts on this. I'm not trying to say the problems I'm raising are necessarily introduced here in this patch set. We've seen quite a lot of false positives lately. I'm not familiar with coverity,

[libvirt] [libvirt-test-api][PATCH] Introduce new test case for setMemoryStatsPeriod

2015-07-02 Thread Luyao Huang
Signed-off-by: Luyao Huang --- cases/linux_domain.conf | 6 +++ repos/domain/set_memory_period.py | 84 +++ 2 files changed, 90 insertions(+) create mode 100644 repos/domain/set_memory_period.py diff --git a/cases/linux_domain.conf b/cases/linux_do

Re: [libvirt] [PATCHv3] virt-aa-helper: Fix permissions for vhost-user socket files

2015-07-02 Thread Michal Privoznik
On 01.07.2015 10:15, Michal Dubiel wrote: > QEMU working in vhost-user mode communicates with the other end (i.e. > some virtual router application) via unix domain sockets. This requires > that permissions for the socket files are correctly written into > /etc/apparmor.d/libvirt/libvirt-UUID.files

[libvirt] [libvirt-test-API][PATCH 2/2] Add new case to test storagePoolLookupByVolume

2015-07-02 Thread jiahu
Added a new case to validate storagePoolLookupByVolume api --- repos/storage/pool_lookup_by_volume.py | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 repos/storage/pool_lookup_by_volume.py diff --git a/repos/storage/pool_lookup_by_volume.py b/repos/s

[libvirt] [libvirt-test-API][PATCH 0/2] Add a new case for storagePoolLookupByVolume API

2015-07-02 Thread jiahu
This API will be tested in dir/logicl/netfs pool type. jiahu (2): Add pool_lookup_by_volume.py to conf Add new case to test storagePoolLookupByVolume cases/storage_dir.conf | 6 + cases/storage_logical.conf | 6 + cases/storage_netfs.conf |

[libvirt] [libvirt-test-API][PATCH 1/2] Add pool_lookup_by_volume.py to conf

2015-07-02 Thread jiahu
--- cases/storage_dir.conf | 6 ++ cases/storage_logical.conf | 6 ++ cases/storage_netfs.conf | 6 ++ 3 files changed, 18 insertions(+) diff --git a/cases/storage_dir.conf b/cases/storage_dir.conf index 38b349d..97e8676 100644 --- a/cases/storage_dir.conf +++ b/cases/storage_di

Re: [libvirt] [PATCH v2 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-07-02 Thread Peter Krempa
On Thu, Jul 02, 2015 at 10:20:43 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH v2 17.5/20] cpu_map.xml: Expand Broadwell-noTSX CPU model

2015-07-02 Thread Peter Krempa
On Thu, Jul 02, 2015 at 10:21:09 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

[libvirt] [PATCH] virsh: Teach cmdFreepages to work with lxc driver

2015-07-02 Thread Michal Privoznik
Some drivers don't expose available huge page sizes in the capabilities XML. For instance, LXC driver is one of those. This has a downside that when virsh is trying to get aggregated info on free pages per all NUMA nodes, it fails. The problem is that the virNodeGetFreePages() API expects caller to

Re: [libvirt] How to define QEMU/SMBIOS Attributes in virsh

2015-07-02 Thread Daniel P. Berrange
On Wed, Jul 01, 2015 at 08:49:00PM +0200, Holger Schranz wrote: > Hi Daniel, > > thanks a lot for this information. > I think thepassthrough is usable as a work around meanwhile. > How do I write a bug report (via the HP of libvirt)? This page has details of how/where to report bugs: http://l

[libvirt] [PATCH v2 17.5/20] cpu_map.xml: Expand Broadwell-noTSX CPU model

2015-07-02 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch src/cpu/cpu_map.xml | 54

[libvirt] [PATCH v2 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-07-02 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark --- Notes: Version 2: - expand all instances of Haswell-noTSX s

Re: [libvirt] [PATCH 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-07-02 Thread Jiri Denemark
On Thu, Jul 02, 2015 at 09:31:19 +0200, Peter Krempa wrote: > On Thu, Jul 02, 2015 at 09:26:11 +0200, Peter Krempa wrote: > > On Fri, Jun 26, 2015 at 15:17:16 +0200, Jiri Denemark wrote: > > > Inheritance among CPU model is cool but it makes reviewing CPU model > > > definitions and comparing them

Re: [libvirt] [PATCH v3 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-07-02 Thread Prerna Saxena
On Tuesday 30 June 2015 06:20 PM, Ján Tomko wrote: > On Fri, Jun 26, 2015 at 05:05:11PM +0530, Prerna Saxena wrote: >> Libvirt periodically refreshes all volumes in a storage pool, including >> the volumes being cloned. >> While cloning a storage volume from parent, we drop pool locks. Subsequent

Re: [libvirt] [PATCH 00/20] cpu_map.xml: Make CPU definitions easier to review

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:16:59 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch with a sorted list > of features. Addi

Re: [libvirt] [PATCH 20/20] cpu_map.xml: Expand Opteron_G4 CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:19 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 19/20] cpu_map.xml: Expand Opteron_G2 CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:18 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 18/20] cpu_map.xml: Expand Opteron_G1 CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:17 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-07-02 Thread Peter Krempa
On Thu, Jul 02, 2015 at 09:26:11 +0200, Peter Krempa wrote: > On Fri, Jun 26, 2015 at 15:17:16 +0200, Jiri Denemark wrote: > > Inheritance among CPU model is cool but it makes reviewing CPU model > > definitions and comparing them to CPU models from QEMU rather hard and > > unpleasant. Let's define

Re: [libvirt] [PATCH 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:16 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 16/20] cpu_map.xml: Expand SandyBridge CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:15 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 15/20] cpu_map.xml: Expand Westmere CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:14 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 14/20] cpu_map.xml: Expand Nehalem CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:13 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 13/20] cpu_map.xml: Expand Penryn CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:12 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -

Re: [libvirt] [PATCH 12/20] cpu_map.xml: Expand Conroe CPU model

2015-07-02 Thread Peter Krempa
On Fri, Jun 26, 2015 at 15:17:11 +0200, Jiri Denemark wrote: > Inheritance among CPU model is cool but it makes reviewing CPU model > definitions and comparing them to CPU models from QEMU rather hard and > unpleasant. Let's define all CPU models from scratch. > > Signed-off-by: Jiri Denemark > -