[libvirt] [glib v2 1/2] Don't overwrite filesystem type when writing format

2015-07-07 Thread Cédric Bosdonnat
When setting filesystem driver format first and type, only the type remained and vice-versa. --- libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 4 ++-- tests/test-gconfig.c | 2 +- tests/xml/gconfig-domain-device-filesys.xml | 2 +- 3 files changed, 4 insertion

[libvirt] [glib v2 0/2] misc gconfig fixes

2015-07-07 Thread Cédric Bosdonnat
Hi all, Here is a version fixing two bugs I introduced. Diff to v1: * takes into account teuf's comments. Cédric Bosdonnat (2): Don't overwrite filesystem type when writing format Dsitribute the whole tests/xml folder libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 4 ++-- tests/Make

[libvirt] [glib v2 2/2] Dsitribute the whole tests/xml folder

2015-07-07 Thread Cédric Bosdonnat
--- tests/Makefile.am | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 63865e8..7189d6f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -17,18 +17,6 @@ LDADD = \ test_programs = test-gconfig test-events EXT

[libvirt] [PATCH 9/9] nodeinfo: fix to parse present cpus rather than possible cpus

2015-07-07 Thread John Ferlan
From: Kothapally Madhu Pavan This patch resolves a situation where a core is defective and is not in the present mask during boot. Optionally a host can have empty sockets could be brought online if the socket is added. In this case the present mask contains the cpu's that are actually there in t

[libvirt] [PATCH 4/9] nodeinfo: Add sysfs_prefix to nodeGetCPUBitmap

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/nodeinfo.c | 24 src/nodeinfo.h | 2 +- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/no

[libvirt] [PATCH 8/9] nodeinfo: Add sysfs_prefix to nodeGetMemoryStats

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/bhyve/bhyve_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/nodeinfo.c | 6 -- src/nodeinfo.h | 3

[libvirt] [PATCH 3/9] nodeinfo: Add sysfs_prefix to nodeGetPresentCPUBitmap

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/nodeinfo.c | 7 --- src/nodeinfo.h | 2 +- src/util/vircgroup.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-)

[libvirt] [PATCH 7/9] nodeinfo: Add sysfs_prefix to nodeCapsInitNUMA

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_CPU_PATH which is a derivative of SYSFS_SYSTEM_PATH Use cpupath for nodeCapsInitNUMAFake and remove SYSFS_CPU_PATH Signed-off-by: John Ferlan --- src/lxc/lxc_conf.c | 2 +-

[libvirt] [PATCH 5/9] nodeinfo: Add sysfs_prefix to nodeGetCPUMap

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/bhyve/bhyve_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/nodeinfo.c | 8 +--- src/nodeinfo.h |

[libvirt] [PATCH 6/9] nodeinfo: Add sysfs_prefix to nodeGetInfo

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/bhyve/bhyve_capabilities.c | 2 +- src/bhyve/bhyve_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/nodeinfo.c

[libvirt] [PATCH 0/9] Add sysfs_prefix to nodeinfo.c API's

2015-07-07 Thread John Ferlan
This series adds/processes a sysfs_prefix for the nodeinfo.c API's. Although the nodeinfotest.c passes a local test directory path, it was never used. This was all brought to light by patch 9 in this series which is essentially Kothapally Madhu Pavan's v3 patch: http://www.redhat.com/archives/l

[libvirt] [PATCH 2/9] nodeinfo: Add sysfs_prefix to nodeGetCPUCount

2015-07-07 Thread John Ferlan
Add the sysfs_prefix argument to the call to allow for setting the path for tests to something other than SYSFS_SYSTEM_PATH. Signed-off-by: John Ferlan --- src/lxc/lxc_controller.c | 2 +- src/nodeinfo.c | 20 +--- src/nodeinfo.h | 2 +- src/qemu/qemu_driver

[libvirt] [PATCH 1/9] nodeinfo: Introduce local linuxGetCPUPresentPath

2015-07-07 Thread John Ferlan
The API will print the path to the /cpu/present file using the sysfs_prefix. NB: This is setup for future patches which will allow local/test sysfs paths. Signed-off-by: John Ferlan --- src/nodeinfo.c | 43 ++- 1 file changed, 34 insertions(+), 9 deletions

[libvirt] [PATCH] libxl: rework setting the state of virDomainObj

2015-07-07 Thread Jim Fehlig
Set the state of virDomainObj in the functions that actually change the domain state, instead of the generic libxlDomainCleanup function. This approach gives functions calling libxlDomainCleanup more flexibility wrt when and how they change virDomainObj state via virDomainObjSetState. The prior ap

Re: [libvirt] [java] [PATCH 0/6] Fix JNA wrapping, fix memory leaks and wrap security model / label function

2015-07-07 Thread Claudio Bley
Hi. At Wed, 28 Jan 2015 21:45:41 +0100, Claudio Bley wrote: > > Hi. > > First and foremost, this series fixes a few mistakes in the wrapping > code found by inspecting the org.libvirt.jna.Libvirt interface and the > corresponding C types of the XML API file. > > The last two patches add two mis

Re: [libvirt] [glib] Don't overwrite filesystem type when writing format

2015-07-07 Thread Christophe Fergeau
On Tue, Jul 07, 2015 at 06:24:38PM +0200, Cedric Bosdonnat wrote: > On Tue, 2015-07-07 at 17:31 +0200, Christophe Fergeau wrote: > > This is unintuitive, but after looking at the code and a quick test, I > > think _add_child() will create the node if it does not exist, and > > return > > the existi

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-07 Thread Zeeshan Ali (Khattak)
Hi all, Christophe pointed out that this and the previous patch binds API that was added an year ago: commit: 03e0e79e07622496522609741734c2fdcacb5bf2 Author: Nehal J Wani Date: Tue Jun 24 02:31:49 2014 +0530 net-dhcp-leases: Implement the public APIs Introduce 3 new APIs, virNetwor

Re: [libvirt] [PATCH] conf: Don't allow duplicated targets regardless of bus

2015-07-07 Thread John Ferlan
ping^2 Tks, John On 06/18/2015 04:12 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1142631 > > Commit id 'e0e290552' added a check to determine if the same bus > had the same target value. It seems that's not quite good enough > as the check should check the target name

Re: [libvirt] [glib] Don't overwrite filesystem type when writing format

2015-07-07 Thread Cedric Bosdonnat
On Tue, 2015-07-07 at 17:31 +0200, Christophe Fergeau wrote: > This is unintuitive, but after looking at the code and a quick test, I > think _add_child() will create the node if it does not exist, and > return > the existing node if it already exists. So I think this could become: > > +no

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-07 Thread Zeeshan Ali (Khattak)
On Tue, Jul 7, 2015 at 3:17 PM, Zeeshan Ali (Khattak) wrote: > --- > libvirt-gobject/libvirt-gobject-network.c | 55 > +++ > libvirt-gobject/libvirt-gobject-network.h | 4 +++ > libvirt-gobject/libvirt-gobject.sym | 2 ++ > 3 files changed, 61 insertions(+) >

[libvirt] [PATCH 3/3] qemu: Test for virtio-9p-ccw support

2015-07-07 Thread Boris Fiuczynski
This patch adds a test for the qemu command line generation. Signed-off-by: Boris Fiuczynski Reviewed-by: Jason J. Herne Reviewed-by: Stefan Zimmermann --- tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 16 ++ tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.xml | 36

[libvirt] [PATCH 0/3] qemu: virtio-9p-ccw support

2015-07-07 Thread Boris Fiuczynski
Adding support and a test for virtio-9p-ccw. Changing the default from virtio-9p-pci to virtio-9p-ccw for s390-ccw-virtio machines. Boris Fiuczynski (3): qemu: Support for virtio-9p-ccw qemu: Make virtio-9p-ccw the default for s390-ccw-virtio machines qemu: Test for virtio-9p-ccw support s

[libvirt] [PATCH 2/3] qemu: Make virtio-9p-ccw the default for s390-ccw-virtio machines

2015-07-07 Thread Boris Fiuczynski
For s390-ccw-virtio machines the default bus type is set to ccw. Specifing an address element allows to override the default. Signed-off-by: Boris Fiuczynski Reviewed-by: Jason J. Herne Reviewed-by: Stefan Zimmermann --- src/qemu/qemu_command.c | 8 1 file changed, 8 insertions(+) di

Re: [libvirt] [glib] Add filesys xml file to distribution

2015-07-07 Thread Christophe Fergeau
On Tue, Jul 07, 2015 at 04:49:16PM +0200, Cédric Bosdonnat wrote: > Tests can't succeed from the distribution tarball: the new > gconfig-domain-device-filesys.xml file wasn't included. > > --- > tests/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/Makefile.am b/tests

Re: [libvirt] [glib] Don't overwrite filesystem type when writing format

2015-07-07 Thread Christophe Fergeau
Hey, On Tue, Jul 07, 2015 at 04:26:02PM +0200, Cédric Bosdonnat wrote: > When setting filesystem driver format first and type, only the type > remained and vice-versa. > --- > libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 8 ++-- > tests/test-gconfig.c | 2 +-

[libvirt] [PATCH 1/3] qemu: Support for virtio-9p-ccw

2015-07-07 Thread Boris Fiuczynski
Adding the recently in qemu added 9pfs support for virtio-ccw. Signed-off-by: Boris Fiuczynski Reviewed-by: Jason J. Herne Reviewed-by: Stefan Zimmermann --- src/qemu/qemu_command.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu

Re: [libvirt] [PATCH v2 00/10] Restore code to allow unpriv_sgio for hostdev SCSI generic

2015-07-07 Thread John Ferlan
On 07/07/2015 08:19 AM, Peter Krempa wrote: > On Mon, Jul 06, 2015 at 13:08:28 -0400, John Ferlan wrote: >> v1 here: >> http://www.redhat.com/archives/libvir-list/2015-June/msg00814.html >> >> Changes since v1: >> - Add doc patch 1 to indicate that this feature may only be supported by >> certa

[libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-07 Thread Zeeshan Ali (Khattak)
--- libvirt-gobject/libvirt-gobject-network.c | 55 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 61 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-network.c b/libvirt-gobject/li

Re: [libvirt] [PATCH v2 1/1] vz: assign static IPs and default gateways for network adapter

2015-07-07 Thread Dmitry Guryanov
On 07/07/2015 04:38 PM, Mikhail Feoktistov wrote: We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates network

[libvirt] [glib] Add filesys xml file to distribution

2015-07-07 Thread Cédric Bosdonnat
Tests can't succeed from the distribution tarball: the new gconfig-domain-device-filesys.xml file wasn't included. --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 63865e8..c8bb4c7 100644 --- a/tests/Makefile.am +++ b/tests/Mak

Re: [libvirt] [libvirt-glib PATCHv5 1/7] gobject: Simplify gvir_connection_list*() implementations

2015-07-07 Thread Christophe Fergeau
Hey, A 'changes since v4' section would have been nice ACK series. Christophe On Tue, Jul 07, 2015 at 03:17:31PM +0100, Zeeshan Ali (Khattak) wrote: > Make use of virConnectListAll* functions to avoid making 4 calls and > hence avoid race conditions and complicated code. > --- > libvirt-gobjec

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-07 Thread Christophe Fergeau
On Tue, Jul 07, 2015 at 03:17:37PM +0100, Zeeshan Ali (Khattak) wrote: > --- > libvirt-gobject/libvirt-gobject-network.c | 55 > +++ > libvirt-gobject/libvirt-gobject-network.h | 4 +++ > libvirt-gobject/libvirt-gobject.sym | 2 ++ > 3 files changed, 61 inserti

[libvirt] [glib] Don't overwrite filesystem type when writing format

2015-07-07 Thread Cédric Bosdonnat
When setting filesystem driver format first and type, only the type remained and vice-versa. --- libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 8 ++-- tests/test-gconfig.c | 2 +- tests/xml/gconfig-domain-device-filesys.xml | 2 +- 3 files changed, 8 inser

[libvirt] [libvirt-glib PATCHv5 6/7] gobject: Add wrapper for virNetworkDHCPLease

2015-07-07 Thread Zeeshan Ali (Khattak)
--- libvirt-gobject/Makefile.am| 5 +- .../libvirt-gobject-network-dhcp-lease-private.h | 34 +++ .../libvirt-gobject-network-dhcp-lease.c | 252 + .../libvirt-gobject-network-dhcp-lease.h | 85 +++ libvirt-gobject/libvirt-g

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Pavel Fedin
Hello! > Could you split that hunk into another patch and also fix it in > lxc_monitor_protocol-structs so that make syntax-check doesn't bother > us? No problem, i will do it. If i have further questions, i'll ask them tomorrow because i'm in 40 minutes apart from leaving the office today. K

[libvirt] [libvirt-glib PATCHv5 1/7] gobject: Simplify gvir_connection_list*() implementations

2015-07-07 Thread Zeeshan Ali (Khattak)
Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. --- libvirt-gobject/libvirt-gobject-connection.c | 203 --- 1 file changed, 28 insertions(+), 175 deletions(-) diff --git a/libvirt-gobject/libvirt-gobjec

[libvirt] [libvirt-glib PATCHv5 3/7] gobject: Port GVirConnection to GTask

2015-07-07 Thread Zeeshan Ali (Khattak)
GSimpleAsyncResult has been deprecated in favour of GTask and with latest glib headers, we get tons of warnings about use of deprecated API. This patch ports the GVirConnection class to GTask. --- libvirt-gobject/libvirt-gobject-connection.c | 280 +-- 1 file changed, 136 i

[libvirt] [libvirt-glib PATCHv5 4/7] gobject: Add API to query connection interfaces

2015-07-07 Thread Zeeshan Ali (Khattak)
Add API to query network interfaces from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 270 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 7 + 3 files changed, 288 insertions(+), 2 deletions(-)

[libvirt] [libvirt-glib PATCHv5 2/7] gobject: Plug 2 virConnect leaks

2015-07-07 Thread Zeeshan Ali (Khattak)
A virConnect reference is leaked in error cases. This patch moves the unref after the label we jump to on errors, to avoid this leak. --- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connectio

[libvirt] [libvirt-glib PATCHv5 5/7] gobject: Add API to query connection networks

2015-07-07 Thread Zeeshan Ali (Khattak)
Add API to query networks from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 262 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 6 + 3 files changed, 279 insertions(+), 2 deletions(-) diff --g

Re: [libvirt] [PATCH] vz: assign static IPs and default gateways for network adapter

2015-07-07 Thread Mikhail Feoktistov
send v2 06.07.2015 21:28, Dmitry Guryanov пишет: On 07/01/2015 01:15 PM, Mikhail Feoktistov wrote: We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settin

[libvirt] [PATCH v2 1/1] vz: assign static IPs and default gateways for network adapter

2015-07-07 Thread Mikhail Feoktistov
We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates network startup scripts /etc/sysconfig/network-scripts/ifcf

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Martin Kletzander
On Tue, Jul 07, 2015 at 03:04:51PM +0300, Pavel Fedin wrote: Hello! I don't think we should use enums at all in the protocol specification. It should be unsigned int and the change should be made separately. Is this hunk here because portable-rpcgen has problems with enum being declared there

[libvirt] [PATCH v2 0/1] vz: assign static IPs and default gateways for network adapter

2015-07-07 Thread Mikhail Feoktistov
fix "avoid_if_before_free" warnings for VIR_FREE calls fix "found diagnostic without %" warnings for virReportError calls use virAsprintf instead of virBufferAsprintf set default gateway only if static ip is present write inet family to log in case of unsupported gateway Mikhail Feoktistov (1):

Re: [libvirt] [PATCH v2 08/10] qemu: Fix integer/boolean logic in qemuSetUnprivSGIO

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 13:08:36 -0400, John Ferlan wrote: > Setting of 'val' is a boolean expression, so handle it that way and > adjust the check/return logic to be clearer > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_conf.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletio

Re: [libvirt] [PATCH v2 07/10] qemu: Refactor qemuSetUnprivSGIO return values

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 13:08:35 -0400, John Ferlan wrote: > Set to ret = -1 and prove otherwise, like usual > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_conf.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_

Re: [libvirt] [PATCH v4 1/2] Fix nodeinfo output on PPC64 KVM hosts

2015-07-07 Thread Martin Kletzander
On Tue, Jul 07, 2015 at 09:25:59AM +0200, Andrea Bolognani wrote: From: Shivaprasad G Bhat The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries off

Re: [libvirt] [PATCH v2 02/10] qemu: Introduce qemuIsSharedHostdev

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 13:08:30 -0400, John Ferlan wrote: > Add a single boolean function to handle whether the hostdev is shared or not. > > Use the new function for the qemu{Add|Remove}SharedHostdev calls as well > as qemuSetUnprivSGIO. NB: This second usage fixes a possible bug where s/second

Re: [libvirt] [PATCH v2 00/10] Restore code to allow unpriv_sgio for hostdev SCSI generic

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 13:08:28 -0400, John Ferlan wrote: > v1 here: > http://www.redhat.com/archives/libvir-list/2015-June/msg00814.html > > Changes since v1: > - Add doc patch 1 to indicate that this feature may only be supported by > certain kernels > - Adjust former patch 1 to add call to q

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Pavel Fedin
Hello! > I don't think we should use enums at all in the protocol > specification. It should be unsigned int and the change should be > made separately. Is this hunk here because portable-rpcgen has > problems with enum being declared there? Yes, its parser fails. I have checked throughout t

Re: [libvirt] [libvirt-glib PATCHv4 4/7] gobject: Add API to query connection interfaces

2015-07-07 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:48PM +0100, Zeeshan Ali (Khattak) wrote: > Add API to query network interfaces from a connection. > --- > libvirt-gobject/libvirt-gobject-connection.c | 265 > +++ > libvirt-gobject/libvirt-gobject-connection.h | 13 +- > libvirt-gobject/libv

Re: [libvirt] [PATCH v3] qemu: Use heads parameter for QXL driver

2015-07-07 Thread Martin Kletzander
On Mon, Jul 06, 2015 at 09:18:59AM +0100, Frediano Ziglio wrote: Allows to specify maximum number of head to QXL driver. The patch to support the "max_outputs" in Qemu is still not merged but I got agreement on the name of the argument. This shouldn't be part of the commit message, we can't p

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Martin Kletzander
On Mon, Jul 06, 2015 at 10:40:28AM +0300, Pavel Fedin wrote: This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin --- configure.ac

[libvirt] [PATCH v2 1/4] virt-aa-helper: fix rules for paths with trailing slash

2015-07-07 Thread Cédric Bosdonnat
Rules generated for a path like '/' were having '//' which isn't correct for apparmor. Make virt-aa-helper smarter to avoid these. --- src/security/virt-aa-helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 13f8a6a..9

[libvirt] [PATCH v2 4/4] virt-aa-helper: add DomainGuest to mockup caps

2015-07-07 Thread Cédric Bosdonnat
With commit 3f9868a virt-aa-helper stopped working due to missing DomainGuest in the caps. The test with -c without arch also needs to be removed since the new capabilities code uses the host arch when none is provided. --- src/security/virt-aa-helper.c | 25 - tests/virt-

[libvirt] [PATCH v2 0/4] virt-aa-helper fixes

2015-07-07 Thread Cédric Bosdonnat
This patch series includes a new version for the trailing slash fix, but also includes other fixes to get virt-sandbox run nicely with apparmor. Thus only one patch has v2 ;) Cédric Bosdonnat (4): virt-aa-helper: fix rules for paths with trailing slash Get more libvirt errors from virt-aa-help

[libvirt] [PATCH v2 2/4] Get more libvirt errors from virt-aa-helper

2015-07-07 Thread Cédric Bosdonnat
Initializing libvirt log in virt-aa-helper and getting it to output libvirt log to stderr. This will help debugging problems happening in libvirt functions called from within virt-aa-helper --- src/security/security_apparmor.c | 4 src/security/virt-aa-helper.c| 4 2 files changed, 8

[libvirt] [PATCH v2 3/4] virt-aa-helper: rename ctl->hvm to ctl->os

2015-07-07 Thread Cédric Bosdonnat
ctl->hvm contains os.type string value, change the name to reflect it. --- src/security/virt-aa-helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 3d57431..f94f337 100644 --- a/src/security/v

Re: [libvirt] [PATCH v3 1/3] Introduce QEMU_CAPS_ARM_VIRT_PCI

2015-07-07 Thread Pavel Fedin
Hello! > Is there a way how we could detect this according to the actual presence > of the PCI bus for the ARM machine? A certain device type that can be > queried rather than relying on a version check. I looked at the code you suggested. As far as i could understand, it actually parses an ou

Re: [libvirt] [libvirt-glib PATCHv4 1/7] gobject: Simplify gvir_connection_list*() implementations

2015-07-07 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:45PM +0100, Zeeshan Ali (Khattak) wrote: > @@ -901,77 +801,31 @@ gboolean > gvir_connection_fetch_storage_pools(GVirConnection *conn, > if (g_cancellable_set_error_if_cancelled(cancellable, err)) > goto cleanup; > > -active = fetch_list(vconn, > -

Re: [libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME

2015-07-07 Thread Dmitry Guryanov
On 07/07/2015 04:49 AM, Maxim Nestratov wrote: It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov There is a typo in libvirt list name, but as

Re: [libvirt] [libvirt-glib PATCHv4 5/7] gobject: Add API to query connection networks

2015-07-07 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:49PM +0100, Zeeshan Ali (Khattak) wrote: > Add API to query networks from a connection. > --- > libvirt-gobject/libvirt-gobject-connection.c | 257 > +++ > libvirt-gobject/libvirt-gobject-connection.h | 13 +- > libvirt-gobject/libvirt-gobjec

Re: [libvirt] [libvirt-glib PATCHv4 3/7] gobject: Port GVirConnection to GTask

2015-07-07 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:47PM +0100, Zeeshan Ali (Khattak) wrote: > GSimpleAsyncResult has been deprecated in favour of GTask and with > latest glib headers, we get tons of warnings about use of deprecated > API. This patch ports the GVirConnection class to GTask. > --- > libvirt-gobject/libv

Re: [libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

2015-07-07 Thread Pavel Fedin
Hello! > Is there a way where we would make this configurable? Since the "virt" > machine types use the MMIO bus by default we should make the PCI bus > configurable since not everybody might want to add it actually. What exactly do you mean? In qemu this is not configurable, it's just there.

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-07 Thread Ren, Qiaowei
On Jul 6, 2015 14:49, Prerna wrote: > On Sun, Jul 5, 2015 at 5:13 PM, Qiaowei Ren > wrote: > > > One RFC in > https://www.redhat.com/archives/libvir-list/2015-June/msg01509.html > > CMT (Cache Monitoring Technology) can be used to measure the

Re: [libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 15:59:26 +0300, Pavel Fedin wrote: > Add PCI Express root complex if the corresponding capability is present > > Signed-off-by: Pavel Fedin > --- > src/qemu/qemu_domain.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_

Re: [libvirt] [PATCH v3 1/3] Introduce QEMU_CAPS_ARM_VIRT_PCI

2015-07-07 Thread Peter Krempa
On Mon, Jul 06, 2015 at 15:59:25 +0300, Pavel Fedin wrote: > This capability specifies that "virt" machine on ARM has PCI controller. > Enabled when qemu version is at least 2.3.0. > > Signed-off-by: Pavel Fedin > --- > src/qemu/qemu_capabilities.c | 5 + > src/qemu/qemu_capabilities.h | 1 +

Re: [libvirt] [PATCH v3 1/2] Fix nodeinfo output on PPC64 KVM hosts

2015-07-07 Thread Andrea Bolognani
On Mon, 2015-07-06 at 17:34 +0530, Shivaprasad bhat wrote: > > Thanks a lot Andrea. The cleanups are really nice. I had a chance to > test the patch and it > seems to work consistently in all sucores_per_core modes. > > Only two comments written inline . Glad you're happy with the changes! > >

[libvirt] [PATCH v4 0/2] Fix nodeinfo output on PPC64 KVM hosts

2015-07-07 Thread Andrea Bolognani
Changes from v3 to v4: * removed a printf() statement; * fixed typo in a commit message. Shivaprasad G Bhat (2): Fix nodeinfo output on PPC64 KVM hosts Add testcase for PPC64 kvm host nodeinfo src/libvirt_private.syms | 1 + src/nodeinfo.c

[libvirt] [PATCH v4 1/2] Fix nodeinfo output on PPC64 KVM hosts

2015-07-07 Thread Andrea Bolognani
From: Shivaprasad G Bhat The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the s