Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl-segmentation NIC capabilities

2015-07-20 Thread Moshe Levi
> -Original Message- > From: John Ferlan [mailto:jfer...@redhat.com] > Sent: Tuesday, July 21, 2015 1:06 AM > To: Moshe Levi; libvir-list@redhat.com > Subject: Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl- > segmentation NIC capabilities > > > > On 07/19/2015 06:11 AM, Mosh

Re: [libvirt] [PATCH 03/13] virsh: blockjob: Split out vshBlockJobSetSpeed from blockJobImpl

2015-07-20 Thread Peter Krempa
On Mon, Jul 20, 2015 at 16:47:38 -0400, John Ferlan wrote: > > > On 07/15/2015 12:33 PM, Peter Krempa wrote: > > --- > > tools/virsh-domain.c | 33 - > > 1 file changed, 24 insertions(+), 9 deletions(-) > > > > diff --git a/tools/virsh-domain.c b/tools/virsh-doma

Re: [libvirt] [PATCHv2 02/17] conf: pay attention to bus minSlot/maxSlot when autoassigning PCI addresses

2015-07-20 Thread Laine Stump
BTW, in case anyone is hesitant to ACK this patch due to concern of regressions - aside from my working through it by hand, there are multiple tests (including for example "pci-bridge-many-disks") which will fail if the exact same bus/slot is not assigned for many devices, so I am certain that the

Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl-segmentation NIC capabilities

2015-07-20 Thread John Ferlan
On 07/19/2015 06:11 AM, Moshe Levi wrote: > Adding functionality to libvirt that will allow > it query the interface for the availability of RDMA and > tx-udp_tnl-segmentation Offloading NIC capabilities > > Here is an example of the feature XML definition: > > > net_eth4_90_e2_ba_5e_a5_45 >

Re: [libvirt] [PATCH 00/13] Improve virsh block job handling

2015-07-20 Thread Eric Blake
On 07/20/2015 02:48 PM, John Ferlan wrote: > > > On 07/15/2015 12:33 PM, Peter Krempa wrote: >> This series refactors the block job command code so that it is handled by >> separate functions rather than one mega-method. Additionally this series then >> fixes the routine for waiting for a block j

Re: [libvirt] [PATCH 11/13] virsh: Refactor block job waiting in cmdBlockPull

2015-07-20 Thread Eric Blake
On 07/15/2015 10:34 AM, Peter Krempa wrote: > Introduce helper function that will provide logic for waiting for block > job completion so the 3 open coded places can be unified and improved. > > This patch introduces the whole logic and uses it to fix > cmdBlockJobPull. The vshBlockJobWait funtion

Re: [libvirt] [PATCH 10/13] qemu: Update state of block job to READY only if it actually is ready

2015-07-20 Thread Eric Blake
On 07/15/2015 10:33 AM, Peter Krempa wrote: > Few parts of the code looked at the current progress of and assumed that > a two phase blockjob is in the _READY state as soon as the progress > reached 100% (info.cur == info.end). In current versions of qemu this > assumption is invalid and qemu expos

Re: [libvirt] [PATCH 02/13] virsh: cmdBlockJob: Switch to declarative flag interlocking

2015-07-20 Thread Eric Blake
On 07/15/2015 10:33 AM, Peter Krempa wrote: > Use the VSH_EXCLUSIVE_OPTIONS_VAR to interlock incompatible options > --- > tools/virsh-domain.c | 33 +++-- > 1 file changed, 19 insertions(+), 14 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >

Re: [libvirt] [PATCH 01/13] virsh: blockjob: Extract block job info code into a separate function

2015-07-20 Thread Eric Blake
On 07/15/2015 10:33 AM, Peter Krempa wrote: > cmdBlockJob will be converted to a hub that will call into the > individual executor functions. > --- > tools/virsh-domain.c | 91 > +++- > 1 file changed, 55 insertions(+), 36 deletions(-) ACK. It wil

Re: [libvirt] [PATCH 11/13] virsh: Refactor block job waiting in cmdBlockPull

2015-07-20 Thread John Ferlan
On 07/15/2015 12:34 PM, Peter Krempa wrote: > Introduce helper function that will provide logic for waiting for block > job completion so the 3 open coded places can be unified and improved. > > This patch introduces the whole logic and uses it to fix > cmdBlockJobPull. The vshBlockJobWait funti

Re: [libvirt] [PATCH 03/13] virsh: blockjob: Split out vshBlockJobSetSpeed from blockJobImpl

2015-07-20 Thread John Ferlan
On 07/15/2015 12:33 PM, Peter Krempa wrote: > --- > tools/virsh-domain.c | 33 - > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 24f53ea..e3f7220 100644 > --- a/tools/virsh-domain.c > +++ b/t

Re: [libvirt] [PATCH 00/13] Improve virsh block job handling

2015-07-20 Thread John Ferlan
On 07/15/2015 12:33 PM, Peter Krempa wrote: > This series refactors the block job command code so that it is handled by > separate functions rather than one mega-method. Additionally this series then > fixes the routine for waiting for a block job. > > As it's perhaps obvious from the patches th

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-20 Thread Christophe Fergeau
On Mon, Jul 20, 2015 at 05:24:30PM +0100, Zeeshan Ali (Khattak) wrote: > And all that data is completely irrelevant for the reason I mentioned > again and again. Now that we have the data, and that it goes your way, yes you can say it's irrelevant ;) What if instead, it turned out only f22 was shi

[libvirt] [PATCH v6 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-20 Thread Andrea Bolognani
From: Shivaprasad G Bhat The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the s

[libvirt] [PATCH v6 0/5] nodeinfo: Add support for subcores

2015-07-20 Thread Andrea Bolognani
Changes from v5 to v6: * updated to work on top of [PATCH v2 00/10] nodeinfo: Various cleanups I'm only sending patch 1/5 to the list, because all the other commits haven't changed since v5 and because this way there's no need to perform moderation due to the message size. For the same

[libvirt] [PATCH v2 09/10] nodeinfo: Use a bitmap to keep track of node CPUs

2015-07-20 Thread Andrea Bolognani
Keep track of what CPUs belong to the current node while walking through the sysfs node entry, so we don't need to do it a second time immediately afterwards. This also allows us to loop through all CPUs that are part of a node in guaranteed ascending order, which is something that is required for

[libvirt] [PATCH v2 06/10] nodeinfo: Rename nodeGetCPUBitmap() to nodeGetOnlineCPUBitmap()

2015-07-20 Thread Andrea Bolognani
The new name makes it clear that the returned bitmap contains the information about which CPUs are online, not eg. which CPUs are present. No behavioral change. --- src/libvirt_private.syms | 2 +- src/nodeinfo.c | 6 +++--- src/nodeinfo.h | 2 +- 3 files changed, 5 insertions

[libvirt] [PATCH v2 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-20 Thread Andrea Bolognani
Swap out all instances of cpu_set_t and replace them with virBitmap, which some of the code was already using anyway. The changes are pretty mechanical, with one notable exception: an assumption has been added on the max value we can run into while reading either socket_it or core_id. While this

[libvirt] [PATCH v2 04/10] nodeinfo: Add old kernel compatibility to nodeGetPresentCPUBitmap()

2015-07-20 Thread Andrea Bolognani
If the cpu/present file is not available, we assume that the kernel is too old to support non-consecutive CPU ids and return a bitmap with all the bits set to represent this fact. This assumption is already exploited in nodeGetCPUCount(). This means users of this API can expect the information to

[libvirt] [PATCH v2 00/10] nodeinfo: Various cleanups

2015-07-20 Thread Andrea Bolognani
This should take care of Peter's remarks, except the ones that I've addressed separately. Andrea Bolognani (10): nodeinfo: Introduce linuxGetCPUGlobalPath() nodeinfo: Introduce linuxGetCPUOnlinePath() nodeinfo: Rename linuxParseCPUmax() to linuxParseCPUCount() nodeinfo: Add old kernel comp

[libvirt] [PATCH v2 05/10] nodeinfo: Remove out parameter from nodeGetCPUBitmap()

2015-07-20 Thread Andrea Bolognani
Not all users of this API will need the size of the returned bitmap; those who do can simply call virBitmapSize() themselves. --- src/nodeinfo.c | 12 +--- src/nodeinfo.h | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index ceb517a..

[libvirt] [PATCH v2 02/10] nodeinfo: Introduce linuxGetCPUOnlinePath()

2015-07-20 Thread Andrea Bolognani
--- src/nodeinfo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index b09a4fd..5459cc6 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -976,6 +976,12 @@ linuxGetCPUPresentPath(const char *sysfs_prefix) return linuxGetCPUGlobalP

[libvirt] [PATCH v2 08/10] nodeinfo: Use nodeGetOnlineCPUBitmap() when parsing node

2015-07-20 Thread Andrea Bolognani
No need to look up the online status of each CPU separately when we can get all the information in one go. --- src/nodeinfo.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 7d0e6b0..c97dece 100644 --- a/src/nodeinfo.c +++

[libvirt] [PATCH v2 03/10] nodeinfo: Rename linuxParseCPUmax() to linuxParseCPUCount()

2015-07-20 Thread Andrea Bolognani
The original name was confusing because the function returns the number of CPUs, not the maximum CPU id. The comment above the function has been updated to reflect this. No behavioral changes. --- src/nodeinfo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/nodein

[libvirt] [PATCH v2 10/10] nodeinfo: Calculate present and online CPUs only once

2015-07-20 Thread Andrea Bolognani
Move the calls to the respective functions from virNodeParseNode(), which is executed once for every NUMA node, to linuxNodeInfoCPUPopulate(), which is executed just once per host. --- src/nodeinfo.c | 53 +++-- 1 file changed, 31 insertions(+), 22 d

[libvirt] [PATCH v2 01/10] nodeinfo: Introduce linuxGetCPUGlobalPath()

2015-07-20 Thread Andrea Bolognani
This is just a more generic version of linuxGetCPUPresentPath(), which is now implemented by calling the new function appropriately. --- src/nodeinfo.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 105d7ab..b09a4fd 100644 --

Re: [libvirt] [PATCH 09/10] nodeinfo: Use a bitmap to keep track of node CPUs

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:47 +0200, Peter Krempa wrote: > > > +/* Iterate over all CPUs in the node, in ascending order */ > > +for (cpu = 0; cpu < npresent_cpus; cpu++) { > > > > -if (!virBitmapIsBitSet(present_cpumap, cpu)) > > +/* Skip CPUs that are not part of the curr

Re: [libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:41 +0200, Peter Krempa wrote: > > > +/* Biggest value we can expect to be used as either socket id > > + * or core id. Bitmaps will need to be sized accordingly */ > > +const int ID_MAX = 4095; > > I think this should be a more global setting. We have quite a

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-20 Thread Zeeshan Ali (Khattak)
On Thu, Jul 16, 2015 at 10:11 AM, Christophe Fergeau wrote: > On Mon, Jul 13, 2015 at 02:45:21PM +0100, Zeeshan Ali (Khattak) wrote: >> On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau >> wrote: >> > Patches of yours broke the build, you have a strong opinion on the right >> > way >> > to fi

[libvirt] [PATCH] Load nbd module before running qemu-nbd

2015-07-20 Thread Cédric Bosdonnat
So far qemu-nbd is run even if the nbd kernel module isn't loaded. This leads to errors when the user starts his lxc container while libvirt could easily load the nbd module automatically. --- src/util/virfile.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) di

Re: [libvirt] [PATCH v2] network: add an option to make dns public

2015-07-20 Thread Cedric Bosdonnat
On Mon, 2015-07-20 at 16:25 +0200, Peter Krempa wrote: > On Mon, Jul 20, 2015 at 11:29:15 +0200, Cédric Bosdonnat wrote: > > In some use cases we don't want the virtual network's DNS to only > > listen to the vnet interface. Adding a publiclyAccessible attribute > > to the dns element in the config

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-20 Thread Olaf Hering
On Thu, Jul 16, Jim Fehlig wrote: > @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, > virObjectUnref(socks[i]); > } > VIR_FREE(socks); > +virObjectUnref(args); This is now below the 'error' label, so args has to be initialized. [ 149s] libxl/libxl_mig

Re: [libvirt] [PATCH] rpc: RH1026137: Fix slow volume download (virsh vol-download)

2015-07-20 Thread Ossi Herrala
> On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote: > > Sorry to miss this mail, it got buried somehow and I haven't got to it > until now since nobody pinged it. Sorry for the long wait then. > No worries and thank you for taking time to review my patch. See new patch attached as w

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 16:18 +0200, Peter Krempa wrote: > On Mon, Jul 20, 2015 at 16:07:42 +0200, Andrea Bolognani wrote: > > On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > > > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char > > > > *sysfs_prefix); > > > > -virBitmapPtr nodeGetC

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-20 Thread Daniel P. Berrange
On Mon, Jul 20, 2015 at 01:50:54PM +, Ren, Qiaowei wrote: > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, July 20, 2015 5:32 PM > > To: Ren, Qiaowei > > Cc: libvir-list@redhat.com > > Subject: Re: [libvirt] [PATCH 2/3] Qemu: add CMT

Re: [libvirt] [PATCH v2] network: add an option to make dns public

2015-07-20 Thread Peter Krempa
On Mon, Jul 20, 2015 at 11:29:15 +0200, Cédric Bosdonnat wrote: > In some use cases we don't want the virtual network's DNS to only > listen to the vnet interface. Adding a publiclyAccessible attribute > to the dns element in the configuration allows the DNS to listen to > all interfaces. Would yo

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Peter Krempa
On Mon, Jul 20, 2015 at 16:07:42 +0200, Andrea Bolognani wrote: > On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix); > > > -virBitmapPtr nodeGetCPUBitmap(const char *sysfs_prefix, int > > > *max_id); > > > +virBitmapPt

Re: [libvirt] [PATCH 10/10] nodeinfo: Calculate present and online CPUs only once

2015-07-20 Thread Peter Krempa
On Mon, Jul 20, 2015 at 15:59:02 +0200, Andrea Bolognani wrote: > Move the calls to the respective functions from virNodeParseNode(), > which is executed once for every NUMA node, to > linuxNodeInfoCPUPopulate(), which is executed just once per host. > --- > src/nodeinfo.c | 49 +++

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix); > > -virBitmapPtr nodeGetCPUBitmap(const char *sysfs_prefix, int > > *max_id); > > +virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix, > > +

Re: [libvirt] [PATCH 00/10] nodeinfo: Various cleanups

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:48 +0200, Peter Krempa wrote: > > > Andrea Bolognani (10): > > nodeinfo: Introduce linuxGetCPUGlobalPath() > > nodeinfo: Introduce linuxGetCPUOnlinePath() > > nodeinfo: Rename linuxParseCPUmax() to linuxParseCPUCount() > > nodeinfo: Add old kernel compatibility to

[libvirt] [PATCH 10/10] nodeinfo: Calculate present and online CPUs only once

2015-07-20 Thread Andrea Bolognani
Move the calls to the respective functions from virNodeParseNode(), which is executed once for every NUMA node, to linuxNodeInfoCPUPopulate(), which is executed just once per host. --- src/nodeinfo.c | 49 + 1 file changed, 29 insertions(+), 20 delet

Re: [libvirt] [PATCH 0/3] nodeinfo: Various fixes

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:12:47 +0200, Andrea Bolognani wrote: > This series fixes a bunch of issues currently affecting nodeinfo > and related tests. > > Andrea Bolognani (3): > tests: Restore links in deconfigured-cpus nodeinfo test > nodeinfo: Add nodeGetPresentCPUBitmap() to libvirt_priva

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-20 Thread Ren, Qiaowei
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, July 20, 2015 5:32 PM > To: Ren, Qiaowei > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 2/3] Qemu: add CMT support > > On Sun, Jul 05, 2015 at 07:43:43PM +0800, Qiaowei Ren wrote: >

Re: [libvirt] [PATCH] qemuProcessStart: Be tolerant to relabel errors for session mode

2015-07-20 Thread Daniel P. Berrange
On Wed, Jul 15, 2015 at 03:02:13PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1124841 > > When the daemon is running under unprivileged user, that is under > qemu:///session, there are plenty of operations we can't do. What > we can do is to go with best effort. O

[libvirt] [PATCH 1/4] cpu: Rename {powerpc, ppc} => ppc64 (filesystem)

2015-07-20 Thread Andrea Bolognani
The driver only supports VIR_ARCH_PPC64 and VIR_ARCH_PPC64LE. Just shuffling files around and updating the build system accordingly. No functional changes. --- po/POTFILES.in | 2 +- src/Makefile.am | 5 +- src/cpu/cpu.c| 2 +- src/cpu/cpu.h| 2 +

[libvirt] [PATCH 0/4] cpu: Rename {powerpc,ppc} => ppc64

2015-07-20 Thread Andrea Bolognani
The naming of files and symbols belonging to the ppc64 CPU driver was all over the place: this series brings inner-peace-inducing consistency to that corner of libvirt via a series of straightforward string replacements. More substantial changes coming next. Andrea Bolognani (4): cpu: Rename {p

Re: [libvirt] [PATCH 00/10] nodeinfo: Various cleanups

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:19 +0200, Andrea Bolognani wrote: > Note: this series is to be applied on top of the > > [PATCH 00/03] nodeinfo: Various fixes > > series I've posted at the same time. > > A bunch of improvements and cleanups that make the nodeinfo > code a bit nicer, more streaml

[libvirt] [PATCH 2/4] cpu: Rename {powerpc, ppc} => ppc64 (exported symbols)

2015-07-20 Thread Andrea Bolognani
Only the symbols exported by the driver have been updated; the driver implementation itself still uses the old names internally. No functional changes. --- src/cpu/cpu.c| 2 +- src/cpu/cpu.h| 2 +- src/cpu/cpu_ppc64.c | 18 +- src/cpu/cpu_ppc64.h

[libvirt] [PATCH 4/4] cpu: Indentation changes in the ppc64 driver

2015-07-20 Thread Andrea Bolognani
--- src/cpu/cpu_ppc64.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 7a48903..c3a51fb 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -340,7 +340,8 @@ ppc64LoadMap(void) } static virCPUDataPtr -ppc64M

[libvirt] [PATCH 3/4] cpu: Rename {powerpc, ppc} => ppc64 (internal symbols)

2015-07-20 Thread Andrea Bolognani
Update the names of the symbols used internally by the driver. No functional changes. --- src/cpu/cpu_ppc64.c | 250 ++-- 1 file changed, 125 insertions(+), 125 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index bec4bf8..7a48

Re: [libvirt] [PATCH 09/10] nodeinfo: Use a bitmap to keep track of node CPUs

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:28 +0200, Andrea Bolognani wrote: > Keep track of what CPUs belong to the current node while walking > through the sysfs node entry, so we don't need to do it a second > time immediately afterwards. > > This also allows us to loop through all CPUs that are part of a >

Re: [libvirt] [PATCH] qemuProcessStart: Be tolerant to relabel errors for session mode

2015-07-20 Thread John Ferlan
On 07/15/2015 09:02 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1124841 > > When the daemon is running under unprivileged user, that is under > qemu:///session, there are plenty of operations we can't do. What > we can do is to go with best effort. One of such cases

Re: [libvirt] [PATCH 08/10] nodeinfo: Use nodeGetOnlineCPUBitmap() when parsing node

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:27 +0200, Andrea Bolognani wrote: > No need to look up the online status of each CPU separately when we > can get all the information in one go. > --- > src/nodeinfo.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > ACK, Peter signature

Re: [libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:26 +0200, Andrea Bolognani wrote: > Swap out all instances of cpu_set_t and replace them with virBitmap, > which some of the code was already using anyway. > > The changes are pretty mechanical, with one notable exception: an > assumption has been added on the max val

Re: [libvirt] unsupported configuration: unknown video model 'virtio' - virtio-vga

2015-07-20 Thread Martin Kletzander
On Mon, Jul 20, 2015 at 11:23:02AM +0200, poma wrote: $ qemu-system-x86_64 ... -device virtio-vga # lspci -d 1af4:1050 -knn 00:03.0 VGA compatible controller [0300]: Red Hat, Inc Device [1af4:1050] (rev 01) Subsystem: Red Hat, Inc Device [1af4:1100] Kernel driver in use: virti

[libvirt] [PATCH] rpc: Remove keepalive_required option

2015-07-20 Thread Martin Kletzander
Since its introduction in 2011 (particularly in commit f4324e329275), the option doesn't work. It just effectively disables all incoming connections. That's because the client private data that contain the 'keepalive_supported' boolean, are initialized to zeroes so the bool is false and the only

Re: [libvirt] [PATCH 06/10] nodeinfo: Rename nodeGetCPUBitmap() to nodeGetOnlineCPUBitmap()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:25 +0200, Andrea Bolognani wrote: > The new name makes it clear that the returned bitmap contains the > information about which CPUs are online, not eg. which CPUs are > present. > > Change the name of the out parameter from max_id, which didn't > reflect the actual v

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:24 +0200, Andrea Bolognani wrote: > This aligns it with nodeGetCPUBitmap(), which already has a > similar out parameters, and relieves users of this API from the > need to call virBitmapSize() on the returned bitmap. > --- > src/nodeinfo.c | 8 ++-- > src/no

Re: [libvirt] [PATCH 04/10] nodeinfo: Add old kernel compatibility to nodeGetPresentCPUBitmap()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:23 +0200, Andrea Bolognani wrote: > If the cpu/present file is not available, we assume that the kernel > is too old to support non-consecutive CPU ids and return a bitmap > with all the bits set to represent this fact. This assumption is > already exploited in nodeGet

[libvirt] tc ingress rule of VM B disappear when reboot VM A

2015-07-20 Thread ychen
hi: when I use openstack devstack to test QOS, wired phenomenon appeared, I set qos ingress rule in tapB, but when I reboot tapA, the ingress rule of tapB automatically removed, but the egress rule is still exist. Test enviroment: Linux: ubuntu 14.04.1 LTS kernel: 3.13.0-32-generic libvirt: 1.2.2

Re: [libvirt] [PATCH] nodeinfo: fix build on FreeBSD

2015-07-20 Thread Roman Bogorodskiy
Martin Kletzander wrote: > On Fri, Jul 17, 2015 at 08:23:07PM +0300, Roman Bogorodskiy wrote: > >Currently, build fails on FreeBSD with: > > > > CC libvirt_driver_la-nodeinfo.lo > >nodeinfo.c:1941:56: error: use of undeclared identifier 'SYSFS_SYSTEM_PATH' > >const char *prefix = sysf

Re: [libvirt] [PATCH 02/10] nodeinfo: Introduce linuxGetCPUOnlinePath()

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 11:34 +0200, Peter Krempa wrote: > > > @@ -973,6 +973,9 @@ linuxGetCPUGlobalPath(const char *sysfs_prefix, > > # define linuxGetCPUPresentPath(sysfs_prefix)\ > > linuxGetCPUGlobalPath(sysfs_prefix, "present") > > > > +# define linuxGetCPUOnlinePath(sysfs_p

Re: [libvirt] [PATCH] qxl: Fix new function name for spice-server library

2015-07-20 Thread Martin Kletzander
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote: The new spice-server function to limit the number of monitors (0.12.6) changed while development from spice_qxl_set_monitors_config_limit to spice_qxl_max_monitors (accepted upstream). By mistake I post patch with former name. This

Re: [libvirt] [PATCH] nodeinfo: fix build on FreeBSD

2015-07-20 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 08:23:07PM +0300, Roman Bogorodskiy wrote: Currently, build fails on FreeBSD with: CC libvirt_driver_la-nodeinfo.lo nodeinfo.c:1941:56: error: use of undeclared identifier 'SYSFS_SYSTEM_PATH' const char *prefix = sysfs_prefix ? sysfs_prefix : SYSFS_SYSTEM_PATH;

Re: [libvirt] [PATCH 03/10] nodeinfo: Rename linuxParseCPUmax() to linuxParseCPUCount()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:22 +0200, Andrea Bolognani wrote: > The original name was confusing because the function returns the number > of CPUs, not the maximum CPU id. The comment above the function has > been updated to reflect this. > > No functional changes. > --- > src/nodeinfo.c | 7 +++

Re: [libvirt] [PATCH v2] qemu: Reject updating unsupported disk information

2015-07-20 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 04:21:29PM +0200, Michal Privoznik wrote: On 10.07.2015 08:20, Martin Kletzander wrote: If one calls update-device with information that is not updatable, libvirt reports success even though no data were updated. The example used in the bug linked below uses updating dev

Re: [libvirt] [PATCH 02/10] nodeinfo: Introduce linuxGetCPUOnlinePath()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:21 +0200, Andrea Bolognani wrote: > --- > src/nodeinfo.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/nodeinfo.c b/src/nodeinfo.c > index 64b12e6..7a12d54 100644 > --- a/src/nodeinfo.c > +++ b/src/nodeinfo.c > @@ -973,6 +973,9 @@ l

Re: [libvirt] [PATCH v2] qemu: Reject updating unsupported disk information

2015-07-20 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 04:58:46PM +0200, Michal Privoznik wrote: On 17.07.2015 16:21, Michal Privoznik wrote: On 10.07.2015 08:20, Martin Kletzander wrote: If one calls update-device with information that is not updatable, libvirt reports success even though no data were updated. The example

Re: [libvirt] [PATCH 01/10] nodeinfo: Introduce linuxGetCPUGlobalPath()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:20 +0200, Andrea Bolognani wrote: > This is just a more generic version of linuxGetCPUPresentPath(), > which is now implemented by calling the new function appropriately. > --- > src/nodeinfo.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-20 Thread Daniel P. Berrange
On Sun, Jul 05, 2015 at 07:43:43PM +0800, Qiaowei Ren wrote: > One RFC in > https://www.redhat.com/archives/libvir-list/2015-June/msg01509.html > > CMT (Cache Monitoring Technology) can be used to measure the > usage of cache by VM running on the host. This patch will > extend the bulk stats API (

[libvirt] [PATCH v2] network: add an option to make dns public

2015-07-20 Thread Cédric Bosdonnat
In some use cases we don't want the virtual network's DNS to only listen to the vnet interface. Adding a publiclyAccessible attribute to the dns element in the configuration allows the DNS to listen to all interfaces. It simply disables the bind-dynamic option of dnsmasq for the network. --- Thi

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-20 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 06:02:25PM +0200, Christophe Fergeau wrote: On Fri, Jul 17, 2015 at 03:42:36PM +0200, Martin Kletzander wrote: On Fri, Jul 17, 2015 at 12:11:55PM +0200, Peter Krempa wrote: >On Fri, Jul 17, 2015 at 09:29:44 +0100, Frediano Ziglio wrote: >>Allows to specify maximum number

[libvirt] [PATCH 2/2] tests: Add script to copy nodeinfo test data from host

2015-07-20 Thread Andrea Bolognani
Files we don't need, including symbolic links that might result problematic to make dist, are removed from the copied data. --- tests/nodeinfodata/copy-from-host.sh | 170 +++ 1 file changed, 170 insertions(+) create mode 100755 tests/nodeinfodata/copy-from-host.sh

[libvirt] [PATCH 0/2] tests: Add nodeinfo test data utility scripts

2015-07-20 Thread Andrea Bolognani
Both scripts can be useful when adding new test cases to the nodeinfo test. Andrea Bolognani (2): tests: Add script to display nodeinfo test data tests: Add script to copy nodeinfo test data from host tests/nodeinfodata/copy-from-host.sh | 170 +++ tests/nodei

[libvirt] [PATCH 1/2] tests: Add script to display nodeinfo test data

2015-07-20 Thread Andrea Bolognani
--- tests/nodeinfodata/display.sh | 101 ++ 1 file changed, 101 insertions(+) create mode 100755 tests/nodeinfodata/display.sh diff --git a/tests/nodeinfodata/display.sh b/tests/nodeinfodata/display.sh new file mode 100755 index 000..bc260e2 --- /dev/n

[libvirt] unsupported configuration: unknown video model 'virtio' - virtio-vga

2015-07-20 Thread poma
$ qemu-system-x86_64 ... -device virtio-vga # lspci -d 1af4:1050 -knn 00:03.0 VGA compatible controller [0300]: Red Hat, Inc Device [1af4:1050] (rev 01) Subsystem: Red Hat, Inc Device [1af4:1100] Kernel driver in use: virtio-pci Kernel modules: virtio_pci # dmesg | gre

[libvirt] [PATCH] qemu: fix some api cannot work when disable cpuset in conf

2015-07-20 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1244664 If user disable cpuset in qemu.conf, we shouldn't try to use it, also shouldn't make some command which can work without cpuset cannot work. Fix these case: 1. start guest with strict numa policy (we can use libnuma help us). 2. Hot add vcpu. 3.

Re: [libvirt] [PATCH] cgroup: Drop resource partition from virSystemdMakeScopeName

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 15:40:31 +0100, Daniel Berrange wrote: > On Thu, Jul 16, 2015 at 04:18:08PM +0200, Peter Krempa wrote: > > The scope name, even according to our docs is > > "machine-$DRIVER\x2d$VMNAME.scope" virSystemdMakeScopeName would use the > > resource partition name instead of "machi

Re: [libvirt] [PATCH] qxl: Fix new function name for spice-server library

2015-07-20 Thread Christophe Fergeau
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote: > The new spice-server function to limit the number of monitors (0.12.6) > changed while development from spice_qxl_set_monitors_config_limit to > spice_qxl_max_monitors (accepted upstream). > By mistake I post patch with former name.

Re: [libvirt] [PATCH 1/2] bhyve: add UTC clock support

2015-07-20 Thread Daniel P. Berrange
On Sun, Jul 19, 2015 at 11:20:35AM +0300, Roman Bogorodskiy wrote: > Bhyve as of r279225 (FreeBSD -CURRENT) or r284894 (FreeBSD 10-STABLE) > supports using UTC time offset via the '-u' argument to bhyve(8). By > default it's still using localtime. > > Make the bhyve driver use UTC clock if it's re

Re: [libvirt] [PATCH 2/2] docs: bhyve: document clock configuration

2015-07-20 Thread Daniel P. Berrange
On Sun, Jul 19, 2015 at 11:20:36AM +0300, Roman Bogorodskiy wrote: > --- > docs/drvbhyve.html.in | 28 > 1 file changed, 28 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

[libvirt] [PATCH] qxl: Fix new function name for spice-server library

2015-07-20 Thread Frediano Ziglio
The new spice-server function to limit the number of monitors (0.12.6) changed while development from spice_qxl_set_monitors_config_limit to spice_qxl_max_monitors (accepted upstream). By mistake I post patch with former name. This patch fix the function name. Signed-off-by: Frediano Ziglio ---