Re: [libvirt] [PATCH] qemu: Resolve Coverity UNINIT

2015-08-15 Thread John Ferlan
On 08/15/2015 10:54 AM, Martin Kletzander wrote: > On Sat, Aug 15, 2015 at 09:18:14AM -0400, John Ferlan wrote: >> Coverity complained that 'vm' wasn't initialized before jumping to >> cleanup: and calling virDomainObjEndAPI if the VIR_STRDUP fails. >> Rather than initialize vm = NULL, I moved th

[libvirt] [PATCH] protocol: Don't use rename as a variable name

2015-08-15 Thread Martin Kletzander
That causes shadowing errors on older compilers. Signed-off-by: Martin Kletzander --- Pushed under the build-breaker rule. src/remote/remote_protocol.x | 2 +- src/remote_protocol-structs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_protocol.x b/src/

Re: [libvirt] [PATCH] Remove static from vshReadline when readline not exist

2015-08-15 Thread Martin Kletzander
On Sat, Aug 15, 2015 at 10:59:41AM +0300, Moshe Levi wrote: This patch remove the static from the vshReadline which introduce in this commit 834c5720e4434f0bcc807bb1cf20855af63e24a3. In with readline function vshReadline is not static but without readline it defined static which cause compilation

Re: [libvirt] [PATCH] qemu: Resolve Coverity UNINIT

2015-08-15 Thread Martin Kletzander
On Sat, Aug 15, 2015 at 09:18:14AM -0400, John Ferlan wrote: Coverity complained that 'vm' wasn't initialized before jumping to cleanup: and calling virDomainObjEndAPI if the VIR_STRDUP fails. Rather than initialize vm = NULL, I moved the VIR_STRDUP closer to usage and used endjob for goto. Wi

Re: [libvirt] [PATCH] qemuDomainRename: Report error if adding domain to domainObj list fails

2015-08-15 Thread Martin Kletzander
On Fri, Aug 14, 2015 at 03:40:16PM +0200, Michal Privoznik wrote: So, domain renaming works like this: new domain name is added into the list of domain objects. Then, domain definition is updated. After that, old domain name is removed from the domain object list. Now, if the very firs step fails

Re: [libvirt] [libvirt-php PATCH] added missing libvirt 1.2.8 constants

2015-08-15 Thread Vasiliy Tolstov
2015-08-15 14:50 GMT+03:00 Eric Schultz : > src/libvirt-php.c | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/src/libvirt-php.c b/src/libvirt-php.c > index f0a2167..8588128 100644 > --- a/src/libvirt-php.c > +++ b/src/libvirt-php.c > @@ -1216,6 +12

[libvirt] [PATCH] qemu: Resolve Coverity UNINIT

2015-08-15 Thread John Ferlan
Coverity complained that 'vm' wasn't initialized before jumping to cleanup: and calling virDomainObjEndAPI if the VIR_STRDUP fails. Rather than initialize vm = NULL, I moved the VIR_STRDUP closer to usage and used endjob for goto. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 6 +++---

[libvirt] [libvirt-php PATCH] added missing libvirt 1.2.8 constants

2015-08-15 Thread Eric Schultz
--- src/libvirt-php.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index f0a2167..8588128 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1216,6 +1216,8 @@ PHP_MINIT_FUNCTION(libvirt) /* XML cont

[libvirt] [PATCH] utils: Remove the logging of errors from virNetDevSendEthtoolIoctl

2015-08-15 Thread Moshe Levi
This patch remove the logging of errors of ioctl api and instead let the caller to choose what errors to log --- src/util/virnetdev.c | 44 +--- 1 files changed, 13 insertions(+), 31 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c in

[libvirt] [PATCH] Remove static from vshReadline when readline not exist

2015-08-15 Thread Moshe Levi
This patch remove the static from the vshReadline which introduce in this commit 834c5720e4434f0bcc807bb1cf20855af63e24a3. In with readline function vshReadline is not static but without readline it defined static which cause compilation error. --- tools/vsh.c |2 +- 1 files changed, 1 inserti