Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Vasiliy Tolstov
23 нояб. 2015 г. 15:13 пользователь "Vasiliy Tolstov" написал: > > 2015-11-23 15:10 GMT+03:00 Peter Krempa : > > The file should not exist prior to the snapshot. If you want to > > pre-create it (with correct size and format), you need to specify > > --reuse-external in that case. Virsh manual alr

Re: [libvirt] [PATCH 3/8] perf: implement the public APIs for perf event

2015-11-23 Thread Ren, Qiaowei
> -Original Message- > From: Jiri Denemark [mailto:jdene...@redhat.com] > Sent: Tuesday, November 24, 2015 12:25 AM > To: Ren, Qiaowei > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 3/8] perf: implement the public APIs for perf > event > > On Tue, Nov 17, 2015 at 16:00:43 +

Re: [libvirt] [PATCH 1/8] perf: add new public APIs for perf event

2015-11-23 Thread Ren, Qiaowei
> -Original Message- > From: Jiri Denemark [mailto:jdene...@redhat.com] > Sent: Monday, November 23, 2015 11:26 PM > To: Ren, Qiaowei > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 1/8] perf: add new public APIs for perf event > > On Tue, Nov 17, 2015 at 16:00:41 +0800, Qiao

Re: [libvirt] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

2015-11-23 Thread Jim Fehlig
On 11/23/2015 01:59 PM, Jim Fehlig wrote: > > Thanks for your comments and ACK'ing the change . I'll submit a V2 that > retains > handling of shutdown event in a thread. While testing V2, I noticed occasionally missing a shutdown event. I can see from the logs that domain_death_xswatch_callback i

Re: [libvirt] [PATCH 31/34] qemu: Replace checking for vcpu<->pid mapping availability with a helper

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Add qemuDomainHasVCpuPids to do the checking and replace in place checks > with it. > --- > src/qemu/qemu_cgroup.c | 7 ++- > src/qemu/qemu_domain.c | 15 +++ > src/qemu/qemu_domain.h | 2 ++ > src/qemu/qemu_driver.c | 29 ++

Re: [libvirt] [PATCH 30/34] qemu: Drop checking vcpu threads in emulator bandwidth getter/setter

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > The vCPU threads make sense in the counterparts that set the vCPU > bandwidth/quota, not in the emulator one. The emulator tunables are set > all the time anyways. > > Drop the extra check and remove the now unneeded vm argument. > --- > src/qemu/qe

Re: [libvirt] [PATCH 29/34] qemu: cgroup: Remove now unreachable check

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Since commit 0c04906fa the check for priv->cgroup doesn't make sense as > the calls to virCgroupHasController return the same information. Remove > it and move it's comment partially to the new check. > > The already spurious check was also later cop

Re: [libvirt] [libvirt-glib v3] gobject: Port to GTask API

2015-11-23 Thread Zeeshan Ali (Khattak)
On Mon, Nov 23, 2015 at 10:45 PM, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- Sorry, forgot to pass --annotate option to git-send-email. v3 just drops some of the private context structures in favour of GPOINTER_TO_UINT/GUINT_TO_POINTER usage. -- Regar

Re: [libvirt] [PATCH 28/34] conf: Add helper to get pointer to a certain vCPU definition

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Once more stuff will be moved into the vCPU data structure it will be > necessary to get a specific one in some ocasions. Add a helper that will > simplify this task. > --- > src/conf/domain_conf.c | 15 +++ > src/conf/domain_conf.h |

Re: [libvirt] [PATCH 26/34] conf: turn def->vcpus into a structure

2015-11-23 Thread John Ferlan
On 11/23/2015 05:22 PM, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: >> To allow collecting all relevant data at one place let's make def->vcpus >> a structure and then we can start moving stuff into it. >> --- >> src/conf/domain_conf.c | 55 >>

[libvirt] [libvirt-glib v3] gobject: Port to GTask API

2015-11-23 Thread Zeeshan Ali (Khattak)
Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 290 +--- libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++--- libvirt-gobject/libvirt-gobject-storage-

Re: [libvirt] [PATCH 27/34] conf: ABI: Split up and improve vcpu info ABI checking

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Extract the checking code into a separate function and prepare the > infrastructure for checking the new structure type. > --- > src/conf/domain_conf.c | 41 ++--- > 1 file changed, 30 insertions(+), 11 deletions(-

Re: [libvirt] [PATCH 26/34] conf: turn def->vcpus into a structure

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > To allow collecting all relevant data at one place let's make def->vcpus > a structure and then we can start moving stuff into it. > --- > src/conf/domain_conf.c | 55 > -- > src/conf/domain_conf.h | 1

Re: [libvirt] [PATCH 07/34] conf: Replace writes to def->maxvcpus with accessor

2015-11-23 Thread John Ferlan
On 11/20/2015 10:21 AM, Peter Krempa wrote: > To support further refactors replace all write access to def->maxvcpus > with a accessor function. > --- > src/conf/domain_conf.c | 18 -- > src/conf/domain_conf.h | 2 ++ > src/hyperv/hyperv_driver.c | 5 - > src/libvir

Re: [libvirt] [PATCH 25/34] qemu: refactor qemuDomainHotunplugVcpus

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Refactor the code flow so that 'exit_monitor:' can be removed. > > This patch moves the auditing functions into places where it's certain > that hotunplug was or was not successful and reports errors from > qemuMonitorGetCPUInfo properly. > --- > sr

[libvirt] [PATCH 0/2] nodedev: fix virtual_functions element

2015-11-23 Thread Laine Stump
Moshe Levi pointed out yesterday in an email to libvir-list that there was no way to tell from the node device API that a PCI was capable of having SRIOV virtual functions (VFs) if it was currently setup to not have any: https://www.redhat.com/archives/libvir-list/2015-November/msg00894.html The

[libvirt] [PATCH 1/2] conf: support reporting maxCount attribute for virtual_functions cap

2015-11-23 Thread Laine Stump
Report the maximum possible number of VFs for an SRIOV PF, like this: ... I've just discovered that the virtual_functions and physical_functions capabilities are not supported in the virNodeDeviceParse functions, only in virNodeDeviceFormat (I suppose because they are only reported,

[libvirt] [PATCH 2/2] nodedev: report maxCount for virtual_functions capability

2015-11-23 Thread Laine Stump
A PCI device may have the capability to setup virtual functions (VFs) but have them currently all disabled. Prior to this patch, if that was the case the the node device XML for the device wouldn't report any virtual_functions capability. With this patch, if a file called "sriov_totalvfs" is found

Re: [libvirt] [PATCH 24/34] qemu: Refactor qemuDomainHotplugVcpus

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Refactor the code flow so that 'exit_monitor:' can be removed. > > This patch also moves the auditing and setting of the new vCPU count > right to the place where the hotplug happens, since it's possible that > the hotplug succeeds and adds a cpu whi

Re: [libvirt] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

2015-11-23 Thread Jim Fehlig
On 11/23/2015 04:24 AM, Ian Jackson wrote: > Jim Fehlig writes ("[PATCH RFC] libxl: use libxl_event_wait to process libxl > events"): >> Prior to this patch, libxl events were delivered to libvirt via >> the libxlDomainEventHandler callback registered with libxl. >> Documenation in $xensrc/tools/l

Re: [libvirt] [PATCH 23/34] qemu: cpu hotplug: Move loops to qemuDomainSetVcpusFlags

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > qemuDomainHotplugVcpus/qemuDomainHotunplugVcpus are complex enough in > regards of adding one CPU. Additionally it will be desired to reuse > those functions later with specific vCPU hotplug. > > Move the loops for adding vCPUs into qemuDomainSetVcpu

Re: [libvirt] [PATCH 22/34] qemu: monitor: Remove weird return values from qemuMonitorSetCPU

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Let the function report errors internally and change it to return > standard return codes. > --- > src/qemu/qemu_driver.c | 22 -- > src/qemu/qemu_monitor_json.c | 4 > src/qemu/qemu_monitor_text.c | 22 +++

Re: [libvirt] [PATCH 21/34] qemu: monitor: Explain logic of qemuMonitorGetCPUInfo

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > The return value has non-obvious semantics. Document it. > --- > src/qemu/qemu_monitor.c | 9 + > 1 file changed, 9 insertions(+) > ACK - wish I'd peeked two ahead before I sent last one ;-) John -- libvir-list mailing list libvir-list@re

Re: [libvirt] [PATCH 20/34] qemu: cpu hotplug: Fix error handling logic

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > The cpu hotplug helper functions used negative error handling in a part > of them, although some code that was added later didn't properly set the > error codes in some cases. This would cause improper error messages in > cases where we couldn't modif

Re: [libvirt] [PATCH 19/34] qemu: Split up vCPU hotplug and hotunplug

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > There's only very little common code among the two operations. Split the > functions so that the internals are easier to understand and refactor > later. > --- > src/qemu/qemu_driver.c | 210 > - > 1 f

[libvirt] [PATCH v2 1/2] libxl: rename libxlConsoleCallback

2015-11-23 Thread Joao Martins
. to a more generic name i.e. libxlDomainStartCallback, since it will now cover another case other than the console. Signed-off-by: Joao Martins --- src/libxl/libxl_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.

[libvirt] [PATCH v2 2/2] libxl: implement virDomainInterfaceStats

2015-11-23 Thread Joao Martins
Introduce support for domainInterfaceStats API call for querying network interface statistics. Consequently it also enables the use of `virsh domifstat ` command plus seeing the interfaces names instead of "-" when doing `virsh domiflist `. After successful guest creation we fill the network inte

[libvirt] [PATCH v2 0/2] libxl: implement virDomainInterfaceStats

2015-11-23 Thread Joao Martins
Hey, This patch series implements virDomainInterfaceStats but based on "ConsoleCallback" as opposed of doing it in libxlDomainStart. The series is divided as following: Patch 1 renames console callback to something more generic and Patch 2 implements virDomainInterfaceStats also taking the previo

Re: [libvirt] [PATCH 18/34] qemu: qemuDomainSetVcpusAgent: re-check agent before calling it the again

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > With a very unfortunate timing, the agent might vanish before we do the > second call while the locks were down. Re-check that the agent is > available before attempting it again. > --- > src/qemu/qemu_driver.c | 3 +++ > 1 file changed, 3 insertions

Re: [libvirt] [PATCH] document virCommandRunRegex function

2015-11-23 Thread Ján Tomko
On Mon, Nov 23, 2015 at 03:09:49PM +0100, Christian Loehle wrote: > >From 01a3ed1e6bacba8cd9f398e5233960714b2c4f49 Mon Sep 17 00:00:00 2001 > From: Christian Loehle > Date: Mon, 23 Nov 2015 15:06:37 +0100 > Subject: [PATCH] =?UTF-8?q?document=20virCommandRunRegex=20function=C3=84?= > MIME-Version:

Re: [libvirt] [PATCH 5/6] RFC qemu: add spice opengl support

2015-11-23 Thread Ján Tomko
On Fri, Nov 20, 2015 at 04:30:44PM +0100, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on > argument to enable opengl rendering context. This is necessary > to actually enable virgl rendering. > > Signed-off-by: Marc-André Lureau > --- > docs/formatd

Re: [libvirt] [PATCH 06/24] qemu: Always set async job when starting a domain

2015-11-23 Thread Daniel P. Berrange
On Thu, Nov 12, 2015 at 07:37:08PM +0100, Jiri Denemark wrote: > We only started an async job for incoming migration from another host. > When we were starting a domain from scratch or restoring from a saved > state (migration from file) we didn't set any async job. Let's introduce > a new QEMU_ASY

Re: [libvirt] [PATCH 2/6] qemu: query virtio-gpu for virgl support

2015-11-23 Thread Ján Tomko
On Fri, Nov 20, 2015 at 04:30:41PM +0100, Marc-André Lureau wrote: > Check if virtio-gpu provides virgl option. > The commit also formats qemu command line. > Signed-off-by: Marc-André Lureau > --- > src/qemu/qemu_capabilities.c | 8 ++ > src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH 1/6] qemu: add virtio video device

2015-11-23 Thread Ján Tomko
On Fri, Nov 20, 2015 at 04:30:40PM +0100, Marc-André Lureau wrote: > qemu 2.5 provides virtio video device. Similarly to other devices, > it can be used with -vga virtio or -device virtio-vga for primary > devices, or -device virtio-gpu for non-vga devices. > This adds virtio-vga but not virtio-g

Re: [libvirt] [PATCH v4 02/10] Add iommu group number info to virPCIDevice

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:35, Shivaprasad G Bhat wrote: > The iommu group number need not be fetched from the sysfs > everytime as it remains constant. Fetch it once during > allocation. > > Signed-off-by: Shivaprasad G Bhat > --- > src/util/virpci.c |5 + > 1 file changed, 5 insertions(+) > > d

Re: [libvirt] [PATCH v4 08/10] Add iommu info for pci on mocked sysfs

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:38, Shivaprasad G Bhat wrote: > The iommu group info can be used to check if the devices are bound/unbound > from vfio at the group level granualrity. Add the info to mock as to help > add test cases later. > > Signed-off-by: Shivaprasad G Bhat > --- > tests/virpcimock.c | 180

Re: [libvirt] [PATCH v4 03/10] Refuse to reattach from vfio if the iommu group is in use by any domain

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:36, Shivaprasad G Bhat wrote: > It is incorrect to attempt the device reattach of a function, > when some other domain is using some functions belonging to the same iommu > group. > > Signed-off-by: Shivaprasad G Bhat > --- > src/util/virhostdev.c | 21 - >

Re: [libvirt] [PATCH v4 06/10] Pass activeDevs and inactiveDevs to virPCIDeviceUnbindFromStub and virPCIDeviceBindToStub

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:36, Shivaprasad G Bhat wrote: > The inactiveDevs need to be selectively altered for more than one > device in case of vfio devices. So, pass the whole list. > > Signed-off-by: Shivaprasad G Bhat > --- > src/util/virpci.c | 36 +++- > 1 file chan

Re: [libvirt] [PATCH v4 01/10] Implement virPCIIsKnownStub function

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:34, Shivaprasad G Bhat wrote: > The checks to known stubs can be easily done having this > implementation. > > Signed-off-by: Shivaprasad G Bhat > --- > src/util/virpci.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/s

Re: [libvirt] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

2015-11-23 Thread Joao Martins
On 11/23/2015 03:35 PM, Jim Fehlig wrote: > On 11/20/2015 05:40 PM, Joao Martins wrote: >> >> On 11/20/2015 07:05 PM, Jim Fehlig wrote: >>> On 11/19/2015 04:45 PM, Joao Martins wrote: >>> >>> You're not going to be happy with me... >>> This new field in libxlDomainObjPrivate is named "config

Re: [libvirt] [PATCH v4 05/10] Split reprobe action from the virPCIUnbindFromStub into a new function

2015-11-23 Thread Michal Privoznik
On 14.11.2015 09:36, Shivaprasad G Bhat wrote: > The reprobe needs to be called multiple times for vfio devices for each > device in the iommu group in future patch. So split the reprobe into a > new function. No functional change. > > Signed-off-by: Shivaprasad G Bhat > --- > src/util/virpci.c

Re: [libvirt] [PATCH v2 2/7] qemu: Introduce qemuProcessLaunch

2015-11-23 Thread Pavel Hrdina
On Thu, Nov 19, 2015 at 01:09:16PM +0100, Jiri Denemark wrote: > Once qemuProcessInit was called, qemuProcessLaunch will launch a new > QEMU process with stopped virtual CPUs. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - save status before running VIR_HOOK_QEMU_OP_S

Re: [libvirt] [PATCH 17/34] qemu: Extract vCPU onlining/offlining via agent into a separate function

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Separate the code so that qemuDomainSetVcpusFlags contains only code > relevant to hardware hotplug/unplug. > --- > src/qemu/qemu_driver.c | 137 > +++-- > 1 file changed, 77 insertions(+), 60 deletions(-)

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 11:26:11AM -0500, Laine Stump wrote: > On 11/23/2015 10:40 AM, Daniel P. Berrange wrote: > >On Mon, Nov 23, 2015 at 10:34:43AM -0500, Laine Stump wrote: > > > >>If we're going to switch to emiting virt_functions whenever a device has the > >>potential to provide VFs, we may

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-23 Thread Laine Stump
On 11/23/2015 10:40 AM, Daniel P. Berrange wrote: On Mon, Nov 23, 2015 at 10:34:43AM -0500, Laine Stump wrote: If we're going to switch to emiting virt_functions whenever a device has the potential to provide VFs, we may as well make it worthwhile and also emit the maximum possible VFs for the

Re: [libvirt] [PATCH 3/8] perf: implement the public APIs for perf event

2015-11-23 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:43 +0800, Qiaowei Ren wrote: > * src/libvirt-domain.c: Implement virDomainGetPerfEvents and > virDomainSetPerfEvents. > > Signed-off-by: Qiaowei Ren > --- > src/libvirt-domain.c | 106 > +++ > 1 file changed, 106 inse

Re: [libvirt] [libvirt-glib v2 3/3] gobject: Port to GTask API

2015-11-23 Thread Zeeshan Ali (Khattak)
On Mon, Nov 23, 2015 at 4:08 PM, Christophe Fergeau wrote: > On Fri, Nov 20, 2015 at 09:06:30PM +, Zeeshan Ali (Khattak) wrote: >> Drop usage of deprecated GSimpleAsyncResult API. >> --- > > A Changes since v1 section would be nice as this patch is a bit big. > >> >> +typedef struct { >> +

Re: [libvirt] Fw:[PATCH] fix configure for pcap

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 03:58:25PM +0800, 程宝传 wrote: > when cross-compiling, pcap can not point to the correct toolchain. > > configure.ac | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index f481c50..d6d2cf4 100644 > --- a/confi

Re: [libvirt] [libvirt-glib v2 3/3] gobject: Port to GTask API

2015-11-23 Thread Christophe Fergeau
On Fri, Nov 20, 2015 at 09:06:30PM +, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- A Changes since v1 section would be nice as this patch is a bit big. > > +typedef struct { > +guint flags; > +} DomainWakeupData; > + > +static void domain_wakeup_

[libvirt] Fw:[PATCH] fix configure for pcap

2015-11-23 Thread 程宝传
when cross-compiling, pcap can not point to the correct toolchain. configure.ac | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index f481c50..d6d2cf4 100644 --- a/configure.ac +++ b/configure.ac @@ -1555,7 +1555,7 @@ if test "$with_numad

Re: [libvirt] [PATCH 14/34] conf: Replace read accesses to def->vcpus with accessor

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > --- > src/conf/domain_audit.c| 2 +- > src/conf/domain_conf.c | 19 +-- > src/conf/domain_conf.h | 1 + > src/libvirt_private.syms | 1 + > src/libxl/libxl_conf.c | 2 +- > src/libxl/libxl_driver.c | 8 ---

Re: [libvirt] [PATCH v2 1/7] qemu: Introduce qemuProcessInit

2015-11-23 Thread Pavel Hrdina
On Thu, Nov 19, 2015 at 01:09:15PM +0100, Jiri Denemark wrote: > qemuProcessStart is going to be split in three parts: qemuProcessInit, > qemuProcessLaunch, and qemuProcessFinish so that migration Prepare phase > can insert additional code in the process. qemuProcessStart will be a > small wrapper

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 10:34:43AM -0500, Laine Stump wrote: > On 11/23/2015 05:05 AM, Daniel P. Berrange wrote: > >On Sun, Nov 22, 2015 at 11:04:28AM +, Moshe Levi wrote: > >>Hi, > >> > >>I was looking on the output of virsh nodedev-dumpxml on a PCI to see if it > >>has SR-IOV PF capability.

Re: [libvirt] [PATCH 1/8] perf: add new public APIs for perf event

2015-11-23 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:41 +0800, Qiaowei Ren wrote: > API agreed on in > https://www.redhat.com/archives/libvir-list/2015-October/msg00872.html > > * include/libvirt/libvirt-domain.h (virDomainGetPerfEvents, > virDomainSetPerfEvents): New declarations. > * src/libvirt_public.syms: Export ne

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-23 Thread Laine Stump
On 11/23/2015 05:05 AM, Daniel P. Berrange wrote: On Sun, Nov 22, 2015 at 11:04:28AM +, Moshe Levi wrote: Hi, I was looking on the output of virsh nodedev-dumpxml on a PCI to see if it has SR-IOV PF capability. It seem that if the virtual functions are enables the xml look like [1] but if

Re: [libvirt] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

2015-11-23 Thread Jim Fehlig
On 11/20/2015 05:40 PM, Joao Martins wrote: > > On 11/20/2015 07:05 PM, Jim Fehlig wrote: >> On 11/19/2015 04:45 PM, Joao Martins wrote: >> >> You're not going to be happy with me... >> >>> This new field in libxlDomainObjPrivate is named "config" >>> and is kept while the domain is active. >> Whil

Re: [libvirt] [PATCH 13/34] conf: Move vcpu count check into helper

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > --- > src/conf/domain_conf.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index d8c1068..3062b3a 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/doma

Re: [libvirt] [PATCH 12/34] conf: Replace writes to def->vcpus with accessor

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > --- > src/conf/domain_conf.c | 25 +++-- > src/conf/domain_conf.h | 1 + > src/hyperv/hyperv_driver.c | 5 - > src/libvirt_private.syms | 1 + > src/libxl/libxl_driver.c | 14 +- > src/openvz/openvz_

Re: [libvirt] [PATCH v3 10/11] admin: Introduce virAdmConnectGetLibVersion

2015-11-23 Thread Martin Kletzander
On Thu, Nov 19, 2015 at 10:52:35AM +0100, Erik Skultety wrote: On 16/11/15 17:42, Martin Kletzander wrote: const ADMIN_PROGRAM = 0x06900690; const ADMIN_PROTOCOL_VERSION = 1; @@ -71,5 +75,10 @@ enum admin_procedure { /** * @generate: none */ -ADMIN_PROC_CONNECT_CLOSE = 2 +A

Re: [libvirt] [PATCH 11/34] conf: Replace read access to def->maxvcpus with accessor

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Finalize the refactor by adding the 'virDomainDefGetVCpusMax' getter and > reusing it accross libvirt. > --- > src/conf/domain_conf.c | 22 +++--- > src/conf/domain_conf.h | 1 + > src/libvirt_private.syms | 1 + > src/lib

Re: [libvirt] [PATCH] storage: Ignore block devices that fail format detection

2015-11-23 Thread Ján Tomko
On Fri, Oct 30, 2015 at 11:13:21AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1276198 > > Prior to commit id '98322052' failure to saferead the block device would > cause an error to be logged and the device to be skipped while attempting > to discover/create a stable

[libvirt] [PATCH] document virCommandRunRegex function

2015-11-23 Thread Christian Loehle
>From 01a3ed1e6bacba8cd9f398e5233960714b2c4f49 Mon Sep 17 00:00:00 2001 From: Christian Loehle Date: Mon, 23 Nov 2015 15:06:37 +0100 Subject: [PATCH] =?UTF-8?q?document=20virCommandRunRegex=20function=C3=84?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

Re: [libvirt] [PATCH 10/34] conf: Assume at least 1 maximum and current vCPU for every conf

2015-11-23 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Set new domain configs to contain at least 1 vCPU add a check that > maximum vCPU count isn't set to 0 and remove unnecesary checks. > > The openvz test suite change is necessary since the test case generates > the config via virDomainDefNew but does

Re: [libvirt] [PATCH 09/34] conf: Add helper to check whether domain has offline vCPUs

2015-11-23 Thread John Ferlan
On 11/20/2015 10:21 AM, Peter Krempa wrote: > The new helper will simplify checking whether the domain config contains > inactive vCPUs. > --- > src/conf/domain_conf.c | 9 - > src/conf/domain_conf.h | 1 + > src/libvirt_private.syms | 1 + > src/openvz/openvz_driver.c | 2 +- >

Re: [libvirt] [PATCH v3 08/11] admin: Add support for URI aliases

2015-11-23 Thread Martin Kletzander
On Thu, Nov 19, 2015 at 02:00:16PM +0100, Erik Skultety wrote: -if (!(conn->uri = virURIParse(uri ? uri : default_uri))) +if ((!(flags & VIR_CONNECT_NO_ALIASES) && + virURIResolveAlias(conf, uri ? uri : default_uri, &alias) < 0)) this should also be fixed (with what I mentioned

Re: [libvirt] [PATCH 2/3] Simplify qemuSetupChrSourceCgroup and its callers

2015-11-23 Thread Ján Tomko
On Fri, Nov 20, 2015 at 09:42:43AM -0500, John Ferlan wrote: > > > On 11/20/2015 05:04 AM, Ján Tomko wrote: > > The domain definition is not needed in any of these functions. > > Only pass it to qemuSetupChardevCgroup, which is used as a callback > > for virDomainChrDefForeach. > > > > Use the r

Re: [libvirt] [libvirt-glib v2 1/3] gobject: Drop redundant glib compatibility code

2015-11-23 Thread Christophe Fergeau
ACK. On Fri, Nov 20, 2015 at 09:06:28PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib older than that. > --- > libvirt-gobject/libvirt-gobject-compat.c | 87 > ---

Re: [libvirt] [libvirt-glib 2/3] gconfig: Drop redundant glib compatibility code

2015-11-23 Thread Christophe Fergeau
I don't know why this one is 2/3, I would squash it with the other similar gobject patch. ACK. Christophe On Fri, Nov 20, 2015 at 09:05:23PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib

Re: [libvirt] [v3] gobject: Add wrapper virDomainSetTime()

2015-11-23 Thread Christophe Fergeau
On Fri, Nov 20, 2015 at 03:27:22PM +, Zeeshan Ali (Khattak) wrote: > --- > libvirt-gobject/libvirt-gobject-domain.c | 134 > +++ > libvirt-gobject/libvirt-gobject-domain.h | 15 +++- > libvirt-gobject/libvirt-gobject.sym | 9 +++ > 3 files changed, 157 inse

Re: [libvirt] [PATCH 07/34] conf: Replace writes to def->maxvcpus with accessor

2015-11-23 Thread John Ferlan
On 11/20/2015 10:21 AM, Peter Krempa wrote: > To support further refactors replace all write access to def->maxvcpus > with a accessor function. > --- > src/conf/domain_conf.c | 18 -- > src/conf/domain_conf.h | 2 ++ > src/hyperv/hyperv_driver.c | 5 - > src/libvir

Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Vasiliy Tolstov
2015-11-23 15:13 GMT+03:00 Vasiliy Tolstov : > If file is not exists i get error: > error: internal error: unable to execute QEMU command 'transaction': > Could not open '/test.raw': Invalid argument Does libvirt/qemu supports external snapshots from raw source format? for example : virsh snapsho

Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Vasiliy Tolstov
2015-11-23 15:10 GMT+03:00 Peter Krempa : > The file should not exist prior to the snapshot. If you want to > pre-create it (with correct size and format), you need to specify > --reuse-external in that case. Virsh manual already documents that: > >If --reuse-external is specified, and the snap

Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Peter Krempa
On Mon, Nov 23, 2015 at 15:04:55 +0300, Vasiliy Tolstov wrote: > 2015-11-23 14:43 GMT+03:00 Peter Krempa : > > If you insist on using --live you also have to specify --memspec to > > point to a location where the memory snapshot is saved. Btw, --live and > > --disk-only are basically mutually exclu

Re: [libvirt] [PATCH 05/34] conf: Use local copy of maxvcpus in virDomainVcpuParse

2015-11-23 Thread John Ferlan
On 11/20/2015 10:21 AM, Peter Krempa wrote: > Use the local variable rather than getting it all the time from the > struct. This will simplify further refactors. > --- > src/conf/domain_conf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c

Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Vasiliy Tolstov
2015-11-23 14:43 GMT+03:00 Peter Krempa : > If you insist on using --live you also have to specify --memspec to > point to a location where the memory snapshot is saved. Btw, --live and > --disk-only are basically mutually exclusive since --disk-only implies > that the memory state should not be sa

Re: [libvirt] libvirt external snapshot error

2015-11-23 Thread Peter Krempa
On Mon, Nov 23, 2015 at 13:13:09 +0300, Vasiliy Tolstov wrote: > Hi, i'm using > virsh -c qemu+ssh://test.node/system snapshot-create-as 40083 > --no-metadata --disk-only --live –atomic --diskspec sda,file=/test > > outputs: > error: Operation not supported: live snapshot creation is supported >

[libvirt] [PATCH] vz: implementation of boot device order

2015-11-23 Thread Mikhail Feoktistov
This patch implements functionality of boot device order based on boot element from os section in XML. Now we support boot from CDROM and HDD. If we have several devices of the same type (for example hdd0 and hdd1), than we mark the first one as bootable. --- src/vz/vz_sdk.c | 111

Re: [libvirt] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

2015-11-23 Thread Ian Jackson
Jim Fehlig writes ("[PATCH RFC] libxl: use libxl_event_wait to process libxl events"): > Prior to this patch, libxl events were delivered to libvirt via > the libxlDomainEventHandler callback registered with libxl. > Documenation in $xensrc/tools/libxl/libxl_event.h states that the > callback "may

[libvirt] libvirt external snapshot error

2015-11-23 Thread Vasiliy Tolstov
Hi, i'm using virsh -c qemu+ssh://test.node/system snapshot-create-as 40083 --no-metadata --disk-only --live –atomic --diskspec sda,file=/test outputs: error: Operation not supported: live snapshot creation is supported only with external checkpoints info: Compiled against library: libvirt 1.2.

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-23 Thread Daniel P. Berrange
On Sun, Nov 22, 2015 at 11:04:28AM +, Moshe Levi wrote: > Hi, > > I was looking on the output of virsh nodedev-dumpxml on a PCI to see if it > has SR-IOV PF capability. > It seem that if the virtual functions are enables the xml look like [1] but > if the PCI has no VFs enabled the > output

Re: [libvirt] [libvirt-glib 3/3] gobject: Port to GTask API

2015-11-23 Thread Christophe Fergeau
On Fri, Nov 20, 2015 at 03:57:08PM -0500, Zeeshan Ali (Khattak) wrote: > >> diff --git a/libvirt-gobject/libvirt-gobject-stream.c > >> b/libvirt-gobject/libvirt-gobject-stream.c > >> index 46dbd9a..f8a1a8c 100644 > >> --- a/libvirt-gobject/libvirt-gobject-stream.c > >> +++ b/libvirt-gobject/libvir

Re: [libvirt] [PATCH] qemu: handle more machines with a single builtin IDE controller

2015-11-23 Thread Guido Günther
On Sat, Nov 21, 2015 at 02:36:44PM -0500, Laine Stump wrote: > On 11/21/2015 02:00 PM, Guido Günther wrote: > >like I440FX by moving the condition into qemuDomainMachineHasBuiltinIDE > >and adding more machines. > > Nice! I like this better than the original 3 patch series, since it allows > recog