On Thu, Jan 07, 2016 at 22:50:03 -0500, Cole Robinson wrote:
> This also makes VIR_TEST_REGENERATE_OUTPUT work
> ---
> tests/qemuxml2xmltest.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index f967ceb..e3bd9c2
On Thu, Jan 07, 2016 at 22:49:56 -0500, Cole Robinson wrote:
> This should be a no-op
> ---
> src/conf/domain_conf.c | 53
> +-
> 1 file changed, 31 insertions(+), 22 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> i
On Thu, Jan 07, 2016 at 22:49:55 -0500, Cole Robinson wrote:
> This should be a no-op
> ---
> src/conf/domain_conf.c | 38 --
> 1 file changed, 24 insertions(+), 14 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 9d47846..a
On Thu, Jan 07, 2016 at 18:21:18 +0100, Andrea Bolognani wrote:
> Most of the changes to the list of active and inactive PCI devices
> happen in virHostdev, where they are properly logged.
>
> virPCIDeviceDetach() and virPCIDeviceReattach(), however, change the
> inactive list as well, so they sho
On 01/07/2016 07:48 AM, Michal Privoznik wrote:
> On 29.12.2015 02:09, Jim Fehlig wrote:
>> Both xm and xl config have long supported specifying vif rate
>> limiting, e.g.
>>
>> vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ]
>>
>> Add support for mapping rate to and from in the xenconfig
On 01/07/2016 07:48 AM, Michal Privoznik wrote:
> On 29.12.2015 02:09, Jim Fehlig wrote:
>> The libxl_device_nic structure supports specifying an outgoing rate
>> limit based on a time interval and bytes allowed per interval. In xl
>> config a rate limit is specified as "/s@". INTERVAL
>> is option
---
tests/qemuxml2xmltest.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index e3bd9c2..c0270d4 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -59,7 +59,7 @@ testXML2XMLHelper(const char *i
In order to make this work, we need to short circuit the normal
virDomainDefPostParse ordering, and manually add stock devices
ourselves, since we need them in the XML before assigning addresses.
There's a bit of test suite churn due to extra XML output, and validation
happening at different call
We will use this in upcoming patches
---
src/conf/domain_conf.c | 31 +--
src/conf/domain_conf.h | 4
src/libvirt_private.syms | 1 +
3 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 61dc65
Should be a no-op
---
src/qemu/qemu_domain.c | 53 +++---
1 file changed, 33 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index bb8d47f..26a29b1 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domai
This should be a no-op
---
src/conf/domain_conf.c | 53 +-
1 file changed, 31 insertions(+), 22 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ab22322..2570f94 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domai
Future changes will make some of these tests dependent on specific
QEMUCaps flags, so wire up the basic handling.
---
tests/qemuxml2xmltest.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index c0270d4..32c9fed 100644
--- a/tests
This also makes VIR_TEST_REGENERATE_OUTPUT work
---
tests/qemuxml2xmltest.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index f967ceb..e3bd9c2 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -43,7
Rather than open coding calls. I can't see any reason not to
---
src/qemu/qemu_domain.c | 3 +++
src/qemu/qemu_driver.c | 6 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 48a2160..a981310 100644
--- a/src/qemu/qemu_domai
There are several qemu and generic domain XML validating/populating
routines that callers need to invoke manually after parsing XML. This
series moves some of these calls into the PostParse handling routines.
Functionally there shouldn't be much change, except for more complete
XML in a few cases w
It's just a combination of AddImplicitControllers, and AddConsoleCompat.
Every caller that wants ImplicitControllers also wants the ConsoleCompat
AFAICT, so lump them together. We also need it for future patches.
---
src/conf/domain_conf.c | 19 ++-
src/conf/domain_conf.h | 2
This should be a no-op
---
src/conf/domain_conf.c | 38 --
1 file changed, 24 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9d47846..ab22322 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
Seems like the natural fit, since we are already adding other XML bits
in the PostParse routine.
Previously AddImplicitControllers was only called at the end of XML
parsing, meaning code that builds a DomainDef by hand had to manually
call it. Adding it for those sites causes some test suite churn
Rather than open coding calls. I can't see any reason not to
---
src/qemu/qemu_domain.c | 23 +++
src/qemu/qemu_driver.c | 29 -
2 files changed, 23 insertions(+), 29 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 26
Justin Clift wrote:
> On 6 Jan 2016, at 18:03, Roman Bogorodskiy wrote:
> > Roman Bogorodskiy wrote:
> >> Justin Clift wrote:
> >>> Hiyas,
> >>>
> >>> Just went to update the MacOS X Homebrew port/formula for
> >>> Libvirt 1.3.0. It's failing during compilation with:
> >>>
> >>> **
On 01/07/2016 02:01 PM, Henning Schild wrote:
> On Thu, 7 Jan 2016 11:20:23 -0500
> John Ferlan wrote:
>
>>
>> [...]
>>
No problem - although it seems they've generated a regression in
the virttest memtune test suite. I'm 'technically' on vacation
for the next couple of weeks; h
On Wed, Nov 18, 2015 at 20:12:58 +0200, Pavel Boldin wrote:
> The provided patchset implements NBD disk migration over a tunnelled
> connection provided by libvirt.
>
> The migration source instructs QEMU to NBD mirror drives into the provided
> UNIX socket. These connections and all the data are
My commit 674afcb09e3d33500cfbbcf870ebf92cb99ecfa3 moved computing the
default listen address from qemuMigrationPrepareAny to
qemuMigrationPrepareIncoming. However, I didn't notice listenAddress was
later passed to qemuMigrationStartNBDServer. Thus, it would be called
with the original value of lis
On Thu, Dec 31, 2015 at 16:51:26 +1100, Michael Chapman wrote:
> If no migration_address is configured, QEMU will listen on 0.0.0.0 or
> [::]. Commit 674afcb09e3d33500cfbbcf870ebf92cb99ecfa3 moved the
> handling of this default value into a new qemuMigrationPrepareIncoming
> function, however the
On Mon, Dec 21, 2015 at 14:46:33 +0100, Andrea Bolognani wrote:
> n Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote:
> > To reduce code duplication.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> > tools/virsh-domain.c | 293
> >---
> > 1 file
On Mon, Dec 21, 2015 at 16:25:56 +0100, Andrea Bolognani wrote:
> On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote:
> >
> > @@ -12154,7 +12155,16 @@ virshEventPrint(virshDomEventData *data,
> > if (!data->loop && *data->count)
> > goto cleanup;
> >
> > -vshPrint(data->ctl
I have been looking at this once again and thinking about this whole
implementation.
I can agree with Daniel's assesment of the SVM/NPT bit setting but the
nested_hvm feature does not exist at all in KVM at the libvirt level/
I could be wrong but when I last looked nested hvm could only be
en
On 6 Jan 2016, at 18:03, Roman Bogorodskiy wrote:
> Roman Bogorodskiy wrote:
>> Justin Clift wrote:
>>> Hiyas,
>>>
>>> Just went to update the MacOS X Homebrew port/formula for
>>> Libvirt 1.3.0. It's failing during compilation with:
>>>
>>> ***
On Thu, 7 Jan 2016 11:20:23 -0500
John Ferlan wrote:
>
> [...]
>
> >> No problem - although it seems they've generated a regression in
> >> the virttest memtune test suite. I'm 'technically' on vacation
> >> for the next couple of weeks; however, I think/perhaps the problem
> >> is a result of
Not all lease values are mandatory, and when they aren't supplied
by the libvirt driver they get set to NULL. That makes
rb_str_new2() bail out.
Signed-off-by: Dan Williams
---
For example using the qemu driver we don't get 'iaid', and that
makes ruby unhappy:
[{"iface"=>"virbr1", "expirytime"=
[...]
>> No problem - although it seems they've generated a regression in the
>> virttest memtune test suite. I'm 'technically' on vacation for the
>> next couple of weeks; however, I think/perhaps the problem is a
>> result of this patch and the change to adding the task to the cgroup
>> at the
On 29.12.2015 02:09, Jim Fehlig wrote:
> Both xm and xl config have long supported specifying vif rate
> limiting, e.g.
>
> vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ]
>
> Add support for mapping rate to and from in the xenconfig
> parser and formatter. rate is mapped to the require
On 01/06/2016 01:58 PM, Laine Stump wrote:
> On 12/18/2015 10:45 AM, John Ferlan wrote:
>> v1:
>> http://www.redhat.com/archives/libvir-list/2015-December/msg00731.html
>>
>> Changes over v1:
>>
>> 1. Insert patch 1 to convert already pushed VSH_POOL into VIRSH_POOL
>> since that was the r
Those parameters should be in opposite order.
Signed-off-by: Pavel Hrdina
---
tests/nwfilterebiptablestest.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/nwfilterebiptablestest.c b/tests/nwfilterebiptablestest.c
index e1330ef..6bd6aad 100644
--- a/test
Since more tests supports regenerating its output, this patch updates
those expected output files.
Signed-off-by: Pavel Hrdina
---
tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml | 4 ++--
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 4 ++--
tests/qem
This is just a rebase to current HEAD.
Pavel Hrdina (10):
xen: move virDomainDefPostParse to xenParseSxpr
tests: introduce VIR_TEST_REGENERATE_OUTPUT flag
tests.testutils: use VIR_TEST_REGENERATE_OUTPUT for
virTestDifferenceFull
tests.testutils: use virTestDifferenceFull in virtTestCom
This patch partially reverts previous commit 91a00424 and moves the post
parse function to xenParseSxpr. This update is required because xen
driver calls xenParseSxpr directly.
Signed-off-by: Pavel Hrdina
---
src/xen/xend_internal.c | 7 +--
src/xenconfig/xen_sxpr.c | 21 ++---
This will enable regenerate functionality for those tests to make
developer lives easier while updating tests.
Signed-off-by: Pavel Hrdina
---
tests/domainsnapshotxml2xmltest.c | 2 +-
tests/interfacexml2xmltest.c | 2 +-
tests/lxcconf2xmltest.c | 2 +-
tests/nodedevxml2xmltest
When this flag is specified, some of the expected output files will be
regenerated with the actual output data. This is a helper for updating
test data.
Signed-off-by: Pavel Hrdina
---
tests/testutils.c | 14 +++---
tests/testutils.h | 1 +
2 files changed, 12 insertions(+), 3 deletion
This function may be called with @dconnuri == NULL, e.g. from
virDomainMigrateToURI3() if the flags are missing
VIR_MIGRATE_PEER2PEER flag. Moreover, all later functions called
from here do wrap it into NULLSTR() so why not do the same here?
Signed-off-by: Michal Privoznik
---
src/libvirt-domain
On Thu, Jan 07, 2016 at 10:47:46AM +0100, Pavel Hrdina wrote:
On Thu, Jan 07, 2016 at 10:18:26AM +0100, Martin Kletzander wrote:
On Thu, Jan 07, 2016 at 09:40:29AM +0100, Pavel Hrdina wrote:
>On Wed, Jan 06, 2016 at 05:50:57PM +0100, Martin Kletzander wrote:
>> If user defines a virtio channel w
Commit b22344f3285187ee1768d6e031bc0ff20e32552d mistakenly reordered
Default-* lines. Thanks to that I noticed that we are very inconsistent
with our init scripts, so I took the liberty of synchronizing them,
updating them and making them all look shiny and new. So apart from
fixing the LSB requi
https://bugzilla.redhat.com/show_bug.cgi?id=1266088
We are missing this value for cdrom-image device. Honestly, I
have no idea whether it can happen for other disk devices too.
Signed-off-by: Michal Privoznik
---
src/vmx/vmx.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/
On Wed, Jan 06, 2016 at 05:50:57PM +0100, Martin Kletzander wrote:
> If user defines a virtio channel with UNIX socket backend and doesn't
> care about the path for the socket (e.g. qemu-agent channel), we still
> generate it into the persistent XML. Moreover when then user renames
> the domain, d
44 matches
Mail list logo