[libvirt] [PATCH v2] migration: add option to set target ndb server port

2016-02-15 Thread Nikolay Shirokovskiy
Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But tunelled mode does not support non-shared disks. The other way to make migration secure is to

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

2016-02-15 Thread David Gibson
On Mon, 08 Feb 2016 20:11:41 +0100 Andrea Bolognani wrote: > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote: > > The nodeinfo output was fixed earlier to reflect the actual cpus available > > in > > KVM mode on PPC64. The earlier fixes covered the aspect of not making a host > > loo

Re: [libvirt] [PATCH 06/12] qemu: Move qemuNetworkIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread John Ferlan
On 02/15/2016 05:38 PM, Laine Stump wrote: > On 02/15/2016 02:37 PM, John Ferlan wrote: >> Move the misplaced function from qemu_command.c to qemu_interface.c >> since it's closer in functionality there and had less to do with building >> the command line. >> >> Rename function to qemuInterfaceNe

Re: [libvirt] [PATCH 05/12] qemu: Move qemuPhysIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread John Ferlan
On 02/15/2016 05:31 PM, Laine Stump wrote: > On 02/15/2016 02:37 PM, John Ferlan wrote: >> Move the misplaced function from qemu_command.c to qemu_interface.c >> since it's closer in functionality there and had less to do with building >> the command line. >> >> Rename function to qemuInterfacePh

Re: [libvirt] [PATCH 06/12] qemu: Move qemuNetworkIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread Laine Stump
On 02/15/2016 02:37 PM, John Ferlan wrote: Move the misplaced function from qemu_command.c to qemu_interface.c since it's closer in functionality there and had less to do with building the command line. Rename function to qemuInterfaceNetworkConnect and modify callers. This function really is

Re: [libvirt] [PATCH 05/12] qemu: Move qemuPhysIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread Laine Stump
On 02/15/2016 02:37 PM, John Ferlan wrote: Move the misplaced function from qemu_command.c to qemu_interface.c since it's closer in functionality there and had less to do with building the command line. Rename function to qemuInterfacePhysicalConnect and modify callers. Signed-off-by: John Ferl

Re: [libvirt] VMware driver: SessionIsActive API / Sessions.ValidateSession permission

2016-02-15 Thread Richard W.M. Jones
On Mon, Feb 15, 2016 at 11:22:27PM +0100, Matthias Bolte wrote: > Here's a patch that basically reverts the offending commit. The patch > is only compile tested, as I don't have a vCenter at hand to test > this. Do you have the option to test this in an actual setup? Yes - I will be able to test t

Re: [libvirt] VMware driver: SessionIsActive API / Sessions.ValidateSession permission

2016-02-15 Thread Matthias Bolte
2016-02-11 12:59 GMT+01:00 Richard W.M. Jones : > Is calling SessionIsActive necessary? From my (very limited) > understanding, it seems as if we might use 'SessionManager. > currentSession' property instead, which doesn't require admin > permissions. Actually the code [see link above] already do

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Maydell
On 15 February 2016 at 20:18, Andrew Jones wrote: > On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: >> How would the command line look like? >> > > Here is what is available today > > # select gicv2 (this work with and without KVM) > qemu-system-aarch64 -M virt

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Andrew Jones
On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On 15 February 2016 at 15:08, Markus Armbruster wrote: > >> Peter Xu writes: > >>> On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: > Peter Xu writes: > Adding ad hoc qu

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Maydell writes: > On 15 February 2016 at 15:08, Markus Armbruster wrote: >> Peter Xu writes: >>> On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: Peter Xu writes: Adding ad hoc queries as we go won't scale. Is there really no generic way to get this info

[libvirt] [PATCH 10/12] qemu-command: Move and rename qemuOpenVhostNet

2016-02-15 Thread John Ferlan
Move function to qemu_interface.c and rename to qemuInterfaceOpenVhostNet Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 97 +-- src/qemu/qemu_command.h | 6 --- src/qemu/qemu_hotplug.c | 9 +++-- src/qemu/qemu_interface.c | 97 ++

[libvirt] [PATCH 06/12] qemu: Move qemuNetworkIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread John Ferlan
Move the misplaced function from qemu_command.c to qemu_interface.c since it's closer in functionality there and had less to do with building the command line. Rename function to qemuInterfaceNetworkConnect and modify callers. Signed-off-by: John Ferlan --- po/POTFILES.in| 1 + sr

[libvirt] [PATCH 04/12] qemu-command: Move qemuVirCommandGetDevSet

2016-02-15 Thread John Ferlan
Move function closer to where it's used in qemuBuildTPMBackendStr Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 08/12] qemu-command: Move qemuDomain*Address* functions to qemu_domain.c

2016-02-15 Thread John Ferlan
Move the functions into qemu_domain.c - additionally move any supporting static functions. Make qemuDomainSupportsPCI non static. Also, move and rename the following: qemuSetSCSIControllerModel to qemuDomainSetSCSIControllerModel qemuCollectPCIAddress to qemuDomainCollectPCIAddress qemuValidateD

[libvirt] [PATCH 09/12] qemu-command: Move remaining qemuDomain* functions

2016-02-15 Thread John Ferlan
Move qemuDomainNetVLAN and qemuDomainDeviceAliasIndex into qemu_domain.c Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 22 -- src/qemu/qemu_command.h | 1 - src/qemu/qemu_domain.c | 25 + src/qemu/qemu_domain.h | 4 4 files changed,

[libvirt] [PATCH 07/12] qemu-command: Move qemuDomainSupports* functions

2016-02-15 Thread John Ferlan
Move qemuDomainSupportsNicdev and qemuDomainSupportsNetdev into qemu_domain.c and expose from there. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 29 - src/qemu/qemu_domain.c | 29 + src/qemu/qemu_domain.h | 9 + 3 fi

[libvirt] [PATCH 12/12] qemu-command: Move qemuAssign*Alias* API's into their own module

2016-02-15 Thread John Ferlan
Create a new module qemu_assign_alias.c to handle the qemuAssign*Alias* APIs Signed-off-by: John Ferlan --- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/qemu/qemu_assign_alias.c | 468 +++ src/qemu/qemu_assign_alias.h |

[libvirt] [PATCH 02/12] qemu-command: Move qemuVirCommandGetFDSet

2016-02-15 Thread John Ferlan
Move function closer to where it's used in qemuBuildTPMCommandLine Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 53 + 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c inde

[libvirt] [PATCH 05/12] qemu: Move qemuPhysIfaceConnect to qemu_interface.c and rename

2016-02-15 Thread John Ferlan
Move the misplaced function from qemu_command.c to qemu_interface.c since it's closer in functionality there and had less to do with building the command line. Rename function to qemuInterfacePhysicalConnect and modify callers. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 58 +++--

[libvirt] [PATCH 11/12] qemu-command: Move qemuNetworkPrepareDevices

2016-02-15 Thread John Ferlan
Move function to qemu_process.c, rename to qemuSetupNetworkPrepareDevices and make it static. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 50 src/qemu/qemu_process.c | 55 - 2 files changed,

[libvirt] [PATCH 01/12] qemu-command: Move qemuBuildTPMBackendStr

2016-02-15 Thread John Ferlan
Move function closer to where it's called in qemuBuildTPMCommandLine Also adjust function header to fit current coding guidelines Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 180 1 file changed, 91 insertions(+), 89 deletions(-) dif

[libvirt] [PATCH 00/12] Split up qemu_command.c

2016-02-15 Thread John Ferlan
Before disappearing too far down the rabbit hole... My recent foray into qemu_command.c to split out qemu_parse_command.c got me thinking that the module could use quite a bit of a reorganization. It's about 11,400 lines of all sorts of various functions. This started out as an attempt to order f

[libvirt] [PATCH 03/12] qemu-command: Move qemuBuildTPMDevStr

2016-02-15 Thread John Ferlan
Move function closer to where it's used in qemuBuildTPMCommandLine Also fix function header to match current coding practices Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 61 + 1 file changed, 31 insertions(+), 30 deletions(-) diff --

[libvirt] [PATCH 6/6] nss: Introduce a test

2016-02-15 Thread Michal Privoznik
A small test to see how is the nss module working. Signed-off-by: Michal Privoznik --- cfg.mk | 2 +- tests/Makefile.am | 18 + tests/nssdata/virbr0.status | 14 tests/nssmock.c | 140 + tests/nsstest.c

[libvirt] [PATCH 2/6] virjson: Resolve const correctness

2016-02-15 Thread Michal Privoznik
Plenty of our virJSON*() APIs don't modify passed object. They merely get a value stored in it. Note this fact in their definition and enforce const correctness. Signed-off-by: Michal Privoznik --- src/util/virjson.c | 58 +++--- src/util/virjson.h

[libvirt] [PATCH 4/6] nss: Implement _nss_libvirt_gethostbyname3_r

2016-02-15 Thread Michal Privoznik
The implementation is pretty straightforward. Moreover, because of the nature of things, gethostbyname_r and gethostbyname2_r can be implemented at the same time too. Signed-off-by: Michal Privoznik --- tools/Makefile.am | 8 +- tools/nss/libvirt_nss.c| 322 +++

[libvirt] [PATCH 1/6] Export virLease* functions for leases file handling

2016-02-15 Thread Michal Privoznik
These functions are going to be reused very shortly. So instead of duplicating the code, lets move them into utils module. Signed-off-by: Michal Privoznik --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/libvirt_private.syms | 6 + src/network/leaseshelper.c |

[libvirt] [PATCH 3/6] Initial support for NSS plugin skeleton

2016-02-15 Thread Michal Privoznik
Name Service Switch is a glibc feature responsible for many things. Translating domain names into IP addresses and vice versa is just one of them. However, currently it's the only functionality that this commit is tickling. Well, in this commit the plugin skeleton is introduced. Implementation to c

[libvirt] [PATCH 0/6] NSS module for libvirt

2016-02-15 Thread Michal Privoznik
Are you tired of remembering IP addresses for your domains? Do you have enough of configuring static IPs so that you can add them to your hosts file? Then libvirt NSS module is exactly what you need! NSS does a lot in a Linux host. These patches aim at translating domain names into IP addresses.

[libvirt] [PATCH 5/6] Implement _nss_libvirt_gethostbyname4_r

2016-02-15 Thread Michal Privoznik
This function is a different beast compared to previous ones. But yet again, nothing surprising is happening here. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c| 84 ++ tools/nss/libvirt_nss.h| 4 +++ tools/nss/libvirt_nss.syms |

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Daniel P. Berrange
On Mon, Feb 15, 2016 at 04:08:33PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > For ARM platform, we still do not have any interface to query > >> > whether current QEMU/host support

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Maydell
On 15 February 2016 at 15:08, Markus Armbruster wrote: > Peter Xu writes: >> On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >>> Peter Xu writes: >>> Adding ad hoc queries as we go won't scale. Is there really no generic >>> way to get this information, e.g. with qom-get? >>

Re: [libvirt] [PATCH] Spell VMware with a lowercase w

2016-02-15 Thread Andrea Bolognani
On Mon, 2016-02-15 at 15:38 +0100, Ján Tomko wrote: > Replace all occurrences of VMWare outside the news. > --- >  docs/formatdomain.html.in | 2 +- >  docs/migration.html.in| 2 +- >  docs/storage.html.in  | 2 +- >  libvirt.spec.in   | 2 +- >  src/util/virerror.c   | 2 +- >  src/

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu writes: > On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >> Peter Xu writes: >> >> > For ARM platform, we still do not have any interface to query >> > whether current QEMU/host support specific GIC version. This >> > patchset is trying to add one QMP interface for

[libvirt] [PATCH] Spell VMware with a lowercase w

2016-02-15 Thread Ján Tomko
Replace all occurrences of VMWare outside the news. --- docs/formatdomain.html.in | 2 +- docs/migration.html.in| 2 +- docs/storage.html.in | 2 +- libvirt.spec.in | 2 +- src/util/virerror.c | 2 +- src/util/virstoragefile.c | 2 +- tools/virsh.c | 2 +- 7 fi

Re: [libvirt] PING: [RFC] vhost-user + shared memory + NUMA

2016-02-15 Thread Daniel P. Berrange
On Mon, Feb 15, 2016 at 04:38:51PM +0300, Pavel Fedin wrote: > Hello! Sorry, but i did not get any answer to the last question. Would it be > OK to require and implicitly add only > shared mode ? No, I really think setting shared must be an explicit action by the app configuring libvirt. Autom

[libvirt] PING: [RFC] vhost-user + shared memory + NUMA

2016-02-15 Thread Pavel Fedin
Hello! Sorry, but i did not get any answer to the last question. Would it be OK to require and implicitly add only shared mode ? Kind regards, Pavel Fedin Senior Engineer Samsung Electronics Research center Russia > -Original Message- > From: libvir-list-boun...@redhat.com [mailto:lib

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Pavel Fedin
Hello! > I know Pavel Fedin was trying to revive kernel_irqchip=off once, > but I don't know if that effort was abandoned or not. It should work with the latest kernel, at least i posted patches and all of them were applied. If nothing got broken during later rewrites. The only missing part i

Re: [libvirt] [PATCH 0/2] virsh: fix usage of vshPrint

2016-02-15 Thread John Ferlan
On 02/12/2016 08:17 AM, Peter Krempa wrote: > Peter Krempa (2): > vsh: Simplify bailing out on OOM conditions > vsh: Replace vshPrint macro with function > > tools/virsh-domain.c | 16 +--- > tools/vsh.c | 34 +- > tools/vsh.h |

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Andrew Jones
On Mon, Feb 15, 2016 at 09:41:57AM +, Peter Maydell wrote: > On 15 February 2016 at 09:35, Martin Kletzander wrote: > > So hardware itself supports some GIC version, let's say 3 for our case. > > Does that mean it can be triggered to do v2 as well? I mean is it > > possible that HW supports m

Re: [libvirt] [PATCH 0/4] Couple of storage related fixes

2016-02-15 Thread Kashyap Chamarthy
On Wed, Feb 10, 2016 at 05:28:53PM +0100, Michal Privoznik wrote: > After an e-mail on libvirt-users [1] I think you meant this thread :-) [1] https://www.redhat.com/archives/libvirt-users/2016-February/msg00033.html -- "Unable to create raw volume on netfs storage (Operation not permitted)" >

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Xu
On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > For ARM platform, we still do not have any interface to query > > whether current QEMU/host support specific GIC version. This > > patchset is trying to add one QMP interface for that. By querying > > the

Re: [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Xu
On Mon, Feb 15, 2016 at 10:35:39AM +0100, Martin Kletzander wrote: > On Sun, Feb 14, 2016 at 01:41:41PM +0800, Peter Xu wrote: > > > >["gicv2", "gicv2-kvm", "gicv3-kvm"] > > > >Please help review whether the interface suits our need, also please > >point out any error I have made. > > > > This loo

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-02-15 Thread Andrea Bolognani
On Tue, 2016-02-02 at 16:58 +0100, Christoffer Dall wrote: > ok, so that would mean we need to implement a QMP command to tell us > which gic versions are supported for a given machine.  Current > possible responses are "2", "3" and "2,3" >  > and we also need to add code to libvirt to try that QMP

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu writes: > For ARM platform, we still do not have any interface to query > whether current QEMU/host support specific GIC version. This > patchset is trying to add one QMP interface for that. By querying > the GIC capability using the new interface, one should know exactly > what GIC vers

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Maydell
On 15 February 2016 at 09:35, Martin Kletzander wrote: > So hardware itself supports some GIC version, let's say 3 for our case. > Does that mean it can be triggered to do v2 as well? I mean is it > possible that HW supports multiple versions? If yes, then I suspect > there is (will be) HW that

Re: [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Martin Kletzander
On Sun, Feb 14, 2016 at 01:41:41PM +0800, Peter Xu wrote: For ARM platform, we still do not have any interface to query whether current QEMU/host support specific GIC version. This patchset is trying to add one QMP interface for that. By querying the GIC capability using the new interface, one sh

Re: [libvirt] [libvirt-php] Status of Development?

2016-02-15 Thread Daniel P. Berrange
On Sun, Feb 14, 2016 at 10:51:19AM +0100, Markus Petzsch wrote: > Hello, > > I've noticed that the PHP libvirt binding is missing some functions which > are present in other implementations. Namely things like attach-interface > which allow live modification of a running VM. How is the current sta

Re: [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Xu
On Mon, Feb 15, 2016 at 12:54:57AM -0600, Wei Huang wrote: > On 2/13/16 23:41, Peter Xu wrote: > > Please help review whether the interface suits our need, also please > > point out any error I have made. > > I tested QEMU with these patches and they were able to work on a native > ARM64 machine.

[libvirt] [RFC PATCH 1/2] arm: gic: add GICType

2016-02-15 Thread Peter Xu
A new enum type is added to define ARM GIC types. Signed-off-by: Peter Xu --- qapi-schema.json | 17 + 1 file changed, 17 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 8d04897..81654bd 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4083,3 +4083,2

[libvirt] [RFC PATCH 2/2] arm: gic: add "query-gic-capability" interface

2016-02-15 Thread Peter Xu
Signed-off-by: Peter Xu --- qapi-schema.json | 11 +++ qmp-commands.hx | 25 + qmp.c| 5 + scripts/qapi.py | 1 + 4 files changed, 42 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 81654bd..7e3b8cd 100644 --- a/qapi-schema

[libvirt] [libvirt-php] Status of Development?

2016-02-15 Thread Markus Petzsch
Hello, I've noticed that the PHP libvirt binding is missing some functions which are present in other implementations. Namely things like attach-interface which allow live modification of a running VM. How is the current status of the PHP binding? Will we see new features in the future or is

[libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Peter Xu
For ARM platform, we still do not have any interface to query whether current QEMU/host support specific GIC version. This patchset is trying to add one QMP interface for that. By querying the GIC capability using the new interface, one should know exactly what GIC version(s) the platform will supp

[libvirt] [PATCH] Revert "storageVolCreateXMLFrom: Check if backend knows how to createVol"

2016-02-15 Thread Ján Tomko
This reverts commit 611a278fa46d3136b7fe5c6ab05e660ca3c8fdf4. According to the original commit message, this is dead code: It is highly unlikely that a backend will know how to create a volume from a different volume (buildVolFrom) and not know how to create an empty volume (createVol). ---