On 24.02.2016 21:36, Florian Hubold wrote:
> Hi,
>
> one of the seems to fail on our build system, vircgrouptest fails with
> Unexpected: nodeGetCPUCount() yields: -1
>
> The test runs fine locally.
> Here are the contents from testsuite.log with VIR_TEST_DEBUG=1 enabled.
>
>
> See tests/test-s
>> Hi all:
>> AFAIK, there're several ways to test libvirt:
>> 1) virt-test, which is driven by autotest or avocado-vt, based on
>qemu-kvm
>> 2) test driver which is parall to other drivers such as qemu_driver and
>libxl_driver in libvirt.
>> 3) make -c tests, which aims to do low lev
libxlMakeNic opens a virConnect object and takes a reference on a
virNetwork object, but doesn't drop the references on all error
paths. Rework the function to follow the standard libvirt pattern
of using a local 'ret' variable to hold the function return value,
performing all cleanup and returning
Yet again, selinux has been adding const-correctness; this change
is ABI-compatible, but breaks API, which affects us when we try to
override things in our testsuite:
../../tests/securityselinuxhelper.c:307:24: error: conflicting types for
'selabel_open'
struct selabel_handle *selabel_open(unsig
Joao Martins wrote:
> Introduce support for domainInterfaceStats API call for querying
> network interface statistics. Consequently it also enables the use of
> `virsh domifstat ` command plus seeing the
> interfaces names instead of "-" when doing `virsh domiflist `.
>
> After successful guest c
gcc 6.0 added an annoying warning:
fdstream.c: In function 'virFDStreamWrite':
fdstream.c:390:29: error: logical 'or' of equal expressions [-Werror=logical-op]
if (errno == EAGAIN || errno == EWOULDBLOCK) {
^~
fdstream.c: In function 'virFDStreamRead':
fdstream.
Hi,
one of the seems to fail on our build system, vircgrouptest fails with
Unexpected: nodeGetCPUCount() yields: -1
The test runs fine locally.
Here are the contents from testsuite.log with VIR_TEST_DEBUG=1 enabled.
See tests/test-suite.log
Please report to libvir-list@redhat.com
==
On 02/11/2016 07:07 AM, Ján Tomko wrote:
> Commit f1a89a8 allowed parsing configs from /etc/libvirt
> without validating the emulator capabilities.
>
> Check for the presence of os->type.machine even if the
> VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS flag is set,
> otherwise the daemon can crash o
Zhangbo (Oscar) wrote:
> Hi all:
> AFAIK, there're several ways to test libvirt:
> 1) virt-test, which is driven by autotest or avocado-vt, based on qemu-kvm
> 2) test driver which is parall to other drivers such as qemu_driver and
> libxl_driver in libvirt.
> 3) make -c tests, which
I would like to request an account to update the libvirt wiki.
first: Adam
last: Hunt
user: voxadam
email: voxa...@gmail.com
--adam
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 02/02/2016 03:12 AM, Richard W.M. Jones wrote:
> On Mon, Feb 01, 2016 at 03:37:07PM +0100, Martin Kletzander wrote:
>> So we recently started compiling with gcc 5 and there's a new thing now
>> and we don't build on gcc 6. I know it's just a development build, but
>> it finds new things, like:
Introduce VIR_DOMAIN_DEF_FEATURE_OFFLINE_CPUPIN domain feature flag
whcih will allow to skip ignoring of the pinning information for
hypervisor drivers which will want to implement forward-pinning of
vcpus.
---
src/conf/domain_conf.c | 28 +++-
src/conf/domain_conf.h | 1 +
The implementation of the inner guts of the function is similar for all
drivers, so we can add a helper and not have to reimplement it three
times.
---
src/conf/domain_conf.c | 64
src/conf/domain_conf.h | 8 ++
src/libvirt_private.syms |
Commit 35847860 introduced virFileUnlink() to fix an issue with deleting
volumes on NFS root-squashed environment. This patch replace the uid
and gid magic by virFileIsSharedFSType() to correctly detect that the
volume is on NFS storage.
This fixes the referenced bug. To reproduce this bug follo
The function was now beyond maintainability.
---
src/qemu/qemu_driver.c | 134 -
1 file changed, 77 insertions(+), 57 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index bfabc53..cab69a5 100644
--- a/src/qemu/qemu_driver.
The API documentation states that the function is returning pinning for
all vCPUs, so we can actually do so if the user passes a large enough
array.
---
src/conf/domain_conf.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_
Now that the function was extracted we can get rid of some temp
variables. Additionally formatting of the bitmap string for the event
code should be checked.
---
src/qemu/qemu_driver.c | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/src
To avoid having to forbid new features added to domain XML in post parse
callbacks for individual hypervisor drivers the feature flag mechanism
will allow to add a central check that will be disabled for the drivers
that will add support.
As a first example flag, the 'hasWideSCSIBus' is converted
Introduce a helper to check supported device and domain config and move
the memory hotplug checks to it.
The advantage of this approach is that by default all new features are
considered unsupported by all hypervisors unless specifically changed
rather than the previous approach where every hyperv
Allow pinning for inactive cpus. The pinning mask will be automatically
applied as we would apply the default mask in case of a cpu hotplug.
Setting the scheduler settings for a vcpu has the same semantics.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1306556
---
src/qemu/qemu_domain.c
Yet another continuation of the saga. In this episode we add pinning for
inactive cpus.
Peter Krempa (9):
virsh: vcpupin: Ask for pinning info for all vCPUs
conf: Extract code filling data for virDomainGetVcpuPinInfo
qemu: Report pinning for all vCPUs in qemuDomainGetVcpuPinInfo
conf: intr
The API docs state that the API queries pinning info for all vCPUs and
thus we should allocate the bitmap even for the inactive ones.
The API will currently return bitmap only for the active vCPUs but that
will change in the future.
---
tools/virsh-domain.c | 3 ++-
1 file changed, 2 insertions(+
We honour the placement bitmaps when starting up, so there's no point in
having this check. Additionally the check was buggy since it checked
vm->def all the time even if the user requested to modify the persistent
definition which had different configuration.
Resolves: https://bugzilla.redhat.com
Similarly to the refactors to iothreads and vcpus, move the code that
initializes the emulator thread settings into single function.
---
src/qemu/qemu_cgroup.c | 66 -
src/qemu/qemu_cgroup.h | 1 -
src/qemu/qemu_process.c | 78
Peter Krempa (2):
qemu: process: Move emulator thread setting code into one function
qemu: Allow setting pinning of emulator/iohtread with automatic
placement
src/qemu/qemu_cgroup.c | 66 -
src/qemu/qemu_cgroup.h | 1 -
src/qemu/qemu_driver.c |
On Tue, Feb 23, 2016 at 05:58:07PM +0100, Pavel Hrdina wrote:
New in v2:
- added patch to always set primary video device as primary
- introduced new qemu monitor functions to update vram64 values after QEMU is
started only if QEMU supports this parameter
ACK series, although I would prefer
On 02/24/2016 04:31 AM, Jim Fehlig wrote:
> On 02/22/2016 04:15 PM, Joao Martins wrote:
>>
>> On 12/08/2015 04:06 PM, Jim Fehlig wrote:
>>> Daniel P. Berrange wrote:
On Mon, Dec 07, 2015 at 10:59:32PM -0700, Jim Fehlig wrote:
> On 12/07/2015 11:52 AM, Daniel P. Berrange wrote:
>> On
Introduce support for domainInterfaceStats API call for querying
network interface statistics. Consequently it also enables the use of
`virsh domifstat ` command plus seeing the
interfaces names instead of "-" when doing `virsh domiflist `.
After successful guest creation we fill the network inte
On Tue, Feb 23, 2016 at 05:58:08PM +0100, Pavel Hrdina wrote:
We always place primary video device at first place, to make it easier
to create a qemu command or format an xml, but we should also set the
primary boolean for primary video device to 'true'.
Signed-off-by: Pavel Hrdina
---
diff --
>On Wed, Feb 24, 2016 at 07:31:56AM +, Zhangbo (Oscar) wrote:
>> Hi all:
>> AFAIK, there're several ways to test libvirt:
>> 1) virt-test, which is driven by autotest or avocado-vt, based on
>qemu-kvm
>> 2) test driver which is parall to other drivers such as qemu_driver and
>libxl_d
ping
On 17.02.2016 11:48, Nikolay Shirokovskiy wrote:
>
>
> On 05.02.2016 18:24, Jiri Denemark wrote:
>> On Fri, Feb 05, 2016 at 18:01:30 +0300, Nikolay Shirokovskiy wrote:
>>>
>>>
>>> On 04.02.2016 21:11, Jiri Denemark wrote:
On Thu, Jan 28, 2016 at 10:04:29 +0300, Nikolay Shirokovskiy wro
Please, disregard this. It's version of the other 1/4 patch which differs only
in
commit message.
On 24.02.2016 11:38, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/conf/domain_conf.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff
Please, disregard this. It's version of the other 1/4 patch which differs only
in
commit message.
On 24.02.2016 11:38, Nikolay Shirokovskiy wrote:
> virDomainLiveConfigHelperMethod function checks this
> condition already.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/libxl/libxl_driver.
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0d2957b..d6c33f6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2872,13 +2872
Flag expansion is the same as in virDomainObjUpdateModificationImpact
which virDomainLiveConfigHelperMethod calls internally. The difference
is merely in implementation. Original code don't use mask
and handle case when VIR_DOMAIN_MEM_MAXIMUM is set explicitly.
Other parts are no different.
Signe
First fortunately all versions of *_CURRENT, *_CONFIG and *_LIVE flags
are numerically equal. Second libxl functions that don't use masks
for flag expansion forbid extra flags via virCheckFlags before.
Signed-off-by: Nikolay Shirokovskiy
---
src/libxl/libxl_driver.c | 63
virDomainLiveConfigHelperMethod function checks this
condition already.
Signed-off-by: Nikolay Shirokovskiy
---
src/libxl/libxl_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 7e65ba2..1428239 100644
--- a/src/libxl/libx
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0d2957b..d6c33f6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2872,13 +2872
Original name of series was:
Subject: [PATCH 0/3] make virDomainObjGetPersistentDef return only persistent
definition
Changes from version1
=
Original motivation of the series was fixing virDomainObjGetPersistentDef so
that it would not return configs other than persistent. H
virDomainLiveConfigHelperMethod function checks this
condition already.
Signed-off-by: Nikolay Shirokovskiy
---
src/libxl/libxl_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 7e65ba2..1428239 100644
--- a/src/libxl/libx
On 02/24/2016 03:31 PM, Zhangbo (Oscar) wrote:
Hi all:
AFAIK, there're several ways to test libvirt:
1) virt-test, which is driven by autotest or avocado-vt, based on qemu-kvm
2) test driver which is parall to other drivers such as qemu_driver and
libxl_driver in libvirt.
I'm af
On Wed, Feb 24, 2016 at 07:31:56AM +, Zhangbo (Oscar) wrote:
> Hi all:
> AFAIK, there're several ways to test libvirt:
> 1) virt-test, which is driven by autotest or avocado-vt, based on qemu-kvm
> 2) test driver which is parall to other drivers such as qemu_driver and
> libxl_driver
So as planned I tagged the rc1 in git and pushed signed tarball and rpms
to the usual place:
ftp://libvirt.org/libvirt/
This seems to work for me with my minimal testing, but please give it
a try especially for different architecture and systems.
Next step would be to push rc2 on Friday
43 matches
Mail list logo
