[libvirt] [PATCH] nss: properly include syms files to dist

Explicitly add Linux and BSD syms files for nss to EXTRA_DIST instead of using the LIBVIRT_NSS_SYMBOL_FILE variable, because its value will point to either Linux or BSD syms file, but we need to ship both. --- tools/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] nss: fix typo in configure help string

Servie -> Service Pushed as trivial. --- m4/virt-nss.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 3d6e8f4..bf5c416 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -20,7 +20,7 @@ dnl AC_DEFUN([LIBVIRT_CHECK_NSS],[ AC_ARG_WITH(

[libvirt] RFC: spec file cleanup ideas

Hi all, I wanted to float some ideas about cleaning up the RPM spec file. None of it is urgent but I'll end up scratching the itch eventually and I want to make sure people are on board Old distro bits: * Drop support for building on rhel5... this was ACKd previously by eblake: http://www.redhat

[libvirt] [libvirt-php PATCH 09/35] adapt add_assoc_string_ex

From: Remi Collet --- src/libvirt-php.c | 299 ++ 1 file changed, 99 insertions(+), 200 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index d37fd6f..0459bb9 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -58,6 +58,

[libvirt] [libvirt-php PATCH 11/35] zend_hash_update

From: Remi Collet --- src/libvirt-php.c | 4 1 file changed, 4 insertions(+) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 3ce8370..3dba7a0 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -3040,7 +3040,11 @@ PHP_FUNCTION(libvirt_connect_get_all_domain_stats)

[libvirt] [libvirt-php PATCH 35/35] Bump version to 0.5.2

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 51a2cfe..ed3c9d6 100644 --- a/configure.ac +++ b/configure.ac @@ -1,4 +1,4 @@ -AC_INIT([libvirt-php], [0.5.1], [http://libvirt.org]) +AC_INIT([libvirt-php], [0.5.2], [http://libvi

[libvirt] [libvirt-php PATCH 16/35] fix missed (hidden) zpp calls

From: Remi Collet --- src/libvirt-php.c | 279 +++--- 1 file changed, 141 insertions(+), 138 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index f4f9c5f..2700c77 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2248,7 +

[libvirt] [libvirt-php PATCH 28/35] fix PHP 5 compat again (nested macro issue)

From: Remi Collet --- src/libvirt-php.c | 163 +++--- src/libvirt-php.h | 26 + 2 files changed, 95 insertions(+), 94 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 511dcaa..9a32d79 100644 --- a/src/libvirt-php.c ++

[libvirt] [libvirt-php PATCH 21/35] Fix max_connections management

From: Remi Collet - %p doesn't work with PHP snprintf - store max_connections_ini as long instead of string - store mem as pointer instead of integer - convert test-conn-limit to phpt --- src/libvirt-php.c | 33 - src/libvirt-php.h | 4 ++-- 2 files changed, 14 i

[libvirt] [libvirt-php PATCH 30/35] add block_commit support and needed const

From: Vasiliy Tolstov Signed-off-by: Vasiliy Tolstov --- src/libvirt-php.c | 66 ++- src/libvirt-php.h | 1 + 2 files changed, 66 insertions(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 27bd828..7bea9e2 100644 -

[libvirt] [libvirt-php PATCH 03/35] add missing arginfo (wip)

From: Remi Collet --- src/libvirt-php.c | 458 +++--- 1 file changed, 371 insertions(+), 87 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 57e1b83..5f330f8 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -70,99 +70

[libvirt] [libvirt-php PATCH 23/35] add test-connect-get-emulator.phpt

From: Remi Collet --- src/tests/test-conn-limit.phpt | 2 +- src/tests/test-connect-get-emulator.phpt | 15 +++ src/tests/test-connect.phpt | 2 +- 3 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 src/tests/test-connect-get-emulator.phpt

[libvirt] [libvirt-php PATCH 34/35] Commit short instructions to using the php extension build method

--- INSTALL.PHPEXT | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 INSTALL.PHPEXT diff --git a/INSTALL.PHPEXT b/INSTALL.PHPEXT new file mode 100644 index 000..e8b6a55 --- /dev/null +++ b/INSTALL.PHPEXT @@ -0,0 +1,14 @@ +Installing using the PHP extension build system

[libvirt] [libvirt-php PATCH 12/35] add_next_index_string

From: Remi Collet --- src/libvirt-php.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 3dba7a0..c1587f9 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -7387,7 +7387,7 @@ PHP_FUNCTION(libv

[libvirt] [libvirt-php PATCH 26/35] convert test-domain-create-and-coredump.phpt to real phpt

From: Remi Collet --- src/tests/example-no-disk-and-media.xml| 41 + src/tests/test-domain-create-and-coredump.phpt | 49 ++ 2 files changed, 90 insertions(+) create mode 100644 src/tests/example-no-disk-and-media.xml create mode 100644 src/t

[libvirt] [libvirt-php PATCH 15/35] fix zpp

From: Remi Collet --- src/libvirt-php.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 1959074..f4f9c5f 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2088,7 +2088,7 @@ PHP_FUNCTION(libvirt_connect) char *url

[libvirt] [libvirt-php PATCH 04/35] fix typo in config.m4

From: Remi Collet --- install-sh| 366 +++--- missing | 2 +- src/config.m4 | 12 +- 3 files changed, 204 insertions(+), 176 deletions(-) diff --git a/install-sh b/install-sh index 0b0fdcb..377bb86 100755 --- a/install-sh +++ b/in

[libvirt] [libvirt-php PATCH 13/35] buildable with PHP 7

From: Remi Collet --- src/libvirt-php.c | 98 +-- src/libvirt-php.h | 4 +++ 2 files changed, 85 insertions(+), 17 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index c1587f9..1959074 100644 --- a/src/libvirt-php.c +++ b/src

[libvirt] [libvirt-php PATCH 29/35] add some checks to prevent overflow

From: Vasiliy Tolstov Signed-off-by: Vasiliy Tolstov Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 50 +++--- 1 file changed, 35 insertions(+), 15 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 57e1b83..27bd828 10064

[libvirt] [libvirt-php PATCH 17/35] fix PHP 5 compat

From: Remi Collet --- src/libvirt-php.c | 75 --- 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 2700c77..3977302 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -59,6 +59,9

[libvirt] [libvirt-php PATCH 14/35] bump version 0.5.2-dev

From: Remi Collet --- src/libvirt-php.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.h b/src/libvirt-php.h index 2ffe9f3..d1f034e 100644 --- a/src/libvirt-php.h +++ b/src/libvirt-php.h @@ -74,10 +74,10 @@ #endif #ifndef VERSION -#define VERSION "0.5

[libvirt] [libvirt-php PATCH 10/35] clean ALLOC_INIT_ZVAL

From: Remi Collet --- src/libvirt-php.c | 83 +-- 1 file changed, 74 insertions(+), 9 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 0459bb9..3ce8370 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2285,7 +228

[libvirt] [libvirt-php PATCH 20/35] Switch all add_assoc_string_ex to add_assoc_string to avoid nul char management

From: Remi Collet PHP 5 => #define add_assoc_string(__arg, __key, __str, __duplicate) add_assoc_string_ex(__arg, __key, strlen(__key)+1, __str, __duplicate) PHP 7 => #define add_assoc_string(__arg, __key, __str) add_assoc_string_ex(__arg, __key, strlen(__key), __str) --- src/lib

[libvirt] [libvirt-php PATCH 33/35] Add more tests

From: Frederic Mora --- src/tests/qemu-no-disk-and-media.xml | 41 + src/tests/test-connect-get-capabilities.phpt | 27 ++ src/tests/test-connect-get-info.phpt | 110 + src/tests/test-connect-get-machine-types.phpt | 30 +++ src/t

[libvirt] [libvirt-php PATCH 02/35] include config.h earlier

From: Remi Collet --- src/config.m4 | 2 -- src/libvirt-php.h | 14 -- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/config.m4 b/src/config.m4 index ee2b47d..d255f77 100644 --- a/src/config.m4 +++ b/src/config.m4 @@ -42,8 +42,6 @@ if test "$PHP_LIBVIRT" != "

[libvirt] [libvirt-php PATCH 08/35] register + fetch resources + hash

From: Remi Collet --- src/libvirt-php.c | 201 ++ 1 file changed, 174 insertions(+), 27 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 5f3857c..d37fd6f 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -57,9 +57,

[libvirt] [libvirt-php PATCH 24/35] fix parse_array + build warnings

From: Remi Collet --- src/libvirt-php.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index af80f06..511dcaa 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1128,11 +1128,11 @@ static void catch_error(void *us

[libvirt] [libvirt-php PATCH 32/35] add arginfo for libvirt_domain_block_commit and libvirt_domain_block_job_info

From: Chuck Roydhouse --- src/libvirt-php.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6b25961..36be055 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -213,6 +213,13 @@ ZEND_ARG_INFO(0, memory) ZE

[libvirt] [libvirt-php PATCH 19/35] port test-connect.phpt to real phpt

From: Remi Collet --- src/tests/test-connect.phpt | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 src/tests/test-connect.phpt diff --git a/src/tests/test-connect.phpt b/src/tests/test-connect.phpt new file mode 100644 index 000..2aab021 --- /dev/null +++ b/src/tes

[libvirt] [libvirt-php PATCH 31/35] add libvirt_domain_block_job_info

From: Vasiliy Tolstov Signed-off-by: Vasiliy Tolstov Signed-off-by: Yuriy Gromak Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 36 src/libvirt-php.h | 1 + 2 files changed, 37 insertions(+) diff --git a/src/libvirt-php.c b/src/libvirt-php.c ind

[libvirt] [libvirt-php PATCH 22/35] add test-conn-limit.phpt (as real phpt)

From: Remi Collet --- src/tests/test-conn-limit.phpt | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 src/tests/test-conn-limit.phpt diff --git a/src/tests/test-conn-limit.phpt b/src/tests/test-conn-limit.phpt new file mode 100644 index 0

[libvirt] [libvirt-php PATCH 05/35] add missing arginfo, part 2

From: Remi Collet --- src/libvirt-php.c | 287 +- 1 file changed, 198 insertions(+), 89 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 5f330f8..47893b2 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -80,7 +80,

[libvirt] [libvirt-php PATCH 00/35] Add PHP7 support and unit tests

First, I apologize if this was sent twice to anyone. I had an error in my git send-email configuration. This patch set primarily adds support for PHP 7 to libvirt-php, but also adds the capability for libvirt-php to be built using the standard PHP extension build system method. Several tests have

[libvirt] [libvirt-php PATCH 27/35] convert test-domain-create-and-get-xpath.phpt to real phpt

From: Remi Collet --- src/tests/test-domain-create-and-get-xpath.phpt | 56 + 1 file changed, 56 insertions(+) create mode 100644 src/tests/test-domain-create-and-get-xpath.phpt diff --git a/src/tests/test-domain-create-and-get-xpath.phpt b/src/tests/test-domain-create

[libvirt] [libvirt-php PATCH 18/35] fix libvirt_version + add test

From: Remi Collet --- src/libvirt-php.c | 2 +- src/tests/skipif.inc| 3 +++ src/tests/test-version-get.phpt | 27 +++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 src/tests/skipif.inc create mode 100644 src/tests/test-

[libvirt] [libvirt-php PATCH 06/35] adapt RETURN_STRING

From: Remi Collet --- src/libvirt-php.c | 258 ++ 1 file changed, 200 insertions(+), 58 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 47893b2..0f8d19e 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1343,7 +1

[libvirt] [libvirt-php PATCH 07/35] work on zpp

From: Remi Collet --- src/libvirt-php.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 0f8d19e..5f3857c 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -55,6 +55,12 @@ const char *fe

[libvirt] [libvirt-php PATCH 25/35] convert test-install.phpt to real phpt

From: Remi Collet --- src/tests/test-install.phpt| 136 + src/tests/test-libvirt-php.img | 0 2 files changed, 136 insertions(+) create mode 100644 src/tests/test-install.phpt create mode 100644 src/tests/test-libvirt-php.img diff --git a/src/test

[libvirt] [libvirt-php PATCH 01/35] add config.m4 to allow standard PHP extension build system

From: Remi Collet --- src/config.m4 | 52 1 file changed, 52 insertions(+) create mode 100644 src/config.m4 diff --git a/src/config.m4 b/src/config.m4 new file mode 100644 index 000..ee2b47d --- /dev/null +++ b/src/config.m4 @@ -0,0 +1,5

Re: [libvirt] RFC backup API

Hello all, Here is the first more detailed view on the list of the backup API functions that look reasonable to have. Though they are presented with parameters and short description all these are the subject to discuss and I kindly ask you to take a look and comment. Your ideas and considerat

Re: [libvirt] Automatic Guest Resolution Adjustment not functional with GRsec guests

On 04/08/2016 02:10 PM, ban...@openmailbox.org wrote: > A VM's QXL driver can no longer automatically adjust the screen resolution > resize when running a GRsecurity kernel in the guest. The screen still > responds to xrandr however but "scale display: always" in virt-manager doesn't > work as it u

[libvirt] Automatic Guest Resolution Adjustment not functional with GRsec guests

A VM's QXL driver can no longer automatically adjust the screen resolution resize when running a GRsecurity kernel in the guest. The screen still responds to xrandr however but "scale display: always" in virt-manager doesn't work as it used to. What can be causing this? -- libvir-list mailing

Re: [libvirt] [PATCH 0/2] host-validate: Don't build on Windows

On 04/08/2016 12:04 PM, Andrea Bolognani wrote: > The recent fixes to virt-host-validate have caused the mingw > build to fail[1]. > > Instead of working around Windows' quirks in the tool, just > stop building it altogether - it's not like it made any > sense to have it available on that OS anywa

Re: [libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

On 04/08/2016 10:55 AM, Andrea Bolognani wrote: > The check is supposed to stop users from trying to compile > virt-login-shell on Windows by erroring out during the > configure phase; however, there are two flaws in it: > > * the value of "x$with_win" is compared to "yes" instead > of "xyes

Re: [libvirt] [PATCH v2] Add macro for handling exponential backoff loops.

On Fri, Apr 08, 2016 at 05:14:04PM +0200, Ján Tomko wrote: > On Fri, Apr 08, 2016 at 12:57:51PM +0100, Richard W.M. Jones wrote: > > In a few places in libvirt we busy-wait for events, for example qemu > > creating a monitor socket. This is problematic because: > > > > - We need to choose a suff

[libvirt] [PATCH 1/2] tests: Enable failure testing with CompareDomXML2XML

This allows tests to check for specific failure scenarios --- tests/bhyvexml2xmltest.c | 4 ++-- tests/genericxml2xmltest.c | 4 ++-- tests/lxcxml2xmltest.c | 3 ++- tests/qemuxml2xmltest.c| 6 -- tests/testutils.c | 47 ++ tes

[libvirt] [PATCH 2/2] test: genericxml2xml: test graphics listen= compat

* Add a test for listen=XXX and collision error * Add an explicit test for listen=XXX duplicated to We implicitly test it elsewhere but I figure it's better to be explicit, and this test case can be extended in the future for additional listen back compat if/when we support syntax --- The

Re: [libvirt] [PATCH 18/18] qemu_domain: remove all listens if vncAutoUnixSocket is enabled

On 04/04/2016 09:20 AM, Pavel Hrdina wrote: > If in qemu.conf vncAutoUnixSocket is enabled remove all other listens > parsed from XML config. > > Signed-off-by: Pavel Hrdina Sorry I should have read further before commenting on patch #15 :) This isn't in line with how we handle qemu.conf vnc_li

Re: [libvirt] [PATCH 15/18] qemu_process: generate vnc unix socket in qemuProcessPrepareDomain

On 04/04/2016 09:20 AM, Pavel Hrdina wrote: > Move generation of vnc unix socket to qemuProcessPrepareDomain which is > the correct place to do those things. Now we can also test it. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_command.c| 20 - >

Re: [libvirt] [PATCH] virt-aa-helper: disallow VNC socket read permissions

On Fri, Apr 08, 2016 at 09:01:33AM -0400, Cole Robinson wrote: > From: Simon Arlott > > The VM does not need read permission for its own VNC socket to create(), > bind(), accept() connections or to receive(), send(), etc. on connections. > > https://bugzilla.redhat.com/show_bug.cgi?id=1312573 >

Re: [libvirt] [PATCH v3] host-validate: Be more careful when checking for cgroup support

On Fri, Apr 08, 2016 at 02:13:10PM +0200, Andrea Bolognani wrote: > Simply checking whether the cgroup name appears somewhere inside > /proc/self/cgroup is enough most of the time, but there are some > corner cases that require a more mindful parsing. > --- > tools/virt-host-validate-common.c | 43

Re: [libvirt] [PATCH 15/18] qemu_process: generate vnc unix socket in qemuProcessPrepareDomain

On Mon, Apr 04, 2016 at 03:20:32PM +0200, Pavel Hrdina wrote: > Move generation of vnc unix socket to qemuProcessPrepareDomain which is > the correct place to do those things. Now we can also test it. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_command.c| 2

Re: [libvirt] [PATCH 14/18] domain_conf: call ...ListensParseXML only for appropriate graphics

On Mon, Apr 04, 2016 at 03:20:31PM +0200, Pavel Hrdina wrote: > Instead of calling the virDomainGraphicsListensParseXML function for all > graphics types and ignore the wrong ones move the call only to graphics > types where we supports listen elements. > > Signed-off-by: Pavel Hrdina > --- > sr

Re: [libvirt] [PATCH 13/18] domain_conf: remove unused virDomainGraphicsListenGet*

On Mon, Apr 04, 2016 at 03:20:30PM +0200, Pavel Hrdina wrote: > Those are the last two places that uses the getter functions. Use a > direct access instead and remove those getters. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 58 > ++--

Re: [libvirt] [PATCH 12/18] domain_conf: cleanup virDomainGraphicsListenDefParseXML

On Mon, Apr 04, 2016 at 03:20:29PM +0200, Pavel Hrdina wrote: > Use VIR_APPEND_ELEMENT_COPY_INPLACE to add listen elements into listens > array while parsing. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 27 --- > 1 file changed, 16 insertions(+), 11 d

[libvirt] [PATCH 2/2] vz: support filesystem type volume

Vz containers are able to use ploop volumes from storage pools to work upon. To use filesystem type volume, pool name and volume name should be specifaed in Signed-off-by: Olga Krishtal --- src/storage/storage_driver.c | 3 + src/vz/vz_sdk.c | 127 +++

[libvirt] [PATCH rfc 0/2] devices: filesystem: type volume

In-Reply-To: Patches introduce the new type of filesystem device. The first patch adds the possibility to use storage pool volumes as a backend for filesystem, that is accesed from the guest. Such possibility allows to use volumes for container as a source of root directory. Usage: ...

[libvirt] [PATCH 1/2] devices: filesystems: added volume type

New type of is introduced. This patch allows to use volumes for storing the filesystem, that is accessed from the guest e.g. root directory for container. To take advantage of volumes as a backend of filesystem volume and pool names should be specified: Signed-off-by: Olga Krishtal --- src

Re: [libvirt] [PATCH 11/18] use virDomainGraphicsGetListen instead of the other getters

On Mon, Apr 04, 2016 at 03:20:28PM +0200, Pavel Hrdina wrote: > There is no point the use two different getters on the same listen > structure few lines apart. > > Signed-off-by: Pavel Hrdina > --- > src/libxl/libxl_conf.c | 15 +++ > src/qemu/qemu_command.c| 98 > ++

Re: [libvirt] [PATCH 10/18] domain_conf: cleanup virDomainGraphicsGetListen

On Mon, Apr 04, 2016 at 03:20:27PM +0200, Pavel Hrdina wrote: > Removes the check for graphics type, it's not a public API and developer > know what he's doing and this check makes no sense. It also removes > the ability to allocate a new array if there is none. This was used by > the virDomainGr

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

On Mon, 2016-02-29 at 15:41 +0100, Martin Kletzander wrote: > On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: > >  > > gcc 6.0 added an annoying warning: > >  > > fdstream.c: In function 'virFDStreamWrite': > > fdstream.c:390:29: error: logical 'or' of equal expressions > > [-Werror=lo

Re: [libvirt] [PATCH 09/18] domain_conf: remove unused virDomainGraphicsListenSetType

On Mon, Apr 04, 2016 at 03:20:26PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 16 > src/conf/domain_conf.h | 2 -- > src/libvirt_private.syms | 1 - > 3 files changed, 19 deletions(-) > ACK Jan -- libvir-list mailing list l

Re: [libvirt] [PATCH 08/18] domain_conf: introduce virDomainGraphicsListenAddNetwork

On Mon, Apr 04, 2016 at 03:20:25PM +0200, Pavel Hrdina wrote: > The same as for virDomainGraphicsListenAddAddress from previous commit > applies to this one too. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 30 +++--- > src/conf/domain_conf.h | 5

Re: [libvirt] [PATCH 07/18] domain_conf: introduce virDomainGraphicsListenAddAddress

On Mon, Apr 04, 2016 at 03:20:24PM +0200, Pavel Hrdina wrote: > This effectively removes virDomainGraphicsListenSetAddress which was > used only to change the address of listen structure and possible change > the listen type. The new function will auto-expand the listens array > and add a new list

[libvirt] [PATCH 0/2] host-validate: Don't build on Windows

The recent fixes to virt-host-validate have caused the mingw build to fail[1]. Instead of working around Windows' quirks in the tool, just stop building it altogether - it's not like it made any sense to have it available on that OS anyway. Cheers. [1] https://ci.centos.org/view/libvirt-project

[libvirt] [PATCH 2/2] configure: Make virt-host-validate optional

virt-host-validate, just like virt-login-shell, doesn't make sense on Windows, so we should avoid building it. Make the tool optional and build it by default on all platforms except Windows, erroring out if the user attempts to build it anyway. --- configure.ac | 29 ++

[libvirt] [PATCH 1/2] tools: Reorganize conditional bits

Instead of having separate handling for programs and man pages, deal with both in the same place. --- tools/Makefile.am | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 6005b8b..930e6c3 100644 --- a/tools/M

Re: [libvirt] [PATCH 06/18] domain_conf: cleanup error paths for graphics parser

On Wed, Apr 06, 2016 at 05:57:02PM +0200, Ján Tomko wrote: > On Mon, Apr 04, 2016 at 03:20:23PM +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/domain_conf.c | 100 > > ++--- > > 1 file changed, 45 insertions(+), 55 dele

Re: [libvirt] [PATCH 02/18] docs: rewrite graphics XML documentation

On Fri, Apr 08, 2016 at 11:21:17AM -0400, Cole Robinson wrote: > On 04/04/2016 09:20 AM, Pavel Hrdina wrote: > > This cleanups the documentation, reformat some of the paragraphs to use > > instead of and rewrites the listen part to be more extendable. > > > > Signed-off-by: Pavel Hrdina > > ---

Re: [libvirt] [PATCH] docs: Remove unused div.body CSS rule

On Fri, 2016-04-08 at 10:16 -0400, Cole Robinson wrote: > On 04/01/2016 05:35 AM, Andrea Bolognani wrote: > > > > The 'body' CSS class is not used anywhere in the HTML files, > > so we can get rid of the definition as well. > > --- > >  docs/generic.css | 5 - > >  1 file changed, 5 deletions(-

Re: [libvirt] [PATCH 16/18] qemu_process: move listen code out of qemuProcessSetupGraphics

On Mon, Apr 04, 2016 at 03:20:33PM +0200, Pavel Hrdina wrote: > Move adding the config listen type=address if there is none in > qemuProcessPrepareDomain and move check for multiple listens to > qemuProcessStartValidate. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_process.c | 48 ++

Re: [libvirt] [PATCH 02/18] docs: rewrite graphics XML documentation

On 04/04/2016 09:20 AM, Pavel Hrdina wrote: > This cleanups the documentation, reformat some of the paragraphs to use > instead of and rewrites the listen part to be more extendable. > > Signed-off-by: Pavel Hrdina > --- > docs/formatdomain.html.in | 351 > ++--

Re: [libvirt] [PATCH] qemu: agent: Fix incorrect and weird debug/warning log entries

On Fri, Apr 08, 2016 at 10:15:58AM +0200, Peter Krempa wrote: > Replace the nonsensical debug statement by adding the expected event > code into the existing debug statement. > > Since the monitor code always notifies the agent on guest > reboot/shutdown even if that was not initiated by the agent

Re: [libvirt] [PATCH v2] Add macro for handling exponential backoff loops.

On Fri, Apr 08, 2016 at 12:57:51PM +0100, Richard W.M. Jones wrote: > In a few places in libvirt we busy-wait for events, for example qemu > creating a monitor socket. This is problematic because: > > - We need to choose a sufficiently small polling period so that >libvirt doesn't add unnece

Re: [libvirt] [PATCH v2] Use virGetLastErrorMessage() rather than open code it

When sending a v2, please give a description of what changed compared to the previous patch version, after the --- break so it doesn't show up in the commit message. For example: On 04/04/2016 06:49 AM, Hui Yiqun wrote: > getting err using virGetLastError() and then retrieving > message from err a

[libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

The check is supposed to stop users from trying to compile virt-login-shell on Windows by erroring out during the configure phase; however, there are two flaws in it: * the value of "x$with_win" is compared to "yes" instead of "xyes" (note the "x" in the first string) * "test" is not bein

Re: [libvirt] [PATCH] docs: Remove unused div.body CSS rule

On 04/01/2016 05:35 AM, Andrea Bolognani wrote: > The 'body' CSS class is not used anywhere in the HTML files, > so we can get rid of the definition as well. > --- > docs/generic.css | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/docs/generic.css b/docs/generic.css > index c0c6215..

[libvirt] [PATCH] virt-aa-helper: disallow VNC socket read permissions

From: Simon Arlott The VM does not need read permission for its own VNC socket to create(), bind(), accept() connections or to receive(), send(), etc. on connections. https://bugzilla.redhat.com/show_bug.cgi?id=1312573 --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH 2/2] netdev: Use the correct pointer type for virSocketAddrFormat()

On Fri, 2016-04-08 at 12:44 +0300, Roman Bogorodskiy wrote: > On a related note, there's one more issue in this function related to > the peer address support addition. It contains a code like this: >  > 1466 if (peerstr) > 1467 virCommandAddArgList(cmd, "pointopoint", peerstr, NULL); >

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

On Fri, 2016-04-08 at 14:17 +0200, Peter Krempa wrote: > > doesn't 'addr' need to be checked as well? > > 'addr' is declared as ATTRIBUTE_NONNULL. Also it wasn't touched by that > patch so I don't thinkso. Right, never mind then. > > I'd like to have all of these fixed in a single patch, but > >

[libvirt] [PATCH v3] host-validate: Be more careful when checking for cgroup support

Simply checking whether the cgroup name appears somewhere inside /proc/self/cgroup is enough most of the time, but there are some corner cases that require a more mindful parsing. --- tools/virt-host-validate-common.c | 43 +-- 1 file changed, 37 insertions(+),

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

On Fri, 2016-04-08 at 13:55 +0200, Peter Krempa wrote: > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > into virNetDevSetIPAddress it crashes. Regression introduced by > b3d069872ce53eb. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325120 > --- >  src/util/vir

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

On Fri, Apr 08, 2016 at 14:11:00 +0200, Andrea Bolognani wrote: > On Fri, 2016-04-08 at 13:55 +0200, Peter Krempa wrote: > > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > > into virNetDevSetIPAddress it crashes. Regression introduced by > > b3d069872ce53eb. > > > > Resolve

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 14:55 GMT+03:00 Peter Krempa : > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > into virNetDevSetIPAddress it crashes. Regression introduced by > b3d069872ce53eb. My fail, thanks! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list mailing list lib

[libvirt] [PATCH v2] Add macro for handling exponential backoff loops.

Since v1: - Rename the macro VIR_TIME_WHILE_WITH_BACKOFF. - Split out the variable initialization into a separate function that the user must call explicitly. - The macro is now an atomic C statement. An interesting observation about the qemu monitor socket: In some cases it appears almo

[libvirt] [PATCH v2] Add macro for handling exponential backoff loops.

In a few places in libvirt we busy-wait for events, for example qemu creating a monitor socket. This is problematic because: - We need to choose a sufficiently small polling period so that libvirt doesn't add unnecessary delays. - We need to choose a sufficiently large polling period so tha

[libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL into virNetDevSetIPAddress it crashes. Regression introduced by b3d069872ce53eb. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325120 --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [PATCH v3 00/11] Introduce worker tuning APIs

On 04/04/16 23:09, Erik Skultety wrote: > since v2: > - all getters are now protected by threadpool mutex to prevent torn reads in > concurrent execution > - some checks in adminDispatchServerGetThreadpoolParameters were redundant, > thus were optimizes out > - fixed memory leak in adminDispatchSer

[libvirt] [PATCH v4 09/11] admin: Introduce virAdmServerGethreadPoolParameters

New API to retrieve current server workerpool specs. Since it uses typed parameters, more specs to retrieve can be further included in the pool of supported ones. Signed-off-by: Erik Skultety --- daemon/admin.c | 45 +++ daemon/admin_server.c |

[libvirt] [PATCH v4 10/11] admin: Introduce virAdmServerSetThreadPoolParameters

Since threadpool increments the current number of threads according to current load, i.e. how many jobs are waiting in the queue. The count however, is constrained by max and min limits of workers. The logic of this new API works like this: 1) setting the minimum a) When the limit is in

[libvirt] [PATCH v4 01/11] po: Fix record ordering in POTFILES.in

Commit a474371f broke ordering of the records. Now if a file required for translation is missing, syntax-check (po-check) will fail and suggest a patch to add the missing file. However, if the ordering is broken, the patch will be understandably inapplicable (cleanly), since the diff isn't against

[libvirt] [PATCH v4 08/11] admin: Prepare admin protocol for future worker related procedures

Before any getter or setter methods can be introduced, first specify a set of public attributes/flags that these methods will be compatible with. Signed-off-by: Erik Skultety --- include/libvirt/libvirt-admin.h | 60 + 1 file changed, 60 insertions(+) dif

[libvirt] [PATCH v4 11/11] virt-admin: Introduce srv-threadpool-info and srv-threadpool-set commands

Wire up the server threadpool tunable APIs to virt-admin client. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 185 + 1 file changed, 185 insertions(+) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index f0a49a3..38936d1 100644

[libvirt] [PATCH v4 06/11] util: Use a mutex when retrieving threadpool data

So far, the values the affected getters retrieve are static, i.e. there's no way of changing them during runtime. But admin interface will later enable not only getting but changing them as well. So to prevent phenomenons like torn reads or concurrent reads and writes of unaligned values, use mutua

[libvirt] [PATCH v4 04/11] util: Refactor thread creation by introducing virThreadPoolExpand

When either creating a threadpool, or creating a new thread to accomplish a job that had been placed into the jobqueue, every time thread-specific data need to be allocated, threadpool needs to be (re)-allocated and thread count indicators updated. Make the code clearer to read by compressing these

[libvirt] [PATCH v4 07/11] util: Add more getters to threadpool parameters

In order for the client to see all thread counts and limits, current total and free worker count getters need to be introduced. Client might also be interested in the job queue length, so provide a getter for that too. As with the other getters, preparing for the admin interface, mutual exclusion i

[libvirt] [PATCH v4 02/11] libvirt-host: Move virTypedParam* to libvirt-common

Commits 0472cef6, 9afc115f, 8cd1d546 exported typed params handlers internally, but a commit which would move the public definition from libvirt-host to libvirt-common was missing. Signed-off-by: Erik Skultety --- include/libvirt/libvirt-common.h.in | 185 +++ inc

Re: [libvirt] [PATCH] Add macro for handling exponential backoff loops.

I'm going to send a v2 of this patch in a moment which should be slightly better. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines

[libvirt] [PATCH v4 00/11] Introduce worker tuning APIs

since v3: - fixed some indentation problem in 10/11 - for some reason daemon-side APIs did not follow our function signature conventions, e.g. if the function name starts with virAdmServer (adminServer for server-side version), it means that first argument is going to be virAdmServerPtr (virNetSer

[libvirt] [PATCH v4 05/11] util: Report system error when virThreadCreateFull fails

Otherwise 'Unknown' error will be returned to client. Signed-off-by: Erik Skultety --- po/POTFILES.in | 1 + src/util/virthreadpool.c | 1 + 2 files changed, 2 insertions(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 6c17f09..d0b72be 100644 --- a/po/POTFILES.in +++ b/po/POTFIL

  1   2   >