On Mon, May 02, 2016 at 19:09:35 -0400, Cole Robinson wrote:
> If we exceed the timeout waiting for the tray status to change,
> we don't report an error. Fix it
> ---
> I hit this trying to eject floppy media for a win10 VM with F24
> qemu, but I didn't dig deeper to figure out _why_ it's timing o
On Mon, May 02, 2016 at 18:35:35 +0200, Michal Privoznik wrote:
> On 02.05.2016 16:36, Peter Krempa wrote:
> > On Fri, Apr 29, 2016 at 18:43:10 +0200, Michal Privoznik wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1139766
[...]
> > Any failure in qemuProcessReconnect results into libvir
Extend the detection of hardware virtualization to the s390 platform.
Signed-off-by: Bjoern Walk
---
tools/virt-host-validate-common.c | 3 ++-
tools/virt-host-validate-common.h | 1 +
tools/virt-host-validate-qemu.c | 21 +++--
3 files changed, 22 insertions(+), 3 deletions(
When virHostValidateCPUFlag returns NULL, that's more an unexpected
error than the sign of missing CPU flags. Let's react to this
appropriately.
Signed-off-by: Bjoern Walk
---
tools/virt-host-validate-qemu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virt-hos
This patch series adds support to the s390 platform for the virt-host-validate
tool which detects virtualization capabilities of the host.
It has been tested on x86 that no regression is introduced.
Bjoern Walk (4):
tools: virt-host-validate: fix missing translation marker
tools: virt-host-va
Let's fix CPU flag detection on s390, where the flags line begins with
a lower-case 'features'.
Signed-off-by: Bjoern Walk
---
tools/virt-host-validate-common.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/virt-host-validate-common.c
b/tools/virt-host-valid
Fix a minor typo.
Signed-off-by: Bjoern Walk
---
tools/virt-host-validate-qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c
index b96b020..eb08e7e 100644
--- a/tools/virt-host-validate-qemu.c
+++ b/tools/v
Xen 4.6 introduced a new migration stream commonly referred to as
"migration V2". Xen 4.6 and newer always produce this new stream,
whereas Xen 4.5 and older always produce the legacy stream.
Support for migration stream V2 can be detected at build time with
LIBXL_HAVE_SRM_V2 from libxl.h. The lega
Similar to "support Xen migration stream V2 in save/restore",
add support for indicating the migration stream version in
the migration code. To accomplish this, add a minimal migration
cookie in the libxl driver that is passed between source and
destination hosts. Initially, the cookie is only used
Hi all,
This patch adds support for Xen migration stream V2 to the libvirt
libxl driver. In the process it fixes save/restore and migration
tests in OSSTest, which have been failing since libvirt commit
e7440656.
Patch1 changes the libxl API requirement from version 4.2 to 4.4,
enabling use of an
In LIBXL_API_VERSION 0x040400, the libxl_domain_create_restore API
gained a parameter for specifying restore parameters. Switch to
using version 0x040400, which will be useful in a subsequent commit
to specify the Xen migration stream version when restoring.
Signed-off-by: Jim Fehlig
---
configu
On 05/02/2016 08:30 AM, Nikolay Shirokovskiy wrote:
> Daemon config parameter switch between reading host uuid
> either from smbios or machine-id:
>
> host_uuid_source = "smbios|machine-id"
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
>
> difference from version 1:
>
> * move file reading fun
On 05/02/2016 09:59 AM, Nitesh Konkar wrote:
> cmdDetachInterface function checks for live config
> flags and then passes the live/config domain xml
> to virshDomainDetachInterface accordingly.
>
> Signed-off-by: Nitesh Konkar
> ---
> tools/virsh-domain.c | 32 +++-
>
On 04/27/2016 02:29 PM, Cole Robinson wrote:
> This adds a ports= attribute to usb controller XML, like
>
>
>
> This maps to:
>
> qemu -device nec-usb-xhci,p2=8,p3=8
>
> Meaning, 8 ports that support both usb2 and usb3 devices. Gerd
> suggested to just expose them as one knob.
>
> https
On 05/02/2016 07:44 PM, John Ferlan wrote:
>
>
> On 04/27/2016 02:29 PM, Cole Robinson wrote:
>> Rather than reimplement it. This will be needed in upcoming patches
>> ---
>> src/conf/domain_conf.c| 2 +-
>> src/conf/domain_conf.h| 2 ++
>> src/libvirt_private.syms | 1 +
>>
On 04/27/2016 02:29 PM, Cole Robinson wrote:
> Reports whether we support -device nec-usb-xhci,p3=XXX value,
> which has been available since qemu 1.3.0
> ---
> src/qemu/qemu_capabilities.c | 7
> src/qemu/qemu_capabilities.h | 1 +
> tests/qemucapa
On 04/27/2016 02:29 PM, Cole Robinson wrote:
> Rather than reimplement it. This will be needed in upcoming patches
> ---
> src/conf/domain_conf.c| 2 +-
> src/conf/domain_conf.h| 2 ++
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_parse_command.c | 8 +++-
> 4 files
On 05/02/2016 09:59 AM, Nitesh Konkar wrote:
> virshDomainDetachInterface handles virsh interface
> detach from the specified live/config domain xml.
>
> Signed-off-by: Nitesh Konkar
> ---
> tools/virsh-domain.c | 104
> ++-
> 1 file changed, 61 i
If we exceed the timeout waiting for the tray status to change,
we don't report an error. Fix it
---
I hit this trying to eject floppy media for a win10 VM with F24
qemu, but I didn't dig deeper to figure out _why_ it's timing out...
src/qemu/qemu_hotplug.c | 8 +++-
1 file changed, 7 inserti
Rather than an if statement, use a switch (we're about to add more support)
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index bd564db..4
Add the ability to add an 'iothread' to the controller which will be how
virtio-scsi-pci and virtio-scsi-ccw iothreads have been implemented in qemu.
Describe the new functionality and add tests to parse/validate that the
new attribute can be added.
Signed-off-by: John Ferlan
---
docs/formatdom
An iothread for virtio-scsi is a property of the controller. Add a lookup
of the 'virtio-scsi-pci' and 'virtio-scsi-ccw' device properties and parse
the output. For both, support for the iothread was added in qemu 2.4
while support for virtio-scsi in general was added in qemu 1.4.
Modify the vari
Move virDomainControllerModelTypeToString closer to it's counterpart
virDomainControllerModelTypeFromString.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Repost of :
http://www.redhat.com/archives/libvir-list/2016-April/msg01539.html
Essentially the same patches as previous, but refreshed to current HEAD
of '6620cd1ef'. I did remove patch 5 since it's not necessary. Also
had to adjust one test to add the new default panic device for ccw.
John Fe
Signed-off-by: John Ferlan
---
docs/formatdomain.html.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bead624..735546e 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2561,8 +2561,9
https://bugzilla.redhat.com/show_bug.cgi?id=1286709
Now that we have all the pieces in place, we can add the 'iothread=#' to
the command line for the (two) controllers that support it (virtio-scsi-pci
and virtio-scsi-ccw). Add the tests as well...
Signed-off-by: John Ferlan
---
src/qemu/qemu_co
Reformat to use elements to make it a bit easier to read.
Signed-off-by: John Ferlan
---
docs/formatdomain.html.in | 49 ---
1 file changed, 29 insertions(+), 20 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 73
On 05/02/2016 09:14 AM, Shivaprasad G Bhat wrote:
> On PPC64, the KVM_MAX_VCPUS is defined to be 1024 where as qemu has
> MAX_CPUMASK_BITS defined at 255 in include/sysemu/sysemu.h.
>
> virsh domacapabilities and virsh maxvcpus --type kvm return different
> maxvcpus values and is confusing as to k
Create helper API's in order to build the network URI as shortly we will
be adding a new SecretInfo type
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 90 +
1 file changed, 69 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_co
Rather than need to call qemuDomainSecretDestroy after any call to
qemuProcessLaunch, let's do the destroy in qemuProcessLaunch since
that's where command line is eventually generated and processed. Once
it's generated, we can clear out the secrets.
Signed-off-by: John Ferlan
---
src/qemu/qemu_p
>From a review after push, add the "_TYPE" into the name.
Also use qemuDomainSecretInfoType in the struct rather than int
with the comment field containing the struct name
Signed-off-by: John Ferlan
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 6 +++---
2 files changed, 4 inserti
Commit id '40d8e2ba3' added the function to qemuProcessStart because
in order to set up some secrets in the future we will need the master
key. However, since the previous patch split the master key creation
into two parts (create just the key and create the file), we can now
call qemuDomainSecretP
https://bugzilla.redhat.com/show_bug.cgi?id=1182074
If they're available and we need to pass secrets to qemu, then use the
qemu domain secret object in order to pass the secrets for iSCSI and
RBD volumes instead of passing plaintext or base64 encoded secrets on
the command line.
Adjust the qemuDo
Add the data structure and infrastructure to support an initialization
vector (IV) secrets. The IV secret generation will need to have access
to the domain private master key, so let's make sure the prepare disk
and hostdev functions can accept that now.
Anywhere that needs to make a decision over
New APIs:
qemuDomainGetIVKeyAlias:
Generate/return the secret object alias for an initialization
vector (IV) secret info type. This will be saved in the secret
info block. This will be called from qemuDomainSecretIVSetup.
qemuDomainSecretHaveEncrypt:
Boolean function to determ
v1 here (specifically patches 11 & 12)
http://www.redhat.com/archives/libvir-list/2016-April/msg01077.html
What's new/changed:
Patches 1-3 address comments made by Jan in his review of v1.
Patch 4 is essentially following through on the Patch 3 comment
Patch 5 was part of patch 11, but I split
A recent review of related changes noted that we should split the creation
(or generation) of the master key into the qemuProcessPrepareDomain and leave
the writing of the master key for qemuProcessPrepareHost.
Made the adjustment and modified some comments to functions that have
changed calling p
2016-04-29 19:12 GMT+03:00 Maxim Nestratov :
> I wonder, if my reply clarify the original message or it's still unclear and
> it's better to step back more and describe the problem in more details?
Yes, may be i'm interesting in this feature too, but i can miss
something. Does you want to allow f
On 05/02/2016 10:41 AM, Ján Tomko wrote:
On Fri, Apr 29, 2016 at 01:09:26PM -0400, Cole Robinson wrote:
On 04/29/2016 10:01 AM, Shivaprasad G Bhat wrote:
The default USB controller is not sent to destination as the older versions
of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) d
On 02.05.2016 16:36, Peter Krempa wrote:
> On Fri, Apr 29, 2016 at 18:43:10 +0200, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1139766
>>
>> Thing is, for some reasons you can have your domain's RTC to be
>> in something different than UTC. More weirdly, it's not only tim
On 29.04.2016 15:45, Erik Skultety wrote:
> This method just aggregates various client object attributes, like socket
> address, connection type (RO/RW), and some TCP/TLS/UNIX identity in an atomic
> manner.
>
> Signed-off-by: Erik Skultety
> ---
> src/rpc/virnetserverclient.c | 26 +
On 29.04.2016 15:45, Erik Skultety wrote:
> We do have a similar method, serving the same purpose, for TLS, but we lack
> one for SASL. So introduce one, in order for other modules to be able to find
> out, if a SASL session is active, or better said, that a SASL session exists
> at all.
>
> Signe
On 29.04.2016 15:45, Erik Skultety wrote:
> Wire-up the client identity getter into virt-admin tool. This patch adjusts
> man-page accordingly.
>
> Signed-off-by: Erik Skultety
> ---
> tools/virt-admin.c | 91
> ++
> 1 file changed, 91 inserti
On 29.04.2016 15:45, Erik Skultety wrote:
> This series adds support for client identity retrieval, i.e. information like
> remote IP (if connected remotely), uid,gid,pid, as well as username if
> connected locally and also information regarding authentication (if used).
>
> The series is rebased
On Mon, 2016-05-02 at 17:01 +0200, Ján Tomko wrote:
> On Mon, May 02, 2016 at 01:51:24PM +0200, Andrea Bolognani wrote:
> >
> > Changes from [v1]:
> >
> > * look for systemctl(1) to detect systemd instead of relying
> > on whether or not the /etc/systemd directory is present,
> > as sug
On Mon, 2016-05-02 at 17:01 +0200, Ján Tomko wrote:
> On Mon, May 02, 2016 at 01:51:26PM +0200, Andrea Bolognani wrote:
> >
> > Most distributions, including RHEL, have switched to systemd,
> > so we should detect it and act accordingly. This also means
> > that 'systemd+redhat' should be preferre
On Fri, 2016-04-29 at 15:23 +0200, Boris Fiuczynski wrote:
> S390 architecture inherently provides a crash detection capability
> which has not been reflected in the domain xml.
> This series adds an s390 model to the panic device which does not
> allow an address to be specified and is by default
On Mon, May 02, 2016 at 01:51:24PM +0200, Andrea Bolognani wrote:
> Changes from [v1]:
>
> * look for systemctl(1) to detect systemd instead of relying
> on whether or not the /etc/systemd directory is present,
> as suggested by Martin
>
> * use 'systemd+redhat' instead of plain 'syst
On Mon, May 02, 2016 at 01:51:26PM +0200, Andrea Bolognani wrote:
> Most distributions, including RHEL, have switched to systemd,
> so we should detect it and act accordingly. This also means
> that 'systemd+redhat' should be preferred to legacy 'redhat'.
>
> Our witness for the check is the avail
On 02.05.2016 16:19, Erik Skultety wrote:
>>> diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
>>> index 57bd95c..8216da6 100644
>>> --- a/src/rpc/virnetserver.c
>>> +++ b/src/rpc/virnetserver.c
>>> @@ -65,6 +65,7 @@ struct _virNetServer {
>>>
>>> size_t nclients;
On Fri, Apr 29, 2016 at 18:43:09 +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_monitor.c | 11 +++
> src/qemu/qemu_monitor.h | 3 +++
> src/qemu/qemu_monitor_json.c | 45
>
> src/qemu/qemu_mo
On Fri, Apr 29, 2016 at 01:09:26PM -0400, Cole Robinson wrote:
> On 04/29/2016 10:01 AM, Shivaprasad G Bhat wrote:
> > The default USB controller is not sent to destination as the older versions
> > of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) didn't
> > support them. For some ar
On Fri, Apr 29, 2016 at 18:43:10 +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1139766
>
> Thing is, for some reasons you can have your domain's RTC to be
> in something different than UTC. More weirdly, it's not only time
> zone what you can shift it of, but an arbi
---
src/conf/domain_conf.c | 52
src/conf/domain_conf.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 56 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 23ff887..48a220f 100644
--- a/src/conf/domain
This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4.
We can't just add checks to the XML parser once we've accepted such
configuration in the past.
---
src/conf/domain_conf.c | 22 --
tests/qemuxml2argvtest.c | 3 +--
2 files changed, 1 insertion(+), 24 deletions(-
---
src/qemu/qemu_command.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 110ee19..0f0427f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -879,7 +879,7 @@ qemuCheckDiskConfig(vi
In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just
as a glorified version of virStorageSourceIsBlockLocal that reports
error messages. Replace it with the latter including the message for
clarity.
---
src/qemu/qemu_command.c | 6 +-
1 file changed, 5 insertions(+), 1 dele
Extract the relevant parts of the existing checker and reuse them for
blockcopy since copying to a non-block device creates an invalid
configuration.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1209802
---
src/qemu/qemu_command.c | 14 +-
src/qemu/qemu_domain.c | 31 +++
Commit 36025c552 tried to improve error reporting for
but reused the code in LXC which doesn't care about the actual disk
type. The error messages would then contain a bogous hint that the
config for the 'lun' device is invalid which might not be the case.
Re-do the relevant portion of the commit
For disks sources described by a libvirt volume we don't need to do a
complicated check since virStorageTranslateDiskSourcePool already
correctly determines the actual disk type.
Replace the checks using a new accessor that does not open-code the
whole logic.
---
src/libvirt_private.syms | 1 +
Commit c820fbff9fbfe1f2549a5b60967496587f8d8bfc added support for iSCSI
disk as backing for . We would not use it for a disk
type="volume" with direct access mode which basically maps to direct
iSCSI usage. Fix it by adding the storage source type accessor that
resolves the volume type.
---
src/qe
Fix a few invalid error messages, remove code that would make certain configs
vanish and reject block copy to a regular file.
Peter Krempa (8):
util: Replace virDomainDiskSourceIsBlockType with a new helper
lxc: Fix wrong error message on disk hotplug
qemu: Support for iSCSI direct mapped v
On 05/02/2016 04:48 AM, Michal Privoznik wrote:
> On 25.04.2016 20:46, Cole Robinson wrote:
>> Let's us de-nest some of the logic, and will simplify upcoming
>> patches
>> ---
>> src/fdstream.c | 73
>> +-
>> 1 file changed, 42 insertions(+)
These dependencies are optional but default to enabled, so if you
shouldn't have to explicitly have to mention them when you run
configure.
---
configure.ac | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8a3
I had some trouble building it and ended up with these patches; they
basically just fix up the configure checks so that they find things
which would later cause the build to fail.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Fixes a handful of errors such as this one:
gtk-doc.make:7: error: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
index 00c2d7e..8a34620 100644
--- a/configure.ac
+++ b/configure.ac
@@ -74
>> diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
>> index 57bd95c..8216da6 100644
>> --- a/src/rpc/virnetserver.c
>> +++ b/src/rpc/virnetserver.c
>> @@ -65,6 +65,7 @@ struct _virNetServer {
>>
>> size_t nclients;/* Current clients count */
>> virNetSer
On 29.04.2016 14:39, Erik Skultety wrote:
> Admin API needs a way of addressing specific clients. Unlike servers, which we
> are happy to address by names both because its name reflects its purpose (to
> some extent) and we only have two of them (so far), naming clients doesn't
> make
> any sense,
On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote:
> On 05/02/2016 07:38 AM, Ján Tomko wrote:
> > On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote:
> >> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> >> index 81d86c2..c9f43fa 100644
> >> --- a/src/qemu/qemu_pr
On Mon, May 02, 2016 at 10:08:10AM -0400, John Ferlan wrote:
>
>
> On 05/02/2016 09:52 AM, Ján Tomko wrote:
> > On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote:
> >> On 05/02/2016 07:38 AM, Ján Tomko wrote:
> >>> On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote:
> diff
On 05/02/2016 09:47 AM, Ján Tomko wrote:
> On Sat, Apr 16, 2016 at 10:17:45AM -0400, John Ferlan wrote:
>> +/* qemuDomainSecretInfoGetAlias:
>> + * @secinfo: pointer to the secret info object
>> + * @qemuCaps: pointer to the emulator capabilities
>> + *
>> + * If the emulator supports it, secinfo
virshDomainDetachInterface handles virsh interface
detach from the specified live/config domain xml.
Signed-off-by: Nitesh Konkar
---
tools/virsh-domain.c | 104 ++-
1 file changed, 61 insertions(+), 43 deletions(-)
diff --git a/tools/virsh-domain
On 29.04.2016 14:39, Erik Skultety wrote:
> Wire-up the public client listing API. Along with this change, a private time
> simple conversion method to interpret client's timestamp obtained from server
> has been added as well. Format used to for time output is as follows:
> -mm-DD HH:MM:SS+ZZZ
On 05/02/2016 09:52 AM, Ján Tomko wrote:
> On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote:
>> On 05/02/2016 07:38 AM, Ján Tomko wrote:
>>> On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote:
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 81d86
cmdDetachInterface function checks for live config
flags and then passes the live/config domain xml
to virshDomainDetachInterface accordingly.
Signed-off-by: Nitesh Konkar
---
tools/virsh-domain.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --gi
The virsh attach virsh detach interface command fails
when both live and config are set and when the interface
gets attached to different pci slots on live and config
xml respectively.
When we attach an interface with both --live and --config,
the first time they get the same PCI slots, but the se
On 29.04.2016 14:39, Erik Skultety wrote:
> v2:
> - gendispatch was modified to be able to generate more client related code
>
> - Martin noticed that I added avahi-related field into my tests which caused
> the tests to fail for him, since he doesn't compile with avahi - fixed
>
> - coverity com
On Sat, Apr 16, 2016 at 10:17:45AM -0400, John Ferlan wrote:
> +/* qemuDomainSecretInfoGetAlias:
> + * @secinfo: pointer to the secret info object
> + * @qemuCaps: pointer to the emulator capabilities
> + *
> + * If the emulator supports it, secinfo is available and associated with
> + * an IV secr
On PPC64, the KVM_MAX_VCPUS is defined to be 1024 where as qemu has
MAX_CPUMASK_BITS defined at 255 in include/sysemu/sysemu.h.
virsh domacapabilities and virsh maxvcpus --type kvm return different
maxvcpus values and is confusing as to know what actually works.
Signed-off-by: Shivaprasad G Bhat
On 05/02/2016 07:38 AM, Ján Tomko wrote:
> On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote:
>> Rather than needing to pass the conn parameter to various command
>> line building API's, add qemuDomainSecretPrepare just prior to the
>> qemuProcessLaunch which calls qemuBuilCommandLine.
Daemon config parameter switch between reading host uuid
either from smbios or machine-id:
host_uuid_source = "smbios|machine-id"
Signed-off-by: Nikolay Shirokovskiy
---
difference from version 1:
* move file reading function to virfile.c and generalize it
* change comments and documentation a
If we didn't find a match, either because we're cross compiling
or because we're not building on RHEL, we won't install any
init script.
Make sure this is reported correctly in the configure summary.
---
configure.ac | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff
Changes from [v1]:
* look for systemctl(1) to detect systemd instead of relying
on whether or not the /etc/systemd directory is present,
as suggested by Martin
* use 'systemd+redhat' instead of plain 'systemd' on RHEL
* move everything to a macro tucked away in a separate file
Tes
Move the code dealing with init scripts to a separate file
so configure.ac itself can be a little bit smaller.
---
First time writing an autoconf macro, so I might very possibly
have gotten something wrong. It seems to be working, though
configure.ac | 63 ++-
Most distributions, including RHEL, have switched to systemd,
so we should detect it and act accordingly. This also means
that 'systemd+redhat' should be preferred to legacy 'redhat'.
Our witness for the check is the availability of the systemctl
command on the host.
---
configure.ac | 8
On 05/02/2016 07:17 AM, Ján Tomko wrote:
> On Sat, Apr 16, 2016 at 10:17:34AM -0400, John Ferlan wrote:
>> Introduce a new private structure to hold qemu domain auth/secret data.
>> This will be stored in the qemuDomainDiskPrivate as a means to store the
>> auth and fetched secret data rather tha
On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote:
> Rather than needing to pass the conn parameter to various command
> line building API's, add qemuDomainSecretPrepare just prior to the
> qemuProcessLaunch which calls qemuBuilCommandLine. The function
> must be called after qemuProcessP
On Mon, 2016-05-02 at 10:19 +0200, Martin Kletzander wrote:
> On Mon, May 02, 2016 at 09:42:58AM +0200, Michal Privoznik wrote:
> > On 15.04.2016 17:03, Cédric Bosdonnat wrote:
> > > Introducing keepalive_interval = -1 breaks to augeas lens. Fix
> > > the lens
> > > by allowing signed ints in the r
On Sat, Apr 16, 2016 at 10:17:34AM -0400, John Ferlan wrote:
> Introduce a new private structure to hold qemu domain auth/secret data.
> This will be stored in the qemuDomainDiskPrivate as a means to store the
> auth and fetched secret data rather than generating during building of
> the command li
On 28.04.2016 16:26, Martin Kletzander wrote:
> v3:
> - Actually use virPCIDeviceAddress. It was actually ACKed with that
>changed but I feel like it's way too big of a change for just
>pushing it. Also, I'm in no rush with this, so I'l gladly wait
>after therelease with this.
>
> v
On 04/16/2016 10:17 AM, John Ferlan wrote:
> v1: http://www.redhat.com/archives/libvir-list/2016-April/msg00596.html
>
> Differences since v1:
>
> - Add qemuBuildiSCSICommandLine (and BuildDiskiSCSI && BuildHostdeviSCSI)
>These will do the magic necessary in order to support IV secret obje
The first patch do all the job. It is rather large but does not touch
any existing code so I found it reasonable not to split it.
Nikolay Shirokovskiy (2):
vz: add domain snapshots functionality
vz: drop prlsdkDomainHasSnapshots
src/libvirt_private.syms | 2 +
src/vz/vz_driver.c | 53
Let's use introduced domain snapshots infrastructure instead.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 87 -
1 file changed, 18 insertions(+), 69 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 23b9277..e
This solution does not keep snapshots cache because vz sdk lacks good support
for snapshot related events.
Libvirt and vz sdk has different approach to snapshot ids. vz sdk always
auto generate them while libvirt has ability to specify id by user.
Thus I have no other choice rather than simply ign
On 25.04.2016 20:46, Cole Robinson wrote:
> Let's us de-nest some of the logic, and will simplify upcoming
> patches
> ---
> src/fdstream.c | 73
> +-
> 1 file changed, 42 insertions(+), 31 deletions(-)
>
> diff --git a/src/fdstream.c b/src
On 25.04.2016 20:46, Cole Robinson wrote:
> This is the only place in daemon/stream.c that sets
> 'stream->closed = true' but neglects to actually abort the stream
> and remove the callback, which seems wrong.
> ---
> daemon/stream.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dae
On 25.04.2016 20:46, Cole Robinson wrote:
> This series attempts to address various stream finish/abort error
> reporting issues:
>
> * Unclear error messages
> * virStreamAbort always returns an error
> * Spurious errors logged on the daemon side
> * Various issues in stream error cleanup (found
On Mon, May 02, 2016 at 09:42:58AM +0200, Michal Privoznik wrote:
On 15.04.2016 17:03, Cédric Bosdonnat wrote:
Introducing keepalive_interval = -1 breaks to augeas lens. Fix the lens
by allowing signed ints in the regular expression.
---
daemon/libvirtd.aug | 2 +-
1 file changed, 1 insertion(+
On 15.04.2016 17:03, Cédric Bosdonnat wrote:
> Introducing keepalive_interval = -1 breaks to augeas lens. Fix the lens
> by allowing signed ints in the regular expression.
> ---
> daemon/libvirtd.aug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/daemon/libvirtd.aug b/da
On Sun, May 01, 2016 at 09:42:20 +0300, Yuri Chornoivan wrote:
> Just a quick note about translations. It is very discouraging to see the
> release dated with 2016 with translations dated back in 2014. Personally,
> I worked hard to update translation to the latest catalog from Zanata just
>
1 - 100 of 101 matches
Mail list logo
