On Tue, May 17, 2016 at 12:36:06 -0400, John Ferlan wrote:
> v3:
>
> http://www.redhat.com/archives/libvir-list/2016-May/msg00444.html
>
> Changes since v3 (by patch)...
>
> 1. Separate out the mock for virRandomBytes. I realize this is not the
>desired state, but figured to at least be pre
According to QEMU docs, the '-m' option for specifying RAM is by default
in MiB, and a suffix of "M" or "G" may be passed for values in MiB and
GiB respectively. This commit adds support and a test for the same.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=812295
Signed-off-by: Nishith S
Move the parsing of -m memory to a new function, qemuParseCommandLineMem
Signed-off-by: Nishith Shah
---
src/qemu/qemu_parse_command.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
This series moves the parsing of qemu -m memory into a separate function
and adds suffix support for the -m option.
The first patch introduces the function qemuParseCommandLineMem, and the
second patch handles suffixes for the -m values and adds a test for the
same.
Nishith Shah (2):
qemu: pars
On Tue, May 17, 2016 at 16:55:53 -0400, John Ferlan wrote:
> On 05/17/2016 10:25 AM, Peter Krempa wrote:
> > Recently I NACKed quite a few patches attempting to add checks to the post
> > parse callback infrastructure that would inhbit configs from being loaded
> > after daemon restart.
> >
> > To
On Tue, May 17, 2016 at 11:31:07 -0400, John Ferlan wrote:
> On 05/17/2016 11:04 AM, Peter Krempa wrote:
> > On Mon, May 16, 2016 at 11:03:09 -0400, John Ferlan wrote:
[...]
> >> +
> >> +virReportError(VIR_ERR_INTERNAL_ERROR,
> >> + _("'%s --mode session' une
On Tue, May 17, 2016 at 23:04:19 -0600, Jim Fehlig wrote:
> On 05/17/2016 08:25 AM, Peter Krempa wrote:
> > Recently there were a few patches adding checks to the post parse
> > callback infrastructure that rejected previously accepted configuration.
> > This unfortunately was not acceptable since
On 05/17/2016 08:25 AM, Peter Krempa wrote:
> Recently there were a few patches adding checks to the post parse
> callback infrastructure that rejected previously accepted configuration.
> This unfortunately was not acceptable since we would fail to load the
> configs from the disk and the VMs woul
On 05/17/2016 07:44 AM, Nikolay Shirokovskiy wrote:
> This patch aims to fix observed crash on daemon shutdown. Main thread is in
> the process of state drivers cleanup, network driver is cleaned up and
> qemu driver is not yet. Meanwhile eof event from qemu process triggers
> qemuProcessStop -> ne
On 05/17/2016 10:25 AM, Peter Krempa wrote:
> Recently I NACKed quite a few patches attempting to add checks to the post
> parse callback infrastructure that would inhbit configs from being loaded
> after daemon restart.
>
> To solve this introduce a new infrastructure that will get called only
On 05/17/2016 10:25 AM, Peter Krempa wrote:
> Recently there were a few patches adding checks to the post parse
> callback infrastructure that rejected previously accepted configuration.
> This unfortunately was not acceptable since we would fail to load the
> configs from the disk and the VMs wo
Chunyan Liu wrote:
> Correct libxl config file type=vif handling.
>
> ---
> Changes in v2:
> * update xen{Parse,Format}ConfigCommon parameter vif_typename to
> nativeFomat. To reuse XEN_CONFIG_FORMAT_{XM,XL}, first extract
> XEN_CONFIG_FORMAT_{XM,XL} to xen_common.h
>
> Chunyan Liu (3):
Chunyan Liu wrote:
> According to current xl.cfg docs and xl codes, it uses type=vif
> instead of type=netfront.
>
> Currently after domxml-to-native, libvirt xml model=netfront will be
> converted to xl type=netfront. This has no problem before, xen codes
> for a long time just check type=ioemu,
On 05/16/2016 06:00 PM, Andrea Bolognani wrote:
> The only case where the hardware capabilities influence the result
> is when no element was provided.
>
> The test programs now ensure both that the correct GIC version is
> picked in that case, and that hardware capabilities are not taken
> int
On 05/16/2016 06:00 PM, Andrea Bolognani wrote:
> Now that we choose the GIC version based on hardware features when
> no element has been provided, we need a way to fake the GIC
> capabilities of the host.
>
> Update the qemuxml2argv and qemuxml2xml tests to allow this.
> ---
> tests/qemuxml2
On 05/16/2016 06:00 PM, Andrea Bolognani wrote:
> This utility function extracts some of the logic from
> virQEMUCapsFillDomainFeatureGICCaps() so that it can be used
> in a different context.
> ---
> src/qemu/qemu_capabilities.c | 62
>
> src/qemu/q
On 05/16/2016 06:00 PM, Andrea Bolognani wrote:
> For use in the test suite.
> ---
> src/qemu/qemu_capabilities.c | 29 +
> src/qemu/qemu_capabilities.h | 5 +
> 2 files changed, 30 insertions(+), 4 deletions(-)
>
ACK
John
--
libvir-list mailing list
libvir-l
On 05/16/2016 06:00 PM, Andrea Bolognani wrote:
> When the element in not present in the domain XML, use the
> domain capabilities to figure out what GIC version is usable and
> choose that one automatically.
>
> This allows guests to be created on hardware that only supports
> GIC v3 without h
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
vz puts uuids into curly braces. Simply introduce new contstant to reflect this
and get rid of magic +2 in code.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 12 ++--
src/vz/vz_utils.h | 2 ++
2 files changed, 8 insertio
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
Peer to peer migration is implemented just as in managed case. Basically
it is copy paste from managed case but with all the branches that are not
applied to vz removed.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_driver.c | 139 ++
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
The newest version of migration protocol - version 3 with parameters is
implemented.
Supported flags is VIR_MIGRATE_PAUSED only. Supported parameters are
VIR_MIGRATE_PARAM_URI and VIR_MIGRATE_PARAM_DEST_NAME.
VIR_MIGRATE_PARAM_DEST_XML
is in VZ_MI
On 05/17/2016 01:20 PM, Andrea Bolognani wrote:
> On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
>> hotplug APIs with the AFFECT_CONFIG flag are essentially replicating
>> 'insert into XML document, and redefine XML'. Thinking of
>> it this way, it's natural that we call virDomainDefPostP
Fabian Freyer wrote:
> These patches implement some rather trivial missing calls in the bhyve driver.
>
> Since the bhyve connection (Interaction through /dev/vmm as well as the
> bhyveload, bhyvectl user-space tools) is local, encryption is not applicable,
> but the connection is seen as not
On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
> hotplug APIs with the AFFECT_CONFIG flag are essentially replicating
> 'insert into XML document, and redefine XML'. Thinking of
> it this way, it's natural that we call virDomainDefPostParse after
> manually editing the XML here.
>
> Not
https://bugzilla.redhat.com/show_bug.cgi?id=1182074
If they're available and we need to pass secrets to qemu, then use the
qemu domain secret object in order to pass the secrets for RBD volumes
instead of passing the base64 encoded secret on the command line.
The goal is to make AES secrets the d
A different model will be posted soon...
Essentially this is way to test/show that a not so random key and iv
will generate a consistent value.
This version uses the setting of the key to the array index rather than
-1 for every entry. Thus a key/iv would be 0x000102030405... etc.
Signed-off-by:
New APIs:
qemuDomainGetAESKeyAlias:
Generate/return the secret object alias for an AES Secret Info type.
This will be called from qemuDomainSecretAESSetup.
qemuDomainSecretHaveEncrypt: (private)
Boolean function to determine whether the underly encryption
API is available. Thi
v3:
http://www.redhat.com/archives/libvir-list/2016-May/msg00444.html
Changes since v3 (by patch)...
1. Separate out the mock for virRandomBytes. I realize this is not the
desired state, but figured to at least be prepared for what would be
coming as a followup to:
http://www.redhat.c
On 05/16/2016 06:05 PM, Jim Fehlig wrote:
Chun Yan Liu wrote:
On 5/14/2016 at 07:47 AM, in message <5736677d.8030...@suse.com>, Jim Fehlig
wrote:
On 05/13/2016 12:21 AM, Chunyan Liu wrote:
Add .domainInterfaceAddresses so that user can have a way to
get domain interface address by 'virsh dom
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_utils.c | 2 +-
src/vz/vz_utils.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vz/vz_utils.c b/src/vz/vz_utils.c
index ae99aa0..4b82c62 100644
--- a/src/vz/vz_utils.
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
This session uuid acts as authN token for different multihost vz operations one
of which is migration. Unfortunately we can't get it from server at any time
thus we need to save it at login.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c
On 05/15/2016 05:51 PM, Cole Robinson wrote:
> It was only needed for rpm versions that are much older than our
> minimally supported distro
>
> Some more details here: https://fedorahosted.org/fpc/ticket/77
> ---
> libvirt.spec.in | 27 ---
> 1 file changed, 27 deletion
On 05/17/2016 11:24 AM, John Ferlan wrote:
>
>
> On 05/13/2016 10:52 AM, Ján Tomko wrote:
>>
>> /path/to/acpi/table/file
>>
>>
>> will result in:
>>
>> -acpitable sig=SLIC,file=/path/to/acpi/table/file
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1327537
>> ---
>> src/qemu/qemu_command.
On 05/17/2016 11:04 AM, Peter Krempa wrote:
> On Mon, May 16, 2016 at 11:03:09 -0400, John Ferlan wrote:
>> Utilize the exit status parameter for virCommandRunRegex in order to
>> check the return error from the 'iscsiadm --mode session' command.
>> Without this enabled, if there are no sessions
On 05/13/2016 10:52 AM, Ján Tomko wrote:
> Add support for the slic_able to the security drivers.
^
Extra space
> ---
> src/security/security_dac.c | 5 +
> src/security/security_selinux.c | 5 +
> src/security/virt-aa-helper.c | 4
> 3 files c
On 05/13/2016 10:52 AM, Ján Tomko wrote:
>
> /path/to/acpi/table/file
>
>
> will result in:
>
> -acpitable sig=SLIC,file=/path/to/acpi/table/file
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1327537
> ---
> src/qemu/qemu_command.c | 4
> tests/qemuxml2
17.05.2016 18:09, Michal Privoznik пишет:
On 17.05.2016 11:36, Maxim Nestratov wrote:
fix numerous inlining errors like:
In file included from vircgroupmock.c:24:0:
In function 'stat':
virmock.h:259:1: error: inlining failed in call to 'callStat.part.1':
call is unlikely and code size would gr
On 05/13/2016 10:52 AM, Ján Tomko wrote:
> Add a new element to XML:
>
> /path/to/acpi/table/file
>
>
> To supply a path to a SLIC (Software Licensing) ACPI
> table blob.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1327537
> ---
> docs/formatdomain.html.in |
On 05/13/2016 10:52 AM, Ján Tomko wrote:
> Split out parsing of most of the subelements into a separate
> function.
> ---
> src/conf/domain_conf.c | 146
> -
> 1 file changed, 83 insertions(+), 63 deletions(-)
>
ACK
John
--
libvir-list mailin
On 17.05.2016 11:36, Maxim Nestratov wrote:
> fix numerous inlining errors like:
>
> In file included from vircgroupmock.c:24:0:
> In function 'stat':
> virmock.h:259:1: error: inlining failed in call to 'callStat.part.1':
> call is unlikely and code size would grow [-Werror=inline]
> callStat(in
On Mon, May 16, 2016 at 11:03:09 -0400, John Ferlan wrote:
> Utilize the exit status parameter for virCommandRunRegex in order to
> check the return error from the 'iscsiadm --mode session' command.
> Without this enabled, if there are no sessions running then virCommandRun
> would have displayed a
On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
> All these calls come near immediately after parsing the domain
> XML, which now triggers qemuDomainAssignAddresses. So drop the
> now redundnat calls
> ---
> src/qemu/qemu_driver.c | 19 ---
> 1 file changed, 19 deletions(-)
On 05/17/2016 08:40 AM, Vasiliy Tolstov wrote:
2016-05-17 15:33 GMT+03:00 Cole Robinson :
I think Laine was saying 'I personally don't care about ->script so I'm not
planning on implementing it',
My position is a bit stronger than that. It's not that I don't want to
spend the effort. It's tha
On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
> This wires up qemuDomainAssignAddresses into the new
> virDomainDefAssignAddressesCallback, so it's always triggered
> via virDomainDefPostParse. We are essentially doing this already
> with open coded calls sprinkled about
Missing period.
On 16.05.2016 10:19, Olga Krishtal wrote:
The modification of .volWipe callback wipes ploop volume using one of
given wiping algorithm: dod, nnsa, etc.
However, in case of ploop volume we need to reinitialize root.hds and
DiskDescriptor.xml.
Signed-off-by: Olga Krishtal
---
src/storage/sto
On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
> This will be called at the end of virDomainDefPostParse to fill
> allow hypervisor drivers to fill in device addresses.
Too many "fill"s ;)
> ---
> src/conf/domain_conf.c | 7 +++
> src/conf/domain_conf.h | 8
> 2 files chang
On Tue, May 17, 2016 at 15:44:40 +0200, Jiri Denemark wrote:
> The INPLACE variants of the VIR_APPEND macros cannot fail and they are
> inherently quiet.
>
> Signed-off-by: Jiri Denemark
> ---
> src/conf/domain_conf.c | 2 +-
> src/qemu/qemu_hotplug.c | 2 +-
> src/util/viralloc.h | 25 ++
Similarly to domain definition it would be possible to introduce
invalid config via device coldplug. Add a similar infrastructure to do
the checking.
---
src/conf/domain_conf.c | 52 +---
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1
Recently there were a few patches adding checks to the post parse
callback infrastructure that rejected previously accepted configuration.
This unfortunately was not acceptable since we would fail to load the
configs from the disk and the VMs would vanish.
This patch adds helpers which are called
---
src/qemu/qemu_driver.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 37d970e..7f8dfc8 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7241,7 +7241,10 @@ qemuDomainCreate(virDomai
Now that we have a good place for this check let's move it there.
---
src/conf/domain_conf.c | 11 +++
src/conf/domain_conf.h | 6 ++
src/libvirt_private.syms | 1 -
src/qemu/qemu_process.c | 3 ---
4 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain
Now that we have a good place for this check let's move it there.
---
src/qemu/qemu_domain.c | 6 ++
src/qemu/qemu_process.c | 6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 5ccb483..f172d6f 100644
--- a/src/qemu/
Name the validation function distinctively since it's called in the
parser. Later patches will add function that will validate disk
definitions that are invalid but need to be parsed to avoid losing
domains.
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Recently I NACKed quite a few patches attempting to add checks to the post
parse callback infrastructure that would inhbit configs from being loaded
after daemon restart.
To solve this introduce a new infrastructure that will get called only on
codepaths that define and start the config leaving th
On Tue, May 17, 2016 at 15:39:17 +0200, Jiri Denemark wrote:
> It was just a useless wrapper around VIR_APPEND_ELEMENT*.
>
> Signed-off-by: Jiri Denemark
> ---
> src/conf/domain_conf.c | 12
> src/conf/domain_conf.h | 3 ---
> src/libvirt_private.syms | 1 -
> src/qemu/qemu_dr
The INPLACE variants of the VIR_APPEND macros cannot fail and they are
inherently quiet.
Signed-off-by: Jiri Denemark
---
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_hotplug.c | 2 +-
src/util/viralloc.h | 25 +++--
3 files changed, 13 insertions(+), 16 deletions(-)
It was just a useless wrapper around VIR_APPEND_ELEMENT*.
Signed-off-by: Jiri Denemark
---
src/conf/domain_conf.c | 12
src/conf/domain_conf.h | 3 ---
src/libvirt_private.syms | 1 -
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_hotplug.c | 3 +--
5 files changed, 2 inser
On Tue, May 17, 2016 at 15:09:51 +0200, Michal Privoznik wrote:
> On 17.05.2016 14:19, Cole Robinson wrote:
> > On 05/17/2016 08:10 AM, Cole Robinson wrote:
> >> On 05/17/2016 04:39 AM, Michal Privoznik wrote:
> >>> On 03.05.2016 01:09, Cole Robinson wrote:
[...]
> > Well I guess that explains it
On 17.05.2016 14:19, Cole Robinson wrote:
> On 05/17/2016 08:10 AM, Cole Robinson wrote:
>> On 05/17/2016 04:39 AM, Michal Privoznik wrote:
>>> On 03.05.2016 01:09, Cole Robinson wrote:
If we exceed the timeout waiting for the tray status to change,
we don't report an error. Fix it
-
Trivially return 1, since bhyve is considered a local connection that
should not be vulnerable to eavesdropping.
---
src/bhyve/bhyve_driver.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 43c7183..441c666 100644
--- a/src/bhyv
Being a local connection, bhyve does not support encryption. Therefore
trivially return 0.
---
src/bhyve/bhyve_driver.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 8b41f7a..43c7183 100644
--- a/src/bhyve/bhyve_driver.c
+++ b
These patches implement some rather trivial missing calls in the bhyve driver.
Since the bhyve connection (Interaction through /dev/vmm as well as the
bhyveload, bhyvectl user-space tools) is local, encryption is not applicable,
but the connection is seen as not prone to eavesdropping.
Fabian F
2016-05-17 15:33 GMT+03:00 Cole Robinson :
> I think Laine was saying 'I personally don't care about ->script so I'm not
> planning on implementing it', so if it isn't implemented we should error
> explicitly rather than silently ignore it.
>
> That said it's probably not hard to get ->script to wo
On Tue, May 17, 2016 at 08:03:11AM -0400, Cole Robinson wrote:
> On 05/17/2016 06:11 AM, Christophe Fergeau wrote:
> > Hey,
> >
> > After this patch series, the QEMU command line may not contain port nor
> > tls-port if they both were set to '0'. However, QEMU versions older than
> > 2.3.0 will er
On Tue, May 17, 2016 at 02:10:16PM +0200, Ján Tomko wrote:
> On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > After this patch series, the QEMU command line may not contain port nor
> > tls-port if they both were set to '0'. However, QEMU versions older than
> >
On 05/17/2016 07:48 AM, Vasiliy Tolstov wrote:
> 2016-05-17 1:53 GMT+03:00 Cole Robinson :
>> I suggest explicitly rejecting the
On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote:
> Hey,
>
> After this patch series, the QEMU command line may not contain port nor
> tls-port if they both were set to '0'. However, QEMU versions older than
> 2.3.0 will error out because they don't have this commit:
> http://git
On 05/17/2016 08:10 AM, Cole Robinson wrote:
> On 05/17/2016 04:39 AM, Michal Privoznik wrote:
>> On 03.05.2016 01:09, Cole Robinson wrote:
>>> If we exceed the timeout waiting for the tray status to change,
>>> we don't report an error. Fix it
>>> ---
>>> I hit this trying to eject floppy media fo
17.05.2016 13:47, Maxim Nestratov пишет:
From: Mikhail Feoktistov
SDK handles empty cdroms all right. We just need to
pass "" instead of NULL (not setting is good too).
However we can get problems here. Disk detaching treats source
as ids. Fortunately disk detaching is not supported for cdrom
This patch aims to fix observed crash on daemon shutdown. Main thread is in
the process of state drivers cleanup, network driver is cleaned up and
qemu driver is not yet. Meanwhile eof event from qemu process triggers
qemuProcessStop -> networkReleaseActualDevice and crash happens as
network driver
On 05/17/2016 04:39 AM, Michal Privoznik wrote:
> On 03.05.2016 01:09, Cole Robinson wrote:
>> If we exceed the timeout waiting for the tray status to change,
>> we don't report an error. Fix it
>> ---
>> I hit this trying to eject floppy media for a win10 VM with F24
>> qemu, but I didn't dig deep
On 05/17/2016 06:11 AM, Christophe Fergeau wrote:
> Hey,
>
> After this patch series, the QEMU command line may not contain port nor
> tls-port if they both were set to '0'. However, QEMU versions older than
> 2.3.0 will error out because they don't have this commit:
> http://git.qemu.org/?p=qemu.
On 05/17/2016 05:26 AM, sonia verma wrote:
> Hi Laine
>
>
> The above patch of interface type="ethernet" is for which libvirt version?
>
Every patch on this list for agains the latest git code. So if it's committed
before the end of the month it will be in libvirt 1.3.5
- Cole
--
libvir-list
2016-05-17 1:53 GMT+03:00 Cole Robinson :
> I suggest explicitly rejecting the
17.05.2016 13:47, Maxim Nestratov пишет:
Mikhail Feoktistov (2):
vz: handle sourceless cdroms
vz: fix template ct creation
Nikolay Shirokovskiy (4):
vz: remove check for auto file format for disks
vz: fix vzCheckUnsupportedDisks format checks for cdroms
vz: fix error message for
From: Nikolay Shirokovskiy
VIR_STORAGE_FILE_AUTO can not be set from xml description.
At the same time we don't set disks format to this value
as for example qemu does. Thus this we can never get this
value in format.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_utils.c | 3 +--
1 file ch
On 05/17/2016 10:34 AM, Chunyan Liu wrote:
> Unify XEN_CONFIG_FORMAT_x and LIBXL_CONFIG_FORMAT_x to
> XEN_CONFIG_FORMAT_x, and move to xen_common.h.
>
> Signed-off-by: Chunyan Liu
LGTM with the minor nitpick fixed, and we're able to consolidate existent
abstraction
in libxl with xenconfig.
Re
From: Mikhail Feoktistov
First we don't need to add disk in this case. Second flag should
be skipped.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index e487f26..b595fe7
From: Nikolay Shirokovskiy
Current version of the function does not check format of cdroms at all.
At the same time prlsdkGetDiskInfo give hints that cdroms always
have format VIR_STORAGE_FILE_RAW. So fix vzCheckUnsupportedDisks.
About structure of checks. As we don't have means to store format
This is just a trivial cosmetic change, throughout all the APIs the argument
is called conn as from 'connection', having 'dmn' at just this single place
might look odd, so better change it now when the interface is still explicitly
disabled and we still have the ability to alter the signatures and
Mikhail Feoktistov (2):
vz: handle sourceless cdroms
vz: fix template ct creation
Nikolay Shirokovskiy (4):
vz: remove check for auto file format for disks
vz: fix vzCheckUnsupportedDisks format checks for cdroms
vz: fix error message for readonly fs
vz: make error path code idiomatic
From: Mikhail Feoktistov
SDK handles empty cdroms all right. We just need to
pass "" instead of NULL (not setting is good too).
However we can get problems here. Disk detaching treats source
as ids. Fortunately disk detaching is not supported for cdroms
yet and for hard disks we can not get empt
On 05/17/2016 10:34 AM, Chunyan Liu wrote:
> According to current xl.cfg docs and xl codes, it uses type=vif
> instead of type=netfront.
>
> Currently after domxml-to-native, libvirt xml model=netfront will be
> converted to xl type=netfront. This has no problem before, xen codes
> for a long time
From: Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index b595fe7..4fe9bfa 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk
On 05/17/2016 10:34 AM, Chunyan Liu wrote:
> Signed-off-by: Chunyan Liu
> ---
> tests/xlconfigdata/test-vif-typename.cfg | 25 ++
> tests/xlconfigdata/test-vif-typename.xml | 45
>
> tests/xlconfigtest.c | 1 +
> 3 files chang
From: Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index e373748..e487f26 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -2666,7 +2666,7 @@ static int
pr
Hi Laine
The above patch of interface type="ethernet" is for which libvirt version?
On Mon, May 16, 2016 at 9:51 PM, Laine Stump wrote:
> This is identical to type='bridge', but without the "connect to a
> bridge" part, so it can be handled by using the same functions (and
> often even the sam
On Mon, May 16, 2016 at 10:59:47AM -0400, Cole Robinson wrote:
> On 05/13/2016 12:35 PM, Christophe Fergeau wrote:
> > Hey,
> >
> > Something which I forgot to mention/test when going through the first
> > iteration is virsh domdisplay, it's currently failing with
> >
> >
> > I think something l
Unify XEN_CONFIG_FORMAT_x and LIBXL_CONFIG_FORMAT_x to
XEN_CONFIG_FORMAT_x, and move to xen_common.h.
Signed-off-by: Chunyan Liu
---
src/libxl/libxl_driver.c | 14 +-
src/xen/xen_driver.h | 3 ---
src/xenconfig/xen_common.h | 4
3 files changed, 9 insertions(+), 12 del
On Tue, 2016-05-10 at 17:59 -0400, Cole Robinson wrote:
> On 05/05/2016 02:48 PM, Andrea Bolognani wrote:
> > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote:
> >
> > ** Guest threads limit **
> >
> > My dual-core laptop will happily run a guest configured with
> >
> >
> >
>
Signed-off-by: Chunyan Liu
---
tests/xlconfigdata/test-vif-typename.cfg | 25 ++
tests/xlconfigdata/test-vif-typename.xml | 45
tests/xlconfigtest.c | 1 +
3 files changed, 71 insertions(+)
create mode 100644 tests/xlconfigdat
Correct libxl config file type=vif handling.
---
Changes in v2:
* update xen{Parse,Format}ConfigCommon parameter vif_typename to
nativeFomat. To reuse XEN_CONFIG_FORMAT_{XM,XL}, first extract
XEN_CONFIG_FORMAT_{XM,XL} to xen_common.h
Chunyan Liu (3):
extract XEN_CONFIG_FORMAT_XM/XL to
According to current xl.cfg docs and xl codes, it uses type=vif
instead of type=netfront.
Currently after domxml-to-native, libvirt xml model=netfront will be
converted to xl type=netfront. This has no problem before, xen codes
for a long time just check type=ioemu, if not, set type to _VIF.
Sinc
On Sun, 2016-05-15 at 17:59 -0400, Cole Robinson wrote:
> ---
> docs/formatdomain.html.in | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 58b8cb6..a461a4e 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdoma
Hey,
After this patch series, the QEMU command line may not contain port nor
tls-port if they both were set to '0'. However, QEMU versions older than
2.3.0 will error out because they don't have this commit:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cf7856adefebe86e0
I assume we want to keep
On Mon, May 16, 2016 at 01:57:13PM -0400, Cole Robinson wrote:
> On 05/12/2016 11:15 AM, Pavel Hrdina wrote:
> > So far we have only two listen types that supports only address:port
> > method, but in the future we may want to add a new different listen
> > type, for example socket.
> >
> > This p
>>> On 5/16/2016 at 06:14 PM, in message <57399d91.1030...@oracle.com>, Joao
Martins wrote:
>
> On 05/13/2016 05:54 PM, Jim Fehlig wrote:
> > On 05/13/2016 06:59 AM, Joao Martins wrote:
> >>
> >> On 05/12/2016 09:55 PM, Jim Fehlig wrote:
> >>> Joao Martins wrote:
> On 05/12/2016 12
On Mon, May 16, 2016 at 13:39:00 -0400, John Ferlan wrote:
>
>
> On 05/11/2016 09:11 AM, Peter Krempa wrote:
> > Commit 82ba41108acd0f3f made possible to use direct mapped iSCSI
> > volumes in qemu as disk sources but didn't remove the define time check.
> >
> > Rework the check by simplifying t
>>> On 5/14/2016 at 12:54 AM, in message <573606ab.4080...@suse.com>, Jim Fehlig
wrote:
> On 05/13/2016 06:59 AM, Joao Martins wrote:
> >
> > On 05/12/2016 09:55 PM, Jim Fehlig wrote:
> >> Joao Martins wrote:
> >>> On 05/12/2016 12:54 AM, Jim Fehlig wrote:
> On 04/21/2016 05:10 AM, Ch
On 16.05.2016 12:06, Chun Yan Liu wrote:
>
>
On 5/14/2016 at 07:47 AM, in message <5736677d.8030...@suse.com>, Jim
Fehlig
> wrote:
>> On 05/13/2016 12:21 AM, Chunyan Liu wrote:
>>
>> It's unfortunate this is a copy-paste from the qemu driver. The code is not
>> trivial and any
1 - 100 of 126 matches
Mail list logo