Re: [libvirt] [PATCH] esx: do not store escaped password in esxVI_Context.

2016-05-23 23:32 GMT+02:00 Dawid Zamirski : > This patch fixes an issue where screenshot API call was failing when > the esx/vcenter password contains special characters such as > apostrophee. The reason for failures was that passwords were escaped > for XML and stored in esxVI_Context which was th

[libvirt] inconsistent handling of "qemu64" CPU model

Hi, I'm not sure where the problem lies, hence the CC to both lists. Please copy me on the reply. I'm playing with OpenStack's devstack environment on an Ubuntu 14.04 host with a Celeron 2961Y CPU. (libvirt detects it as a Nehalem with a bunch of extra features.) Qemu gives version 2.2.0

Re: [libvirt] [PATCH] lxc: support

2016-05-25 21:51 GMT+03:00 Laine Stump : > How does it gather than config? With a qemu hook script? No, libvirit send event when domain starts, i catch it and get domain xml from libvirt via binding. Parse xml element with address and answer to dhcp queries from vm. Also i use this method because

Re: [libvirt] [PATCH v2 0/3] auto-assign controller indexes

On 05/25/2016 11:21 AM, Cole Robinson wrote: ACK series. Thanks for reworking it Thanks! I just pushed it. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] lxc: support

On 05/25/2016 11:13 AM, Vasiliy Tolstov wrote: 2016-05-25 18:00 GMT+03:00 Laine Stump : So $VM_GW is on the same subnet as $VM_IP/24 ? Is that also the same subnet as $HOST_IP? Or is that on a completely different network? (This is all very useful, because it's pointing out that the config of t

Re: [libvirt] [PATCH 2/2] libxl: add default firmwares to driver config object

On 05/25/2016 08:37 AM, Michal Privoznik wrote: > On 25.05.2016 15:28, Jim Fehlig wrote: >> On 05/25/2016 03:32 AM, Michal Privoznik wrote: >>> On 18.05.2016 18:38, Jim Fehlig wrote: Prefer firmwares specified via --with-loader-nvram configure option. If none are specified, use the Xen-pr

Re: [libvirt] [PATCH] esx: do not store escaped password in esxVI_Context.

Hi Michal, Thanks for reviewing. I'll send v2 soon to handle EnsureSession as well. Regards, Dawid On Wed, 2016-05-25 at 14:33 +0200, Michal Privoznik wrote: > On 23.05.2016 23:32, Dawid Zamirski wrote: > > This patch fixes an issue where screenshot API call was failing > > when > > the esx/vcen

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

On 05/25/2016 08:52 AM, Laine Stump wrote: > On 05/24/2016 11:42 PM, Jim Fehlig wrote: >> On 05/22/2016 09:34 PM, Chun Yan Liu wrote: >> On 5/17/2016 at 11:46 PM, in message >>> <2fa0cb6f-ea83-d6f3-18f8-51a671574...@laine.org>, Laine Stump >>> >>> wrote: On 05/16/2016 06:05 PM, Jim Fehli

Re: [libvirt] [PATCHv2 3/3] security: label the slic_table

On Wed, May 25, 2016 at 05:06:27PM +0200, Peter Krempa wrote: > On Wed, May 25, 2016 at 16:53:25 +0200, Peter Krempa wrote: > > On Mon, May 23, 2016 at 20:01:18 +0200, Ján Tomko wrote: > > > Add support for the slic_table to the security drivers. > > > > In this case, you should add a note to the

Re: [libvirt] [PATCH v2 0/3] auto-assign controller indexes

On 05/23/2016 04:50 PM, Laine Stump wrote: > Patches 1 and 2 just shuffle a couple of existing functions. Patch 3 > gets to the point. > > v1->v2 changes are explained in patch 3. > > Laine Stump (3): > conf/qemu: make IS_USB2_CONTROLLER globally available > conf: make virDomainControllerFind

Re: [libvirt] [PATCH] lxc: support

2016-05-25 18:00 GMT+03:00 Laine Stump : > So $VM_GW is on the same subnet as $VM_IP/24 ? Is that also the same subnet > as $HOST_IP? Or is that on a completely different network? > > (This is all very useful, because it's pointing out that the config of the > two ends definitely aren't mirror imag

Re: [libvirt] [PATCHv2 3/3] security: label the slic_table

On Wed, May 25, 2016 at 16:53:25 +0200, Peter Krempa wrote: > On Mon, May 23, 2016 at 20:01:18 +0200, Ján Tomko wrote: > > Add support for the slic_table to the security drivers. > > In this case, you should add a note to the documentation that the file > is not treated as shared and should be cop

Re: [libvirt] [PATCH] lxc: support

On 05/25/2016 08:58 AM, Vasiliy Tolstov wrote: 2016-05-24 19:33 GMT+03:00 Laine Stump : So ignoring the IPv6 addresses for now. You now have a tap device on the *host* that has the following IP addresses: $HOST_IP peer $VM_IP/32 $VM_GW 169.254.169.254 I'm guessing th

Re: [libvirt] [PATCH v2] qemucapstest: replace caps-1.6.50 with updated caps-1.7.0

On Tue, May 24, 2016 at 16:07:44 +0200, Pavel Hrdina wrote: > The qemu-1.6.50 is a beta before the new minor version, let's replace it with > the release qemu-1.7.0. > > Signed-off-by: Pavel Hrdina > --- > tests/domaincapsschemadata/qemu_1.6.50.x86_64.xml | 78 - > tests/domaincapsschemadata/

Re: [libvirt] [PATCHv2 3/3] security: label the slic_table

On Mon, May 23, 2016 at 20:01:18 +0200, Ján Tomko wrote: > Add support for the slic_table to the security drivers. In this case, you should add a note to the documentation that the file is not treated as shared and should be copied for every VM to avoid problems as with shared kernel files. > ---

Re: [libvirt] [PATCH] esx: use lsilogic adapter type in vol create.

On 23.05.2016 23:31, Dawid Zamirski wrote: > ESX will refuse to attach VMDKS that have buslogic adatper type to 64bit > VMs whereas lsilogic works fine both 32bit and 64bit VMs. > --- > src/esx/esx_storage_backend_vmfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

On 05/24/2016 11:42 PM, Jim Fehlig wrote: On 05/22/2016 09:34 PM, Chun Yan Liu wrote: On 5/17/2016 at 11:46 PM, in message <2fa0cb6f-ea83-d6f3-18f8-51a671574...@laine.org>, Laine Stump wrote: On 05/16/2016 06:05 PM, Jim Fehlig wrote: Chun Yan Liu wrote: On 5/14/2016 at 07:47 AM, in message

Re: [libvirt] [PATCHv2 2/3] qemu: format SLIC ACPI table command line

On Mon, May 23, 2016 at 20:01:17 +0200, Ján Tomko wrote: > > > /path/to/acpi/table/file > > > > will result in: > > -acpitable sig=SLIC,file=/path/to/acpi/table/file > > This option was introduced by QEMU commit 8a92ea2 in 2009. > > https://bugzilla.redhat.com/show_bug.cgi?id=132753

Re: [libvirt] [PATCHv2 1/3] conf: add to

On Mon, May 23, 2016 at 20:01:16 +0200, Ján Tomko wrote: > Add a new element to XML: > > > /path/to/acpi/table/file > > > > To supply a path to a SLIC (Software Licensing) ACPI > table blob. > > https://bugzilla.redhat.com/show_bug.cgi?id=1327537 > --- > docs/formatdomain.html.in

Re: [libvirt] [PATCH 00/11] qemu: Erradicate use of virDomainLiveConfigHelperMethod

On Wed, May 25, 2016 at 03:03:58PM +0200, Peter Krempa wrote: > Don't use that terrible function in the qemu driver and a few relevant > refactors. > > Peter Krempa (11): > qemu: monitor: Remove 'supportMaxOptions' argument from > qemuMonitorGetBlockIoThrottle > qemu: Replace virDomainLiv

Re: [libvirt] [PATCH 2/2] libxl: add default firmwares to driver config object

On 25.05.2016 15:28, Jim Fehlig wrote: > On 05/25/2016 03:32 AM, Michal Privoznik wrote: >> On 18.05.2016 18:38, Jim Fehlig wrote: >>> Prefer firmwares specified via --with-loader-nvram configure >>> option. If none are specified, use the Xen-provided default >>> firmwares found in LIBXL_FIRMWARE_D

Re: [libvirt] [PATCH] libxl: default to qemu driver for network disks

On 05/25/2016 02:41 AM, Michal Privoznik wrote: > On 24.05.2016 00:01, Jim Fehlig wrote: >> Xen only supports network-based disks with the qemu (aka qdisk) driver. >> Set the driverName to 'qemu' in libxlDomainDeviceDefPostParse() if >> not already set. When starting a domain with network-based dis

[libvirt] [PATCH] qemu: don't regard cur_balloon in supplied xml in migrate and save

cur_balloon value can change in between preparing external config and using it in operations like save and migrate. As a resutl operation will fail for ABI inconsistency. cur_balloon changes can not be predicted generally and thus operations will fail from time to time. Skip this check if domain l

Re: [libvirt] [PATCH 06/11] qemu: Refactor qemuDomainGetBlkioParameters

On Wed, May 25, 2016 at 03:04:04PM +0200, Peter Krempa wrote: > Get rid of lots of duplicated code. > --- > src/qemu/qemu_driver.c | 411 > + > 1 file changed, 75 insertions(+), 336 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qe

Re: [libvirt] [PATCH 2/2] libxl: add default firmwares to driver config object

On 05/25/2016 03:32 AM, Michal Privoznik wrote: > On 18.05.2016 18:38, Jim Fehlig wrote: >> Prefer firmwares specified via --with-loader-nvram configure >> option. If none are specified, use the Xen-provided default >> firmwares found in LIBXL_FIRMWARE_DIR. >> >> Signed-off-by: Jim Fehlig >> --- >

[libvirt] [PATCH 17/19] tests: Rename virtTestCounterNext to virTestCounterNext.

This function doesn't follow our convention of naming functions. --- tests/qemucommandutiltest.c | 2 +- tests/testutils.c | 6 +++--- tests/testutils.h | 2 +- tests/virbitmaptest.c | 2 +- tests/virfiletest.c | 2 +- tests/virstoragetest.c | 2 +- 6 files c

[libvirt] [PATCH 18/19] tests: Rename virtTestErrorFuncQuiet to virTestErrorFuncQuiet.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 3454429..61e7a22 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -719,7 +719,7 @@ vir

[libvirt] [PATCH 15/19] tests: Rename virtTestDifferenceBin to virTestDifferenceBin.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 2 +- tests/testutils.h | 2 +- tests/virnetmessagetest.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index f56ab09..7244a52

[libvirt] [PATCH 13/19] tests: Rename virtTestDifferenceFullInternal to virTestDifferenceFullInternal.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 9ebd94a..2f27bde 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -476,7 +476,7 @@ v

[libvirt] [PATCH 00/19] Drop virt prefix from tests

Replacig virt prefix with vir prefix in tests. It was suggested on wikipage: http://wiki.libvirt.org/page/BiteSizedTasks#Rename_test_suite_routines_from_virtTest.2A_to_virTest.2A Tomáš Ryšavý (19): tests: Rename virtTestRun to virTestRun. tests: Rename virtTestDifference to virTestDifference.

[libvirt] [PATCH 04/19] tests: Rename virtTestCompareToFile to virTestCompareToFile.

This function doesn't follow our convention of naming functions. --- tests/bhyvexml2argvtest.c| 6 +++--- tests/cputest.c | 2 +- tests/domaincapstest.c | 2 +- tests/lxcconf2xmltest.c | 2 +- tests/networkxml2conftest.c | 2 +- tests/networkxml2fir

[libvirt] [PATCH 16/19] tests: Rename virtTestCaptureProgramOutput to virTestCaptureProgramOutput.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 4 ++-- tests/testutils.h | 2 +- tests/virshtest.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 7244a52..f0a4dec 100644 --- a/tests/testut

[libvirt] [PATCH 19/19] tests: Rename virtTestMain to virTestMain.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 2 +- tests/testutils.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 61e7a22..b96fed6 100644 --- a/tests/testutils.c +++ b/tests/testut

[libvirt] [PATCH 06/19] tests: Rename virtTestClearCommandPath to virTestClearCommandPath.

This function doesn't follow our convention of naming functions. --- tests/networkxml2firewalltest.c | 2 +- tests/nwfilterebiptablestest.c | 14 +++--- tests/nwfilterxml2firewalltest.c | 2 +- tests/testutils.c| 2 +- tests/testutils.h| 2 +- 5 files

[libvirt] [PATCH 07/19] tests: Rename virtTest00MActive to virTest00MActive.

This function doesn't follow our convention of naming functions. --- tests/qemuargv2xmltest.c | 2 +- tests/qemuxml2argvtest.c | 2 +- tests/testutils.c| 2 +- tests/testutils.h| 2 +- tests/virfirewalltest.c | 8 5 files changed, 8 insertions(+), 8 deletions(-) diff --g

[libvirt] [PATCH 14/19] tests: Rename virtTestCaptureProgramExecChild to virTestCaptureProgramExecChild.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 2f27bde..f56ab09 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -351,7 +351,7 @@ vir

[libvirt] [PATCH 03/19] tests: Rename virtTestLoadFile to virTestLoadFile.

This function doesn't follow our convention of naming functions. --- tests/domainsnapshotxml2xmltest.c | 4 ++-- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +- tests/networkxml2xmlupdatetest.c | 2 +- tests/nodedevxml2xmltest.c| 2 +- tests/qemuargv2xm

[libvirt] [PATCH 02/19] tests: Rename virtTestDifference to virTestDifference.

This function doesn't follow our convention of naming functions. --- tests/commandtest.c| 16 tests/esxutilstest.c | 6 +++--- tests/jsontest.c | 6 +++--- tests/nwfilterebiptablestest.c | 14 +++--- tests/openvzutilstest.c|

[libvirt] [PATCH 11/19] tests: Rename virtTestQuiesceLibvirtErrors to virTestQuiesceLibvirtErrors.

This function doesn't follow our convention of naming functions. --- tests/esxutilstest.c| 2 +- tests/metadatatest.c| 2 +- tests/objecteventtest.c | 2 +- tests/sockettest.c | 2 +- tests/testutils.c | 2 +- tests/testutils.h | 2 +- tests/utiltest.c| 2 +- 7 fil

[libvirt] [PATCH 10/19] tests: Rename virtTestUseTerminalColors to virTestUseTerminalColors.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 40ac8ef..03369ab 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -89,7 +89,7 @@ b

[libvirt] [PATCH 09/19] tests: Rename virtTestLogContentAndReset to virTestLogContentAndReset.

This function doesn't follow our convention of naming functions. --- tests/cputest.c | 4 ++-- tests/qemuargv2xmltest.c | 2 +- tests/qemuxml2argvtest.c | 4 ++-- tests/testutils.c| 2 +- tests/testutils.h| 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 08/19] tests: Rename virtTestCounterReset to virTestCounterReset.

This function doesn't follow our convention of naming functions. --- tests/qemucommandutiltest.c | 2 +- tests/testutils.c | 6 +++--- tests/testutils.h | 2 +- tests/virbitmaptest.c | 2 +- tests/virfiletest.c | 2 +- tests/virstoragetest.c | 2 +- 6 files c

[libvirt] [PATCH 05/19] tests: Rename virtTestDifferenceFull to virTestDifferenceFull.

This function doesn't follow our convention of naming functions. --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/nodedevxml2xmltest.c| 2 +- tests/qemuhotplugtest.c | 2 +- tests/testutils.c | 8 tests/te

[libvirt] [PATCH 12/19] tests: Rename virtTestDifferenceFullNoRegenerate.

This function doesn't follow our convention of naming functions. --- tests/qemuxml2xmltest.c | 2 +- tests/testutils.c | 4 ++-- tests/testutils.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 7b01587..6bb

[libvirt] [PATCH] tests: Rename virtTestMain to virTestMain.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 2 +- tests/testutils.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 934fce5..2dbac99 100644 --- a/tests/testutils.c +++ b/tests/testut

[libvirt] [PATCH 07/11] qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainGetSchedulerParametersFlags

--- src/qemu/qemu_driver.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a9cfde2..0f79dcd 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10336,7 +10336,7 @@ qemuDomainGetSchedulerParameter

[libvirt] [PATCH 05/11] qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainGetBlkioParameters

--- src/qemu/qemu_driver.c | 65 ++ 1 file changed, 29 insertions(+), 36 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index db8b9d6..e8e1418 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9089,10 +9

[libvirt] [PATCH 09/11] qemu: Refactor qemuDomainGetSchedulerParametersFlags

Use virDomainCputune struct to store the data rather than exploding the fields and use macros to fill the typed params. --- src/qemu/qemu_driver.c | 143 +++-- 1 file changed, 42 insertions(+), 101 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/

[libvirt] [PATCH 08/11] conf: Change virDomainCputune member 'shares' to unsigned long long

cgroup functions set and get the longer type so use it everywhere --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 2 +- src/lxc/lxc_native.c | 2 +- src/vmx/vmx.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf

[libvirt] [PATCH 00/11] qemu: Erradicate use of virDomainLiveConfigHelperMethod

Don't use that terrible function in the qemu driver and a few relevant refactors. Peter Krempa (11): qemu: monitor: Remove 'supportMaxOptions' argument from qemuMonitorGetBlockIoThrottle qemu: Replace virDomainLiveConfigHelperMethod in qemuDomainGetBlockIoTune qemu: Refactor typed p

[libvirt] [PATCH 01/11] qemu: monitor: Remove 'supportMaxOptions' argument from qemuMonitorGetBlockIoThrottle

The caller is already aware that the params are missing and the extractor is ignoring the missing ones so the parameter isn't necessary. --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor.c | 5 ++--- src/qemu/qemu_monitor.h | 3 +-- src/qemu/qemu_monitor_json.c | 24 +

[libvirt] [PATCH 02/11] qemu: Replace virDomainLiveConfigHelperMethod in qemuDomainGetBlockIoTune

Use virDomainObjGetDefs since the API guarantees that both live and config are never set together. --- src/qemu/qemu_driver.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index af42c8d..2e6b166 100

[libvirt] [PATCH 11/11] qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetSchedulerParametersFlags

This refactor also makes a distinction between the pointer to the original definition and copied one to prevent mixups. --- src/qemu/qemu_driver.c | 93 +- 1 file changed, 47 insertions(+), 46 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/q

[libvirt] [PATCH 10/11] qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetBlockIoTune

--- src/qemu/qemu_driver.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 71d25a4..0fbce1b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17090,6 +17090,7 @@ qemuDomainSetBlockIoTune

[libvirt] [PATCH 06/11] qemu: Refactor qemuDomainGetBlkioParameters

Get rid of lots of duplicated code. --- src/qemu/qemu_driver.c | 411 + 1 file changed, 75 insertions(+), 336 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e8e1418..a9cfde2 100644 --- a/src/qemu/qemu_driver.c +++ b/

[libvirt] [PATCH 04/11] qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetMemoryParameters

--- src/qemu/qemu_driver.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4ec04ee..db8b9d6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9497,6 +9497,7 @@ qemuDomain

[libvirt] [PATCH 03/11] qemu: Refactor typed params assignment in qemuDomainGetBlockIoTune

Introduce a macro to assign the parameters to avoid the for loop and shuffle around various checks for a simpler and saner function. --- src/qemu/qemu_driver.c | 145 + 1 file changed, 37 insertions(+), 108 deletions(-) diff --git a/src/qemu/qemu_dr

Re: [libvirt] [PATCH] lxc: support

2016-05-24 19:33 GMT+03:00 Laine Stump : > > So ignoring the IPv6 addresses for now. You now have a tap device on the > *host* that has the following IP addresses: > > $HOST_IP peer $VM_IP/32 > $VM_GW > 169.254.169.254 > > I'm guessing that in the guest you configure its eth

Re: [libvirt] [PATCH] esx: do not store escaped password in esxVI_Context.

On 23.05.2016 23:32, Dawid Zamirski wrote: > This patch fixes an issue where screenshot API call was failing when > the esx/vcenter password contains special characters such as > apostrophee. The reason for failures was that passwords were escaped > for XML and stored in esxVI_Context which was the

[libvirt] [PATCHv2] Added hook for network modification event

From: Anton Khramov Anton Khramov (1): network: Added hook for network modification event docs/hooks.html.in | 2 ++ src/network/bridge_driver.c | 5 + src/util/virhook.c | 3 ++- src/util/virhook.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-) -- 1.

[libvirt] [PATCHv2] network: Added hook for network modification event

From: Anton Khramov Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1181539 --- docs/hooks.html.in | 2 ++ src/network/bridge_driver.c | 5 + src/util/virhook.c | 3 ++- src/util/virhook.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/

Re: [libvirt] [PATCH v2] Call qemuDomainObjEndJob when qemuCaps is null during hotplug

On Wed, May 25, 2016 at 04:18:57AM -0500, Shivaprasad G Bhat wrote: > Signed-off-by: Shivaprasad G Bhat > --- > src/qemu/qemu_driver.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) ACK and pushed, thanks. Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.r

Re: [libvirt] [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON

On 05/25/2016 02:46 AM, Marc Brothier wrote: > Public bug reported: > > Hi, > > We have VMs which were started with an older version than qemu 2.1 which > added "cache-miss-rate" property for XBZRLECacheStats. While trying to > migrate the VM to a new host which is running a higher version (2.3)

Re: [libvirt] [PATCH 2/3] qemu: driver: Remove unnecessary cleanup label from qemuDomainChangeDiskLive

On 25.05.2016 07:48, Peter Krempa wrote: > --- > src/qemu/qemu_driver.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 895e926..6f5712d 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qem

Re: [libvirt] [PATCH 0/3] qemu: Allow update of certain disk options during runtime

On 25.05.2016 07:48, Peter Krempa wrote: > Until this series it was possible to update floppies and cdroms only. With > this > you can update startup policy and snapshot behavior for regular disks too. > > Peter Krempa (3): > qemu: driver: Move around code to avoid need to rollback > qemu: dr

Re: [libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

On 09.05.2016 21:00, intrigeri wrote: > Hi, > >> Stefan Bader wrote (20 May 2015 10:11:45 GMT) : >> intrigeri wrote (15 Jun 2015 15:09:11 GMT) : >> My (possibly incomplete) records say that I've tested the latest >> proposed patch set back in February (<85iof8v6j5@boum.org>). > >>> Since I lo

[libvirt] [PATCH v2] Call qemuDomainObjEndJob when qemuCaps is null during hotplug

Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_driver.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 249393a..cd53d3c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8237,7 +8237,7 @@ q

Re: [libvirt] [PATCH] Call qemuDomainObjEndJob when qemuCaps is null during hotplug

On Wed, May 25, 2016 at 4:06 PM, Pavel Hrdina wrote: > On Wed, May 25, 2016 at 03:49:04AM -0500, Shivaprasad G Bhat wrote: > > Signed-off-by: Shivaprasad G Bhat > > --- > > src/qemu/qemu_driver.c |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/qemu/qemu

Re: [libvirt] [PATCH V2 0/4] libxl: support pvusb

On 05/20/2016 11:21 PM, Jim Fehlig wrote: > On 05/19/2016 02:14 AM, Chunyan Liu wrote: >> This patch series is to support pvusb in libxl driver. >> >> --- >> Changes in v2: >> * add LIBXL_HAVE_PVUSB check >> * add convertion of domxml USB config to/from xl.cfg >> * address other comments >>

Re: [libvirt] [PATCH] xenconfig: xm: check for driver on disk format

On 05/25/2016 02:21 AM, Jim Fehlig wrote: > On 05/24/2016 04:56 AM, Joao Martins wrote: >> When reviewing libxl vif typename series[0] I found out a bug > > s/out// > >> on xen-xm formatter where this "virsh domxml-to-native xen-xm file.xml" > > s/this// > >> can lead to a NULL dereference if

Re: [libvirt] [PATCH] Call qemuDomainObjEndJob when qemuCaps is null during hotplug

On Wed, May 25, 2016 at 03:49:04AM -0500, Shivaprasad G Bhat wrote: > Signed-off-by: Shivaprasad G Bhat > --- > src/qemu/qemu_driver.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 249393a..3f26f1f 100644 >

Re: [libvirt] [PATCH] Unref the cfg in qemuDomainAttachHostPCIDevice()

On Wed, May 25, 2016 at 03:47:12AM -0500, Shivaprasad G Bhat wrote: > Signed-off-by: Shivaprasad G Bhat > --- > src/qemu/qemu_hotplug.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK and pushed Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mail

[libvirt] [PATCH] Call qemuDomainObjEndJob when qemuCaps is null during hotplug

Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 249393a..3f26f1f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8237,7 +8237,7 @@ qem

[libvirt] [PATCH] Unref the cfg in qemuDomainAttachHostPCIDevice()

Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_hotplug.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 807aaf8..41a0e4f 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1164,7 +1164,7 @@ qe

Re: [libvirt] [PATCH 2/2] libxl: add default firmwares to driver config object

On 18.05.2016 18:38, Jim Fehlig wrote: > Prefer firmwares specified via --with-loader-nvram configure > option. If none are specified, use the Xen-provided default > firmwares found in LIBXL_FIRMWARE_DIR. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_conf.c | 21 + >

Re: [libvirt] [PATCH 1/2] driver config: Introduce virFirmware object

On 18.05.2016 18:38, Jim Fehlig wrote: > The virQEMUDriverConfig object contains lists of > loader:nvram pairs to advertise firmwares supported by > by the driver, and qemu_conf.c contains code to populate > the lists, all of which is useful for other drivers too. > > To avoid code duplication, in

Re: [libvirt] [PATCH v5 1/6] graphics: introduce listen type socket and use it for VNC

On Wed, May 25, 2016 at 10:32:02AM +0200, Christophe Fergeau wrote: > On Tue, May 24, 2016 at 04:45:53PM +0200, Pavel Hrdina wrote: > > Introduce a new listen type that will be used to tell a graphics device > > to listen on unix socket and use it for VNC graphics instead of socket > > attribute.

Re: [libvirt] [PATCH v2 2/3] qemu: Remove unused persistentAddrs

On Tue, May 24, 2016 at 06:53:17PM -0400, John Ferlan wrote: > Based on some digital archaeology performed by jtomko, it's been determined > that the persistentAddrs variable is no longer necessary... > > The variable was added by: > commit 141dea6bc7222107c2357acb68066baea5b26df3 > CommitDate: 20

Re: [libvirt] [PATCH v2 1/2] Document virPCIGetPhysicalFunction() and fix its callers

On Tue, 2016-05-24 at 11:22 -0400, Laine Stump wrote: > On 05/24/2016 07:11 AM, Andrea Bolognani wrote: > >  > > Commit c8b1a83605e4 changed the function, making it > > impossible for callers to be able to tell whether a > > non-negative return value means "physical function > > address found and p

Re: [libvirt] [PATCH] libxl: default to qemu driver for network disks

On 24.05.2016 00:01, Jim Fehlig wrote: > Xen only supports network-based disks with the qemu (aka qdisk) driver. > Set the driverName to 'qemu' in libxlDomainDeviceDefPostParse() if > not already set. When starting a domain with network-based disks, > ensure the driverName is 'qemu'. > > Signed-of

Re: [libvirt] [PATCH] libxl: default to qemu driver for network disks

On 05/25/2016 04:23 AM, Jim Fehlig wrote: > On 05/23/2016 04:01 PM, Jim Fehlig wrote: >> Xen only supports network-based disks with the qemu (aka qdisk) driver. >> Set the driverName to 'qemu' in libxlDomainDeviceDefPostParse() if >> not already set. When starting a domain with network-based disks,

Re: [libvirt] [PATCH v2 3/3] lxc: Fix lxcDomainDestroyFlags endjob processing

On 25.05.2016 00:53, John Ferlan wrote: > Commit id '15ccb0dbf' added job functions for the lxc driver; however, > for shutdown and nonpersistent path, the vm was removed from the domain > object list and the vm pointer cleared before the endjob. > > Adjust the code to perform the endjob first and

Re: [libvirt] [PATCH v2 1/3] qemu: Remove dead code

On 25.05.2016 00:53, John Ferlan wrote: > Since commit id '20a0fa8e' removed the QEMU_CAPS_DEVICE, Coverity notes > that it's no longer possible to have 'addrs' be NULL when checking for > a live domain since qemuDomainPCIAddressSetCreate would have jumped to > cleanup if addrs was NULL. > > Signe

Re: [libvirt] [PATCH v2 0/3] Fix a couple of recently found coverity issues

On 25.05.2016 00:53, John Ferlan wrote: > v1: > http://www.redhat.com/archives/libvir-list/2016-May/msg01611.html > > Although initially ACK'd by Erik, Jan pointed out something with one > of the patches and well this just lagged on my todo list. Since then > a change was made to lxc_driver.c (co

Re: [libvirt] [PATCH v5 1/6] graphics: introduce listen type socket and use it for VNC

On Tue, May 24, 2016 at 04:45:53PM +0200, Pavel Hrdina wrote: > Introduce a new listen type that will be used to tell a graphics device > to listen on unix socket and use it for VNC graphics instead of socket > attribute. The socket attribute will remain in the XML for backward > compatibility. >

Re: [libvirt] [PATCH 0/7] qemu: Fix removable devices without a tray

On Wed, May 25, 2016 at 09:47:58 +0200, Michal Privoznik wrote: > On 24.05.2016 15:17, Peter Krempa wrote: > > Peter Krempa (7): > > ACK series. Pushed; Thanks. Peter signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/

Re: [libvirt] [PATCH 4/7] qemu: process: Fix and improve disk data extraction

On Wed, May 25, 2016 at 09:47:59 +0200, Michal Privoznik wrote: > On 24.05.2016 15:17, Peter Krempa wrote: > > Extract information for all disks and update tray state and source only > > for removable drives. Additionally store whether a drive is removable > > and whether it has a tray. > > --- > >

Re: [libvirt] [PATCH 0/7] qemu: Fix removable devices without a tray

On 24.05.2016 15:17, Peter Krempa wrote: > Peter Krempa (7): > qemu: Move struct qemuDomainDiskInfo to qemu_domain.h > qemu: Extract more information about qemu drives > qemu: Move and rename qemuDomainCheckEjectableMedia to > qemuProcessRefreshDisks > qemu: process: Fix and improve dis

Re: [libvirt] [PATCH 4/7] qemu: process: Fix and improve disk data extraction

On 24.05.2016 15:17, Peter Krempa wrote: > Extract information for all disks and update tray state and source only > for removable drives. Additionally store whether a drive is removable > and whether it has a tray. > --- > src/qemu/qemu_domain.h | 4 > src/qemu/qemu_monitor.c | 18