Re: [libvirt] [PATCH 0/2] Introduce libvirt-libs.rpm

2016-07-06 Thread Michal Privoznik
On 01.07.2016 12:04, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Privoznik (2): > spec: Split libvirt-client > spec: Move virt-admin into its own package > > libvirt.spec.in | 90 > +++-- > 1 file changed, 56 insertions(+), 34

Re: [libvirt] [PATCH] qemu: agent: Fix QEMU guest agent is not available due to an error

2016-07-06 Thread Xiubo Li
Hi All, This patch I have test for more than 3 days using 5 different scripts at the same time, and the test scripts and libvirtd are all running happily till now. Thanks, BRs Xiubo On 06/07/2016 15:21, Xiubo Li wrote: These days, we experienced one qemu guest agent is not available error

[libvirt] [PATCHv5 4/5] gconfig: Add GVirConfigDomainAddressPci getters

2016-07-06 Thread Zeeshan Ali (Khattak)
From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++ libvirt-gconfig/libvirt-gconfig.sym

[libvirt] [PATCHv5 3/5] Add GVirConfigDomainHostdevPci

2016-07-06 Thread Zeeshan Ali (Khattak)
Add API to read and write PCI hostdev nodes. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-hostdev-pci.c | 235 + .../libvirt-gconfig-domain-hostdev-pci.h | 81 +++ libvirt-gconfig/libvirt-gconfig-domain-host

[libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

2016-07-06 Thread Zeeshan Ali (Khattak)
Add API to read and write domain/devices/hostdev nodes. This patch only adds the baseclass and hence is not useful on it's own. A more specific subclass to represent PCI devices will be added in a following patch. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-

[libvirt] gconfig: Add hostdev support v5

2016-07-06 Thread Zeeshan Ali (Khattak)
It's back! :) Really intend to actually get it finished and merged this time around. Basically I mostly fixed all the minor issues in patch 3/5 (Add GVirConfigDomainHostdevPci) pointed out in last review, including treatment of on/off attributes (which is why the patch "libvirt-gconfig: Accept

[libvirt] [PATCHv5 1/5] gconfig: Add gvir_config_object_has_child

2016-07-06 Thread Zeeshan Ali (Khattak)
From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-p

[libvirt] [PATCHv5 5/5] Add test for GVirConfigDomainHostdevPci API

2016-07-06 Thread Zeeshan Ali (Khattak)
--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c b/tests/test-gc

[libvirt] [libvirt-php PATCH 3/3] use VIRT_FOREACH macros everywhere.

2016-07-06 Thread Dawid Zamirski
This results in cleaner code and fixes other potential bugs, e.g. in get_next_free_numeric_value --- src/libvirt-php.c | 141 ++ 1 file changed, 25 insertions(+), 116 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index e03990a.

[libvirt] [libvirt-php PATCH 2/3] libvirt_connect: use loop macros to read cred info.

2016-07-06 Thread Dawid Zamirski
Since addition of PHP7 the libvirt_connect regressed on PHP5 where it was no longer reading out credential info from the php hash table properly. This patch makes use of the loop macros that handle both PHP versions correctly and consequently fix this issue. --- src/libvirt-php.c | 33 +++-

[libvirt] [libvirt-php PATCH 0/3] Fix PHP5 compatibilty issues.

2016-07-06 Thread Dawid Zamirski
With the patches that landed support for PHP7 some API calls were not behaving correctly when compiled against PHP5. The most obvious case is where connection to e.g. esx host, libvirt_connect wasn't properly reading out credentials from Zeng HashTable which resulted in failure to authenticate. Thi

[libvirt] [libvirt-php PATCH 1/3] Define macros for looping php hash tables.

2016-07-06 Thread Dawid Zamirski
Since PHP5 and 7 differ slightly on how looping over php hash tables is done, those macros were added to abstract away those differences and avoid using ifdefs for each php version. --- src/libvirt-php.c | 31 +++ src/libvirt-php.h | 6 ++ 2 files changed, 37 inser

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

2016-07-06 Thread Zeeshan Ali (Khattak)
On Thu, May 12, 2016 at 1:28 PM, Christophe Fergeau wrote: > Looks I never answered this one. > > On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote: >> >> +const gchar >> >> *gvir_config_domain_hostdev_pci_get_rom_file(GVirConfigDomainHostdevPci >> >> *hostdev) >> >> +{ >> >>

[libvirt] [PATCH] qemu: agent: Fix QEMU guest agent is not available due to an error

2016-07-06 Thread Xiubo Li
These days, we experienced one qemu guest agent is not available error. Then the guest agent couldn't be used forever before rebooting the libvirtd daemon or reboot the qemu-guest-agent in the VM(you can also reboot the VM) to clear the priv->agentError. This is one bug for a long time in many ver

[libvirt] [PATCH 3/4] vz: refactoring of prlsdkCreateCt

2016-07-06 Thread Olga Krishtal
We do not need to check domainf fs type there, because it is done in prlsdkCheckUnsupportedParams. Signed-off-by: Olga Krishtal --- src/vz/vz_sdk.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index b13b84d..dd7eb6e

[libvirt] [PATCH 2/4] devices: filesystems: added volume type

2016-07-06 Thread Olga Krishtal
New type of is introduced. This patch allows to use volumes for storing the filesystem, that is accessed from the guest e.g. root directory for container. To take advantage of volumes as a backend of filesystem volume and pool names should be specified: Signed-off-by: Olga Krishtal --- src

[libvirt] [PATCH 2/4] devices: filesystems: added volume type

2016-07-06 Thread Olga Krishtal
New type of is introduced. This patch allows to use volumes for storing the filesystem, that is accessed from the guest e.g. root directory for container. To take advantage of volumes as a backend of filesystem volume and pool names should be specified: Signed-off-by: Olga Krishtal --- src

[libvirt] [PATCH 4/4] vz: support filesystem type volume

2016-07-06 Thread Olga Krishtal
Vz containers are able to use ploop volumes from storage pools to work upon. To use filesystem type volume, pool name and volume name should be specifaed in : The information about pool and volume is stored in ct dom configuration: libvirt://localhost/pool_name/vol_n

[libvirt] [PATCH v2 0/4] devices: filesystem: type volume

2016-07-06 Thread Olga Krishtal
The patches introduce new filesystem type volume: This makes possible to use storage volumes as the source for disks. v2: -split patches -rebased Olga Krishtal (4): filesystem: adds possibility to use storage pool as fs source devices: filesystems: added volume type vz: refact

[libvirt] [PATCH 4/4] vz: support filesystem type volume

2016-07-06 Thread Olga Krishtal
Vz containers are able to use ploop volumes from storage pools to work upon. To use filesystem type volume, pool name and volume name should be specifaed in : The information about pool and volume is stored in ct dom configuration: libvirt://localhost/pool_name/vol_n

[libvirt] [PATCH v2 0/4] devices: filesystem: type volume

2016-07-06 Thread Olga Krishtal
The patches introduce new filesystem type volume: This makes possible to use storage volumes as the source for disks. v2: -split patches -rebased Olga Krishtal (4): filesystem: adds possibility to use storage pool as fs source devices: filesystems: added volume type vz: refact

[libvirt] [PATCH 1/4] filesystem: adds possibility to use storage pool as fs source

2016-07-06 Thread Olga Krishtal
Signed-off-by: Olga Krishtal --- src/conf/domain_audit.c| 4 ++-- src/conf/domain_conf.c | 34 --- src/conf/domain_conf.h | 3 ++- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_container.c| 50 +

[libvirt] [PATCH 3/4] vz: refactoring of prlsdkCreateCt

2016-07-06 Thread Olga Krishtal
We do not need to check domainf fs type there, because it is done in prlsdkCheckUnsupportedParams. Signed-off-by: Olga Krishtal --- src/vz/vz_sdk.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index b13b84d..dd7eb6e

[libvirt] [PATCH 1/4] filesystem: adds possibility to use storage pool as fs source

2016-07-06 Thread Olga Krishtal
Signed-off-by: Olga Krishtal --- src/conf/domain_audit.c| 4 ++-- src/conf/domain_conf.c | 34 --- src/conf/domain_conf.h | 3 ++- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_container.c| 50 +

[libvirt] [PATCH] examples: If parameters count is zero we have nothing to do

2016-07-06 Thread Marc Hartmayer
The virDomainGetCPUStats() API contract permits nparams == 0. print_cpu_usage() assumes nparams > 0 because the domtop example application isn't very useful if there are no statistics. Explicitly error out to avoid potentially using the local variable pos uninitialized. Reviewed-by: Boris Fiuczyns

[libvirt] [PATCH 2/3] util: bitmap: Mention the size == 0 handling

2016-07-06 Thread Marc Hartmayer
As there is an explicit constructor for the special case of empty bitmaps, we should mention that the generic constructors rejects the creation of empty bitmaps. Reviewed-by: Boris Fiuczynski Reviewed-by: Sascha Silbe Reviewed-by: Bjoern Walk Signed-off-by: Marc Hartmayer --- src/util/virbitm

[libvirt] [PATCH 3/3] tests: Add test cases for the empty bitmap

2016-07-06 Thread Marc Hartmayer
As the empty bitmap exists, we should also test it. This patch adds test cases for the procedures 'virBitmapNextSetBit', 'virBitmapLastSetBit', 'virBitmapNextClearBit'. Tested-by: Sascha Silbe Reviewed-by: Sascha Silbe Reviewed-by: Boris Fiuczynski Signed-off-by: Marc Hartmayer --- tests/virb

[libvirt] [PATCH 1/3] util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps

2016-07-06 Thread Marc Hartmayer
Before the variable 'bits' was initialized with 0 (commit 3470cd860d517760b13e26d97b6a842ff72687a1), the following bug was possible. A function call with an empty bitmap leads to undefined behavior. Because if 'bitmap->map_len == 0' 'unusedBits' will be <= 0 and 'sz == 1'. So the non global and no

[libvirt] [PATCH 0/3] bitmap: Clarify and add tests for empty bitmap

2016-07-06 Thread Marc Hartmayer
This patch series clarifies the virBitmapLastSetBit function and adds some tests for the empty bitmap. It also clarifies the documentations of virBitmapNewQuiet and virBitmapNew. Marc Hartmayer (3): util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps util: bitmap: Mention t

Re: [libvirt] [PATCH 1/2] qemu: Properly reset spiceMigration flag

2016-07-06 Thread Pavel Hrdina
On Tue, Jul 05, 2016 at 10:17:39AM +0200, Jiri Denemark wrote: > Otherwise migration during which we didn't send client_migrate_info QMP > command will get stuck waiting for SPICE migration to finish if libvirtd > sent the QMP command in a previous migration attempt. > > https://bugzilla.redhat.co

Re: [libvirt] [PATCH 0/2] qemu: Fix SPICE migration with incorrect URI

2016-07-06 Thread Pavel Hrdina
On Tue, Jul 05, 2016 at 10:17:38AM +0200, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1151723 > ACK series Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list