On Mon, Jul 25, 2016 at 11:48:38PM +0100, Justin Clift wrote:
> On 25 Jul 2016, at 23:13, Daniel Veillard wrote:
> > About time to roll that one.
> > I think we need to enter freese on Wednesday, then I can make rc2 on Friday,
> > and hopefully we can push 2.1.0 on Monday or Tuesday next week.
>
Justin Clift wrote:
> On 25 Jul 2016, at 23:13, Daniel Veillard wrote:
> > About time to roll that one.
> > I think we need to enter freese on Wednesday, then I can make rc2 on Friday,
> > and hopefully we can push 2.1.0 on Monday or Tuesday next week.
> >
> > Raise a flag if that doesn't wo
Daniel P. Berrange wrote:
> On Wed, Jul 20, 2016 at 03:46:56PM +0200, Andrea Bolognani wrote:
> > The symbol being missing has been reported as causing build
> > failures on OS X. If it's not already defined, define it to
> > zero so that it won't have any effect.
> > ---
> > Changes from v2:
>
On 07/25/2016 09:35 PM, Jim Fehlig wrote:
> On 07/23/2016 05:34 AM, Joao Martins wrote:
>> On 07/22/2016 10:50 PM, Jim Fehlig wrote:
>>> On 07/20/2016 04:48 PM, Joao Martins wrote:
Introduce initial support for domainBlockStats API call that
allow us to query block device statistics. op
Introduce initial support for domainBlockStats API call that
allow us to query block device statistics. openstack nova
uses this API call to query block statistics, alongside
virDomainMemoryStats and virDomainInterfaceStats. Note that
this patch only introduces it for VBD for starters. QDisk
would
On 25 Jul 2016, at 23:13, Daniel Veillard wrote:
> About time to roll that one.
> I think we need to enter freese on Wednesday, then I can make rc2 on Friday,
> and hopefully we can push 2.1.0 on Monday or Tuesday next week.
>
> Raise a flag if that doesn't work :-)
Hoping we get the OSX fix i
About time to roll that one.
I think we need to enter freese on Wednesday, then I can make rc2 on Friday,
and hopefully we can push 2.1.0 on Monday or Tuesday next week.
Raise a flag if that doesn't work :-)
thanks,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
vei
https://bugzilla.redhat.com/show_bug.cgi?id=1356937
Add the definitions to allow for viewing/setting cgroup period and quota
limits for IOThreads.
This is similar to the work done for emulator quota and period by
commit ids 'b65dafa' and 'e051c482'.
Being able to view/set the IOThread specific v
https://bugzilla.redhat.com/show_bug.cgi?id=1356937
Add support for IOThread quota/bandwidth and period parameters for non
session mode. If in session mode, then error out. Uses all the same
places where {vcpu|emulator|global}_{period|quota} are adjusted and
adds the iothread values.
Signed-off-
https://bugzilla.redhat.com/show_bug.cgi?id=1356937
John Ferlan (2):
conf: Add IOThread quota and period scheduler/cputune defs
qemu: Add support to get/set IOThread period and quota cgroup values
docs/formatdomain.html.in | 25
docs/schemas/domaincommon.rng
Add some vhost definitions, in preparation for a new protocol that
will allow vhost-scsi devices to be specified on a hostdev tag.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/conf/domain_conf.c | 3 ++-
src/conf/domain_
In the case of other SCSI host devices, the device that is created
within the guest will be within the usual SCSI namespace
(e.g., host:bus:target:lun). But for vhost-scsi, the actual naming
structure will come from the host configuration, and will be
invisible to both QEMU and Libvirt. So specif
Add an example of the vhost-scsi hostdev tag, and its associated
definitions, to the domain XML helpfile.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
docs/formatdomain.html.in | 16
1 file changed, 16 inser
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_cgroup.c | 5 +
src/qemu/qemu_conf.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --g
Open /dev/vhost-scsi, and record the resulting file descriptor, so that
the guest has access to the host device outside of the libvirt daemon.
Pass this information, along with data parsed from the XML file, to build
a device string for the qemu command line. That device string will be
for either
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24
.../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 33 ++
tests/qemuxml2arg
Since the vhost-scsi protocol for hostdev tags has no child
elements within its source tag, we can use a self-closing
source tag to make the resulting XML a little cleaner.
Suggested-by: Bjoern Walk
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/conf
Starting two guests using the same vhost-scsi target results
in an error when opening /dev/vhost-scsi. Since "shareable"
suggests there's a way around this, let's disallow this tag
when using vhost-scsi protocol for our hostdev device.
Suggested-by: Marc Hartmayer
Signed-off-by: Eric Farman
Rev
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests/qemuca
Validate an XML schema that contains the vhost protocol in its
hostdev tag.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 12
1 file changed, 12 insertions(+)
diff --git a/docs/schemas/domaincommon.rng b/docs
Add code that will permit a hostdev tag to specify a vhost protocol,
and parse the associated XML within it. But don't do anything with
that information just yet.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/conf/domain_conf.c | 38
The idea of vhost-scsi is to have a controller-less host device that
carries all LUNs, so (silently) creating a virtio-scsi controller is
not necessary here. Let's get adjust the comparison so we don't
accidentally make one.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris
Let's adjust some of the indentation in the command line code for the
upcoming vhost-scsi support, so we can keep existing code separate
from the new code that we'll add.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 22 --
1 file cha
When issuing virsh dumpxml and parsing a hostdev element,
the vhost-scsi protocol needs to be handled separately from
the existing options, to create valid XML.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/conf/domain_conf.c | 20 ---
Adjust the device string that is built for vhost-scsi devices so that it
can be invoked from hotplug.
>From the QEMU command line, the file descriptors are expect to be numeric only.
However, for hotplug, the file descriptors are expected to begin with at least
one alphabetic character else this e
Let's adjust some of the indentation in the hotplug code for the
upcoming vhost-scsi support, so we can keep existing code separate
from the new code that we'll add.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu
This patch series provides a libvirt implementation of the vhost-scsi
interface in QEMU. As near as I can see, this was discussed upstream in
July 2014[1], and ended in a desire to replace a vhost-scsi controller
in favor of a hostdev element instead[2].
There is no capability check in this serie
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Also, do a little minor formatting in virHostdevReAttachSCSIDevices,
to match the similar functions elsewhere.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/util/virhostdev.c | 13 ++-
We're going to make some changes here, and the boolean logic
does not lend itself to be easily expanded.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_conf.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff -
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/security/security_apparmor.c | 5 +++--
src/security/security_dac.c | 10 ++
On 07/23/2016 05:34 AM, Joao Martins wrote:
> On 07/22/2016 10:50 PM, Jim Fehlig wrote:
>> On 07/20/2016 04:48 PM, Joao Martins wrote:
>>> Introduce initial support for domainBlockStats API call that
>>> allow us to query block device statistics. openstack nova
>>> uses this API call to query block
From: Prasanna Kumar Kalever
To allow using failover with gluster it's necessary to specify multiple
volume hosts. Add support for starting qemu with such configurations.
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 2 +-
src/qemu/qemu_command.c
Move the iterator of objects to the recursive function so that nested
objects are supported by flattening the structure with '.' delimiters.
---
src/util/virqemu.c | 70 ++---
tests/qemucommandutiltest.c | 8 ++
2 files changed, 61 insertions(+
To allow richer definitions of disk sources add infrastructure that will
allow to register functionst generating a JSON object based definition.
This infrastructure will then convert the definition to the proper
command line syntax and use it in cases where it's necessary. This will
allow to keep
Allow using 'ssh' protocol in backing chains and later for disks
themselves.
---
src/libxl/libxl_conf.c| 1 +
src/qemu/qemu_command.c | 7 +++
src/qemu/qemu_driver.c| 3 +++
src/qemu/qemu_parse_command.c | 1 +
src/util/virstoragefile.c | 4 +++-
src/util/virstoragefi
---
src/util/virstoragefile.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index c4dcd48..5b896ff 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -2746,6 +2746,30 @@ virStorageSourcePa
Failure to parse a XML that was not supposed to fail would result into a
crash in the test suite as the vcpu bitmap would not be filled prior to
the active XML->XML test.
Skip formatting of the vcpu snippet in the fake status XML formatter in
such case to avoid the crash. The test would fail anywa
Add support for converting objects nested in arrays with a numbering
discriminator on the command line. This syntax is used for the
object-based specification of disk source properties.
---
src/libvirt_private.syms| 1 +
src/util/virqemu.c | 33 +
src/
As gluster natively supports multiple hosts for failover reasons we can
easily add the support to the storage driver code in libvirt.
Extract the code setting an individual host into a separate function and
call them in a loop. The new code also tries to keep the debug log
entries sane.
---
src/s
The iterator function (second argument) already requires that the object
is handled as 'const' thus we won't modify the object itself.
---
src/util/virjson.c | 2 +-
src/util/virjson.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virjson.c b/src/util/virjson.c
in
Extract the code so that it can be called from multiple places. This
also removes a tricky fallthrough in the large switch in
qemuBuildNetworkDriveStr.
---
src/qemu/qemu_command.c | 122 +++-
1 file changed, 68 insertions(+), 54 deletions(-)
diff --git
The disk source formatting code grew rather ugly and complex and it will
get worse. Extract it into a separated function to contain the mess.
---
src/qemu/qemu_command.c | 159 ++--
1 file changed, 87 insertions(+), 72 deletions(-)
diff --git a/src/qemu
As we already test that the extraction of the backing store string works
well additional tests for the backing store string parser can be made
simpler.
Export virStorageSourceNewFromBackingAbsolute and use it to parse the
backing store strings, format them using virDomainDiskSourceFormat and
match
Refactor the command line generator by adding a wrapper (with
documentation) that will handle the outermost object iteration.
This patch also renames the functions and tweaks the error message for
nested arrays to be more universal.
The new function is then reused to simplify qemucommandutiltest.
Avoid a large block by tweaking the condition skipping empty drives and
split up the switch containing two branches having different purpose.
---
src/qemu/qemu_command.c | 99 +++--
1 file changed, 46 insertions(+), 53 deletions(-)
diff --git a/src/qemu
Along with the legacy URI based syntax add support for the brand-new
fully object based syntax.
---
src/util/virstoragefile.c | 108 ++
tests/virstoragetest.c| 25 +++
2 files changed, 133 insertions(+)
diff --git a/src/util/virstoragefile.
http(s), ftp(s) and tftp use URIs for volume definitions in the JSON
pseudo protocol so it's pretty straightforward to add support for them.
---
src/util/virstoragefile.c | 43 +++
tests/virstoragetest.c| 8
2 files changed, 51 insertions(+)
d
The function builds also non-uri strings for the various protocols.
---
src/qemu/qemu_command.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 3d6e4b5..96cc202 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qem
For use with memory hotplug virQEMUBuildCommandLineJSONRecurse attempted
to format JSON arrays as bitmap on the command line. Make the formatter
function configurable so that it can be reused with different syntaxes
of arrays such as numbered arrays for use with disk sources.
This patch extracts t
Until now the JSON->commandline convertor was used only for objects
created by qemu. To allow reusing it with disk formatter we'll need to
escape ',' as usual in qemu commandlines.
---
src/util/virqemu.c | 3 ++-
tests/qemucommandutiltest.c | 1 +
2 files changed, 3 insertions(+), 1 delet
Add a modular parser that will allow to parse 'json' backing definitions
that are supported by qemu. The initial implementation adds support for
the 'file' driver.
---
src/util/virstoragefile.c | 87 +++
tests/virstoragetest.c| 8 +
2 files chan
The function would generate a leading comma. Let the callers properly
add commas by formatting the commas at the end and trimming the trailing
one.
---
src/util/virqemu.c | 22 ++
tests/qemucommandutiltest.c | 10 ++
2 files changed, 16 insertions(+), 16 deleti
---
src/util/virstoragefile.c | 38 ++
tests/virstoragetest.c| 9 +
2 files changed, 47 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 41fbc96..92e0006 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/vi
This is a updated take based on stuff I had laying around and parts from
https://www.redhat.com/archives/libvir-list/2016-July/msg00872.html
This addresses the backing store parser, adds and improves bits to the
JSON->commandline generator prior to plugging in the gluster support.
This series doe
iSCSI is a bit odd in this aspect since it only supports URIs but using
the 'filename' property and does not have any alternative syntax.
---
src/util/virstoragefile.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
i
JSON pseudo protocol for qemu allows to explicitly specify devices.
Add convertor to the internal type.
---
src/util/virstoragefile.c | 2 ++
tests/virstoragetest.c| 6 ++
2 files changed, 8 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 826e4ba..2e
---
src/util/virstoragefile.c | 45 +
tests/virstoragetest.c| 14 ++
2 files changed, 59 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 9fc260b..c4dcd48 100644
--- a/src/util/virstoragefile.c
+++ b
I made this discussion a private one by mistake, so it's time for some
storytelling:
*Christophe Fergeau wrote:*
> For what it's worth, this patch series
https://www.redhat.com/archives/libvir-list/2016-March/msg00993.html
would have allowed not to have to implement this both for VNC and SPICE.
No
On Mon, Jul 25, 2016 at 12:56:44PM +0100, Zeeshan Ali (Khattak) wrote:
> In my attempt to add a message to the patch series summarising the
> changes, I managed to add bogus emails in To and BCC fields. Please
> remove those when you reply.
>
> Changes in v8: gvir_config_domain_hostdev_pci_get_rom
On Mon, Jul 25, 2016 at 12:46:52PM +0100, Zeeshan Ali (Khattak) wrote:
> +void gvir_config_domain_hostdev_pci_set_address(GVirConfigDomainHostdevPci
> *hostdev,
> +GVirConfigDomainAddressPci
> *address)
> +{
> +GVirConfigObject *source;
> +x
On Sat, Jul 23, 2016 at 03:47:12AM +0200, Tomasz Flendrich wrote:
The address sets (pci, ccw, virtio serial) are currently cached
in qemu private data, but all the information required to recreate
these sets is in the domain definition. Therefore I am removing
the redundant data and adding a way
On Mon, Jul 25, 2016 at 05:26:48PM +0200, Pavel Hrdina wrote:
Commit 4a585a88 introduced searching QOM device path by alias, let's use it for
memballoon too. This may speedup the search because in most cases we will find
the correct QOM device path directly by using alias without the need for th
Commit 4a585a88 introduced searching QOM device path by alias, let's use it for
memballoon too. This may speedup the search because in most cases we will find
the correct QOM device path directly by using alias without the need for the
recursion code.
Signed-off-by: Pavel Hrdina
---
src/qemu/qe
On Sat, Jul 23, 2016 at 03:47:11AM +0200, Tomasz Flendrich wrote:
Dropping the caching of ccw address set.
The cached set is not required anymore, because the set is now being
recalculated from the domain definition on demand, so the cache
can be deleted.
---
src/qemu/qemu_domain.c | 1 -
On Sat, Jul 23, 2016 at 03:47:10AM +0200, Tomasz Flendrich wrote:
Dropping the caching of ccw address set.
Instead of using the cached address set, functions in qemu_hotplug.c
now recalculate it on demand.
---
src/qemu/qemu_hotplug.c | 26 +-
1 file changed, 21 insertions(+
On Sat, Jul 23, 2016 at 03:47:08AM +0200, Tomasz Flendrich wrote:
Dropping the caching of virtio serial address set.
The cached set is not required anymore, because the set is now being
recalculated from the domain definition on demand, so the cache
can be deleted.
This patch shows how useless
On Sat, Jul 23, 2016 at 03:47:07AM +0200, Tomasz Flendrich wrote:
Dropping the caching of virtio serial address set.
Instead of using the cached address set, a function in qemu_hotplug.c
now recalculates it on demand.
Credit goes to Cole Robinson.
---
src/qemu/qemu_hotplug.c | 38 +++
On Mon, Jul 25, 2016 at 03:53:42PM +0200, Ján Tomko wrote:
Use virAsprintf to prepend an underscore to make the code more
readable.
---
src/util/vircgroup.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 04f3818..07cd7f
Hi Daniel,
Thanks for your help about my bug fix. Now I find that I can't delete
instance with nvram. The problem is really serious for AArch64, since it
always needs uefi.
I'm now working on this bug:
https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1567807, it's about
Nova can't del
On Sat, Jul 23, 2016 at 03:47:06AM +0200, Tomasz Flendrich wrote:
The address sets (pci, ccw, virtio serial) are currently cached
in qemu private data, but all the information required to recreate
these sets is in the domain definition. Therefore I am removing
the redundant data and adding a way
On Mon, Jul 25, 2016 at 03:51:49PM +0200, Martin Kletzander wrote:
> On Mon, Jul 25, 2016 at 02:41:01PM +0200, Pavel Hrdina wrote:
> >Commit ce745914 introduced detection of actual video ram sizes to fix
> >migration
> >if QEMU decide to modify the values provided by libvirt. This works
> >perfe
Use virAsprintf to prepend an underscore to make the code more
readable.
---
src/util/vircgroup.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 04f3818..07cd7f6 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgrou
On Mon, Jul 25, 2016 at 02:41:01PM +0200, Pavel Hrdina wrote:
Commit ce745914 introduced detection of actual video ram sizes to fix migration
if QEMU decide to modify the values provided by libvirt. This works perfectly
for domains with number of video devices up to two.
If there are more than
Commit ce745914 introduced detection of actual video ram sizes to fix migration
if QEMU decide to modify the values provided by libvirt. This works perfectly
for domains with number of video devices up to two.
If there are more than two video devices in the guest all the secondary devices
in the
Purely cosmetic change to be consistent with the other names.
Signed-off-by: Henning Schild
---
Something i found in an old staging queue and that might be considered
useful.
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c | 4 ++--
tests/q
Signed-off-by: Pavel Hrdina
---
Pushed
setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index 099b1e0..936aeb4 100755
--- a/setup.py
+++ b/setup.py
@@ -305,7 +305,7 @@ class my_clean(clean):
_c_modules, _py_modules = get_module_lists()
setup(n
On Mon, Jul 25, 2016 at 01:24:07PM +0200, Pavel Hrdina wrote:
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
Some time ago I went through the trouble to make support for perl module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed
Hi,
In my attempt to add a message to the patch series summarising the
changes, I managed to add bogus emails in To and BCC fields. Please
remove those when you reply.
Changes in v8: gvir_config_domain_hostdev_pci_get_rom_bar() simplified
as per review comment.
On Mon, Jul 25, 2016 at 12:46 PM,
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
Add API to read and write PCI hostdev nodes.
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-hostdev-pci.c | 222 +
.../libvirt-gconfig-domain-hostdev-pci.h | 81
libvirt-gconfig/libvirt-gconfig-domain-hos
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
Add API to read and write domain/devices/hostdev nodes. This patch only
adds the baseclass and hence is not useful on it's own. A more specific
subclass to represent PCI devices will be added in a following patch.
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
> Some time ago I went through the trouble to make support for perl module
> requirements in our bootstrap. Even though we require it in the
> bootstrap, it was not listed as a build requirement in the specfile.
Is this required t
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
Some time ago I went through the trouble to make support for perl module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Yes, of course this
Some time ago I went through the trouble to make support for perl module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Signed-off-by: Martin Kletzander
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+
On Mon, Jul 25, 2016 at 10:08 AM, Christophe Fergeau
wrote:
> On Fri, Jul 22, 2016 at 01:43:35PM +0100, Zeeshan Ali (Khattak) wrote:
>> +gboolean
>> gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci
>> *hostdev)
>> +{
>> +xmlNodePtr hostdev_node;
>> +xmlNodePtr rom_no
ping
Update: Patches 7-9 do resolve bz 1289391
Tks -
John
On 07/19/2016 10:30 AM, John Ferlan wrote:
> v1: http://www.redhat.com/archives/libvir-list/2016-June/msg02207.html
>
> Changes since v1...
> - Use the bz noted by Cole from the v1 series
> - Merged in recent hotplug cleanup changes
ping?
Tks -
John
On 07/18/2016 07:37 AM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1356436
>
> Details in patches.
>
> John Ferlan (2):
> util: Introduce virISCSINodeNew
> iscsi: Establish connection to target via static target login
>
> src/libvirt_private.syms
On Mon, Jul 25, 2016 at 10:02:41AM +0100, Daniel P. Berrange wrote:
On Sat, Jul 23, 2016 at 09:13:13AM +0200, Martin Kletzander wrote:
On Thu, Jul 21, 2016 at 09:49:18AM -0400, Aaron Shindman wrote:
> The wiki page at
>
http://wiki.libvirt.org/page/I_created_an_external_snapshot,_but_libvirt_wo
On Sat, Jul 16, 2016 at 02:42:45AM +0200, Tomasz Flendrich wrote:
Changes in v2:
* rebased
This patch requires another one, otherwise a small conflict appears:
https://www.redhat.com/archives/libvir-list/2016-July/msg00402.html
In qemu_driver.c, two functions were split to have less responsibil
On Sat, Jul 16, 2016 at 02:42:55AM +0200, Tomasz Flendrich wrote:
This is the first testcase for qemuhotplugtest for attaching and
detaching a device to the persistent domain.
---
tests/qemuhotplugtest.c| 7
.../qemuhotplug-base-config+qemu-agent+config.xml | 45
On Sat, Jul 16, 2016 at 02:42:53AM +0200, Tomasz Flendrich wrote:
More generic functions, qemuDomainAttachDeviceLiveAndConfig
and qemuDomainDetachDeviceLiveAndConfig, are now used instead
of other functions in qemuhotplugtest to attach and detach devices.
---
tests/qemuhotplugtest.c | 157 ++
On Sat, Jul 16, 2016 at 02:42:49AM +0200, Tomasz Flendrich wrote:
This will make splitting up qemuDomainDetachDeviceFlags into two
functions easier.
---
src/qemu/qemu_driver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
On Sat, Jul 16, 2016 at 02:42:52AM +0200, Tomasz Flendrich wrote:
Attaching to both live and config will soon be tested, so
testQemuHotplugCheckResult will be used on both def and newDef.
Or you could just pass the modification impact flag in as well and
select ->def or ->newDef based on that.
On Sat, Jul 16, 2016 at 02:42:54AM +0200, Tomasz Flendrich wrote:
It was previously working only with attachments/detachments
to the live domain. Now it can test attaching/detaching to
the persistent domain too.
---
tests/qemuhotplugtest.c | 43 +++
1 file
On Sat, Jul 16, 2016 at 02:42:51AM +0200, Tomasz Flendrich wrote:
They will be used to test device attachment and detachment, so
they have to be visible to the outside.
---
src/qemu/qemu_driver.c | 4 ++--
src/qemu/qemu_driver.h | 14 ++
2 files changed, 16 insertions(+), 2 deletions(
On Sat, Jul 16, 2016 at 02:42:46AM +0200, Tomasz Flendrich wrote:
We want to be able to pass a NULL instead of the connection
and use this function in tests. To achieve this, the virConnectPtr
is passed instead of virDomainPtr, and the driver is a new separate
parameter.
---
src/qemu/qemu_driver
On Fri, Jul 22, 2016 at 08:10:47PM +0200, Tomasz Flendrich wrote:
There's a plan to rework the address handling, so testcases
that verify hotplugging ccw devices will help in avoiding
regression.
In this commit, some files are duplicated because of the way
qemuhotplug.c calculates the expected x
On Fri, Jul 22, 2016 at 01:43:35PM +0100, Zeeshan Ali (Khattak) wrote:
> +gboolean
> gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci
> *hostdev)
> +{
> +xmlNodePtr hostdev_node;
> +xmlNodePtr rom_node;
> +const gchar *bar_str;
> +
> +g_return_val_if_fail(GVIR
1 - 100 of 103 matches
Mail list logo
