At 2016-08-05 15:23:52, "Chen Hanxiao" wrote:
>From: Chen Hanxiao
>
>In libvirt, snapshot means disk snapshot.
>snapshot --live is more like VM checkpoint.
>Make it clear in virsh.pod.
>
>Signed-off-by: Chen Hanxiao
>---
> tools/virsh.pod | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(
At 2016-08-09 19:02:18, "Daniel P. Berrange" wrote:
>On Tue, Aug 09, 2016 at 05:57:44PM +0800, Chen Hanxiao wrote:
>>
>> At 2016-08-08 23:19:26, "Daniel P. Berrange" wrote:
>> >On Mon, Aug 08, 2016 at 05:00:38PM +0200, Michal Privoznik wrote:
>> >> Dear list,
>> >>
>> >> while wiring qemu-ga in
在 2016-08-09 19:03:32，"Andrea Bolognani" 写道：
>On Mon, 2016-08-08 at 16:19 +0100, Daniel P. Berrange wrote:
>> IOW, I don't think we should ever expose the qemu guest agent exec command
>> via libvirt APIs.
>>
>> If people want a general purpose exec facility, they can trivially write
>> a much be
On 08/09/2016 09:11 AM, Andrea Bolognani wrote:
On Mon, 2016-08-08 at 04:56 -0400, Laine Stump wrote:
These patches use three methods to get more of the PCI devices onto PCIe
slots on Q35 and aarch64/virt machinetypes:
1) When virtio devices can present themselves as PCIe if they're
plu
On 08/08/2016 12:35 PM, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1227354
Translate the optional attribute to
disable-legacy=on/off and disable-modern=on/off options
for the following devices:
virtio-balloon-pci
virtio-blk-pci
virtio-scsi-pci
On 08/08/2016 12:35 PM, Ján Tomko wrote:
Check whether the disable-legacy property is present on the following
devices:
virtio-balloon-pci
virtio-blk-pci
virtio-scsi-pci
virtio-net-pci
virtio-gpu-pci
Assuming that if QEMU knows other virtio devices where this property
is applicabl
On 08/08/2016 12:35 PM, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1227354
---
docs/formatdomain.html.in | 9 +++
docs/schemas/domaincommon.rng | 16
src/conf/domain_conf.c | 86 ++
On Tue, 2016-08-09 at 12:39 +, Jason Miesionczek wrote:
> ---
> src/hyperv/hyperv_driver.c | 106
> +++-
> src/hyperv/hyperv_private.h | 2 +
> 2 files changed, 107 insertions(+), 1 deletion(-)
>
>
It seems that there was initial review [1] done fo
On Tue, 2016-08-09 at 12:39 +, Jason Miesionczek wrote:
> ---
> src/hyperv/hyperv_driver.c | 52
> ++
> 1 file changed, 52 insertions(+)
>
> diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
> index 4a5e80d..b2d1abf 100644
> --- a
On Tue, Aug 09, 2016 at 04:21:39PM +0200, Erik Skultety wrote:
After commit 9d479dd1 fiddled with the cmdConnect's output which used to be a
bit more verbose prior to the mentioned commit, the program flow would result
in a quite confusing error if an invalid URI has been provided:
error: Fai
On 08/09/2016 03:54 AM, Daniel P. Berrange wrote:
On Mon, Aug 08, 2016 at 04:56:55AM -0400, Laine Stump wrote:
When faced with a guest device that requires a PCI address but doesn't
have one manually assigned in the config, libvirt has always insisted
(well... *tried* to insist) on auto-assignin
On 08/09/2016 04:05 AM, Daniel P. Berrange wrote:
On Mon, Aug 08, 2016 at 12:41:48PM -0400, Laine Stump wrote:
On 08/08/2016 04:56 AM, Laine Stump wrote:
When faced with a guest device that requires a PCI address but doesn't
have one manually assigned in the config, libvirt has always insisted
https://bugzilla.redhat.com/show_bug.cgi?id=1240439
In this function we create a macvtap device and open its tap
device. Possibly multiple times. Not the thing is, if opening the
tap device fails, that is virNetDevMacVLanTapOpen() returns a
negative value, we unroll all the changes BUT return 0 fo
Le sigh. How come this slipped uncaught for that long?
Michal Privoznik (3):
virNetDevMacVLanCreateWithVPortProfile: Don't mask
virNetDevMacVLanTapOpen error
virNetDevMacVLanCreateWithVPortProfile: Drop @rc
virNetDevMacVLanCreateWithVPortProfile: Drop @ret
src/util/virnetdevmacvlan.c |
Usually, this variable is used to hold the return value for a
function of ours. Well, this is not the case. Its use does not
match our pattern and therefore it is very misleading. Drop it
and define an alternative @rc variable, but only in that single
block where it is needed.
Signed-off-by: Micha
This variable is very misleading. We use VIR_FORCE_CLOSE to set
it to -1 and returning it even though it does not refer to a FD
at all. It merely holds 0 or -1. Drop it completely.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 35 ---
1 file ch
On Tue, 2016-08-09 at 11:59 -0400, Laine Stump wrote:
> > One thing that's not quite clear to me about pcie-expander-bus:
> > according to the code and comment, it has a single slot that
> > can accomodate either a pcie-root-port or a dmi-to-pci-bridge.
> >
> > It seems like that would limit its u
On 08/09/2016 05:01 AM, Andrea Bolognani wrote:
On Sat, 2016-08-06 at 19:22 -0400, Laine Stump wrote:
More misunderstanding/mistaken assumptions on my part - I had thought
that a pci-expander-bus could be plugged into any legacy PCI slot, and
that pcie-expander-bus could be plugged into any PCIe
On 08/09/2016 08:13 AM, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
So, I went through the patches. They look okay. But require some
polishing before they can be merged.
Your review and feedback is much appreciated, thank you! I'll get a v2
up as soon as I can, thought i
It doesn’t exist in the SOAP response
> On Aug 9, 2016, at 11:33 AM, Neal Gompa wrote:
>
> On Tue, Aug 9, 2016 at 8:39 AM, Jason Miesionczek
> wrote:
>
>> +class Win32_OperatingSystem
>> + string BootDevice
>> + string BuildNumber
>> + string BuildType
>> + strin
On Tue, Aug 9, 2016 at 8:39 AM, Jason Miesionczek
wrote:
> +class Win32_OperatingSystem
> + string BootDevice
> + string BuildNumber
> + string BuildType
> + string Caption
> + string CodeSet
> + string CountryCode
> + string CreationClassNa
On 08/09/2016 10:54 AM, Daniel P. Berrange wrote:
On Tue, Aug 09, 2016 at 10:44:44AM -0400, Eric Farman wrote:
On 08/09/2016 08:22 AM, Daniel P. Berrange wrote:
+
+
+
I'm not sure this syntax really makes sense.
IIRC, currently is used to passthrough an individual
SCSI LUNs
On 08/08/2016 03:34 PM, Jovanka Gulicoska wrote:
> Add nodedev-event support for node device lifecycle events
> ---
> tools/virsh-nodedev.c | 187
> ++
> tools/virsh.pod | 18 +
> 2 files changed, 205 insertions(+)
ACK and pushed
- Cole
On Fri, Aug 05, 2016 at 03:56:03PM +0200, Peter Krempa wrote:
> Add support for retrieving information regarding hotpluggable cpu units
> supported by qemu. Data returned by the command carries information
> needed to figure out the granularity of hotplug, the necessary cpu type
> name and the topo
On Tue, Aug 09, 2016 at 10:44:44AM -0400, Eric Farman wrote:
>
>
> On 08/09/2016 08:22 AM, Daniel P. Berrange wrote:
> > On Tue, Aug 09, 2016 at 02:13:29PM +0200, Michal Privoznik wrote:
> > > On 25.07.2016 22:48, Eric Farman wrote:
> > > > The qemuxml2argv test was cloned from hostdev-scsi-virti
On 08/09/2016 08:22 AM, Daniel P. Berrange wrote:
On Tue, Aug 09, 2016 at 02:13:29PM +0200, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemu
After commit 9d479dd1 fiddled with the cmdConnect's output which used to be a
bit more verbose prior to the mentioned commit, the program flow would result
in a quite confusing error if an invalid URI has been provided:
error: Failed to connect to the admin server
Connected to the admin se
On 09/08/16 16:04, Jiri Denemark wrote:
> On Tue, Aug 09, 2016 at 15:43:57 +0200, Erik Skultety wrote:
>> Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin
>> server but it messed up the checks:
>>
>> if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0)
On Tue, Aug 09, 2016 at 15:43:57 +0200, Erik Skultety wrote:
> Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin
> server but it messed up the checks:
>
> if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0)
> return -1;
> else if (VIR_STRD
The generated command line wouldn't work since QEMU doesn't know what
'cmt' is. The following patch will fix this issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1355857
Signed-off-by: Jiri Denemark
---
.../qemuxml2argv-cpu-host-model-cmt.args | 22 ++
.../qemux
Since the introduction of CMT features (commit v1.3.5-461-gf294b83)
starting a domain with host-model CPU on a host which supports CMT fails
because QEMU complains about unknown 'cmt' feature:
qemu-system-x86_64: CPU feature cmt not found
https://bugzilla.redhat.com/show_bug.cgi?id=1355857
S
By removing a non-migratable feature in a for loop we would fail to drop
every second non-migratable feature if the features array contained
several of them in a row.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index d9646eb..7bb2bb6 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -767,6 +767,22 @@ x
Since the introduction of CMT features (commit v1.3.5-461-gf294b83)
starting a domain with host-model CPU on a host which supports CMT fails
because QEMU complains about unknown 'cmt' feature:
qemu-system-x86_64: CPU feature cmt not found
https://bugzilla.redhat.com/show_bug.cgi?id=1355857
J
Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin
server but it messed up the checks:
if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0)
return -1;
else if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0)
return -1;
So if a clien
On Fri, Aug 05, 2016 at 03:56:02PM +0200, Peter Krempa wrote:
> To allow matching up the data returned by query-cpus to entries in the
> query-hotpluggable-cpus reply to allow for CPU hotplug it's necessary to
s/ to allow//
> extract the QOM path as it's the only link between the two.
> ---
> sr
On Mon, 2016-08-08 at 04:56 -0400, Laine Stump wrote:
> These patches use three methods to get more of the PCI devices onto PCIe
> slots on Q35 and aarch64/virt machinetypes:
>
> 1) When virtio devices can present themselves as PCIe if they're
>plugged into a PCIe controller, do that. (This ca
---
src/hyperv/hyperv_driver.c | 807 +
1 file changed, 807 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index bd028ed..716fadb 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -2275,6 +22
---
src/hyperv/hyperv_driver.c | 117 +
1 file changed, 117 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index daae371..db59ce1 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -2090,6 +20
---
src/hyperv/hyperv_driver.c | 52 ++
1 file changed, 52 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 4a5e80d..b2d1abf 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -1349,6 +134
---
src/Makefile.am| 1 +
src/hyperv/hyperv_driver.c | 2 +
src/hyperv/hyperv_network_driver.c | 124 +
src/hyperv/hyperv_network_driver.h | 30 +
src/hyperv/hyperv_wmi.c| 39
src/hyperv/hyperv_w
The following patches include work originally done by Yves Vinter back
in 2014. The last patch introduces support for Hyper-V 2012, while still
supporting 2008. I am not sure that the method I used to include the 2012
support is the best approach, mainly due to code duplication, but I am
open to su
---
src/hyperv/hyperv_wmi_generator.input | 485 ++
1 file changed, 485 insertions(+)
diff --git a/src/hyperv/hyperv_wmi_generator.input
b/src/hyperv/hyperv_wmi_generator.input
index 97f9dff..28a5bdc 100644
--- a/src/hyperv/hyperv_wmi_generator.input
+++ b/src/hyp
---
src/hyperv/hyperv_driver.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 7d956d3..861d5ab 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -1573,6 +1573,37 @@ hyperv
---
src/hyperv/hyperv_driver.c | 72 ++
1 file changed, 72 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index db59ce1..bd028ed 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -2205,6 +220
---
src/hyperv/hyperv_driver.c | 127 +
1 file changed, 127 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 2623916..348b39c 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -1737,6 +17
---
src/Makefile.am | 1 +
src/hyperv/hyperv_driver.c| 62 ++-
src/hyperv/hyperv_driver_2012.c | 299 ++
src/hyperv/hyperv_driver_2012.h | 55 +++
src/hyperv/hyperv_private.h | 4 +
src/hyperv/hyp
---
src/hyperv/hyperv_driver.c | 232
src/hyperv/hyperv_private.h | 2 +
2 files changed, 234 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 348b39c..daae371 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src
---
src/hyperv/hyperv_driver.c | 176 +
1 file changed, 176 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index b2d1abf..7d956d3 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -1401,6 +14
---
src/hyperv/hyperv_driver.c | 106 +++-
src/hyperv/hyperv_private.h | 2 +
2 files changed, 107 insertions(+), 1 deletion(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index b642a02..4a5e80d 100644
--- a/src/hyperv/hyperv_dri
---
src/hyperv/hyperv_network_driver.c | 156 +
1 file changed, 156 insertions(+)
diff --git a/src/hyperv/hyperv_network_driver.c
b/src/hyperv/hyperv_network_driver.c
index 00037ae..68f03e5 100644
--- a/src/hyperv/hyperv_network_driver.c
+++ b/src/hyperv/hyper
---
src/hyperv/hyperv_driver.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 4c094e7..2623916 100644
--- a/src/hyperv/hyperv_driver.c
+++ b/src/hyperv/hyperv_driver.c
@@ -1704,6 +1704,39 @@ hyp
also added ability to get/set auto start
---
src/hyperv/hyperv_driver.c | 101 +++
src/hyperv/hyperv_wmi.c| 670 -
src/hyperv/hyperv_wmi.h| 58
src/hyperv/openwsman.h | 4 +
4 files changed, 827 insertions(+), 6 deletions(-)
diff
---
src/hyperv/hyperv_wmi_generator.py | 57 --
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git a/src/hyperv/hyperv_wmi_generator.py
b/src/hyperv/hyperv_wmi_generator.py
index f767d54..8384634 100755
--- a/src/hyperv/hyperv_wmi_generator.py
+++ b/s
On Mon, Jul 25, 2016 at 04:48:11PM -0400, Eric Farman wrote:
> Open /dev/vhost-scsi, and record the resulting file descriptor, so that
> the guest has access to the host device outside of the libvirt daemon.
> Pass this information, along with data parsed from the XML file, to build
> a device stri
On Tue, Aug 09, 2016 at 02:13:29PM +0200, Michal Privoznik wrote:
> On 25.07.2016 22:48, Eric Farman wrote:
> > The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
> >
> > Signed-off-by: Eric Farman
> > Reviewed-by: Boris Fiuczynski
> > ---
> > .../qemuxml2argv-hostdev-scsi-vhost-scs
On 25.07.2016 22:48, Eric Farman wrote:
> When issuing virsh dumpxml and parsing a hostdev element,
> the vhost-scsi protocol needs to be handled separately from
> the existing options, to create valid XML.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczynski
On 25.07.2016 22:48, Eric Farman wrote:
> Since the vhost-scsi protocol for hostdev tags has no child
> elements within its source tag, we can use a self-closing
> source tag to make the resulting XML a little cleaner.
>
> Suggested-by: Bjoern Walk
> Signed-off-by: Eric Farman
> Reviewed-by: Bjo
On 25.07.2016 22:48, Eric Farman wrote:
> Validate an XML schema that contains the vhost protocol in its
> hostdev tag.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczynski
> ---
> docs/schemas/domaincommon.rng | 12
> 1 file changed, 12 insert
On 25.07.2016 22:48, Eric Farman wrote:
> Add some vhost definitions, in preparation for a new protocol that
> will allow vhost-scsi devices to be specified on a hostdev tag.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Bjoern Walk
> Reviewed-by: Marc Hartmayer
> Reviewed-by: Boris Fiuczynski
On 25.07.2016 22:48, Eric Farman wrote:
> Add code that will permit a hostdev tag to specify a vhost protocol,
> and parse the associated XML within it. But don't do anything with
> that information just yet.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczyn
On 25.07.2016 22:48, Eric Farman wrote:
> Add an example of the vhost-scsi hostdev tag, and its associated
> definitions, to the domain XML helpfile.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Bjoern Walk
> Reviewed-by: Marc Hartmayer
> Reviewed-by: Boris Fiuczynski
> ---
> docs/formatdoma
On 25.07.2016 22:48, Eric Farman wrote:
> Open /dev/vhost-scsi, and record the resulting file descriptor, so that
> the guest has access to the host device outside of the libvirt daemon.
> Pass this information, along with data parsed from the XML file, to build
> a device string for the qemu comma
On 25.07.2016 22:48, Eric Farman wrote:
>
So, I went through the patches. They look okay. But require some
polishing before they can be merged. Also, I'd love to test this but I
don't have HW to do so :(
Looking forward to v2.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://w
On 25.07.2016 22:48, Eric Farman wrote:
> The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
>
> Signed-off-by: Eric Farman
> Reviewed-by: Boris Fiuczynski
> ---
> .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24
> .../qemuxml2argv-hostdev-scsi-vhost-scsi.xm
On 25.07.2016 22:48, Eric Farman wrote:
> Do all the stuff for the vhost-scsi capability in QEMU,
> so it's in place for our checks later.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Boris Fiuczynski
> ---
> src/qemu/qemu_capabilities.c| 2 ++
> src/qemu/qemu_capab
On 25.07.2016 22:48, Eric Farman wrote:
> Make sure that the new vhost protocol does not drive the existing
> virtio SCSI code.
>
> Also, do a little minor formatting in virHostdevReAttachSCSIDevices,
> to match the similar functions elsewhere.
>
> Signed-off-by: Eric Farman
> Reviewed-by: Boris
On 25.07.2016 22:48, Eric Farman wrote:
> In the case of other SCSI host devices, the device that is created
> within the guest will be within the usual SCSI namespace
> (e.g., host:bus:target:lun). But for vhost-scsi, the actual naming
> structure will come from the host configuration, and will b
On 25.07.2016 22:48, Eric Farman wrote:
> Adjust the device string that is built for vhost-scsi devices so that it
> can be invoked from hotplug.
>
>>From the QEMU command line, the file descriptors are expect to be numeric
>>only.
> However, for hotplug, the file descriptors are expected to begi
On 08/08/16 16:27, Michal Privoznik wrote:
> On 29.07.2016 14:06, Erik Skultety wrote:
>> Just like we decide on which URI we go with based on EUID for qemu in remote
>> driver, do a similar thing for admin except we do not spawn a daemon in this
>> case.
>>
>> Resolves: https://bugzilla.redhat.com
On Mon, 2016-08-08 at 16:19 +0100, Daniel P. Berrange wrote:
> IOW, I don't think we should ever expose the qemu guest agent exec command
> via libvirt APIs.
>
> If people want a general purpose exec facility, they can trivially write
> a much better exec feature via a separate virtio-serial chann
On Tue, Aug 09, 2016 at 05:48:45PM +0800, Chen Hanxiao wrote:
>
> At 2016-08-08 23:00:38, "Michal Privoznik" wrote:
> >Dear list,
> >
> >while wiring qemu-ga into libvirt I've noticed that it has ability to
> >spawn commands inside guest. I haven't paid much attention to it then as
> >implementin
On Tue, Aug 09, 2016 at 05:57:44PM +0800, Chen Hanxiao wrote:
>
> At 2016-08-08 23:19:26, "Daniel P. Berrange" wrote:
> >On Mon, Aug 08, 2016 at 05:00:38PM +0200, Michal Privoznik wrote:
> >> Dear list,
> >>
> >> while wiring qemu-ga into libvirt I've noticed that it has ability to
> >> spawn co
At 2016-08-08 23:19:26, "Daniel P. Berrange" wrote:
>On Mon, Aug 08, 2016 at 05:00:38PM +0200, Michal Privoznik wrote:
>> Dear list,
>>
>> while wiring qemu-ga into libvirt I've noticed that it has ability to
>> spawn commands inside guest. I haven't paid much attention to it then as
>> implemen
At 2016-08-08 23:00:38, "Michal Privoznik" wrote:
>Dear list,
>
>while wiring qemu-ga into libvirt I've noticed that it has ability to
>spawn commands inside guest. I haven't paid much attention to it then as
>implementing libvirt <-> qemu-ga communication was more important. But
>lately couple o
On Tue, 2016-08-09 at 11:19 +0200, Martin Kletzander wrote:
> > for (i = 0; i < nAddrNodes; i++) {
> > -virPCIDeviceAddress addr = { 0, 0, 0, 0, 0 };
> > +virPCIDeviceAddress addr = { 0, 0, 0, 0, false };
>
> Honestly, I have no idea what preferences we have for such
> initiali
On Tue, Aug 09, 2016 at 10:49:04AM +0200, Xian Han Yu wrote:
Signed-off-by: Xian Han Yu
---
You could've been more descriptive in the commit message. Like
describing what's the reason for this change? Just to initialize bool
to 'false' instead 0? Is there something more to it?
src/conf/no
On Sat, 2016-08-06 at 19:22 -0400, Laine Stump wrote:
> More misunderstanding/mistaken assumptions on my part - I had thought
> that a pci-expander-bus could be plugged into any legacy PCI slot, and
> that pcie-expander-bus could be plugged into any PCIe slot. This isn't
> correct - they can both b
Signed-off-by: Xian Han Yu
---
src/conf/node_device_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a23d8ef..96fdb6f 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -1163,7 +11
On Fri, Aug 05, 2016 at 03:56:01PM +0200, Peter Krempa wrote:
> QEMU reports whether 'query-hotpluggable-cpus' is supported for a given
> machine type. Extract and cache the information using the capability
> cache.
> ---
> src/qemu/qemu_capabilities.c | 29 -
> src
On Mon, Aug 08, 2016 at 12:41:48PM -0400, Laine Stump wrote:
> On 08/08/2016 04:56 AM, Laine Stump wrote:
> > When faced with a guest device that requires a PCI address but doesn't
> > have one manually assigned in the config, libvirt has always insisted
> > (well... *tried* to insist) on auto-assi
On Mon, Aug 08, 2016 at 04:56:55AM -0400, Laine Stump wrote:
> When faced with a guest device that requires a PCI address but doesn't
> have one manually assigned in the config, libvirt has always insisted
> (well... *tried* to insist) on auto-assigning an address that is on a
> PCI controller that
On Mon, 2016-08-08 at 15:33 -0400, Laine Stump wrote:
> > Doesn't
> >
> > https://bugzilla.redhat.com/1363648#c4
> >
> > tell us that we *need* to use a pcie-root-port when plugging
> > stuff into a pcie-expander-bus?
>
> No, I think you're misunderstanding Marcel's comment:
>
> > (In reply
83 matches
Mail list logo
