[libvirt] [PATCH 3/3] network: allow limiting a element to certain domains

2016-08-11 Thread Laine Stump
For some unknown reason the original implementation of the element only took advantage of part of the functionality in the dnsmasq feature it exposes - it allowed specifying the ip address of a DNS server which *all* DNS requests would be forwarded to, like this: This is a frontend for dnsma

[libvirt] [PATCH 0/3] Three new network features

2016-08-11 Thread Laine Stump
The first two patches add settings that let you *disable* certain functionality (iptables rules, and the DNS server), while the third enhances the DNS element. Laine Stump (3): network: new network forward mode 'open' network: allow disabling dnsmasq's DNS server network: allow limiting a

[libvirt] [PATCH 1/3] network: new network forward mode 'open'

2016-08-11 Thread Laine Stump
The new forward mode 'open' is just like mode='route', except that no firewall rules are added to assure that any traffic does or doesn't pass. It is assumed that either they aren't necessary, or they will be setup outside the scope of libvirt. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id

[libvirt] [PATCH 2/3] network: allow disabling dnsmasq's DNS server

2016-08-11 Thread Laine Stump
If you define a libvirt virtual network with one or more IP addresses, it starts up an instance of dnsmasq. It's always been possible to avoid dnsmasq's dhcp server (simply don't include a element), but until now it wasn't possible to avoid having the DNS server listening; even if the network has

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Tomasz Flendrich
Hello, please sign me up too. username: tflendrich email: t.flendrich gmail com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] schema: Allow spaces in paths

2016-08-11 Thread Cole Robinson
On 08/11/2016 12:02 PM, Michal Privoznik wrote: > Since ages filesystems allowed to have space characters in > filenames and even directory names. In fact, on all major > filesystems out there you can have whatever character you like > except NULL. There's no reason why we should forbid users to no

Re: [libvirt] [PATCH 12/27] tests: cpu-hotplug: Add data for ppc64 without threads enabled

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:08PM +0200, Peter Krempa wrote: > The reported data is unusual so add it to the test suite. > --- > ...umonitorjson-cpuinfo-ppc64-no-threads-cpus.json | 77 + > ...nitorjson-cpuinfo-ppc64-no-threads-hotplug.json | 125 > + > .../qemum

Re: [libvirt] [PATCH 11/27] tests: cpu-hotplug: Add data for ppc64 out-of-order hotplug

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:07PM +0200, Peter Krempa wrote: > Test the algorithm that extracts the order in which the vcpu entries > were plugged in on a sample of data created by plugging in vcpus > arbitrarily. > --- > ...mumonitorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 221 > +++

Re: [libvirt] [PATCH 10/27] tests: cpu-hotplug: Add data for ppc64 platform including hotplug

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:06PM +0200, Peter Krempa wrote: > Power 8 platform's basic hotpluggable unit is a core rather than a > thread for x86_64 family. This introduces most of the complexity of the > matching code and thus needs to be tested. > > The test data contain data captured from in-

[libvirt] [PATCH] schema: Allow spaces in paths

2016-08-11 Thread Michal Privoznik
Since ages filesystems allowed to have space characters in filenames and even directory names. In fact, on all major filesystems out there you can have whatever character you like except NULL. There's no reason why we should forbid users to not have spaces in their filenames. Moreover, if we do tha

[libvirt] [PATCH 0/3] Node device update lifecycle event as top level event

2016-08-11 Thread Jovanka Gulicoska
Introduce node device update lifecycle as top level event. Series include API implementation, udev driver implementation, event-test implementation and virsh nodedev-event changes. Jovanka Gulicoska (3): Introduce node device update event as top level event virsh: nodedev-event update callback

[libvirt] [PATCH 1/3] Introduce node device update event as top level event

2016-08-11 Thread Jovanka Gulicoska
Also includes node device update event implementation for udev backend. Node device Update API: virConnectNodeDeviceEventUpdateCallback --- daemon/remote.c| 29 include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_event.c | 55

[libvirt] [PATCH 3/3] event-test: add support node device update event API

2016-08-11 Thread Jovanka Gulicoska
--- examples/object-events/event-test.c | 12 1 file changed, 12 insertions(+) diff --git a/examples/object-events/event-test.c b/examples/object-events/event-test.c index 2f9756a..730cb8b 100644 --- a/examples/object-events/event-test.c +++ b/examples/object-events/event-test.c @@

[libvirt] [PATCH 2/3] virsh: nodedev-event update callback support

2016-08-11 Thread Jovanka Gulicoska
--- tools/virsh-nodedev.c | 62 --- 1 file changed, 54 insertions(+), 8 deletions(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index d3d3fc1..7676dcc 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -756,19 +756,21

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 10:17:34AM -0400, Laine Stump wrote: On 08/11/2016 09:31 AM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrot

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Nishith Shah
I don't have an account as well. username: nishithshah2211 email: nishithshah.2...@gmail.com Thanks, Nishith On Thu, Aug 11, 2016 at 7:01 PM, Cole Robinson wrote: > Next week is the time for GSOC students to submit their Final Evaluations. > Work needs to be hosted/linked from a public URL. Ce

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Jovanka Gulicoska
I'll need an account. username: gulic or jgulic email: jovanka.gulico...@gmail.com Thanks, Jovanka On Thu, Aug 11, 2016 at 3:31 PM, Cole Robinson wrote: > Next week is the time for GSOC students to submit their Final Evaluations. > Work needs to be hosted/linked from a public URL. Cedric sugg

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Cole Robinson
On 08/11/2016 10:26 AM, Daniel P. Berrange wrote: > On Thu, Aug 11, 2016 at 04:25:01PM +0200, Ján Tomko wrote: >> On Thu, Aug 11, 2016 at 09:31:33AM -0400, Cole Robinson wrote: >>> Next week is the time for GSOC students to submit their Final Evaluations. >>> Work needs to be hosted/linked from a p

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 04:25:01PM +0200, Ján Tomko wrote: > On Thu, Aug 11, 2016 at 09:31:33AM -0400, Cole Robinson wrote: > > Next week is the time for GSOC students to submit their Final Evaluations. > > Work needs to be hosted/linked from a public URL. Cedric suggested using the > > libvirt wik

Re: [libvirt] [PATCH 09/27] tests: Add test infrastructure for qemuMonitorGetCPUInfo

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:05PM +0200, Peter Krempa wrote: > As the combination algorithm is rather complex and ugly it's necessary > to make sure it works properly. Add test suite infrastructure for > testing it along with a basic test based on x86_64 platform. > --- > ...nitorjson-cpuinfo-x86

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 09:31:33AM -0400, Cole Robinson wrote: Next week is the time for GSOC students to submit their Final Evaluations. Work needs to be hosted/linked from a public URL. Cedric suggested using the libvirt wiki for these pages, so something like: http://wiki.libvirt.org/page/Goo

Re: [libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Katerina Koukiou
Please sign me up: username: kkoukiou email: k.kouk...@gmail.com Thanks, Katerina On Thu, Aug 11, 2016 at 1:31 PM, Cole Robinson wrote: > Next week is the time for GSOC students to submit their Final Evaluations. > Work needs to be hosted/linked from a public URL. Cedric suggested using the > li

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Laine Stump
On 08/11/2016 09:31 AM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: I'm wondering about generalizing this. eg what if

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > > > > > I'm wondering about ge

Re: [libvirt] Failing build on rawhide

2016-08-11 Thread Michal Privoznik
On 11.08.2016 15:44, Martin Kletzander wrote: > So after updating my fedora-rawhide machines, I started receiving an > interesting error: > > In file included from /usr/include/features.h:397:0, > from /usr/include/bits/libc-header-start.h:33, > from /usr/include/st

Re: [libvirt] [PATCH 08/27] qemu: monitor: Add algorithm for combining query-(hotpluggable-)-cpus data

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:04PM +0200, Peter Krempa wrote: > For hotplug purposes it's necessary to retrieve data using > query-hotpluggable-cpus while the old query-cpus API report thread IDs > and order of hotplug. > > This patch adds code that merges the data using a rather non-trivial > alg

Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-11 Thread Martin Kletzander
On Thu, Aug 11, 2016 at 10:46:28AM +0100, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 05:39:06PM +0800, Xian Han Yu wrote: On 8/11/2016 5:00 PM, Daniel P. Berrange wrote: > On Thu, Aug 11, 2016 at 10:55:44AM +0200, Andrea Bolognani wrote: > > On Thu, 2016-08-11 at 14:48 +0800, Xian Han Y

[libvirt] Failing build on rawhide

2016-08-11 Thread Martin Kletzander
So after updating my fedora-rawhide machines, I started receiving an interesting error: In file included from /usr/include/features.h:397:0, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdio.h:28, from ../gnulib/lib/stdio.h:43,

Re: [libvirt] [PATCHv2 11/11] qemu: format options for enforcing virtio revisions

2016-08-11 Thread Boris Fiuczynski
On 08/11/2016 01:59 PM, Ján Tomko wrote: On Wed, Aug 10, 2016 at 04:27:58PM +0200, Boris Fiuczynski wrote: On 08/08/2016 06:35 PM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1227354 Translate the optional attribute to disable-legacy=on/off and disable-modern=on/off options f

Re: [libvirt] [PATCH 0/6] Use more PCIe, less legacy PCI slots

2016-08-11 Thread Andrea Bolognani
On Wed, 2016-08-10 at 12:10 -0400, Laine Stump wrote: > > > Note that setting disable-modern/disable-legacy does *not* necessarily > > > do what you think, and we don't want to always have to set virtio > > > revision='1.0' in order to get a PCIe device, nor do we want all PCIe > > > devices to be

[libvirt] [PATCH v2 08/10] security: Introduce internal APIs for memdev labelling

2016-08-11 Thread Michal Privoznik
These APIs will be used whenever we are hot (un-)plugging a memdev. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms| 2 ++ src/security/security_driver.h | 9 +++ src/security/security_manager.c | 56 + src/security/security_man

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: > On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: > > On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > > > > > > > > > I'm wondering about generalizing this. eg what if there are > > other device mod

[libvirt] wiki accounts for GSOC submissions

2016-08-11 Thread Cole Robinson
Next week is the time for GSOC students to submit their Final Evaluations. Work needs to be hosted/linked from a public URL. Cedric suggested using the libvirt wiki for these pages, so something like: http://wiki.libvirt.org/page/Google_Summer_of_Code_2016/My_Page_Title And then we can link it fr

[libvirt] [PATCH v2 03/10] qemu: Implement NVDIMM

2016-08-11 Thread Michal Privoznik
So, majority of the code is just ready as-is. Well, with one slight change: differentiate between dimm and nvdimm in places like device alias generation, generating the command line and so on. Speaking of the command line, we also need to append 'nvdimm=on' to the '-machine' argument so that the n

[libvirt] [PATCH v2 02/10] qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM

2016-08-11 Thread Michal Privoznik
Introduce a qemu capability for -device nvdimm. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_6

[libvirt] [PATCH v2 09/10] secdrivers: Implement memdev relabel APIs

2016-08-11 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 3 +++ src/security/security_nop.c | 19 +++ src/security/security_selinux.c | 3 +++ 3 files changed, 25 insertions(+) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 253cbbf

[libvirt] [PATCH v2 06/10] security_dac: Label host side of NVDIMM

2016-08-11 Thread Michal Privoznik
When domain is being started up, we ought to relabel the host side of NVDIMM so qemu has access to it. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 73 + 1 file changed, 73 insertions(+) diff --git a/src/security/security_dac.c b/

[libvirt] [PATCH v2 07/10] security_selinux: Label host side of NVDIMM

2016-08-11 Thread Michal Privoznik
When domain is being started up, we ought to relabel the host side of NVDIMM so qemu has access to it. Signed-off-by: Michal Privoznik --- src/security/security_selinux.c | 66 + 1 file changed, 66 insertions(+) diff --git a/src/security/security_selinux.

[libvirt] [PATCH v2 05/10] qemu: Implement memAccess for banks

2016-08-11 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 11 +++-- src/qemu/qemu_command.h| 1 + src/qemu/qemu_hotplug.c| 3 ++- ...muxml2argv-memory-hotplug-nvdimm-memAccess.args | 26 ++

[libvirt] [PATCH v2 10/10] qemu_hotplug: Relabel memdev

2016-08-11 Thread Michal Privoznik
Now that we have APIs for relabel memdevs on hotplug, fill in the missing implementation in qemu hotplug code. Signed-off-by: Michal Privoznik --- src/qemu/qemu_hotplug.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6

[libvirt] [PATCH v2 04/10] conf: Introduce memAccess to

2016-08-11 Thread Michal Privoznik
Now that NVDIMM has found its way into libvirt, users might want to fine tune some settings for each module separately. One such setting is 'share=on|off' for the memory-backend-file object. This setting - just like its name suggest already - enables sharing the nvdimm module with other application

[libvirt] [PATCH v2 01/10] Introduce NVDIMM memory model

2016-08-11 Thread Michal Privoznik
NVDIMM is new type of memory introduced in qemu. The idea is that we have a DIMM module that keeps the data persistent across domain reboots. At the domain XML level, we already have some representation of 'dimm' modules. Long story short, we have element that lives under . Now, the element even h

[libvirt] [PATCH v2 00/10] Introduce NVDIMM support

2016-08-11 Thread Michal Privoznik
This is v2 of: https://www.redhat.com/archives/libvir-list/2016-August/msg00055.html diff to v1: - Rebase to the latest HEAD - Introduced relabeling for host side of NVDIMM Michal Privoznik (10): Introduce NVDIMM memory model qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM qemu: Implement NVDIMM

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: I'm wondering about generalizing this. eg what if there are other device models where we want the ability to set a revision. We don't really want to invent a new

Re: [libvirt] [PATCH] lxc: don't try to resolve a NULL path for filesystems

2016-08-11 Thread Cole Robinson
On 08/11/2016 09:09 AM, Daniel P. Berrange wrote: > > > > > > would lead to lxcContainerResolveSymlinks calling > access(NULL) because it failed to check if fs->src->path > was non-NULL. This is a regression caused by > > commit da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 > Autho

[libvirt] [PATCH] lxc: don't try to resolve a NULL path for filesystems

2016-08-11 Thread Daniel P. Berrange
would lead to lxcContainerResolveSymlinks calling access(NULL) because it failed to check if fs->src->path was non-NULL. This is a regression caused by commit da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 Author: Olga Krishtal Date: Thu Jul 14 16:52:38 2016 +0300 filesyst

Re: [libvirt] [PATCH v1] qemu-migration: Disallow migration of read only disk

2016-08-11 Thread Corey S McQuay
On 08/10/2016 09:16 AM, Koniszewski, Pawel wrote: -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list- boun...@redhat.com] On Behalf Of Corey S. McQuay Sent: Friday, August 5, 2016 8:34 PM To: jjhe...@linux.vnet.ibm.com; libvir-list@redhat.com Cc: Corey S. McQuay

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > I'm wondering about generalizing this. eg what if there are other device models where we want the ability to set a revision. We don't really want to invent a new sub-elment named after each device model > Regards, Daniel -- |

Re: [libvirt] [PATCHv2 11/11] qemu: format options for enforcing virtio revisions

2016-08-11 Thread Ján Tomko
On Wed, Aug 10, 2016 at 04:27:58PM +0200, Boris Fiuczynski wrote: On 08/08/2016 06:35 PM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1227354 Translate the optional attribute to disable-legacy=on/off and disable-modern=on/off options for the following devices: virtio-ball

[libvirt] [PATCHv4 10/11] Introduce QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY

2016-08-11 Thread Ján Tomko
Check whether the disable-legacy property is present on the following devices: virtio-balloon-pci virtio-blk-pci virtio-scsi-pci virtio-serial-pci virtio-9p-pci virtio-net-pci virtio-rng-pci virtio-gpu-pci virtio-input-host-pci virtio-keyboard-pci virtio-mouse-pci virtio-tab

[libvirt] [PATCHv4 11/11] qemu: format options for enforcing virtio revisions

2016-08-11 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 Translate the optional attributes to disable-legacy=on/off and disable-modern=on/off options for the following devices: virtio-balloon-pci virtio-blk-pci virtio-scsi-pci virtio-serial-pci virtio-9p-pci

Re: [libvirt] [PATCH 7/7] qemu: Support newer ivshmem and prefer that over the legacy one

2016-08-11 Thread Martin Kletzander
On Thu, Aug 11, 2016 at 09:27:47AM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 01:50:11PM +0200, Martin Kletzander wrote: QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are reworked varians of legacy ivshmem that are compatible, but have sane specification and han

Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 05:39:06PM +0800, Xian Han Yu wrote: > > > On 8/11/2016 5:00 PM, Daniel P. Berrange wrote: > > On Thu, Aug 11, 2016 at 10:55:44AM +0200, Andrea Bolognani wrote: > > > On Thu, 2016-08-11 at 14:48 +0800, Xian Han Yu wrote: > > > > > The default is not OFF, though, it's ABSEN

Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-11 Thread Xian Han Yu
On 8/11/2016 5:00 PM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 10:55:44AM +0200, Andrea Bolognani wrote: On Thu, 2016-08-11 at 14:48 +0800, Xian Han Yu wrote: The default is not OFF, though, it's ABSENT :) In fact, as far as I can tell, OFF isn't ever used explicitly either for a

Re: [libvirt] an AB deadlock or libvirtd crash problem in virsh console and virsh destroy

2016-08-11 Thread Michal Privoznik
On 04.08.2016 14:37, weifuqiang wrote: > The reason of this problem is that fdstream abort event or close event > occured at the same time, libvirtd doesn't deal with the synchronousness well > enough. > the flows about fdStream is bellow > 1、qemuDomainDefineXMLFlags -> virDomainObjListAdd ->

Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 10:55:44AM +0200, Andrea Bolognani wrote: > On Thu, 2016-08-11 at 14:48 +0800, Xian Han Yu wrote: > > > The default is not OFF, though, it's ABSENT :) > > >  > > > In fact, as far as I can tell, OFF isn't ever used explicitly > > > either for assignment or comparison. And fa

Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-11 Thread Andrea Bolognani
On Thu, 2016-08-11 at 14:48 +0800, Xian Han Yu wrote: > > The default is not OFF, though, it's ABSENT :) > >  > > In fact, as far as I can tell, OFF isn't ever used explicitly > > either for assignment or comparison. And false is plain wrong > > from a datatype point of view. >   > How about we cha

Re: [libvirt] [PATCH 7/7] qemu: Support newer ivshmem and prefer that over the legacy one

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 01:50:11PM +0200, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible, but have sane > specification and handling. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id

Re: [libvirt] libvirtd crash with host cpu model qemu64

2016-08-11 Thread Michal Privoznik
On 05.08.2016 23:38, Jim Fehlig wrote: > > With vendor = 0x0, &host_model->vendor->cpuid evaluates to 8, which > is not a nice value to pass to virCPUx86DataAddCPUID(). Check for a > non-null host_model->vendor before calling virCPUx86DataAddCPUID(). > > Signed-off-by: Jim Fehlig > --- > src/c

Re: [libvirt] [PATCH 0/7] qemu: Trivially add support for newer ivshmem

2016-08-11 Thread Martin Kletzander
On Wed, Aug 10, 2016 at 01:50:04PM +0200, Martin Kletzander wrote: It's "trivially" because it's just about using different parameters. It is a series because I wanted to make some code paths saner and some output nicer, but I tried keeping every patch self-contained and as small as possible whil

Re: [libvirt] [PATCH 0/5] Introduce NVDIMM support

2016-08-11 Thread Michal Privoznik
On 04.08.2016 10:42, Stefan Hajnoczi wrote: > On Mon, Aug 1, 2016 at 4:10 PM, Michal Privoznik wrote: >> NVDIMM was introduced to qemu in v2.6.0-rc0~248^2~25. So it's >> been a while since then. >> >> It's not the next big thing, but it is very interesting feature >> enabling higher performance as

Re: [libvirt] [PATCH 18/27] util: Extract and rename qemuDomainDelCgroupForThread to virCgroupDelThread

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:14PM +0200, Peter Krempa wrote: > --- > src/libvirt_private.syms | 1 + > src/qemu/qemu_driver.c | 27 +++ > src/util/vircgroup.c | 20 > src/util/vircgroup.h | 4 > 4 files changed, 28 insertions(+), 24 de

Re: [libvirt] [PATCH 17/27] qemu: setvcpus: Extract setting of maximum vcpu count

2016-08-11 Thread Pavel Hrdina
On Fri, Aug 05, 2016 at 03:56:13PM +0200, Peter Krempa wrote: > Setting of the maximum vcpu count is slightly semantically different > thus split it into a self-contained func. > --- > src/qemu/qemu_driver.c | 47 +++ > 1 file changed, 31 insertions(+),