Re: [libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address

2016-08-23 Thread Xian Han Yu
Ping... On 8/15/2016 12:22 PM, Xian Han Yu wrote: The 'multi' element in PCI address struct used as 'virTristateSwitch', and its default value is 'VIR_TRISTATE_SWITCH_ABSENT'. Current PCI process use 'false' to initialization 'multi', which is ambiguously for assignment or comparison. This patch

Re: [libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems

2016-08-23 Thread John Ferlan
On 08/23/2016 08:02 PM, Rufo Dogav wrote: > This patch fixes a segfault in virt-aa-helper caused by attempting to modify a > string literal in situ. It is triggered when a domain has a with > type='mount' configured readonly, and libvirt is using the AppArmor security > driver for sVirt confine

[libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems

2016-08-23 Thread Rufo Dogav
This patch fixes a segfault in virt-aa-helper caused by attempting to modify a string literal in situ. It is triggered when a domain has a with type='mount' configured readonly, and libvirt is using the AppArmor security driver for sVirt confinement. --- Thanks for the advice Martin - I complete

Re: [libvirt] RFC: Limited dynamic ownership

2016-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2016 at 06:17:44PM -0400, Martin Kletzander wrote: > On Tue, Aug 23, 2016 at 05:54:29PM -0400, Daniel P. Berrange wrote: > > On Tue, Aug 23, 2016 at 05:06:20PM -0400, Martin Kletzander wrote: > > > Hi everyone, > > > > > > so there was an idea about limiting the relabelling of imag

Re: [libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems

2016-08-23 Thread Martin Kletzander
On Tue, Aug 23, 2016 at 07:30:04PM +0100, rufo wrote: This patch fixes a segfault in virt-aa-helper caused by attempting to modify a string literal in situ. It is triggered when a domain has a with type='mount' configured readonly, and libvirt is using the AppArmor security driver for sVirt co

[libvirt] [PATCHv5 11/13] Add compatibility attribute to video

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 17 +++-- src/conf/domai

[libvirt] [PATCHv5 12/13] Add compatibility attribute to input devices

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c |

[libvirt] [PATCHv5 13/13] qemu: format options for enforcing virtio revisions

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 Translate the optional attributes to disable-legacy=on/off and disable-modern=on/off options for the following devices: virtio-balloon-pci virtio-blk-pci virtio-scsi-pci virtio-serial-pci virtio-9p-pci

[libvirt] [PATCHv5 07/13] Add compatibility attribute to controllers

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 9 - docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c | 7 +++ src/conf/domai

[libvirt] [PATCHv5 05/13] Add compatibility attribute to memballoon

2016-08-23 Thread Ján Tomko
A new attribute to alter the virtio revision: https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 15 ++ src/conf/domain_conf.c | 40

[libvirt] [PATCHv5 09/13] Add compatibility attribute to interfaces

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c | 8 +++- src/conf/do

[libvirt] [PATCHv5 06/13] Add compatibility attribute to disks

2016-08-23 Thread Ján Tomko
A new attribute to alter the virtio revision: https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 8 +++- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c

[libvirt] [PATCHv5 10/13] Add compatibility attribute to rng devices

2016-08-23 Thread Ján Tomko
/dev/random https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 8 src/

[libvirt] [PATCHv5 01/13] Use a separate buffer for subelements

2016-08-23 Thread Ján Tomko
Instead of figuring out upfront whether will be a single or a pair element, format the subelements into a separate buffer and close early if this buffer is empty. --- src/conf/domain_conf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_c

[libvirt] [PATCHv5 03/13] Use a separate buffer for

2016-08-23 Thread Ján Tomko
Make adding new attributes easier. --- src/conf/domain_conf.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 99e8a8b..af1c12e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.

[libvirt] [PATCHv5 08/13] Add compatibility attribute to filesystems

2016-08-23 Thread Ján Tomko
... https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c | 9 + src/conf/d

[libvirt] [PATCHv5 00/13] qemu: allow disabling certain virtio revisions

2016-08-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01235.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg00412.html * probe for the qemu capability * add the attribute to virtio1-only devices such as virtio-gpu

[libvirt] [PATCHv5 02/13] Use a separate buffer for

2016-08-23 Thread Ján Tomko
Eliminate the big condition at the start. Instead use a buffer and only format the element if the buffer is non-empty. --- src/conf/domain_conf.c | 55 +- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/co

[libvirt] [PATCHv5 04/13] Use a separate buffer for

2016-08-23 Thread Ján Tomko
Format the attributes in a separate buffer and only print the element if it's not empty. --- src/conf/domain_conf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index af1c12e..1e694fd 100644 --- a/src/conf/domain_c

Re: [libvirt] RFC: Limited dynamic ownership

2016-08-23 Thread Martin Kletzander
On Tue, Aug 23, 2016 at 05:54:29PM -0400, Daniel P. Berrange wrote: On Tue, Aug 23, 2016 at 05:06:20PM -0400, Martin Kletzander wrote: Hi everyone, so there was an idea about limiting the relabelling of images that libvirt does. And I'm taking the liberty of pitching my idea how to approach th

[libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems

2016-08-23 Thread rufo
This patch fixes a segfault in virt-aa-helper caused by attempting to modify a string literal in situ. It is triggered when a domain has a with type='mount' configured readonly, and libvirt is using the AppArmor security driver for sVirt confinement. --- src/security/virt-aa-helper.c | 7 -

Re: [libvirt] RFC: Limited dynamic ownership

2016-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2016 at 05:06:20PM -0400, Martin Kletzander wrote: > Hi everyone, > > so there was an idea about limiting the relabelling of images that > libvirt does. And I'm taking the liberty of pitching my idea how to > approach this. I feel like it's pretty simple thing and there's not > m

Re: [libvirt] Does libvirt live migration have error handling on port bind failure

2016-08-23 Thread Michal Privoznik
On 23.08.2016 08:57, Prasanna Kalever wrote: > On Tue, Aug 23, 2016 at 4:10 AM, Michal Privoznik wrote: >> On 17.08.2016 11:02, Prasanna Kalever wrote: >>> [ oops! apologies, my previous draft miss the links ] >>> >>> Hello, >>> > Thanks Michal that really helps. > > So If I understand it right,

[libvirt] RFC: Limited dynamic ownership

2016-08-23 Thread Martin Kletzander
Hi everyone, so there was an idea about limiting the relabelling of images that libvirt does. And I'm taking the liberty of pitching my idea how to approach this. I feel like it's pretty simple thing and there's not much to talk about, but a) I could've missed something and b) you might hate th

[libvirt] [PATCH] Fix remote_protocol-structs after recent commit

2016-08-23 Thread Peter Krempa
Commit 0adc9d26ae0cfbb4aa227e89424f3d48bb977da0 broke the build since remote_protocol-structs was not updated. --- Pushed under the build-breaker rule. src/remote_protocol-structs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote_protocol-structs b/src/remote_pro

Re: [libvirt] [PATCH 0/9] add ACL checks to vz driver

2016-08-23 Thread Maxim Nestratov
24-Jun-16 17:32, Nikolay Shirokovskiy пишет: First (patches 1 - 8) prepare driver to add checks. Nikolay Shirokovskiy (9): vz: expand start/stop/... APIs for ACL checks vz: implement plain create API thru createFlags instead of visa versa vz: factor out block stats impl vz: factor o

Re: [libvirt] [PATCH RFC 0/5] Remove usb address set caching

2016-08-23 Thread Ján Tomko
On Sat, Aug 20, 2016 at 04:53:02PM +0200, Tomasz Flendrich wrote: During my work on removing addresses caching, usb addresses were added :). It should be applied on top of: https://www.redhat.com/archives/libvir-list/2016-August/msg00945.html or some small conflicts appear. I took an approach w

Re: [libvirt] [PATCH RFC 2/5] qemu_hotplug: use a recalculated usb address set

2016-08-23 Thread Ján Tomko
On Sat, Aug 20, 2016 at 04:53:04PM +0200, Tomasz Flendrich wrote: Since we now have a way of relculating the usb address set, all the places that previously used the cached set now use the recalculated one. --- src/qemu/qemu_hotplug.c | 38 +++--- 1 file changed, 19

[libvirt] libvirt-python virNodeGetInfo returns None

2016-08-23 Thread Christian Loehle
I'm trying to use virt-manager with a custom libvirt hypervisor driver. My current problem is that virt-manager closes the connection because virNodeGetInfo(the python binding) returns None: Traceback (most recent call last): File "/home/cloehle/Documents/libvirt/virt-manager/virtManager/connec

Re: [libvirt] network ethernet - device not up and ip not assigned

2016-08-23 Thread Laine Stump
On 08/23/2016 06:22 AM, Vasiliy Tolstov wrote: I'm install latest libvir and configure network to assign some ip to ethernet device. But after start tap device is down and no addresses assigned. My investigation: qemu_interface.c have functions: qemuInterfaceStartDevice and qemuInterfaceStopDev

Re: [libvirt] [PATCH v2 08/23] qemu: monitor: Add algorithm for combining query-(hotpluggable-)-cpus data

2016-08-23 Thread Shivaprasad G Bhat
On 08/19/2016 08:08 PM, Peter Krempa wrote: For hotplug purposes it's necessary to retrieve data using query-hotpluggable-cpus while the old query-cpus API report thread IDs and order of hotplug. This patch adds code that merges the data using a rather non-trivial algorithm and fills the data

[libvirt] network ethernet - device not up and ip not assigned

2016-08-23 Thread Vasiliy Tolstov
I'm install latest libvir and configure network to assign some ip to ethernet device. But after start tap device is down and no addresses assigned. My investigation: qemu_interface.c have functions: qemuInterfaceStartDevice and qemuInterfaceStopDevice In start device in case of ethernet device no