On Fri, Nov 18, 2016 at 02:25:18PM -0700, Jim Fehlig wrote:
> Hi All,
>
> I briefly mentioned this at an evening event during the KVM Forum / Xen Dev
> Summit, but the list is certainly a better place to discuss such a topic.
> What do folks think about finally removing the old, legacy, xend-based
On 11/10/2016 09:14 PM, Bob Liu wrote:
Tunnelled migration doesn't require any extra network connections beside the
libvirt daemon.
It's capable of strong encryption and the default option of openstack-nova.
This patch adds the tunnelled migration(Tunnel3params) support to libxl.
On the src side
From: Mehdi Abaakouk
When vhostuser interfaces are used, the interface statistics
are not available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information for vhostuser interface.
Note that in openvswitch world drop/error doesn't always m
From: Mehdi Abaakouk
This is just a code move of virstat.c to virnetdevtap.c
---
po/POTFILES.in | 1 -
src/Makefile.am| 1 -
src/libvirt_private.syms | 4 +-
src/libxl/libxl_driver.c | 2 +-
src/lxc/lxc_driver.c | 1 -
src/openvz/openvz_driver.c | 2
This new version removes the virstat.c from locale configuration.
It also adds a new commit to autodected the ifname of the ovs vhostuser.
Mehdi Abaakouk (4):
Gathering vhostuser interface stats with ovs
virstat: fix signature of virstat helper
Move virstat.c code to virnetdevtap.c
domain
From: Mehdi Abaakouk
This change puts the socket filename as ifname for vhostuser netwok
interface.
The filename is the name of the openvswitch interface, this allows the
qemuDomainInterfaceStats to work out of the box without having to
manually set the ifname.
---
src/conf/domain_conf.c | 10 +
From: Mehdi Abaakouk
In preparation to the code move to virnetdevtap.c, this change:
* renames virNetInterfaceStats to virNetDevTapInterfaceStats
* changes 'path' to 'ifname', to use the same vocable as other
method in virnetdevtap.c.
* Add the attributes checker
---
src/libvirt_private.syms
On Fri, 2016-11-18 at 14:25 -0700, Jim Fehlig wrote:
> Hi All,
>
> I briefly mentioned this at an evening event during the KVM Forum /
> Xen Dev
> Summit, but the list is certainly a better place to discuss such a
> topic. What
> do folks think about finally removing the old, legacy, xend-based
Hi All,
I briefly mentioned this at an evening event during the KVM Forum / Xen Dev
Summit, but the list is certainly a better place to discuss such a topic. What
do folks think about finally removing the old, legacy, xend-based driver from
the libvirt sources?
The Xen community made xl/libx
On 11/18/2016 08:01 AM, Eric Farman wrote:
>
>
> On 11/17/2016 06:18 PM, John Ferlan wrote:
>> [...]
>>
I don't think the current code naming is incorrect, but it does
slightly paint us into a box with this work. I'll mull this over
overnight, and maybe cook up a cleanup patch s
From: Mehdi Abaakouk
When vhostuser interfaces are used, the interface statistics
are not available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information for vhostuser interface.
Note that in openvswitch world drop/error doesn't always m
From: Mehdi Abaakouk
This is just a code move of virstat.c to virnetdevtap.c
---
src/Makefile.am| 1 -
src/libvirt_private.syms | 4 +-
src/libxl/libxl_driver.c | 2 +-
src/lxc/lxc_driver.c | 1 -
src/openvz/openvz_driver.c | 2 +-
src/qemu/qemu_driver.c | 2
Hi,
The new code have been moved to virnetdevopenvswitch.c
I have also sent the refactoring of virstat.c
Regards,
Mehdi Abaakouk (3):
Gathering vhostuser interface stats with ovs
virstat: fix signature of virstat helper
Move virstat.c code to virnetdevtap.c
src/Makefile.am
From: Mehdi Abaakouk
In preparation to the code move to virnetdevtap.c, this change:
* renames virNetInterfaceStats to virNetDevTapInterfaceStats
* changes 'path' to 'ifname', to use the same vocable as other
method in virnetdevtap.c.
* Add the attributes checker
---
src/libvirt_private.syms
On Fri, 2016-11-18 at 11:16 -0500, Dawid Zamirski wrote:
>
> Hi Andrea,
>
> Sure, in this case those patches simply enable support of VirtualBox
> 5.1.x series in libvirt (prior to that libvirt supported vbox 2.x.x
> to
> 5.0.x)- and as such it does not affect any previous version that
> libvirt
On Wed, 2016-11-09 at 15:28 +0100, Pino Toscano wrote:
> Hi,
>
> this series introduces a new libssh transport in libvirt, based on the
> libssh C library. This library supports what libssh2 does, and more:
> - easier API for known_hosts handling (there's a ticket upstream to
> request extensio
With kernel 3.18 (since commit 3e32cb2e0a12b6915056ff04601cf1bb9b44f967) the
"unlimited" value for cgroup memory limits has changed once again as its byte
value is now computed from a page counter.
The new "unlimited" value reported by the cgroup fs is therefore 2**51-1 pages
which is (VIR_DOMAIN_M
On Thu, 2016-11-10 at 23:39 +0100, Jiri Denemark wrote:
> This is another step in revisiting all APIs provided by the cpu driver
> and making them a bit more sane. As with the previous round(s), the
> updated APIs will gain virCPU prefix so that they can be easily
> distinguished from the ones that
On Mon, 2016-11-14 at 18:20 +0300, Pavel Glushchak wrote:
> dom xml generated on begin step should be passed
> to perform step in VIR_MIGRATE_PARAM_DEST_XML parameter.
> Otherwise 'XML error: failed to parse xml document' is
> raised on destination host as dom xml is NULL.
>
> Signed-off-by: Pavel
On Tue, 2016-11-08 at 11:50 +, Daniel P. Berrange wrote:
> The current libvirt website design dates from 2008 and
> has not changed significantly since. Compared to
> contemporary open source project websites it looks
> pretty dated and cluttered.
>
> This series incrementally changes the webs
With kernel 3.18 (since commit 3e32cb2e0a12b6915056ff04601cf1bb9b44f967) the
"unlimited" value for cgroup memory limits has changed once again as its byte
value is now computed from a page counter.
The new "unlimited" value reported by the cgroup fs is therefore 2**51-1 pages
which is (VIR_DOMAIN_M
On Thu, 2016-11-03 at 07:12 +0100, Peter Krempa wrote:
> See patch 4 for explanation of the bug.
>
> Peter Krempa (4):
> conf: Allow specifying only the slot number for hotpluggable memory
> qemu: process: detect if dimm aliases are broken on reconnect
> qemu: Assign slots to memory devices
On Fri, 2016-11-18 at 16:47 +0100, Andrea Bolognani wrote:
> Would you mind drafting one or two short sentences to describe
> the impact of these changes for users? If everything goes
> according to plans[1], they will be added to the NEWS file.
>
> Thanks!
>
>
> [1] Which it often doesn't :)
>
This reverts commit 3a6cf6fc16.
Mistakenly this commit was pushed because I thought I missed the
corret one b880ff42ddb while in fact I didn't.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
i
This entry is meant to both get the ball rolling on the
switch and to provide a blueprint of what NEWS file entries
are supposed to look like.
---
We need to start somewhere, and what better way than talking
about the change itself? ;)
docs/news.html.in | 9 +
1 file changed, 9 insertions
On 18.11.2016 16:57, Andrea Bolognani wrote:
> On Fri, 2016-11-04 at 13:28 +0100, Michal Privoznik wrote:
>> Basically this is trivial. Everything is prepared and the only
>> thing that prevented us from doing this was missing exception in
>> one check. Trivial.
>>
>> Michal Privoznik (2):
>>
On 11/18/2016 07:56 AM, Ján Tomko wrote:
> On Tue, Nov 15, 2016 at 06:48:03PM -0500, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1363586
>>
>> There's actually a couple of bugs here...
>>
>>only the "input" format type, so any other "types" of format would be
>
> I coul
On Fri, 2016-11-04 at 13:28 +0100, Michal Privoznik wrote:
> Basically this is trivial. Everything is prepared and the only
> thing that prevented us from doing this was missing exception in
> one check. Trivial.
>
> Michal Privoznik (2):
> qemuDomainAttachNetDevice: Don't overwrite error on rol
On Wed, 2016-11-02 at 17:13 +0100, Peter Krempa wrote:
> Now that the release is out, I fixed the few things pointed out.
>
> Andrea Bolognani (5):
> tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release
> tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release
> tests: q
On Wed, Nov 09, 2016 at 11:22:34AM -0500, John Ferlan wrote:
>
>
> On 11/01/2016 06:27 AM, Erik Skultety wrote:
> > The reason why we need something like this lies in the daemon's config
> > where we
> > treat the @log_outputs variable (but not just this one) the very same way in
> > cases where
On Mon, 2016-11-07 at 16:03 -0500, Dawid Zamirski wrote:
> With VBox 5.1.x release new SDK header needs to be added to libvirt
> sources. Sending as attachments due to the size of the first patch
> being a large header file taken from VBOX SDK.
>
> Dawid Zamirski (2):
> vbox: add vbox 5.1 C API
On Wed, 2016-10-26 at 12:51 +0200, Martin Kletzander wrote:
> v4:
> - Incorporated John's review
>
> v3:
> - https://www.redhat.com/archives/libvir-list/2016-September/msg01232.html
>
>
> Martin Kletzander (6):
> conf, qemu: Add support for shmem model
> conf, qemu: Add newer shmem models
On Fri, Nov 18, 2016 at 03:23:55PM +, Daniel P. Berrange wrote:
> On Fri, Nov 18, 2016 at 04:05:52PM +0100, Martin Kletzander wrote:
> > Since we are useing Overpass for the web pages, we might be using the
s/useing/using/
> > latest version.
> >
> > Signed-off-by: Martin Kletzander
> > ---
On 18.11.2016 16:21, Daniel P. Berrange wrote:
> On Fri, Nov 18, 2016 at 04:05:50PM +0100, Martin Kletzander wrote:
>> I heard Overpass 3.0 was released, so let's update to that. There are
>> some changes that I noticed. There are more font weights than we had
>> before. The one we decided to us
On Fri, Nov 18, 2016 at 04:05:52PM +0100, Martin Kletzander wrote:
> Since we are useing Overpass for the web pages, we might be using the
> latest version.
>
> Signed-off-by: Martin Kletzander
> ---
>
> Notes:
> I'm not sure where Dan got the hinted versions. Also what version
> that i
On Fri, Nov 18, 2016 at 04:05:50PM +0100, Martin Kletzander wrote:
> I heard Overpass 3.0 was released, so let's update to that. There are
> some changes that I noticed. There are more font weights than we had
> before. The one we decided to use is now probably the 'semibold' one.
> So the regul
Some of those were duplicate, so remove those. In order to better see
such things in the future, sort them so they are "regular, italic,
bold, bold-italic, light, light-italic".
Signed-off-by: Martin Kletzander
---
docs/fonts/stylesheet.css | 18 ++
1 file changed, 2 insertions(
After a944bd92 we gained support for setting gluster debug level.
However, due to stupid space we haven't tested whether augeas
file actually works.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu.conf | 2 +-
src/qemu/test_libvirtd_qemu.aug.in | 1 +
2 files changed, 2 inserti
Overpass 3.0 has monospaced fonts, so why not have the same font for
the monospaced parts of the documentation.
Signed-off-by: Martin Kletzander
---
docs/fonts/stylesheet.css | 21 +
1 file changed, 21 insertions(+)
diff --git a/docs/fonts/stylesheet.css b/docs/fonts/stylesh
Signed-off-by: Martin Kletzander
---
docs/generic.css | 4
1 file changed, 4 insertions(+)
diff --git a/docs/generic.css b/docs/generic.css
index 02383017a91b..f7083b6e6c7f 100644
--- a/docs/generic.css
+++ b/docs/generic.css
@@ -71,3 +71,7 @@ h6 {
margin-top: 0.75em;
font-size: 0.8em
I heard Overpass 3.0 was released, so let's update to that. There are
some changes that I noticed. There are more font weights than we had
before. The one we decided to use is now probably the 'semibold' one.
So the regular font is a little thinner, but not as much as the
'light' one. I think t
Remove duplicated code - make one path through
Signed-off-by: John Ferlan
---
src/storage/storage_backend_scsi.c | 35 +++
1 file changed, 11 insertions(+), 24 deletions(-)
diff --git a/src/storage/storage_backend_scsi.c
b/src/storage/storage_backend_scsi.c
inde
Create a utility routine in order to read the scsi_host fabric_name files
looking for a match to a passed fabric_name
Signed-off-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virutil.c | 86
src/util/virutil.h | 4 +++
https://bugzilla.redhat.com/show_bug.cgi?id=1349696
As it turns out using only the 'parent' to achieve the goal of a
consistent vHBA parent has issues with reboots where the scsi_hostX
parent could change to scsi_hostY causing either failure to create
the vHBA or usage of the wrong HBA for our vHB
Rather than extraneous VIR_FREE's depending on where we are in the code,
move them to the top of the loop and in the cleanup path.
Signed-off-by: John Ferlan
---
src/util/virutil.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/src/util/virutil.c
Use the ret = -1, goto cleanup, etc. rather than current hodgepodge.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_scsi.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/src/storage/storage_backend_scsi.c
b/src/storage/storag
Move the check for an already existing vHBA to the top of the function.
No sense in first decoding a provided parent if the next thing we're going
to do is fail if a provided wwnn/wwpn already exists.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_scsi.c | 28 ++--
Providing XML such as:
vhba
would crash libvirt because the '' isn't a required field, but
for vHBA creation it's expected (day 1 issue - see commit id '81d0ffbc').
The nodedev.rng added in commit id '2c22a68c' has this as an optional field.
NB: On normal udev discovery if a p
https://bugzilla.redhat.com/show_bug.cgi?id=1349696
When creating a vHBA, the process is to feed XML to nodeDeviceCreateXML
that lists the scsi_hostX to use to create the vHBA. However,
between reboots, it's possible that the changes its scsi_hostX
to scsi_hostY and saved XML to perform the crea
Extract out code from virNodeDeviceGetParentHost into helpers - it's
going to be reused in upcoming patches to search on more fields
Create virNodeDeviceFindVPORTCapDef in order to return a virNodeDevCapsDefPtr
of the VPORT_OPS and virNodeDeviceFindFCParentHost to use the function and
generate an
Add new fields to the fchost structure to allow creation of a vHBA via
the storage pool when a parent_wwnn/parent_wwpn or parent_fabric_wwn is
supplied in the storage pool XML.
Signed-off-by: John Ferlan
---
docs/schemas/basictypes.rng | 15 +++
src/conf/storage_conf.c | 21 +
If a is not supplied in the XML used to create a non-persistent
vHBA, then instead of failing, let's try to find a "vports" capable node
device and use that.
Signed-off-by: John Ferlan
---
src/conf/node_device_conf.c | 39
src/conf/node_device_conf.
https://bugzilla.redhat.com/show_bug.cgi?id=1349696
Lots of details in the bz, but essentially the problem is that providing
a "parent" scsi_hostX value has drawbacks on reboots because what was
scsi_hostX could turn into scsi_hostY on subsequent reboots.
So add the ability to use the parent wwnn
On Fri, Nov 18, 2016 at 10:59:58AM +0100, Erik Skultety wrote:
On Fri, Nov 18, 2016 at 10:34:47AM +0100, Martin Kletzander wrote:
Commit 94cc577807ba tried fixing build on systems that did not have
SCHED_BATCH or SCHED_IDLE defined. But instead of changing it to
conditional support, it rather c
On Fri, Nov 18, 2016 at 09:06:51AM +0100, Mehdi Abaakouk wrote:
> When vhostuser or ovs interfaces are used, the interface statistics
> are not always available in /proc/net/dev.
>
> This change looks at the openvswitch interfaces statistics
> tables to provide this information in additional to /p
Removed the comment 'Set the migration source' as it isn't valid anymore
and 'start it up' isn't useful as qemuProcessStart() is already a
speaking name.
Signed-off-by: Marc Hartmayer
---
src/qemu/qemu_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/
Only generate a warning if there is something to report.
Signed-off-by: Marc Hartmayer
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index a45279a..f006ab
Fixed trailing '/' for path, removed an obsolete comment, and removed
a useless warning.
Bjoern Walk (1):
virutil: fix trailing '/' for path prefixes
Marc Hartmayer (2):
virfile: Only generate a warning if there is something to report
qemu: Removed an outdated comment in qemuDomainSaveImage
From: Bjoern Walk
The path prefixes for sysfs trees are always prepended by paths
beginning with a slash, making the trailing slash in the prefix
redundant.
Signed-off-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/util/virutil.c | 4 ++--
1 file changed, 2
On 11/17/2016 06:18 PM, John Ferlan wrote:
[...]
I don't think the current code naming is incorrect, but it does
slightly paint us into a box with this work. I'll mull this over
overnight, and maybe cook up a cleanup patch separate from this
series. Or perhaps take your other suggestion and
On Tue, Nov 15, 2016 at 06:48:03PM -0500, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1363586
There's actually a couple of bugs here...
only the "input" format type, so any other "types" of format would be
I could a verb.
filtered during the blkid_do_probe resulting
On Tue, Nov 15, 2016 at 06:48:02PM -0500, John Ferlan wrote:
They're not necessary - either we have an error or not especially since
the caller only checked for the "NOT_FOUND" case.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_fs.c | 16 +++-
src/storage/storage_backen
If users try to hotplug RNG device with a backend different to
/dev/random or /dev/urandom the whole operation fails as qemu is
unable to access the device. The problem is we don't update
device CGroups during the operation.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_cgroup.c | 62 ++
We are already doing that for some devices (e.g. disks,
hostdevs), but completely forgot about some others (chardevs and
RNGs). So far the hotplug worked by pure chance as /dev/random
and /dev/urandom are enabled in the device CGroups by default.
Michal Privoznik (2):
qemu: Update cgroup on RNG
Just like in the previous commit, we are not updating CGroups on
chardev hot(un-)plug and thus leaving qemu unable to access any
non-default device users are trying to hotplug.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_cgroup.c | 46 ++
src/qe
On Thu, Nov 17, 2016 at 01:02:57PM +1100, Alexey Kardashevskiy wrote:
> On 16/11/16 01:02, Andrea Bolognani wrote:
> > On Tue, 2016-11-01 at 13:46 +1100, David Gibson wrote:
> >> On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote:
> >>>
> >>> On 31/10/16 13:53, David Gibson wrot
On Fri, Nov 18, 2016 at 10:34:47AM +0100, Martin Kletzander wrote:
> Commit 94cc577807ba tried fixing build on systems that did not have
> SCHED_BATCH or SCHED_IDLE defined. But instead of changing it to
> conditional support, it rather completely disabled the support for
> setting any scheduler.
Commit 94cc577807ba tried fixing build on systems that did not have
SCHED_BATCH or SCHED_IDLE defined. But instead of changing it to
conditional support, it rather completely disabled the support for
setting any scheduler. Since then, such old systems are not
supported, but rather than reverting
On Wed, Nov 16, 2016 at 08:29:49PM +0100, Guido Günther wrote:
Unify the logic we use for looking up daemons and admin binaries. Some
lookups prefered $PATH over **/sbin while others left out $PATH
entierly. We add **/sbin since non-root users might not have these in
their path.
This also unbre
On Thu, 2016-11-17 at 13:02 +1100, Alexey Kardashevskiy wrote:
> > That said, considering that a big part of the PCI address
> > allocation logic is based off whether the specific machine
> > type exposes a legay PCI Root Bus or a PCI Express Root Bus,
> > libvirt will need a way to be able to tell
When vhostuser or ovs interfaces are used, the interface statistics
are not always available in /proc/net/dev.
This change looks at the openvswitch interfaces statistics
tables to provide this information in additional to /proc/net/dev.
Note that in openvswitch world drop/error doesn't always mak
Hi,
To follow up, my question about vhostuser/ovs interfaces statistics.
This is my porposal to implement this feature.
Regards,
Mehdi Abaakouk (1):
virstats: Gathering net interface stats with ovs
src/util/virstats.c | 99 +++--
1 file change
72 matches
Mail list logo
