On 08.12.2016 19:38, John Ferlan wrote:
>
>
> On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote:
>> In case of 0 filesystems *info is not set while according
>> to virDomainGetFSInfo contract user should call free on it even
>> in case of 0 filesystems. Thus we need to properly set
>> it. NULL
On 08.12.2016 23:07, John Ferlan wrote:
>
>
> On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
>> We need extra state variable to distinguish between autogenerated
>> and user defined cases after auto generation is done.
>> ---
>> src/conf/domain_conf.h | 1 +
>> src/qemu/qemu_process.c |
On 12/07/2016 08:16 PM, Jim Fehlig wrote:
> On 11/22/2016 02:16 PM, John Ferlan wrote:
>>
>>
>> On 11/21/2016 10:58 PM, Eric Farman wrote:
>>> Signed-off-by: Eric Farman
>>> ---
>>> docs/formatdomain.html.in | 24
>>> 1 file changed, 24 insertions(+)
>>>
>>
>> This will
Eric Farman wrote:
>
>
> On 12/07/2016 08:16 PM, Jim Fehlig wrote:
>> On 11/22/2016 02:16 PM, John Ferlan wrote:
>>>
>>>
>>> On 11/21/2016 10:58 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24
On 11/25/2016 08:12 AM, Erik Skultety wrote:
> Now that virLog{Get,Set}DefaultOutput routines are introduced we can wire them
> up to the daemon's logging initialization code. Also, change the order of
> operations a bit so that we still strictly honor our precedence of settings:
> cmdline > env
$SUB: "virLogSetOutputs"?
On 11/25/2016 08:12 AM, Erik Skultety wrote:
> Along with an empty string, it should also be possible for users to pass NULL
> to the public APIs which in turn would trigger a routine (future work)
> responsible for defining an appropriate default logging output given th
On 11/25/2016 08:11 AM, Erik Skultety wrote:
> These helpers will manage the log destination defaults (fetch/set). The reason
> for this is to stay consistent with the current daemon's behaviour with
> respect
> to /etc/libvirt/.conf file, since both assignment of an empty string
> or not settin
On Thu, Dec 08, 2016 at 03:55:43PM -0500, Yash Mankad wrote:
Add builders for Fedora 25 to ci.centos.org
Wouldn't it make sense to remove fedora 23 at the same time?
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
Add builders for Fedora 25 to ci.centos.org
Signed-off-by: Yash Mankad
---
projects/libosinfo.yaml | 1 +
projects/libvirt-cim.yaml | 1 +
projects/libvirt-glib.yaml| 1 +
projects/libvirt-perl.yaml| 1 +
projects/libvirt-python.yaml | 1 +
projects/libvirt-sandbox.yaml | 1 +
On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
> We need extra state variable to distinguish between autogenerated
> and user defined cases after auto generation is done.
> ---
> src/conf/domain_conf.h | 1 +
> src/qemu/qemu_process.c | 19 +--
> 2 files changed, 18 insert
On 12/08/2016 09:00 AM, Nikolay Shirokovskiy wrote:
>
>
> On 08.12.2016 16:21, John Ferlan wrote:
>>
>> Perhaps a commit message would answer my question below...
>>
>> On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
>>> ---
>>> src/conf/domain_conf.c | 5 -
>>> 1 file changed, 4 inser
This adds a new command to QMP: query-device-slots. It will allow
management software to query possible slots where devices can be
plugged.
This implementation of the command will return:
* Multiple PCI slots per bus, in the case of PCI buses;
* One slot per bus in the case of the other buses;
*
[...]
>>
>> Compare that to NFS, which uses mount which is included in well every
>> distro I can think of. That's a big difference. Also let's face it, NFS
>> has been the essential de facto goto tool to access remote storage for a
>> long time. Personally, I'd rather see the NFS code split out o
>> Compare that to NFS, which uses mount which is included in well every
>> distro I can think of. That's a big difference. Also let's face it, NFS
>> has been the essential de facto goto tool to access remote storage for a
>> long time. Personally, I'd rather see the NFS code split out of the
>>
Signed-off-by: John Ferlan
---
Pushed as trivial
docs/news.html.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/news.html.in b/docs/news.html.in
index 958bdd2..faea685 100644
--- a/docs/news.html.in
+++ b/docs/news.html.in
@@ -28,6 +28,12 @@
Improveme
On 08/12/16 19:39, Olga Krishtal wrote:
Hi all, I see here a lot of discussions and explanations about
virtuozzo storage. So, I will just add some information.
Initially I have planned, that admin or user has properly configured
vstorage somewhere over the
network. (It can be done via DNS recor
On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote:
> In case of 0 filesystems *info is not set while according
> to virDomainGetFSInfo contract user should call free on it even
> in case of 0 filesystems. Thus we need to properly set
> it. NULL will be enough as free eats NULLs ok.
> ---
> src/
On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote:
> Current call to qemuAgentGetFSInfo in qemuDomainGetFSInfo is
> unsafe. Domain lock is dropped and we use vm->def. To fix that
> let's fill in intermediate qemuAgentFsInfo structure in
> qemuAgentGetFSInfo and use vm->def to convert result late
Hi all, I see here a lot of discussions and explanations about
virtuozzo storage. So, I will just add some information.
Initially I have planned, that admin or user has properly configured
vstorage somewhere over the
network. (It can be done via DNS records or zeroconf.) At the host where
pool
On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote:
> qemuAgentNotifyEvent notify on a lock condition without taking
> the lock. This works but it is a subject to race conditions.
> ---
> src/qemu/qemu_agent.c | 4
> 1 file changed, 4 insertions(+)
>
But the vm is locked prior to any priv
On 08.12.2016 11:33, Peter Krempa wrote:
> There's nothing to compress if the requested snapshot memory format is
> set to 'raw' explicitly. After commit 9e14689ea libvirt would try to
> run /sbin/raw to process them emory stream if the qemu.conf option
> snapshot_image_format is set.
>
> Resolves
On 07.12.2016 14:20, John Ferlan wrote:
> Nuisance for some, but both have negative repurcussions although one is
> "just" a test.
>
> John Ferlan (2):
> tests: Fix virmacmaptest when allocation fails
> nss: Need to check error condition on virJSONValueArraySize
>
> tests/virmacmaptest.c |
On 07.12.2016 14:20, John Ferlan wrote:
> If the 'nleases < 0' on return, then the subsequent call to
> findLeaseInJSON will not produce the expected results (passed
> in as a size_t, but nleases is a ssize_t). So check if the
> returned value < 0 and if so, goto cleanup.
>
> Found by Coverity as
On 11/18/2016 09:26 AM, John Ferlan wrote:
Move the check for an already existing vHBA to the top of the function.
No sense in first decoding a provided parent if the next thing we're going
to do is fail if a provided wwnn/wwpn already exists.
Signed-off-by: John Ferlan
---
src/storage/stor
On 08.12.2016 16:29, Cédric Bosdonnat wrote:
> If the monitor doesn't hold a reference to the domain object
> the object may be destroyed before the monitor actually stops.
> ---
> v2: Moved vm ref upper, removed vm unref in error case.
>
> src/lxc/lxc_monitor.c | 3 ++-
> 1 file changed, 2 inse
If the monitor doesn't hold a reference to the domain object
the object may be destroyed before the monitor actually stops.
---
v2: Moved vm ref upper, removed vm unref in error case.
src/lxc/lxc_monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lxc/lxc_monitor.
On Thu, Dec 08, 2016 at 08:49:55AM -0500, John Ferlan wrote:
On 11/22/2016 08:53 AM, Martin Kletzander wrote:
Since the great rework of how we store vcpu- and iothread-related
data, we have overly complex part of code that is trying to format the
scheduler tuning data in as less lines as possi
On 12/07/2016 08:16 PM, Jim Fehlig wrote:
On 11/22/2016 02:16 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
This will get squashed in with the co
-if (ret == 0)
-ret = virNetInterfaceStats(path, stats);
-else
+if (net) {
+if (net->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER) {
+ret = virNetDevOpenvswitchInterfaceStats(path, stats);
+} else {
+ret = virNetInterfaceStats(path, stats);
+
In 22f7ceb695a I've introduced another NSS module
but forgot to package it in libvirt-nss.rpm.
Signed-off-by: Michal Privoznik
---
Pushed under trivial rule.
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4bb0699cb..51ffbb55c 100644
At 2016-12-08 20:08:11, "Peter Krempa" wrote:
>On Sat, Dec 03, 2016 at 17:45:47 +0800, Chen Hanxiao wrote:
>> From: Chen Hanxiao
>>
>> Base upon patches from Roy Keene
>>
>> Currently qemuDomainSaveMemory can save vm's config
>> and memory to fd.
>> It writes a magic QEMU_SAVE_PARTIAL firstl
On 08.12.2016 15:17, John Ferlan wrote:
>
>
> On 12/08/2016 04:19 AM, Maxim Nestratov wrote:
>> 08-Dec-16 02:22, John Ferlan пишет:
>>
>>> [...]
>>>
> I see what you mean; however, IMO vstorage should be separate. Maybe
> there's another opinion out there, but since you're requiring
>>>
On 06.12.2016 15:39, Cédric Bosdonnat wrote:
> If the monitor doesn't hold a reference to the domain object
> the object may be destroyed before the monitor actually stops.
> ---
> src/lxc/lxc_monitor.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/lxc/lxc_monitor.c b/src/lxc/lx
On 08.12.2016 16:21, John Ferlan wrote:
>
> Perhaps a commit message would answer my question below...
>
> On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
>> ---
>> src/conf/domain_conf.c | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/conf/domain_conf.c
On Thu, Dec 08, 2016 at 01:51:10PM +0100, Michal Privoznik wrote:
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
From: Mehdi Abaakouk
I don't think this is a good idea. For instance, for the following XML:
this code would produce ifname of "vhost0.sock", whic
On 08.12.2016 16:21, John Ferlan wrote:
>
>
> On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
>> We need extra state variable to distinguish between autogenerated
>> and user defined cases after auto generation is done.
>> ---
>> src/conf/domain_conf.h | 1 +
>> src/qemu/qemu_process.c |
On 11/22/2016 08:53 AM, Martin Kletzander wrote:
> Since the great rework of how we store vcpu- and iothread-related
> data, we have overly complex part of code that is trying to format the
> scheduler tuning data in as less lines as possible by grouping
> settings for multiple threads. That was
On 08.12.2016 16:21, John Ferlan wrote:
>
>
> On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
>> ---
>> src/qemu/qemu_process.c | 30 +-
>> 1 file changed, 21 insertions(+), 9 deletions(-)
>>
>
> ACK - although I'll reword commit a bit:
>
> qemu: Refactor
08-Dec-16 15:17, John Ferlan пишет:
On 12/08/2016 04:19 AM, Maxim Nestratov wrote:
08-Dec-16 02:22, John Ferlan пишет:
[...]
I see what you mean; however, IMO vstorage should be separate. Maybe
there's another opinion out there, but since you're requiring
"something" else to be installed i
This patch reduces the complexity of the filtering algorithm in
virCgroupDetect by first correcting the controller mask and then
checking for potential co-mounts without any correlating
controller mask modifications.
If you agree that this patch removes complexity and improves
readability it could
The problem description is covered in patch one.
I added patch two as an optional enhancement removing some complexity and
improving readability. If this finds common agreement it should simply be
squashed into the first patch of this series.
Boris Fiuczynski (2):
cgroup: unavailable controller
The cgroup controller filtering in virCgroupDetect does not work
properly if the following conditions are met:
1) the host system does not have a cgroup controller which
libvirt requests (unavailable controller) and
2) libvirt is configured to disable a controller (disabled controller) and
3) the d
On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
> We need extra state variable to distinguish between autogenerated
> and user defined cases after auto generation is done.
> ---
> src/conf/domain_conf.h | 1 +
> src/qemu/qemu_process.c | 19 +--
> 2 files changed, 18 insert
On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
> ---
> src/qemu/qemu_process.c | 30 +-
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
ACK - although I'll reword commit a bit:
qemu: Refactor qemuProcessGraphicsReservePorts
Use switch for enums r
Perhaps a commit message would answer my question below...
On 11/22/2016 06:09 AM, Nikolay Shirokovskiy wrote:
> ---
> src/conf/domain_conf.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 6e008e2..fb6ff0b 100
On 12/08/2016 01:48 PM, Martin Kletzander wrote:
On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote:
On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander
wrote:
On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote:
The comment was actually wrong as
https://www.freed
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
> From: Mehdi Abaakouk
>
> When vhostuser interfaces are used, the interface statistics
> are not available in /proc/net/dev.
>
> This change looks at the openvswitch interfaces statistics
> tables to provide this information for vhostuser interface.
>
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
> From: Mehdi Abaakouk
>
> This change puts the socket filename as ifname for vhostuser netwok
> interface.
>
> The filename is the name of the openvswitch interface, this allows the
> qemuDomainInterfaceStats to work out of the box without having to
>
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
> From: Mehdi Abaakouk
>
> This is just a code move of virstat.c to virnetdevtap.c
> ---
> po/POTFILES.in | 1 -
> src/Makefile.am| 1 -
> src/libvirt_private.syms | 4 +-
> src/libxl/libxl_driver.c | 2 +-
> src/lxc/
On 18.11.2016 23:51, Mehdi Abaakouk wrote:
> From: Mehdi Abaakouk
>
> In preparation to the code move to virnetdevtap.c, this change:
>
> * renames virNetInterfaceStats to virNetDevTapInterfaceStats
> * changes 'path' to 'ifname', to use the same vocable as other
> method in virnetdevtap.c.
>
On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote:
On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander
wrote:
On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote:
The comment was actually wrong as
https://www.freedesktop.org/software/systemd/man/udev_new.html
men
On 12/08/2016 04:19 AM, Maxim Nestratov wrote:
> 08-Dec-16 02:22, John Ferlan пишет:
>
>> [...]
>>
I see what you mean; however, IMO vstorage should be separate. Maybe
there's another opinion out there, but since you're requiring
"something" else to be installed in order to get th
On Sat, Dec 03, 2016 at 17:45:47 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> Base upon patches from Roy Keene
>
> Currently qemuDomainSaveMemory can save vm's config
> and memory to fd.
> It writes a magic QEMU_SAVE_PARTIAL firstly,
> then re-open it to change QEMU_SAVE_PARTIAL as QEMU_
There's nothing to compress if the requested snapshot memory format is
set to 'raw' explicitly. After commit 9e14689ea libvirt would try to
run /sbin/raw to process them emory stream if the qemu.conf option
snapshot_image_format is set.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1402726
On Mon, Dec 05, 2016 at 12:04:36PM +, Daniel P. Berrange wrote:
> I was not originally planning to do anything for the gnutls 3.5.6
> regression:
>
> https://www.redhat.com/archives/libvir-list/2016-November/msg00816.html
>
> but there's still no immediate sign of the new 3.5.7 release,
> s
This flag tells backend not to create instance
disks making behavior the same as in qemu driver.
Disk files have to be created beforehand on target
host manually or by upper management layer i.e.
OpenStack Nova.
Signed-off-by: Pavel Glushchak
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 inserti
This flag is used in Virtuozzo backend implicitly, thus
we need to support it and don't fail if it's set.
Signed-off-by: Pavel Glushchak
---
src/vz/vz_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 08f7961..0a84cee 100
08-Dec-16 02:22, John Ferlan пишет:
[...]
I see what you mean; however, IMO vstorage should be separate. Maybe
there's another opinion out there, but since you're requiring
"something" else to be installed in order to get the WITH_VSTORAGE to be
set to 1, then a separate file is in order.
Not
At 2016-12-03 17:45:46, "Chen Hanxiao" wrote:
>This series introduce flag VIR_DOMAIN_SAVE_PIPE
>to enable command 'save' to write to PIPE.
>
>Base upon patches from Roy Keene
>with some fixes.
>
>Change from original patch:
>1) Check whether the specified path is a PIPE.
>2) Rebase on upstream.
1ec22be5 added code that detects the maximum cpu count according to
domain capabilities. The code fell back to the old command only if the
API was not supported. If the API fails for other reasons the command
would fail. There's no point in not trying the old API in such case.
https://bugzilla.red
60 matches
Mail list logo
