[libvirt] [V2]RFC for support cache tune in libvirt

2016-12-22 Thread Qiao, Liyong
Hi folks I’v send the V1 version RFC early this week, but no reply yet. Thanks Qiaowei for the comment, I’v change the RFC much more libvirt specify, please help to comments on. ##Propose Changes #Libvirtd configure changes Add a new configure option cache_allocation_ratio to libvirtd, which

[libvirt] Libvirtd is not started as a service

2016-12-22 Thread Weiwei Jia
Hi Daniel, I download libvirt 2.5.0 source codes and install them as following steps. $ ./autogen.sh --prefix=/usr --localstatedir=/var --sysconfdir=/etc $ make $ sudo make install However, the libvirtd is not started as a service daemon. $ initctl stop libvirt-bin initctl: Unknown job: libvir

Re: [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread John Ferlan
On 12/21/2016 12:11 PM, Weiwei Jia wrote: > Hi, > > I cannot add iothreads > (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in > the libvirt xml configuration file. Once I add > "4" and other related config for IOthreads into > the libvirt xml configuration file with virsh c

Re: [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread Weiwei Jia
On Thu, Dec 22, 2016 at 4:33 AM, Daniel P. Berrange wrote: > On Wed, Dec 21, 2016 at 12:11:51PM -0500, Weiwei Jia wrote: >> Hi, >> >> I cannot add iothreads >> (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in >> the libvirt xml configuration file. Once I add >> "4" and other

Re: [libvirt] Performance about x-data-plane

2016-12-22 Thread Weiwei Jia
On Thu, Dec 22, 2016 at 4:30 AM, Daniel P. Berrange wrote: > On Thu, Dec 22, 2016 at 01:34:47AM -0500, Weiwei Jia wrote: >> Hi, >> >> With QEMU x-data-plane, I find the performance has not been improved >> very much. Please see following two settings. >> >> Setting 1: I/O thread in host OS (VMM) r

Re: [libvirt] [PATCH] network: write both lo and lo0 in dnsmasq configuration

2016-12-22 Thread Andrea Bolognani
On Tue, 2016-12-06 at 09:41 +0100, Martin Kletzander wrote: > > When generating a new configuration for dnsmasq, add except-interface > > for both lo and lo0: this should make sure the configuration works, > > and is always the same for every supported OS. > >  > > Adjust the data of networkxml2con

[libvirt] [PATCH] tests/networkxml2conf: Fix to work again on non-Linux

2016-12-22 Thread Andrea Bolognani
Since commit 478ddedc12b7 the name of the loopback interface in the generated dnsmasq configuration is OS-dependent. However, the test suite has not been updated to cope with the change, causing it to fail on FreeBSD and other non-Linux operating systems. Modify the networkxml2conf test case to re

Re: [libvirt] [PATCH v2 5/5] vz: get disks statistics for CTs

2016-12-22 Thread Maxim Nestratov
22-Dec-16 12:13, Daniel P. Berrange пишет: On Wed, Dec 21, 2016 at 10:38:52PM +0300, Maxim Nestratov wrote: A CT disk statistics is reported with prefix "hdd" and we should use it to extract data. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 10 -- src/vz/vz_sdk.c|

Re: [libvirt] [PATCH v2 06/10] util: Introduce virMACMap module

2016-12-22 Thread Andrea Bolognani
On Mon, 2016-12-05 at 11:31 +0100, Michal Privoznik wrote: > This module will be used to track: >  >    >  > pairs. It will be important to know these mappings without > libvirt connection (that is from a JSON file), because NSS > module will use those to provide better host name translation. This

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

2016-12-22 Thread Andrea Bolognani
[Added Roman to CC] On Tue, 2016-12-20 at 11:54 +0100, Michal Privoznik wrote: > > This patch series adds the functionality to detect a misconfiguration > > between disk bus type and disk address type for disks that are using > > the address type virDomainDeviceDriveAddress. It also adds a test fo

Re: [libvirt] [PATCH] tests: enable virpolkittest on any ELF platform

2016-12-22 Thread Andrea Bolognani
On Mon, 2016-11-28 at 14:47 +0100, Pino Toscano wrote: > This tests uses preload, which should work on any ELF-based platform > (and indeed it passes on Linux, GNU/kFreeBSD, and FreeBSD). > > Also remove the WITH_DBUS conditional, as the test is already built > based on that conditional. > --- >

[libvirt] [PATCH] docs: Update docs for recently added physical adjustments

2016-12-22 Thread John Ferlan
Add the description for ... One is a new feature - the API and the other is an improvement for the volume xml output. Signed-off-by: John Ferlan --- I'll hold off pushing as trivial for a bit just in case the grammar/format gestapo (Andrea) would like an adjustment ;-) docs/news.html.in | 11

[libvirt] [PATCH] Add domain event for metadata changes

2016-12-22 Thread Daniel P. Berrange
When changing the metadata via virDomainSetMetadata, we now emit an event to notify the app of changes. This is useful when co-ordinating different applications read/write of custom metadata. Signed-off-by: Daniel P. Berrange --- daemon/remote.c | 45 +++ exam

Re: [libvirt] [PATCH 1/2] m4/virt-arg: Move LIBVIRT_ARG_* macros to their own file

2016-12-22 Thread Pavel Hrdina
On Thu, Dec 22, 2016 at 03:27:27PM +0100, Andrea Bolognani wrote: > On Thu, 2016-12-22 at 13:44 +0100, Pavel Hrdina wrote: > > > +dnl Copyright (C) 2012-2014 Red Hat, Inc. > >  > > The year should be probably 2016 but I don't know for sure. > > I was told at some point that having the full project

Re: [libvirt] [PATCH 1/2] m4/virt-arg: Move LIBVIRT_ARG_* macros to their own file

2016-12-22 Thread Andrea Bolognani
On Thu, 2016-12-22 at 13:44 +0100, Pavel Hrdina wrote: > > +dnl Copyright (C) 2012-2014 Red Hat, Inc. >  > The year should be probably 2016 but I don't know for sure. I was told at some point that having the full project history recorded with git makes copyright statements such at that one pointle

[libvirt] [PATCH] qemu: Don't assume secret provided for LUKS encryption

2016-12-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1405269 If a secret was not provided for what was determined to be a LUKS encrypted disk (during virStorageFileGetMetadata processing when called from qemuDomainDetermineDiskChain as a result of hotplug attach qemuDomainAttachDeviceDiskLive), then do not

[libvirt] [PATCH 2/2] virsh: Fix English grammar in the virsh perf manpage

2016-12-22 Thread Nitesh Konkar
--- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ef91223..9f9a0c6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2274,7 +2274,7 @@ including context-switches, minor-faults, etc.. Now dozens of events from diff

[libvirt] [PATCH 1/2] perf: Refactor perf code

2016-12-22 Thread Nitesh Konkar
Avoid unnecessary calling of function vshCommandOptStringReq. In the current code the function vshCommandOptStringReq is called irrespective of whether --enable and/or --disable is present in the command line. Eg: 'virsh perf domainName' also results in calling this function twice. This patch fixes

[libvirt] [PATCH] m4/virt-gnutls: properly backup CFLAGS and LIBS for AC_CHECK_* macros

2016-12-22 Thread Pavel Hrdina
Commit 943ddcb7120 partially fixed this bug in gnutls configure code. However we also need to backup and modify CFLAGS and do if for AC_CHECK_HEADERS as well. Signed-off-by: Pavel Hrdina --- Pushed under build breaker rule. m4/virt-gnutls.m4 | 9 ++--- 1 file changed, 6 insertions(+), 3 de

Re: [libvirt] [PATCH] m4/virt-lib: use correct format of package name for AC_ARG_* macros

2016-12-22 Thread Pavel Hrdina
On Thu, Dec 22, 2016 at 11:47:07AM +0100, Andrea Bolognani wrote: > On Wed, 2016-12-21 at 22:26 +0100, Pavel Hrdina wrote: > > Introduced by commit 25034b3c40 and reused by commit 4519e94b743. > > This patch silences warning printed by configure: > >  > >   configure: WARNING: unrecognized options:

Re: [libvirt] [PATCH 2/2] m4/virt-arg: Rename LIBVIRT_ARG_WITH* macros

2016-12-22 Thread Pavel Hrdina
On Thu, Dec 22, 2016 at 01:20:59PM +0100, Andrea Bolognani wrote: > LIBVIRT_ARG_WITH_ALT is more generic than LIBVIRT_ARG_WITH, which > is tailored at switching features on and off. > > Rename the macros according to their intended purpose, and add > some documentation to help developers pick betw

Re: [libvirt] [PATCH 1/2] m4/virt-arg: Move LIBVIRT_ARG_* macros to their own file

2016-12-22 Thread Pavel Hrdina
On Thu, Dec 22, 2016 at 01:20:58PM +0100, Andrea Bolognani wrote: > They're not just used, or supposed to be just used, for > library-related arguments, so they deserve to have their > own separate file. > --- > m4/virt-arg.m4 | 144 > + > m

[libvirt] [PATCH 2/2] m4/virt-arg: Rename LIBVIRT_ARG_WITH* macros

2016-12-22 Thread Andrea Bolognani
LIBVIRT_ARG_WITH_ALT is more generic than LIBVIRT_ARG_WITH, which is tailored at switching features on and off. Rename the macros according to their intended purpose, and add some documentation to help developers pick between the two. --- configure.ac | 16 ++--- m4/virt-

[libvirt] [PATCH 0/2] m4: Small cleanups

2016-12-22 Thread Andrea Bolognani
Andrea Bolognani (2): m4/virt-arg: Move LIBVIRT_ARG_* macros to their own file m4/virt-arg: Rename LIBVIRT_ARG_WITH* macros configure.ac | 16 ++--- m4/virt-apparmor.m4 | 4 +- m4/virt-arg.m4| 154 ++ m4/vir

[libvirt] [PATCH 1/2] m4/virt-arg: Move LIBVIRT_ARG_* macros to their own file

2016-12-22 Thread Andrea Bolognani
They're not just used, or supposed to be just used, for library-related arguments, so they deserve to have their own separate file. --- m4/virt-arg.m4 | 144 + m4/virt-lib.m4 | 124 - 2 files ch

Re: [libvirt] [PATCH] NEWS: Update after virtio console on ppc64 fix

2016-12-22 Thread Andrea Bolognani
On Thu, 2016-12-22 at 11:46 +0530, Shivaprasad G Bhat wrote: > Thanks for this patch. Missed it, I am yet to get full hang of the new  > process around news.html. :) >  > ACK. That's okay, especially since the new process for release notes was not even in place back when you posted the patch ;) P

Re: [libvirt] [PATCH] m4/virt-lib: use correct format of package name for AC_ARG_* macros

2016-12-22 Thread Andrea Bolognani
On Wed, 2016-12-21 at 22:26 +0100, Pavel Hrdina wrote: > Introduced by commit 25034b3c40 and reused by commit 4519e94b743. > This patch silences warning printed by configure: >  >   configure: WARNING: unrecognized options: --with-qemu-user >  > Signed-off-by: Pavel Hrdina > --- >  m4/virt-lib.m4

Re: [libvirt] [PATCH v2 1/1] qemu_domain: set default ovs vhostuser ifname

2016-12-22 Thread Michal Privoznik
On 21.12.2016 02:29, Mehdi Abaakouk wrote: > This change adds a new helper function that > return a ifname from the vhostuser unix-socket path but only > if the interface is managed by openvswitch > > This new function is issue to autodetect the ifname for openvswitch > managed vhostuser interface

[libvirt] [PATCH v3] qemu: set default vhost-user ifname

2016-12-22 Thread Michal Privoznik
Based on work of Mehdi Abaakouk . When parsing vhost-user interface XML and no ifname is found we can try to fill it in in post parse callback. The way this works is we try to make up interface name from given socket path and then ask openvswitch wether it knows the interface. Signed-off-by: Mich

Re: [libvirt] [PATCH] m4/virt-gnutls: use AC_CHECK_FUNCS to detect availability of functions

2016-12-22 Thread Daniel P. Berrange
On Thu, Dec 22, 2016 at 10:31:33AM +0100, Pavel Hrdina wrote: > Sigh, autoconf has AC_CHECK_FUNC and AC_CHECK_FUNCS and both check > whether some function exists or not. However in addition to the obvious > difference that the later is able to check multiple functions it also > defines HAVE_FUNCTI

Re: [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 12:11:51PM -0500, Weiwei Jia wrote: > Hi, > > I cannot add iothreads > (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in > the libvirt xml configuration file. Once I add > "4" and other related config for IOthreads into > the libvirt xml configuration f

[libvirt] [PATCH] m4/virt-gnutls: use AC_CHECK_FUNCS to detect availability of functions

2016-12-22 Thread Pavel Hrdina
Sigh, autoconf has AC_CHECK_FUNC and AC_CHECK_FUNCS and both check whether some function exists or not. However in addition to the obvious difference that the later is able to check multiple functions it also defines HAVE_FUNCTION_NAME for each function. Commit 680d2f49da moved the code to separa

Re: [libvirt] Performance about x-data-plane

2016-12-22 Thread Daniel P. Berrange
On Thu, Dec 22, 2016 at 01:34:47AM -0500, Weiwei Jia wrote: > Hi, > > With QEMU x-data-plane, I find the performance has not been improved > very much. Please see following two settings. > > Setting 1: I/O thread in host OS (VMM) reads 4KB each time from disk > (8GB in total). Pin the I/O thread

Re: [libvirt] [PATCH 1/2] configure: move gnutls check into virt-gnutls.m4

2016-12-22 Thread Pavel Hrdina
On Wed, Dec 21, 2016 at 06:34:05PM -0500, John Ferlan wrote: > > > On 10/24/2016 04:40 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > configure.ac | 109 > > +- > > m4/virt-gnutls.m4 | 64 +++

Re: [libvirt] [PATCH 1/2] configure: move gnutls check into virt-gnutls.m4

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 06:34:05PM -0500, John Ferlan wrote: > > > On 10/24/2016 04:40 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > configure.ac | 109 > > +- > > m4/virt-gnutls.m4 | 64 +++

Re: [libvirt] [PATCH] m4/virt-lib: use correct format of package name for AC_ARG_* macros

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:26:14PM +0100, Pavel Hrdina wrote: > Introduced by commit 25034b3c40 and reused by commit 4519e94b743. > This patch silences warning printed by configure: > > configure: WARNING: unrecognized options: --with-qemu-user > > Signed-off-by: Pavel Hrdina > --- > m4/virt-

Re: [libvirt] [PATCH v2 5/5] vz: get disks statistics for CTs

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:38:52PM +0300, Maxim Nestratov wrote: > A CT disk statistics is reported with prefix "hdd" and we should use > it to extract data. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_driver.c | 10 -- > src/vz/vz_sdk.c| 5 +++-- > src/vz/vz_sdk.h| 2

Re: [libvirt] [PATCH v2 4/5] vz: set boot from disk for CT only when there is no root filesystem

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:38:51PM +0300, Maxim Nestratov wrote: > Before, boot devices information for CTs was always empty and we > didn't indicate that containers can boot from disk. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 25 ++--- > 1 file changed, 2

Re: [libvirt] [PATCH v2 3/5] vz: report disks either as disks or filesystems depending on original xml

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:38:50PM +0300, Maxim Nestratov wrote: > Virtuozzo SDK interface doesn't differ filesystems from disks and sees them > as disks. > Before, we always mistakenly presented disks based on files as filesystems, > which is > not completely correct. Now we are going to show ei

Re: [libvirt] [PATCH v2 1/5] vz: report "scsi" bus for disks when nothing was set explixitly

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:38:48PM +0300, Maxim Nestratov wrote: > This is necessary to show CTs created out of libvirt correctly. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c > index 64748f

Re: [libvirt] [PATCH v2 2/5] vz: don't add implicit devices for CTs

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 10:38:49PM +0300, Maxim Nestratov wrote: > Implicit devices like controllers are confusing for CTs and > function virDomainDefAddImplicitDevices never intended to be called > for CTs. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 2 +- > 1 file changed, 1 i