[libvirt] char: Logging serial pty output when disconnected

2017-01-26 Thread Ed Swierk
Interactive access to a guest serial console can be enabled by hooking the serial device to a pty backend, e.g. -device isa-serial,chardev=cs0 -chardev pty,id=cs0. With libvirt this can be configured via . Output from the same serial device can also be logged to a file by adding logfile=/somefile

Re: [libvirt] Refactoring of storage pool

2017-01-26 Thread John Ferlan
On 01/26/2017 11:16 AM, Olga Krishtal wrote: > On 26/01/17 17:49, Daniel P. Berrange wrote: >> On Wed, Jan 25, 2017 at 08:02:30PM +0300, Olga Krishtal wrote: >>> Hi everyone! >>> Half a year ago we started discussion about filesystem pools: >>> https://www.redhat.com/archives/libvir-list/2016-Apr

Re: [libvirt] [PATCH] domain_conf: vnc: preserve autoport value if no port was specified

2017-01-26 Thread John Ferlan
On 01/25/2017 12:26 PM, Pavel Hrdina wrote: > The issue is that if this graphics definition is provided: > > > > it's parsed as: > > > > > > but if the resulting XML is parsed again the output is: > > > > > > and this should not happen. The XML have to always remai

Re: [libvirt] [PATCH] doc: improve VNC/SPICE password documentation

2017-01-26 Thread John Ferlan
On 01/25/2017 05:00 AM, Pavel Hrdina wrote: > If the passwd attribute is set to empty string it disables VNC/SPICE > access to the guest. > > Signed-off-by: Pavel Hrdina > --- > docs/formatdomain.html.in | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --g

Re: [libvirt] [PATCH] virnettlssessiontest.c: fix grammar

2017-01-26 Thread John Ferlan
On 01/25/2017 04:12 AM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > tests/virnettlssessiontest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > ACK and pushed, John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libv

Re: [libvirt] [PATCH 7/7] virsh: Fix manpage typo

2017-01-26 Thread John Ferlan
On 01/18/2017 11:58 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > tools/virsh.pod | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > ACK and pushed (w/ slight adjustment noted below) John > diff --git a/tools/virsh.pod b/tools/virsh.pod > index 467a7d6..bf5b93a

Re: [libvirt] [PATCH] perf: Prevent enabling of already enabled perf event

2017-01-26 Thread John Ferlan
On 01/24/2017 04:12 AM, Nitesh Konkar wrote: > Currently, on every --enable perf_event command, > a new event->fd is created and counting of perf > event counter starts from zero and previous > event->fd is lost. This patch prevents this > behaviour. > > Signed-off-by: Nitesh Konkar > --- > sr

Re: [libvirt] [PATCH] docs: Reword virsh manpage for --uuid --name --details options

2017-01-26 Thread John Ferlan
On 01/21/2017 09:38 AM, Nitesh Konkar wrote: > This commit is similar to commit 0977ada8.The virsh manpage > lists options --uuid and --name as mutually exclusive if > option --details is specified when actually the option > --details is mutually exclusive and can't go with options > --uuid and/o

Re: [libvirt] [PATCH] virsh: Modify description for LIBVIRT_DEBUG=4 in manpage

2017-01-26 Thread John Ferlan
On 01/18/2017 02:05 AM, Nitesh Konkar wrote: > As LIBVIRT_DEBUG=4 logs only error messages and there > are no levels above it, adjusting the description in > the man page accordingly. > > Signed-off-by: Nitesh Konkar > --- > tools/virsh.pod | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [libvirt] [PATCH] vstorage: fix build

2017-01-26 Thread John Ferlan
On 01/26/2017 11:44 AM, Olga Krishtal wrote: > Fixed errors when we build libvirt with --with-storage-vstorage key > > Signed-off-by: Olga Krishtal > --- > src/storage/storage_backend_vstorage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > ACK (adjusted slightly to just add th

[libvirt] [PATCH] vstorage: fix build

2017-01-26 Thread Olga Krishtal
Fixed errors when we build libvirt with --with-storage-vstorage key Signed-off-by: Olga Krishtal --- src/storage/storage_backend_vstorage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_vstorage.c b/src/storage/storage_backend_vstorage.c index

Re: [libvirt] [PATCH] storage: Fix build due to recent storage backend code movement

2017-01-26 Thread Roman Bogorodskiy
John Ferlan wrote: > Commit id '5f07c3c07' broke the freebsd build in the libvirt CI test > environment because the UMOUNT was not defined unless WITH_STORAGE_FS > is defined. > > So remove the virStorageBackendUmountLocal from storage_util.c,h and > restore the code back in the storage_backend

Re: [libvirt] [PATCH v2 0/5] storage: Virtuozzo storage backend for storage pool

2017-01-26 Thread John Ferlan
[...] >> This series with the adjustments I made as a result of the series I >> posted related to moving API's to storage_util is now pushed. I believe >> I got the right things merged - please double check though so we can >> make adjustments sooner rather than later. That is grab the top, >> co

[libvirt] [PATCH] storage: Fix build due to recent storage backend code movement

2017-01-26 Thread John Ferlan
Commit id '5f07c3c07' broke the freebsd build in the libvirt CI test environment because the UMOUNT was not defined unless WITH_STORAGE_FS is defined. So remove the virStorageBackendUmountLocal from storage_util.c,h and restore the code back in the storage_backend_fs.c and _vstorage.c modules. Si

Re: [libvirt] [PATCH 2/3] storage: Create common file/dir pool backend helpers

2017-01-26 Thread John Ferlan
On 01/26/2017 11:39 AM, Roman Bogorodskiy wrote: > John Ferlan wrote: > >> Move some pool functions to storage_util to create local/common helpers >> using the same naming syntax as the existing upload, download, and wipe >> virStorageBackend*Local API's. >> >> In the process of doing so, foun

Re: [libvirt] [PATCH v2 0/5] storage: Virtuozzo storage backend for storage pool

2017-01-26 Thread Olga Krishtal
On 26/01/17 19:24, John Ferlan wrote: On 01/17/2017 09:10 AM, Olga Krishtal wrote: This series of patches support pool and volume management within Virtuozzo Storage. Virtuozzo Storage is a highly-available distributed software defined storage with built-in replication and disaster recovery. M

Re: [libvirt] [PATCH 2/3] storage: Create common file/dir pool backend helpers

2017-01-26 Thread Roman Bogorodskiy
John Ferlan wrote: > Move some pool functions to storage_util to create local/common helpers > using the same naming syntax as the existing upload, download, and wipe > virStorageBackend*Local API's. > > In the process of doing so, found a few API's that can now become local > to storage_util.

Re: [libvirt] [PATCH v2 0/5] storage: Virtuozzo storage backend for storage pool

2017-01-26 Thread John Ferlan
On 01/17/2017 09:10 AM, Olga Krishtal wrote: > This series of patches support pool and volume management within Virtuozzo > Storage. > Virtuozzo Storage is a highly-available distributed software defined storage > with built-in replication and disaster recovery. > More information about vzstorag

Re: [libvirt] Refactoring of storage pool

2017-01-26 Thread Olga Krishtal
On 26/01/17 17:49, Daniel P. Berrange wrote: On Wed, Jan 25, 2017 at 08:02:30PM +0300, Olga Krishtal wrote: Hi everyone! Half a year ago we started discussion about filesystem pools: https://www.redhat.com/archives/libvir-list/2016-April/msg01941.html https://www.redhat.com/archives/libvir-list/

[libvirt] [PATCH] Add libvirt-go-xml and libvirt-console-proxy to downloads

2017-01-26 Thread Daniel P. Berrange
Add recently created modules to the download page list. Signed-off-by: Daniel P. Berrange --- docs/downloads.html.in | 34 ++ 1 file changed, 34 insertions(+) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 25dc54d..99da7a6 100644 --- a/docs/do

Re: [libvirt] Refactoring of storage pool

2017-01-26 Thread Daniel P. Berrange
On Wed, Jan 25, 2017 at 08:02:30PM +0300, Olga Krishtal wrote: > Hi everyone! > Half a year ago we started discussion about filesystem pools: > https://www.redhat.com/archives/libvir-list/2016-April/msg01941.html > https://www.redhat.com/archives/libvir-list/2016-May/msg00208.html > https://www.red

Re: [libvirt] [PATCH v2] qemu: Don't lose group_name

2017-01-26 Thread Martin Kletzander
On Wed, Jan 25, 2017 at 03:53:20PM +0100, Martin Kletzander wrote: Due to our APIs not copying various pointers, we need to carry it around on the side and just supply it every time it is needed. Otherwise it will not work with both --live and --config options. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

2017-01-26 Thread Martin Kletzander
On Thu, Jan 26, 2017 at 12:43:09PM +0100, Michal Privoznik wrote: On 01/25/2017 03:18 PM, John Ferlan wrote: On 01/25/2017 08:55 AM, Martin Kletzander wrote: On Wed, Jan 25, 2017 at 06:43:39AM -0500, John Ferlan wrote: On 01/25/2017 04:16 AM, Martin Kletzander wrote: We were setting it ba

Re: [libvirt] [PATCH python 0/7] Remove unused code from generator

2017-01-26 Thread Daniel P. Berrange
ping On Thu, Jan 19, 2017 at 03:31:20PM +, Daniel P. Berrange wrote: > All this functionality is inherited from libxml, but is not required > to generate libvirt python bindings. > > Daniel P. Berrange (7): > Removed unused 'reference_keepers' code from generator > Removed unused 'functio

Re: [libvirt] [PATCH v1 3/4] bhyve: fix SATA address allocation

2017-01-26 Thread Roman Bogorodskiy
Laine Stump wrote: > On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: > > As bhyve for a long time didn't have a notion of the explicit SATA > > controller and created a controller for each drive, the bhyve driver > > in libvirt acted in a similar way and didn't care about the SATA > > controlle

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

2017-01-26 Thread Michal Privoznik
On 01/25/2017 03:18 PM, John Ferlan wrote: > > > On 01/25/2017 08:55 AM, Martin Kletzander wrote: >> On Wed, Jan 25, 2017 at 06:43:39AM -0500, John Ferlan wrote: >>> >>> >>> On 01/25/2017 04:16 AM, Martin Kletzander wrote: We were setting it based on whether it was supported and that lead to

Re: [libvirt] [PATCH 4/4] qemu: Implement mtu on interface

2017-01-26 Thread Michal Privoznik
On 01/25/2017 04:16 PM, Laine Stump wrote: > On 01/24/2017 10:40 AM, Michal Privoznik wrote: >> Not only we should set the MTU on the host end of the device but >> also let qemu know what MTU did we set. >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH 3/4] domain_conf: Introduce to

2017-01-26 Thread Michal Privoznik
On 01/25/2017 03:46 PM, Laine Stump wrote: > On 01/24/2017 10:40 AM, Michal Privoznik wrote: >> So far we allow to set MTU for libvirt networks. However, not all >> domain interfaces have to be plugged into a libvirt network and >> even if they are, they might want to have a different MTU (e.g. >>