On 03/10/2017 04:10 PM, John Ferlan wrote:
> If we have a connection pointer there's no sense walking through the
> sysfs in order to create/destroy the vHBA. Instead, let's make use of
> the node device create/destroy API's.
>
> Since we don't have to rewrite all the various parent options for
> t
On 03/10/2017 04:10 PM, John Ferlan wrote:
> Move the bulk of the code to the node_device_conf and rename to
> virNodeDevice{Create|Delete}Vport.
>
> Alter the create algorithm slightly in order to return the name of
> the scsi_host vHBA that was created. The existing code would fetch
> the name an
On 03/10/2017 04:10 PM, John Ferlan wrote:
> Move the virStoragePoolSourceAdapter from storage_conf.h and rename
> to virStorageAdapter.
>
> Continue with code realignment for brevity and flow.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/storage_adapter_conf.c| 71
> ++---
On 03/10/2017 04:10 PM, John Ferlan wrote:
> Rework the code to use the new FCHost specific adapter structures.
>
> Also rework the parameters to only pass what's need and leave logic in
> the caller for the adapter type and the need to call the helpers.
>
> Signed-off-by: John Ferlan
> ---
> src
On 03/10/2017 04:10 PM, John Ferlan wrote:
> Use the FCHost and SCSIHost adapter specific typedefs
>
> Signed-off-by: John Ferlan
> ---
> src/storage/storage_backend_scsi.c | 29 +++--
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/src/storage/storage
On 03/12/2017 08:42 AM, John Ferlan wrote:
>
>
>>
>> (This is the first time I've seen "relnode" used to save a ctxt->node. When
>> I look through the source, the one other place I see it is in virxml.c
>> (other places use "node", "save_node", "oldnode", "save_ctxt", "tmpnode",
>> and on an on)
---
docs/formatstorage.html.in | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index c787a059d..225e19000 100644
--- a/docs/formatstorage.html.in
+++ b/docs/formatstorage.html.in
@@ -
---
docs/formatstorage.html.in | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index c787a059d..225e19000 100644
--- a/docs/formatstorage.html.in
+++ b/docs/formatstorage.html.in
@@ -
Michal Privoznik wrote:
> On 02/12/2017 04:12 PM, Roman Bogorodskiy wrote:
> > Signed-off-by: Roman Bogorodskiy
> > ---
> > tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args | 12 +++
> > tests/bhyvexml2argvdata/bhyvexml2argv-vnc.ldargs | 1 +
> > tests/bhyvexml2argvdata/bhyvexml2argv-
On 03/11/2017 08:16 PM, Laine Stump wrote:
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Rather than use virXPathString, pass along an virXPathNode and alter
>> the parsing to use virXMLPropString.
>
> Just so I understand the reasoning correctly - you're not doing this so you
> can use virXM
On 03/11/2017 12:22 PM, Laine Stump wrote:
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Split out the code that munges through the storage pool adapter into
>> helpers - it's about to be moved into it's own source file.
>>
>> This is purely code motion at this point.
>>
>> Signed-off-by: John
On 03/11/2017 09:56 PM, Laine Stump wrote:
> On 03/11/2017 10:34 AM, Laine Stump wrote:
>> On 03/10/2017 04:10 PM, John Ferlan wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1428209
>>>
>>> Commit id 'bb74a7ffe' neglected to check that both the parent_wwnn
>>> parent_wwpn are in the XML i
12 matches
Mail list logo
