ping..
On Fri, Jan 27, 2017 at 4:29 PM, Shivaprasad G Bhat <
sb...@linux.vnet.ibm.com> wrote:
> Commit afe6e58 & c4caab53 made necessary changes to use io-helpers
> during save and restore. The commit c4caab53 missed to remove the
> redundant check in qemuDomainSaveImageOpen() because of which
>
On 03/13/2017 06:29 AM, Michal Privoznik wrote:
There were couple of reports on the list (e.g. [1]) that guests
with huge amounts of RAM are unable to start because libvirt
kills qemu in the initialization phase. The problem is that if
guest is configured to use hugepages kernel has to zero them
On 03/13/2017 06:29 AM, Michal Privoznik wrote:
While connecting to qemu monitor, the first thing we do is for it
s/is for/is wait for/
to show up. However, we are doing it with some timeout to avoid
indefinite waits (e.g. when qemu doesn't create the monitor
socket at all). After beaa447a29
On 03/13/2017 06:29 AM, Michal Privoznik wrote:
I am not able to test this properly (my host has "just" 32GiB of RAM), but I've
patched qemu to insert some delay into its init process and it worked just
fine.
Damn, I should have scanned the list today before also working on this problem.
Attac
On 03/14/2017 07:05 PM, John Ferlan wrote:
>
> On 03/11/2017 10:14 PM, Laine Stump wrote:
>> On 03/10/2017 04:10 PM, John Ferlan wrote:
>>> Rather than have lots of ugly inline code create helpers to try and
>>> make things more readable. While creating the helpers realign the code
>>> as necessary
On 03/14/2017 07:05 PM, John Ferlan wrote:
>
> On 03/11/2017 09:41 PM, Laine Stump wrote:
>> Ah, but wait! I ACKed this too soon! *This* is the patch that's renaming the
>> functions. It should be changing the arguments in some cases too (and at
>> least one of the names seems wrong).
>>
>>
>> On
On 03/11/2017 10:02 PM, Laine Stump wrote:
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Rather than have lots of ugly inline code create helpers to try and
>
> s/code create/code, create/ (it took me a second to parse it - at first my
> brain wanted to understand that there had been ugly i
On 03/11/2017 09:41 PM, Laine Stump wrote:
> Ah, but wait! I ACKed this too soon! *This* is the patch that's renaming the
> functions. It should be changing the arguments in some cases too (and at
> least one of the names seems wrong).
>
>
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Renam
On 03/11/2017 10:14 PM, Laine Stump wrote:
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Rather than have lots of ugly inline code create helpers to try and
>> make things more readable. While creating the helpers realign the code
>> as necessary.
>
> [same opinionated commentary about this be
On 02/23/2017 08:50 AM, Michal Privoznik wrote:
On 02/23/2017 03:26 PM, Matt Fleming wrote:
On Tue, 21 Feb, at 11:23:52AM, Michal Privoznik wrote:
Jim,
what is the actual problem? I've tried to reproduce this by running vm
with 3.5G RAM backed by 1GB huge pages and the guest runs just fine. I
On Tue, 14 Mar 2017 20:28:12 +0100
Andrea Bolognani wrote:
> On Tue, 2017-03-14 at 14:54 -0400, Luiz Capitulino wrote:
> > > It's unfortunate that the current, buggy behavior made
> > > it look like you didn't necessarily have to worry about
> > > this. If we fix it, existing guests will fail to
On Tue, 2017-03-14 at 14:54 -0400, Luiz Capitulino wrote:
> > It's unfortunate that the current, buggy behavior made
> > it look like you didn't necessarily have to worry about
> > this. If we fix it, existing guests will fail to start
> > right away instead of possibly crashing in the future:
> >
On 03/14/2017 02:30 PM, John Ferlan wrote:
>
> On 03/11/2017 08:16 PM, Laine Stump wrote:
>> On 03/10/2017 04:10 PM, John Ferlan wrote:
>>> Rather than use virXPathString, pass along an virXPathNode and alter
>>> the parsing to use virXMLPropString.
>> Just so I understand the reasoning correctly -
On Tue, 14 Mar 2017 19:40:38 +0100
Andrea Bolognani wrote:
> It's unfortunate that the current, buggy behavior made
> it look like you didn't necessarily have to worry about
> this. If we fix it, existing guests will fail to start
> right away instead of possibly crashing in the future:
> while t
On Tue, 2017-03-14 at 15:55 +0100, Peter Krempa wrote:
> > NB if we did enforce $RAM + $LARGE_NUMBER, then I'd suggest we did
> > set a default hard_limit universally once more, not only set a mlock
>
> We were already attempting to do this and we reverted it since there's
> no deterministic $LARG
On 03/11/2017 08:16 PM, Laine Stump wrote:
> On 03/10/2017 04:10 PM, John Ferlan wrote:
>> Rather than use virXPathString, pass along an virXPathNode and alter
>> the parsing to use virXMLPropString.
>
> Just so I understand the reasoning correctly - you're not doing this so you
> can use virXM
On Tue, 2017-03-14 at 20:58 +0400, Roman Bogorodskiy wrote:
> Pushed with the fixes applied, thanks!
Don't forget to document this new feature in the
release notes! ;)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailma
Michal Privoznik wrote:
> On 03/13/2017 07:02 PM, Roman Bogorodskiy wrote:
> > Introduce config file support for the bhyve driver. The only available
> > setting at present is 'firmware_dir' for specifying a directory with
> > UEFI firmware files.
> > ---
> > src/Makefile.am
ioh3420 is emulated Intel hardware, so it always looked
quite out of place in aarch64/virt guests.
If pcie-root-port is available in QEMU, use that device
instead.
---
It was mentioned somewhere, at some point, that we might
want to switch to generic PCIe Root Ports for x86/q35
guests as well.
It
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 04783aa..434a9f7 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -17,6 +17,15 @@
The virt-host-validate tool now supports bhyve hypervisor
+
+
The checks are now in a dedicated qemuProcessVerifyHypervFeatures
function.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 88 ++---
1 file changed, 55 insertions(+), 33 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_pro
When starting a domain with custom guest CPU specification QEMU may add
or remove some CPU features. There are several reasons for this, e.g.,
QEMU/KVM does not support some requested features or the definition of
the requested CPU model in libvirt's cpu_map.xml differs from the one
QEMU is using.
QEMU 2.9 introduces the pcie-root-port device, which is
a generic version of the existing ioh3420 device.
Make the new device available to libvirt users.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1408808
---
docs/schemas/domaincommon.rng| 1 +
src/conf/domain_con
Andrea Bolognani (4):
qemu: Add support for generic PCIe Root Ports
qemu: Use generic PCIe Root Ports by default for aarch64/virt
tests: Test generic PCIe Root Ports
news: Document support for generic PCIe Root Ports
docs/news.xml | 9 +
docs/sche
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor_json.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 3a29f1aa7..733daf096 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_mo
We want pcie-root-ports to be used for aarch64/virt guests
when available in QEMU, but at the same time we need to
ensure that other machine type and hosts where QEMU releases
lacking the new device type are not affected.
---
...uxml2argv-pcie-root-port-mach-virt-generic.args | 22 +
.
The checks are now in a dedicated qemuProcessVerifyKVMFeatures function.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 48820a2
Signed-off-by: Jiri Denemark
---
tests/domaincapstest.c | 38 --
tests/testutilsqemu.c | 48
2 files changed, 44 insertions(+), 42 deletions(-)
diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c
index
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 40 +---
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 25371b93d..894679373 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 42 ++
src/qemu/qemu_process.c| 13 +++
.../qemuxml2argv-aarch64-gic-host.xml | 2 +-
.../qemuxml2argv-aarch64-gic-v2.xml| 2 +-
The checks are now in a dedicated qemuProcessVerifyCPUFeatures function.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 48
1 file changed, 32 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process
When guest CPU definition uses VIR_CPU_CHECK_FULL checks, we need to
make sure QEMU does not add or remove any features.
https://bugzilla.redhat.com/show_bug.cgi?id=822148
https://bugzilla.redhat.com/show_bug.cgi?id=824989
Signed-off-by: Jiri Denemark
---
src/cpu/cpu.c | 3 ++-
src/cpu/cpu
The attribute can be used to request a specific way of checking whether
the virtual CPU matches created by the hypervisor matches the
specification in domain XML.
Signed-off-by: Jiri Denemark
---
docs/formatdomain.html.in | 30 ++
docs/schemas/cputypes.rng | 1
When starting a domain with custom guest CPU specification QEMU may add
or remove some CPU features. There are several reasons for this, e.g.,
QEMU/KVM does not support some requested features or the definition of
the requested CPU model in libvirt's cpu_map.xml differs from the one
QEMU is using.
qemuMonitorGetGuestCPU can now optionally create CPU data from
filtered-features in addition to feature-words.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor.c | 11 ---
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_monitor_json.c | 25 +++--
src/q
Signed-off-by: Jiri Denemark
---
docs/formatdomain.html.in | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 9a204f845..75367d6dd 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.ht
On 03/12/2017 11:47 AM, Alexander Vasilenko wrote:
> ---
> docs/formatstorage.html.in | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
I altered the commit message a bit:
docs: Move 'timestamps' and 'encryption' sub-element description
The d
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 76
> +
> src/qemu/qemu_domain.h | 8 ++
> src/qemu/qemu_hotplug.c | 11 +++
> 3 files changed, 95 insertions(+)
>
> di
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Some users might want to pass a blockdev or a chardev as a
> backend for NVDIMM. In fact, this is expected to be the mostly
> used configuration. Therefore libvirt should allow the device in
> devices CGroup then.
>
> Signed-off-by: Michal Privoz
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Now that we have APIs for relabel memdevs on hotplug, fill in the
> missing implementation in qemu hotplug code.
>
> The qemuSecurity wrappers might look like overkill for now,
> because qemu namespace code does not deal with the nvdimms yet.
> N
On Mon, Mar 13, 2017 at 18:16:49 +, Daniel Berrange wrote:
> On Mon, Mar 13, 2017 at 02:08:30PM -0400, Luiz Capitulino wrote:
> > On Mon, 13 Mar 2017 13:53:33 -0400
> > Luiz Capitulino wrote:
> >
> > > OK, you're right. I personally don't like we're putting a random cap
> > > on QEMU memory a
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_dac.c | 3 +++
> src/security/security_nop.c | 19 +++
> src/security/security_selinux.c | 3 +++
> 3 files changed, 25 insertions(+)
>
ACK,
John
--
libv
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> These APIs will be used whenever we are hot (un-)plugging a
> memdev.
>
> Signed-off-by: Michal Privoznik
> ---
> src/libvirt_private.syms| 2 ++
> src/security/security_driver.h | 9 +++
> src/security/security_manager.c | 56
>
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> When domain is being started up, we ought to relabel the host
> side of NVDIMM so qemu has access to it.
>
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_selinux.c | 66
> +
> 1 file cha
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> When domain is being started up, we ought to relabel the host
> side of NVDIMM so qemu has access to it.
>
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_dac.c | 73
> +
> 1 file cha
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> For NVDIMM devices it is optionally possible to specify the size
> of internal storage for namespaces. Namespaces are a feature that
> allows users to partition the NVDIMM for different uses.
>
> Signed-off-by: Michal Privoznik
> ---
> docs/for
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c| 5 +++--
> .../qemuxml2argv-memory-hotplug-nvdimm-access.args | 26
> ++
> tests/qemuxml2argvtest.c | 2
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Now that NVDIMM has found its way into libvirt, users might want
> to fine tune some settings for each module separately. One such
> setting is 'share=on|off' for the memory-backend-file object.
> This setting - just like its name suggest already
On Tue, Mar 14, 2017 at 02:18:48PM +0100, Olaf Hering wrote:
Am Tue, 14 Mar 2017 14:05:37 +0100
schrieb Martin Kletzander :
However without that commit we'll be back to broken code that won't compile on
some distros. So unless I missed something (if I did, it should be added to
the commit me
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> So, majority of the code is just ready as-is. Well, with one
> slight change: differentiate between dimm and nvdimm in places
> like device alias generation, generating the command line and so
> on.
>
> Speaking of the command line, we also need
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Introduce a qemu capability for -device nvdimm.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_capabilities.c | 9 +
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 10 insertions(+)
>
ACK,
John
--
libvir-list mai
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> NVDIMM is new type of memory introduced into QEMU 2.6. The idea
> is that we have a Non-Volatile memory module that keeps the data
> persistent across domain reboots.
>
> At the domain XML level, we already have some representation of
> 'dimm' mo
Am Tue, 14 Mar 2017 14:05:37 +0100
schrieb Martin Kletzander :
> However without that commit we'll be back to broken code that won't compile
> on some distros. So unless I missed something (if I did, it should be added
> to the commit message), there should rather be a configure check that defi
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Frankly, this function is one big mess. A lot of arguments,
> complicated behaviour. It's really surprising that arguments were
> in random order (input and output arguments were mixed together),
> the documentation was outdated, the description o
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 49
> ++---
> src/qemu/qemu_command.h | 5 +
> src/qemu/qemu_hotplug.c | 6 ++
> 3 files changed, 25 insertions(+), 35 delet
On Tue, Mar 14, 2017 at 08:55:30AM +, Olaf Hering wrote:
All PERF_* names are enmus. Enums are ordinary code for CPP.
An ifdef does not trigger.
Fixes 1d29c889a ("Make use of PERF_COUNT_HW_REF_CPU_CYCLES conditional")
Well, it *reverts* that commit. If that is desired, it should rather be
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> Even though this variable contains just values from an enum where
> zero has the usual meaning, it's enum after all and we should
> check it as such.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 3 ++-
> 1 file changed,
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
> This is an input argument. We should not overwrite it.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
ACK
John
--
libvir-list mailing list
libvir-list@redhat
On Mon, 2017-03-13 at 14:24 -0400, Luiz Capitulino wrote:
> > NB if we did enforce $RAM + $LARGE_NUMBER, then I'd suggest we did
> > set a default hard_limit universally once more, not only set a mlock
> > limit when using . This would at least ensure we see consistent
> > (bad) behaviour rather th
On 03/13/2017 07:02 PM, Roman Bogorodskiy wrote:
> Introduce config file support for the bhyve driver. The only available
> setting at present is 'firmware_dir' for specifying a directory with
> UEFI firmware files.
> ---
> src/Makefile.am | 25 +++-
> src/bhyve/bhyve.con
All PERF_* names are enmus. Enums are ordinary code for CPP.
An ifdef does not trigger.
Fixes 1d29c889a ("Make use of PERF_COUNT_HW_REF_CPU_CYCLES conditional")
Signed-off-by: Olaf Hering
---
src/util/virperf.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/util/virperf.c b/src/util
61 matches
Mail list logo
