On 08/15/2017 03:00 AM, John Ferlan wrote:
>
>
> On 08/07/2017 08:20 AM, Michal Privoznik wrote:
>> This API is definitely modifying state of @vm. Therefore it
>> should grab a job.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/qemu/qemu_driver.c | 23 ++-
>> 1 file ch
On 08/14/2017 05:42 PM, Ján Tomko wrote:
> On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote:
>> This is basically taken from libvirt repo. I'm creating .mailmap
>> to avoid doubled entries in the AUTHORS file. Also, AUTHORS is no
>> longer tracked by git.
>>
>> Signed-off-by: Michal
ping?
Tks,
John
On 07/21/2017 05:47 PM, John Ferlan wrote:
> If an environment specific _tls_x509_cert_dir is provided, then
> do not VIR_STRDUP the defaultTLSx509secretUUID as that would be
> for the "default" environment and not the vnc, spice, chardev, or
> migrate environments. If the envir
On 08/08/2017 11:25 AM, Pavel Hrdina wrote:
> Pavel Hrdina (7):
> maint: cleanup gitignore
> maint: ignore dist tarball
> build: fix distcheck
> build: move test related bits to test/Makefile.am
> maint: move service file into data directory
> data: add system dbus service file
> da
ping^^2
Again, don't bother with patches 4-6.
Tks,
John
On 08/02/2017 07:27 AM, John Ferlan wrote:
>
> ping -
>
> perhaps at least the first 3...
>
> I'm now beginning to think/wonder if using the rwlock_rdlock would be
> the solution at least for nwfilter objs. It seems from a quick scan o
ping? Although there could be merge conflicts with most recent top of
tree. I could repost if desired.
To help with the which have R-B and which do not...
Patch 1 & 2 were essentially R-B before, but with the split
Patches 3-5 got a please change where something lands, but otherwise
looks goo
On 08/07/2017 10:16 PM, Chen Hanxiao wrote:
> At 2017-08-03 08:40:48, "John Ferlan" wrote:
>>
>>
>> On 07/28/2017 04:33 AM, Chen Hanxiao wrote:
>>> From: Chen Hanxiao
>>>
>>> Many vendor id's and product id's have leading zeros.
>>> Show them in error messages.
>>>
>>> Signed-off-by: Ch
On 08/07/2017 08:20 AM, Michal Privoznik wrote:
> This API is definitely modifying state of @vm. Therefore it
> should grab a job.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 23 ++-
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
Not sure wh
On 08/03/2017 04:50 AM, Peter Krempa wrote:
> On Thu, Aug 03, 2017 at 10:28:59 +0200, Bjoern Walk wrote:
>> Peter Krempa [2017-08-03, 09:47AM +0200]:
>>> On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote:
Peter Krempa [2017-08-02, 05:39PM +0200]:
> It turns out that our impleme
On 07/28/2017 10:57 AM, Scott Garfinkle wrote:
> From: Scott Garfinkle
>
Again no commit message. Maybe a bit more verbose here indicating what's
being added.
You also need a followup patch 4 to docs/news.xml to adjust the 3.7.0
docs to describe the new feature briefly.
> ---
> tools/virsh-
On 07/28/2017 10:57 AM, Scott Garfinkle wrote:
> From: Scott Garfinkle
>
Need a commit message. Typically this is something like "Set up wire and
protocol for xxx" (see commit id 20ffaf59d for the SetMaxDowntime example)
> ---
> src/qemu/qemu_driver.c | 51
> ++
On 07/28/2017 10:57 AM, Scott Garfinkle wrote:
> From: Scott Garfinkle
>
Since you'll be updating anyway from your regular email (e.g. non lotus
notes account)... Add a brief commit message here. It can be as simple
as introduce the xxx API in order to allow fetching the current downtime
value
When security drivers are active and domain def contains
no elements, there is no need to autogenerate
seclabels when starting the domain, e.g.
In fact, autogenerating the label can result in needless
save/restore and migration failures when the security driver
is not active on the restore/mi
Changelog
-
Changes v3 -> v4:
* New compact representation of slot sets.
* New generic code to automatically merge similar slots
into a single entry in the command output while keeping
implementations of the method simpler.
* Example implementation of IDE and USB bus enumeration
Chang
This adds a new command to QMP: query-device-slots. It will allow
management software to query possible slots where devices can be
plugged.
Slot sets are represented by a list of option names and sets of
possible values for each of those options. We use a compact
format for set of valid values, t
As in previous doc, it may cause confusion about whether parallel_shutdown would
take effect when guests are asked to suspend on host shutdown. Hence, changed
the
doc of parallel_shutdown, make it more clear.
Signed-off-by: Lily Zhu
---
tools/libvirt-guests.sysconf | 6 --
1 file changed, 4
On Mon, Aug 14, 2017 at 05:51:59PM +0200, Ján Tomko wrote:
> On Mon, Aug 07, 2017 at 04:31:30PM +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/qemu/qemu_driver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/qemu/qemu_driver.c b/src/
On Mon, Aug 14, 2017 at 05:10:00PM +0200, Ján Tomko wrote:
> On Mon, Aug 14, 2017 at 02:32:39PM +0200, Pavel Hrdina wrote:
> > Pavel Hrdina (8):
> > util: introduce virXMLNodeNameEqual
> > use virXMLNodeNameEqual instead of xmlStrEqual
> > conf: cleanup virDomainChrSourceDef parsing
> > conf: u
On Mon, Aug 07, 2017 at 04:31:31PM +0200, Pavel Hrdina wrote:
The correct lock order is:
nwfilter driver lock (not used in this code path)
nwfilter update lock
virt driver lock (not used in this code path)
domain object lock
but the current code have this order:
domain object lock
nwfilt
On Mon, Aug 07, 2017 at 04:31:30PM +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index b3f65f440d..0b549f20da 100644
--- a/src/qemu/qemu_driver.c
On Sat, Aug 05, 2017 at 02:29:58PM +0200, Michal Privoznik wrote:
This is basically taken from libvirt repo. I'm creating .mailmap
to avoid doubled entries in the AUTHORS file. Also, AUTHORS is no
longer tracked by git.
Signed-off-by: Michal Privoznik
---
.gitignore| 1 +
.mailmap
On Thu, Aug 03, 2017 at 12:00:42PM -0400, Cole Robinson wrote:
There's some specific logic in qemuBuildCpuCommandLine to support
auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu binary.
Add a test case for it
Signed-off-by: Cole Robinson
---
v2:
Drop unnecessary qemu-kvm path usage
On Mon, Aug 14, 2017 at 02:32:39PM +0200, Pavel Hrdina wrote:
Pavel Hrdina (8):
util: introduce virXMLNodeNameEqual
use virXMLNodeNameEqual instead of xmlStrEqual
conf: cleanup virDomainChrSourceDef parsing
conf: use virXMLPropString for KeyWrapCipherDef parsing
FYI there is a non-breaking
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 46 +-
1 file changed, 13 insertions(+), 33 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/dom
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 59 --
1 file changed, 33 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 528d11c17d..9dc788
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index cb1b5b55fb..6e424c96
The @remaining variable is leftover from old code and it's not
used anymore.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 37aa975eca..528d1
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6e424c96d8..23ef46dc79
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 +
src/util/virxml.c| 16
src/util/virxml.h| 3 +++
3 files changed, 20 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 447dd938d0..4f1ad2a0cc 100644
--- a/src/lib
Pavel Hrdina (8):
util: introduce virXMLNodeNameEqual
use virXMLNodeNameEqual instead of xmlStrEqual
conf: cleanup virDomainChrSourceDef parsing
conf: use virXMLPropString for KeyWrapCipherDef parsing
conf: use virXMLPropString for disk geometry parsing
conf: use virXMLPropString for IO
Signed-off-by: Pavel Hrdina
---
src/conf/cpu_conf.c | 2 +-
src/conf/domain_conf.c | 212 +--
src/conf/interface_conf.c| 2 +-
src/conf/netdev_bandwidth_conf.c | 6 +-
src/conf/netdev_vport_profile_conf.c | 2 +
On 08/08/2017 07:00 PM, Scott Garfinkle wrote:
> I think this may have gotten lost in the 3.6 release. Does someone have
> the time to review this, please?
"Typically" in order to get someone to review a series that hasn't been
looked at you should reply-all to the .0 cover-letter (or just the
s
Ping - opinions on this or is it ready to be committed?
On this reply setting Guido on CC as he has experience on apparmor patches
in libvirt and commit rights.
On Fri, Aug 11, 2017 at 8:58 PM, intrigeri
wrote:
> Hi,
>
> Christian Ehrhardt:
> > With that qemu change in place the rules generate
On Fri, Aug 11, 2017 at 17:05:28 -0300, Guido Günther wrote:
> ---
> src/vbox/vbox_tmpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This clasifies for the 'trivial' rule.
>
> diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> index 07f25ba24f..dffeabde02 100644
> --- a/src
35 matches
Mail list logo
