Hi Peter,
Do let me know if there's anything else I can help with on setting up the
VxHS devices for testing.
Thanks,
Ashish
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Sep 26, 2017 at 05:06:37PM -0400, John Ferlan wrote:
>
>
> On 09/18/2017 11:45 PM, Liu Qing wrote:
> > Qcow2 small IO random write performance will drop dramatically if the l2
> > cache table could not cover the whole disk. This will be a lot of l2
> > cache table RW operations if cache m
In virNWFilterIPAddrMapAddIPAddr the @val may be leaked.
Signed-off-by: ZhiPeng Lu
---
src/conf/nwfilter_ipaddrmap.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c
index 446f3de..5242f05 100644
--- a/src/conf/
Signed-off-by: zhenwei.pi
---
domain.go | 76 +++---
domain_test.go | 38 +
2 files changed, 95 insertions(+), 19 deletions(-)
diff --git a/domain.go b/domain.go
index d81ac2a..773a83e 100644
--- a/domain.go
+
In learnIPAddressThread()the @inetaddr may be leaked.
Signed-off-by: ZhiPeng Lu
---
src/nwfilter/nwfilter_learnipaddr.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/nwfilter/nwfilter_learnipaddr.c
b/src/nwfilter/nwfilter_learnipaddr.c
index cfd92d9..0cadf73 10064
>On 09/26/2017 03:54 PM, ZhiPeng Lu wrote:>> In learnIPAddressThread()the
>@inetaddr may be leaked.>> > Signed-off-by: ZhiPeng Lu
>> ---> src/nwfilter/nwfilter_learnipaddr.c | 4 +++->
>1 file changed, 3 insertions(+), 1 deletion(-)> > diff --git
>a/src/nwfilter/nwfilter_learnipaddr.c b/src/nw
On 09/25/2017 04:37 PM, Peter Krempa wrote:
> When the vcpu is successfully removed libvirt would remove the cgroup.
> In cases when removal of the cgroup fails libvirt would report an error.
>
> This does not make much sense, since the vcpu was removed and we can't
> really do anything with the
On 09/25/2017 11:46 AM, Ján Tomko wrote:
> Calling fallocate on the new (smaller) capacity ensures
> that the whole file is allocated, but it does not reduce
> the file size.
>
> Also call ftruncate after fallocate.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1366446
> ---
> src/util/virst
On 09/26/2017 03:54 PM, ZhiPeng Lu wrote:
> In learnIPAddressThread()the @inetaddr may be leaked.
>
> Signed-off-by: ZhiPeng Lu
> ---
> src/nwfilter/nwfilter_learnipaddr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/nwfilter/nwfilter_learnipaddr.c
> b/src/
On 09/25/2017 11:46 AM, Ján Tomko wrote:
> We have been trying to implement the ALLOCATE flag to mean
Is this the colloquial "we"? ;-)
> "the volume should be fully allocated after the resize".
commit id 'aa2a4cff' added support for ALLOCATE, but it seems that code
was wrong, then?
The docs a
On 09/25/2017 11:46 AM, Ján Tomko wrote:
> Introduce a new function virFileAllocate that will call the
> non-destructive variants of safezero, essentially reverting
> my commit 1390c268
> safezero: fall back to writing zeroes even when resizing
> back to the state as of commit 18f0316
> v
Signed-off-by: Jeroen Simonetti
---
domain.go | 22 ++
domain_test.go | 41 +
2 files changed, 55 insertions(+), 8 deletions(-)
diff --git a/domain.go b/domain.go
index 3ab54a1..805909f 100644
--- a/domain.go
+++ b/domain.go
@@ -17
On 09/18/2017 11:45 PM, Liu Qing wrote:
> Qcow2 small IO random write performance will drop dramatically if the l2
> cache table could not cover the whole disk. This will be a lot of l2
> cache table RW operations if cache miss happens frequently.
>
> This patch exports the qcow2 driver paramet
On 09/25/2017 10:25 AM, Peter Krempa wrote:
> Some values we read from the qemu monitor may be changed with the actual
> state by the incomming migration. This means that we should refresh
s/incomming/incoming
> certain things only after the migration has finished.
>
> This is mostly visible i
Rather than building the "file" string in qemuBuildSCSIHostdevDrvStr
build it in the called helper.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5f527
Add the capability to use the blockdev-add query-qmp-schema option
to find the 'password-secret' parameter that will allow the iSCSI
code to use the master secret object to encrypt the secret for an
and only need to provide the object id of the secret on the command
line thus obsfuscating the passp
Rather than placing/using privateData about secinfo in the hostdev,
let's use the virStorageSource (e.g. disksrc) instead.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 5 ++---
src/qemu/qemu_domain.c | 21 +
2 files changed, 15 insertions(+), 11 deletions(-)
di
Since it's not longer used to shuttle the @secinfo, let's remove
the private hostdev completely.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c| 12 ++-
src/conf/domain_conf.h| 4 +---
src/lxc/lxc_native.c | 2 +-
src/qemu/qemu_domain.c| 50 +++--
Rather than picking apart the two pieces we need/want (path, hosts,
and auth)- let's just use the new virDomainDiskStorageSourceNew API
in order to allocate and use a virStorageSourcePtr.
The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need
to "fake" one for the qemuBuildNetworkDriv
Since the virStorageEncryptionPtr encryption; is a member of
_virStorageSource it really should be allowed to be a subelement
of the disk for various disk formats:
Source{File|Dir|Block|Volume}
SourceProtocol{RBD|ISCSI|NBD|Gluster|Simple|HTTP}
NB: Simple includes sheepdog, ftp, ftps, tftp
Add helper to manage the virStorageSourcePtr allocation for disk->src,
disk->mirror, and disk->src->backingStore.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.
Since the encryption information can also be disk source specific
move it from _qemuDomainDiskPrivate to _qemuDomainDiskSrcPrivate.
Since the last allocated element from _qemuDomainDiskPrivate is
removed, that means we no longer need qemuDomainDiskPrivateDispose.
Signed-off-by: John Ferlan
---
When commit id 'da86c6c22' added support for diskPriv->encinfo in
qemuDomainSecretDiskPrepare a change to qemuDomainSecretDiskDestroy
to was missed. Although qemuDomainDiskPrivateDispose probably would
do the trick.
Signed-off-by: John Ferlan
---
src/qemu/qemu_domain.c | 7 ---
1 file change
Create a qemu* specific StorageSourceCopy helper because we need
to be able to copy the PrivateData too if it exists without adding
any knowledge to the virStorageSourceCopy function.
Signed-off-by: John Ferlan
---
src/qemu/qemu_blockjob.c | 2 +-
src/qemu/qemu_domain.c | 63 +
https://bugzilla.redhat.com/show_bug.cgi?id=1425757
The blockdev-add code provides a mechanism to sanely provide user
and password-secret arguments for iscsi without placing them on the
command line to be viewable by a 'ps -ef' type command or needing
to create separate -iscsi devices for each dis
Relocate into disk source private (qemuDomainDiskSrcPrivatePtr)
Since the secret information is really _virStorageSource specific
piece of data, let's manage the privateData from there instead of
at the Disk level.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 6 --
src/qemu/qem
Signed-off-by: John Ferlan
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index aab812b25..18ac28d87 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -59,6 +59,19 @@
kernel-forward-plane-offload).
Introduce the bare necessities to add privateData to _virStorageSource.
Subsequent patches will fill in more details.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.h| 1 +
src/qemu/qemu_domain.c| 43 +++
src/qemu/qemu_domain.h| 13 ++
Since the virStorageAuthDefPtr auth; is a member of _virStorageSource
it really should be allowed to be a subelement of the disk
for the RBD and iSCSI prototcols. That way we can set up to allow
the element to be formatted within the disk source.
Since we've allowed the to be a child of , we'll
v3: https://www.redhat.com/archives/libvir-list/2017-September/msg00881.html
Difference with v3:
Add patch 3 to perform virStorageSourceCopy for qemu and storage source
private data.
Adjust the move encinfo from private disk to private disk src to handle
the Copy for the @encinfo too
Repeated
Ugh... Need to SNACK forgot the virStorageSourceCopy for qemu
privateData of _virStorageSource
John
On 09/25/2017 06:22 PM, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2017-September/msg00466.html
>
> Changes since v2:
>
> * Former Patch 1 & 2 were pushed
>
> * N
Introduce the bare necessities to add privateData to _virStorageSource.
Subsequent patches will fill in more details.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.h| 1 +
src/qemu/qemu_domain.c| 43 +++
src/qemu/qemu_domain.h| 13 ++
Since the virStorageAuthDefPtr auth; is a member of _virStorageSource
it really should be allowed to be a subelement of the disk
for the RBD and iSCSI prototcols. That way we can set up to allow
the element to be formatted within the disk source.
Since we've allowed the to be a child of , we'll
Create a qemu* specific StorageSourceCopy helper because we need
to be able to copy the PrivateData too if it exists without adding
any knowledge to the virStorageSourceCopy function.
Signed-off-by: John Ferlan
---
Naturally I realized today after sending this yesterday that the
virStorageSour
We discovered that the entire python process get stuck for about 30
seconds when calling virDomain.getMemoryStats() if libvirt is stuck in
virConnect.getAllDomainStats() on inaccessible storage. This blocking
cause a horrible mess in oVirt.
This patches adds the standard *_ALLOW_THREADS around the
On 09/18/2017 12:57 PM, Nitesh Konkar wrote:
> libvirtd throws unhandled signal 11 on ppc while running
> virsh cpu-compare with missing model tag in the xml. This
> patch errors out in such situation.
You could provide the example XML snippet ... and as noted below what
the "expectations" are
ping -
Would be good to close on this before freeze. I think design has been
agreed upon and Ashish has tested.
Only patches 3 and 4 are not re-reviewed.
Tks -
John
On 09/19/2017 09:32 PM, John Ferlan wrote:
> v8: https://www.redhat.com/archives/libvir-list/2017-September/msg00375.html
>
>
On 09/26/2017 07:58 AM, Ján Tomko wrote:
> Use an empty string to let qemu fill out the default.
Matches what's done in qemuBuildChrChardevStr
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1454671
> ---
> src/qemu/qemu_monitor_json.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-
On Wed, Sep 20, 2017 at 04:01:14PM +0200, Pavel Hrdina wrote:
> This reverts commit edaf4ebe95a5995585c8ab7bc5b92887286d4431.
>
> This uses "reconnect" as attribute for element, but we already
> have a element for element for chardev devices.
>
> Since this is the same feature for different de
Commit 6801da94 fixed the typo in the function name, but forgot
to adjust the indentation level of the next line.
---
Pushed as trivial.
src/qemu/qemu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index a095d6e98..0b0
The packet with passed FD has the following format:
--
| len | header | payload |
--
where "payload" has an additional count of FDs before the actual data:
--
| nfds | payload |
--
When the p
On Tue, Sep 26, 2017 at 04:39:36PM +0200, Peter Krempa wrote:
---
Pushed as trivial.
src/qemu/qemu_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index cb371f1e8..a095d6e98 100644
--- a/src/qemu/qemu_domain.c
+++ b
---
Pushed as trivial.
src/qemu/qemu_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index cb371f1e8..a095d6e98 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1796,7 +1796,7 @@ qemuDomainObjPri
On Fri, Sep 08, 2017 at 06:57:30AM -0500, Brijesh Singh wrote:
> Hi All,
Sorry if below comment doesn't make sense, I might be misunderstanding
something basic about SEV. Also sorry about the delay, I've been on
vacation.
> (sorry for the long message)
>
> CPUs from AMD EPYC family supports Sec
On Tue, Sep 26, 2017 at 01:40:30PM +0200, Ján Tomko wrote:
> It is possible (although possibly not very useful) to leave out
> the service attribute when using
>
> Fix the formatter bug introduced by commit 4a0da34 and format
> the host when its present (checked for non-NULL inside
> virBufferEsca
On Tue, Sep 26, 2017 at 01:58:52PM +0200, Ján Tomko wrote:
It is possible (although possibly not very useful) to leave out
the service attribute when using
Fix the formatter bug introduced by commit 4a0da34 and format
the host when its present (checked for non-NULL inside
virBufferEscapeString)
On 09/26/2017 01:34 PM, John Ferlan wrote:
>
>
> On 09/26/2017 05:38 AM, Michal Privoznik wrote:
>> On 09/12/2017 04:29 PM, John Ferlan wrote:
>>>
>>>
>>> On 09/05/2017 07:45 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1447169
Signed-off-by: Michal Privo
In learnIPAddressThread()the @inetaddr may be leaked.
Signed-off-by: ZhiPeng Lu
---
src/nwfilter/nwfilter_learnipaddr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/nwfilter/nwfilter_learnipaddr.c
b/src/nwfilter/nwfilter_learnipaddr.c
index cfd92d9..5dc212e 100644
Ján Tomko (2):
conf: fix formatting of udp chardev attributes
qemu: fix hotplug of udp device with no connect host
src/conf/domain_conf.c | 12
src/qemu/qemu_monitor_json.c| 5 -
tests/genericxml2xmloutdata/generic-chardev
It is possible (although possibly not very useful) to leave out
the service attribute when using
Fix the formatter bug introduced by commit 4a0da34 and format
the host when its present (checked for non-NULL inside
virBufferEscapeString) instead of basing it on the presence
of the service attribut
Use an empty string to let qemu fill out the default.
https://bugzilla.redhat.com/show_bug.cgi?id=1454671
---
src/qemu/qemu_monitor_json.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 63b855920..c63d250d3
It is possible (although possibly not very useful) to leave out
the service attribute when using
Fix the formatter bug introduced by commit 4a0da34 and format
the host when its present (checked for non-NULL inside
virBufferEscapeString) instead of basing it on the presence
of the service attribut
On Tue, Sep 26, 2017 at 01:36:13PM +0200, Martin Kletzander wrote:
> On Tue, Sep 26, 2017 at 11:16:05AM +0100, Daniel P. Berrange wrote:
> > When python3 builds C modules, it adds the -Wsign-compare flag to GCC.
> > This creates lots of warnings where we compare a 'size_t' value against
> > an 'int
On 09/26/2017 12:30 PM, Daniel P. Berrange wrote:
> On Tue, Sep 26, 2017 at 11:38:26AM +0200, Michal Privoznik wrote:
>> On 09/12/2017 04:29 PM, John Ferlan wrote:
>>>
>>>
>>> On 09/05/2017 07:45 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1447169
Signed-o
In learnIPAddressThread()the @inetaddr may be leaked.
Signed-off-by: ZhiPeng Lu
---
src/nwfilter/nwfilter_learnipaddr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/nwfilter/nwfilter_learnipaddr.c
b/src/nwfilter/nwfilter_learnipaddr.c
index cfd92d9..018f20f 100644
On Tue, Sep 26, 2017 at 11:16:05AM +0100, Daniel P. Berrange wrote:
When python3 builds C modules, it adds the -Wsign-compare flag to GCC.
This creates lots of warnings where we compare a 'size_t' value against
an 'int' value due to signed/unsigned difference. Change all the size_t
types to ssiz
On 09/26/2017 05:38 AM, Michal Privoznik wrote:
> On 09/12/2017 04:29 PM, John Ferlan wrote:
>>
>>
>> On 09/05/2017 07:45 AM, Michal Privoznik wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
>>>
>>> Signed-off-by: Michal Privoznik
>>> ---
>>> src/qemu/qemu_driver.c
Please delay review, I plan to provide better patch.
On 08.09.2017 10:16, Nikolay Shirokovskiy wrote:
> Patch aeda1b8c needs some enhancement.
>
> 1. Shutdown event is delivired on reboot too and we don't want
> to set willhangup flag is this case.
>
> 2. There is a next race condition.
>
> -
Somewhere around commit 9ff9d9f reserving entire PCI slots was
eliminated, as demonstrated by commit 6cc2014.
Reserve the functions required by the implicit devices:
00:01.0 ISA Bridge
00:01.1 IDE Controller
00:01.2 USB Controller (unless USB is disabled)
00:01.3 Bridge
https://bugzilla.redhat.co
The address is restricted to 0:0:1.2 only for the piix3-uhci controller
with index 0.
https://bugzilla.redhat.com/show_bug.cgi?id=1460602
---
src/qemu/qemu_domain_address.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_ad
Ján Tomko (2):
qemu: reserve PCI addresses for implicit i440fx devices
qemu: clarify error message for index 0 PIIX3 USB controller
src/qemu/qemu_domain_address.c | 17 +++
.../qemuxml2argv-440fx-ide-address-conflict.xml| 25 ++
tests/qe
On Tue, Sep 26, 2017 at 11:38:26AM +0200, Michal Privoznik wrote:
> On 09/12/2017 04:29 PM, John Ferlan wrote:
> >
> >
> > On 09/05/2017 07:45 AM, Michal Privoznik wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
> >>
> >> Signed-off-by: Michal Privoznik
> >> ---
> >> src/qemu/qe
When python3 builds C modules, it adds the -Wsign-compare flag to GCC.
This creates lots of warnings where we compare a 'size_t' value against
an 'int' value due to signed/unsigned difference. Change all the size_t
types to ssize_t to address this.
Signed-off-by: Daniel P. Berrange
---
libvirt-
On Tue, Sep 26, 2017 at 12:45:16AM +0200, Wojtek Porczyk wrote:
> On Mon, Sep 25, 2017 at 12:14:24PM +0100, Daniel P. Berrange wrote:
> > On Fri, Sep 22, 2017 at 05:54:04PM +0200, Wojtek Porczyk wrote:
> > > Hi libvirt-list,
> > >
> > > I'd like to submit a second iteration of libvirtaio series fo
For vhost-user ports, Open vSwitch acts as the server and QEMU the client.
When OVS crashes or restarts, the QEMU process should be reconnected to
OVS.
Signed-off-by: ZhiPeng Lu
---
docs/schemas/domaincommon.rng | 26 --
src/conf/domain_conf.c
On Tue, Sep 26, 2017 at 11:15:36AM +0100, Daniel P. Berrange wrote:
> Latest GCC versions are unhappy with us treating an integer
> arithmetic result as a boolean:
>
> libvirt-utils.c: In function ‘virReallocN’:
> libvirt-utils.c:111:23: warning: ‘*’ in boolean context, suggest ‘&&’ instead
> [-W
VM private data is cleared when the VM is turned off and also when the
VM object is being freed. Some of the clearing code was duplicated.
Extract it to a separate function.
This also removes the now unnecessary function
qemuDomainClearPrivatePaths.
---
src/qemu/qemu_domain.c | 76 ++
On Tue, Sep 26, 2017 at 12:47:00AM +0200, Wojtek Porczyk wrote:
> On Mon, Sep 25, 2017 at 02:53:01PM +0100, Daniel P. Berrange wrote:
> > On Thu, Sep 14, 2017 at 02:41:12AM +0200, Wojtek Porczyk wrote:
> > > The intended use is to ensure that the implementation is empty, which is
> > > one way to e
Latest GCC versions are unhappy with us treating an integer
arithmetic result as a boolean:
libvirt-utils.c: In function ‘virReallocN’:
libvirt-utils.c:111:23: warning: ‘*’ in boolean context, suggest ‘&&’ instead
[-Wint-in-bool-context]
if (!tmp && (size * count)) {
~~^
On Tue, Sep 26, 2017 at 12:46:02AM +0200, Wojtek Porczyk wrote:
> On Mon, Sep 25, 2017 at 02:43:56PM +0100, Daniel P. Berrange wrote:
> > On Thu, Aug 24, 2017 at 09:22:49PM +0200, Wojtek Porczyk wrote:
> > > This logging is helpful for tracing problems with unclosed connections
> > > and leaking fi
On 09/12/2017 04:29 PM, John Ferlan wrote:
>
>
> On 09/05/2017 07:45 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/qemu/qemu_driver.c | 4 +-
>> src/qemu/qemu_hotplug.c
The command "info migrate" of qemu outputs the dirty-pages-rate during
migration, but page size is different in different architectures. So
page size should be output to calculate dirty pages in bytes.
Page size is already implemented with commit
030ce1f8612215fcbe9d353dfeaeb2937f8e3f94 in qemu.
N
72 matches
Mail list logo
