v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00673.html
(and a few pings along the way)
Don't think much survived from v2 - this is a fresh start anyway.
Perhaps old patch 2 the same, but beyond that a different approach
to remove recursive read/write locks and replace with using r
Now that nwfilters object list is self locking, it's no longer
necessary to hold the driver level lock for certain API's.
However, for the DefineXML, Undefine, and Reload processing keeping
that lock ensures for serialization required in order to process
the filter Instantiation properly.
Signed-
Implement the self locking object list for nwfilter object lists
that uses two hash tables to store the nwfilter object by UUID or
by Name.
As part of this alter the uuid argument to virNWFilterObjLookupByUUID
to expect an already formatted uuidstr.
Alter the existing list traversal code to imple
Unlike it's counterparts, the nwfilter object code needs to be able
to support recursive read locks while processing and checking new
filters against the existing environment. Thus instead of using a
virObjectLockable which uses pure mutexes, use the virObjectRWLockable
and primarily use RWLockRead
Commit id '46a811db07' added code to check if the filter by Name
already existed with a different UUID, to go along with the existing
found filter by UUID and compare the Names match thus making it
impossible to reach this find by Name condition without both the
Name and UUID already matching, so r
If libvirtd is restarted, let's be sure to block any odd attempts to
update the nwfilters or allow any sort of callbacks from running guests
until all the objects are populated.
Signed-off-by: John Ferlan
---
src/nwfilter/nwfilter_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
Modify virStoragePoolObjGetAutostartLink and
virStoragePoolObjGetConfigFile to return "const char *"
since that's how both are used and to ensure no one
tries to VIR_FREE the result.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c | 4 ++--
src/conf/virstorageobj.h | 4 ++--
2 files chan
Rather than accessing privconn->pools.objs[i] in the for loop,
let's use an @obj variable to make it easier to read the code.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/src/test/test_d
Since the previous series (19 patches):
https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
didn't garner any attention, let me try with smaller patch piles with the
hope that forward progress will be made.
The only "new" one in this series from the other is patch2 - somethi
In preparation for privatizing the object, use the accessor.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 162 +++--
1 file changed, 91 insertions(+), 71 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index e84acf
In preparation for privatizing the object, use the accessor to fetch
the obj->def instead of the direct reference.
Signed-off-by: John Ferlan
---
src/storage/storage_driver.c | 411 ---
1 file changed, 234 insertions(+), 177 deletions(-)
diff --git a/src/
Make it more obvious as we're about to need to change how
obj->def gets referenced.
Perform a couple of minor cleanups along the way too.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/src/test/te
Signed-off-by: John Ferlan
---
tests/storagevolxml2argvtest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c
index 1b3003216d..73d9c4bc6b 100644
--- a/tests/storagevolxml2argvtest.c
+++ b/tests/storagevolxml2ar
On 10/05/2017 10:00 AM, Wim Ten Have wrote:
From: Wim ten Have
Generating libvirt packages per make rpm, "with_libxl=1" and "with_xen=1",
adds strict runtime dependencies per libxenlight for xen-libs package from
core libvirt-libs package. This is not necessary and unfortunate since
those depe
On Thu, Oct 05, 2017 at 02:54:36PM +0200, Erik Skultety wrote:
> [...]
> > > +while (1) {
> > > +virMutexLock(&privateData->lock);
> > > +while (privateData->nevents == 0 && !privateData->threadQuit) {
> > > +if (virCondWait(&privateData->threadCond,
> > > &privateD
From: Wim ten Have
Generating libvirt packages per make rpm, "with_libxl=1" and "with_xen=1",
adds strict runtime dependencies per libxenlight for xen-libs package from
core libvirt-libs package. This is not necessary and unfortunate since
those dependencies set demand to "xen-libs" package even
The command tries to match interface in domain definition by MAC
address or interface name. However, since it's possible to
configure two interfaces with the same MAC address, it may
happen that the XPath returns two or more nodes. We should check
for that.
Signed-off-by: Michal Privoznik
---
to
https://bugzilla.redhat.com/show_bug.cgi?id=1497396
The current implementation reads the stats from the host.
However, this doesn't work for all types of interfaces as not all
of them have a representation in the host. For instance,
interface type='user' doesn't.
Signed-off-by: Michal Privoznik
On 09/26/2017 07:05 AM, Ján Tomko wrote:
> Somewhere around commit 9ff9d9f reserving entire PCI slots was
> eliminated, as demonstrated by commit 6cc2014.
>
> Reserve the functions required by the implicit devices:
> 00:01.0 ISA Bridge
> 00:01.1 IDE Controller
> 00:01.2 USB Controller (unless US
On 10/05/2017 09:13 AM, Michal Privoznik wrote:
> In 361c8dc17 and 662140fa68ae0 I've implemented hot-(un)plug of
> watchdog devices. Document this change.
>
> Signed-off-by: Michal Privoznik
> ---
> docs/news.xml | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/news.xml b/d
On 09/26/2017 07:05 AM, Ján Tomko wrote:
> The address is restricted to 0:0:1.2 only for the piix3-uhci controller
> with index 0.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1460602
> ---
> src/qemu/qemu_domain_address.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
*** BLURB HERE ***
Michal Privoznik (4):
virsh: Document limitation of domifstat
virDomainInterfaceStats: Accept MAC address too
virsh: Deal with multiple matching devices in domif-getlink
virDomainNetFind: Report error if no device found
include/libvirt/libvirt-domain.h | 2 +-
src/con
Every caller reports the error themselves. Might as well move it
into the function and thus unify it.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 18 ++
src/libxl/libxl_driver.c | 5 +
src/lxc/lxc_driver.c | 5 +
src/openvz/openvz_driver.c |
https://bugzilla.redhat.com/show_bug.cgi?id=1497396
The other APIs accept both, ifname and MAC address. There's no
reason virDomainInterfaceStats can't do the same.
Signed-off-by: Michal Privoznik
---
include/libvirt/libvirt-domain.h | 2 +-
src/driver-hypervisor.h | 2 +-
src/libvir
On 10/05/2017 08:06 AM, Peter Krempa wrote:
> V2:
>
> Patches 1/4 and 3/4 are new. Patch 2/4 and 4/4 were fixed to use
> virTristateBool.
>
> Peter Krempa (4):
> util: Add functions to simplify bool->virTristate(Bool|Switch)
> assignment
> qemu: domain: Mark if no blockjobs are active i
Rather than placing/using privateData about secinfo in the hostdev,
let's use the virStorageSource (e.g. disksrc) instead.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 5 ++---
src/qemu/qemu_domain.c | 21 +
2 files changed, 15 insertions(+), 11 deletions(-)
di
Rather than picking apart the two pieces we need/want (path, hosts,
and auth)- let's just use the new virDomainDiskStorageSourceNew API
in order to allocate and use a virStorageSourcePtr.
The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need
to "fake" one for the qemuBuildNetworkDriv
Since the virStorageEncryptionPtr encryption; is a member of
_virStorageSource it really should be allowed to be a subelement
of the disk for various disk formats:
Source{File|Dir|Block|Volume}
SourceProtocol{RBD|ISCSI|NBD|Gluster|Simple|HTTP}
NB: Simple includes sheepdog, ftp, ftps, tftp
Relocate into disk source private (qemuDomainDiskSrcPrivatePtr)
Since the secret information is really _virStorageSource specific
piece of data, let's manage the privateData from there instead of
at the Disk level.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 6 --
src/qemu/qem
Introduce the bare necessities to add privateData to _virStorageSource.
Subsequent patches will fill in more details.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.h| 1 +
src/qemu/qemu_domain.c| 43 +++
src/qemu/qemu_domain.h| 13 ++
Since the virStorageAuthDefPtr auth; is a member of _virStorageSource
it really should be allowed to be a subelement of the disk
for the RBD and iSCSI prototcols. That way we can set up to allow
the element to be formatted within the disk source.
Since we've allowed the to be a child of , we'll
In 361c8dc17 and 662140fa68ae0 I've implemented hot-(un)plug of
watchdog devices. Document this change.
Signed-off-by: Michal Privoznik
---
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4e8d7c940..3a01bd491 100644
--- a/docs/news.xml
+
Signed-off-by: John Ferlan
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 09cd1cd340..b5f7e11b4f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -63,6 +63,16 @@
way.
+
+
+
Since the encryption information can also be disk source specific
move it from _qemuDomainDiskPrivate to _qemuDomainDiskSrcPrivate.
Since the last allocated element from _qemuDomainDiskPrivate is
removed, that means we no longer need qemuDomainDiskPrivateDispose.
Signed-off-by: John Ferlan
---
Add the capability to use the blockdev-add query-qmp-schema option
to find the 'password-secret' parameter that will allow the iSCSI
code to use the master secret object to encrypt the secret for an
and only need to provide the object id of the secret on the command
line thus obsfuscating the passp
v4: https://www.redhat.com/archives/libvir-list/2017-September/msg00944.html
Changes since v4 are minor - mostly to change from 3.8.0 to 3.9.0... Update
the news.xml once is allowed for . Add a news.xml to describe
the bug fix. Beyond that - merge changes up to git commit '5d7659027'.
I ran the
Create a qemu* specific StorageSourceCopy helper because we need
to be able to copy the PrivateData too if it exists without adding
any knowledge to the virStorageSourceCopy function.
Signed-off-by: John Ferlan
---
src/qemu/qemu_blockjob.c | 2 +-
src/qemu/qemu_domain.c | 62 +
Rather than building the "file" string in qemuBuildSCSIHostdevDrvStr
build it in the called helper.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 21f02
https://bugzilla.redhat.com/show_bug.cgi?id=1425757
The blockdev-add code provides a mechanism to sanely provide user
and password-secret arguments for iscsi without placing them on the
command line to be viewable by a 'ps -ef' type command or needing
to create separate -iscsi devices for each dis
Since it's not longer used to shuttle the @secinfo, let's remove
the private hostdev completely.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c| 12 ++-
src/conf/domain_conf.h| 4 +---
src/lxc/lxc_native.c | 2 +-
src/qemu/qemu_domain.c| 50 +++--
Signed-off-by: John Ferlan
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4e8d7c940a..09cd1cd340 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,19 @@
+
+
+ conf: Move th
When commit id 'da86c6c22' added support for diskPriv->encinfo in
qemuDomainSecretDiskPrepare a change to qemuDomainSecretDiskDestroy
to was missed. Although qemuDomainDiskPrivateDispose probably would
do the trick.
Signed-off-by: John Ferlan
---
src/qemu/qemu_domain.c | 7 ---
1 file change
Add helper to manage the virStorageSourcePtr allocation for disk->src,
disk->mirror, and disk->src->backingStore.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.
[...]
> > +while (1) {
> > +virMutexLock(&privateData->lock);
> > +while (privateData->nevents == 0 && !privateData->threadQuit) {
> > +if (virCondWait(&privateData->threadCond, &privateData->lock))
> > {
> > +virReportSystemError(errno, "%s",
> > +
On Thu, Oct 05, 2017 at 01:31:02PM +0200, Michal Privoznik wrote:
> On 10/05/2017 01:01 PM, Pavel Hrdina wrote:
> > On Thu, Oct 05, 2017 at 10:40:01AM +0100, Daniel P. Berrange wrote:
> >> On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
> >>> On Thu, Oct 05, 2017 at 10:44:29AM +0
On Thu, Oct 05, 2017 at 01:26:54PM +0200, Peter Krempa wrote:
> On Thu, Oct 05, 2017 at 10:40:01 +0100, Daniel Berrange wrote:
> > On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
> > > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> > > > On 10/05/2017 10:10 A
On 10/05/2017 01:48 PM, John Ferlan wrote:
>
>
> On 10/05/2017 04:07 AM, Michal Privoznik wrote:
>> On 10/04/2017 11:20 PM, John Ferlan wrote:
>>>
>>>
>>> On 09/27/2017 08:12 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1447169
Since domain can have at mo
Add a helper variable so that we don't have to access the disk via 3
indirections.
---
src/qemu/qemu_process.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index f29228bc1..4353ad5ec 100644
--- a/src/qemu/qemu_process
On Thu, Oct 05, 2017 at 10:46:24 +0200, Marc Hartmayer wrote:
> Let's assume we've a z13 system with a QEMU 2.9 and we define a domain
> using the default s390-virtio-ccw machine together with the host-model
> CPU mode. The definition will have the machine expanded to
> s390-virtio-ccw-2.9 but reta
virTristateBoolFromBool and virTristateSwitchFromBool convert a boolean
to the correct enum value.
---
src/libvirt_private.syms | 2 ++
src/util/virutil.c | 20
src/util/virutil.h | 3 +++
3 files changed, 25 insertions(+)
diff --git a/src/libvirt_private.syms b
V2:
Patches 1/4 and 3/4 are new. Patch 2/4 and 4/4 were fixed to use
virTristateBool.
Peter Krempa (4):
util: Add functions to simplify bool->virTristate(Bool|Switch)
assignment
qemu: domain: Mark if no blockjobs are active in the status XML
qemu: process: Simplify acces to individual d
Skip purging the backing chain and redetecting it when it was not going
to change during the time we were not present.
The decision is based on the new flag which records whether there were
blockjobs running to the status XML.
---
src/qemu/qemu_process.c | 16 ++--
1 file changed, 10
Note when no blockjobs are running in the status XML so that we know
that the backing chain will not change until we reconnect.
---
src/qemu/qemu_domain.c | 38 ++
src/qemu/qemu_domain.h | 3 +++
tests/qemuxml2xmltest.c | 44 ++
On Wed, Oct 04, 2017 at 16:24:52 -0400, John Ferlan wrote:
>
>
> On 10/04/2017 07:59 AM, Peter Krempa wrote:
> > Note when no blockjobs are running in the status XML so that we know
> > that the backing chain will not change until we reconnect.
> > ---
> > src/qemu/qemu_domain.c | 39 ++
On 10/05/2017 01:01 PM, Pavel Hrdina wrote:
> On Thu, Oct 05, 2017 at 10:40:01AM +0100, Daniel P. Berrange wrote:
>> On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
>>> On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
On 10/05/2017 10:10 AM, Daniel P. Berran
On Thu, Oct 05, 2017 at 10:40:01 +0100, Daniel Berrange wrote:
> On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
> > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> > > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> > > > On Wed, Oct 04, 2017 at 08:31:36A
On 10/05/2017 04:07 AM, Michal Privoznik wrote:
> On 10/04/2017 11:20 PM, John Ferlan wrote:
>>
>>
>> On 09/27/2017 08:12 AM, Michal Privoznik wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
>>>
>>> Since domain can have at most one watchdog it simplifies things a
>>> bit. However,
The majority of the syntax check is taylored for C sources, so some of
the checks already cause false positives for non-C sources (and thus
there are exclusion regexps in place).
Instead, just exclude more non-C files from all the checks:
- pot files: they are templates for po files (already exclu
On Thu, Oct 05, 2017 at 10:40:01AM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
> > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> > > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> > > > On Wed, Oct 04, 2017 at 08:3
On Thu, Oct 05, 2017 at 11:28:35AM +0200, Michal Privoznik wrote:
> On 10/05/2017 11:13 AM, Daniel P. Berrange wrote:
> > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> >> On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> >>> On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin K
On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote:
> On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> > > On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
> > > > On Tue, Oct 03, 2017 at 03:10
On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote:
On Tue, Oct 03, 2017 at 04:03:20PM +0200, M
On 10/05/2017 11:13 AM, Daniel P. Berrange wrote:
> On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
>> On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
>>> On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P.
On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote:
> On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> > On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
> >> On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote:
> >>> On Tue, Oct 03, 2017 at 04:03:2
Let's assume we've a z13 system with a QEMU 2.9 and we define a domain
using the default s390-virtio-ccw machine together with the host-model
CPU mode. The definition will have the machine expanded to
s390-virtio-ccw-2.9 but retain the host-model CPU mode. In a next step
we upgrade to QEMU 2.10 (fi
On 10/05/2017 10:10 AM, Daniel P. Berrange wrote:
> On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
>> On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote:
>>> On Tue, Oct 03, 2017 at 04:03:20PM +0200, Martin Kletzander wrote:
On Tue, Oct 03, 2017 at 02:53:46P
On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote:
> On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote:
> > On Tue, Oct 03, 2017 at 04:03:20PM +0200, Martin Kletzander wrote:
> > > On Tue, Oct 03, 2017 at 02:53:46PM +0100, Daniel P. Berrange wrote:
> > > > On Tue, O
On 10/05/2017 09:55 AM, Peter Krempa wrote:
> On Thu, Oct 05, 2017 at 09:31:25 +0200, Michal Privoznik wrote:
>> In cea3715b2e9 and d86fd2402e9d2 I've fixed domifstat and QoS
>> that was reversed for some types of interfaces. Document this
>> in the news file.
>>
>> Signed-off-by: Michal Privoznik
On 10/04/2017 11:20 PM, John Ferlan wrote:
>
>
> On 09/27/2017 08:12 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
>>
>> Since domain can have at most one watchdog it simplifies things a
>> bit. However, since we must be able to set the watchdog action as
>> w
Michal Privoznik [2017-09-21, 04:47PM +0200]:
> In the near future the qemuAssignDeviceAliases() function is
> going to be called multiple times: once at the domain define
> time, then in domain prepare phase. To avoid regenerating the
> same aliases the second time we need to be able to tell the
On Wed, Oct 04, 2017 at 18:21:24 +0200, Peter Krempa wrote:
> On Wed, Oct 04, 2017 at 12:09:04 -0400, John Ferlan wrote:
> >
> >
> > On 10/04/2017 07:42 AM, Peter Krempa wrote:
> > > Checking of disk presence accesses storage on the host so it should be
> > > done from the host setup function. Mo
On Thu, Oct 05, 2017 at 09:31:25 +0200, Michal Privoznik wrote:
> In cea3715b2e9 and d86fd2402e9d2 I've fixed domifstat and QoS
> that was reversed for some types of interfaces. Document this
> in the news file.
>
> Signed-off-by: Michal Privoznik
> ---
> docs/news.xml | 11 +++
> 1 file
On Wed, Oct 04, 2017 at 10:55:58 -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1475250
>
> It's possible to define and start a pool with a '.' in the
> name; however, when trying to add a volume to a domain using
> the storage pool source with a '.' in the storage pool na
On Thu, Oct 05, 2017 at 09:20:15 +0200, Jiri Denemark wrote:
Any explanation? :)
> Signed-off-by: Jiri Denemark
> ---
> libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 48f193f0c4..e053f05f1c 100644
> --- a/libvi
On Wed, Oct 04, 2017 at 12:06:28 -0400, John Ferlan wrote:
>
>
> On 10/04/2017 07:42 AM, Peter Krempa wrote:
> > Introduce a new function to prepare domain disks which will also do the
> > volume source to actual disk source translation.
> > ---
> > src/qemu/qemu_domain.c | 10 +-
> > s
On Wed, Oct 04, 2017 at 11:59:07 -0400, John Ferlan wrote:
>
>
> On 10/04/2017 07:42 AM, Peter Krempa wrote:
> > Pass flags to the function rather than just whether we have incoming
> > migration. This also enforces correct startup policy for USB devices
> > when reverting from a snapshot.
> > --
In cea3715b2e9 and d86fd2402e9d2 I've fixed domifstat and QoS
that was reversed for some types of interfaces. Document this
in the news file.
Signed-off-by: Michal Privoznik
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 72e
On 10/05/2017 12:49 AM, John Ferlan wrote:
>
>
> On 10/02/2017 11:05 AM, Michal Privoznik wrote:
>> Interestingly enough, we don't document the point of view of the
>> interface statistics. Therefore it's unknown to users if for
>> instance rx_packets is the number of packets received by domain o
On 10/05/2017 12:38 AM, John Ferlan wrote:
>
>
> On 10/02/2017 11:05 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1497410
>>
>> The comment in virNetDevTapInterfaceStats() implementation for
>> Linux states that packets transmitted by domain are received by
>> the ho
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 48f193f0c4..e053f05f1c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -35,7 +35,7 @@
%define with_qemu_tcg 0
%define qemu_k
On 10/02/2017 05:05 PM, Michal Privoznik wrote:
> This is initiated by:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1497410
>
> Long story short, in some cases host and domain are on the same side of RX/TX
> stats/QoS.
>
> Michal Privoznik (7):
> lxc: Drop useless ifdef __linux__
> qemuD
clang doesn't like mode_t type as an argument to va_arg():
error: second argument to 'va_arg' is of promotable type 'mode_t' (aka
'unsigned short'); this va_arg has undefined behavior because arguments
will be promoted to 'int'
mode = va_arg(ap, mode_t);
^~
Signed-o
82 matches
Mail list logo
