Re: [libvirt] [PATCH] virDomainInterfaceStats: Accept MAC addresses properly

2017-10-13 Thread Michal Privoznik
On 10/13/2017 05:44 PM, John Ferlan wrote: > > > On 10/13/2017 07:32 PM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1497396 >> >> In 0d3d020ba6c4f I've added capability to accept MAC addresses >> for the API too. However, the implementation was faulty. It needs >> to l

Re: [libvirt] [PATCH] virDomainInterfaceStats: Accept MAC addresses properly

2017-10-13 Thread John Ferlan
On 10/13/2017 07:32 PM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1497396 > > In 0d3d020ba6c4f I've added capability to accept MAC addresses > for the API too. However, the implementation was faulty. It needs > to lookup the corresponding interface in the domain defin

Re: [libvirt] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

2017-10-13 Thread Eduardo Habkost
On Fri, Oct 13, 2017 at 04:58:23PM -0400, Waiman Long wrote: > On 10/13/2017 03:01 PM, Eduardo Habkost wrote: > > On Wed, Oct 11, 2017 at 04:19:38PM -0400, Waiman Long wrote: > >> On 10/10/2017 03:41 PM, Eduardo Habkost wrote: > >>> On Tue, Oct 10, 2017 at 02:07:25PM -0400, Waiman Long wrote: > >>>

[libvirt] [PATCH] virDomainInterfaceStats: Accept MAC addresses properly

2017-10-13 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1497396 In 0d3d020ba6c4f I've added capability to accept MAC addresses for the API too. However, the implementation was faulty. It needs to lookup the corresponding interface in the domain definition and pass the ifname instead of MAC address. Signed-of

Re: [libvirt] [PATCH] nodedev: Fix missing network devices

2017-10-13 Thread Michal Privoznik
On 10/10/2017 06:30 AM, John Ferlan wrote: > Commit id '8708ca01c' added a check to determine whether the NIC had > Switchdev capabilities; however, in doing so inadvertently would cause > network devices without a PCI device to not be added to the node device > database. Thus, network devices havi

Re: [libvirt] [PATCH 2/4] virDomainInterfaceStats: Accept MAC address too

2017-10-13 Thread Michal Privoznik
On 10/13/2017 10:45 AM, John Ferlan wrote: > > > On 10/05/2017 10:18 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1497396 >> >> The other APIs accept both, ifname and MAC address. There's no >> reason virDomainInterfaceStats can't do the same. >> >> Signed-off-by: Mi

Re: [libvirt] [PATCH 0/4] virDomainInterfaceStats: Accept MAC address too

2017-10-13 Thread Michal Privoznik
On 10/05/2017 07:18 AM, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Privoznik (4): > virsh: Document limitation of domifstat > virDomainInterfaceStats: Accept MAC address too > virsh: Deal with multiple matching devices in domif-getlink > virDomainNetFind: Report error if no de

Re: [libvirt] [PATCH v2 00/22] Fix host-model if the chosen CPU model has more features in QEMU compared to our cpu_map.xml

2017-10-13 Thread John Ferlan
On 10/13/2017 02:14 PM, Jiri Denemark wrote: > When decoding CPUID data to virCPUDef we need to be careful about using > a CPU model which cannot be directly used on the current host. Normally, > libvirt would notice the features which prevent the model from being > usable and it would disable th

Re: [libvirt] [PATCH v2 07/22] conf: Introduce virDomainCapsCPUModelsGet

2017-10-13 Thread John Ferlan
On 10/13/2017 02:14 PM, Jiri Denemark wrote: > This internal API can be used to find a specific CPU model in > virDomainCapsCPUModels list. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch which replaces the original 07/23 > (cpu: Return model from vir

Re: [libvirt] [PATCH 1/4] virsh: Document limitation of domifstat

2017-10-13 Thread Michal Privoznik
On 10/13/2017 10:44 AM, John Ferlan wrote: > > > On 10/05/2017 10:18 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1497396 >> >> The current implementation reads the stats from the host. >> However, this doesn't work for all types of interfaces as not all >> of them h

Re: [libvirt] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

2017-10-13 Thread Waiman Long
On 10/13/2017 03:01 PM, Eduardo Habkost wrote: > On Wed, Oct 11, 2017 at 04:19:38PM -0400, Waiman Long wrote: >> On 10/10/2017 03:41 PM, Eduardo Habkost wrote: >>> On Tue, Oct 10, 2017 at 02:07:25PM -0400, Waiman Long wrote: On 10/10/2017 11:50 AM, Eduardo Habkost wrote: >> Yes. Another p

Re: [libvirt] [PATCH v2 01/22] util: Introduce virStringListCopy

2017-10-13 Thread John Ferlan
On 10/13/2017 03:07 PM, Jiri Denemark wrote: > On Fri, Oct 13, 2017 at 20:14:33 +0200, Jiri Denemark wrote: >> diff --git a/src/util/virstring.c b/src/util/virstring.c >> index 0288d1e677..820b282ac5 100644 >> --- a/src/util/virstring.c >> +++ b/src/util/virstring.c >> @@ -239,6 +239,43 @@ virStr

Re: [libvirt] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Laszlo Ersek
On 10/13/17 18:18, Peter Maydell wrote: > On 13 October 2017 at 13:51, Laszlo Ersek wrote: >> Another idea is to move *the* system DRAM base to a different guest-phys >> address. (Likely using a different version of the "virt" machine type, >> or even a different machine type entirely.) This would

Re: [libvirt] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Laszlo Ersek
On 10/13/17 15:21, Ard Biesheuvel wrote: > On 13 October 2017 at 13:51, Laszlo Ersek wrote: >> Hi Ard, Leif, >> >> the current physical memory map of the "virt" machine type doesn't leave >> much room for ECAM / MMCONFIG, which limits the number of PCI Express >> root ports and downstream ports (e

Re: [libvirt] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

2017-10-13 Thread Eduardo Habkost
On Wed, Oct 11, 2017 at 04:19:38PM -0400, Waiman Long wrote: > On 10/10/2017 03:41 PM, Eduardo Habkost wrote: > > On Tue, Oct 10, 2017 at 02:07:25PM -0400, Waiman Long wrote: > >> On 10/10/2017 11:50 AM, Eduardo Habkost wrote: > Yes. Another possibility is to enable it when there is >1 NUMA n

Re: [libvirt] [PATCH v2 01/22] util: Introduce virStringListCopy

2017-10-13 Thread Jiri Denemark
On Fri, Oct 13, 2017 at 20:14:33 +0200, Jiri Denemark wrote: > diff --git a/src/util/virstring.c b/src/util/virstring.c > index 0288d1e677..820b282ac5 100644 > --- a/src/util/virstring.c > +++ b/src/util/virstring.c > @@ -239,6 +239,43 @@ virStringListRemove(char ***strings, > } > > > +/** > +

Re: [libvirt] [PATCH 07/23] cpu: Return model from virCPUModelIsAllowed

2017-10-13 Thread Jiri Denemark
On Fri, Oct 13, 2017 at 14:45:05 -0400, John Ferlan wrote: > >> In any case, the 'ModelIsAllowed" now feels overloaded returning more > >> than just true/false that a typical "Is" type function would return. > >> Sorry, I don't have suggestions, so unless someone else is looking and > >> has a bett

Re: [libvirt] [PATCH 01/23] util: Introduce virStringListCopy

2017-10-13 Thread Jiri Denemark
On Fri, Oct 13, 2017 at 14:14:37 -0400, John Ferlan wrote: > > > On 10/13/2017 09:27 AM, Jiri Denemark wrote: > > On Thu, Oct 12, 2017 at 07:22:51 -0400, John Ferlan wrote: > >> > >> > >> On 10/04/2017 10:58 AM, Jiri Denemark wrote: > >>> The API makes a deep copy of a NULL-terminated string list

Re: [libvirt] [PATCH 14/23] cputest: Separate QEMUCaps creation from cpuTestCPUIDJson

2017-10-13 Thread John Ferlan
On 10/13/2017 01:27 PM, Jiri Denemark wrote: > On Thu, Oct 12, 2017 at 17:20:06 -0400, John Ferlan wrote: >> >> >> On 10/04/2017 10:58 AM, Jiri Denemark wrote: >>> To make the code reusable by other tests. >>> >>> Signed-off-by: Jiri Denemark >>> --- >>> tests/cputest.c | 97 >>> ++

Re: [libvirt] [PATCH 07/23] cpu: Return model from virCPUModelIsAllowed

2017-10-13 Thread John Ferlan
On 10/13/2017 11:31 AM, Jiri Denemark wrote: > On Thu, Oct 12, 2017 at 15:50:29 -0400, John Ferlan wrote: >> >> >> On 10/04/2017 10:58 AM, Jiri Denemark wrote: >>> If a given CPU model is supported by the hypervisor, we want to know >>> more about it, e.g., what features may block its usage on th

[libvirt] [PATCH v2 06/22] cpu: Drop unused parameter from cpuDecode

2017-10-13 Thread Jiri Denemark
The "preferred" parameter is not used by any caller of cpuDecode anymore. It's only used internally in cpu_x86 to implement cpuBaseline. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change src/cpu/cpu.c | 15 --- src/cpu

[libvirt] [PATCH v2 05/22] cpu: Use virDomainCapsCPUModelsPtr in cpu driver APIs

2017-10-13 Thread Jiri Denemark
All APIs which expect a list of CPU models supported by hypervisors were switched from char **models and int models to just accept a pointer to virDomainCapsCPUModels object stored in domain capabilities. This avoids the need to transform virDomainCapsCPUModelsPtr into a NULL-terminated list of mod

[libvirt] [PATCH v2 08/22] cpu_x86: Move x86FeatureFind* to avoid forward prototypes

2017-10-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change src/cpu/cpu_x86.c | 61 --- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 84ec878d1b

[libvirt] [PATCH v2 03/22] qemu: Store CPU usability blockers in caps cache

2017-10-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - modified error message src/qemu/qemu_capabilities.c | 51 ++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qe

[libvirt] [PATCH v2 22/22] cputest: Make a crippled version of Core-i7-2600

2017-10-13 Thread Jiri Denemark
xsaveopt is artificially removed from the host to test disabled feature which is only included in QEMU's version of the CPU model. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputest.c| 1 + ...x86

Re: [libvirt] [PATCH 01/23] util: Introduce virStringListCopy

2017-10-13 Thread John Ferlan
On 10/13/2017 09:27 AM, Jiri Denemark wrote: > On Thu, Oct 12, 2017 at 07:22:51 -0400, John Ferlan wrote: >> >> >> On 10/04/2017 10:58 AM, Jiri Denemark wrote: >>> The API makes a deep copy of a NULL-terminated string list. >>> >>> Signed-off-by: Jiri Denemark >>> --- >>> src/util/virstring.c |

[libvirt] [PATCH v2 15/22] cputest: Use CPU models from QEMU when available

2017-10-13 Thread Jiri Denemark
When testing cpuDecode for computing guest CPU definition from CPUID data (the CPU definition reported by domain capabilities), we need to use CPU models (and their usability blockers) from QEMU if they are available to cpuDecode in the same way it is actually used in the qemu driver. Signed-off-b

Re: [libvirt] [PATCH 04/23] qemu: Parse unavailable features for CPU models

2017-10-13 Thread John Ferlan
On 10/13/2017 10:39 AM, Jiri Denemark wrote: > On Thu, Oct 12, 2017 at 07:25:59 -0400, John Ferlan wrote: >> >> >> On 10/04/2017 10:58 AM, Jiri Denemark wrote: >>> query-cpu-definitions QMP command returns a list of unavailable features >>> which prevent CPU models from being usable on the curren

[libvirt] [PATCH v2 12/22] cputest: Print correct feature in virCPUUpdateLive test

2017-10-13 Thread Jiri Denemark
If the actual result does not match our expectation, the tests would not correctly show the difference if a CPU feature is disabled in the expected result and the actual result does not mention it at all. The test could complain about an unrelated CPU feature or it could even crash in case the actu

[libvirt] [PATCH v2 14/22] cputest: Separate QEMUCaps creation from cpuTestCPUIDJson

2017-10-13 Thread Jiri Denemark
To make the code reusable by other tests. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputest.c | 97 +++-- 1 file changed, 60 insertions(+), 37 deletions(-) diff --git a/tests/cpute

[libvirt] [PATCH v2 11/22] cputest: Avoid calling json_reformat in cpu-parse.sh

2017-10-13 Thread Jiri Denemark
Various version of json_reformat use different number of spaces for indenting. Let's use a simple python reformatter to gain full control over the formatting for consistent results. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputestda

[libvirt] [PATCH v2 17/22] cputest: Add CPUID data for Intel(R) Xeon(R) CPU E7-4830

2017-10-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputest.c| 1 + .../x86_64-cpuid-Xeon-E7-4830-disabled.xml | 5 + .../x86_64-cpuid-Xeon-E7-4830-enabled.xml | 8 + .../x86_64-cpuid-X

[libvirt] [PATCH v2 20/22] cputest: Add query-cpu-definitions reply for Xeon-E3-1245

2017-10-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputest.c | 2 +- tests/cputestdata/x86_64-cpuid-Xeon-E3-1245.json | 299 +++ 2 files changed, 300 insertions(+), 1 deletion(-) diff --g

[libvirt] [PATCH v2 04/22] qemu: Parse unavailable features for CPU models

2017-10-13 Thread Jiri Denemark
query-cpu-definitions QMP command returns a list of unavailable features which prevent CPU models from being usable on the current host. So far we only checked whether the list was empty to mark CPU models as (un)usable. This patch parses all unavailable features for each CPU model and stores them

[libvirt] [PATCH v2 21/22] cputest: Update Core-i7-2600 data

2017-10-13 Thread Jiri Denemark
arat is now enabled even if the hardware does not support it. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change .../x86_64-cpuid-Core-i7-2600-disabled.xml | 1 - .../x86_64-cpuid-Core-i7-2600-enabled.xml | 1 + .../cputestdata

[libvirt] [PATCH v2 13/22] cputest: Test CPU usability blockers

2017-10-13 Thread Jiri Denemark
Gather query-cpu-definitions results and use them for testing CPU model usability blockers in CPUID to virCPUDef translation. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change src/qemu/qemu_capabilities.c| 2 +- src/qemu/qemu_capspriv.h

[libvirt] [PATCH v2 10/22] cputest: Replace bool with cpuTestCPUIDJson enum

2017-10-13 Thread Jiri Denemark
We will soon need to handle more than two values. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - changed commit summary tests/cputest.c | 79 ++--- 1 file changed, 42 insertions(+), 37 deletions(-) dif

[libvirt] [PATCH v2 02/22] conf: Add usability blockers to virDomainCapsCPUModel

2017-10-13 Thread Jiri Denemark
When a hypervisor marks a CPU model as unusable on the current host, it may also give us a list of features which prevent the model from being usable. Storing this list in virDomainCapsCPUModel will help the CPU driver with creating a host-model CPU configuration. Signed-off-by: Jiri Denemark Rev

[libvirt] [PATCH v2 07/22] conf: Introduce virDomainCapsCPUModelsGet

2017-10-13 Thread Jiri Denemark
This internal API can be used to find a specific CPU model in virDomainCapsCPUModels list. Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch which replaces the original 07/23 (cpu: Return model from virCPUModelIsAllowed) src/conf/domain_capabilities.c | 18 ++

[libvirt] [PATCH v2 19/22] cputest: Update Xeon-E3-1245 data

2017-10-13 Thread Jiri Denemark
xsaves is supported by current QEMU/KVM on this CPU. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change .../x86_64-cpuid-Xeon-E3-1245-disabled.xml | 1 - .../x86_64-cpuid-Xeon-E3-1245-enabled.xml | 2 +- .../cputestdata/x86_64-

[libvirt] [PATCH v2 09/22] cpu_x86: Disable blockers from unusable CPU models

2017-10-13 Thread Jiri Denemark
When decoding CPUID data to virCPUDef we need to be careful about using a CPU model which cannot be directly used on the current host. Normally, libvirt would notice the features which prevent the model from being usable and it would disable them in the computed virCPUDef, but this won't work in ca

[libvirt] [PATCH v2 16/22] cputest: Add query-cpu-definitions reply for Core-i5-2540M

2017-10-13 Thread Jiri Denemark
The unavailable features do not make any difference in this case, because this is a SandyBridge CPU which has an empty list of unavailable features. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change tests/cputest.c

[libvirt] [PATCH v2 18/22] cputest: Add query-cpu-definitions reply for Xeon-E7-4830

2017-10-13 Thread Jiri Denemark
This CPU was incorrectly detected as SandyBridge before because the number of additional elements was the same for both SandyBridge and Westmere CPU models, but SandyBridge is newer (the CPU signature does not help here because it doesn't match any signature defined in cpu_map.xml). But since QEMU

[libvirt] [PATCH v2 00/22] Fix host-model if the chosen CPU model has more features in QEMU compared to our cpu_map.xml

2017-10-13 Thread Jiri Denemark
When decoding CPUID data to virCPUDef we need to be careful about using a CPU model which cannot be directly used on the current host. Normally, libvirt would notice the features which prevent the model from being usable and it would disable them in the computed virCPUDef, but this won't work in ca

[libvirt] [PATCH v2 01/22] util: Introduce virStringListCopy

2017-10-13 Thread Jiri Denemark
The API makes a deep copy of a NULL-terminated string list. Signed-off-by: Jiri Denemark Reviewed-by: John Ferlan --- Notes: Version 2: - no change src/util/virstring.c | 37 + src/util/virstring.h | 3 +++ 2 files changed, 40 insertions(+) diff -

Re: [libvirt] [PATCH 20/23] cputest: Update Xeon-E3-1245 data

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 18:22:54 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > xsaves is supported by current QEMU/KVM on this CPU. > > Current as of when? Good question. The QEMU version (unknown) used to generate the original test data did not enable xsaves

Re: [libvirt] [PATCH 22/23] cputest: Update Core-i7-2600 data

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 18:22:42 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > arat is now enabled even if the hardware does not support it. > > > > Signed-off-by: Jiri Denemark > > --- > > .../x86_64-cpuid-Core-i7-2600-disabled.xml | 1 - > > .../x

Re: [libvirt] [PATCH] Use https:// links for most sites

2017-10-13 Thread Eric Blake
On 10/13/2017 10:32 AM, Daniel P. Berrange wrote: > This adds a rule to require https links for the libvirt, qemu > and kvm websites. > > Signed-off-by: Daniel P. Berrange > --- > +++ b/cfg.mk > @@ -1020,6 +1020,26 @@ sc_prohibit_obj_free_apis_in_virsh: > halt='avoid using virDomain(Snapsh

Re: [libvirt] [PATCH 4/4] virDomainNetFind: Report error if no device found

2017-10-13 Thread John Ferlan
On 10/05/2017 10:18 AM, Michal Privoznik wrote: > Every caller reports the error themselves. Might as well move it > into the function and thus unify it. > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c | 18 ++ > src/libxl/libxl_driver.c | 5 + > s

Re: [libvirt] [PATCH 2/4] virDomainInterfaceStats: Accept MAC address too

2017-10-13 Thread John Ferlan
On 10/05/2017 10:18 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1497396 > > The other APIs accept both, ifname and MAC address. There's no > reason virDomainInterfaceStats can't do the same. > > Signed-off-by: Michal Privoznik > --- > include/libvirt/libvirt-doma

Re: [libvirt] [PATCH 16/23] cputest: Use CPU models from QEMU when available

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 17:21:53 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > When testing cpuDecode for computing guest CPU definition from CPUID > > data (the CPU definition reported by domain capabilities), we need to > > use CPU models (and their usability

Re: [libvirt] [PATCH 3/4] virsh: Deal with multiple matching devices in domif-getlink

2017-10-13 Thread John Ferlan
On 10/05/2017 10:18 AM, Michal Privoznik wrote: > The command tries to match interface in domain definition by MAC > address or interface name. However, since it's possible to > configure two interfaces with the same MAC address, it may > happen that the XPath returns two or more nodes. We should

Re: [libvirt] [PATCH 1/4] virsh: Document limitation of domifstat

2017-10-13 Thread John Ferlan
On 10/05/2017 10:18 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1497396 > > The current implementation reads the stats from the host. > However, this doesn't work for all types of interfaces as not all > of them have a representation in the host. For instance, > int

Re: [libvirt] [PATCH 17/23] cputest: Add query-cpu-definitions reply for Core-i5-2540M

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 17:49:33 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > The unavailable features do not make any difference in this case, > > because this is a SandyBridge CPU which has an empty list of unavailable > > features. ... > > diff --git a/tests

Re: [libvirt] [PATCH 15/23] build: Export virCPUModelIsAllowed private API

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 17:20:18 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/libvirt_private.syms | 1 + > > 1 file changed, 1 insertion(+) > > > > This should either be merged earlier when changing the function

Re: [libvirt] [PATCH 14/23] cputest: Separate QEMUCaps creation from cpuTestCPUIDJson

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 17:20:06 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > To make the code reusable by other tests. > > > > Signed-off-by: Jiri Denemark > > --- > > tests/cputest.c | 97 > > +++-- > >

Re: [libvirt] [PATCH 11/23] cputest: Avoid calling json_reformat in cpu-parse.sh

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 16:18:20 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > Various version of json_reformat use different number of spaces for > > indenting. Let's use a simple python reformatter to gain full control > > over the formatting for consistent re

Re: [libvirt] [Qemu-devel] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Andrew Jones
On Fri, Oct 13, 2017 at 05:18:59PM +0100, Peter Maydell wrote: > On 13 October 2017 at 13:51, Laszlo Ersek wrote: > > Another idea is to move *the* system DRAM base to a different guest-phys > > address. (Likely using a different version of the "virt" machine type, > > or even a different machine

Re: [libvirt] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Peter Maydell
On 13 October 2017 at 13:51, Laszlo Ersek wrote: > Another idea is to move *the* system DRAM base to a different guest-phys > address. (Likely using a different version of the "virt" machine type, > or even a different machine type entirely.) This would not be compatible > with current ArmVirtQemu

Re: [libvirt] [PATCH] Remove obsolete TODO file

2017-10-13 Thread Jiri Denemark
On Fri, Oct 13, 2017 at 16:32:32 +0100, Daniel P. Berrange wrote: > We stopped autogenerating a TODO file from RFE bugs a long time > ago. > > Signed-off-by: Daniel P. Berrange > --- > TODO | 22 -- > 1 file changed, 22 deletions(-) > delete mode 100644 TODO ACK if you also

Re: [libvirt] [PATCH 07/23] cpu: Return model from virCPUModelIsAllowed

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 15:50:29 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > If a given CPU model is supported by the hypervisor, we want to know > > more about it, e.g., what features may block its usage on the current > > host and such details are stored in

[libvirt] [PATCH] Remove obsolete TODO file

2017-10-13 Thread Daniel P. Berrange
We stopped autogenerating a TODO file from RFE bugs a long time ago. Signed-off-by: Daniel P. Berrange --- TODO | 22 -- 1 file changed, 22 deletions(-) delete mode 100644 TODO diff --git a/TODO b/TODO deleted file mode 100644 index 6843a17b35..00 --- a/TODO +++ /de

[libvirt] [PATCH] Use https:// links for most sites

2017-10-13 Thread Daniel P. Berrange
This adds a rule to require https links for the libvirt, qemu and kvm websites. Signed-off-by: Daniel P. Berrange --- cfg.mk| 20 + configure.ac | 2 +- daemon/libvirtd.conf | 2 +- daemon/libvirtd.init.in | 4 +-

Re: [libvirt] [PATCH] Add CII best practices badge

2017-10-13 Thread Daniel P. Berrange
On Fri, Oct 13, 2017 at 04:48:06PM +0200, Martin Kletzander wrote: > On Fri, Oct 13, 2017 at 02:32:03PM +0100, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > README.md | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/README.md b/README.md > > index 5fed0f

Re: [libvirt] [PATCH 05/23] cpu: Use virDomainCapsCPUModelsPtr in cpu driver APIs

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 07:27:22 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > All APIs which expect a list of CPU models supported by hypervisors were > > switched from char **models and int models to just accept a pointer to > > virDomainCapsCPUModels object s

Re: [libvirt] [PATCH] Add CII best practices badge

2017-10-13 Thread Martin Kletzander
On Fri, Oct 13, 2017 at 02:32:03PM +0100, Daniel P. Berrange wrote: Signed-off-by: Daniel P. Berrange --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 5fed0fd874..1271843cb1 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ [![Build Status](https

Re: [libvirt] [PATCH 04/23] qemu: Parse unavailable features for CPU models

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 07:25:59 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > query-cpu-definitions QMP command returns a list of unavailable features > > which prevent CPU models from being usable on the current host. So far > > we only checked whether the lis

Re: [libvirt] [PATCH 02/23] conf: Add usability blockers to virDomainCapsCPUModel

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 07:23:25 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > When a hypervisor marks a CPU model as unusable on the current host, it > > may also give us a list of features which prevent the model from being > > usable. Storing this list in vir

Re: [libvirt] [PATCH 3/9] util: storage: Store backing chain index in virStorageSource

2017-10-13 Thread Eric Blake
On 10/13/2017 12:43 AM, Peter Krempa wrote: > On Thu, Oct 12, 2017 at 14:57:36 -0500, Eric Blake wrote: >> On 10/12/2017 02:07 PM, Peter Krempa wrote: >>> The backing store indexes were not bound to the storage sources in any >>> way. To allow us to bind a given alias to a given storage source we n

Re: [libvirt] [PATCH 03/23] qemu: Store CPU usability blockers in caps cache

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 07:23:41 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_capabilities.c | 51 > > ++-- > > 1 file changed, 49 insertions(+), 2 deletions(-) >

Re: [libvirt] [PATCH 01/23] util: Introduce virStringListCopy

2017-10-13 Thread Jiri Denemark
On Thu, Oct 12, 2017 at 07:22:51 -0400, John Ferlan wrote: > > > On 10/04/2017 10:58 AM, Jiri Denemark wrote: > > The API makes a deep copy of a NULL-terminated string list. > > > > Signed-off-by: Jiri Denemark > > --- > > src/util/virstring.c | 37 + > > sr

[libvirt] [PATCH] Add CII best practices badge

2017-10-13 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 5fed0fd874..1271843cb1 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ [![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/libvir

Re: [libvirt] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Ard Biesheuvel
On 13 October 2017 at 13:51, Laszlo Ersek wrote: > Hi Ard, Leif, > > the current physical memory map of the "virt" machine type doesn't leave > much room for ECAM / MMCONFIG, which limits the number of PCI Express > root ports and downstream ports (each port takes a separate bus number, > and each

[libvirt] dynamic DRAM base for ArmVirtQemu

2017-10-13 Thread Laszlo Ersek
Hi Ard, Leif, the current physical memory map of the "virt" machine type doesn't leave much room for ECAM / MMCONFIG, which limits the number of PCI Express root ports and downstream ports (each port takes a separate bus number, and each bus number eats up a chunk of the ECAM area). Also, each por

[libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-13 Thread John Ferlan
Rather than a forward linked list, let's use the ObjectRWLockable object in order to manage the data. Requires numerous changes from List to Object management similar to many other drivers/vir*obj.c modules Signed-off-by: John Ferlan --- This is the real one - I need more coffee. src/conf/vir

Re: [libvirt] [PATCH v2] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-13 Thread John Ferlan
On 10/13/2017 07:41 AM, John Ferlan wrote: > Rather than a forward linked list, let's use the ObjectRWLockable object > in order to manage the data. > > Requires numerous changes from List to Object management similar to > many other drivers/vir*obj.c modules > > Signed-off-by: John Ferlan > -

[libvirt] [PATCH v2] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-13 Thread John Ferlan
Rather than a forward linked list, let's use the ObjectRWLockable object in order to manage the data. Requires numerous changes from List to Object management similar to many other drivers/vir*obj.c modules Signed-off-by: John Ferlan --- v1: https://www.redhat.com/archives/libvir-list/2017-Oct

Re: [libvirt] [PATCH] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-13 Thread John Ferlan
On 10/09/2017 07:17 PM, John Ferlan wrote: > Rather than a forward linked list, let's use the ObjectRWLockable object > in order to manage the data. > > Requires numerous changes from List to Object management similar to > many other drivers/vir*obj.c modules > > Signed-off-by: John Ferlan > -

Re: [libvirt] 答复: [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-13 Thread Martin Kletzander
On Fri, Oct 13, 2017 at 08:56:30AM +, Caoxinhua wrote: I also want to change priv->libDir name to priv->runDir. But this might relate a lot of file change. Currently priv->libDir only save monitor.sock and master-key.aes. All those file need clear at system reset. So it make sense to change

[libvirt] 答复: [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-13 Thread Caoxinhua
I also want to change priv->libDir name to priv->runDir. But this might relate a lot of file change. Currently priv->libDir only save monitor.sock and master-key.aes. All those file need clear at system reset. So it make sense to change priv->libDir from /var/lib/libvirt/qemu to /var/run/libvirt

Re: [libvirt] [PATCH v5 1/4] numa: describe siblings distances within cells

2017-10-13 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 09:31:54PM +0200, Wim Ten Have wrote: > From: Wim ten Have > > Add support for describing NUMA distances in a domain's > XML description. > > Below is an example of a 4 node setup: > > > > > > > > > >

Re: [libvirt] [PATCH 2/2] network: Introduce virNetworkObjListForEachCb

2017-10-13 Thread Pavel Hrdina
On Thu, Oct 12, 2017 at 09:28:24PM -0400, John Ferlan wrote: > > > On 10/12/2017 08:48 AM, Erik Skultety wrote: > > On Tue, Oct 10, 2017 at 04:20:06PM -0400, John Ferlan wrote: > >> Rather than separate callbacks for the NumOfNetworks, GetNames, and > >> Export functions, let's combine them all i

Re: [libvirt] [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-13 Thread Daniel P. Berrange
On Fri, Oct 13, 2017 at 09:21:45AM +0200, Martin Kletzander wrote: > On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote: > > directory /var/lib alway is Persistence directory, but in redhat system, > > /var/run is memory directory. > > our running domain xml is saved at /var/run/libvirt/qe

Re: [libvirt] [PATCH] virt-host-validate: require fuse for LXC if compiled in

2017-10-13 Thread Cedric Bosdonnat
>>> Guido Günther 10/12/17 6:12 PM >>> Domains fail to start without fuse like error: internal error: guest failed to start: fuse: device not found, try 'modprobe fuse' first Failure in libvirt_lxc startup: no error so check for it too. References: https://ci.debian.net/data/autopkgtest

Re: [libvirt] [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-13 Thread Martin Kletzander
On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote: directory /var/lib alway is Persistence directory, but in redhat system, /var/run is memory directory. our running domain xml is saved at /var/run/libvirt/qemu. so if we cold reset system, the /var/run/libvirt/qemu directory is clear,