Signed-off-by: Andrea Bolognani
---
guests/files/jessie-backports.preferences | 3 +++
guests/files/jessie-backports.sources | 1 +
guests/tasks/base.yml | 20
guests/vars/mappings.yml | 1 -
4 files changed, 24 insertions(+), 1 del
Set it to 1 second instead of the default 10 seconds. This brings
it in line with Linux guests and makes boot faster.
Signed-off-by: Andrea Bolognani
---
guests/tasks/base.yml | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml
On Fri, Oct 20, 2017 at 10:07:27AM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote:
> > On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote:
> > > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote:
> > > > - Original
On Fri, 2017-10-20 at 21:49 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> guests/vars/mappings.yml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
> index cae9d23..828690e 100644
> --- a/guests/vars/mappings.yml
> +++
On Fri, 2017-10-20 at 21:36 +0200, Pavel Hrdina wrote:
> On FreeBSD the sudo command cleans the new environment too much
> and Jenkins is not able to run properly.
>
> Signed-off-by: Pavel Hrdina
> ---
> guests/group_vars/all/main.yml | 2 +-
> guests/host_vars/libvirt-freebsd-10/m
Signed-off-by: Pavel Hrdina
---
guests/vars/mappings.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index cae9d23..828690e 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -118,7 +118,6 @@ mappings:
glusterfs:
On FreeBSD the sudo command cleans the new environment too much
and Jenkins is not able to run properly.
Signed-off-by: Pavel Hrdina
---
guests/group_vars/all/main.yml | 2 +-
guests/host_vars/libvirt-freebsd-10/main.yml | 2 +-
guests/host_vars/libvirt-freebsd-11/main.yml | 2 +-
On 10/20/2017 04:12 PM, Christian Borntraeger wrote:
>
>
> On 10/20/2017 04:06 PM, David Hildenbrand wrote:
>> On 20.10.2017 16:02, Christian Borntraeger wrote:
>>>
>>>
>>> On 10/20/2017 03:51 PM, David Hildenbrand wrote:
>>> [...]
> The problem goes much further.
> A fresh guest with
>
To avoid further confusion - rename the array elements to what they are.
Signed-off-by: John Ferlan
---
Pushing as trivial as noted by:
https://www.redhat.com/archives/libvir-list/2017-October/msg00981.html
src/conf/virinterfaceobj.c | 24
1 file changed, 12 inserti
On 10/20/2017 10:28 AM, Pavel Hrdina wrote:
> On Fri, Oct 20, 2017 at 04:25:13PM +0200, Andrea Bolognani wrote:
>> On Fri, 2017-10-20 at 16:07 +0200, Pavel Hrdina wrote:
>>> Introduced by 6094d6ec7fc9ea3e28c18c880b76858f06a8b129.
>>> Found by running libvirt-perl tests.
>>>
>>> Signed-off-by: Pav
On Fri, 2017-10-20 at 20:40 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> projects/libvirt.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Good stuff :)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@r
Signed-off-by: Pavel Hrdina
---
projects/libvirt.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml
index a70a58c..1b31c1b 100644
--- a/projects/libvirt.yaml
+++ b/projects/libvirt.yaml
@@ -16,16 +16,19 @@
- libvirt-centos-6
FWIW, this patch alone probably makes sense to fix this particular issue.
The question is do we want to have some additional interfaces between
libvirt/qemu
that tell libvirt what CPUs/features are allowed for a specific machine version?
Halil just brough up an example. Imagine to have a QEMU bi
>
> I intend to put some brain-power in this too. Probably next week.
>
> My general impression is, that I have a at places different understanding
> of how things should work compared to David. Especially when it comes
> to this concept of persistent copying, and also an end-user-digestible
> d
Starting a guest with
hvm
on an IBM z14 results in
"qemu-system-s390x: Some features requested in the CPU model are not
available in the configuration: gs"
This is because guarded storage is fenced for compat machines that did not have
guarded storage support, but libvirt expands t
Signed-off-by: Michal Privoznik
---
docs/formatdomain.html.in | 23 +++
1 file changed, 23 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index b7d7cba5a..4609e2ec2 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -22
We need to format alias even for inactive XMLs since that's the
way how users are going to identify their devices.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
i
https://bugzilla.redhat.com/show_bug.cgi?id=1434451
This way users can uniquely identify devices at define time.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
They have to be unique within the domain. As usual, backwards
compatibility takes its price. In this particular situation we
have a device that is represented twice in a domain and so is its
alias.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 148 +++
v2 of:
https://www.redhat.com/archives/libvir-list/2017-October/msg00790.html
diff to v1:
- new patch 1/11 to address Pavel's findings
- reworked parsing so that the alias is set iff it follows the rules
- added some tests
- added news.xml entry
Michal Privoznik (11):
qemu_alias: Be more toler
The qemuxml2argvtest expects the domain XMLs to be inactive ones.
Therefore we should pass inactive XMLs.
Signed-off-by: Michal Privoznik
---
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-network-ftp.xml | 1 -
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-network-ftps.xml | 1 -
tests/qemu
Signed-off-by: Michal Privoznik
---
.../qemuxml2argv-user-aliases.args | 71 +++
.../qemuxml2argvdata/qemuxml2argv-user-aliases.xml | 140 +
tests/qemuxml2argvtest.c | 5 +
.../qemuxml2xmlout-user-aliases.xml
Signed-off-by: Michal Privoznik
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index ff36c800a..989b82aa5 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -40,6 +40,15 @@
Add capability to allow hot (un)plug of a domain wat
Since we will be allowing users to set device aliases and memory
devices are fragile when it comes to aliases we have to make sure
they won't change during migration. Other devices should be fine.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 15 +++
1 file changed, 15
If driver that is calling the parse supports user supplied
aliases, they can be parsed even for inactive XMLs. However, to
avoid any clashes with aliases that libvirt generates, the user
ones have to have "ua-" prefix.
Note, that some drivers don't have notion of device aliases at
all. Also, in or
When assigning alias to a device we usually iterate over other
devices of its kind trying to find next index. We do this by
stripping down the prefix and then parsing number at the end,
Usually, if the prefix doesn't match the one we are expecting, we
just continue with next iteration. Except for c
The point of this test is to load live XML and test hotplug. But
even though the XMLs we are parsing are live, the parsing is done
with VIR_DOMAIN_DEF_PARSE_INACTIVE flag.
Signed-off-by: Michal Privoznik
---
tests/qemuhotplugtest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Hi Jim
I discovered that libvirt's native config file to xml converter for
libxl only pick up the first occurrence of an option.
For example in a xl cfg file:
extra = "abc"
...
extra = "def"
xl will pick up "def" because that shows up later and takes precedence,
while the converter picks up "ab
Hi,
libvirt-glib has unit tests which can be evaluated as a part of build of RPM.
It is generally recommended to run these tests so that some problems can be
cought soon enough before the package gets to the users.
Please, enable these tests for libvirt-glib.
I've done scratch-build of this in ko
From: Marek Kasik
Enable unit tests so that we can catch some problems soon enough
before the package gets to the users.
https://bugzilla.redhat.com/show_bug.cgi?id=1502639
---
libvirt-glib.spec.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libvirt-glib.spec.in b/libvirt-glib.spec.i
On Fri, Oct 20, 2017 at 04:25:13PM +0200, Andrea Bolognani wrote:
> On Fri, 2017-10-20 at 16:07 +0200, Pavel Hrdina wrote:
> > Introduced by 6094d6ec7fc9ea3e28c18c880b76858f06a8b129.
> > Found by running libvirt-perl tests.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/conf/virinterfaceobj
On 10/18/17 8:35 PM, Michael S. Tsirkin wrote:
On Wed, Oct 18, 2017 at 08:18:48PM +0100, Dr. David Alan Gilbert wrote:
* Michael S. Tsirkin (m...@redhat.com) wrote:
On Fri, Sep 08, 2017 at 10:48:10AM -0500, Brijesh Singh wrote:
> 11. GO verifies the measurement and if measurement matches
On Fri, 2017-10-20 at 16:07 +0200, Pavel Hrdina wrote:
> Introduced by 6094d6ec7fc9ea3e28c18c880b76858f06a8b129.
> Found by running libvirt-perl tests.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/conf/virinterfaceobj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src
On Fri, Oct 20, 2017 at 04:05:38PM +0200, Pavel Hrdina wrote:
> Pavel Hrdina (2):
> Add VIR_DOMAIN_JOB_MEMORY_PAGE_SIZE constant
> Add set_lifecycle_action
>
> Changes| 3 ++-
> Virt.xs| 24
> lib/Sys/Virt/Domain.pm | 60
> +++
On 10/20/2017 04:06 PM, David Hildenbrand wrote:
> On 20.10.2017 16:02, Christian Borntraeger wrote:
>>
>>
>> On 10/20/2017 03:51 PM, David Hildenbrand wrote:
>> [...]
The problem goes much further.
A fresh guest with
hvm
does not sta
Introduced by 6094d6ec7fc9ea3e28c18c880b76858f06a8b129.
Found by running libvirt-perl tests.
Signed-off-by: Pavel Hrdina
---
src/conf/virinterfaceobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/virinterfaceobj.c b/src/conf/virinterfaceobj.c
index a6814a6aee..21
On 20.10.2017 16:02, Christian Borntraeger wrote:
>
>
> On 10/20/2017 03:51 PM, David Hildenbrand wrote:
> [...]
>>> The problem goes much further.
>>> A fresh guest with
>>>
>>>
>>> hvm
>>>
>>>
>>>
>>> does not start. No migration from an older system is necessary.
>>>
>>
>> Ye
Signed-off-by: Pavel Hrdina
---
Changes| 1 +
Virt.xs| 23 +
lib/Sys/Virt/Domain.pm | 56 ++
3 files changed, 80 insertions(+)
diff --git a/Changes b/Changes
index 06f66c8..ebc6548 100644
--- a/C
Signed-off-by: Pavel Hrdina
---
Changes| 2 +-
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 4
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 0cf810e..06f66c8 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7 @@ Revision history
Pavel Hrdina (2):
Add VIR_DOMAIN_JOB_MEMORY_PAGE_SIZE constant
Add set_lifecycle_action
Changes| 3 ++-
Virt.xs| 24
lib/Sys/Virt/Domain.pm | 60 ++
3 files changed, 86 insertions(+), 1 delet
On 10/20/2017 03:51 PM, David Hildenbrand wrote:
[...]
>> The problem goes much further.
>> A fresh guest with
>>
>>
>> hvm
>>
>>
>>
>> does not start. No migration from an older system is necessary.
>>
>
> Yes, as stated in the documentation "copying host CPU definition from
>
On 20.10.2017 15:49, Christian Borntraeger wrote:
>
>
> On 10/20/2017 03:43 PM, David Hildenbrand wrote:
>> On 20.10.2017 15:36, Christian Borntraeger wrote:
>>>
>>>
>>> On 10/20/2017 03:16 PM, David Hildenbrand wrote:
> Hi all,
>
> we recently encountered the problem that the 'h
Separate it so that it deals only with single virStorageSource, so that
it can later be reused for full backing chain support.
Two aliases are passed since authentication is more relevant to the
'storage backend' whereas encryption is more relevant to the protocol
layer. When using node names, the
On 10/20/2017 03:43 PM, David Hildenbrand wrote:
> On 20.10.2017 15:36, Christian Borntraeger wrote:
>>
>>
>> On 10/20/2017 03:16 PM, David Hildenbrand wrote:
>>>
Hi all,
we recently encountered the problem that the 'host-model' [1] has to be
related to the machine type of a d
Until now we ignored user-provided backing chains and while detecting
the code inherited labels of the parent device. With user provided
chains we should keep this functionality, so label of the parent image
in the backing chain will be applied if an image-specific label is not
present.
---
src/se
When attaching the disks, aliases are always generated.
---
src/qemu/qemu_domain.c | 8
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_process.c | 2 +-
4 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_
qemuDomainGetImageIds and qemuDomainStorageFileInit are helpful when
trying to access a virStorageSource from the qemu driver since they
figure out the correct uid and gid for the image.
When accessing members of a backing chain the permissions for the top
level would be used. To allow using speci
When a user provides the backing chain, we will not need to re-detect
all the backing stores again, but should move to the end of the user
specified chain. Additionally if a user provides a full terminated chain
we should not attempt any further detection.
---
src/qemu/qemu_domain.c | 48 +
Simplify reporting the error if backing chain is broken for further
callers by extracting it into a separate function.
---
src/storage/storage_source.c | 47 +++-
src/storage/storage_source.h | 4
2 files changed, 37 insertions(+), 14 deletions(-)
dif
Until now we ignored user-provided backing chains and while detecting
the code inherited labels of the parent device. With user provided
chains we should keep this functionality, so label of the parent image
in the backing chain will be applied if an image-specific label is not
present.
---
src/se
Iterate through the backing chain when setting up TLS for disks.
---
src/qemu/qemu_domain.c | 41 ++---
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index aebe24e7b..3560cdd29 100644
--- a/src/qe
When the user provides backing chain, we don't need the full support for
traversing the backing chain. This patch adds a feature check for the
virStorageSourceAccess API.
---
src/storage/storage_source.c | 20
src/storage/storage_source.h | 1 +
2 files changed, 21 insertions
virSecuritySELinuxSetImageLabelInternal assigns different labels to
backing chain members than to the parent image. This was done via the
'first' flag. Convert it to passing in pointer to the parent
virStorageSource. This will allow us to use the parent virStorageSource
in further changes.
---
src
The 'file access' module of the storage driver has few feature checks to
determine whether libvirt supports given storage driver method. The code
to retrieve the driver struct needed for the check is the same so it can
be extracted.
---
src/storage/storage_source.c | 43 +++
---
src/qemu/qemu_domain.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 4a2ba1761..c689911c4 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1324,6 +1324,19 @@ qemuDomainSecret
When users will specify backing chain, we need to take into account what
was passed in them and/or inherit the data from the parents as we are
copying the data (labels, etc...) from the parent disk source.
Peter Krempa (12):
storage: Extract common code to retrieve driver backend for support
On 20.10.2017 15:36, Christian Borntraeger wrote:
>
>
> On 10/20/2017 03:16 PM, David Hildenbrand wrote:
>>
>>> Hi all,
>>>
>>> we recently encountered the problem that the 'host-model' [1] has to be
>>> related to the machine type of a domain. We have following problem:
>>>
>>>Let's assume w
On 10/20/2017 03:16 PM, David Hildenbrand wrote:
>
>> Hi all,
>>
>> we recently encountered the problem that the 'host-model' [1] has to be
>> related to the machine type of a domain. We have following problem:
>>
>>Let's assume we've a z13 system with a QEMU 2.9 and we define a
>>domain
On 10/19/2017 11:35 AM, Julio Faracco wrote:
> The function virEventRegisterImpl() checks the attempt to replace the
> registered events. But there is a duplicate variable inside the IF statement.
> The variable 'removeHandleImpl' was wrongly repeated. One of them needs to be
> replaced by 'remov
> Hi all,
>
> we recently encountered the problem that the 'host-model' [1] has to be
> related to the machine type of a domain. We have following problem:
>
>Let's assume we've a z13 system with a QEMU 2.9 and we define a
>domain using the default s390-virtio-ccw machine together with t
On Thu, 2017-10-19 at 13:35 -0200, Julio Faracco wrote:
> The function virEventRegisterImpl() checks the attempt to replace the
> registered events. But there is a duplicate variable inside the IF statement.
> The variable 'removeHandleImpl' was wrongly repeated. One of them needs to be
> replaced
On 10/19/2017 09:56 AM, Jiri Denemark wrote:
> Mostly refactoring of the horrible mess in qemuMigrationRun.
>
> Jiri Denemark (7):
> qemu: Use switch in qemuMigrationCompleted
> qemu: Refactor qemuMigrationRun a bit
> qemu: Split cleanup and error code in qemuMigrationRun
> qemu: Unite e
On 20.10.2017 14:50, Jiri Denemark wrote:
> On Fri, Oct 20, 2017 at 13:37:42 +0200, David Hildenbrand wrote:
>> On 20.10.2017 13:09, Marc Hartmayer wrote:
>>> we recently encountered the problem that the 'host-model' [1] has to be
>>> related to the machine type of a domain. We have following probl
On Fri, Oct 20, 2017 at 01:31:17PM +0200, Andrea Bolognani wrote:
> 1/2 is a bug fix, 2/2 a small improvement.
>
> Andrea Bolognani (2):
> guests: Reorder configuration steps for root authentication
> guests: Don't warn when bootstrapping package manager
Reviewed-by: Pavel Hrdina
signature
On 10/20/2017 08:21 AM, Ján Tomko wrote:
> On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote:
>> Since qemuAssignDeviceDiskAlias checks whether the input info.alias
>> is already present, no need to check here as well.
>>
>> Signed-off-by: John Ferlan
>> ---
>> src/qemu/qemu_hotplug.c
On Fri, Oct 20, 2017 at 13:37:42 +0200, David Hildenbrand wrote:
> On 20.10.2017 13:09, Marc Hartmayer wrote:
> > we recently encountered the problem that the 'host-model' [1] has to be
> > related to the machine type of a domain. We have following problem:
> >
> >Let's assume we've a z13 syst
On Fri, Oct 20, 2017 at 13:09:26 +0200, Marc Hartmayer wrote:
> we recently encountered the problem that the 'host-model' [1] has to be
> related to the machine type of a domain. We have following problem:
>
>Let's assume we've a z13 system with a QEMU 2.9 and we define a
>domain using the
On Fri, Oct 20, 2017 at 02:27:44PM +0200, Pavel Hrdina wrote:
> Pavel Hrdina (2):
> Add VIR_DOMAIN_JOB_MEMORY_PAGE_SIZE constant
> Add virDomainSetLifecycleAction API support
>
> domain.go| 39 +++
> domain_compat.go | 12
> domain_comp
Pavel Hrdina (2):
Add VIR_DOMAIN_JOB_MEMORY_PAGE_SIZE constant
Add virDomainSetLifecycleAction API support
domain.go| 39 +++
domain_compat.go | 12
domain_compat.h | 47 +++
3 files changed,
Signed-off-by: Pavel Hrdina
---
domain.go | 6 ++
domain_compat.h | 6 ++
2 files changed, 12 insertions(+)
diff --git a/domain.go b/domain.go
index b83bfc3..5183726 100644
--- a/domain.go
+++ b/domain.go
@@ -2860,6 +2860,8 @@ type DomainJobInfo struct {
MemBps
Signed-off-by: Pavel Hrdina
---
domain.go| 33 +
domain_compat.go | 12
domain_compat.h | 41 +
3 files changed, 86 insertions(+)
diff --git a/domain.go b/domain.go
index 5183726..36d77ba 100644
--- a/d
On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote:
Since qemuAssignDeviceDiskAlias checks whether the input info.alias
is already present, no need to check here as well.
Signed-off-by: John Ferlan
---
src/qemu/qemu_hotplug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
On Fri, Oct 20, 2017 at 01:10:14PM +0200, Pavel Hrdina wrote:
> On Fri, Oct 20, 2017 at 12:59:51PM +0200, Marc Hartmayer wrote:
> > Hi all,
> >
> > the actual capabilities of QEMU are depending on the host. This
> > includes dependencies like which kernel modules are loaded or which
> > kernel par
When migrating both memory and storage, we need to make sure block jobs
are finished after the virtual CPUs get paused at the end of migration
but before QEMU completes the migration otherwise QEMU may die with
_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed
This is a libvirt si
This new capability enables a pause before device state serialization so
that we can finish all block jobs without racing with the end of the
migration. The pause is indicated by "pre-switchover" state. Once we're
done QEMU enters "device" migration state.
This patch just defines the new capabilit
QEMU identified a race condition between the device state serialization
and the end of storage migration. Both QEMU and libvirt needs to be
updated to fix this.
Our migration work flow is modified so that after starting the migration
we to wait for QEMU to enter "pre-switchover", "postcopy-active"
Rather than having the caller check, if the input @addrs is NULL
(e.g. priv->usbaddrs), then just return 0.
Signed-off-by: John Ferlan
---
src/conf/domain_addr.c | 3 +++
src/conf/domain_addr.h | 2 +-
src/qemu/qemu_hotplug.c | 23 ---
3 files changed, 12 insertions(+), 1
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor.c | 13 +
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 27 +++
src/qemu/qemu_monitor_json.h | 4
4 files changed, 47 insertions(+)
diff --git a/src/qemu/qemu_monitor.c b
Since qemuAssignDeviceControllerAlias checks whether the input info.alias
is already present, no need to check here as well.
Signed-off-by: John Ferlan
---
src/qemu/qemu_hotplug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_ho
Rather than having the caller check, if the input @addrs is NULL
(e.g. priv->usbaddrs), then just return 0.
Signed-off-by: John Ferlan
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 2 +-
src/qemu/qemu_domain_address.c | 7 ++-
src/qemu/qemu_hotplug.c|
Patches speak for themselves - they also resolve a couple of new
Coverity whines.
John Ferlan (4):
conf,qemu: Check for NULL addrs in virDomainUSBAddressRelease
conf,qemu: Check for NULL addrs in virDomainUSBAddressEnsure
qemu: Remove unnecessary virtio disk detach info.alias check
qemu: R
Since qemuAssignDeviceDiskAlias checks whether the input info.alias
is already present, no need to check here as well.
Signed-off-by: John Ferlan
---
src/qemu/qemu_hotplug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.
On 10/20/2017 01:38 PM, Pavel Hrdina wrote:
> On Fri, Oct 20, 2017 at 01:20:20PM +0200, Michal Privoznik wrote:
>> On 10/19/2017 03:33 PM, Pavel Hrdina wrote:
>>> On Thu, Oct 19, 2017 at 10:10:55AM +0200, Michal Privoznik wrote:
As discussed earlier [1], we should allow users to set device
>>>
On Fri, Oct 20, 2017 at 07:08:37 -0400, John Ferlan wrote:
>
>
> On 10/20/2017 03:03 AM, Jiri Denemark wrote:
> > On Thu, Oct 19, 2017 at 18:30:53 -0400, John Ferlan wrote:
> >>
> >>
> >> On 10/18/2017 07:29 AM, Jiri Denemark wrote:
> >>> Each time we need to check whether a given migration capab
On Fri, Oct 20, 2017 at 01:20:20PM +0200, Michal Privoznik wrote:
> On 10/19/2017 03:33 PM, Pavel Hrdina wrote:
> > On Thu, Oct 19, 2017 at 10:10:55AM +0200, Michal Privoznik wrote:
> >> As discussed earlier [1], we should allow users to set device
> >> aliases at the define time. While the discuss
On 20.10.2017 13:09, Marc Hartmayer wrote:
> On Thu, Oct 12, 2017 at 02:07 PM +0200, Jiri Denemark
> wrote:
>> On Mon, Oct 09, 2017 at 10:16:48 +0200, Marc Hartmayer wrote:
>>> On Thu, Oct 05, 2017 at 02:11 PM +0200, Jiri Denemark
>>> wrote:
But it's going to be a bit complicated because w
1/2 is a bug fix, 2/2 a small improvement.
Andrea Bolognani (2):
guests: Reorder configuration steps for root authentication
guests: Don't warn when bootstrapping package manager
guests/tasks/base.yml | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
--
2.13.6
--
libvir
Key-based SSH authentication for root should be enabled before
changing the password, because if that fails (for example because
the user hasn't generated an SSH key pair yet) having changed the
root password will result in subsequent 'lcitool prepare' runs
failing to access the guest.
Signed-off-
Ansible will try to get us to use the apt or dnf modules, but we
can't really do that when we are bootstrapping said modules, so
just silence the warning.
Signed-off-by: Andrea Bolognani
---
guests/tasks/base.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/guests/tasks/base.yml b/guest
On Fri, Oct 20, 2017 at 13:15:41 +0200, Marc Hartmayer wrote:
> On Fri, Oct 20, 2017 at 01:10 PM +0200, Pavel Hrdina
> wrote:
> > On Fri, Oct 20, 2017 at 12:59:51PM +0200, Marc Hartmayer wrote:
> >> Hi all,
> >>
> >> the actual capabilities of QEMU are depending on the host. This
> >> includes de
On 10/19/2017 03:33 PM, Pavel Hrdina wrote:
> On Thu, Oct 19, 2017 at 10:10:55AM +0200, Michal Privoznik wrote:
>> As discussed earlier [1], we should allow users to set device
>> aliases at the define time. While the discussed approach calls
>> for generating missing aliases too, I'm saving that f
On Thu, Oct 12, 2017 at 02:07 PM +0200, Jiri Denemark
wrote:
> On Mon, Oct 09, 2017 at 10:16:48 +0200, Marc Hartmayer wrote:
>> On Thu, Oct 05, 2017 at 02:11 PM +0200, Jiri Denemark
>> wrote:
>> > But it's going to be a bit complicated because we ask QEMU what the
>> > host CPU is and the inter
On Fri, Oct 20, 2017 at 01:10 PM +0200, Pavel Hrdina wrote:
> On Fri, Oct 20, 2017 at 12:59:51PM +0200, Marc Hartmayer wrote:
>> Hi all,
>>
>> the actual capabilities of QEMU are depending on the host. This
>> includes dependencies like which kernel modules are loaded or which
>> kernel parameters
On Fri, Oct 20, 2017 at 12:59:51PM +0200, Marc Hartmayer wrote:
> Hi all,
>
> the actual capabilities of QEMU are depending on the host. This
> includes dependencies like which kernel modules are loaded or which
> kernel parameters are used (e.g. kvm.nested). Therefore, after a
> restart we cannot
On 10/20/2017 03:03 AM, Jiri Denemark wrote:
> On Thu, Oct 19, 2017 at 18:30:53 -0400, John Ferlan wrote:
>>
>>
>> On 10/18/2017 07:29 AM, Jiri Denemark wrote:
>>> Each time we need to check whether a given migration capability is
>>> supported by QEMU, we call query-migrate-capabilities QMP comm
Hi all,
the actual capabilities of QEMU are depending on the host. This
includes dependencies like which kernel modules are loaded or which
kernel parameters are used (e.g. kvm.nested). Therefore, after a
restart we cannot be sure that the QEMU capabilities remain the same.
How can we solve this
On Fri, Oct 20, 2017 at 12:12 PM +0200, Jiri Denemark
wrote:
> On Fri, Oct 20, 2017 at 11:28:37 +0200, Marc Hartmayer wrote:
>> On Thu, Oct 19, 2017 at 03:56 PM +0200, Jiri Denemark
>> wrote:
>> > When adding a new job state it's useful to let the compiler complain
>> > about places where we ne
On Fri, Oct 20, 2017 at 11:28:37 +0200, Marc Hartmayer wrote:
> On Thu, Oct 19, 2017 at 03:56 PM +0200, Jiri Denemark
> wrote:
> > When adding a new job state it's useful to let the compiler complain
> > about places where we need to think about what to do with the new
> > state.
> >
> > Signed-o
On Thu, Oct 19, 2017 at 03:56 PM +0200, Jiri Denemark
wrote:
> When adding a new job state it's useful to let the compiler complain
> about places where we need to think about what to do with the new
> state.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 23 ++
On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote:
> On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote:
> > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote:
> > > - Original Message -
> > > > From: "Daniel P. Berrange"
> > > > To: "Igor Mammedov
1 - 100 of 102 matches
Mail list logo
