These XMLs live in a separate directory, there's no need for them
to have a special prefix in addition. It also doesn't play nicely
with ':e' completion in Vim, finding proper file based on
qemuxml2argvtest.c is also needlessly complicated.
The files were renamed using the following commands. From
The patches are trimmed out a lot to fit the size limit of our list. Anyway,
the interesting bits are kept and also you can find the patches at my github:
https://github.com/zippy2/libvirt/commits/qemuxml2argvdata
If this approach is ACKed, I can continue because some other files suffer the
sam
Similarly to the previous commit, rename .args files.
The files were renamed using the following commands. From
qemuxml2argvdata:
for i in qemuxml2argv-*.args; do mv $i ${i#qemuxml2argv-}; done
and then (to fix broken symlinks) from qemuxml2argvdata and
qemuxml2xmloutdata:
for i in $(find .
Okay, the second release candidate is now tagged in git, signed tarball
and rpms have been pushed to the usual location:
ftp://libvirt.org/libvirt/
Seems to work fine in my limited testing, Jenkins is still all green
at https://ci.centos.org/view/libvirt/ so it looks like we are lining up
On Fri, Dec 01, 2017 at 11:59:50AM +0100, Peter Krempa wrote:
> On Thu, Nov 30, 2017 at 17:13:02 +0100, Peter Krempa wrote:
> > On Wed, Nov 29, 2017 at 17:27:40 +0100, Daniel Veillard wrote:
> > > As planned yesterday (but a bit late) I tagged Release Candidate 1
> > > in git and pushed the signe
On Fri, Dec 01, 2017 at 01:54:30PM +0100, Pavel Hrdina wrote:
Pavel Hrdina (2):
security: introduce virSecurityManager(Set|Restore)ChardevLabel
qemu: fix security labeling for attach/detach of char devices
src/libvirt_private.syms| 2 ++
src/qemu/qemu_hotplug.c | 10 +++
src
Use this function in qemuDomainNamespaceSetup* functions which
only require creating one device.
---
src/qemu/qemu_domain.c | 120 +++--
1 file changed, 26 insertions(+), 94 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
To match the "things/nthings" pattern used in virDomainDef.
---
src/qemu/qemu_domain.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e8e03134f..1c145365a 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_d
The underlying function which needs the driver gets it from the
passed virDomainObj object anyway.
---
src/qemu/qemu_domain.c | 34 --
src/qemu/qemu_domain.h | 30 ++
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_hotplug.c | 42 +++
Split out the logic of unlinking devices from
qemuDomainNamespaceTeardownHostdev for reuse in other functions.
---
src/qemu/qemu_domain.c | 55 +++---
1 file changed, 39 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_
Use it in every qemuDomainNamespaceTeardown* function that only
wants to unlink one device.
---
src/qemu/qemu_domain.c | 117 +++--
1 file changed, 26 insertions(+), 91 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index ddc9
To match the "things/nthings" pattern used in virDomainDef.
---
src/qemu/qemu_domain.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 1c145365a..d7f4b3fd7 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_d
Separate the logic of creating devices from their gathering.
Use this new function in qemuDomainNamespaceSetupHostdev and
qemuDomainNamespaceSetupDisk.
---
src/qemu/qemu_domain.c | 74 ++
1 file changed, 44 insertions(+), 30 deletions(-)
diff --git
Rebased + rename path to paths in one more function.
Ján Tomko (7):
qemuDomainNamespaceTeardownHostdev: rename path to paths
qemuDomainNamespaceSetupHostdev: rename path to paths
Introduce qemuDomainNamespaceMknodPaths
Introduce qemuDomainNamespaceMknodPath
Introduce qemuDomainNamespaceU
On Fri, Dec 01, 2017 at 07:31:29PM +0800, Lin Ma wrote:
Adding an IDE controller for a machinetype that has no built-in IDE
controller, Libvirt will log an error. Currently the machinetype list
which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx,
malta, sun4u and g3beige.
Signed-
On 12/01/2017 06:26 AM, Jamie Strandboge wrote:
On Thu, 2017-11-30 at 10:43 -0700, Jim Fehlig wrote:
Noticed the following denial in audit.log when shutting down
an apparmor confined domain
type=AVC msg=audit(1512002299.742:131): apparmor="DENIED"
operation="open" profile="libvirt-66154842-e926
I know that libvirt 3.2 does not have this issue, this is last version
that i try before this issue (after 3.2 i'm go to 3.5.0)
2017-12-01 16:14 GMT+03:00 Nikolay Shirokovskiy :
> On 01.12.2017 15:26, Vasiliy Tolstov wrote:
>> Hi again. I'm still try to determine why my libvirtd locks, this is
>>
May be i'm too late check the status, but always when i have such
issue virsh says that domain in shutdown state, and qemu process not
founded.
2017-12-01 16:10 GMT+03:00 Peter Krempa :
> On Fri, Dec 01, 2017 at 15:26:35 +0300, Vasiliy Tolstov wrote:
>> Hi again. I'm still try to determine why my
On Thu, Nov 30, 2017 at 01:17:25PM +, Daniel P. Berrange wrote:
> Each module has its own set of tags it may wish to pass to 'go test',
> so set it based on an env variable
>
> Signed-off-by: Daniel P. Berrange
> ---
> jobs/go.yaml | 2 +-
> projects/libvirt-go-xml.yaml | 2 +
On 12/01/2017 08:06 AM, Pavel Hrdina wrote:
> On Fri, Dec 01, 2017 at 07:31:31PM +0800, Lin Ma wrote:
>> The corresponding code will be moved to qemuDomainControllerDefValidate
>> by next patch.
>>
>> Signed-off-by: Lin Ma
>> ---
>> src/qemu/qemu_command.c | 10 +-
>> 1 file changed, 1
On Thu, 2017-11-30 at 10:43 -0700, Jim Fehlig wrote:
> Noticed the following denial in audit.log when shutting down
> an apparmor confined domain
>
> type=AVC msg=audit(1512002299.742:131): apparmor="DENIED"
> operation="open" profile="libvirt-66154842-e926-4f92-92f0-
> 1c1bf61dd1ff"
> name="/proc
On 01.12.2017 15:26, Vasiliy Tolstov wrote:
> Hi again. I'm still try to determine why my libvirtd locks, this is
> another portion of gdb stuff:
> https://gist.github.com/vtolstov/ae8c4a67e15b2fbd14bbb95c226fb427
>
> error looks in logs like:
> Dec 01 12:35:49 cn04 libvirtd[1171]: 2017-12-01 09:3
On Fri, Dec 01, 2017 at 15:26:35 +0300, Vasiliy Tolstov wrote:
> Hi again. I'm still try to determine why my libvirtd locks, this is
> another portion of gdb stuff:
> https://gist.github.com/vtolstov/ae8c4a67e15b2fbd14bbb95c226fb427
>
> error looks in logs like:
> Dec 01 12:35:49 cn04 libvirtd[117
On Fri, Dec 01, 2017 at 07:31:31PM +0800, Lin Ma wrote:
> The corresponding code will be moved to qemuDomainControllerDefValidate
> by next patch.
>
> Signed-off-by: Lin Ma
> ---
> src/qemu/qemu_command.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/src/qem
SELinux and DAC drivers already have both functions but they were not
exported as public API of security manager.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms| 2 ++
src/security/security_dac.c | 3 +++
src/security/security_driver.h | 11 +++
src/security/secu
Commit e93d844b90 was not enough to fix the permission denied
issue. We need to apply security labels as well.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1465833
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_hotplug.c | 10
src/qemu/qemu_security.c | 60 +++
Pavel Hrdina (2):
security: introduce virSecurityManager(Set|Restore)ChardevLabel
qemu: fix security labeling for attach/detach of char devices
src/libvirt_private.syms| 2 ++
src/qemu/qemu_hotplug.c | 10 +++
src/qemu/qemu_security.c| 60 +
On 12/01/2017 06:31 AM, Lin Ma wrote:
> Validate IDE controllers in qemuDomainDeviceDefValidate for reminding users
> earlier.
>
> v2->v3:
> * split original patch to multiple patches.
> * making the validation is preferred over the PostParse for avoiding guests
> disappear.
> * remove ide fro
Hi again. I'm still try to determine why my libvirtd locks, this is
another portion of gdb stuff:
https://gist.github.com/vtolstov/ae8c4a67e15b2fbd14bbb95c226fb427
error looks in logs like:
Dec 01 12:35:49 cn04 libvirtd[1171]: 2017-12-01 09:35:49.637+:
28063: error : qemuDomainObjBeginJobInter
The corresponding code will be moved to qemuDomainControllerDefValidate
by next patch.
Signed-off-by: Lin Ma
---
src/qemu/qemu_command.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6a8da1d..2074ff6 100644
-
Validate IDE controllers in qemuDomainDeviceDefValidate for reminding users
earlier.
v2->v3:
* split original patch to multiple patches.
* making the validation is preferred over the PostParse for avoiding guests
disappear.
* remove ide from the pseries and the ccw tests.
Lin Ma (4):
tests: q
Validate IDE controllers in qemuDomainDeviceDefValidate for reminding
users earlier.
Signed-off-by: Lin Ma
---
src/qemu/qemu_domain.c | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e8e0
Adding an IDE controller for a machinetype that has no built-in IDE
controller, Libvirt will log an error. Currently the machinetype list
which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx,
malta, sun4u and g3beige.
Signed-off-by: Lin Ma
---
tests/qemuxml2argvdata/qemuxml2argv-d
Adding an IDE controller for a machinetype that has no built-in IDE
controller, libvirt will log an error. Currently the machinetype list
which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx,
malta, sun4u and g3beige.
Signed-off-by: Lin Ma
---
tests/qemuhotplugtestdomains/qemuhotp
On Thu, Nov 30, 2017 at 17:13:02 +0100, Peter Krempa wrote:
> On Wed, Nov 29, 2017 at 17:27:40 +0100, Daniel Veillard wrote:
> > As planned yesterday (but a bit late) I tagged Release Candidate 1
> > in git and pushed the signed tarball and rpms to the usual place:
> >
> > ftp://libvirt.org/li
Hi,
Michal Privoznik:
> On 11/30/2017 06:43 PM, Jim Fehlig wrote:
>> I must admit it is not clear to me why
>> /proc//cmdline is read on domain shutdown.
> It's result of these qemu patches:
> fbe7e3327a8cfa1b08664c2cda7a0a341cf0530a
> 7dc9ae4339faa97e89daadb2e1098147ab4aadc8
> Whenever qemu re
On Fri, Dec 01, 2017 at 10:09:46 +0100, Michal Privoznik wrote:
> ==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
> ==899==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
> ==899==by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
> ==899==by 0x55498D2: virVasp
On Fri, Dec 01, 2017 at 10:09:45 +0100, Michal Privoznik wrote:
> ==1277== 8 bytes in 4 blocks are definitely lost in loss record 39 of 131
> ==1277==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
> ==1277==by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
> ==1277==by 0x53B1DC2
On Fri, Dec 01, 2017 at 10:09:44 +0100, Michal Privoznik wrote:
> ==861== 3 bytes in 1 blocks are definitely lost in loss record 3 of 168
> ==861==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
> ==861==by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
> ==861==by 0x5DCCDC2: vir
On 11/24/2017 06:18 PM, John Ferlan wrote:
> Don't use a unary comparison for an int value - compare against zero
> directly instead.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/numa_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/numa_conf.c b/src/c
Ideally, I'd like to merge these to the release.
Michal Privoznik (3):
virDomainDiskSourceNetworkParse: Don't leak @tlsCfg or @haveTLS
virDomainDiskBackingStoreParse: Don't leak @idx
qemuStateInitialize: Don't leak @memoryBackingPath
src/conf/domain_conf.c | 3 +++
src/qemu/qemu_driver.c |
==1277== 8 bytes in 4 blocks are definitely lost in loss record 39 of 131
==1277==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
==1277==by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
==1277==by 0x53B1DC2: virXMLPropString (virxml.c:510)
==1277==by 0x53D696A: virDomainDis
==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
==899==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
==899==by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
==899==by 0x55498D2: virVasprintfInternal (virstring.c:708)
==899==by 0x55499E7: virAsprintfInte
==861== 3 bytes in 1 blocks are definitely lost in loss record 3 of 168
==861==at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
==861==by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
==861==by 0x5DCCDC2: virXMLPropString (virxml.c:510)
==861==by 0x5DF1232: virDomainDiskSourc
On 11/24/2017 06:18 PM, John Ferlan wrote:
> While reviewing the recent distance adjustments for Michal, I noted a
> couple of minor formatting things as well as a memory leak when removing
> the distances.
>
> John Ferlan (3):
> conf: Clean up virDomainNumaDefNodeDistanceParseXML
> conf: Clea
On 11/30/2017 06:43 PM, Jim Fehlig wrote:
> Noticed the following denial in audit.log when shutting down
> an apparmor confined domain
>
> type=AVC msg=audit(1512002299.742:131): apparmor="DENIED"
> operation="open" profile="libvirt-66154842-e926-4f92-92f0-1c1bf61dd1ff"
> name="/proc/1475/cmdline"
46 matches
Mail list logo
