v4:
update commit messages and news
v3:
use helper qemuDomainDelChardevTLSObjects and address some comments
v2:
rebased on master
Chen Hanxiao (2):
qemu: Add support for hot unplugging redirdev device which can use the
detach-device --live
news: add change of hot unplug redirdev
do
From: Chen Hanxiao
Commit id '162efa1a' added support hotplug a redirdev, but
did not add the hot unplug. This patch will add that support
to allow usage of the detach-device --live on the device.
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4:
commit message changed and fit cod
From: Chen Hanxiao
Reviewed-by: John Ferlan
Signed-off-by: Chen Hanxiao
---
v4:
remove part
v3:
move it into 'Improvements' section
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index bb611b7ba..838dd5b39 100644
--- a/docs/news.xml
+
offset and len can also be equal to 0 on failed if blockjob return
status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state",
so we need to check 'error' in this case.
---
src/qemu/qemu_monitor_json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_mo
Thanks for your reply, and I will send a new version of this
patch.
>On Thu, Jan 04, 2018 at 05:46:32 -0500, Yi Wang wrote:
>> We can't clear vcpupin settings of XML once we did vcpupin
>> command, this is not convenient under some condition such
>> as migration.
>>
>> This patch introduces clear
On 12/09/2017 07:10 PM, Marek Marczykowski-Górecki wrote:
Check conversion of "cpuid" setting, check all supported policy settings
("1", "0", "x"). Also, check interaction with "nestedhvm" - should not
be included as "vmx=1" in "cpuid" setting.
---
Changes since v2:
- new patch
---
tests/xlc
On 12/09/2017 07:10 PM, Marek Marczykowski-Górecki wrote:
Only "libxl" format supported for now. Special care needed around
vmx/svm, because those two are translated into "nestedhvm" setting.
---
Changes since v2:
- new patch
---
src/xenconfig/xen_xl.c | 168 +
offset and len can also be equal to 0 on failed if blockjob return
status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state",
so it's better to make our decision based on whether 'error' is non-NULL.
---
src/qemu/qemu_monitor_json.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On 12/13/2017 09:30 AM, Michal Privoznik wrote:
> Since we have user aliases it may happen that users want to
> change it using 'update-device'. Instead of ignoring it silently,
> error out loudly.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 8
> 1 file change
On 12/22/2017 03:04 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> Add hot unplug redirdev in news 'Improvements' section
I'll drop this part
>
> Signed-off-by: Chen Hanxiao
> ---
> v3:
> move it into 'Improvements' section
>
> docs/news.xml | 11 +++
> 1 file changed, 11 inse
On 12/22/2017 03:04 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> We lacked of hot unplugging redirdev device.
> This patch add support for it.
> We could use detach-device --live now.
Change the commit message to:
Commit id '162efa1a' added support hotplug a redirdev, but
did not add the
On 12/20/2017 04:29 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> We used VIR_ERR_OPERATION_FAILED when target detaching device
> is not found.
> That error code VIR_ERR_OPERATION_FAILED is widely used,
> so the tools powered by libvirt, such as nova,
> can't catch the exact errors from libv
On 12/19/2017 05:08 AM, Bjoern Walk wrote:
> Since kernel version 4.7, processor frequency information is available
> on S390. Let's adjust the parser so this information shows up for virsh
> nodeinfo:
>
> # virsh nodeinfo
> CPU model: s390x
> CPU(s): 8
> C
On 12/19/2017 05:08 AM, Bjoern Walk wrote:
> Let's also parse the available processor frequency information on S390
> so that it can be utilized by virsh sysinfo:
>
> # virsh sysinfo
>
>
> ...
>
> 2964
> IBM/S390
> 00
> 5000
> 5000
> 145
On 12/18/2017 07:33 AM, Marc Hartmayer wrote:
> This fixes the compilation error (compiled with the compiler option
> '-03').
>
> In file included from ../../tools/vsh.c:28:0:
> ../../tools/vsh.c: In function 'vshCommandOptStringQuiet':
> ../../tools/vsh.c:838:30: error: potential null pointer d
On 12/17/2017 06:02 PM, Shaohe Feng wrote:
> We can start qemu with a "cpu,+la57" to set 57-bit vitrual address
> space. So VM can be aware that it need to enable 5-level paging.
>
> Corresponding QEMU commits:
> al57 6c7c3c21f95dd9af8a0691c0dd29b07247984122
> ---
> src/cpu/cpu_map.xml
Add a @detach parameter to the API in order allow running the QEMU
code as a thread.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_monitor.c | 7 +--
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_monitor_json.c | 4 +++-
src/qemu/qemu_monitor_js
https://bugzilla.redhat.com/show_bug.cgi?id=916061
If the QEMU version running is new enough (based on the DUMP_COMPLETED
event), then we can add a 'detach' boolean to the dump-guest-memory
command in order to tell QEMU to run in a thread. This ensures that we
don't lock out other commands while t
Add the DUMP_COMPLETED check to the capabilities. This is the
mechanism used to determine whether the dump-guest-memory command
can support the "-detach" option and thus be able to wait on the
event and allow for a query of the progress of the dump.
Signed-off-by: John Ferlan
---
src/qemu/qemu_c
Previous rebase:
https://www.redhat.com/archives/libvir-list/2017-December/msg00124.html
Rebase after pushing first 2 ACK'd patches and for recent capabilities
adjustments. Plus it's been a month...
Original v2:
https://www.redhat.com/archives/libvir-list/2017-November/msg00779.html
Rebase due
The event is fired when the domain memory only dump completes.
Wire up the code to extract and send along the status.
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.c | 18 ++
src/qemu/qemu_monitor.h | 19 +++
src/qemu/qemu_monitor_json.c | 31 +++
Add an API to allow fetching the Dump statistics for the job
via the qemuDomainGetJobInfo API.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 56 --
1 file changed, 54 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/sr
Extract out the parts of qemuDomainGetJobStatsInternal that get
the migration stats. We're about to add the ability to get just
dump information.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 52 --
1 file changed, 33 insertions(+), 19 de
Add the query-dump API's in order to allow the dump-guest-memory
to be used to monitor progress.
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.c | 14 +
src/qemu/qemu_monitor.h | 11 +++
src/qemu/qemu_monitor_json.c | 69
Add a couple of booleans to mark when there's a dump completion event
waiting and when a dump completed event has been received.
To ensure the dump completed event from a non memory-only dump doesn't
cause the a dump completed event to be fired, only broadcast if there's
a completion event waiting
On 01/04/2018 10:12 AM, Jie Wang wrote:
> offset and len can also be equal to 0 on failed if blockjob return
> status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state",
> so it's better to make our decision based on whether 'error' is non-NULL.
> ---
> src/qemu/qemu_monitor_json.c |
On 01/04/2018 06:51 AM, Jiri Denemark wrote:
> On Thu, Jan 04, 2018 at 20:19:51 +0800, Wang King wrote:
>> As CVE-2017-5715 described on
>> https://access.redhat.com/security/cve/cve-2017-5715,
>> libvirt under the influence yet, So what's coming next for this?
>
> We're waiting for QEMU patches
Heyho Guys,
The domain defintion xml allows to extend the qemu command.
For example:
```
```
The options are correctly passed on startup, but the migration will
ignore them. The desination xml is dumped with the flags 1|2|8. (secure,
inactive and migrateable)
`secure` flag is requ
offset and len can also be equal to 0 on failed if blockjob return
status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state",
so it's better to make our decision based on whether 'error' is non-NULL.
---
src/qemu/qemu_monitor_json.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On Thu, Jan 04, 2018 at 16:25:49 +0100, Peter Krempa wrote:
> On Thu, Jan 04, 2018 at 15:58:11 +0100, Jiri Denemark wrote:
> > From: Paolo Bonzini
> >
> > A microcode update can cause the CPUID bits to change; an example
> > from the past was the update that disabled TSX on several Haswell and
>
On Thu, Jan 04, 2018 at 04:27:45PM +0100, Jiri Denemark wrote:
On Thu, Jan 04, 2018 at 16:15:46 +0100, Peter Krempa wrote:
On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote:
> +char ebuf[1024];
> +VIR_DEBUG("Failed to read microcode version from %s: %s",
> +
On Thu, Jan 04, 2018 at 15:58:12 +0100, Jiri Denemark wrote:
> From: Paolo Bonzini
>
> A microcode update can cause the CPUID bits to change; an example
> from the past was the update that disabled TSX on several Haswell
> and Broadwell machines.
>
> Therefore, place microcode version in the vir
On Thu, Jan 04, 2018 at 16:15:46 +0100, Peter Krempa wrote:
> On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote:
> > From: Paolo Bonzini
> >
> > This new API reads host's CPU microcode version from /proc/cpuinfo.
> >
> > Unfortunately, there is no other way of reading microcode version
On Thu, Jan 04, 2018 at 15:58:11 +0100, Jiri Denemark wrote:
> From: Paolo Bonzini
>
> A microcode update can cause the CPUID bits to change; an example
> from the past was the update that disabled TSX on several Haswell and
> Broadwell machines.
>
> In order to track the x86 microcode version i
On Thu, Jan 04, 2018 at 15:58:10 +0100, Jiri Denemark wrote:
> The function will be used to initialize internal data of the x86 CPU
> driver (including the CPU map).
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_x86.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
ACK
On Thu, Jan 04, 2018 at 15:58:08 +0100, Jiri Denemark wrote:
> From: Paolo Bonzini
>
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Jiri Denemark
> ---
> src/libvirt_private.syms | 1 +
> src/util/virfile.c | 19 +++
> src/util/virfile.h | 2 ++
> 3 files changed
On Thu, Jan 04, 2018 at 15:58:09 +0100, Jiri Denemark wrote:
> From: Paolo Bonzini
>
> This new API reads host's CPU microcode version from /proc/cpuinfo.
>
> Unfortunately, there is no other way of reading microcode version which
> would be usable from both system and session daemon.
>
> Signe
Jiri Denemark (1):
cpu_x86: Rename virCPUx86MapInitialize
Paolo Bonzini (4):
util: add virFileReadHeaderQuiet wrapper around virFileReadHeaderFD
util: introduce virHostCPUGetMicrocodeVersion
conf: include x86 microcode version in virsh capabilities
qemu: capabilities: force update if the
The function will be used to initialize internal data of the x86 CPU
driver (including the CPU map).
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index f514fd2663..fddde64d8c 1
From: Paolo Bonzini
A microcode update can cause the CPUID bits to change; an example
from the past was the update that disabled TSX on several Haswell and
Broadwell machines.
In order to track the x86 microcode version in the QEMU capabilities,
we have to fetch it and store it in the host CPU.
From: Paolo Bonzini
This new API reads host's CPU microcode version from /proc/cpuinfo.
Unfortunately, there is no other way of reading microcode version which
would be usable from both system and session daemon.
Signed-off-by: Paolo Bonzini
Signed-off-by: Jiri Denemark
---
src/libvirt_priva
From: Paolo Bonzini
A microcode update can cause the CPUID bits to change; an example
from the past was the update that disabled TSX on several Haswell
and Broadwell machines.
Therefore, place microcode version in the virQEMUCaps struct and
XML, and rebuild the cache if the versions do not match
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Jiri Denemark
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 19 +++
src/util/virfile.h | 2 ++
3 files changed, 22 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private
On Mon, Dec 18, 2017 at 07:56:51AM -0500, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2017-December/msg00543.html
>
> Changes since v1...
>
> * Added a patch to handle a NULL return with pool obj lock
>
> * Alter the IsDuplicate API to use a bool parameter
>
> * Use the
On Mon, Dec 18, 2017 at 07:56:52AM -0500, John Ferlan wrote:
> The RW pool could be left unlocked if allocation fails.
s/unlocked/locked
Erik
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Introduced by commit <0eaa59dce1>. That comparison already returns
true or false.
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule.
src/rpc/virnetserverclient.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclie
You're correct Jim,
virNetDevSwitchdevFeature determines if the interface supports switchdev mode
(hw offloading).
We are using virNetDevGetPCIDevice to determine the interface's PF pci address
in order to query the nic's capabilities using devlink.
I'm not that familiar with the rest of the use
On Thu, Jan 04, 2018 at 07:24:30AM -0500, John Ferlan wrote:
Jan -
ping on the question from my response to your review...
On 12/20/2017 01:33 PM, John Ferlan wrote:
On 12/20/2017 07:38 AM, Ján Tomko wrote:
[...]
Easier to read as:
for (next_unit = -1; next_unit < -1; controller++)
On Wed, Dec 20, 2017 at 01:52:16PM +0100, Ján Tomko wrote:
On Wed, Dec 06, 2017 at 08:08:05AM -0500, John Ferlan wrote:
In virDomainDefMaybeAddHostdevSCSIcontroller when we add a new
controller because someone neglected to add one or we're adding
one because the existing one is full, we should c
On 01/04/2018 05:23 AM, Marc Hartmayer wrote:
> On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan
> wrote:
>> Move the checks that various attributes are not set on any controller
>> other than SCSI controller using virtio-scsi model into the common
>> controller validate checks.
>
> You not
On Thu, Jan 04, 2018 at 20:19:51 +0800, Wang King wrote:
> As CVE-2017-5715 described on
> https://access.redhat.com/security/cve/cve-2017-5715,
> libvirt under the influence yet, So what's coming next for this?
We're waiting for QEMU patches since libvirt can't do much with this
issue by itself.
On 12/13/2017 03:30 PM, Michal Privoznik wrote:
> Since we have user aliases it may happen that users want to
> change it using 'update-device'. Instead of ignoring it silently,
> error out loudly.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 8
> 1 file changed,
On 12/18/2017 10:43 AM, linzhecheng wrote:
> We use virsh detach-device to hot-unplug a vhost-user net card,
> and libvirtd will issue qmp_netdev_del, qmp_chardev_remove and
> qmp_netdev_del. However, in qmp_netdev_del, qemu will remove
> the chardev when cleanup the netdev. So libvirtd has no need
When the -machine pseries,max-cpu-compat=X is supported use
machine parameter instead of -cpu host,compat=X parameter as
that is deprecated now with qemu > v2.10.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146
Signed-off-by: Shivaprasad G Bhat
---
src/qemu/qemu_command.c
Signed-off-by: Shivaprasad G Bhat
---
src/qemu/qemu_capabilities.c |7 +++
src/qemu/qemu_capabilities.h |2 ++
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml |1 +
3 files changed, 10 insertions(+)
diff --git a/src/qemu/qemu_capabilities.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146
---
Shivaprasad G Bhat (2):
qemu: Add capability for pseries machine's max-cpu-compat= parameter
qemu: Add support for pseries machine's max-cpu-compat= parameter
src/qemu/qemu_capabilities.c |7 +++
On 12/21/2017 08:33 PM, Julio Faracco wrote:
> There is no method to rename inactive domains for test driver.
> After this patch, we can rename the domains using 'domrename'.
>
> virsh# domrename test anothertest
> Domain successfully renamed
>
> Signed-off-by: Julio Faracco
> ---
> src
Jan -
ping on the question from my response to your review...
On 12/20/2017 01:33 PM, John Ferlan wrote:
>
>
> On 12/20/2017 07:38 AM, Ján Tomko wrote:
>> On Wed, Dec 06, 2017 at 08:08:06AM -0500, John Ferlan wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1519130
>>>
>>> Commit id 'dc6
As CVE-2017-5715 described on
https://access.redhat.com/security/cve/cve-2017-5715,
libvirt under the influence yet, So what's coming next for this?
Signed-off-by: Wang King
--
2.8.3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jan 04, 2018 at 05:46:32 -0500, Yi Wang wrote:
> We can't clear vcpupin settings of XML once we did vcpupin
> command, this is not convenient under some condition such
> as migration.
>
> This patch introduces clear feature, which can clear vcpuin
> setting of XML.
>
> Signed-off-by: Yi W
Use a switch statement instead of if-else-if statements. Move the
command line building of the iothread attribute into the common path
as the SCSI controller attributes are already validated.
Signed-off-by: Marc Hartmayer
---
This patch fits well to this series as it was created during the
revie
On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan wrote:
> Modify the SCSI controller switch during command line building
> to account for all virDomainControllerModelSCSI types rather
> than using the default label.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_command.c | 7 +--
>
We can't clear vcpupin settings of XML once we did vcpupin
command, this is not convenient under some condition such
as migration.
This patch introduces clear feature, which can clear vcpuin
setting of XML.
Signed-off-by: Yi Wang
Signed-off-by: Xi Xu
---
include/libvirt/libvirt-domain.h | 1 +
On Tue, Dec 12, 2017 at 04:06 PM +0100, John Ferlan wrote:
> Move the checks that various attributes are not set on any controller
> other than SCSI controller using virtio-scsi model into the common
> controller validate checks.
You not only move the checks, but also add the call
'qemuDomainSetS
https://bugzilla.redhat.com/show_bug.cgi?id=1528502
So imagine you have /dev/blah symlink which points to /dev/sda.
You attach /dev/blah as disk to your domain. Libvirt correctly
creates the /dev/blah -> /dev/sda symlink in the qemu namespace.
However, then you detach the disk, change the symlink
On 12/28/2017 06:41 PM, Eduardo Habkost wrote:
> All calls to virDomainAuditCgroupPath() were passing 'rc == 0' as
> argument, when it was supposed to pass the 'rc' value directly.
>
> As a consequence, the audit events that were supposed to be
> logged (actual cgroup changes) were never being log
We don't try to right align the backslashes anymore.
Signed-off-by: Michal Privoznik
---
Pushed under trivial & build breaker rules.
tests/virstringtest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/virstringtest.c b/tests/virstringtest.c
index e8518ede1..1230
67 matches
Mail list logo
