Function qemuMonitorJSONBuildCPUModelInfoJSON builds Json of form
{"model": {"name": "IvyBridge", "props": {}}}
from pointer to qemuMonitorCPUModelInfo.
---
src/qemu/qemu_monitor_json.c | 49
1 file changed, 49 insertions(+)
diff --git a/src/qemu/qemu_
Implementation of libvirt functions to support the
QEMU query-cpu-model-baseline QMP command.
This is part of resolution of:
https://bugzilla.redhat.com/show_bug.cgi?id=1511999
Signed-off-by: Chris Venteicher
Chris Venteicher (3):
qemu_monitor_json: Populate CPUModelInfo struct from json
q
New function qemuMonitorJSONBuildCPUModelInfo created by extracting code
from existing function qemuMonitorJSONGetCPUModelExpansion to create a
reusable function for extracting cpu model info from json.
---
src/qemu/qemu_monitor_json.c | 82 ++--
1 file chan
Function qemuMonitorGetCPUModelBaseline exposed to carry out a QMP
query-cpu-model-baseline transaction with QEMU.
QEMU determines a baseline CPU Model from two input CPU Models to
complete the query-cpu-model-baseline transaction.
---
src/qemu/qemu_monitor.c | 16 +
src/qemu
When user-namespace is enabled we are not allowed
to mount block/NBD devices.
Instead, mount /dev/nbdX to /run/libvirt/lxc/.root
and set:
fs->src->path = /run/libvirt/lxc/.root
fs->type = VIR_DOMAIN_FS_TYPE_MOUNT
---
src/lxc/lxc_container.c | 53 -
There is no functional change in this patch.
It only moves virLXCControllerAppendNBDPids above
virLXCControllerSetupNBDDeviceFS.
---
src/lxc/lxc_controller.c | 96
1 file changed, 49 insertions(+), 47 deletions(-)
diff --git a/src/lxc/lxc_controll
Problem background
--
The LXC driver has support for the filesystem types "file" and "block"
that allow a disk image to be mounted in the guest (container). [1]
However, when user-namespace is enabled (uid/gid mapping is used) the
mount of the root filesystem block device fails. [
---
src/lxc/lxc_container.c | 5 +
src/lxc/lxc_container.h | 4
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 532fd0be0..3b8cb966e 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -113,9 +113,6 @
Radostin Stoyanov (2):
lxc: s/subtreee/subtree/
lxc: Clean up /.oldroot
src/lxc/lxc_container.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.14.3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Signed-off-by: Radostin Stoyanov
---
src/lxc/lxc_container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 532fd0be0..665b93a0a 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -574,7 +574,7 @@ stat
Remove the /.oldroot directory after it has been unmounted (at the end
of lxcContainerSetupPivotRoot). Ignore errors silently.
Signed-off-by: Radostin Stoyanov
---
src/lxc/lxc_container.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
ind
On Wed, Apr 11, 2018 at 11:16:27AM -0400, John Ferlan wrote:
On 04/04/2018 04:13 AM, Peter Krempa wrote:
Allow testing of XML->argv conversion with using a real capability map
as used in the qemucapabilitiestest. This allows specifying the required
qemu version with the test rather than having
On Wed, Apr 11, 2018 at 04:41:50PM +0200, Jiri Denemark wrote:
When an always-on migration capability is supposed to be enabled on both
sides of migration, each side can only enable the feature if it is
enabled by the other side.
Thus the source host sends a list of supported migration capabilit
On Wed, Apr 11, 2018 at 04:41:51PM +0200, Jiri Denemark wrote:
The API is renamed as qemuMigrationParamsGetULL and it can be used with
any migration parameter stored as unsigned long long.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 9 -
src/qemu/qemu_migration_p
On Thu, Apr 12, 2018 at 11:10:34AM +0100, Daniel P. Berrangé wrote:
The last use of qemuMonitorMigrateToCommand was removed years back in
commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6
Author: Daniel P. Berrange
Date: Fri Nov 6 16:50:26 2015 +
qemu: assume support for all migratio
On Mon, Apr 09, 2018 at 08:34:06AM +0200, Christian Ehrhardt wrote:
> Due to mediation of socket and signal activity currently qemu:///session
> connections calling qemu_bridge_helper fail.
>
> We need the profile for libvirtd itself and the subprofile for
> qemu-bridge-helper to be able to talk/n
On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_capabilities.c | 1 +
> tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
> tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
> tests/qemucapabilitiesdat
On Thu, Apr 12, 2018 at 04:24:18PM +0100, Daniel P. Berrangé wrote:
The legacy xen driver is removed, so these ACLL hacks can be removed
s/LL/L/
too now.
Signed-off-by: Daniel P. Berrangé
---
src/check-aclrules.pl | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
This commit adds the node to the domain definition,
with the following semantics:
To pass standard input verbatim to the bootloader, set
some stdin
Multiline standard input can be set using a CDATA tag:
Standard input can be read from a file as follows:
Signed-off-by: Fabian F
This is also not fatal on other drivers.
Signed-off-by: Rainer Müller
---
src/vmware/vmware_conf.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
index 891d9a47f..b9f18e6ac 100644
--- a/src/vmware/vmware_conf.c
+++ b/
On 04/13/2018 05:47 AM, Nikolay Shirokovskiy wrote:
>>> However as we use chain of disabled bitmaps with one active bitmap on tip
>>> of the chain and qemu does not track their order we need to do it in
>>> libvirt.
>>>
>> Well, you seem to be tracking it in *qemu*, by using the name field.
>> Sh
13.04.2018 21:02, John Snow wrote:
On 04/13/2018 08:01 AM, Vladimir Sementsov-Ogievskiy wrote:
1. It looks unsafe to use nbd server + backup(sync=none) on same node,
synchronization is needed, like in block/replication, which uses
backup_wait_for_overlapping_requests, backup_cow_request_begin,
On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> This is a definition that holds information on SCSI persistent
> reservation settings. The XML part looks like this:
>
>
>
>
>
> If @managed is set to 'yes' then the is not parsed.
> This design was agreed on here:
>
> https://www.r
On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> The capability tracks if qemu has pr-manager-helper object. At
> this time don't actually detect if qemu has the capability. Not
> just yet. Only after the code is written the feature will be
> enabled.
>
> Signed-off-by: Michal Privoznik
> ---
On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> It's not easier, as we'll have to implement either separate of bitmaps
> concept of checkpoints, which will be based on bitmaps, and we'll have
> to negotiate and implement storing these objects to qcow2 and migrate
> them. Or we'll go
If we're running against a freshly-provisioned FreeBSD guest,
intltool won't have been installed yet and attempts to fix it
will fail. Make sure the file exists.
Signed-off-by: Andrea Bolognani
---
guests/tasks/kludges.yml | 8
1 file changed, 8 insertions(+)
diff --git a/guests/tasks/
On Wed, Apr 11, 2018 at 04:41:36PM +0200, Jiri Denemark wrote:
Since every parameter or capability set in qemuMigrationCompression
structure is now reflected in qemuMigrationParams structure, we can
replace qemuMigrationAnyCompressionDump with a new API which will work
on qemuMigrationParams.
Si
If a function is disposing virSomething it should be called
virSomethingDispose(). There are two offenders:
virCapabilitiesDispose(virCapsPtr) and
virDomainXMLOptionClassDispose(virDomainXMLOptionPtr).
Signed-off-by: Michal Privoznik
---
src/conf/capabilities.c | 6 +++---
src/conf/domain_conf.c
On Wed, Apr 11, 2018 at 04:41:43PM +0200, Jiri Denemark wrote:
We want to have all migration parameters parsing and formatting at one
place, i.e., in qemu_migration_params.c.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 68 +++-
src/qemu/qemu_mo
Whenever we declare a new object the first member of the struct
has to be virObject (or any other member of that family). Now, up
until now we did not care about the name of the struct member.
But lets unify it so that we can do some checks at compile time
later.
The unified name is 'parent'.
Sig
On Wed, Apr 11, 2018 at 04:41:38PM +0200, Jiri Denemark wrote:
Let's separate the code which queries QEMU for migration parameters from
qemuMigrationParamsCheck into a dedicated function.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 56 +++-
src
On Wed, Apr 11, 2018 at 04:41:46PM +0200, Jiri Denemark wrote:
Adding support for new migration parameter requires a lot of places to
be changed (most likely by copy&paste engineering): new variables to
store the parameter value and the associated *_set bool, JSON formatter
and parser, XML format
On Fri, Apr 13, 2018 at 10:08:34AM -0400, John Ferlan wrote:
>
>
> On 04/10/2018 10:49 AM, Ján Tomko wrote:
> > If QEMU uses a seccomp blacklist (since 2.11), -sandbox on
> > no longer tries to whitelist all the calls, but uses sets
> > of blacklists:
> > default (always blacklisted with -sandbox
On Wed, Apr 11, 2018 at 04:41:35PM +0200, Jiri Denemark wrote:
There's no need to call this API explicitly in the migration code. We
can pass the compression parameters to qemuMigrationParamsFromFlags and
it can internally call qemuMigrationParamsSetCompression to apply them
to the qemuMigrationP
On Wed, Apr 11, 2018 at 04:41:39PM +0200, Jiri Denemark wrote:
Use this internal structure only in qemu_migration_params.c and change
other non-test users to use the high level qemuMigrationParams struct.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 26 +++
13.04.2018 12:16, Nikolay Shirokovskiy wrote:
On 13.04.2018 00:16, John Snow wrote:
On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote:
Hi, all.
This is another RFC on pull backup API. This API
On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> diff --git a/guests/vars/projects/virt-viewer.yml
> b/guests/vars/projects/virt-viewer.yml
> index 6f3dbf9..85d1589 100644
> --- a/guests/vars/projects/virt-viewer.yml
> +++ b/guests/vars/projects/virt-viewer.yml
> @@ -6,5 +6,29 @@ pac
On 04/10/2018 10:49 AM, Ján Tomko wrote:
> QEMU commit 1bd6152 changed the default behavior from whitelist
> to blacklist and introduced a few sets of system calls.
>
> Use the 'elevateprivileges' parameter of -sandbox as a witness
> of this change.
>
> https://bugzilla.redhat.com/show_bug.cgi?
On Wed, Apr 11, 2018 at 04:41:34PM +0200, Jiri Denemark wrote:
The code really belongs to qemu_migration_params.c.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 140 -
src/qemu/qemu_migration.h| 19
src/qemu/qemu_migration_params.c |
On Wed, Apr 11, 2018 at 04:41:29PM +0200, Jiri Denemark wrote:
Most migration capabilities are directly connected with
virDomainMigrateFlags so qemuMigrationParamsFromFlags can automatically
enable them.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 30
On Wed, Apr 11, 2018 at 04:41:30PM +0200, Jiri Denemark wrote:
Propagate the calls up the stack to the point where
qemuMigrationParamsFromFlags is called. The end goal achieved in the
following few patches is to merge compression parameters into the
general migration parameters code.
Signed-off-
On Wed, Apr 11, 2018 at 04:41:23PM +0200, Jiri Denemark wrote:
Instead of checking each capability at the time we want to set it in
qemuMigrationParamsSetCapability we can check all of them at once in
qemuMigrationParamsCheck.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c|
On Fri, Apr 13, 2018 at 02:36:57PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> [...]
> > + mingw32-gtk-vnc:
> > +FedoraRawhide: mingw32-gtk-vnc
>
> This (and the corresponding mingw64 entry) will drag in the version
> of the library based on
On Fri, Apr 13, 2018 at 01:15:11PM +0200, Katerina Koukiou wrote:
> Changes from v2:
> Adjusted to reviews.
>
> Katerina Koukiou (20):
> Implement Setter for Autostart property for Domain interface
> Implement SchedulerType property for Domain Interface
> Implement MemoryStats for Domain Int
On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> > diff --git a/guests/vars/projects/libvirt-glib.yml
> > b/guests/vars/projects/libvirt-glib.yml
> > index 13a5128..bb21ae0 100644
> > --- a/guests/vars/projects/libvi
On Fri, Apr 13, 2018 at 01:15:29PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 25 +
> 2 files changed, 31 insertions(+)
[...]
> +static void
> +virtDBusDomainMigrateSet
On 13.04.2018 12:07, Daniel P. Berrangé wrote:
> On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote:
>> *Temporary snapshot API*
>>
>> In previous version it is called 'Fleece API' after qemu terms and I'll still
>> use BlockSnapshot prefix for commands as in previous RFC instea
On Wed, Apr 11, 2018 at 04:41:12PM +0200, Jiri Denemark wrote:
There's no real reason for qemuMigrationParamsEnableTLS to require the
callers to pass a valid virQEMUDriverConfigPtr, it can just call
virQEMUDriverGetConfig.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 10 +
On 04/13/2018 09:34 AM, Radostin Stoyanov wrote:
> Remove unnecessary virFileIsExecutable check after virFindFileInPath.
> Since commit 9ae992f, virFindFileInPath will reject non-executables.
>
> 9ae992f24353d6506f570fc9dd58355b165e4472
> virFindFileInPath: only find executable non-directory
>
>
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 36
2 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index dc1df26..98e2873 100644
--- a/data/or
On 04/12/2018 05:40 PM, Sukrit Bhatnagar wrote:
> Incremental patches do look better. Just to make sure I am on the right
> track, I have some queries.
>
> I have to apply the changes one function at a time, and these changes
> will be the same ones I made in the v2 and v3 patches, right?
yes,
On Wed, Apr 11, 2018 at 04:41:15PM +0200, Jiri Denemark wrote:
Our current monitor API forces the caller to call
migrate-set-capabilities QMP command for each capability separately,
which is quite suboptimal. Let's add a new API for setting all
capabilities at once.
Signed-off-by: Jiri Denemark
On Wed, Apr 11, 2018 at 04:41:16PM +0200, Jiri Denemark wrote:
Migration capabilities are closely related to migration parameters and
it makes sense to keep them in a single data structure. Similarly to
migration parameters the capabilities are all send to QEMU at once in
qemuMigrationParamsApply
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 28
2 files changed, 34 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 21eb162..eec9dcb 100644
--- a/data/org.libvir
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 26 ++
2 files changed, 32 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 838ebed..dc1df26 100644
--- a/data/org.libvirt.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 22 ++
test/test_domain.py | 1 +
3 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 243a978..21eb162
Move testing of [Get,Set]Vcpus to seperate test.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 26 ++
test/test_domain.py | 9 +++--
3 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/d
On Thu, Apr 12, 2018 at 04:33:00PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 26 ++
> 2 files changed, 32 insertions(+)
[...]
> +static void
> +virtDBusDomainSetMemory
On Wed, Apr 11, 2018 at 04:41:05PM +0200, Jiri Denemark wrote:
Currently, only job->phase is passed and both APIs will need to look at
more details about the job.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Review
On Wed, Apr 11, 2018 at 04:41:09PM +0200, Jiri Denemark wrote:
The new name is qemuMigrationParamsDisableTLS.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 4 ++--
src/qemu/qemu_migration_params.c | 6 +++---
src/qemu/qemu_migration_params.h | 4 ++--
3 files changed, 7 inser
On Wed, Apr 11, 2018 at 04:41:02PM +0200, Jiri Denemark wrote:
When connection to the client which controls a non-p2p migration gets
closed between Perform and Confirm phase, we don't know whether the
domain was successfully migrated or not. Thus, we have to leave the
domain paused and just clean
On Wed, Apr 11, 2018 at 04:41:08PM +0200, Jiri Denemark wrote:
The function checks whether QEMU supports TLS migration and stores the
original value of tls-creds parameter to priv->migTLSAlias. This is no
longer needed because we already have the original value stored in
priv->migParams.
Signed-
On Wed, Apr 11, 2018 at 04:41:03PM +0200, Jiri Denemark wrote:
Any job which touches migration parameters will first store their
original values (i.e., QEMU defaults) to qemuDomainJobObj to make it
easier to reset them back once the job finishes.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_d
On Wed, Apr 11, 2018 at 04:40:59PM +0200, Jiri Denemark wrote:
It's no longer used since we do not store the struct on a stack anymore.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 12 +---
src/qemu/qemu_migration_params.h | 3 ---
2 files changed, 1 insertion(+),
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 25 +
2 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 074dd62..c3c64fa 100644
--- a/data/org.libvirt.D
On 13.04.2018 02:53, John Snow wrote:
>>
> First a few facts about qemu dirty bitmaps.
>
> Bitmap can be either in active or disable state. In disabled state it
> does not
> get changed on guest writes. And oppositely in active state it tracks
> guest
> writes. This
On Thu, Apr 12, 2018 at 04:32:54PM +0200, Katerina Koukiou wrote:
> Move testing of [Get,Set]Vcpus to seperate test.
>
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 26 ++
> test/test_domain.py |
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 36
2 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 36167d8..243a978 100644
--- a/data/or
This method is not tested for now since the test driver
doesn't suport this API.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 25 +
2 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/
On 13/04/18 08:35, Michal Privoznik wrote:
> On 04/13/2018 08:01 AM, Radostin Stoyanov wrote:
>> Remove unnecessary virFileIsExecutable check after virFindFileInPath.
>> Since the commit 9ae992f virFindFileInPath will reject non-executables.
>>
>> 9ae992f24353d6506f570fc9dd58355b165e4472
>> virFind
On Wed, Apr 11, 2018 at 04:41:00PM +0200, Jiri Denemark wrote:
It provides just another view on some migration parameters so let's move
it close to them. The end goal is to merge compression parameters with
the rest of migration parameters since it doesn't make any sense to
handle them differentl
On Thu, Apr 12, 2018 at 04:32:49PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 25 +
> 2 files changed, 31 insertions(+)
[...]
> +static void
> +virtDBusDomainMigrateSet
On Wed, Apr 11, 2018 at 04:40:58PM +0200, Jiri Denemark wrote:
It will get a bit more complicated soon and storing it on a stack with
{0} initializer will no longer work. We need a proper constructor.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 20 +++--
src/q
On 13.04.2018 03:04, John Snow wrote:
>
>
> On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
>>
>> I propose, not to say that bitmap represents a checkpoint. It is simpler
>> to say (and it reflects the reality) that bitmap is a difference between
>> two consecutive checkpoints. And
On Thu, Apr 12, 2018 at 04:32:44PM +0200, Katerina Koukiou wrote:
> This method is not tested for now since the test driver
> doesn't suport this API.
>
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 25 +
Incremental patches do look better. Just to make sure I am on the right
track, I have some queries.
I have to apply the changes one function at a time, and these changes will
be the same ones I made in the v2 and v3 patches, right?
If that is the case, do I need the next patch to be v4 or can the
On 04/12/2018 08:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> 1. It looks unsafe to use nbd server + backup(sync=none) on same node,
> synchronization is needed, like in block/replication, which uses
> backup_wait_for_overlapping_requests, backup_cow_request_begin,
> backup_cow_request_end. We ha
On 04/04/2018 12:29 PM, Jai Singh Rana wrote:
> In case of pci SR-IOV device with interface_type as 'hostdev', return
> network stats if it has a VF Representor interface on host for
> pci SR-IOV device according to switchdev model.
> ---
> v3 includes changes based on v2's[1] feedback and sugges
https://bugzilla.redhat.com/show_bug.cgi?id=1480668
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f864350bd5..67350719aa 100644
--- a/src/qemu/qemu_command.c
+++ b/src/
Signed-off-by: Michal Privoznik
---
.../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 20 +-
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 +-
.../caps_2.10.0.aarch64.replies| 30 +-
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 2 +-
.../qemucapabilit
This capability tracks if memory-backend-file has discard-data
attribute or not.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 17 +
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 18 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/q
The code is written generic enough to be reused. Move it into a
separate function.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 62 ++--
1 file changed, 42 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/sr
Instead of cramming the dependencies that we need for a MinGW
build of libvirt along with those we need for a native build,
create a new project for the former.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-fedora-rawhide/main.yml | 1 +
guests/vars/projects/libvirt+mingw.yml
Qemu introduced this in 11ae6ed8affdd13. A small refactor is needed
however.
Michal Privoznik (7):
qemu: Rename qemuMonitorGetObjectProps to qemuMonitorGetDeviceProps
qemu_capabilities: s/ObjectProps/DeviceProps/g
qemu_capabilities: Separate out device props fetching
qemu_monitor: Introduc
Changes from [v1]:
* instead of dropping CentOS 6 altogether, simply stop building
pretty much all projects on it;
* introduce a new job type specifically for whatever little
stuff we need to ensure still works on CentOS 6;
* the end result is still a nice cleanup thanks to not rep
On 04/04/2018 10:45 AM, Viktor Mihajlovski wrote:
> Extended the json monitor test program with support for query-cpus-fast
> and added a sample file set for x86 data obtained using the it.
> Also extend the test program to recognize the halted property.
This last sentence involves code that pro
On 04/04/2018 10:45 AM, Viktor Mihajlovski wrote:
> The QEMU monitor commmand query-cpus is deprecated starting
> with QEMU 2.12.0 because it can adversely affect the performance of
> a running virtual machine.
>
> This series enables libvirt to use the new query-cpus-fast interface
> if support
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 38 ++
2 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 0937cbb..5763a8a 100644
--- a/data/
On Thu, 2018-04-12 at 17:16 +0200, Ján Tomko wrote:
> On Thu, Apr 12, 2018 at 10:07:50AM +0200, Andrea Bolognani wrote:
> > On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
> > > Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used
> > > when QEMU_CAPS_NO_USER_CONFIG is unsupported.
The legacy xen driver is removed, so these ACLL hacks can be removed
too now.
Signed-off-by: Daniel P. Berrangé
---
src/check-aclrules.pl | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl
index 5b6c711dc8..3
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 5 +
src/domain.c| 35 +++
2 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 83e37bc..2e0339b 100644
--- a/data/org.
Move testing of [Get,Set]Vcpus to seperate test.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 26 ++
test/test_domain.py | 9 +++--
3 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/d
This method is not tested for now since the test driver
doesn't suport this API.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 25 +
2 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/
*Please accept our apologies if you receive multiple copies of this Call
for
PapersCALL
FOR PAPERS 13th Workshop on Virtualization in High-Performance Cloud
Computing (VHPC '18)held in conjunction with the International
Supercomp
Use the return value of virObjectRef directly. This way, it's easier
for another reader to identify the reason why the additional reference
is required.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/rpc/virnetserver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Hi!
> We'd generally expect to see a change to tests/qemuxml2argvtest.c for
> this. Either adding a new test data file, or updating existing data
> files if they would cover it.
Sorry! Updated my patch. Have I still missed something?
I checked the valgrind tests, but they don't fail because of my
Historically we have relied on autopoint/gettextize to install a
standard po/Makefile.in.in. There is very limited scope for customizing
this and it also causes a bunch of extra stuff to be pulled into
configure.ac which potentially clashes with gnulib. Writing make rules
for po file management is
Use virNetServerGetProgram() to determine the virNetServerProgram
instead of using hard coded global variables. This allows us to remove
the global variables @remoteProgram and @qemuProgram as they're now no
longer necessary.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
Note:
On 12.04.2018 07:14, John Snow wrote:
>
>
> On 04/11/2018 12:32 PM, Eric Blake wrote:
>> On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote:
>>> Hi, all.
>>>
>>>
On Thu, Apr 12, 2018 at 10:41:03AM +0200, Andrea Bolognani wrote:
On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
Implied by QEMU >= 1.2.0.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_capabilities.h | 2 +
1 - 100 of 176 matches
Mail list logo