Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 6:09 PM, Jim Fehlig wrote: > On 05/08/2018 03:22 AM, David Kiarie wrote: > >> >> >> On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig > jfeh...@suse.com>> wrote: >> >> On 05/07/2018 08:57 AM, David Kiarie wrote: >> >> >> >> On Mon, May 7, 2018 at 5:55 PM, David Kiarie

[libvirt] Question about verifying same uid:gid in src and dst for live migration

2018-05-08 Thread Fei Li
Hi, When I do live migration using virsh command line based on NFS shared storage between two systems having the same security mechanism and having the same kvm/qemu/libvirt version, I encounter the following error: debug : qemuMonitorJSONIOProcessLine:193 : Line [{"timestamp": {"seconds": 15

[libvirt] [PATCH 2/3] bhyve: add tests for wiring memory

2018-05-08 Thread Fabian Freyer
--- tests/bhyveargv2xmldata/bhyveargv2xml-wired.args | 7 + tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml| 19 tests/bhyveargv2xmltest.c | 1 + tests/bhyvexml2argvdata/bhyvexml2argv-wired.args | 10 ++ tests/bhyvexml2argvdata/bhyvexml2argv-

[libvirt] [PATCH 1/3] bhyve: add support for wiring memory

2018-05-08 Thread Fabian Freyer
The element will now pass the wired (-S) flag to the bhyve command. --- src/bhyve/bhyve_command.c | 3 +++ src/bhyve/bhyve_parse_command.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 9413ae5c1..e3f7ded7d 100644 --- a/sr

[libvirt] [PATCH 3/3] bhyve: document support for wiring guest memory

2018-05-08 Thread Fabian Freyer
--- docs/drvbhyve.html.in | 14 ++ docs/news.xml | 10 ++ 2 files changed, 24 insertions(+) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index bde8298a5..5b5513d3d 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -430,6 +430,20 @@ support

[libvirt] [PATCH 0/3] bhyve: allow locking memory

2018-05-08 Thread Fabian Freyer
This patch series adds support for locking guest memory to the bhyve driver using the following elements When specified, the -S flag is passed to the bhyve binary. Fabian Freyer (3): bhyve: add support for wiring memory bhyve: add tests for wiring memory bhyve: document su

Re: [libvirt] [PATCHv2] Deprecate QEMU_CAPS_NESTING

2018-05-08 Thread John Ferlan
On 05/07/2018 04:38 AM, Ján Tomko wrote: > Unused since commit . > > Signed-off-by: Ján Tomko > --- > v2: also delete the hasHwVirt variable as well as the whole 'svm' > checking > > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_command.c | 24 > 2 files

Re: [libvirt] [PATCH] rpc: fixing compilation error due to deprecated ssh_get_publickey().

2018-05-08 Thread John Ferlan
On 05/06/2018 03:15 PM, Julio Faracco wrote: > Well, > > Do we have a winner? :-) > > -- > Julio Cesar Faracco > sigh, top posting is not favored in technical groups. In any case, I kind of like Eric's suggestion and I just figured you'd end up coding it and posting it. John > 2018-05-04

Re: [libvirt] [PATCH v3 14/14] qemu: Add swtpm to emulator cgroup

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Add the external swtpm to the emulator cgroup so that upper limits of CPU > usage can be enforced on the emulated TPM. > > To enable this we need to have the swtpm write its process id (pid) into a > file. We then read it from the file to configure

Re: [libvirt] [PATCH v3 13/14] tpm: Add support for choosing emulation of a TPM 2

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > This patch extends the TPM's device XML with TPM 2 support. This only works > for the emulator type backend and looks as follows: > > > Perhaps this would be better as just version='2' since you're in a block? > > > The swtpm pr

Re: [libvirt] [PATCH v3 12/14] security: Label the external swtpm with SELinux labels

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > In this patch we label the swtpm process with SELinux labels. We give it the > same label as the QEMU process has. We label its state directory and files > as well. > > The file and process labels now look as follows: > > Directory: /var/lib/libvir

Re: [libvirt] [PATCH v3 11/14] tests: Add test cases for external swtpm TPM emulator

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > This patch adds extensions to existing test cases and specific test cases > for the tpm-emulator. > > Signed-off-by: Stefan Berger > --- > tests/qemuxml2argvdata/tpm-emulator.args | 27 +++ > tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH v3 10/14] qemu: Add support for external swtpm TPM emulator

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > This patch adds support for an external swtpm TPM emulator. The XML for > this type of TPM looks as follows: > > > > > > The XML will currently only start a TPM 1.2. > > Upon first start, libvirt will run `swtpm_setup`, which will simulate

Re: [libvirt] [PATCH v3 09/14] qemu: Implement a layer for external devices like tpm-emulator

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Implement a layer for starting and stopping of external devices. > The tpm-emulator is the only user of this layer. > > Signed-off-by: Stefan Berger > --- > src/qemu/Makefile.inc.am | 2 + > src/qemu/qemu_extdevice.c | 300 > ++

Re: [libvirt] [PATCH v3 08/14] qemu: Extend qemu_conf with tpm-emulator support

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Extend qemu_conf with user and group for running the tpm-emulator > and add directories to the configuration for the locations of the > log, state, and socket of the tpm-emulator. > > Signed-off-by: Stefan Berger > --- > src/qemu/libvirtd_qemu.aug

Re: [libvirt] [PATCH v3 07/14] util: Extend virtpm.c with tpm-emulator support

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Add functions for managing the storage of the external swtpm as well > as starting and stopping it. Also implement functions to use swtpm_setup, > which simulates the manufacturing of a TPM which includes creation of > certificates for the device. >

Re: [libvirt] [PATCH v3 06/14] security: Add DAC and SELinux security for tpm-emulator

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Extend the DAC and SELinux modules with support for the > tpm-emulator. > > Signed-off-by: Stefan Berger > --- > src/security/security_dac.c | 4 > src/security/security_selinux.c | 5 + > 2 files changed, 9 insertions(+) > > diff --

Re: [libvirt] [PATCH v3 05/14] util: Implement virFileChownFiles()

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Implement virFileChownFiles() which changes file ownership of all > files in a given directory. > > Signed-off-by: Stefan Berger > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c | 49 > ++

Re: [libvirt] [PATCH v3 04/14] qemu: Extend QEMU capabilities with 'tpm-emulator'

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Extend the QEMU capabilities with tpm-emulator support. > > Signed-off-by: Stefan Berger > --- > src/qemu/qemu_capabilities.c | 5 + > src/qemu/qemu_capabilities.h | 1 + > tests/qemucapabilitiesdata

Re: [libvirt] [PATCH v3 03/14] conf: Add support for external swtpm TPM emulator to domain XML

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > This patch adds support for an external swtpm TPM emulator. The XML for > this type of TPM looks as follows: > > > > > > The XML will currently only define a TPM 1.2. > > Extend the documentation. > > Add a test case testing the XML parse

Re: [libvirt] [PATCH v3 02/14] util: Implement virStringFilterLines()

2018-05-08 Thread John Ferlan
On 05/04/2018 04:21 PM, Stefan Berger wrote: > Implement virStringFilterLines() that takes as an input a buffer with text > and extracts each line that contains a given needle. The size of each re- > turned line can be restricted and if it is restricted '...' will automa- > tically be appended. >

Re: [libvirt] [PATCH v3 01/14] util: implement virFileReadOffsetQuiet()

2018-05-08 Thread John Ferlan
$SUBJ: "Implement" On 05/04/2018 04:21 PM, Stefan Berger wrote: > Implement virFileReadOffsetQuiet() that reads a given maximum number > of bytes into a buffer that will be allocated. The reading starts > from a given offset. > > Signed-off-by: Stefan Berger > --- > src/libvirt_private.syms |

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

2018-05-08 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote: > Up until now, we had to skip it on FreeBSD due to some > portability issues in the test suite, but as of libvirt > commit 0b86e23d2569 they've all been fixed. Unfortunately it appears that gnulib has a non-deterministic failure in

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread Jim Fehlig
On 05/08/2018 03:22 AM, David Kiarie wrote: On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig > wrote: On 05/07/2018 08:57 AM, David Kiarie wrote: On Mon, May 7, 2018 at 5:55 PM, David Kiarie mailto:davidkiar...@gmail.com>

[libvirt] Question about using cpu mode "host-model" while providing a cpu model name

2018-05-08 Thread Collin Walling
Hi I have noticed something that may be misconstrued regarding the libvirt domain xml format for defining a cpu model. There seems to be a misalignment where the libvirt documentation states something that is not supported, but libvirt itself gives no clear indication of such. This is regarding

[libvirt] [PATCH v2 06/12] vshReadlineParse: Ignore vshReadlineOptionsGenerator for VSH_OT_ARGV options

2018-05-08 Thread Lin Ma
Currently the VSH_OT_ARGV options don't support complete, But some of VSH_OT_ARGV options are gonna support complete in upcoming patches. Once applied the upcoming completion patches for VSH_OT_ARGV options, If we don't ignore VSH_OT_ARGV here, The vshReadlineOptionsGenerator will be called, Hence

[libvirt] [PATCH v2 08/12] virsh: Apply macro for current VSH_OT_ARGV "domain" options

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 071619d0e3..fa93f3a312 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@

[libvirt] [PATCH v2 09/12] vshReadlineOptionsGenerator: Add already provided VSH_OT_ARGV options to list

2018-05-08 Thread Lin Ma
It's helpful for users while they type certain kind of VSH_OT_ARGV options. e.g. $ virsh domstats --domain sles12sp3 --d Signed-off-by: Lin Ma --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index e45bb0d825..279d1b56e6 100644 --- a/

[libvirt] [PATCH v2 12/12] virsh: Add event name completion to 'event' command

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-completer.c | 37 + tools/virsh-completer.h | 3 +++ tools/virsh-domain.c| 1 + 3 files changed, 41 insertions(+) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index e3b8234b41..ddf7b17caf 100644 ---

[libvirt] [PATCH v2 10/12] virsh: Enable multiple --event flags to 'event' command

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-domain.c | 107 +++ 1 file changed, 57 insertions(+), 50 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 30da953446..36278ebc1c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-do

[libvirt] [PATCH v2 11/12] virsh: add helper for returning event name string

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-util.c | 60 ++ tools/virsh-util.h | 3 +++ 2 files changed, 63 insertions(+) diff --git a/tools/virsh-util.c b/tools/virsh-util.c index 44be3ad64b..686f9aef98 100644 --- a/tools/virsh-util.c +++ b/tools/v

[libvirt] [PATCH v2 03/12] virsh: Conditionally Ignore the first entry in list of completions

2018-05-08 Thread Lin Ma
The first entry in the returned array is the substitution for TEXT. It causes unnecessary output if other commands or options share the same prefix, e.g. $ virsh des des desc destroy or $ virsh domblklist --d --d--details --domain This patch fixes the above issue. Signed-off-

[libvirt] [PATCH v2 05/12] virsh: Apply macro for current VSH_OT_STRING "domain" options

2018-05-08 Thread Lin Ma
These VSH_OT_STRING "domain" options support domain name completion now. Signed-off-by: Lin Ma --- tools/virsh-domain.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ace5c02871..30da953446 100644 --- a/to

[libvirt] [PATCH v2 01/12] virsh: Move the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h

2018-05-08 Thread Lin Ma
centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h to avoid unnecessary duplicated definition Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 3 --- tools/virsh-domain.c | 3 --- tools/virsh-snapshot.c | 3 --- tools/virsh.h| 3 +++

[libvirt] [PATCH v2 00/12] Some fixes and improvement for virsh completion in non interactive mode

2018-05-08 Thread Lin Ma
This patch series is about some fixes and improvement for virsh completion in non interactive mode. Some of them probably don't make sense, I sent them out for suggestions. v2->v1: * Add a new patch for centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h * rename the help

[libvirt] [PATCH v2 04/12] virsh: Create macros for VSH_OT_STRING "domain" option

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/virsh.h b/tools/virsh.h index 9e717ef574..b1b641bc41 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -110,6 +110,17 @@ .help = _helpstr \ } +# define VIRSH_COMMON_OPT_DOMA

[libvirt] [PATCH v2 07/12] virsh: Create macros for VSH_OT_ARGV "domain" option

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh.h | 12 1 file changed, 12 insertions(+) diff --git a/tools/virsh.h b/tools/virsh.h index b1b641bc41..4353ff46d4 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -121,6 +121,18 @@ #define VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(cflags) \ V

[libvirt] [PATCH v2 02/12] virsh: Add domain name completion to 'migrate-postcopy' command

2018-05-08 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-domain.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index aa11a81638..ace5c02871 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11213,11 +11213,7 @@ static const vshCm

Re: [libvirt] [PATCH] qemu: add sdl opengl support

2018-05-08 Thread Maciej Wolny
On 04/05/18 00:08, John Ferlan wrote: > BTW: Since your patches add a capability - I would have expected a > change to add a flag to one (or more) of the > tests/qemucapabilitiesdata/caps_*.xml files, but none are modified. So > that means that the feature may not be introspectable, perhaps it's

Re: [libvirt] [PATCH 0/3] spec: drop deprecated el5 bits

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 09:53:22AM -0400, Cole Robinson wrote: > 2 patches from a Fedora contributor, 1 from me, dropping spec bits > that aren't required on el6 and later builds > > Cole Robinson (1): > spec: Remove Group: tags > > Igor Gnatenko (2): > spec: Remove BuildRoot definition > s

[libvirt] [PATCH 2/3] spec: Remove %clean section

2018-05-08 Thread Cole Robinson
From: Igor Gnatenko None of currently supported distributions need that. Last one was EL5 which is EOL for a while. Signed-off-by: Igor Gnatenko Signed-off-by: Cole Robinson --- libvirt.spec.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b629e

[libvirt] [PATCH 0/3] spec: drop deprecated el5 bits

2018-05-08 Thread Cole Robinson
2 patches from a Fedora contributor, 1 from me, dropping spec bits that aren't required on el6 and later builds Cole Robinson (1): spec: Remove Group: tags Igor Gnatenko (2): spec: Remove BuildRoot definition spec: Remove %clean section libvirt.spec.in | 45 ---

[libvirt] [PATCH 3/3] spec: Remove Group: tags

2018-05-08 Thread Cole Robinson
It's only required on el5 which we don't support anymore. Everywhere else it's not used for anything useful https://fedoraproject.org/wiki/RPMGroups Signed-off-by: Cole Robinson --- libvirt.spec.in | 41 - 1 file changed, 41 deletions(-) diff --git a/lib

[libvirt] [PATCH 1/3] spec: Remove BuildRoot definition

2018-05-08 Thread Cole Robinson
From: Igor Gnatenko None of currently supported distributions need that. It was needed last for EL5 which is EOL now Signed-off-by: Igor Gnatenko Signed-off-by: Cole Robinson --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e261e25

[libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

2018-05-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ guests/vars/mappings.yml | 6 ++ guests/vars/projects/libosinfo+mingw.yml | 8 guests/vars/projects/osinfo-db-tools+mingw.yml | 10 ++ projects/

[libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

2018-05-08 Thread Daniel P . Berrangé
Currently all patches are simply sent to the main libvirt development mailing list. Sometimes individual developers are also CC'd but this is typically the exception. Libvirt does not follow a subsystem maintainer model, so there is no notion of owners for the different areas of code, but there ce

Re: [libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 3:45 PM, Daniel P. Berrangé wrote: > On Tue, May 08, 2018 at 03:40:00PM +0300, David Kiarie wrote: > > Remove my name and email from these files > > > > Signed-off-by: David Kiarie > > --- > > src/xenconfig/xen_xl.c | 1 - > > src/xenconfig/xen_xl.h | 1 - > > tests/xlcon

[libvirt] [PATCH 10/12] storage_util: Move @type into _virStorageBackendQemuImgInfo

2018-05-08 Thread John Ferlan
We're about to split up the code a bit more, so we'll need this to be in the local struct. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index bd8

[libvirt] [PATCH 11/12] storage_util: Introduce storageBackendCreateQemuImgSetInput

2018-05-08 Thread John Ferlan
Split up virStorageBackendCreateQemuImgCmdFromVol into two parts. It's too long anyway and virStorageBackendCreateQemuImgCmdFromVol should just handle the command line processing. NB: Requires changing info.* into info->* references. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 1

[libvirt] [PATCH 06/12] storage_util: Move secretPath generation

2018-05-08 Thread John Ferlan
Move generation of secretPath to storageBackendGenerateSecretData and simplify a bit since we know vol->target.encryption is set plus we have a local @enc. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[libvirt] [PATCH 04/12] storage_util: Rename virQEMUBuildLuksOpts

2018-05-08 Thread John Ferlan
Rename to storageBackendCreateQemuImgOpts - which is what it's doing. Signed-off-by: John Ferlan --- src/libvirt_private.syms | 2 +- src/storage/storage_util.c | 2 +- src/util/virqemu.c | 8 src/util/virqemu.h | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions

[libvirt] [PATCH 12/12] storage_util: Introduce storageBackendDoCreateQemuImg

2018-05-08 Thread John Ferlan
Extract out command line setup and run from storageBackendCreateQemuImg as we'll need to run it twice soon. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_ut

[libvirt] [PATCH 03/12] storage_util: Remove unnecessary check

2018-05-08 Thread John Ferlan
Commit id 'a48c71411' altered the logic a bit and didn't remove an unnecessary check as info.encryption is true when vol->target.encryption != NULL, so if we enter the if segment with info.format == VIR_STORAGE_FILE_RAW && vol->target.encryption != NULL, then there's no way info.encryption could be

[libvirt] [PATCH 07/12] storage_util: Remove luks distinction from secret path and alias

2018-05-08 Thread John Ferlan
Remove the "luks" distinction as the code is about to become more generic and be able to support qcow encryption as well. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_util.c b/src/stor

[libvirt] [PATCH 09/12] storage_util: Split preallocate set in storageBackendCreateQemuImgOpts

2018-05-08 Thread John Ferlan
The only way preallocate could be set is if the info->format was not RAW (see storageBackendCreateQemuImgSetBacking), so let's just extract it from the if/else surrounding the application of the encryption options. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 13 +++-- 1 f

[libvirt] [PATCH 08/12] storage_util: Split backing_fmt set in storageBackendCreateQemuImgOpts

2018-05-08 Thread John Ferlan
The only way backing_fmts could be set is if the info->format was not RAW (see storageBackendCreateQemuImgSetBacking), so let's just extract it from the if/else surrounding the application of the encryption options. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 7 --- 1 file ch

[libvirt] [PATCH 01/12] storage_util: Some code cleanup

2018-05-08 Thread John Ferlan
Perform some code cleanup in areas that are about to be altered. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index bc048e3dff..4fddbf3f9e 100644 --- a/s

[libvirt] [PATCH 02/12] storage_util: Cleanup usage of target.encryption

2018-05-08 Thread John Ferlan
Remove the != NULL checks, use !! for setting info.encryption. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 4fddbf3f9e..cc1f6e7086 10

[libvirt] [PATCH 00/12] Various storage_util adjustments

2018-05-08 Thread John Ferlan
Essentially fallout and preparatory steps needed in order to alter the code to allow using qemu-img for creation of qcow[2] encrypted volume. The following series: https://www.redhat.com/archives/libvir-list/2018-April/msg01578.html is the impetus for these changes. What will follow once more t

[libvirt] [PATCH 05/12] storage_util: Generate the qcow secret earlier

2018-05-08 Thread John Ferlan
Rather than having storageBackendCreateQemuImgCheckEncryption perform the virStorageGenerateQcowEncryption, let's just do that earlier during storageBackendCreateQemuImg so that the check helper is just a check helper rather doing something different based on whether the format is qcow[2] or raw ba

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 03:42:27PM +0300, David Kiarie wrote: > On Tue, May 8, 2018 at 2:21 PM, Daniel P. Berrangé > wrote: > > > On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa > > wrote: > > > > > > > On Sat, May 05, 2018 at 12:

Re: [libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 03:40:00PM +0300, David Kiarie wrote: > Remove my name and email from these files > > Signed-off-by: David Kiarie > --- > src/xenconfig/xen_xl.c | 1 - > src/xenconfig/xen_xl.h | 1 - > tests/xlconfigtest.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/src/

[libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread David Kiarie
Remove my name and email from these files Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 1 - src/xenconfig/xen_xl.h | 1 - tests/xlconfigtest.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 35d52f8a..f0d9177c 100644 --- a/

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 2:21 PM, Daniel P. Berrangé wrote: > On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa > wrote: > > > > > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > > > On Sat, May 5, 2018 at 12:15 PM, Davi

[libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
Replace references to my name and email with a pseudonym Signed-off-by: David Kiarie --- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xl.h | 2 +- tests/xlconfigtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c ind

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

2018-05-08 Thread Boris Fiuczynski
On 05/07/2018 01:51 PM, John Ferlan wrote: [...] Someone may also want to consider creating a s390 specific version of what Peter did for x86_64 for VIR_TEST_CAPS_LATEST in order to then have/use the "latest" capabilities instead of adding bits to xml2argv tests. I'm curious why the xml2xml tes

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread Daniel P . Berrangé
On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa wrote: > > > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > > On Sat, May 5, 2018 at 12:15 PM, David Kiarie > > > wrote: > > > > > > > Replace references to my name and

Re: [libvirt] [PATCH] qemu: add sdl opengl support

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 12:12:42PM +0100, Maciej Wolny wrote: > On 02/05/18 11:54, Daniel P. Berrangé wrote: > > On Wed, May 02, 2018 at 11:48:24AM +0100, Maciej Wolny wrote: > >> On 02/05/18 08:13, Daniel P. Berrangé wrote: > >>> On Tue, May 01, 2018 at 08:22:45PM +0100, Maciej Wolny wrote: >

Re: [libvirt] [PATCH] qemu: add sdl opengl support

2018-05-08 Thread Maciej Wolny
On 02/05/18 11:54, Daniel P. Berrangé wrote: > On Wed, May 02, 2018 at 11:48:24AM +0100, Maciej Wolny wrote: >> On 02/05/18 08:13, Daniel P. Berrangé wrote: >>> On Tue, May 01, 2018 at 08:22:45PM +0100, Maciej Wolny wrote: Add SDL graphics gl attribute, modify the domain XML schema, add a

Re: [libvirt] unix_sock_dir for virtlogd

2018-05-08 Thread Martin Kletzander
On Fri, May 04, 2018 at 03:07:41AM +0300, Mathieu Tarral wrote: Hi, thanks for your reply Martin, 2018-05-04 1:44 GMT+03:00 Martin Kletzander : On Thu, May 03, 2018 at 11:03:48PM +0300, Mathieu Tarral wrote: Hi ! I'm trying to run libvirtd from git, and the daemon is starting now, but when

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 12:22 PM, David Kiarie wrote: > > > On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig wrote: > >> On 05/07/2018 08:57 AM, David Kiarie wrote: >> >>> >>> >>> On Mon, May 7, 2018 at 5:55 PM, David Kiarie >> > wrote: >>> >>> >>> >>> On Mon, May 7,

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread David Kiarie
On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig wrote: > On 05/07/2018 08:57 AM, David Kiarie wrote: > >> >> >> On Mon, May 7, 2018 at 5:55 PM, David Kiarie > > wrote: >> >> >> >> On Mon, May 7, 2018 at 10:29 AM, Peter Krempa > > wrote: