Per-domain log files were introduced in commit a30b08b7179. The FILE
objects associated with these log files are stored in a hash table
using domid as a key. When a domain is shutdown, destroyed, or
otherwise powered-off, the FILE object is removed from the hash table,
where the free function will
On 05/17/2018 03:28 PM, Jiri Denemark wrote:
> On Wed, May 09, 2018 at 13:36:55 +0200, Halil Pasic wrote:
>>
>>
>> On 05/09/2018 12:41 PM, Jiri Denemark wrote:
>>> On Tue, May 08, 2018 at 10:44:22 -0400, Collin Walling wrote:
Hi
I have noticed something that may be misconstrued regar
https://bugzilla.redhat.com/show_bug.cgi?id=1544869
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 8 -
docs/schemas/domaincommon.rng | 5 +++
src/qemu/qemu_command.c| 5 +++
src/qemu/qemu_domain.c
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 1 +
tests/qemublocktestdata/xml2json/network-nbd-tls.json | 19 +++
tests/qemublocktestdata/xml2json/network-nbd-tls.xml | 18 ++
3 files changed, 38 insertions(+)
create mo
Signed-off-by: Peter Krempa
---
src/qemu/libvirtd_qemu.aug | 4
src/qemu/qemu.conf | 34 ++
src/qemu/qemu_conf.c | 15 +++
src/qemu/qemu_conf.h | 3 +++
src/qemu/test_libvirtd_qemu.aug.in | 2 +
v2:
- added qemu.conf knobs
- added docs
- fixed test case for changes in ACKed patches
This applies on top of my branch collecting all ACKed postings of
recent blockdev-related work. Current version can be fetched by:
git fetch git://pipo.sk/pipo/libvirt.git blockdev-staging
Peter Krempa (3):
On Thu, May 31, 2018 at 19:30:25 +0200, Peter Krempa wrote:
> Add code that will handle the managed persistent reservations object
> separately from the unmanaged one. There is only one managed object so
> handling it with disks is awkward and does not scale well when backing
> chains come into vie
With blockdev support we will need to introspect whether any of the
backing chain members requires PR rather just one of them. Add a helper
and reuse it in virDomainDefHasManagedPR.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c| 2 +-
src/libvirt_private.syms | 1 +
src/util/virs
Keep the handling of the singleton managed pr-manager-helper object
separate from the unmanaged ones which are instantiated
one-per-disk-source.
This applies on top of my branch collecting all ACKed postings of
recent blockdev-related work. Current version can be fetched by:
git fetch git://pipo.
Add code that will handle the managed persistent reservations object
separately from the unmanaged one. There is only one managed object so
handling it with disks is awkward and does not scale well when backing
chains come into view.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c
Everything is contained in the virStorageSourceStructure.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 12 +---
src/qemu/qemu_command.h | 2 +-
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu
Also since we don't do any conditional formatting, fix the comment for
the function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 22 +++---
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 5 -
3 files changed, 16 insertions(+), 14 deletions(-)
diff
Disks are client-only so we don't need to have this variable. We also
always pass false for 'isListen' to qemuBuildTLSx509BackendProps for all
disk-related code-paths.
---
This applies on top of my branch collecting all ACKed postings of
recent blockdev-related work. Current version can be fetched
On Thu, May 31, 2018 at 05:16:51PM +0200, Jiri Denemark wrote:
The python bindings for this API cannot be generated because are
generator is not capable of handling string arrays (char **) parameters.
https://bugzilla.redhat.com/show_bug.cgi?id=1584676
Signed-off-by: Jiri Denemark
---
generato
On 05/31/2018 08:14 AM, Martin Kletzander wrote:
> On Wed, May 30, 2018 at 12:00:26PM -0400, John Ferlan wrote:
>>
>>
>> On 05/21/2018 11:00 AM, Martin Kletzander wrote:
>>> TSEG (Top of Memory Segment) is one of many regions that SMM (System
>>> Management
>>> Mode) can occupy. This one, howev
The python bindings for this API cannot be generated because are
generator is not capable of handling string arrays (char **) parameters.
https://bugzilla.redhat.com/show_bug.cgi?id=1584676
Signed-off-by: Jiri Denemark
---
generator.py | 1 +
libvirt-override-api.xml | 11
On Wed, May 30, 2018 at 07:06:37PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/qemu/qemu_monitor.c | 34 --
src/qemu/qemu_monitor.h | 5 -
src/util/virqemu.c | 22 --
src/util/virqemu
On Wed, May 30, 2018 at 07:06:36PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
libvir-list mailing list
lib
On Wed, May 30, 2018 at 07:06:35PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 31 +++-
src/qemu/qemu_hotplug.c | 77
src/qemu/qemu_hotplug.h | 1 -
src/qemu/qemu_migration_para
On Wed, May 30, 2018 at 07:06:34PM +0200, Peter Krempa wrote:
Note that it's okay to pass NULL to qemuDomainDelTLSObjects in
qemuDomainAddTLSObjects as the tls-creds-x509 object was either not
created or qemu crashed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 29 +++
On Wed, May 30, 2018 at 07:06:33PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 53 -
src/qemu/qemu_hotplug.c | 8 +---
2 files changed, 23 insertions(+), 38 deletions(-)
Reviewed-by: Ján Tomko
Jano
On Thu, May 31, 2018 at 09:45:04AM -0400, John Ferlan wrote:
On 05/31/2018 03:24 AM, Martin Kletzander wrote:
On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
This is way too sparse.
I can't really think of what to say here that is not already mentioned
in the
documentation or
On 05/31/2018 02:30 PM, Filip Alac wrote:
>
> Filip Alac (4):
> virutil: Introduce virHostHasIOMMU
> qemu: hostdev: Refactor code
> capabilities: Extend capabilities with iommu_support
> docs: news: Explain iommu_support improvement
>
> docs/news.xml | 8
On 05/31/2018 02:30 PM, Filip Alac wrote:
> ---
> src/conf/capabilities.c | 6 ++
> src/conf/capabilities.h | 3 +++
> src/util/virutil.c | 28
> src/util/virutil.h | 2 ++
> 4 files changed, 39 insertions(+)
It would be better if you'd merge this and
On 05/31/2018 02:30 PM, Filip Alac wrote:
> Make qemuHostdevHostSupportsPassthroughVFIO use
> virHostHasIOMMU.
>
> ---
> src/libvirt_private.syms | 2 ++
> src/qemu/qemu_hostdev.c | 29 -
> 2 files changed, 6 insertions(+), 25 deletions(-)
>
> diff --git a/src/libvi
On Wed, May 30, 2018 at 07:06:32PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 76 ++---
src/qemu/qemu_command.h | 2 +-
src/qemu/qemu_hotplug.c | 8 ++
3 files changed, 43 insertions(+), 43 deletions(-)
R
On Wed, May 30, 2018 at 07:06:31PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 61 +++--
src/qemu/qemu_command.h | 1 -
src/qemu/qemu_hotplug.c | 15 +++-
3 files changed, 27 insertions(+), 50 deletions(-)
On Wed, May 30, 2018 at 07:06:28PM +0200, Peter Krempa wrote:
Use the new monitor command internal API to allow wrapping of the object
name and alias into the JSON props so that they don't have to be passed
out of band.
The new API also takes a double pointer so that it can be cleared when
the v
On Wed, May 30, 2018 at 07:06:29PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virqemu.c | 40
src/util/virqemu.h | 3 +++
3 files changed, 40 insertions(+), 4 deletions(-)
Reviewed-by:
On Wed, May 30, 2018 at 07:06:30PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 30 ++
src/qemu/qemu_hotplug.c | 19 +++
2 files changed, 17 insertions(+), 32 deletions(-)
Reviewed-by: Ján Tomko
Jano
signatu
On Wed, May 30, 2018 at 07:06:26PM +0200, Peter Krempa wrote:
The function adds the object of a certain type. Change the name so that
we make room for the generic function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_hotplug.c | 50 -
On Wed, May 30, 2018 at 07:06:27PM +0200, Peter Krempa wrote:
s/virQEMUBuildObjectCommandlineFromJSON/virQEMUBuildObjectCommandlineFromJSONType/
The function adds the object of a certain type. Change the name so that
we make room for the generic function.
Signed-off-by: Peter Krempa
---
src/li
On 05/31/2018 03:26 PM, Peter Krempa wrote:
> In commit 8bebb2b735d I've refactored how the detach of disk with a
> managed persistent reservations object is handled. After the commit if
> any disk with a managed PR object would be removed libvirt would also
> attempt to remove the shared 'pr-manag
On Thu, May 31, 2018 at 02:22:05PM +0200, Martin Kletzander wrote:
> On Thu, May 31, 2018 at 10:52:08AM +0200, Pavel Hrdina wrote:
> > On Thu, May 31, 2018 at 10:09:46AM +0200, Martin Kletzander wrote:
> > > On Thu, May 31, 2018 at 08:45:39AM +0200, Pavel Hrdina wrote:
> > > > On Wed, May 30, 2018
On 05/31/2018 03:24 AM, Martin Kletzander wrote:
> On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
>>
>> This is way too sparse.
>>
>
> I can't really think of what to say here that is not already mentioned
> in the
> documentation or self-explanatory in the code. But maybe only I
On Thu, May 31, 2018 at 03:12:17PM +0200, Pavel Hrdina wrote:
> On Thu, May 31, 2018 at 02:50:31PM +0200, Erik Skultety wrote:
> > On Wed, May 30, 2018 at 02:30:04AM +0530, Sukrit Bhatnagar wrote:
> > > New macros are added to src/util/viralloc.h which help in
> > > adding cleanup attribute to vari
In commit 8bebb2b735d I've refactored how the detach of disk with a
managed persistent reservations object is handled. After the commit if
any disk with a managed PR object would be removed libvirt would also
attempt to remove the shared 'pr-manager-helper' object potentially used
by other disks.
On Thu, May 31, 2018 at 02:50:31PM +0200, Erik Skultety wrote:
> On Wed, May 30, 2018 at 02:30:04AM +0530, Sukrit Bhatnagar wrote:
> > New macros are added to src/util/viralloc.h which help in
> > adding cleanup attribute to variable declarations.
> >
> > Signed-off-by: Sukrit Bhatnagar
> > ---
>
On Wed, May 30, 2018 at 02:30:07AM +0530, Sukrit Bhatnagar wrote:
> Define a new cleanup function for virAuthConfigPtr in
> src/util/virauthconfig.h.
> Modifiy code to use cleanup macros where required.
s/fiy/fy
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/virauth.c | 66
> ++
On Wed, May 30, 2018 at 02:30:06AM +0530, Sukrit Bhatnagar wrote:
> Modifiy code to use cleanup macros where required.
s/fiy/fy
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/virauthconfig.c | 34 --
> 1 file changed, 12 insertions(+), 22 deletions(-)
>
> d
On Wed, May 30, 2018 at 02:30:05AM +0530, Sukrit Bhatnagar wrote:
> Modifiy code to use cleanup macros where required.
s/fiy/fy
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/virarptable.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/util/virarptab
On Wed, May 30, 2018 at 02:30:04AM +0530, Sukrit Bhatnagar wrote:
> New macros are added to src/util/viralloc.h which help in
> adding cleanup attribute to variable declarations.
>
> Signed-off-by: Sukrit Bhatnagar
> ---
> src/util/viralloc.h | 69
> ++
Make qemuHostdevHostSupportsPassthroughVFIO use
virHostHasIOMMU.
---
src/libvirt_private.syms | 2 ++
src/qemu/qemu_hostdev.c | 29 -
2 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 6001635916.
---
src/conf/capabilities.c | 6 ++
src/conf/capabilities.h | 3 +++
src/util/virutil.c | 28
src/util/virutil.h | 2 ++
4 files changed, 39 insertions(+)
diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index dd2fc77f91..ba19d5db8c 1006
---
docs/schemas/capability.rng | 13 +
src/conf/capabilities.c | 3 +++
src/qemu/qemu_capabilities.c| 3 +++
src/test/test_driver.c | 2 ++
tests/qemucaps2xmldata/all_1.6.0-1.xm
Filip Alac (4):
virutil: Introduce virHostHasIOMMU
qemu: hostdev: Refactor code
capabilities: Extend capabilities with iommu_support
docs: news: Explain iommu_support improvement
docs/news.xml | 8 +
docs/schemas/capability.rng | 13
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c45850f625..b5ac50f3a1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -123,6 +123,14 @@
secret-event, pool-event and nodedev-event)
+
+
+
On Thu, May 31, 2018 at 10:52:08AM +0200, Pavel Hrdina wrote:
On Thu, May 31, 2018 at 10:09:46AM +0200, Martin Kletzander wrote:
On Thu, May 31, 2018 at 08:45:39AM +0200, Pavel Hrdina wrote:
> On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
> >
> > This is way too sparse.
> >
> > On
On Wed, May 30, 2018 at 12:00:26PM -0400, John Ferlan wrote:
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
TSEG (Top of Memory Segment) is one of many regions that SMM (System Management
Mode) can occupy. This one, however is special, because a) most of the SMM code
lives in TSEG nowadays
I'm happy to announce the release of virt-bootstrap 1.1.0!
virt-bootstrap is a tool providing an easy way to setup the root file
system for libvirt-based containers.
The release can be downloaded from:
http://virt-manager.org/download/
This release includes:
- safe_untar: check for permissions
On Thu, May 31, 2018 at 12:11:36 +0200, Michal Privoznik wrote:
> When preparing qemuCaps for test cases the following is
> happening:
>
> qemuTestParseCapabilitiesArch() is called, which calls
> virQEMUCapsLoadCache() which in turn calls
> virQEMUCapsInitHostCPUModel() which sets qemuCaps->kvmCPU
On Thu, May 31, 2018 at 07:22:28 -0400, John Ferlan wrote:
>
>
> On 05/31/2018 02:18 AM, Peter Krempa wrote:
> > On Wed, May 30, 2018 at 16:14:31 -0400, John Ferlan wrote:
> >>
> >>
> >> On 05/23/2018 10:13 AM, Peter Krempa wrote:
> >>> The old qcow/qcow2 encryption format is so broken that qemu
On Thu, May 31, 2018 at 07:34:14 -0400, John Ferlan wrote:
> [...]
>
> >>> +qemuProcessPrepareStorageSourceTlsNbd(virStorageSourcePtr src,
> >>> + virQEMUDriverConfigPtr cfg,
> >>> + virQEMUCapsPtr qemuCaps)
> >>> +{
> >>> +
[...]
>>> +qemuProcessPrepareStorageSourceTlsNbd(virStorageSourcePtr src,
>>> + virQEMUDriverConfigPtr cfg,
>>> + virQEMUCapsPtr qemuCaps)
>>> +{
>>> +/* XXX: for NBD we don't have the qemu.conf knobs for private TLS env
On 05/31/2018 02:18 AM, Peter Krempa wrote:
> On Wed, May 30, 2018 at 16:14:31 -0400, John Ferlan wrote:
>>
>>
>> On 05/23/2018 10:13 AM, Peter Krempa wrote:
>>> The old qcow/qcow2 encryption format is so broken that qemu decided to
>>> drop it completely. This series forbids the use of such ima
On Thu, May 31, 2018 at 11:44:06AM +0200, Michal Privoznik wrote:
> On 05/31/2018 10:56 AM, Peter Krempa wrote:
> > On Thu, May 31, 2018 at 10:16:41 +0200, Michal Privoznik wrote:
> >> On 05/31/2018 10:05 AM, Erik Skultety wrote:
> >
> > [...]
> >
> >>> @@ -419,6 +420,13 @@ virDomainAuditHostdev(vi
On Thu, May 31, 2018 at 11:11:58AM +0200, Xiao Feng Ren wrote:
This patch fixes the USB input bus check, the bug was introduced by commit
317badb
Signed-off-by: Xiao Feng Ren
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
And pushed,
On 31/05/2018 10:19, Martin Kletzander wrote:
>>
>
> Oh, it definitely helps. And I always enjoy when someone explains
> low level details of something like you do, it makes me feel very
> smart after I read it =)
>
> ...something about the shoulders of giants and stuff...
>
> I'll fix this up
When preparing qemuCaps for test cases the following is
happening:
qemuTestParseCapabilitiesArch() is called, which calls
virQEMUCapsLoadCache() which in turn calls
virQEMUCapsInitHostCPUModel() which sets qemuCaps->kvmCPU and
qemuCaps->tcgCPU.
But then the code tries to update the capabilities:
On 05/31/2018 10:56 AM, Peter Krempa wrote:
> On Thu, May 31, 2018 at 10:16:41 +0200, Michal Privoznik wrote:
>> On 05/31/2018 10:05 AM, Erik Skultety wrote:
>
> [...]
>
>>> @@ -419,6 +420,13 @@ virDomainAuditHostdev(virDomainObjPtr vm,
>>> virDomainHostdevDefPtr hostdev,
>>> go
On 05/31/2018 10:57 AM, Jiri Denemark wrote:
> On Thu, May 31, 2018 at 10:06:37 +0200, Michal Privoznik wrote:
>> On 05/30/2018 06:57 PM, Peter Krempa wrote:
>>> On Wed, May 30, 2018 at 18:04:29 +0200, Michal Privoznik wrote:
While this leak happens in tests only, it is still worth fixing.
>>>
This patch fixes the USB input bus check, the bug was introduced by commit
317badb
Signed-off-by: Xiao Feng Ren
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 27e2bd50eb..e4d39c06e8 100644
---
On 5/31/2018 4:21 PM, Ján Tomko wrote:
On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
There's one explicit bug(introduced in commit:317badb) when checking
the bus of one input device is USB.
Let's fix it.
The fix looks good to me, but the explanation (which is not really a
On Thu, May 31, 2018 at 10:06:37 +0200, Michal Privoznik wrote:
> On 05/30/2018 06:57 PM, Peter Krempa wrote:
> > On Wed, May 30, 2018 at 18:04:29 +0200, Michal Privoznik wrote:
> >> While this leak happens in tests only, it is still worth fixing.
> >>
> >> ==12962== 2,035 (104 direct, 1,931 indire
On Thu, May 31, 2018 at 10:16:41 +0200, Michal Privoznik wrote:
> On 05/31/2018 10:05 AM, Erik Skultety wrote:
[...]
> > @@ -419,6 +420,13 @@ virDomainAuditHostdev(virDomainObjPtr vm,
> > virDomainHostdevDefPtr hostdev,
> > goto cleanup;
> > }
> > break
On Thu, May 31, 2018 at 10:09:46AM +0200, Martin Kletzander wrote:
> On Thu, May 31, 2018 at 08:45:39AM +0200, Pavel Hrdina wrote:
> > On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
> > >
> > > This is way too sparse.
> > >
> > > On 05/21/2018 11:00 AM, Martin Kletzander wrote:
> >
On Thu, May 31, 2018 at 10:16:41AM +0200, Michal Privoznik wrote:
> On 05/31/2018 10:05 AM, Erik Skultety wrote:
> > There was a missing enum for mdev causing a strange 'unknown device type'
> > warning when hot-plugging mdev.
> >
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1583927
>
On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
There's one explicit bug(introduced in commit:317badb) when checking the bus of
one input device is USB.
Let's fix it.
The fix looks good to me, but the explanation (which is not really and the
mention
of the commit that broke it
On Thu, May 31, 2018 at 09:33:54AM +0200, Laszlo Ersek wrote:
adding qemu-devel, Paolo and Gerd; comments below:
On 05/30/18 23:08, Martin Kletzander wrote:
On Wed, May 30, 2018 at 11:02:59AM -0400, John Ferlan wrote:
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
We are still hoping all
On 05/31/2018 10:05 AM, Erik Skultety wrote:
> There was a missing enum for mdev causing a strange 'unknown device type'
> warning when hot-plugging mdev.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1583927
>
> Signed-off-by: Erik Skultety
> ---
> src/conf/domain_audit.c | 13
On Thu, May 31, 2018 at 08:45:39AM +0200, Pavel Hrdina wrote:
On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
This is way too sparse.
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1469338
>
> Signed-off-by: Martin Kletzand
On Wed, May 30, 2018 at 12:55:19 -0300, Eduardo Habkost wrote:
> The main question that I'm still unable to answer is: when
> cpu_map.xml is still used? Does it affect libvirt behavior in
> any way when using a recent QEMU version?
Yes, it is still used. Mainly for reporting host CPU capabilities
On Thu, May 31, 2018 at 10:06:38 +0200, Michal Privoznik wrote:
> On 05/30/2018 06:46 PM, Peter Krempa wrote:
> > On Wed, May 30, 2018 at 18:04:28 +0200, Michal Privoznik wrote:
> >> There's no point in calling testInitQEMUCaps() (which sets
> >> info.qemuCaps) only to overwrite (and leak) it on th
On 05/30/2018 06:46 PM, Peter Krempa wrote:
> On Wed, May 30, 2018 at 18:04:28 +0200, Michal Privoznik wrote:
>> There's no point in calling testInitQEMUCaps() (which sets
>> info.qemuCaps) only to overwrite (and leak) it on the very next
>> line.
>>
>> ==12962== 296 (208 direct, 88 indirect) bytes
On 05/30/2018 06:57 PM, Peter Krempa wrote:
> On Wed, May 30, 2018 at 18:04:29 +0200, Michal Privoznik wrote:
>> While this leak happens in tests only, it is still worth fixing.
>>
>> ==12962== 2,035 (104 direct, 1,931 indirect) bytes in 1 blocks are
>> definitely lost in loss record 325 of 331
>>
There was a missing enum for mdev causing a strange 'unknown device type'
warning when hot-plugging mdev.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1583927
Signed-off-by: Erik Skultety
---
src/conf/domain_audit.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
On Wed, May 30, 2018 at 12:23:12PM -0400, John Ferlan wrote:
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c | 10 +++
src/qemu/qemu_capabilities.h | 2 +
.../caps_1.5.3.x86_64.replies
Signed-off-by: Xiao Feng Ren
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 27e2bd50eb..e4d39c06e8 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27878,7 +27878,7 @@ virDoma
There's one explicit bug(introduced in commit:317badb) when checking the bus of
one input device is USB.
Let's fix it.
Xiao Feng Ren (1):
Fixup USB input bus check
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.16.3
--
libvir-list mailing list
libvir-list
adding qemu-devel, Paolo and Gerd; comments below:
On 05/30/18 23:08, Martin Kletzander wrote:
> On Wed, May 30, 2018 at 11:02:59AM -0400, John Ferlan wrote:
>>
>>
>> On 05/21/2018 11:00 AM, Martin Kletzander wrote:
>>> We are still hoping all of such checks will be moved there and this
>>> is one
On Wed, May 30, 2018 at 04:00:32PM -0400, John Ferlan wrote:
This is way too sparse.
I can't really think of what to say here that is not already mentioned in the
documentation or self-explanatory in the code. But maybe only I see that as
self-explanatory. I'll write something up here.
On
On Thu, May 31, 2018 at 09:16:10 +0200, Michal Privoznik wrote:
> On 05/30/2018 06:46 PM, Peter Krempa wrote:
> > On Wed, May 30, 2018 at 18:04:27 +0200, Michal Privoznik wrote:
[...]
> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> >> index 27e2bd50eb..d8b4fbd6b0 100644
> >> -
On 05/30/2018 06:46 PM, Peter Krempa wrote:
> On Wed, May 30, 2018 at 18:04:27 +0200, Michal Privoznik wrote:
>> We need to free return value of virXPathString().
>>
>> ==12962== 37 bytes in 1 blocks are definitely lost in loss record 156 of 331
>> ==12962==at 0x4C2AF0F: malloc (vg_replace_mall
83 matches
Mail list logo
