On Thu, May 31, 2018 at 03:52:26PM +0200, Pavel Hrdina wrote:
On Thu, May 31, 2018 at 02:22:05PM +0200, Martin Kletzander wrote:
On Thu, May 31, 2018 at 10:52:08AM +0200, Pavel Hrdina wrote:
> On Thu, May 31, 2018 at 10:09:46AM +0200, Martin Kletzander wrote:
> > On Thu, May 31, 2018 at 08:45:39
On Fri, Jun 01, 2018 at 08:21:52AM -0400, John Ferlan wrote:
[...]
First thanks for taking the time to elaborate - it is helpful. Much
better than just stating no because I don't like it ;-).
And thanks for appreciating that =)
1. Add poll-max-ns property of each iothread:
https://www.re
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> PCI device hotunplug requires a running guest OS that cooperates with
> the ACPI unplug request. We must thus boot a real guest and wait for it
> to be ready before running the tests.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stum
On Fri, Jun 01, 2018 at 02:06:38PM +0200, Peter Krempa wrote:
Now that the old qcow2 encryption is removed we can safely delete all
this code since it's not needed any more.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 --
src/qemu/qemu_monitor.h | 4 --
src/qemu/
On Fri, Jun 01, 2018 at 02:06:37PM +0200, Peter Krempa wrote:
The encryption was buggy and qemu actually dropped it upstream. Forbid
it for all versions since it would cause other problems too.
Problems with the old encryption include weak crypto, corruption of
images with blockjobs and a lot of
On Fri, Jun 01, 2018 at 05:51:12PM +0200, Peter Krempa wrote:
Now that we have one place that sets up all disk-related objects to
qemuBlockStorageSourceAttachDataPtr we can easily reuse the data in the
command-line formatter by implementing a worker which will convert the
data.
A huge advantage
On Fri, Jun 01, 2018 at 05:51:11PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 106
1 file changed, 62 insertions(+), 44 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital sig
On Fri, Jun 01, 2018 at 05:51:10PM +0200, Peter Krempa wrote:
It prepares all disk so use the plural form.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital s
On Fri, Jun 01, 2018 at 05:51:09PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 9 +
src/qemu/qemu_block.h | 3 +++
src/qemu/qemu_command.c | 9 -
src/qemu/qemu_command.h | 3 ++-
src/qemu/qemu_hotplug.c | 37 +
On Fri, Jun 01, 2018 at 05:51:08PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 21 +
src/qemu/qemu_block.h | 6 ++
src/qemu/qemu_command.c | 13 +
src/qemu/qemu_hotplug.c | 37 -
4 fil
On Fri, Jun 01, 2018 at 05:51:07PM +0200, Peter Krempa wrote:
Introduce a new setup function for all the related configuration and
move the setup and attachment of the PR code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 8
src/qemu/qemu_block.h | 3 +++
src/qemu/qemu_c
On Fri, Jun 01, 2018 at 05:51:06PM +0200, Peter Krempa wrote:
Create a new "Prepare" function and move the drive add code into the new
helpers. This will eventually allow to simplify and unify the attaching
code for use with blockdev at the same time as providing compatibility
with older qemus.
On Fri, Jun 01, 2018 at 05:51:05PM +0200, Peter Krempa wrote:
Emphasize that it's for the 'drive' part of the disk.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_alias.c | 4 ++--
src/qemu/qemu_alias.h | 2 +-
src/qemu/qemu_block.c | 2 +-
src/qemu/qemu_command.c | 4 ++--
src/qem
On Fri, Jun 01, 2018 at 05:51:04PM +0200, Peter Krempa wrote:
Replace access via wrapper by direct call to monitor API.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Des
On Thu, May 31, 2018 at 07:59:35PM +0200, Peter Krempa wrote:
On Thu, May 31, 2018 at 19:30:25 +0200, Peter Krempa wrote:
Add code that will handle the managed persistent reservations object
separately from the unmanaged one. There is only one managed object so
handling it with disks is awkward
On Thu, May 31, 2018 at 07:30:24PM +0200, Peter Krempa wrote:
Also since we don't do any conditional formatting, fix the comment for
the function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 22 +++---
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 5 ++
On Thu, May 31, 2018 at 07:30:23PM +0200, Peter Krempa wrote:
Everything is contained in the virStorageSourceStructure.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 12 +---
src/qemu/qemu_command.h | 2 +-
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 7 insertions(+), 9 d
On Thu, May 31, 2018 at 07:30:22PM +0200, Peter Krempa wrote:
With blockdev support we will need to introspect whether any of the
backing chain members requires PR rather just one of them. Add a helper
and reuse it in virDomainDefHasManagedPR.
Signed-off-by: Peter Krempa
---
src/conf/domain_con
On Thu, May 31, 2018 at 08:51:14PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 1 +
tests/qemublocktestdata/xml2json/network-nbd-tls.json | 19 +++
tests/qemublocktestdata/xml2json/network-nbd-tls.xml | 18 +++
On Thu, May 31, 2018 at 08:51:13PM +0200, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1544869
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 8 -
docs/schemas/domaincommon.rng | 5 +++
src/qemu/qemu_command.c
On Thu, May 31, 2018 at 08:51:12PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/libvirtd_qemu.aug | 4
src/qemu/qemu.conf | 34 ++
src/qemu/qemu_conf.c | 15 +++
src/qemu/qemu_conf.h
On Tue, May 29, 2018 at 06:58:03PM +0800, bing@intel.com wrote:
From: Bing Niu
Extend current cachetune section to support memory bandwidth allocation.
Add a new cachetune element llc for memory allocation. As the example
below:
id--- on which last
On Tue, May 29, 2018 at 06:58:02PM +0800, bing@intel.com wrote:
From: Bing Niu
Add memory bandwidth allocation support basing on existing
virresctrl implementation. Two new structures virResctrlInfoMB
and virResctrlAllocMB are introduced.
virResctrlInfoMB is used to record host system MBA
On Thu, May 24, 2018 at 02:24:36PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
This patch adds new test cases for zPCI when 'uid' and 'fid'
are defined with different conditions in XML.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
Reviewed-by: Stefan Z
On Thu, May 24, 2018 at 02:24:31PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
Add new functions to generate zPCI command string and append it to
QEMU command line.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
---
src/qe
On Thu, May 24, 2018 at 02:24:30PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
The pci-root depends on zpci capability. So autogenerate pci-root if
zpci exists.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Reviewed-by: Bjoern Walk
---
src/qemu/q
On Thu, May 24, 2018 at 02:24:29PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
of PCI device on s390, is the significant capability. Only when zPCI
capability is existing, we consider QEMU supports PCI multibus properly.
On Thu, May 24, 2018 at 02:24:28PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
This patch introduces a new attribute PCI address extension flag
to deal with the extension PCI attributes such as 'uid' and 'fid'
on the S390 platform.
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
-
On Thu, May 24, 2018 at 02:24:26PM +0200, Xiao Feng Ren wrote:
From: Yi Min Zhao
Add zPCI definitions in preparation of extending the PCI address
with parameters uid (user-defined identifier) and fid (PCI function
identifier).
Signed-off-by: Yi Min Zhao
Reviewed-by: Boris Fiuczynski
Reviewed
On Thu, May 24, 2018 at 04:26:12PM -0400, Stefan Berger wrote:
Extend the existing auditing with auditing for the TPM emulator.
Signed-off-by: Stefan Berger
---
docs/auditlog.html.in | 2 +-
src/conf/domain_audit.c | 16 +---
2 files changed, 14 insertions(+), 4 deletions(-)
Rev
On Thu, May 24, 2018 at 04:26:13PM -0400, Stefan Berger wrote:
Fix the resrc field for the TPM passthrough case to show tpm.
This fixes the code to follow the documentation.
Signed-off-by: Stefan Berger
---
src/conf/domain_audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed
On Thu, May 24, 2018 at 04:26:14PM -0400, Stefan Berger wrote:
Signed-off-by: Stefan Berger
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redh
On Thu, May 24, 2018 at 04:26:11PM -0400, Stefan Berger wrote:
TPM 1.2 does not support a CRB interface but only TIS. So, in
this case we need to alert the user and request a change to the
XML rather than silently overwriting it.
Signed-off-by: Stefan Berger
---
src/conf/domain_conf.c | 15
On Thu, May 24, 2018 at 04:26:10PM -0400, Stefan Berger wrote:
swtpm_setup can be run for a TPM 2 in unprivileged mode assuming
XDG_CONFIG_HOME has been set and the necessary configuration files
have been put into that directory.
For current reference also see this link:
https://github.com/stef
On Thu, May 24, 2018 at 04:26:09PM -0400, Stefan Berger wrote:
This patch extends the AppArmor domain profile with file paths
the swtpm accesses for state, log, pid, and socket files.
Both, QEMU and swtpm, use this AppArmor profile.
Signed-off-by: Stefan Berger
Cc: Christian Ehrhardt
---
exam
On Thu, May 24, 2018 at 04:26:08PM -0400, Stefan Berger wrote:
Signed-off-by: Stefan Berger
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
htt
On Thu, May 24, 2018 at 04:26:07PM -0400, Stefan Berger wrote:
Add the external swtpm to the emulator cgroup so that upper limits of CPU
usage can be enforced on the emulated TPM.
To enable this we need to have the swtpm write its process id (pid) into a
file. We then read it from the file to co
On Thu, May 24, 2018 at 04:26:06PM -0400, Stefan Berger wrote:
This patch extends the TPM's device XML with TPM 2 support. This only works
for the emulator type backend and looks as follows:
The swtpm process now has --tpm2 as an additional parameter:
system_u:system_r:svirt_t:s0
On Thu, May 24, 2018 at 04:26:05PM -0400, Stefan Berger wrote:
In this patch we label the swtpm process with SELinux labels. We give it the
same label as the QEMU process has. We label its state directory and files
as well. We restore the old security labels once the swtpm has terminated.
The fi
On Thu, May 24, 2018 at 04:26:04PM -0400, Stefan Berger wrote:
This patch adds extensions to existing test cases and specific test cases
for the tpm-emulator.
Signed-off-by: Stefan Berger
Reviewed-by: John Ferlan
---
.../tpm-emulator.x86_64-latest.args| 33 +
On Thu, May 24, 2018 at 04:26:03PM -0400, Stefan Berger wrote:
This patch adds support for an external swtpm TPM emulator. The XML for
this type of TPM looks as follows:
The XML will currently only start a TPM 1.2.
Upon first start, libvirt will run `swtpm_setup`, which will simulate the
On Thu, May 24, 2018 at 04:26:02PM -0400, Stefan Berger wrote:
Implement functions for managing the storage of the external swtpm as well
as starting and stopping it. Also implement functions to use swtpm_setup,
which simulates the manufacturing of a TPM, which includes creation of
certificates f
On Thu, May 24, 2018 at 04:26:01PM -0400, Stefan Berger wrote:
Extend qemu_conf with user and group for running the tpm-emulator
and add directories to the configuration for the locations of the
log, state, and socket of the tpm-emulator.
Also add these new directories to the QEMU Makefile.inc.a
On Thu, May 24, 2018 at 04:26:00PM -0400, Stefan Berger wrote:
Extend the DAC and SELinux modules with support for the tpm-emulator.
We label the Unix socket that QEMU connects to after starting swtmp
with DAC and SELinux labels. We do not have to restore the labels in
this case since the tpm-emu
On Thu, May 24, 2018 at 04:25:59PM -0400, Stefan Berger wrote:
Implement virFileChownFiles() which changes file ownership of all
files in a given directory.
Signed-off-by: Stefan Berger
Reviewed-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 55 +
On Thu, May 24, 2018 at 04:25:58PM -0400, Stefan Berger wrote:
Extend the QEMU capabilities with tpm-emulator support.
Signed-off-by: Stefan Berger
Reviewed-by: John Ferlan
---
src/qemu/qemu_capabilities.c | 5 +
src/qemu/qemu_capabilities.h | 1 +
On Thu, May 24, 2018 at 04:25:57PM -0400, Stefan Berger wrote:
This patch adds support for an external swtpm TPM emulator. The XML for
this type of TPM looks as follows:
The XML will currently only define a TPM 1.2.
Extend the documentation.
Add a test case testing the XML parser and for
On Sat, Jun 02, 2018 at 12:57:39PM +0200, Michal Privoznik wrote:
When parsing domain XML the virCapsDomainData lookup is performed
in order to fill in missing def->os.arch and def->os.machine
strings. Well, when doing copy of already existing virDomainDef
we don't want any automagic fill in of d
ping for this series.
thanks a lot
bing
On 2018年05月29日 18:58, bing@intel.com wrote:
From: Bing Niu
This series is to introduce RDT memory bandwidth allocation support by extending
current virresctrl implementation.
The Memory Bandwidth Allocation (MBA) feature provides indirect and a
When parsing domain XML the virCapsDomainData lookup is performed
in order to fill in missing def->os.arch and def->os.machine
strings. Well, when doing copy of already existing virDomainDef
we don't want any automagic fill in of defaults (and those two
strings are going to be provided at this poin
50 matches
Mail list logo
