Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Andrea Bolognani
On Tue, 2018-06-05 at 18:03 +0100, Daniel P. Berrangé wrote: > We can't use docker on centos6 either and believe it or not the host > doesn't have hardware virt either. > > I could possibly setup libvirt lxc to run the jobs though. I believe running build jobs on libvirt.org in a CentOS 7 contain

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-05 Thread bing.niu
Hi Pavel, Thanks for your valuable inputs here. please see my respond. On 2018年06月05日 20:11, Pavel Hrdina wrote: On Tue, May 29, 2018 at 06:58:01PM +0800, bing@intel.com wrote: From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current virresct

Re: [libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

2018-06-05 Thread David Gibson
On Tue, Jun 05, 2018 at 04:05:38PM +0200, Andrea Bolognani wrote: > On Mon, 2018-06-04 at 11:33 +1000, David Gibson wrote: > > On Thu, May 24, 2018 at 07:34:25AM +0200, Peter Krempa wrote: > > > On Wed, May 23, 2018 at 19:09:59 +0200, Andrea Bolognani wrote: > > > > To be fair, it would perhaps mak

[libvirt] [PATCH] qemu: Fix double free in qemuDomainSecretAESClear

2018-06-05 Thread John Ferlan
Commit id 02b031a4 added a secondary path from which the incoming @secinfo would not be free'd until the private data was freed in qemuDomainStorageSourcePrivateDispose. However, by doing this the original intention to free @*secinfo afterwards is lost and thus the pass by value of the secinfo->s.

Re: [libvirt] [PATCH v2 0/2] nwfilter: fix IP address learning

2018-06-05 Thread John Ferlan
On 06/05/2018 12:42 PM, Daniel P. Berrangé wrote: > Changed in v2: > > - Use if() instead of switch() > > Daniel P. Berrangé (2): > nwfilter: fix IP address learning > nwfilter: directly use poll to wait for packets instead of pcap_next > > src/nwfilter/nwfilter_learnipaddr.c | 55 ++

[libvirt] [PATCH] docs: document mandatory signoffs in governance.html

2018-06-05 Thread Ján Tomko
Amend the paragraphs about no CLAs and implicit license agreements to mention mandatory Signed-off-by tags. Signed-off-by: Ján Tomko --- This is duplicating information, but I did not find a reasonable way to link the numbered list in hacking.html without making it look ugly. Very probably due to

Re: [libvirt] [perl PATCH 6/6] Modernize list of build deps to match actual required packages

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:44:01PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index dd26412..451af2

Re: [libvirt] [perl PATCH 5/6] Use %license for LICENSE file instead of %doc

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:44:00PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -- libvir-list mailing list libvi

Re: [libvirt] [perl PATCH 4/6] Remove obsolete %defattr statement

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:43:59PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com h

Re: [libvirt] [perl PATCH 3/6] Remove commented out cruft leftover from Module::Build conversion

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:43:58PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 1 file changed, 4 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.c

Re: [libvirt] [perl PATCH 2/6] Replace search.cpan.org with metacpan.org

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:43:57PM +0100, Daniel P. Berrangé wrote: The former is being shutdown very soon in favour of the latter Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.as

Re: [libvirt] [perl PATCH 1/6] Remove obsolete RPM group tag

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 06:43:56PM +0100, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com h

Re: [libvirt] [PATCH v2 2/2] docs: bhyve: document guest CPU topology feature

2018-06-05 Thread John Ferlan
On 05/29/2018 12:57 PM, Roman Bogorodskiy wrote: > Signed-off-by: Roman Bogorodskiy > --- > docs/drvbhyve.html.in | 16 > docs/news.xml | 9 + > 2 files changed, 25 insertions(+) > This should be split to keep the news.xml in its own patch. You could move t

Re: [libvirt] [PATCH v2 1/2] bhyve: add CPU topology support

2018-06-05 Thread John Ferlan
On 05/29/2018 12:57 PM, Roman Bogorodskiy wrote: > Recently, bhyve started supporting specifying guest CPU topology. > It looks this way: > > bhyve -c cpus=C,sockets=S,cores=C,threads=T ... > > The old behaviour with bhyve -c C, where C is a number of vCPUs, is > still supported. > > So if

[libvirt] [PATCH v7 8/9] remote: implement the remote protocol for launch security

2018-06-05 Thread Brijesh Singh
Add remote support for launch security info. Signed-off-by: Brijesh Singh Reviewed-by: Erik Skultety --- src/remote/remote_daemon_dispatch.c | 47 + src/remote/remote_driver.c | 40 +++ src/remote/remote_protocol.x

[libvirt] [PATCH v7 9/9] qemu: Add support to launch security info

2018-06-05 Thread Brijesh Singh
This patch implements the internal driver API for launch event into qemu driver. When SEV is enabled, execute 'query-sev-launch-measurement' to get the measurement of memory encrypted through launch sequence. Signed-off-by: Brijesh Singh --- src/qemu/qemu_driver.c | 69

[libvirt] [PATCH v7 7/9] libvirt: add new public API to get launch security info

2018-06-05 Thread Brijesh Singh
The API can be used outside the libvirt to get the launch security information. When SEV is enabled, the API can be used to get the measurement of the launch process. Signed-off-by: Brijesh Singh --- include/libvirt/libvirt-domain.h | 17 ++ src/driver-hypervisor.h | 8

[libvirt] [PATCH v7 3/9] expose virNodeGetSEVCapability API

2018-06-05 Thread Brijesh Singh
The API can be used by application to query the SEV capability. Signed-off-by: Brijesh Singh <> --- include/libvirt/libvirt-host.h | 42 + src/driver-hypervisor.h | 6 +++ src/libvirt-host.c | 48 +++ src/libvirt_public.syms

[libvirt] [PATCH v7 4/9] conf: introduce launch-security element in domain

2018-06-05 Thread Brijesh Singh
The launch-security element can be used to define the security model to use when launching a domain. Currently we support 'sev'. When 'sev' is used, the VM will be launched with AMD SEV feature enabled. SEV feature supports running encrypted VM under the control of KVM. Encrypted VMs have their pa

[libvirt] [PATCH v7 1/9] qemu: provide support to query the SEV capability

2018-06-05 Thread Brijesh Singh
QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the SEV capability from the qemu. Signed-off-by: Brijesh Singh --- src/conf/domain_capabilities.c | 1

[libvirt] [PATCH v7 2/9] conf: expose SEV feature in domain capabilities

2018-06-05 Thread Brijesh Singh
Extend hypervisor capabilities to include sev feature. When available, hypervisor supports launching an encrypted VM on AMD platform. The sev feature tag provides additional details like Platform Diffie-Hellman (PDH) key and certificate chain which can be used by the guest owner to establish a cryp

[libvirt] [PATCH v7 0/9] x86: Secure Encrypted Virtualization (AMD)

2018-06-05 Thread Brijesh Singh
This patch series provides support for launching an encrypted guest using AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV feature allows the memory conte

[libvirt] [PATCH v7 5/9] qemu/cgroup: add /dev/sev in shared devices list

2018-06-05 Thread Brijesh Singh
QEMU uses /dev/sev device while creating the SEV guest, lets add /dev/sev in the list of devices allowed to be accessed by the QEMU. Signed-off-by: Brijesh Singh <> Reviewed-by: Erik Skultety --- docs/drvqemu.html.in | 1 + src/qemu/qemu.conf | 2 +- src/qemu/qemu_c

[libvirt] [PATCH v7 3/9] libvirt-host: expose virNodeGetSEVCapability API

2018-06-05 Thread Brijesh Singh
The API can be used by application to get the SEV capability (which includes platform certificate chain and other releated information) Signed-off-by: Brijesh Singh <> --- include/libvirt/libvirt-host.h | 42 + src/driver-hypervisor.h | 6 +++ src/libvirt-host.c

[libvirt] [PATCH v7 6/9] qemu: add support to launch SEV guest

2018-06-05 Thread Brijesh Singh
QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted VMs on AMD platform using SEV feature. The various inputs required to launch SEV guest is provided through the tag. A typical SEV guest launch command line looks like this: # $QEMU ...\ -object sev-guest,id=sev0,cbitpos=

Re: [libvirt] [PATCH 1/3] util: cleanup: using virGetLastErrorMessage instead of err->message

2018-06-05 Thread Ján Tomko
On Sat, May 05, 2018 at 01:04:19PM +0100, ramyelkest wrote: Signed-off-by: Ramy Elkest There is something odd with your git setup. Did you type the signoff manually? Please set the name in your git config [0] to your legal name. That way you can certify your compliance with the DCO [1] by add

[libvirt] [PATCH] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-05 Thread Daniel P . Berrangé
The container images provided by Travis only support Ubuntu 14.04, however, Travis has ability to run docker, which allows the build script to use arbitrary OS images. This takes advantage of that to convert the build over to Ubuntu 16.04 and 18.04 This is using the official Ubuntu provided images

[libvirt] [perl PATCH 6/6] Modernize list of build deps to match actual required packages

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index dd26412..451af27 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@

[libvirt] [perl PATCH 5/6] Use %license for LICENSE file instead of %doc

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 35f8e01..dd26412 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -66,7 +66,8 @@ virtualization co

[libvirt] [perl PATCH 2/6] Replace search.cpan.org with metacpan.org

2018-06-05 Thread Daniel P . Berrangé
The former is being shutdown very soon in favour of the latter Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index b171826..928c7cf 100644 --- a/perl-Sys-Virt.spec.

[libvirt] [perl PATCH 1/6] Remove obsolete RPM group tag

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index e7b4044..b171826 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -31,7 +31,6 @@ Version:@VERSION@ Release:

[libvirt] [perl PATCH 4/6] Remove obsolete %defattr statement

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 341e40c..35f8e01 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -66,7 +66,6 @@ virtualization containers to be mana

[libvirt] [perl PATCH 0/6] Update RPM spec to match latest Fedora

2018-06-05 Thread Daniel P . Berrangé
Syncing changes back from Fedora to follow best practice Daniel P. Berrangé (6): Remove obsolete RPM group tag Replace search.cpan.org with metacpan.org Remove commented out cruft leftover from Module::Build conversion Remove obsolete %defattr statement Use %license for LICENSE file inst

[libvirt] [perl PATCH 3/6] Remove commented out cruft leftover from Module::Build conversion

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 928c7cf..341e40c 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -60,10 +60,6 @@ virtualization containers to be

[libvirt] [PATCH] tests: use a fixed NBD TLS certificate path

2018-06-05 Thread Daniel P . Berrangé
The default NBD TLS certificate path varies based on prefix given to configure, causing tests to fail depending on build options. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for CI tests/qemuxml2argvdata/disk-drive-network-tlsx509.args | 4 ++-- tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 06:50:53PM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 14:38 +0200, Michal Privoznik wrote: > > On 06/05/2018 02:04 PM, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 01:55:54PM +0200, Michal Privoznik wrote: > > > > We are building with GnuTLS everywhere

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Andrea Bolognani
On Tue, 2018-06-05 at 14:38 +0200, Michal Privoznik wrote: > On 06/05/2018 02:04 PM, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 01:55:54PM +0200, Michal Privoznik wrote: > > > We are building with GnuTLS everywhere because GnuTLS is widely > > > available. Also, it is desirable to prefer

[libvirt] [PATCH v2 2/2] nwfilter: directly use poll to wait for packets instead of pcap_next

2018-06-05 Thread Daniel P . Berrangé
When a QEMU VM shuts down its TAP device gets deleted while nwfilter IP address learning thread is still capturing packets. It is seen that with TPACKET_V3 support in libcap, the pcap_next() call will not always exit its poll() when the NIC is removed. This prevents the learning thread from exiting

[libvirt] [PATCH v2 0/2] nwfilter: fix IP address learning

2018-06-05 Thread Daniel P . Berrangé
Changed in v2: - Use if() instead of switch() Daniel P. Berrangé (2): nwfilter: fix IP address learning nwfilter: directly use poll to wait for packets instead of pcap_next src/nwfilter/nwfilter_learnipaddr.c | 55 ++--- src/nwfilter/nwfilter_learnipaddr.h | 2 +-

[libvirt] [PATCH v2 1/2] nwfilter: fix IP address learning

2018-06-05 Thread Daniel P . Berrangé
In a previous commit: commit d4bf8f415074759baf051644559e04fe7f8b Author: Daniel P. Berrangé Date: Wed Feb 14 09:43:59 2018 + nwfilter: handle missing switch enum cases Ensure all enum cases are listed in switch statements, or cast away enum type in places where we d

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 07:16:56PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > eg old OS versions that only work with PC, or more commonly pre-existing > > cloud disk images that were built against PC can't be assumed to just > > work a

Re: [libvirt] [PATCH v3 2/4] qemu: support passing pre-opened UNIX socket listen FD

2018-06-05 Thread Daniel P . Berrangé
On Thu, May 24, 2018 at 04:50:36PM -0500, Eric Blake wrote: > On 05/17/2018 08:40 AM, Daniel P. Berrangé wrote: > > There is a race condition when spawning QEMU where libvirt has spawned > > QEMU but the monitor socket is not yet open. Libvirt has to repeatedly > > try to connect() to QEMU's monito

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > eg old OS versions that only work with PC, or more commonly pre-existing > cloud disk images that were built against PC can't be assumed to just > work against q35, even if the OS in the image supports it. I don't understand tha

Re: [libvirt] [PATCH v1 01/18] add macros for implementing automatic cleanup functionality

2018-06-05 Thread Erik Skultety
On Sun, Jun 03, 2018 at 01:41:59PM +0530, Sukrit Bhatnagar wrote: > New macros are added to src/util/viralloc.h which help in > adding cleanup attribute to variable declarations. > > Signed-off-by: Sukrit Bhatnagar If you recall the recent RFC thread [1], I agreed with Pavel that we should introd

Re: [libvirt] [PATCH 1/2] vircgroup: Add virCgroupSetupBlkiotune()

2018-06-05 Thread Fabiano Fidêncio
On Tue, Jun 5, 2018 at 4:16 PM, Michal Privoznik wrote: > On 06/03/2018 08:09 PM, Fabiano Fidêncio wrote: >> virCgroupSetupBlkiotune() has been introduced in order to remove the >> code duplication present between virLXCCgroupSetupBlkioTune() and >> qemuSetupBlkioCgroup(). >> >> Signed-off-by: Fab

Re: [libvirt] [PATCH v1 17/18] use VIR_AUTOFREE in src/util/virfirewall.c

2018-06-05 Thread Erik Skultety
On Sun, Jun 03, 2018 at 01:42:15PM +0530, Sukrit Bhatnagar wrote: > Modify code to use VIR_AUTOFREE macro wherever required. > > Signed-off-by: Sukrit Bhatnagar > --- > src/util/virfirewall.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) ... > @@ -808,12 +805,11 @@ virFi

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Pavel Hrdina
On Tue, Jun 05, 2018 at 03:07:04PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > > > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > > > On Tue, Jun 05, 201

Re: [libvirt] [PATCH 1/2] vircgroup: Add virCgroupSetupBlkiotune()

2018-06-05 Thread Michal Privoznik
On 06/03/2018 08:09 PM, Fabiano Fidêncio wrote: > virCgroupSetupBlkiotune() has been introduced in order to remove the > code duplication present between virLXCCgroupSetupBlkioTune() and > qemuSetupBlkioCgroup(). > > Signed-off-by: Fabiano Fidêncio > --- > src/libvirt_private.syms | 1 + > src/

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Pavel Hrdina
On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 05, 201

Re: [libvirt] [PATCH v1 14/18] use VIR_AUTOFREE in src/util/virfile.c

2018-06-05 Thread Erik Skultety
On Sun, Jun 03, 2018 at 01:42:12PM +0530, Sukrit Bhatnagar wrote: > Modify code to use VIR_AUTOFREE macro wherever required. > > Signed-off-by: Sukrit Bhatnagar > --- > src/util/virfile.c | 303 > + > 1 file changed, 99 insertions(+), 204 delet

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 05, 201

Re: [libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

2018-06-05 Thread Andrea Bolognani
On Mon, 2018-06-04 at 11:33 +1000, David Gibson wrote: > On Thu, May 24, 2018 at 07:34:25AM +0200, Peter Krempa wrote: > > On Wed, May 23, 2018 at 19:09:59 +0200, Andrea Bolognani wrote: > > > To be fair, it would perhaps make sense to perform the conversion > > > directly inside QEMU, in order to

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > > > (CCing libvir-list)

Re: [libvirt] [PATCH 0/3] travis: Stop performing Ubuntu builds

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 03:57:03PM +0200, Andrea Bolognani wrote: > They're all failing at the moment anyway. > > We'll get the Ubuntu coverage back as soon as we add Ubuntu > builders to the CentOS CI environment. I've got fixes testing for travis to make it use both 16.04 and 18.04 for builds.

Re: [libvirt] [PATCH] qemu: Fix detaching from persistent def in qemuDomainDetachDeviceAliasLiveAndConfig

2018-06-05 Thread Michal Privoznik
On 06/05/2018 09:38 AM, Peter Krempa wrote: > The code that detaches the device from persistent definition copies the > persistent definition first so that it can easily be rolled back. The > actual detaching is then made in the copy which is assigned back on > success (if the live operation succee

[libvirt] [PATCH 2/3] travis: Remove matrix

2018-06-05 Thread Andrea Bolognani
Now that we're only performing macOS builds on Travis CI, we no longer need to maintain a matrix and can flatten the configuration. Signed-off-by: Andrea Bolognani --- .travis.yml | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/.travis.yml b/

[libvirt] [PATCH 3/3] travis: Minor style tweaks

2018-06-05 Thread Andrea Bolognani
Group related settings together and fix indentation. Signed-off-by: Andrea Bolognani --- .travis.yml | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 91838e3651..a72a6c6c42 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,16 +1,15

[libvirt] [PATCH 1/3] travis: Stop performing Ubuntu builds

2018-06-05 Thread Andrea Bolognani
As of 60d9ad6f1e42, we require GnuTLS 3.2 to build libvirt; the only Linux environment available on Travis CI (Ubuntu 14.04 LTS), however, ships with an older GnuTLS version and thus the build cannot succeed. Let's only perform macOS builds on Travis CI. Signed-off-by: Andrea Bolognani --- .tra

[libvirt] [PATCH 0/3] travis: Stop performing Ubuntu builds

2018-06-05 Thread Andrea Bolognani
They're all failing at the moment anyway. We'll get the Ubuntu coverage back as soon as we add Ubuntu builders to the CentOS CI environment. Andrea Bolognani (3): travis: Stop performing Ubuntu builds travis: Remove matrix travis: Minor style tweaks .travis.yml | 118 -

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Pavel Hrdina
On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > > (CCing libvir-list) > > > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berr

Re: [libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

2018-06-05 Thread Michal Privoznik
On 06/05/2018 01:41 PM, Tomáš Golembiovský (by way of Tomáš Golembiovský ) wrote: > Signed-off-by: Tomáš Golembiovský > --- > include/libvirt/libvirt-domain.h | 9 - > src/qemu/qemu_monitor_json.c | 2 ++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/include/lib

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > > (CCing libvir-list) > > > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berr

Re: [libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

2018-06-05 Thread Erik Skultety
On Tue, Jun 05, 2018 at 03:36:14PM +0200, Michal Privoznik wrote: > On 06/05/2018 03:08 PM, Erik Skultety wrote: > > On Tue, Jun 05, 2018 at 01:41:02PM +0200, Tomáš Golembiovský wrote: > >> Signed-off-by: Tomáš Golembiovský > >> --- > >> include/libvirt/libvirt-domain.h | 9 - > >> src/qe

Re: [libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

2018-06-05 Thread Michal Privoznik
On 06/05/2018 03:08 PM, Erik Skultety wrote: > On Tue, Jun 05, 2018 at 01:41:02PM +0200, Tomáš Golembiovský wrote: >> Signed-off-by: Tomáš Golembiovský >> --- >> include/libvirt/libvirt-domain.h | 9 - >> src/qemu/qemu_monitor_json.c | 2 ++ >> 2 files changed, 10 insertions(+), 1 del

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > (CCing libvir-list) > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann w

Re: [libvirt] [PATCH v1 12/18] use VIR_AUTOFREE in src/util/virdbus.c

2018-06-05 Thread Erik Skultety
On Sun, Jun 03, 2018 at 01:42:10PM +0530, Sukrit Bhatnagar wrote: > Modify code to use VIR_AUTOFREE macro wherever required. > > Signed-off-by: Sukrit Bhatnagar > --- > src/util/virdbus.c | 28 +++- > 1 file changed, 7 insertions(+), 21 deletions(-) > > diff --git a/src/ut

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > (CCing libvir-list) > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Add to that shortcuts like -cdrom > > > >

Re: [libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

2018-06-05 Thread Erik Skultety
On Tue, Jun 05, 2018 at 01:41:02PM +0200, Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský > --- > include/libvirt/libvirt-domain.h | 9 - > src/qemu/qemu_monitor_json.c | 2 ++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/include/libvirt/libvirt-do

[libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Eduardo Habkost
(CCing libvir-list) On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Add to that shortcuts like -cdrom > > > > stop working, > > > > > > Maybe is fixable. > > > > Already fixed for ages.

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Michal Privoznik
On 06/05/2018 02:04 PM, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 01:55:54PM +0200, Michal Privoznik wrote: >> We are building with GnuTLS everywhere because GnuTLS is widely >> available. Also, it is desirable to prefer cryptographically >> strong PRNG over "/dev/urandom" which is just a

Re: [libvirt] [PATCH v8 00/18] Add support for TPM emulator (for 4.5)

2018-06-05 Thread Stefan Berger
On 06/05/2018 07:28 AM, Stefan Berger wrote: On 06/05/2018 01:03 AM, Marc Hartmayer wrote: On Thu, May 24, 2018 at 10:25 PM +0200, Stefan Berger wrote: This series of patches adds support for the TPM emulator backend that is available in QEMU and based on swtpm + libtpms. It allows to attach

Re: [libvirt] [PATCH v2 4/5] tests: Always build TLS related tests

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:55:57PM +0200, Michal Privoznik wrote: > Since GnuTLS is required there is no way to go with !WITH_GNUTLS > branch and just distribute these files. > > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 12 ++-- > 1 file changed, 2 insertions(+), 10 de

Re: [libvirt] [PATCH v2 3/5] src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:55:56PM +0200, Michal Privoznik wrote: > Now that GnuTLS is required these symbols are going to be present > all the time. > > Signed-off-by: Michal Privoznik > --- > src/Makefile.am | 6 -- > src/libvirt_gnutls.syms | 31 --- >

Re: [libvirt] [PATCH v2 2/5] src: Always build virnettlscontext into libvirt-net-rpc.la

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:55:55PM +0200, Michal Privoznik wrote: > Since GnuTLS is required there is no way to go with !WITH_GNUTLS > branch and just distribute these files. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_gnutls.syms | 17 - > src/libvirt_remote.syms | 1

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-05 Thread Pavel Hrdina
On Tue, May 29, 2018 at 06:58:01PM +0800, bing@intel.com wrote: > From: Bing Niu > > This series is to introduce RDT memory bandwidth allocation support by > extending > current virresctrl implementation. > > The Memory Bandwidth Allocation (MBA) feature provides indirect and > approximate

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:55:54PM +0200, Michal Privoznik wrote: > We are building with GnuTLS everywhere because GnuTLS is widely > available. Also, it is desirable to prefer cryptographically > strong PRNG over "/dev/urandom" which is just a fallback. > > Signed-off-by: Michal Privoznik > ---

[libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Michal Privoznik
We are building with GnuTLS everywhere because GnuTLS is widely available. Also, it is desirable to prefer cryptographically strong PRNG over "/dev/urandom" which is just a fallback. Signed-off-by: Michal Privoznik --- configure.ac | 2 -- m4/virt-gnutls.m4 | 4 2 files changed, 6 dele

[libvirt] [PATCH v2 3/5] src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms

2018-06-05 Thread Michal Privoznik
Now that GnuTLS is required these symbols are going to be present all the time. Signed-off-by: Michal Privoznik --- src/Makefile.am | 6 -- src/libvirt_gnutls.syms | 31 --- src/libvirt_remote.syms | 8 3 files changed, 8 insertions(+), 37 delet

[libvirt] [PATCH v2 4/5] tests: Always build TLS related tests

2018-06-05 Thread Michal Privoznik
Since GnuTLS is required there is no way to go with !WITH_GNUTLS branch and just distribute these files. Signed-off-by: Michal Privoznik --- tests/Makefile.am | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1ce3dbb50f.

[libvirt] [PATCH v2 5/5] src: Drop most of #ifdef WITH_GNUTLS

2018-06-05 Thread Michal Privoznik
Now that GnuTLS is a requirement, we can drop a lot of conditionally built code. However, not all ifdef-s can go because we still want libvirt_setuid to build without gnutls. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- src/locking/lock_daemon.c | 4 --- src/lo

[libvirt] [PATCH v2 2/5] src: Always build virnettlscontext into libvirt-net-rpc.la

2018-06-05 Thread Michal Privoznik
Since GnuTLS is required there is no way to go with !WITH_GNUTLS branch and just distribute these files. Signed-off-by: Michal Privoznik --- src/libvirt_gnutls.syms | 17 - src/libvirt_remote.syms | 17 + src/rpc/Makefile.inc.am | 14 ++ 3 files change

[libvirt] [PATCH v2 0/5] Require GnuTLS

2018-06-05 Thread Michal Privoznik
v2 of: diff to v1: - Reworded commit message of 1/3 - Broken 2/3 into three separate patches: 1) removing WITH_GNUTLS conditional from src/ 2) removing libvirt_gnutls.syms 3) removing WITH_GNUTLS conditional from tests/ Michal Privoznik (5): configure: Require GnuTLS src: Always build

Re: [libvirt] [PATCH 5/8] qemu: implement vsock hotplug

2018-06-05 Thread Ján Tomko
On Tue, Jun 05, 2018 at 07:40:25AM -0400, John Ferlan wrote: [...] + cleanup: +    if (ret < 0) { +    virErrorPreserveLast(&originalError); +    if (releaseaddr) +    qemuDomainReleaseDeviceAddress(vm, &vsock->info, NULL); +    virErrorRestore(&originalError); +    } + +  

[libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

2018-06-05 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský --- include/libvirt/libvirt-domain.h | 9 - src/qemu/qemu_monitor_json.c | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index da773b76cb..b96c018a90 100644 ---

Re: [libvirt] [PATCH 5/8] qemu: implement vsock hotplug

2018-06-05 Thread John Ferlan
[...] >> + cleanup: >> +    if (ret < 0) { >> +    virErrorPreserveLast(&originalError); >> +    if (releaseaddr) >> +    qemuDomainReleaseDeviceAddress(vm, &vsock->info, NULL); >> +    virErrorRestore(&originalError); >> +    } >> + >> +    virDomainVsockDefFree(vsock); > >

Re: [libvirt] [PATCH v8 00/18] Add support for TPM emulator (for 4.5)

2018-06-05 Thread Stefan Berger
On 06/05/2018 01:03 AM, Marc Hartmayer wrote: On Thu, May 24, 2018 at 10:25 PM +0200, Stefan Berger wrote: This series of patches adds support for the TPM emulator backend that is available in QEMU and based on swtpm + libtpms. It allows to attach a TPM 1.2 or 2 to a QEMU VM. sVirt labels are

Re: [libvirt] [PATCH 1/3] configure: Require GnuTLS

2018-06-05 Thread Peter Krempa
On Tue, Jun 05, 2018 at 13:17:46 +0200, Michal Privoznik wrote: > On 06/05/2018 11:43 AM, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 10:45:55AM +0200, Michal Privoznik wrote: > >> We are building with GnuTLS everywhere because GnuTLS is widely > >> available. In addition after recent pat

Re: [libvirt] [PATCH v1 08/18] use VIR_AUTOFREE in src/util/vircgroup.c

2018-06-05 Thread Erik Skultety
On Sun, Jun 03, 2018 at 01:42:06PM +0530, Sukrit Bhatnagar wrote: > Modify code to use VIR_AUTOFREE macro wherever required. > > Signed-off-by: Sukrit Bhatnagar > --- > src/util/vircgroup.c | 526 > ++- > 1 file changed, 179 insertions(+), 347 dele

Re: [libvirt] [PATCH 2/3] build: Build gnutls related sources unconditionally

2018-06-05 Thread Michal Privoznik
On 06/05/2018 11:44 AM, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 10:45:56AM +0200, Michal Privoznik wrote: >> Now that GnuTLS is required these source files must be compiled >> in. >> >> Signed-off-by: Michal Privoznik >> --- >> src/Makefile.am | 7 +-- >> src/rpc/Makefile

Re: [libvirt] [PATCH 1/3] configure: Require GnuTLS

2018-06-05 Thread Michal Privoznik
On 06/05/2018 11:43 AM, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 10:45:55AM +0200, Michal Privoznik wrote: >> We are building with GnuTLS everywhere because GnuTLS is widely >> available. In addition after recent patches Libvirt relies on >> GnuTLS' PRNG. > > This second sentance isn't

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:10:45PM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 11:42 +0100, Daniel P. Berrangé wrote: > > On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > > > Instead of having to specify this separately for every > > > guest due to minor differences in

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Andrea Bolognani
On Tue, 2018-06-05 at 11:42 +0100, Daniel P. Berrangé wrote: > On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > > Instead of having to specify this separately for every > > guest due to minor differences in the environment, figure > > it out at login time by asking Perl itself fo

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > Instead of having to specify this separately for every > guest due to minor differences in the environment, figure > it out at login time by asking Perl itself for the > information we need. We still have the problem that any time

Re: [libvirt] [RFC PATCH] travis: require libgnutls28-dev

2018-06-05 Thread Pavel Hrdina
On Tue, Jun 05, 2018 at 09:37:55AM +0200, Ján Tomko wrote: > Since commit we require GnuTLS >= 3.2.0. > Install the aptly-named libgnutls28-dev package > instead of plain libgnutls-dev. > > Signed-off-by: Ján Tomko > --- > RFC, since I haven't even started to figure out how to test it. > > Expo

Re: [libvirt] [jenkins-ci PATCH 5/5] guests: Move remaining paths out of the inventory

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:27PM +0200, Andrea Bolognani wrote: > None of these ever needed per-host overrides, so we can > avoid one layer of indirection and store them directly in > the shell profile. > > Signed-off-by: Andrea Bolognani > --- > guests/group_vars/all/main.yml | 11 ---

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > Instead of having to specify this separately for every > guest due to minor differences in the environment, figure > it out at login time by asking Perl itself for the > information we need. > > Signed-off-by: Andrea Bolognani >

Re: [libvirt] [jenkins-ci PATCH 4/5] guests: Make PYTHONPATH dynamic

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:26PM +0200, Andrea Bolognani wrote: > Instead of having to specify this separately for every > guest due to minor differences in the environment, figure > it out at login time by asking Python itself for the > information we need. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Remove distinction between files and templates

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:24PM +0200, Andrea Bolognani wrote: > The main difference between files and templates is that the > former can can be uploaded as-is, while the latter has to > go through Jinja2 first. > > Since the overhead of template processing is negligible, and > there's a fair c

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Add .j2 extension to existing templates

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:23PM +0200, Andrea Bolognani wrote: > By convention, Jinja2 templates should use the .j2 extension. > > Signed-off-by: Andrea Bolognani > --- > guests/tasks/users.yml | 2 +- > guests/templates/{bash_profile => bash_profile.j2} | 0 > gue

Re: [libvirt] [jenkins-ci PATCH] guests: Fix os_version for development branches

2018-06-05 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 03:50:28PM +0200, Andrea Bolognani wrote: > We currently know about three development branches: Fedora > Rawhide, Debian sid and FreeBSD -CURRENT. > > For all three, we use the name of the development branch in > the guest name; however, the value of os_version is not set >

  1   2   >